add_dog.php ➔ sire()

Complexity

Conditions	38
Paths	> 20000

Size

Total Lines	236
Code Lines	155

Duplication

Lines	66
Ratio	27.97 %

Importance

Changes

0

<?php
function sire()

sire uses the super-global variable $_POST which is generally not recommended.

sire uses the super-global variable $_GET which is generally not recommended.

sire uses the super-global variable $_FILES which is generally not recommended.

sire uses the super-global variable $GLOBALS which is generally not recommended.

{
    global $xoopsTpl, $xoopsUser, $xoopsDB;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    //get module configuration
    $moduleHandler = xoops_getHandler('module');
    $module        = $moduleHandler->getByDirname('pedigree');
    $configHandler = xoops_getHandler('config');
    $moduleConfig  = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
    $empty         = array(); // an empty array

    //check for access
    if (empty($xoopsUser)) {
        redirect_header('javascript:history.go(-1)', 3, _NOPERM . '<br />' . _MA_PEDIGREE_REGIST);
    }
    $user = isset($_POST['user']) ? $_POST['user'] : null;
    if (empty($random)) {

The variable $random seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

        $random = isset($_POST['random']) ? $_POST['random'] : null;
    }
    if (isset($_GET['random'])) {
        $random = $_GET['random'];
    }
    if (empty($st)) {

The variable $st seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

        $st = 0;
    }
    if (isset($_GET['st'])) {
        $st = $_GET['st'];
    }
    $name = isset($_POST['NAAM']) ? $_POST['NAAM'] : null;
    $roft = isset($_POST['roft']) ? $_POST['roft'] : null;

    $id_owner   = isset($_POST['id_owner']) ? $_POST['id_owner'] : null;
    $id_breeder = isset($_POST['id_breeder']) ? $_POST['id_breeder'] : null;

    $picturefield = isset($_FILES['photo']) ? $_FILES['photo']['name'] : null; // $_FILES['photo']['name'];

89% of this comment could be valid code. Did you maybe forget this after debugging?

    if (empty($picturefield) || $picturefield == '') {
        $foto = '';
    } else {
        $foto = PedigreeUtilities::uploadPicture(0);
    }
    $numpicturefield = 1;

    //make the redirect
    if (!isset($_GET['r'])) {
        if ($_POST['NAAM'] == '') {
            redirect_header('add_dog.php', 1, _MA_PEDIGREE_ADD_NAMEPLZ);
        }
        //create animal object
        $animal = new PedigreeAnimal();
        //test to find out how many user fields there are..
        $fields = $animal->getNumOfFields();
        sort($fields); //sort by ID not by order
        $usersql = '';
        for ($i = 0, $iMax = count($fields); $i < $iMax; ++$i) {
            $userField   = new Field($fields[$i], $animal->getConfig());
            $fieldType   = $userField->getSetting('FieldType');
            $fieldObject = new $fieldType($userField, $animal);

$fieldObject is not used, you could remove the assignment.

            if ($userField->isActive()) {
                //check if _FILES variable exists for user picturefield
                $currentfield = 'user' . $fields[$i];
                $picturefield = $_FILES[$currentfield]['name'];
                if ($fieldType === 'Picture' && (!empty($picturefield) || $picturefield != '')) {
                    $userpicture = PedigreeUtilities::uploadPicture($numpicturefield);
                    $usersql .= ",'" . $userpicture . "'";
                    ++$numpicturefield;
                } elseif ($userField->isLocked()) {
                    //userfield is locked, substitute default value
                    $usersql .= ",'" . $userField->defaultvalue . "'";

The property defaultvalue does not seem to exist in Field.

                } else {
                    //echo $fieldType.":".$i.":".$fields[$i]."<br />";

65% of this comment could be valid code. Did you maybe forget this after debugging?

                    $usersql .= ",'" . PedigreeUtilities::unHtmlEntities($_POST['user' . $fields[$i]]) . "'";
                }
            } else {
                $usersql .= ",''";
            }
            //echo $fields[$i]."<br/>";

78% of this comment could be valid code. Did you maybe forget this after debugging?

        }

        //insert into pedigree_temp
        //        $query = 'INSERT INTO ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp') . " VALUES ('" . $random . "','" . PedigreeUtilities::unHtmlEntities($name) . "','" . $id_owner . "','" . $id_breeder . "','" . $user . "','" . $roft . "','','','" . $foto . "', ''" . $usersql . ')';
        $query = 'INSERT INTO ' . $GLOBALS['xoopsDB']->prefix('pedigree_temp') . " VALUES ('" . $GLOBALS['xoopsDB']->escape($random) . "','" . $GLOBALS['xoopsDB']->escape(unHtmlEntities($name)) . "','" . $GLOBALS['xoopsDB']->escape($id_owner) . "','" . $GLOBALS['xoopsDB']->escape($id_breeder) . "','" . $GLOBALS['xoopsDB']->escape($user) . "','" . $GLOBALS['xoopsDB']->escape($roft) . "','','','" . $GLOBALS['xoopsDB']->escape($foto) . "', ''" . $usersql . ')';
        //echo $query; die();

78% of this comment could be valid code. Did you maybe forget this after debugging?

        $GLOBALS['xoopsDB']->query($query);
        redirect_header('add_dog.php?f=sire&random=' . $random . '&st=' . $st . '&r=1&l=a', 1, strtr(_MA_PEDIGREE_ADD_SIREPLZ, array('[father]' => $moduleConfig['father'])));
    }
    //find letter on which to start else set to 'a'
    if (isset($_GET['l'])) {
        $l = $_GET['l'];
    } else {
        $l = 'a';
    }
    //assign sire to template
    $xoopsTpl->assign('sire', '1');
    //create list of males dog to select from
    $perp = $moduleConfig['perpage'];
    //count total number of dogs
    $numdog = 'SELECT count(ID) from ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE roft='0' and NAAM LIKE '" . $l . "%'";
    $numres = $GLOBALS['xoopsDB']->query($numdog);
    //total number of dogs the query will find
    list($numresults) = $GLOBALS['xoopsDB']->fetchRow($numres);
    //total number of pages
    $numpages = floor($numresults / $perp) + 1;
    if (($numpages * $perp) == ($numresults + $perp)) {
        --$numpages ;
    }
    //find current page
    $cpage = floor($st / $perp) + 1;
    //create alphabet
    $pages = '';
    for ($i = 65; $i <= 90; ++$i) {

This code seems to be duplicated across your project.

        if ($l == chr($i)) {
            $pages .= "<b><a href=\"add_dog.php?f=sire&r=1&random=" . $random . '&l=' . chr($i) . "\">" . chr($i) . '</a></b>&nbsp;';
        } else {
            $pages .= "<a href=\"add_dog.php?f=sire&r=1&random=" . $random . '&l=' . chr($i) . "\">" . chr($i) . '</a>&nbsp;';
        }
    }
    $pages .= '-&nbsp;';
    $pages .= "<a href=\"add_dog.php?f=sire&r=1&random=" . $random . "&l=Ã…\">Ã…</a>&nbsp;";
    $pages .= "<a href=\"add_dog.php?f=sire&r=1&random=" . $random . "&l=Ö\">Ö</a>&nbsp;";
    //create linebreak
    $pages .= '<br />';
    //create previous button
    if ($numpages > 1) {
        if ($cpage > 1) {
            $pages .= "<a href=\"add_dog.php?f=sire&r=1&l=" . $l . '&random=' . $random . '&st=' . ($st - $perp) . "\">" . _MA_PEDIGREE_PREVIOUS . '</a>&nbsp;&nbsp';
        }
    }
    //create numbers
    for ($x = 1; $x < ($numpages + 1); ++$x) {
        //create line break after 20 number
        if (($x % 20) == 0) {
            $pages .= '<br />';
        }
        if ($x != $cpage) {
            $pages .= "<a href=\"add_dog.php?f=sire&r=1&l=" . $l . '&random=' . $random . '&st=' . ($perp * ($x - 1)) . "\">" . $x . '</a>&nbsp;&nbsp;';
        } else {
            $pages .= $x . '&nbsp;&nbsp';
        }
    }
    //create next button
    if ($numpages > 1) {
        if ($cpage < $numpages) {
            $pages .= "<a href=\"add_dog.php?f=sire&r=1&l=" . $l . '&random=' . $random . '&st=' . ($st + $perp) . "\">" . _MA_PEDIGREE_NEXT . '</a>&nbsp;&nbsp';
        }
    }

    //query
    $queryString = 'SELECT * from ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE roft = '0' and NAAM like '" . $l . "%'ORDER BY NAAM LIMIT " . $st . ', ' . $perp;
    $result      = $GLOBALS['xoopsDB']->query($queryString);

    $animal = new PedigreeAnimal();
    //test to find out how many user fields there are...
    $fields       = $animal->getNumOfFields();
    $numofcolumns = 1;
    $columns[]    = array('columnname' => 'Name');

$columns was never initialized. Although not strictly required by PHP, it is generally a good practice to add $columns = array(); before regardless.

    for ($i = 0, $iMax = count($fields); $i < $iMax; ++$i) {

This code seems to be duplicated across your project.

        $userField   = new Field($fields[$i], $animal->getConfig());
        $fieldType   = $userField->getSetting('FieldType');
        $fieldObject = new $fieldType($userField, $animal);
        //create empty string
        $lookupvalues = '';
        if ($userField->isActive() && $userField->inList()) {
            if ($userField->hasLookup()) {
                $lookupvalues = $userField->lookupField($fields[$i]);
                //debug information
                //print_r($lookupvalues);
            }
            $columns[] = array('columnname' => $fieldObject->fieldname, 'columnnumber' => $userField->getId(), 'lookupval' => $lookupvalues);
            ++$numofcolumns;
            unset($lookupvalues);
        }
    }

    for ($i = 1; $i < $numofcolumns; ++$i) {

This code seems to be duplicated across your project.

        $empty[] = array('value' => '');
    }
    $dogs [] = array(

$dogs was never initialized. Although not strictly required by PHP, it is generally a good practice to add $dogs = array(); before regardless.

        'id'          => '0',
        'name'        => '',
        'gender'      => '',
        'link'        => "<a href=\"add_dog.php?f=dam&random=" . $random . "&selsire=0\">" . strtr(_MA_PEDIGREE_ADD_SIREUNKNOWN, array('[father]' => $moduleConfig['father'])) . '</a>',
        'colour'      => '',
        'number'      => '',
        'usercolumns' => $empty
    );

    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {

This code seems to be duplicated across your project.

        //create picture information
        if ($row['foto'] != '') {
            $camera = " <img src=\"assets/images/camera.png\">";
        } else {
            $camera = '';
        }
        $name = stripslashes($row['NAAM']) . $camera;
        //empty array
        unset($columnvalue);
        //fill array
        for ($i = 1; $i < $numofcolumns; ++$i) {
            $x = $columns[$i]['columnnumber'];
            if (is_array($columns[$i]['lookupval'])) {
                foreach ($columns[$i]['lookupval'] as $key => $keyvalue) {
                    if ($key == $row['user' . $x]) {
                        $value = $keyvalue['value'];
                    }
                }
                //debug information
                ///echo $columns[$i]['columnname']."is an array !";

77% of this comment could be valid code. Did you maybe forget this after debugging?

            } //format value - cant use object because of query count
            elseif (0 === strpos($row['user' . $x], 'http://')) {
                $value = "<a href=\"" . $row['user' . $x] . "\">" . $row['user' . $x] . '</a>';
            } else {
                $value = $row['user' . $x];
            }
            $columnvalue[] = array('value' => $value);

$columnvalue was never initialized. Although not strictly required by PHP, it is generally a good practice to add $columnvalue = array(); before regardless.

The variable $value does not seem to be defined for all execution paths leading up to this point.

        }
        $dogs[] = array(
            'id'          => $row['Id'],
            'name'        => $name,
            'gender'      => '<img src="assets/images/male.gif">',
            'link'        => "<a href=\"add_dog.php?f=dam&random=" . $random . '&selsire=' . $row['Id'] . "\">" . $name . '</a>',
            'colour'      => '',
            'number'      => '',
            'usercolumns' => $columnvalue

The variable $columnvalue does not seem to be defined for all execution paths leading up to this point.

        );
    }

    //add data to smarty template
    //assign dog
    $xoopsTpl->assign('dogs', $dogs);
    $xoopsTpl->assign('columns', $columns);
    $xoopsTpl->assign('numofcolumns', $numofcolumns);
    $xoopsTpl->assign('tsarray', PedigreeUtilities::sortTable($numofcolumns));
    //assign links
    $xoopsTpl->assign('nummatch', strtr(_MA_PEDIGREE_ADD_SELSIRE, array('[father]' => $moduleConfig['father'])));
    $xoopsTpl->assign('pages', $pages);
}