PedigreeOwnerHandler

Complexity

Total Complexity

2

Size/Duplication

Total Lines	37
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getActiveCriteria()	0	20	1
A	__construct()	0	3	1

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Pedigree module for XOOPS
 *
 * @copyright       XOOPS Project (http://xoops.org)
 * @license         GPL 2.0 or later
 * @package         pedigree
 * @since           2.5.x
 * @author          XOOPS Module Dev Team (http://xoops.org)
 */

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

/**
 * Class PedigreeOwner
 */
class PedigreeOwner extends XoopsObject
{
    //Constructor
    /**
     *
     */
    public function __construct()
    {
        parent::__construct();
        $this->initVar('Id', XOBJ_DTYPE_INT, null, false, 11);
        $this->initVar('firstname', XOBJ_DTYPE_TXTBOX, null, false, 30);
        $this->initVar('lastname', XOBJ_DTYPE_TXTBOX, null, false, 30);
        $this->initVar('postcode', XOBJ_DTYPE_TXTBOX, null, false, 7);
        $this->initVar('city', XOBJ_DTYPE_TXTBOX, null, false, 50);
        $this->initVar('streetname', XOBJ_DTYPE_TXTBOX, null, false, 40);
        $this->initVar('housenumber', XOBJ_DTYPE_TXTBOX, null, false, 6);
        $this->initVar('phonenumber', XOBJ_DTYPE_TXTBOX, null, false, 14);
        $this->initVar('emailadres', XOBJ_DTYPE_TXTBOX, null, false, 40);
        $this->initVar('website', XOBJ_DTYPE_TXTBOX, null, false, 60);
        $this->initVar('user', XOBJ_DTYPE_TXTBOX, null, false, 20);
    }

    /**
     * @param bool $action
     *
     * @return XoopsThemeForm
     */
    public function getForm($action = false)
    {
        global $xoopsModuleConfig;

        if ($action === false) {
            $action = $_SERVER['REQUEST_URI'];
        }

        $title = $this->isNew() ? sprintf(_AM_PEDIGREE_OWNER_ADD) : sprintf(_AM_PEDIGREE_OWNER_EDIT);

        include_once(XOOPS_ROOT_PATH . '/class/xoopsformloader.php');

        $form = new XoopsThemeForm($title, 'form', $action, 'post', true);
        $form->setExtra('enctype="multipart/form-data"');

        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_FIRSTNAME, 'firstname', 50, 255, $this->getVar('firstname')), false);

It seems like $this->getVar('firstname') can also be of type array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_LASTNAME, 'lastname', 50, 255, $this->getVar('lastname')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_POSTCODE, 'postcode', 50, 255, $this->getVar('postcode')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_CITY, 'city', 50, 255, $this->getVar('city')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_STREETNAME, 'streetname', 50, 255, $this->getVar('streetname')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_HOUSENUMBER, 'housenumber', 50, 255, $this->getVar('housenumber')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_PHONENUMBER, 'phonenumber', 50, 255, $this->getVar('phonenumber')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_EMAILADRES, 'emailadres', 50, 255, $this->getVar('emailadres')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_WEBSITE, 'website', 50, 255, $this->getVar('website')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_OWNER_USER, 'user', 50, 255, $this->getVar('user')), false);

        $form->addElement(new XoopsFormHidden('op', 'save_owner'));

        //Submit buttons
        $button_tray   = new XoopsFormElementTray('', '');
        $submit_button = new XoopsFormButton('', 'submit', _SUBMIT, 'submit');
        $button_tray->addElement($submit_button);

        $cancel_button = new XoopsFormButton('', '', _CANCEL, 'cancel');
        $cancel_button->setExtra('onclick="history.go(-1)"');
        $button_tray->addElement($cancel_button);

        $form->addElement($button_tray);

        return $form;
    }
}

/**
 * Class PedigreeOwnerHandler
 */
class PedigreeOwnerHandler extends XoopsPersistableObjectHandler
{
    /**
     * @param null|object|XoopsDatabase $db
     */
    public function __construct(XoopsDatabase $db)
    {
        parent::__construct($db, 'pedigree_owner', 'PedigreeOwner', 'Id', 'firstname');
    }

    /**
     * Get criteria for active animals
     *
     * @return CriteriaElement
     */
    public function getActiveCriteria()
    {
        $gperm_handler = xoops_getHandler('groupperm');

The assignment to $gperm_handler is dead and can be removed.

        //        $criteria = new CriteriaCompo(new Criteria('offline', false));
        //        $criteria->add(new Criteria('published', 0, '>'));
        //        $criteria->add(new Criteria('published', time(), '<='));
        //        $expiredCriteria = new CriteriaCompo(new Criteria('expired', 0));
        //        $expiredCriteria->add(new Criteria('expired', time(), '>='), 'OR');
        //        $criteria->add($expiredCriteria);
        // add criteria for categories that the user has permissions for
        //        $groups                   = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : array(0 => XOOPS_GROUP_ANONYMOUS);
        //mb        $allowedDownCategoriesIds = $gperm_handler->getItemIds('WFDownCatPerm', $groups, $this->wfdownloads->getModule()->mid());
        //mb        $criteria->add(new Criteria('cid', '(' . implode(',', $allowedDownCategoriesIds) . ')', 'IN'));

        $criteria = new CriteriaCompo();
        $criteria->setSort('lastname ASC');
        $criteria->setOrder('ASC');

        return $criteria;
    }
}