PedigreeSelectBox::__construct() - Code Metrics - Inspection of "Merge #1 (Geekwright, Zyspec, Mamba), work in prog..." - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (44f723)

by Michael

created 2016-04-24 16:59 UTC

PedigreeSelectBox::__construct() A

↳ Parent: PedigreeSelectBox

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	8

Duplication

Lines	11
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	11
loc	11
rs	9.4285
cc	2
eloc	8
nc	2
nop	2

<?php

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Pedigree module for XOOPS
 *
 * @copyright   {@link http://sourceforge.net/projects/thmod/ The TXMod XOOPS Project}
 * @copyright   {@link http://sourceforge.net/projects/xoops/ The XOOPS Project}
 * @license     GPL 2.0 or later
 * @package     pedigree
 * @subpackage  class
 * @author      XOOPS Mod Development Team
 */

require_once __DIR__ . '/htmlinput.abstract.php';

/**
 * Class PedigreeSelectBox
 */
class PedigreeSelectBox extends PedigreeHtmlInputAbstract
namespace YourVendor;

class YourClass { }
{
    // Define class variables
    private $fieldnumber;
    private $fieldname;
    private $value;
    private $defaultvalue;
    private $lookuptable;

    /**
     * Constructor
     *
     * @param $parentObject
     * @param $animalObject
     */
    public function __construct($parentObject, $animalObject)

    {
        $this->fieldnumber  = $parentObject->getId();
        $this->fieldname    = $parentObject->fieldname;
        $this->value        = $animalObject->{'user' . $this->fieldnumber};
        $this->defaultvalue = $parentObject->defaultvalue;
        $this->lookuptable  = $parentObject->lookuptable;
        if (0 == $this->lookuptable) {
            echo "<span style='color: red;'><h3>A lookuptable must be specified for userfield" . $this->fieldnumber . '</h3></span>';
        }
    }

    /**
     * @return XoopsFormSelect
     */
    public function editField()

    {
        $select         = new XoopsFormSelect('<b>' . $this->fieldname . '</b>', 'user' . $this->fieldnumber, $value = $this->value, $size = 1, $multiple = false);
        $lookupcontents = parent::lookupField($this->fieldnumber);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $lcCount        = count($lookupcontents);
        for ($i = 0; $i < $lcCount; ++$i) {
            $select->addOption($lookupcontents[$i]['id'], $lookupcontents[$i]['value']);
        }

        return $select;
    }

    /**
     * @param string $name
     *
     * @return XoopsFormSelect
     */
    public function newField($name = '')

    {
        $select         = new XoopsFormSelect('<b>' . $this->fieldname . '</b>', $name . 'user' . $this->fieldnumber, $value = $this->defaultvalue, $size = 1, $multiple = false);
        $lookupcontents = parent::lookupField($this->fieldnumber);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $lcCount        = count($lookupcontents);
        for ($i = 0; $i < $lcCount; ++$i) {
            $select->addOption($lookupcontents[$i]['id'], $lookupcontents[$i]['value']);
        }

        return $select;
    }

    /**
     * @return XoopsFormLabel
     */
    public function viewField()
    {
        $lookupcontents = parent::lookupField($this->fieldnumber);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $lcCount        = count($lookupcontents);
        for ($i = 0; $i < $lcCount; ++$i) {
            if ($lookupcontents[$i]['id'] == $this->value) {
                $choosenvalue = $lookupcontents[$i]['value'];
            }
        }
        $view = new XoopsFormLabel($this->fieldname, $choosenvalue);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        return $view;
    }

    /**
     * @return string
     */
    public function showField()

    {
        $choosenvalue   = '';
        $lookupcontents = parent::lookupField($this->fieldnumber);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $lcCount        = count($lookupcontents);
        for ($i = 0; $i < $lcCount; ++$i) {
            if ($lookupcontents[$i]['id'] == $this->value) {
                $choosenvalue = $lookupcontents[$i]['value'];
            }
        }

        return $this->fieldname . ' : ' . $choosenvalue;
    }

    /**
     * @return string
     */
    public function showValue()

    {
        $choosenvalue   = '';
        $lookupcontents = parent::lookupField($this->fieldnumber);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $lcCount        = count($lookupcontents);
        for ($i = 0; $i < $lcCount; ++$i) {
            if ($lookupcontents[$i]['id'] == $this->value) {
                $choosenvalue = $lookupcontents[$i]['value'];
            }
        }

        return $choosenvalue;
    }

    /**
     * @return string HTML <select> for this field
     */
    public function searchField()

    {
        $select         = "<select size='1' name='query' style='width: 140px;'>";
        $lookupcontents = parent::lookupField($this->fieldnumber);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        $lcCount        = count($lookupcontents);
        for ($i = 0; $i < $lcCount; ++$i) {
            $select .= "<option value='" . $lookupcontents[$i]['id'] . "'>" . $lookupcontents[$i]['value'] . '</option>';
        }
        $select .= '</select>';

        return $select;
    }

    /**
     *
     */
    public function getSearchString()
    {
        return;
    }
}


1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 27 and the first side effect is on line 22. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11		/**
12		* Pedigree module for XOOPS
13		*
14		* @copyright {@link http://sourceforge.net/projects/thmod/ The TXMod XOOPS Project}
15		* @copyright {@link http://sourceforge.net/projects/xoops/ The XOOPS Project}
16		* @license GPL 2.0 or later
17		* @package pedigree
18		* @subpackage class
19		* @author XOOPS Mod Development Team
20		*/
21
22		require_once __DIR__ . '/htmlinput.abstract.php';
23
24		/**
25		* Class PedigreeSelectBox
26		*/
27		class PedigreeSelectBox extends PedigreeHtmlInputAbstract
		0 ignored issues – show Coding Style Compatibility introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
28		{
29		// Define class variables
30		private $fieldnumber;
31		private $fieldname;
32		private $value;
33		private $defaultvalue;
34		private $lookuptable;
35
36		/**
37		* Constructor
38		*
39		* @param $parentObject
40		* @param $animalObject
41		*/
42	View Code Duplication	public function __construct($parentObject, $animalObject)
		0 ignored issues – show Duplication introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$this->fieldnumber = $parentObject->getId();
45		$this->fieldname = $parentObject->fieldname;
46		$this->value = $animalObject->{'user' . $this->fieldnumber};
47		$this->defaultvalue = $parentObject->defaultvalue;
48		$this->lookuptable = $parentObject->lookuptable;
49		if (0 == $this->lookuptable) {
50		echo "<span style='color: red;'><h3>A lookuptable must be specified for userfield" . $this->fieldnumber . '</h3></span>';
51		}
52		}
53
54		/**
55		* @return XoopsFormSelect
56		*/
57	View Code Duplication	public function editField()
		0 ignored issues – show Duplication introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		$select = new XoopsFormSelect('<b>' . $this->fieldname . '</b>', 'user' . $this->fieldnumber, $value = $this->value, $size = 1, $multiple = false);
60		$lookupcontents = parent::lookupField($this->fieldnumber);
		0 ignored issues – show Comprehensibility Bug introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`lookupField()` instead of `editField()`). Are you sure this is correct? If so, you might want to change this to `$this->lookupField()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
61		$lcCount = count($lookupcontents);
62		for ($i = 0; $i < $lcCount; ++$i) {
63		$select->addOption($lookupcontents[$i]['id'], $lookupcontents[$i]['value']);
64		}
65
66		return $select;
67		}
68
69		/**
70		* @param string $name
71		*
72		* @return XoopsFormSelect
73		*/
74	View Code Duplication	public function newField($name = '')
		0 ignored issues – show Duplication introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		$select = new XoopsFormSelect('<b>' . $this->fieldname . '</b>', $name . 'user' . $this->fieldnumber, $value = $this->defaultvalue, $size = 1, $multiple = false);
77		$lookupcontents = parent::lookupField($this->fieldnumber);
		0 ignored issues – show Comprehensibility Bug introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`lookupField()` instead of `newField()`). Are you sure this is correct? If so, you might want to change this to `$this->lookupField()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
78		$lcCount = count($lookupcontents);
79		for ($i = 0; $i < $lcCount; ++$i) {
80		$select->addOption($lookupcontents[$i]['id'], $lookupcontents[$i]['value']);
81		}
82
83		return $select;
84		}
85
86		/**
87		* @return XoopsFormLabel
88		*/
89		public function viewField()
90		{
91		$lookupcontents = parent::lookupField($this->fieldnumber);
		0 ignored issues – show Comprehensibility Bug introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`lookupField()` instead of `viewField()`). Are you sure this is correct? If so, you might want to change this to `$this->lookupField()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
92		$lcCount = count($lookupcontents);
93		for ($i = 0; $i < $lcCount; ++$i) {
94		if ($lookupcontents[$i]['id'] == $this->value) {
95		$choosenvalue = $lookupcontents[$i]['value'];
96		}
97		}
98		$view = new XoopsFormLabel($this->fieldname, $choosenvalue);
		0 ignored issues – show Bug introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report The variable `$choosenvalue` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
99
100		return $view;
101		}
102
103		/**
104		* @return string
105		*/
106	View Code Duplication	public function showField()
		0 ignored issues – show Duplication introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		$choosenvalue = '';
109		$lookupcontents = parent::lookupField($this->fieldnumber);
		0 ignored issues – show Comprehensibility Bug introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`lookupField()` instead of `showField()`). Are you sure this is correct? If so, you might want to change this to `$this->lookupField()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
110		$lcCount = count($lookupcontents);
111		for ($i = 0; $i < $lcCount; ++$i) {
112		if ($lookupcontents[$i]['id'] == $this->value) {
113		$choosenvalue = $lookupcontents[$i]['value'];
114		}
115		}
116
117		return $this->fieldname . ' : ' . $choosenvalue;
118		}
119
120		/**
121		* @return string
122		*/
123	View Code Duplication	public function showValue()
		0 ignored issues – show Duplication introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
124		{
125		$choosenvalue = '';
126		$lookupcontents = parent::lookupField($this->fieldnumber);
		0 ignored issues – show Comprehensibility Bug introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`lookupField()` instead of `showValue()`). Are you sure this is correct? If so, you might want to change this to `$this->lookupField()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
127		$lcCount = count($lookupcontents);
128		for ($i = 0; $i < $lcCount; ++$i) {
129		if ($lookupcontents[$i]['id'] == $this->value) {
130		$choosenvalue = $lookupcontents[$i]['value'];
131		}
132		}
133
134		return $choosenvalue;
135		}
136
137		/**
138		* @return string HTML <select> for this field
139		*/
140	View Code Duplication	public function searchField()
		0 ignored issues – show Duplication introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
141		{
142		$select = "<select size='1' name='query' style='width: 140px;'>";
143		$lookupcontents = parent::lookupField($this->fieldnumber);
		0 ignored issues – show Comprehensibility Bug introduced 2016-04-24 17:00 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`lookupField()` instead of `searchField()`). Are you sure this is correct? If so, you might want to change this to `$this->lookupField()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
144		$lcCount = count($lookupcontents);
145		for ($i = 0; $i < $lcCount; ++$i) {
146		$select .= "<option value='" . $lookupcontents[$i]['id'] . "'>" . $lookupcontents[$i]['value'] . '</option>';
147		}
148		$select .= '</select>';
149
150		return $select;
151		}
152
153		/**
154		*
155		*/
156		public function getSearchString()
157		{
158		return;
159		}
160		}
161

mambax7 / pedigree

Branch — master (44f723)

PedigreeSelectBox::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like