PedigreeFields - Code Metrics - Inspection of "Merge #1 (Geekwright, Zyspec, Mamba), work in prog..." - mambax7/pedigree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (44f723)

by Michael

created 2016-04-24 16:59 UTC

PedigreeFields A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	230
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
wmc	20
c	4
b	0
f	0
lcom	0
cbo	0
dl	0
loc	230
rs	10

15 Methods

Rating	Name	Size	Complexity
A	__construct()	22	1
B	getForm()	84	4
A	isActive()	4	1
A	inAdvanced()	4	1
A	isLocked()	4	1
A	hasSearch()	4	1
A	addLitter()	4	1
A	generalLitter()	4	1
A	hasLookup()	4	1
A	getSearchString()	4	1
A	inPie()	4	1
A	inPedigree()	4	1
A	inList()	4	1
A	getId()	6	2
A	getSetting()	4	2

<?php

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Pedigree module for XOOPS
 *
 * @copyright       {@link http://xoops.org/ The XOOPS Project}
 * @license         GPL 2.0 or later
 * @package         pedigree
 * @author          XOOPS Module Dev Team
 */

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

/**
 * Class PedigreeFields
 */
class PedigreeFields extends XoopsObject
namespace YourVendor;

class YourClass { }
{
    /**
     * Constructor
     */
    public function __construct()
    {
        parent::__construct();
        $this->initVar('Id', XOBJ_DTYPE_INT, null, false, 2);
        $this->initVar('isActive', XOBJ_DTYPE_INT, 1, false, 1);
        $this->initVar('fieldName', XOBJ_DTYPE_TXTBOX, null, false, 50);
        $this->initVar('fieldType', XOBJ_DTYPE_ENUM, 'textbox', false);
        $this->initVar('lookupTable', XOBJ_DTYPE_INT, 0, false, 1);
        $this->initVar('defaultValue', XOBJ_DTYPE_TXTBOX, null, false, 50);
        $this->initVar('fieldExplanation', XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar('hasSearch', XOBJ_DTYPE_INT, 0, false, 1);
        $this->initVar('litter', XOBJ_DTYPE_INT, 0, false, 1);
        $this->initVar('generalLitter', XOBJ_DTYPE_INT, 1, false, 1);
        $this->initVar('searchName', XOBJ_DTYPE_TXTBOX, null, false, 50);
        $this->initVar('searchExplanation', XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar('viewInPedigree', XOBJ_DTYPE_INT, 1, false, 1);
        $this->initVar('viewInAdvanced', XOBJ_DTYPE_INT, 1, false, 1);
        $this->initVar('viewInPie', XOBJ_DTYPE_INT, 1, false, 1);
        $this->initVar('viewInList', XOBJ_DTYPE_INT, 1, false, 1);
        $this->initVar('locked', XOBJ_DTYPE_INT, 0, false, 1);
        $this->initVar('order', XOBJ_DTYPE_INT, 0, false, 3);
    }

    /**
     * @param bool $action
     *
     * @todo refactor to eliminate XoopsObjectTree since it's not structured to
     *       handle this type of object
     *
     * @return object {@see XoopsThemeForm}
     */
    public function getForm($action = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($action === false) {
            $action = $_SERVER['REQUEST_URI'];
        }

        $title = $this->isNew() ? sprintf(_AM_PEDIGREE_PEDIGREE_CONFIG_ADD) : sprintf(_AM_PEDIGREE_PEDIGREE_CONFIG_EDIT);

        include_once $GLOBALS['xoops']->path('class/xoopsformloader.php');

        $form = new XoopsThemeForm($title, 'form', $action, 'post', true);
        $form->setExtra('enctype="multipart/form-data"');

        $form->addElement(new XoopsFormText(_AM_PEDIGREE_PEDIGREE_CONFIG_FIELDNAME, 'fieldName', 50, 255, $this->getVar('FieldName')), true);
        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_ISACTIVE, 'isActive', (int)$this->getVar('isActive')), false);
        $fieldTypes = new XoopsFormSelect(_AM_PEDIGREE_PEDIGREE_CONFIG_FIELDTYPE, 'fieldType', $this->getVar('FieldType'), false);
        $fieldTypes->addOptionArray(array('DataSelect' => 'DataSelect', 'Picture' => 'Picture', 'radiobutton' => 'radiobutton', 'selectbox' => 'selectbox', 'textarea' => 'textarea', 'textbox' => 'textbox', 'urlfield' => 'urlfield'));
        $form->addElement($fieldTypes);
        //        $form->addElement(new XoopsFormTextArea(_AM_PEDIGREE_PEDIGREE_CONFIG_FIELDTYPE, "FieldType", $this->getVar("FieldType"), 4, 47), false);

        $form->addElement(new XoopsFormText(_AM_PEDIGREE_PEDIGREE_CONFIG_LOOKUPTABLE, 'lookupTable', 50, 255, $this->getVar('LookupTable')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_PEDIGREE_CONFIG_DEFAULTVALUE, 'defaultValue', 50, 255, $this->getVar('DefaultValue')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_PEDIGREE_CONFIG_FIELDEXPLANATION, 'fieldExplanation', 50, 255, $this->getVar('FieldExplanation')), false);
        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_HASSEARCH, 'hasSearch', (int)$this->getVar('HasSearch')), false);
        /* @todo: should be single select for either General Litter or Litter, can't have both */
        $currentType = $this->getVar('litter') ? 'litter' : 'generallitter';
        $litterRadio = new XoopsFormRadio(_AM_PEDIGREE_PEDIGREE_CONFIG_LITTER_TYPE, 'litterType', $currentType);
        $litterRadio->addOptionArray(array('litter' => _AM_PEDIGREE_PEDIGREE_CONFIG_LITTER, 'generallitter' => _AM_PEDIGREE_PEDIGREE_CONFIG_GENERALLITTER));
        $form->addElement($litterRadio, false);
        //        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_LITTER, "Litter", $this->getVar("Litter")), false);

        //        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_GENERALLITTER, "Generallitter", $this->getVar("Generallitter")), false);

        $form->addElement(new XoopsFormText(_AM_PEDIGREE_PEDIGREE_CONFIG_SEARCHNAME, 'searchName', 50, 255, $this->getVar('SearchName')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_PEDIGREE_CONFIG_SEARCHEXPLANATION, 'searchExplanation', 50, 255, $this->getVar('SearchExplanation')), false);
        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_VIEWINPEDIGREE, 'viewInPedigree', (int)$this->getVar('ViewInPedigree')), false);
        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_VIEWINADVANCED, 'viewInAdvanced', (int)$this->getVar('ViewInAdvanced')), false);
        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_VIEWINPIE, 'viewInPie', (int)$this->getVar('ViewInPie')), false);
        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_VIEWINLIST, 'viewInList', (int)$this->getVar('ViewInList')), false);
        $form->addElement(new XoopsFormRadioYN(_AM_PEDIGREE_PEDIGREE_CONFIG_LOCKED, 'locked', (int)$this->getVar('locked')), false);
        $form->addElement(new XoopsFormText(_AM_PEDIGREE_PEDIGREE_CONFIG_ORDER, 'order', 3, 8, (int)$this->getVar('order')), false);
        //            include_once(XOOPS_ROOT_PATH."/class/tree.php");

        //            $Handler = xoops_getModuleHandler("animal_", $GLOBALS['xoopsDB']->getVar("dirname"));

        //            $criteria = new CriteriaCompo();

        //            $criteria->setSort('_id');

        //            $criteria->setOrder('ASC');

        //            $_arr = $Handler->getall();

        //            $mytree = new XoopsObjectTree($_arr, "_id", "_pid");

        //            $form->addElement(new XoopsFormLabel(_AM_PEDIGREE_PEDIGREE_CONFIG_LOCKED, $mytree->makeSelBox("_pid", "_title","--", $this->getVar("_pid"),false)));

        //
        //            include_once(XOOPS_ROOT_PATH."/class/tree.php");

        //            $Handler = xoops_getModuleHandler("animal_", $GLOBALS['xoopsModule']->getVar("dirname"));

        //            $criteria = new CriteriaCompo();

        //            $criteria->setSort('_id');

        //            $criteria->setOrder('ASC');

        //            $_arr = $Handler->getall();

        //            $mytree = new XoopsObjectTree($_arr, "_id", "_pid");

        //            $form->addElement(new XoopsFormLabel(_AM_PEDIGREE_PEDIGREE_CONFIG_ORDER, $mytree->makeSelBox("_pid", "_title","--", $this->getVar("_pid"),false)));

        /*

                include_once $GLOBALS['xoops']->path("class/tree.php");
        //      $Handler = xoops_getModuleHandler("animal_", $GLOBALS['xoopsModule']->getVar("dirname"));
                $Handler = xoops_getModuleHandler('fields', 'pedigree');
        //        $Handler = & $pedigreeFieldsHandler;
                $criteria = new CriteriaCompo();
                $criteria->setSort('Id');
                $criteria->setOrder('ASC');
                $_arr   = $Handler->getAll();
                $mytree = new XoopsObjectTree($_arr, "ID", "_pid");
                $form->addElement(new XoopsFormLabel(_AM_PEDIGREE_PEDIGREE_CONFIG_LOCKED, $mytree->makeSelBox("_pid", "_title", "--", $this->getVar("_pid"), false)));
        */
        $form->addElement(new XoopsFormHidden('op', 'save_pedigree_config'));

        //Submit buttons
        $form->addElement(new XoopsFormButtonTray('fieldButtons', _SUBMIT, 'submit'));
        /*

                $button_tray   = new XoopsFormElementTray("", "");
                $submit_button = new XoopsFormButton("", "submit", _SUBMIT, "submit");
                $button_tray->addElement($submit_button);
        
                $cancel_button = new XoopsFormButton("", "", _CANCEL, "cancel");
                $cancel_button->setExtra('onclick="history.go(-1)"');
                $button_tray->addElement($cancel_button);
        
                $form->addElement($button_tray);
        */
        return $form;
    }

    /**
     * @return bool
     */
    public function isActive()
    {
        return (1 == $this->getVar('isActive'));// ? true : false;

    }

    /**
     * @return bool
     */
    public function inAdvanced()
    {
        return (1 == $this->getVar('ViewInAdvanced'));// ? true : false;

    }

    /**
     * @return bool
     */
    public function isLocked()
    {
        return (1 == $this->getVar('Locked'));// ? true : false;

    }

    /**
     * @return bool
     */
    public function hasSearch()
    {
        return (1 == $this->getVar('HasSearch'));// ? true : false;

    }

    /**
     * @return bool
     */
    public function addLitter()
    {
        return (1 == $this->getVar('Litter'));// ? true : false;

    }

    /**
     * @return bool
     */
    public function generalLitter()
    {
        return (1 == $this->getVar('Generallitter'));// ? true : false;

    }

    /**
     * @return bool
     */
    public function hasLookup()
    {
        return (1 == $this->getVar('LookupTable'));// ? true : false;

    }

    /**
     * @return string
     */
    public function getSearchString()
    {
        return '&amp;o=naam&amp;p';
    }

    /**
     * @return bool
     */
    public function inPie()
    {
        return (1 == $this->getVar('ViewInPie'));// ? true : false;

    }

    /**
     * @return bool
     */
    public function inPedigree()
    {
        return (1 == $this->getVar('ViewInPedigree'));// ? true : false;

    }

    /**
     * @return bool
     */
    public function inList()
    {
        return (1 == $this->getVar('ViewInList'));// ? true : false;

    }

    /**
     * @return int|mixed
     */
    public function getId()
    {
        $id = $this->getVar('Id');

        return !empty($id) ? $id : 0;
    }

    /**
     * @deprecated
     * @param $setting
     *
     * @return mixed
     */
    public function getSetting($setting)
    {
        return isset($this->$setting) ? $this->setting : null;
    }
}

/**
 * Class PedigreeFieldsHandler
 *
 * @param object $db reference to the {@link XoopsDatabase} object
 *
 * @return void
 */
class PedigreeFieldsHandler extends XoopsPersistableObjectHandler
namespace YourVendor;

class YourClass { }
{
    /**
     * @param null|object|XoopsDatabase $db
     */
    public function __construct(XoopsDatabase $db)
    {
        parent::__construct($db, 'pedigree_fields', 'PedigreeFields', 'Id', 'FieldName');
    }

    /**
     * @todo table pedigree_lookup doesn't exist in dB this function will FAIL if called
     *
     * @param $fieldnumber
     *
     * @return array
     */
    public function lookupField($fieldnumber)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ret    = array();
        $SQL    = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_lookup' . $fieldnumber) . " ORDER BY 'order'";
        $result = $GLOBALS['xoopsDB']->query($SQL);
        while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
            $ret[] = array('id' => $row['Id'], 'value' => $row['value']);
        }
        //array_multisort($ret,SORT_ASC);

        return $ret;
    }
}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-13 09:56 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 25 and the first side effect is on line 20. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11			/**
12			* Pedigree module for XOOPS
13			*
14			* @copyright {@link http://xoops.org/ The XOOPS Project}
15			* @license GPL 2.0 or later
16			* @package pedigree
17			* @author XOOPS Module Dev Team
18			*/
19
20			defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
21
22			/**
23			* Class PedigreeFields
24			*/
25			class PedigreeFields extends XoopsObject
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
26			{
27			/**
28			* Constructor
29			*/
30			public function __construct()
31			{
32			parent::__construct();
33			$this->initVar('Id', XOBJ_DTYPE_INT, null, false, 2);
34			$this->initVar('isActive', XOBJ_DTYPE_INT, 1, false, 1);
35			$this->initVar('fieldName', XOBJ_DTYPE_TXTBOX, null, false, 50);
36			$this->initVar('fieldType', XOBJ_DTYPE_ENUM, 'textbox', false);
37			$this->initVar('lookupTable', XOBJ_DTYPE_INT, 0, false, 1);
38			$this->initVar('defaultValue', XOBJ_DTYPE_TXTBOX, null, false, 50);

mambax7 / pedigree

Branch — master (44f723)

PedigreeFields A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

Duplication Side-by-Side

Filter issues like