mambax7 / pedigree

class/pedigree.php

Spacing +7 added lines, -7 removed lines

@@ -37,7 +37,7 @@ 
      */
     protected function __construct($debug)
     {
-        $this->debug   = $debug;
+        $this->debug = $debug;
        $moduleDirName = basename(dirname(__DIR__));
        parent::__construct($moduleDirName);
     }
@@ -88,7 +88,7 @@ 
 
             return null;
         }
-        $this->addLog("Getting config '{$name}' : " . print_r($this->config[$name], true));
+        $this->addLog("Getting config '{$name}' : ".print_r($this->config[$name], true));
 
         return $this->config[$name];
     }
@@ -105,7 +105,7 @@ 
             $this->initConfig();
         }
         $this->config[$name] = $value;
-        $this->addLog("Setting config '{$name}' : " . $this->config[$name]);
+        $this->addLog("Setting config '{$name}' : ".$this->config[$name]);
 
         return $this->config[$name];
     }
@@ -117,12 +117,12 @@ 
      */
     public function getHandler($name)
     {
-        if (!isset($this->handler[$name . 'Handler'])) {
+        if (!isset($this->handler[$name.'Handler'])) {
             $this->initHandler($name);
         }
         $this->addLog("Getting handler '{$name}'");
 
-        return $this->handler[$name . 'Handler'];
+        return $this->handler[$name.'Handler'];
     }
 
     public function initModule()
@@ -149,8 +149,8 @@ 
      */
     public function initHandler($name)
     {
-        $this->addLog('INIT ' . $name . ' HANDLER');
-        $this->handler[$name . 'Handler'] = xoops_getModuleHandler($name, $this->dirname);
+        $this->addLog('INIT '.$name.' HANDLER');
+        $this->handler[$name.'Handler'] = xoops_getModuleHandler($name, $this->dirname);
     }
 
     /**

class/SelectBox.php

Spacing +6 added lines, -6 removed lines

@@ -45,11 +45,11 @@ 
     {
         $this->fieldnumber  = $parentObject->getId();
         $this->fieldname    = $parentObject->fieldname;
-        $this->value        = $animalObject->{'user' . $this->fieldnumber};
+        $this->value        = $animalObject->{'user'.$this->fieldnumber};
         $this->defaultvalue = $parentObject->defaultvalue;
         $this->lookuptable  = $parentObject->lookuptable;
         if (0 == $this->lookuptable) {
-            echo "<span style='color: red;'><h3>A lookuptable must be specified for userfield" . $this->fieldnumber . '</h3></span>';
+            echo "<span style='color: red;'><h3>A lookuptable must be specified for userfield".$this->fieldnumber.'</h3></span>';
         }
     }
 
@@ -58,7 +58,7 @@ 
      */
     public function editField()
     {
-        $select         = new \XoopsFormSelect('<b>' . $this->fieldname . '</b>', 'user' . $this->fieldnumber, $value = $this->value, $size = 1, $multiple = false);
+        $select         = new \XoopsFormSelect('<b>'.$this->fieldname.'</b>', 'user'.$this->fieldnumber, $value = $this->value, $size = 1, $multiple = false);
         $lookupcontents = parent::lookupField($this->fieldnumber);
         $lcCount        = count($lookupcontents);
         foreach ($lookupcontents as $i => $iValue) {
@@ -75,7 +75,7 @@ 
      */
     public function newField($name = '')
     {
-        $select         = new \XoopsFormSelect('<b>' . $this->fieldname . '</b>', $name . 'user' . $this->fieldnumber, $value = $this->defaultvalue, $size = 1, $multiple = false);
+        $select         = new \XoopsFormSelect('<b>'.$this->fieldname.'</b>', $name.'user'.$this->fieldnumber, $value = $this->defaultvalue, $size = 1, $multiple = false);
         $lookupcontents = parent::lookupField($this->fieldnumber);
         $lcCount        = count($lookupcontents);
         foreach ($lookupcontents as $i => $iValue) {
@@ -116,7 +116,7 @@ 
             }
         }
 
-        return $this->fieldname . ' : ' . $choosenvalue;
+        return $this->fieldname.' : '.$choosenvalue;
     }
 
     /**
@@ -145,7 +145,7 @@ 
         $lookupcontents = parent::lookupField($this->fieldnumber);
         $lcCount        = count($lookupcontents);
         foreach ($lookupcontents as $i => $iValue) {
-            $select .= "<option value='" . $lookupcontents[$i]['id'] . "'>" . $lookupcontents[$i]['value'] . '</option>';
+            $select .= "<option value='".$lookupcontents[$i]['id']."'>".$lookupcontents[$i]['value'].'</option>';
         }
         $select .= '</select>';
 

class/breadcrumb.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         require_once $GLOBALS['xoops']->path('class/template.php');
         $breadcrumbTpl = new \XoopsTpl();
         $breadcrumbTpl->assign('breadcrumb', $this->bread);
-        $html = $breadcrumbTpl->fetch('db:' . $this->dirname . '_common_breadcrumb.tpl');
+        $html = $breadcrumbTpl->fetch('db:'.$this->dirname.'_common_breadcrumb.tpl');
         unset($breadcrumbTpl);
 
         return $html;

class/DateSelect.php

Spacing +6 added lines, -6 removed lines

@@ -47,16 +47,16 @@ 
         //@todo move language strings to language file
         $this->fieldnumber  = $parentObject->getId();
         $this->fieldname    = $parentObject->fieldname;
-        $this->value        = $animalObject->{'user' . $this->fieldnumber};
+        $this->value        = $animalObject->{'user'.$this->fieldnumber};
         $this->defaultvalue = $parentObject->defaultvalue;
         if ($parentObject->hasLookup()) {
-            xoops_error('No lookuptable may be specified for userfield ' . $this->fieldnumber, get_class($this));
+            xoops_error('No lookuptable may be specified for userfield '.$this->fieldnumber, get_class($this));
         }
         if ($parentObject->inAdvanced()) {
-            xoops_error('userfield ' . $this->fieldnumber . ' cannot be shown in advanced info', get_class($this));
+            xoops_error('userfield '.$this->fieldnumber.' cannot be shown in advanced info', get_class($this));
         }
         if ($parentObject->inPie()) {
-            xoops_error('A Pie-chart cannot be specified for userfield ' . $this->fieldnumber, get_class($this));
+            xoops_error('A Pie-chart cannot be specified for userfield '.$this->fieldnumber, get_class($this));
         }
     }
 
@@ -65,7 +65,7 @@ 
      */
     public function editField()
     {
-        $textarea = new \XoopsFormTextDateSelect('<b>' . $this->fieldname . '</b>', 'user' . $this->fieldnumber, $size = 15, $this->value);
+        $textarea = new \XoopsFormTextDateSelect('<b>'.$this->fieldname.'</b>', 'user'.$this->fieldnumber, $size = 15, $this->value);
 
         return $textarea;
     }
@@ -77,7 +77,7 @@ 
      */
     public function newField($name = '')
     {
-        $textarea = new \XoopsFormTextDateSelect('<b>' . $this->fieldname . '</b>', $name . 'user' . $this->fieldnumber, $size = 15, $this->defaultvalue);
+        $textarea = new \XoopsFormTextDateSelect('<b>'.$this->fieldname.'</b>', $name.'user'.$this->fieldnumber, $size = 15, $this->defaultvalue);
 
         return $textarea;
     }

class/Picture.php

Spacing +11 added lines, -11 removed lines

@@ -34,23 +34,23 @@ 
     {
         $this->fieldnumber  = $parentObject->getId();
         $this->fieldname    = $parentObject->fieldname;
-        $this->value        = $animalObject->{'user' . $this->fieldnumber};
+        $this->value        = $animalObject->{'user'.$this->fieldnumber};
         $this->defaultvalue = $parentObject->defaultvalue;
         $this->lookuptable  = $parentObject->hasLookup();
         if ($this->lookuptable) {
-            xoops_error('No lookuptable may be specified for userfield ' . $this->fieldnumber);
+            xoops_error('No lookuptable may be specified for userfield '.$this->fieldnumber);
         }
         if ($parentObject->inAdvanced()) {
-            xoops_error('userfield ' . $this->fieldnumber . ' cannot be shown in advanced info', get_class($this));
+            xoops_error('userfield '.$this->fieldnumber.' cannot be shown in advanced info', get_class($this));
         }
         if ($parentObject->inPie()) {
-            xoops_error('A Pie-chart cannot be specified for userfield ' . $this->fieldnumber, get_class($this));
+            xoops_error('A Pie-chart cannot be specified for userfield '.$this->fieldnumber, get_class($this));
         }
         if ('1' == $parentObject->viewinlist) {
-            xoops_error('userfield ' . $this->fieldnumber . ' cannot be included in listview', get_class($this));
+            xoops_error('userfield '.$this->fieldnumber.' cannot be included in listview', get_class($this));
         }
         if ('1' == $parentObject->hassearch) {
-            xoops_error('Search cannot be defined for userfield ' . $this->fieldnumber, get_class($this));
+            xoops_error('Search cannot be defined for userfield '.$this->fieldnumber, get_class($this));
         }
     }
 
@@ -59,7 +59,7 @@ 
      */
     public function editField()
     {
-        $picturefield = new \XoopsFormFile($this->fieldname, 'user' . $this->fieldnumber, 1024000);
+        $picturefield = new \XoopsFormFile($this->fieldname, 'user'.$this->fieldnumber, 1024000);
         $picturefield->setExtra("size ='50'");
 
         return $picturefield;
@@ -72,7 +72,7 @@ 
      */
     public function newField($name = '')
     {
-        $picturefield = new \XoopsFormFile($this->fieldname, $name . 'user' . $this->fieldnumber, 1024000);
+        $picturefield = new \XoopsFormFile($this->fieldname, $name.'user'.$this->fieldnumber, 1024000);
         $picturefield->setExtra("size ='50'");
 
         return $picturefield;
@@ -83,7 +83,7 @@ 
      */
     public function viewField()
     {
-        $view = new \XoopsFormLabel($this->fieldname, '<img src="' . PEDIGREE_UPLOAD_URL . '/images/thumbnails/' . $this->value . '_400.jpeg">');
+        $view = new \XoopsFormLabel($this->fieldname, '<img src="'.PEDIGREE_UPLOAD_URL.'/images/thumbnails/'.$this->value.'_400.jpeg">');
 
         return $view;
     }
@@ -93,7 +93,7 @@ 
      */
     public function showField()
     {
-        return '<img src="' . PEDIGREE_UPLOAD_URL . '/images/thumbnails/' . $this->value . '_150.jpeg">';
+        return '<img src="'.PEDIGREE_UPLOAD_URL.'/images/thumbnails/'.$this->value.'_150.jpeg">';
     }
 
     /**
@@ -101,7 +101,7 @@ 
      */
     public function showValue()
     {
-        return '<img src="' . PEDIGREE_UPLOAD_URL . '/images/thumbnails/' . $this->value . '_400.jpeg">';
+        return '<img src="'.PEDIGREE_UPLOAD_URL.'/images/thumbnails/'.$this->value.'_400.jpeg">';
     }
 
     /**

class/Utility.php

Spacing +41 added lines, -41 removed lines

@@ -28,7 +28,7 @@ 
         //        $filteredFolder = XoopsFilterInput::clean($folder, 'PATH');
         if (!is_dir($folder)) {
             mkdir($folder);
-            file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
+            file_put_contents($folder.'/index.html', '<script>history.go(-1);</script>');
         }
         //        chmod($filteredFolder, 0777);
     }
@@ -65,7 +65,7 @@ 
         $max_imgheight     = $GLOBALS['xoopsModuleConfig']['maximgheight']; //1000;
         $allowed_mimetypes = ['image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png'];
         //    $img_dir = XOOPS_ROOT_PATH . "/modules/" . $GLOBALS['xoopsModule']->dirname() . "/images" ;
-        $img_dir = $GLOBALS['xoopsModuleConfig']['uploaddir'] . '/images';
+        $img_dir = $GLOBALS['xoopsModuleConfig']['uploaddir'].'/images';
         require_once $GLOBALS['xoops']->path('class/uploader.php');
         $field = $_POST['xoops_upload_file'][$num];
         if (!empty($field) || '' != $field) {
@@ -120,7 +120,7 @@ 
     */
 
         // load the image
-        require_once $GLOBALS['xoops']->path('modules/' . $GLOBALS['xoopsModule']->dirname() . '/library/Zebra_Image.php');
+        require_once $GLOBALS['xoops']->path('modules/'.$GLOBALS['xoopsModule']->dirname().'/library/Zebra_Image.php');
         $thumbnail_widths = [150, 400];
 
         // indicate a target image
@@ -132,12 +132,12 @@ 
         // create a new instance of the class
         $image = new \Zebra_Image();
         // indicate a source image (a GIF, PNG or JPEG file)
-        $image->source_path = PEDIGREE_UPLOAD_PATH . "/images/{$filename}";
+        $image->source_path = PEDIGREE_UPLOAD_PATH."/images/{$filename}";
 
         foreach ($thumbnail_widths as $thumbnail_width) {
 
             // generate & output thumbnail
-            $output_filename    = PEDIGREE_UPLOAD_PATH . '/images/thumbnails/' . basename($filename) . "_{$thumbnail_width}.{$config_output_format}";
+            $output_filename    = PEDIGREE_UPLOAD_PATH.'/images/thumbnails/'.basename($filename)."_{$thumbnail_width}.{$config_output_format}";
             $image->target_path = $output_filename;
             // since in this example we're going to have a jpeg file, let's set the output
             // image's quality
@@ -293,17 +293,17 @@ 
                 $x = $columns[$i]['columnnumber'];
                 if (is_array($columns[$i]['lookupval'])) {
                     foreach ($columns[$i]['lookupval'] as $key => $keyvalue) {
-                        if ($keyvalue['id'] == $rowres['user' . $x]) {
+                        if ($keyvalue['id'] == $rowres['user'.$x]) {
                             $value = $keyvalue['value'];
                         }
                     }
                     //debug information
                     ///echo $columns[$i]['columnname']."is an array !";
                 } //format value - cant use object because of query count
-                elseif (0 === strncmp($rowres['user' . $x], 'http://', 7)) {
-                    $value = '<a href="' . $rowres['user' . $x] . '">' . $rowres['user' . $x] . '</a>';
+                elseif (0 === strncmp($rowres['user'.$x], 'http://', 7)) {
+                    $value = '<a href="'.$rowres['user'.$x].'">'.$rowres['user'.$x].'</a>';
                 } else {
-                    $value = $rowres['user' . $x];
+                    $value = $rowres['user'.$x];
                 }
                 $columnvalue[] = ['value' => $value];
             }
@@ -312,7 +312,7 @@ 
                 'id'          => $rowres['d_id'],
                 'name'        => $name,
                 'gender'      => $gender,
-                'link'        => '<a href="dog.php?id=' . $rowres['d_id'] . '">' . $name . '</a>',
+                'link'        => '<a href="dog.php?id='.$rowres['d_id'].'">'.$name.'</a>',
                 'colour'      => '',
                 'number'      => '',
                 'usercolumns' => $columnvalue
@@ -333,9 +333,9 @@ 
     {
         global $numofcolumns1, $nummatch1, $pages1, $columns1, $dogs1;
         if ('0' == $pa && '0' == $ma) {
-            $sqlquery = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' WHERE father = ' . $pa . ' AND mother = ' . $ma . ' AND id != ' . $oid . " AND father != '0' AND mother !='0' ORDER BY naam";
+            $sqlquery = 'SELECT * FROM '.$GLOBALS['xoopsDB']->prefix('pedigree_tree').' WHERE father = '.$pa.' AND mother = '.$ma.' AND id != '.$oid." AND father != '0' AND mother !='0' ORDER BY naam";
         } else {
-            $sqlquery = 'SELECT * FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . ' WHERE father = ' . $pa . ' AND mother = ' . $ma . ' AND id != ' . $oid . ' ORDER BY naam';
+            $sqlquery = 'SELECT * FROM '.$GLOBALS['xoopsDB']->prefix('pedigree_tree').' WHERE father = '.$pa.' AND mother = '.$ma.' AND id != '.$oid.' ORDER BY naam';
         }
         $queryresult = $GLOBALS['xoopsDB']->query($sqlquery);
         $nummatch1   = $GLOBALS['xoopsDB']->getRowsNum($queryresult);
@@ -382,17 +382,17 @@ 
                 $x = $columns1[$i]['columnnumber'];
                 if (is_array($columns1[$i]['lookupval'])) {
                     foreach ($columns1[$i]['lookupval'] as $key => $keyvalue) {
-                        if ($keyvalue['id'] == $rowres['user' . $x]) {
+                        if ($keyvalue['id'] == $rowres['user'.$x]) {
                             $value = $keyvalue['value'];
                         }
                     }
                     //debug information
                     ///echo $columns[$i]['columnname']."is an array !";
                 } //format value - cant use object because of query count
-                elseif (0 === strncmp($rowres['user' . $x], 'http://', 7)) {
-                    $value = '<a href="' . $rowres['user' . $x] . '">' . $rowres['user' . $x] . '</a>';
+                elseif (0 === strncmp($rowres['user'.$x], 'http://', 7)) {
+                    $value = '<a href="'.$rowres['user'.$x].'">'.$rowres['user'.$x].'</a>';
                 } else {
-                    $value = $rowres['user' . $x];
+                    $value = $rowres['user'.$x];
                 }
                 $columnvalue1[] = ['value' => $value];
             }
@@ -400,7 +400,7 @@ 
                 'id'          => $rowres['id'],
                 'name'        => $name,
                 'gender'      => $gender,
-                'link'        => '<a href="dog.php?id=' . $rowres['id'] . '">' . $name . '</a>',
+                'link'        => '<a href="dog.php?id='.$rowres['id'].'">'.$name.'</a>',
                 'colour'      => '',
                 'number'      => '',
                 'usercolumns' => $columnvalue1
@@ -421,9 +421,9 @@ 
         $content = '';
 
         if (0 == $breeder) {
-            $sqlquery = 'SELECT id, naam, roft FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE id_owner = '" . $oid . "' ORDER BY naam";
+            $sqlquery = 'SELECT id, naam, roft FROM '.$GLOBALS['xoopsDB']->prefix('pedigree_tree')." WHERE id_owner = '".$oid."' ORDER BY naam";
         } else {
-            $sqlquery = 'SELECT id, naam, roft FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE id_breeder = '" . $oid . "' ORDER BY naam";
+            $sqlquery = 'SELECT id, naam, roft FROM '.$GLOBALS['xoopsDB']->prefix('pedigree_tree')." WHERE id_breeder = '".$oid."' ORDER BY naam";
         }
         $queryresult = $GLOBALS['xoopsDB']->query($sqlquery);
         while (false !== ($rowres = $GLOBALS['xoopsDB']->fetchArray($queryresult))) {
@@ -432,8 +432,8 @@ 
             } else {
                 $gender = '<img src="assets/images/female.gif">';
             }
-            $link    = '<a href="dog.php?id=' . $rowres['id'] . '">' . stripslashes($rowres['naam']) . '</a>';
-            $content .= $gender . ' ' . $link . '<br>';
+            $link = '<a href="dog.php?id='.$rowres['id'].'">'.stripslashes($rowres['naam']).'</a>';
+            $content .= $gender.' '.$link.'<br>';
         }
 
         return $content;
@@ -447,7 +447,7 @@ 
     public static function getName($oid)
     {
         $oid         = (int)$oid;
-        $sqlquery    = 'SELECT naam FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE id = '{$oid}'";
+        $sqlquery    = 'SELECT naam FROM '.$GLOBALS['xoopsDB']->prefix('pedigree_tree')." WHERE id = '{$oid}'";
         $queryresult = $GLOBALS['xoopsDB']->query($sqlquery);
         while (false !== ($rowres = $GLOBALS['xoopsDB']->fetchArray($queryresult))) {
             $an = stripslashes($rowres['naam']);
@@ -462,7 +462,7 @@ 
      */
     public static function showParent($PA)
     {
-        $sqlquery    = 'SELECT naam FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE id='" . $PA . "'";
+        $sqlquery    = 'SELECT naam FROM '.$GLOBALS['xoopsDB']->prefix('pedigree_tree')." WHERE id='".$PA."'";
         $queryresult = $GLOBALS['xoopsDB']->query($sqlquery);
         while (false !== ($rowres = $GLOBALS['xoopsDB']->fetchArray($queryresult))) {
             $result = $rowres['naam'];
@@ -481,7 +481,7 @@ 
      */
     public static function findId($naam_hond)
     {
-        $sqlquery    = 'SELECT id FROM ' . $GLOBALS['xoopsDB']->prefix('pedigree_tree') . " WHERE naam= '$naam_hond'";
+        $sqlquery    = 'SELECT id FROM '.$GLOBALS['xoopsDB']->prefix('pedigree_tree')." WHERE naam= '$naam_hond'";
         $queryresult = $GLOBALS['xoopsDB']->query($sqlquery);
         while (false !== ($rowres = $GLOBALS['xoopsDB']->fetchArray($queryresult))) {
             $result = $rowres['id'];
@@ -534,8 +534,8 @@ 
             $gender = '';
             if ((!empty($GLOBALS['xoopsUser']) && $GLOBALS['xoopsUser'] instanceof \XoopsUser)
                 && ($row['user'] == $GLOBALS['xoopsUser']->getVar('uid') || true === $modadmin)) {
-                $gender = "<a href='dog.php?id={$row['id']}'><img src='assets/images/edit.png' alt='" . _EDIT . "'></a>
-                     . <a href='delete.php?id={$row['id']}'><img src='assets/images/delete.png' alt='" . _DELETE . "'></a>";
+                $gender = "<a href='dog.php?id={$row['id']}'><img src='assets/images/edit.png' alt='"._EDIT."'></a>
+                     . <a href='delete.php?id={$row['id']}'><img src='assets/images/delete.png' alt='"._DELETE."'></a>";
             }
 
             $genImg = (0 == $row['roft']) ? 'male.gif' : 'female.gif';
@@ -546,7 +546,7 @@ 
             } else {
                 $camera = '';
             }
-            $name = stripslashes($row['naam']) . $camera;
+            $name = stripslashes($row['naam']).$camera;
             unset($columnvalue);
 
             //fill array
@@ -555,22 +555,22 @@ 
                 $lookuparray = $columns[$i]['lookuparray'];
                 if (is_array($lookuparray)) {
                     foreach ($lookuparray as $index => $indexValue) {
-                        if ($lookuparray[$index]['id'] == $row['user' . $x]) {
+                        if ($lookuparray[$index]['id'] == $row['user'.$x]) {
                             //echo "<h1>".$lookuparray[$index]['id']."</h1>";
                             $value = $lookuparray[$index]['value'];
                         }
                     }
                 } //format value - cant use object because of query count
-                elseif (0 === strncmp($row['user' . $x], 'http://', 7)) {
-                    $value = '<a href="' . $row['user' . $x] . '">' . $row['user' . $x] . '</a>';
+                elseif (0 === strncmp($row['user'.$x], 'http://', 7)) {
+                    $value = '<a href="'.$row['user'.$x].'">'.$row['user'.$x].'</a>';
                 } else {
-                    $value = $row['user' . $x];
+                    $value = $row['user'.$x];
                 }
                 $columnvalue[] = ['value' => $value];
                 unset($value);
             }
 
-            $linkto = '<a href="' . $link . $row[$element] . '">' . $name . '</a>';
+            $linkto = '<a href="'.$link.$row[$element].'">'.$name.'</a>';
             //create array
             $dogs[] = [
                 'id'          => $row['id'],
@@ -602,7 +602,7 @@ 
         $cat_sql = '';
         if (is_array($cats)) {
             $cats    = array_map('intval', $cats); // make sure all cats are numbers
-            $cat_sql = '(' . implode(',', $cats) . ')';
+            $cat_sql = '('.implode(',', $cats).')';
         /*
                     $cat_sql = '(' . current($cats);
                     array_shift($cats);
@@ -612,7 +612,7 @@ 
                     $cat_sql .= ')';
         */
         } else {
-            $cat_sql = '(' . (int)$cats . ')'; // not efficient but at least creates valid SQL statement
+            $cat_sql = '('.(int)$cats.')'; // not efficient but at least creates valid SQL statement
         }
 
         return $cat_sql;
@@ -751,7 +751,7 @@ 
         //        xoops_load('XoopsLocal');
 
         //        $criteria = $myObject->getHandler($activeObject)->getActiveCriteria();
-        $criteria->setGroupby('UPPER(LEFT(' . $name . ',1))');
+        $criteria->setGroupby('UPPER(LEFT('.$name.',1))');
         $countsByLetters = $myObject->getHandler($activeObject)->getCounts($criteria);
         // Fill alphabet array
 
@@ -791,7 +791,7 @@ 
                 $letter_array['count']  = $countsByLetters[$letter];
                 //            $letter_array['url']    = "" . XOOPS_URL . "/modules/" . $helper->getModule()->dirname() . "/viewcat.php?list={$letter}";
                 //                $letter_array['url'] = '' . XOOPS_URL . '/modules/' . $myObject->getModule()->dirname() . '/'.$file.'?f='.$name."&amp;l=1&amp;w={$letter}%25&amp;o=".$name;
-                $letter_array['url'] = '' . XOOPS_URL . '/modules/' . $myObject->getModule()->dirname() . '/' . $link . $letter . $link2;
+                $letter_array['url'] = ''.XOOPS_URL.'/modules/'.$myObject->getModule()->dirname().'/'.$link.$letter.$link2;
             } else {
                 $letter_array['letter'] = $letter;
                 $letter_array['count']  = 0;
@@ -810,7 +810,7 @@ 
         $letterschoiceTpl          = new \XoopsTpl();
         $letterschoiceTpl->caching = false; // Disable cache
         $letterschoiceTpl->assign('alphabet', $alphabet_array);
-        $html = $letterschoiceTpl->fetch('db:' . $myObject->getModule()->dirname() . '_common_letterschoice.tpl');
+        $html = $letterschoiceTpl->fetch('db:'.$myObject->getModule()->dirname().'_common_letterschoice.tpl');
         unset($letterschoiceTpl);
 
         return $html;
@@ -847,7 +847,7 @@ 
         if (!$withLink) {
             return $pedigreeModuleName;
         } else {
-            return '<a href="' . PEDIGREE_URL . '/">{$pedigreeModuleName}</a>';
+            return '<a href="'.PEDIGREE_URL.'/">{$pedigreeModuleName}</a>';
         }
     }
 
@@ -868,7 +868,7 @@ 
         $GLOBALS['xoopsDB'] = \XoopsDatabaseFactory::getDatabaseConnection();
         $realName           = $GLOBALS['xoopsDB']->prefix($table);
 
-        $sql = 'SHOW TABLES FROM ' . XOOPS_DB_NAME;
+        $sql = 'SHOW TABLES FROM '.XOOPS_DB_NAME;
         $ret = $GLOBALS['xoopsDB']->queryF($sql);
 
         while (false !== (list($m_table) = $GLOBALS['xoopsDB']->fetchRow($ret))) {
@@ -972,10 +972,10 @@ 
         $queryString = $_SERVER['QUERY_STRING'];
 
         if ('' != $queryString) {
-            $queryString = '?' . $queryString;
+            $queryString = '?'.$queryString;
         }
 
-        $currentURL = $http . $httpHost . $phpSelf . $queryString;
+        $currentURL = $http.$httpHost.$phpSelf.$queryString;
 
         $urls                = [];
         $urls['http']        = $http;

class/Common/ServerStats.php

Spacing +12 added lines, -12 removed lines

@@ -34,19 +34,19 @@ 
         //        $sql   .= " WHERE metakey='version' LIMIT 1";
         //        $query = $GLOBALS['xoopsDB']->query($sql);
         //        list($meta) = $GLOBALS['xoopsDB']->fetchRow($query);
-        $html .= "<fieldset><legend style='font-weight: bold; color: #900;'>" . constant('CO_' . $moduleDirNameUpper . '_IMAGEINFO') . "</legend>\n";
+        $html .= "<fieldset><legend style='font-weight: bold; color: #900;'>".constant('CO_'.$moduleDirNameUpper.'_IMAGEINFO')."</legend>\n";
         $html .= "<div style='padding: 8px;'>\n";
         //        $html .= '<div>' . constant('CO_' . $moduleDirNameUpper . '_METAVERSION') . $meta . "</div>\n";
         //        $html .= "<br>\n";
         //        $html .= "<br>\n";
-        $html .= '<div>' . constant('CO_' . $moduleDirNameUpper . '_SPHPINI') . "</div>\n";
+        $html .= '<div>'.constant('CO_'.$moduleDirNameUpper.'_SPHPINI')."</div>\n";
         $html .= "<ul>\n";
         //
-        $gdlib = function_exists('gd_info') ? '<span style="color: green;">' . constant('CO_' . $moduleDirNameUpper . '_GDON') . '</span>' : '<span style="color: red;">' . constant('CO_' . $moduleDirNameUpper . '_GDOFF') . '</span>';
-        $html  .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_GDLIBSTATUS') . $gdlib;
+        $gdlib = function_exists('gd_info') ? '<span style="color: green;">'.constant('CO_'.$moduleDirNameUpper.'_GDON').'</span>' : '<span style="color: red;">'.constant('CO_'.$moduleDirNameUpper.'_GDOFF').'</span>';
+        $html .= '<li>'.constant('CO_'.$moduleDirNameUpper.'_GDLIBSTATUS').$gdlib;
         if (function_exists('gd_info')) {
             if (true === ($gdlib = gd_info())) {
-                $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_GDLIBVERSION') . '<b>' . $gdlib['GD Version'] . '</b>';
+                $html .= '<li>'.constant('CO_'.$moduleDirNameUpper.'_GDLIBVERSION').'<b>'.$gdlib['GD Version'].'</b>';
             }
         }
         //
@@ -56,18 +56,18 @@ 
         //    $registerglobals = (!ini_get('register_globals')) ? "<span style=\"color: green;\">" . constant('CO_' . $moduleDirNameUpper . '_OFF') . '</span>' : "<span style=\"color: red;\">" . constant('CO_' . $moduleDirNameUpper . '_ON') . '</span>';
         //    $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_REGISTERGLOBALS . $registerglobals;
         //
-        $downloads = ini_get('file_uploads') ? '<span style="color: green;">' . constant('CO_' . $moduleDirNameUpper . '_ON') . '</span>' : '<span style="color: red;">' . constant('CO_' . $moduleDirNameUpper . '_OFF') . '</span>';
-        $html      .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_SERVERUPLOADSTATUS') . $downloads;
+        $downloads = ini_get('file_uploads') ? '<span style="color: green;">'.constant('CO_'.$moduleDirNameUpper.'_ON').'</span>' : '<span style="color: red;">'.constant('CO_'.$moduleDirNameUpper.'_OFF').'</span>';
+        $html .= '<li>'.constant('CO_'.$moduleDirNameUpper.'_SERVERUPLOADSTATUS').$downloads;
         //
-        $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_MAXUPLOADSIZE') . ' <b><span style="color: blue;">' . ini_get('upload_max_filesize') . "</span></b>\n";
-        $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_MAXPOSTSIZE') . ' <b><span style="color: blue;">' . ini_get('post_max_size') . "</span></b>\n";
-        $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_MEMORYLIMIT') . ' <b><span style="color: blue;">' . ini_get('memory_limit') . "</span></b>\n";
+        $html .= '<li>'.constant('CO_'.$moduleDirNameUpper.'_MAXUPLOADSIZE').' <b><span style="color: blue;">'.ini_get('upload_max_filesize')."</span></b>\n";
+        $html .= '<li>'.constant('CO_'.$moduleDirNameUpper.'_MAXPOSTSIZE').' <b><span style="color: blue;">'.ini_get('post_max_size')."</span></b>\n";
+        $html .= '<li>'.constant('CO_'.$moduleDirNameUpper.'_MEMORYLIMIT').' <b><span style="color: blue;">'.ini_get('memory_limit')."</span></b>\n";
         $html .= "</ul>\n";
         $html .= "<ul>\n";
-        $html .= '<li>' . constant('CO_' . $moduleDirNameUpper . '_SERVERPATH') . ' <b>' . XOOPS_ROOT_PATH . "</b>\n";
+        $html .= '<li>'.constant('CO_'.$moduleDirNameUpper.'_SERVERPATH').' <b>'.XOOPS_ROOT_PATH."</b>\n";
         $html .= "</ul>\n";
         $html .= "<br>\n";
-        $html .= constant('CO_' . $moduleDirNameUpper . '_UPLOADPATHDSC') . "\n";
+        $html .= constant('CO_'.$moduleDirNameUpper.'_UPLOADPATHDSC')."\n";
         $html .= '</div>';
         $html .= '</fieldset><br>';
 

class/Common/FilesManagement.php

Spacing +10 added lines, -10 removed lines

@@ -32,7 +32,7 @@ 
                     throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
                 }
 
-                file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
+                file_put_contents($folder.'/index.html', '<script>history.go(-1);</script>');
             }
         } catch (\Exception $e) {
             echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
@@ -60,10 +60,10 @@ 
         if (!mkdir($dst) && !is_dir($dst)) {
             while (false !== ($file = readdir($dir))) {
                 if (('.' !== $file) && ('..' !== $file)) {
-                    if (is_dir($src . '/' . $file)) {
-                        self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
+                    if (is_dir($src.'/'.$file)) {
+                        self::recurseCopy($src.'/'.$file, $dst.'/'.$file);
                     } else {
-                        copy($src . '/' . $file, $dst . '/' . $file);
+                        copy($src.'/'.$file, $dst.'/'.$file);
                     }
                 }
             }
@@ -158,7 +158,7 @@ 
                 self::rrmdir($fObj->getPathname());
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -191,14 +191,14 @@ 
         $iterator = new \DirectoryIterator($src);
         foreach ($iterator as $fObj) {
             if ($fObj->isFile()) {
-                rename($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
+                rename($fObj->getPathname(), "{$dest}/".$fObj->getFilename());
             } elseif (!$fObj->isDot() && $fObj->isDir()) {
                 // Try recursively on directory
-                self::rmove($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
+                self::rmove($fObj->getPathname(), "{$dest}/".$fObj->getFilename());
                 //                rmdir($fObj->getPath()); // now delete the directory
             }
         }
-        $iterator = null;   // clear iterator Obj to close file/directory
+        $iterator = null; // clear iterator Obj to close file/directory
         return rmdir($src); // remove the directory & return results
     }
 
@@ -234,9 +234,9 @@ 
         $iterator = new \DirectoryIterator($src);
         foreach ($iterator as $fObj) {
             if ($fObj->isFile()) {
-                copy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
+                copy($fObj->getPathname(), "{$dest}/".$fObj->getFilename());
             } elseif (!$fObj->isDot() && $fObj->isDir()) {
-                self::rcopy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
+                self::rcopy($fObj->getPathname(), "{$dest}/".$fObj->getFilename());
             }
         }
         return true;

class/Common/VersionChecks.php

Spacing +5 added lines, -5 removed lines

@@ -37,13 +37,13 @@ 
         //check for minimum XOOPS version
         $currentVer = substr(XOOPS_VERSION, 6); // get the numeric part of string
         if (null === $requiredVer) {
-            $requiredVer = '' . $module->getInfo('min_xoops'); //making sure it's a string
+            $requiredVer = ''.$module->getInfo('min_xoops'); //making sure it's a string
         }
-        $success     = true;
+        $success = true;
 
         if (version_compare($currentVer, $requiredVer, '<')) {
-            $success     = false;
-            $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_XOOPS'), $requiredVer, $currentVer));
+            $success = false;
+            $module->setErrors(sprintf(constant('CO_'.$moduleDirNameUpper.'_ERROR_BAD_XOOPS'), $requiredVer, $currentVer));
         }
 
         return $success;
@@ -66,7 +66,7 @@ 
         $reqVer  = $module->getInfo('min_php');
         if (false !== $reqVer && '' !== $reqVer) {
             if (version_compare($verNum, $reqVer, '<')) {
-                $module->setErrors(sprintf(constant('CO_' . $moduleDirNameUpper . '_ERROR_BAD_PHP'), $reqVer, $verNum));
+                $module->setErrors(sprintf(constant('CO_'.$moduleDirNameUpper.'_ERROR_BAD_PHP'), $reqVer, $verNum));
                 $success = false;
             }
         }