XoopsModules\Pedigree\pedigreeUtilities0::createList()

Complexity

Conditions	18
Paths	264

Size

Total Lines	93
Code Lines	62

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function createList($result, $prefix, $link, $element)
    {
        global $xoopsTpl;
        $animal = new Pedigree\Animal();
        //test to find out how many user fields there are...
        $fields       = $animal->getNumOfFields();
        $numofcolumns = 1;
        $columns[]    = ['columnname' => 'Name'];

$columns was never initialized. Although not strictly required by PHP, it is generally a good practice to add $columns = array(); before regardless.

        for ($i = 0, $iMax = \count($fields); $i < $iMax; ++$i) {
            $userField   = new Field($fields[$i], $animal->getConfig());
            $fieldType   = $userField->getSetting('FieldType');
            $fieldObject = new $fieldType($userField, $animal);
            if ($userField->isActive() && $userField->inList()) {
                if ($userField->hasLookup()) {
                    $id = $userField->getId();
                    $q  = $userField->lookupField($id);
                } else {
                    $q = '';
                }
                $columns[] = [
                    'columnname'   => $fieldObject->fieldname,
                    'columnnumber' => $userField->getId(),
                    'lookuparray'  => $q,
                ];
                ++$numofcolumns;
            }
        }

        //add preliminary row to array if passed
        if (\is_array($prefix)) {
            $dogs[] = $prefix;

$dogs was never initialized. Although not strictly required by PHP, it is generally a good practice to add $dogs = array(); before regardless.

        }

        while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
            //reset $gender
            $gender = '';
            if ((!empty($GLOBALS['xoopsUser']) && $GLOBALS['xoopsUser'] instanceof \XoopsUser)
                && ($row['user'] == $GLOBALS['xoopsUser']->getVar('uid') || true === $modadmin)) {

The variable $modadmin seems to be never defined.

                $gender = "<a href='dog.php?id={$row['id']}'><img src='images/edit.png' alt='" . _EDIT . "'></a>
                     . <a href='delete.php?id={$row['id']}'><img src='images/delete.png' alt='" . _DELETE . "'></a>";
            }

            $genImg = (0 == $row['roft']) ? 'male.gif' : 'female.gif';
            $gender .= "<img src='assets/images/{$genImg}'>";

            if ('' != $row['foto']) {
                $camera = ' <img src="' . PEDIGREE_UPLOAD_URL . '/images/dog-icon25.png">';

The constant XoopsModules\Pedigree\PEDIGREE_UPLOAD_URL was not found. Maybe you did not declare it correctly or list all dependencies?

            } else {
                $camera = '';
            }
            $name = \stripslashes($row['pname']) . $camera;
            unset($columnvalue);

            //fill array
            for ($i = 1; $i < $numofcolumns; ++$i) {
                $x           = $columns[$i]['columnnumber'];
                $lookuparray = $columns[$i]['lookuparray'];
                if (\is_array($lookuparray)) {
                    for ($index = 0, $indexMax = \count($lookuparray); $index < $indexMax; ++$index) {
                        if ($lookuparray[$index]['id'] == $row['user' . $x]) {
                            //echo "<h1>".$lookuparray[$index]['id']."</h1>";
                            $value = $lookuparray[$index]['value'];
                        }
                    }
                } //format value - cant use object because of query count
                elseif (0 === \strncmp($row['user' . $x], 'http://', 7)) {
                    $value = '<a href="' . $row['user' . $x] . '">' . $row['user' . $x] . '</a>';
                } else {
                    $value = $row['user' . $x];
                }
                $columnvalue[] = ['value' => $value];

The variable $value does not seem to be defined for all execution paths leading up to this point.

                unset($value);
            }

            $linkto = '<a href="' . $link . $row[$element] . '">' . $name . '</a>';
            //create array
            $dogs[] = [
                'id'          => $row['id'],
                'name'        => $name,
                'gender'      => $gender,
                'link'        => $linkto,
                'colour'      => '',
                'number'      => '',
                'usercolumns' => $columnvalue,

The variable $columnvalue does not seem to be defined for all execution paths leading up to this point.

            ];
        }

        //add data to smarty template
        //assign dog
        $xoopsTpl->assign('dogs', $dogs);

The variable $dogs does not seem to be defined for all execution paths leading up to this point.

        $xoopsTpl->assign('columns', $columns);
        $xoopsTpl->assign('numofcolumns', $numofcolumns);
        $xoopsTpl->assign('tsarray', self::sortTable($numofcolumns));
    }