SysUtility   B
last analyzed

Complexity

Total Complexity 50

Size/Duplication

Total Lines 387
Duplicated Lines 0 %

Importance

Changes 2
Bugs 0 Features 0
Metric Value
eloc 152
dl 0
loc 387
rs 8.4
c 2
b 0
f 0
wmc 50

13 Methods

Rating   Name   Duplication   Size   Complexity  
A addField() 0 4 1
A prepareFolder() 0 9 4
A getInstance() 0 8 2
A blockAddCatSelect() 0 13 4
A metaDescription() 0 9 2
A metaKeywords() 0 9 2
A cloneRecord() 0 20 3
A tableExists() 0 10 1
A fieldExists() 0 7 1
A getEditor() 0 32 5
A enumerate() 0 20 2
A selectSorting() 0 25 4
F truncateHtml() 0 95 19

How to fix   Complexity   

Complex Class

Complex classes like SysUtility often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use SysUtility, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
namespace XoopsModules\Pedigree\Common;
4
5
/*
6
 Utility Class Definition
7
8
 You may not change or alter any portion of this comment or credits of
9
 supporting developers from this source code or any supporting source code
10
 which is considered copyrighted (c) material of the original comment or credit
11
 authors.
12
13
 This program is distributed in the hope that it will be useful, but
14
 WITHOUT ANY WARRANTY; without even the implied warranty of
15
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
16
 */
17
18
/**
19
 * @package      \XoopsModules\Pedigree
20
 * @copyright    {@link https://xoops.org/ XOOPS Project}
21
 * @license      GNU GPL2orlater(https://www.gnu.org/licenses/gpl-2.0.html)
22
 * @author       XOOPS Development Team <https://xoops.org>
23
 * @author       ZySpec <[email protected]>
24
 * @author       Mamba <[email protected]>
25
 */
26
27
use Xmf\Request;
28
use XoopsFormEditor;
29
use XoopsModules\Pedigree\{
30
    Helper
31
};
32
33
/**
34
 * Class SysUtility
35
 */
36
class SysUtility
37
{
38
    use VersionChecks; //checkVerXoops, checkVerPhp Traits
0 ignored issues
show
introduced by
The trait XoopsModules\Pedigree\Common\VersionChecks requires some properties which are not provided by XoopsModules\Pedigree\Common\SysUtility: $tag_name, $prerelease
Loading history...
39
    use ServerStats; // getServerStats Trait
40
    use FilesManagement; // Files Management Trait
41
42
    //--------------- Common module methods -----------------------------
43
44
    /**
45
     * Access the only instance of this class
46
     *
47
     * @return SysUtility
48
     *
49
     */
50
    public static function getInstance(): SysUtility
51
    {
52
        static $instance;
53
        if (null === $instance) {
54
            $instance = new static();
55
        }
56
57
        return $instance;
58
    }
59
60
    /**
61
     * @param $text
62
     * @param $form_sort
63
     * @return string
64
     */
65
    public static function selectSorting($text, $form_sort): string
66
    {
67
        global $start, $order, $sort;
68
69
        $select_view   = '';
0 ignored issues
show
Unused Code introduced by
The assignment to $select_view is dead and can be removed.
Loading history...
70
        $moduleDirName = \basename(\dirname(__DIR__));
0 ignored issues
show
Unused Code introduced by
The assignment to $moduleDirName is dead and can be removed.
Loading history...
71
        $helper = Helper::getInstance();
72
73
        //$pathModIcon16 = XOOPS_URL . '/modules/' . $moduleDirName . '/' . $helper->getConfig('modicons16');
74
        $pathModIcon16 = $helper->url($helper->getModule()->getInfo('modicons16'));
0 ignored issues
show
Bug introduced by
It seems like $helper->getModule()->getInfo('modicons16') can also be of type array; however, parameter $url of Xmf\Module\Helper\GenericHelper::url() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

74
        $pathModIcon16 = $helper->url(/** @scrutinizer ignore-type */ $helper->getModule()->getInfo('modicons16'));
Loading history...
75
76
        $select_view = '<form name="form_switch" id="form_switch" action="' . Request::getString('REQUEST_URI', '', 'SERVER') . '" method="post"><span style="font-weight: bold;">' . $text . '</span>';
77
        //$sorts =  $sort ==  'asc' ? 'desc' : 'asc';
78
        if ($form_sort == $sort) {
79
            $sel1 = 'asc' === $order ? 'selasc.png' : 'asc.png';
80
            $sel2 = 'desc' === $order ? 'seldesc.png' : 'desc.png';
81
        } else {
82
            $sel1 = 'asc.png';
83
            $sel2 = 'desc.png';
84
        }
85
        $select_view .= '  <a href="' . Request::getString('SCRIPT_NAME', '', 'SERVER') . '?start=' . $start . '&sort=' . $form_sort . '&order=asc"><img src="' . $pathModIcon16 . '/' . $sel1 . '" title="ASC" alt="ASC"></a>';
86
        $select_view .= '<a href="' . Request::getString('SCRIPT_NAME', '', 'SERVER') . '?start=' . $start . '&sort=' . $form_sort . '&order=desc"><img src="' . $pathModIcon16 . '/' . $sel2 . '" title="DESC" alt="DESC"></a>';
87
        $select_view .= '</form>';
88
89
        return $select_view;
90
    }
91
92
    /***************Blocks***************/
93
    /**
94
     * @param array $cats
95
     * @return string
96
     */
97
    public static function blockAddCatSelect(array $cats): string
98
    {
99
        $cat_sql = '';
100
        if (\is_array($cats) && !empty($cats)) {
101
            $cat_sql = '(' . \current($cats);
102
            \array_shift($cats);
103
            foreach ($cats as $cat) {
104
                $cat_sql .= ',' . $cat;
105
            }
106
            $cat_sql .= ')';
107
        }
108
109
        return $cat_sql;
110
    }
111
112
    /**
113
     * @param $content
114
     */
115
    public static function metaKeywords($content): void
116
    {
117
        global $xoopsTpl, $xoTheme;
118
        $myts    = \MyTextSanitizer::getInstance();
119
        $content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
120
        if (\is_object($xoTheme)) {
121
            $xoTheme->addMeta('meta', 'keywords', \strip_tags($content));
122
        } else {    // Compatibility for old Xoops versions
123
            $xoopsTpl->assign('xoops_metaKeywords', \strip_tags($content));
124
        }
125
    }
126
127
    /**
128
     * @param $content
129
     */
130
    public static function metaDescription($content): void
131
    {
132
        global $xoopsTpl, $xoTheme;
133
        $myts    = \MyTextSanitizer::getInstance();
134
        $content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
135
        if (\is_object($xoTheme)) {
136
            $xoTheme->addMeta('meta', 'description', \strip_tags($content));
137
        } else {    // Compatibility for old Xoops versions
138
            $xoopsTpl->assign('xoops_metaDescription', \strip_tags($content));
139
        }
140
    }
141
142
    /**
143
     * @param string $tableName
144
     * @param string $columnName
145
     *
146
     * @return array|false
147
     */
148
    public static function enumerate(string $tableName, string $columnName)
149
    {
150
        $table = $GLOBALS['xoopsDB']->prefix($tableName);
151
152
        //    $result = $GLOBALS['xoopsDB']->query("SELECT COLUMN_TYPE FROM INFORMATION_SCHEMA.COLUMNS
153
        //        WHERE TABLE_NAME = '" . $table . "' AND COLUMN_NAME = '" . $columnName . "'")
154
        //    || exit ($GLOBALS['xoopsDB']->error());
155
156
        $sql    = 'SELECT COLUMN_TYPE FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = "' . $table . '" AND COLUMN_NAME = "' . $columnName . '"';
157
        $result = $GLOBALS['xoopsDB']->query($sql);
158
        if (!$result) {
159
//            exit($GLOBALS['xoopsDB']->error());
160
            $logger     = \XoopsLogger::getInstance();
161
            $logger->handleError(\E_USER_WARNING, $sql, __FILE__, __LINE__);
162
            return false;
163
        }
164
165
        $row      = $GLOBALS['xoopsDB']->fetchBoth($result);
166
        $enumList = \explode(',', \str_replace("'", '', \mb_substr($row['COLUMN_TYPE'], 5, - 6)));
167
        return $enumList;
168
    }
169
170
171
    /**
172
     * Clone a record in a dB
173
     *
174
     * @TODO need to exit more gracefully on error. Should throw/trigger error and then return false
175
     *
176
     * @param string $tableName name of dB table (without prefix)
177
     * @param string $idField   name of field (column) in dB table
178
     * @param int    $id        item id to clone
179
     *
180
     * @return mixed
181
     */
182
    public static function cloneRecord(string $tableName, string $idField, int $id)
183
    {
184
        $newId = false;
0 ignored issues
show
Unused Code introduced by
The assignment to $newId is dead and can be removed.
Loading history...
185
        $table = $GLOBALS['xoopsDB']->prefix($tableName);
186
        // copy content of the record you wish to clone
187
        $sql       = "SELECT * FROM $table WHERE $idField='" . (int)$id . "' ";
188
        $tempTable = $GLOBALS['xoopsDB']->fetchArray($GLOBALS['xoopsDB']->query($sql), \MYSQLI_ASSOC);
189
        if (!$tempTable) {
190
            exit($GLOBALS['xoopsDB']->error());
0 ignored issues
show
Best Practice introduced by
Using exit here is not recommended.

In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.

Loading history...
191
        }
192
        // set the auto-incremented id's value to blank.
193
        unset($tempTable[$idField]);
194
        // insert cloned copy of the original  record
195
        $sql    = "INSERT INTO $table (" . \implode(', ', \array_keys($tempTable)) . ") VALUES ('" . \implode("', '", \array_values($tempTable)) . "')";
196
        $result = $GLOBALS['xoopsDB']->queryF($sql);
197
        if (!$result) {
198
            exit($GLOBALS['xoopsDB']->error());
0 ignored issues
show
Best Practice introduced by
Using exit here is not recommended.

In general, usage of exit should be done with care and only when running in a scripting context like a CLI script.

Loading history...
199
        }
200
        // Return the new id
201
        return $GLOBALS['xoopsDB']->getInsertId();
202
    }
203
    /**
204
     * truncateHtml can truncate a string up to a number of characters while preserving whole words and HTML tags
205
     * www.gsdesign.ro/blog/cut-html-string-without-breaking-the-tags
206
     * www.cakephp.org
207
     *
208
     * @TODO: Refactor to consider HTML5 & void (self-closing) elements
209
     * @TODO: Consider using https://github.com/jlgrall/truncateHTML/blob/master/truncateHTML.php
210
     *
211
     * @param string $text         String to truncate.
212
     * @param int    $length       Length of returned string, including ellipsis.
213
     * @param string $ending       Ending to be appended to the trimmed string.
214
     * @param bool   $exact        If false, $text will not be cut mid-word
215
     * @param bool   $considerHtml If true, HTML tags would be handled correctly
216
     *
217
     * @return string Trimmed string.
218
     */
219
    public static function truncateHtml(
220
        string $text,
221
        ?int $length = 100,
222
        ?string $ending = '...',
223
        ?bool $exact = false,
224
        ?bool $considerHtml = true
225
    ): string {
226
        $openTags = [];
227
        if ($considerHtml) {
228
            // if the plain text is shorter than the maximum length, return the whole text
229
            if (\mb_strlen(\preg_replace('/<.*?' . '>/', '', $text)) <= $length) {
230
                return $text;
231
            }
232
            // splits all html-tags to scanable lines
233
            \preg_match_all('/(<.+?' . '>)?([^<>]*)/s', $text, $lines, \PREG_SET_ORDER);
234
            $total_length = \mb_strlen($ending);
0 ignored issues
show
Bug introduced by
It seems like $ending can also be of type null; however, parameter $string of mb_strlen() does only seem to accept string, maybe add an additional type check? ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

234
            $total_length = \mb_strlen(/** @scrutinizer ignore-type */ $ending);
Loading history...
235
            //$openTags    = [];
236
            $truncate     = '';
237
            foreach ($lines as $line_matchings) {
238
                // if there is any html-tag in this line, handle it and add it (uncounted) to the output
239
                if (!empty($line_matchings[1])) {
240
                    // if it's an "empty element" with or without xhtml-conform closing slash
241
                    if (\preg_match('/^<(\s*.+?\/\s*|\s*(img|br|input|hr|area|base|basefont|col|frame|isindex|link|meta|param)(\s.+?)?)>$/is', $line_matchings[1])) {
242
                        // do nothing
243
                        // if tag is a closing tag
244
                    } elseif (\preg_match('/^<\s*\/(\S+?)\s*>$/s', $line_matchings[1], $tag_matchings)) {
245
                        // delete tag from $openTags list
246
                        $pos = \array_search($tag_matchings[1], $openTags, true);
247
                        if (false !== $pos) {
248
                            unset($openTags[$pos]);
249
                        }
250
                        // if tag is an opening tag
251
                    } elseif (\preg_match('/^<\s*([^\s>!]+).*?' . '>$/s', $line_matchings[1], $tag_matchings)) {
252
                        // add tag to the beginning of $openTags list
253
                        \array_unshift($openTags, \mb_strtolower($tag_matchings[1]));
254
                    }
255
                    // add html-tag to $truncate'd text
256
                    $truncate .= $line_matchings[1];
257
                }
258
                // calculate the length of the plain text part of the line; handle entities as one character
259
                $content_length = \mb_strlen(\preg_replace('/&[0-9a-z]{2,8};|&#\d{1,7};|[0-9a-f]{1,6};/i', ' ', $line_matchings[2]));
260
                if ($total_length + $content_length > $length) {
261
                    // the number of characters which are left
262
                    $left            = $length - $total_length;
263
                    $entities_length = 0;
264
                    // search for html entities
265
                    if (\preg_match_all('/&[0-9a-z]{2,8};|&#\d{1,7};|[0-9a-f]{1,6};/i', $line_matchings[2], $entities, \PREG_OFFSET_CAPTURE)) {
266
                        // calculate the real length of all entities in the legal range
267
                        foreach ($entities[0] as $entity) {
268
                            if ($left >= $entity[1] + 1 - $entities_length) {
269
                                $left--;
270
                                $entities_length += \mb_strlen($entity[0]);
271
                            } else {
272
                                // no more characters left
273
                                break;
274
                            }
275
                        }
276
                    }
277
                    $truncate .= \mb_substr($line_matchings[2], 0, $left + $entities_length);
278
                    // maximum length is reached, so get off the loop
279
                    break;
280
                }
281
                $truncate     .= $line_matchings[2];
282
                $total_length += $content_length;
283
284
                // if the maximum length is reached, get off the loop
285
                if ($total_length >= $length) {
286
                    break;
287
                }
288
            }
289
        } else {
290
            if (\mb_strlen($text) <= $length) {
291
                return $text;
292
            }
293
            $truncate = \mb_substr($text, 0, $length - \mb_strlen($ending));
294
        }
295
        // if the words shouldn't be cut in the middle...
296
        if (!$exact) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $exact of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

If an expression can have both false, and null as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values.

$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
Loading history...
297
            // ...search the last occurance of a space...
298
            $spacepos = \mb_strrpos($truncate, ' ');
299
            if (isset($spacepos)) {
300
                // ...and cut the text in this position
301
                $truncate = \mb_substr($truncate, 0, $spacepos);
302
            }
303
        }
304
        // add the defined ending to the text
305
        $truncate .= $ending;
306
        if ($considerHtml) {
307
            // close all unclosed html-tags
308
            foreach ($openTags as $tag) {
309
                $truncate .= '</' . $tag . '>';
310
            }
311
        }
312
313
        return $truncate;
314
    }
315
316
    /**
317
     * Get correct text editor based on user rights
318
     *
319
     * @param \Xmf\Module\Helper $helper
320
     * @param array|null         $options
321
     *
322
     * @return \XoopsFormDhtmlTextArea|\XoopsFormEditor
323
     */
324
    public static function getEditor(?\Xmf\Module\Helper $helper = null, ?array $options = null)
325
    {
326
        /** @var Helper $helper */
327
        if (null === $options) {
328
            $options           = [];
329
            $options['name']   = 'Editor';
330
            $options['value']  = 'Editor';
331
            $options['rows']   = 10;
332
            $options['cols']   = '100%';
333
            $options['width']  = '100%';
334
            $options['height'] = '400px';
335
        }
336
337
        if (null === $helper) {
338
            $helper = Helper::getInstance();
339
        }
340
341
        $isAdmin = $helper->isUserAdmin();
342
343
        if (\class_exists('XoopsFormEditor')) {
344
            if ($isAdmin) {
345
                $descEditor = new XoopsFormEditor(\ucfirst($options['name']), $helper->getConfig('editorAdmin'), $options, $nohtml = false, $onfailure = 'textarea');
346
            } else {
347
                $descEditor = new XoopsFormEditor(\ucfirst($options['name']), $helper->getConfig('editorUser'), $options, $nohtml = false, $onfailure = 'textarea');
348
            }
349
        } else {
350
            $descEditor = new \XoopsFormDhtmlTextArea(\ucfirst($options['name']), $options['name'], $options['value'], '100%', '100%');
0 ignored issues
show
Bug introduced by
'100%' of type string is incompatible with the type integer expected by parameter $cols of XoopsFormDhtmlTextArea::__construct(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

350
            $descEditor = new \XoopsFormDhtmlTextArea(\ucfirst($options['name']), $options['name'], $options['value'], '100%', /** @scrutinizer ignore-type */ '100%');
Loading history...
Bug introduced by
'100%' of type string is incompatible with the type integer expected by parameter $rows of XoopsFormDhtmlTextArea::__construct(). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-type  annotation

350
            $descEditor = new \XoopsFormDhtmlTextArea(\ucfirst($options['name']), $options['name'], $options['value'], /** @scrutinizer ignore-type */ '100%', '100%');
Loading history...
351
        }
352
353
        //        $form->addElement($descEditor);
354
355
        return $descEditor;
356
    }
357
358
    /**
359
     * Check if column in dB table exists
360
     *
361
     * @param string $fieldname name of dB table field
362
     * @param string $table     name of dB table (including prefix)
363
     *
364
     * @return bool true if table exists
365
     * @deprecated
366
     */
367
    public static function fieldExists(string $fieldname, string $table): bool
368
    {
369
        $trace = \debug_backtrace(\DEBUG_BACKTRACE_IGNORE_ARGS, 1);
370
        \trigger_error(__METHOD__ . " is deprecated, use Xmf\Database\Tables instead - instantiated from {$trace[0]['file']} line {$trace[0]['line']},");
371
372
        $result = $GLOBALS['xoopsDB']->queryF("SHOW COLUMNS FROM   $table LIKE '$fieldname'");
373
        return ($GLOBALS['xoopsDB']->getRowsNum($result) > 0);
374
    }
375
376
377
    /**
378
     * Function responsible for checking if a directory exists, we can also write in and create an index.html file
379
     *
380
     * @param string $folder The full path of the directory to check
381
     */
382
    public static function prepareFolder(string $folder): void
383
    {
384
        try {
385
            if (!@\mkdir($folder) && !\is_dir($folder)) {
386
                throw new \RuntimeException(\sprintf('Unable to create the %s directory', $folder));
387
            }
388
            file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
389
        } catch (\Exception $e) {
390
            echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
391
        }
392
    }
393
394
    /**
395
     * Check if dB table table exists
396
     *
397
     * @param string $tablename dB tablename with prefix
398
     * @return bool true if table exists
399
     */
400
    public static function tableExists(string $tablename): bool
401
    {
402
        $trace = \debug_backtrace(\DEBUG_BACKTRACE_IGNORE_ARGS, 1);
403
        \trigger_error(__FUNCTION__ . " is deprecated, called from {$trace[0]['file']} line {$trace[0]['line']}");
404
        $GLOBALS['xoopsLogger']->addDeprecated(
405
            \basename(\dirname(__DIR__, 2)) . ' Module: ' . __FUNCTION__ . ' function is deprecated, please use Xmf\Database\Tables method(s) instead.' . " Called from {$trace[0]['file']}line {$trace[0]['line']}"
406
        );
407
        $result = $GLOBALS['xoopsDB']->queryF("SHOW TABLES LIKE '$tablename'");
408
409
        return $GLOBALS['xoopsDB']->getRowsNum($result) > 0    ;
410
    }
411
412
    /**
413
     * Add a field to a mysql table
414
     *
415
     * @param $field
416
     * @param $table
417
     * @return bool|\mysqli_result
418
     */
419
    public static function addField($field, $table)
420
    {
421
        global $xoopsDB;
422
        return $xoopsDB->queryF('ALTER TABLE ' . $table . " ADD $field;");
423
    }
424
}
425