XoopsModules\Pedigree\Animal

Complexity

Total Complexity

5

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getNumOfFields()	0	27	2
A	getConfig()	0	3	1
A	__construct()	0	10	2

<?php

namespace XoopsModules\Pedigree;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * Pedigree module for XOOPS
 *
 * @copyright   {@link http://sourceforge.net/projects/xoops/ The XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @package     pedigree
 * @subpackage  class
 * @since       1.3.1
 * @author      XOOPS Module Dev Team
 * @author      ZySpec <zyspec@yahoo.com>
 */

use XoopsModules\Pedigree\{
    Helper

This use statement conflicts with another class in this namespace, XoopsModules\Pedigree\Helper. Consider defining an alias.

};

/**
 * Animal Class
 */
class Animal
{
    protected $myTree       = [];
    protected $fields       = [];
    protected $configValues = [];

    /**
     * class constructor
     *
     * initializes the tree array
     * @param int|null $id
     */
    public function __construct($id = null)
    {
        $moduleDirName = \basename(\dirname(__DIR__));

The assignment to $moduleDirName is dead and can be removed.

        $id            = null !== $id ? (int)$id : 1;
        $myTreeHandler = Helper::getInstance()->getHandler('Tree');

        $criteria = new \CriteriaCompo();
        $criteria->add(new \Criteria('id', $id));
        $criteria->setLimit(1);
        $this->myTree = $myTreeHandler->getAll($criteria, null, false);

The method getAll() does not exist on XoopsModules\Pedigree\TreeHandler.

        /*
        $SQL = "SELECT * FROM " . $GLOBALS['xoopsDB']->prefix("pedigree_registry") . " WHERE id = {$id}";
        $result    = $GLOBALS['xoopsDB']->query($SQL);
        $row       = $GLOBALS['xoopsDB']->fetchRow($result);
        $numfields = mysqli_num_fields($result);
        for ($i = 0; $i < $numfields; ++$i) {
            $key        =$GLOBALS['xoopsDB']->getFieldName($result, $i);
            $this->$key = $row[$i];
        }
        */
    }

    /**
     * Number of Fields
     * @return array
     */
    public function getNumOfFields()
    {
        $moduleDirName = \basename(\dirname(__DIR__));

The assignment to $moduleDirName is dead and can be removed.

        $fieldsHandler = Helper::getInstance()->getHandler('Fields');
        $criteria      = new \CriteriaCompo();
        $criteria->setSort('`order`');
        $criteria->setOrder('ASC');
        $this->fields       = $fieldsHandler->getIds($criteria); //get all object IDs

The method getIds() does not exist on XoopsModules\Pedigree\FieldsHandler.

        $this->configValues = $fieldsHandler->getAll($criteria, null, false); //get objects as arrays

The method getAll() does not exist on XoopsModules\Pedigree\FieldsHandler.

        if (empty($this->configValues)) {
            $this->configValues = '';
        }
        /*
        $SQL    = "SELECT * FROM " . $GLOBALS['xoopsDB']->prefix("pedigree_fields") . " ORDER BY `order`";
        $result = $GLOBALS['xoopsDB']->query($SQL);
        $fields = [];
        while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
            $fields[] = $row['id'];
            $configValues[] = $row;

        }
        $this->configValues = isset($configValues) ? $configValues : '';
        //print_r ($this->configValues); exit();
        */
        unset($fieldsHandler, $criteria);

        return $this->fields;
    }

    /**
     * @return array
     */
    public function getConfig()
    {
        return $this->configValues;
    }
}