Passed
Push — master ( 492cc7...e5a5fc )
by Michael
45s queued 11s
created
language/english/modinfo.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 define('_MI_NEWBB_INSTALL_FORUM_DESC', 'Forum for test.');
217 217
 define('_MI_NEWBB_INSTALL_POST_SUBJECT', 'Congratulations! The forum is working.');
218 218
 define('_MI_NEWBB_INSTALL_POST_TEXT', '
219
-    Welcome to ' . htmlspecialchars($GLOBALS['xoopsConfig']['sitename'], ENT_QUOTES) . ' forum.
219
+    Welcome to ' . htmlspecialchars($GLOBALS['xoopsConfig']['sitename'], ENT_QUOTES).' forum.
220 220
     Feel free to register and login to start your topics.
221 221
 
222 222
     If you have any question concerning NewBB usage, please visit your local support site or [url=https://xoops.org/modules/newbb/]XOOPS Support Site[/url].
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 //Help
326 326
 define('_MI_NEWBB_HELP', 'Help');
327 327
 define('_MI_NEWBB_DIRNAME', basename(dirname(dirname(__DIR__))));
328
-define('_MI_NEWBB_HELP_HEADER', __DIR__ . '/help/helpheader.tpl');
328
+define('_MI_NEWBB_HELP_HEADER', __DIR__.'/help/helpheader.tpl');
329 329
 define('_MI_NEWBB_BACK_2_ADMIN', 'Back to Administration of ');
330 330
 define('_MI_NEWBB_OVERVIEW', 'Overview');
331 331
 
Please login to merge, or discard this patch.
xoops_version.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
  * @package        module::newbb
10 10
  */
11 11
 
12
-require_once __DIR__   . '/preloads/autoloader.php';
12
+require_once __DIR__.'/preloads/autoloader.php';
13 13
 
14 14
 $moduleDirName = basename(__DIR__);
15 15
 
@@ -46,24 +46,24 @@  discard block
 block discarded – undo
46 46
     'sqlfile'             => ['mysql' => 'sql/mysql.sql'],
47 47
     // ------------------- Tables ----------------------------
48 48
     'tables'              => [
49
-        $moduleDirName . '_' . 'archive',
50
-        $moduleDirName . '_' . 'categories',
51
-        $moduleDirName . '_' . 'votedata',
52
-        $moduleDirName . '_' . 'forums',
53
-        $moduleDirName . '_' . 'posts',
54
-        $moduleDirName . '_' . 'posts_text',
55
-        $moduleDirName . '_' . 'topics',
56
-        $moduleDirName . '_' . 'online',
57
-        $moduleDirName . '_' . 'digest',
58
-        $moduleDirName . '_' . 'report',
59
-        $moduleDirName . '_' . 'attachments',
60
-        $moduleDirName . '_' . 'moderates',
61
-        $moduleDirName . '_' . 'reads_forum',
62
-        $moduleDirName . '_' . 'reads_topic',
63
-        $moduleDirName . '_' . 'type',
64
-        $moduleDirName . '_' . 'type_forum',
65
-        $moduleDirName . '_' . 'stats',
66
-        $moduleDirName . '_' . 'user_stats'
49
+        $moduleDirName.'_'.'archive',
50
+        $moduleDirName.'_'.'categories',
51
+        $moduleDirName.'_'.'votedata',
52
+        $moduleDirName.'_'.'forums',
53
+        $moduleDirName.'_'.'posts',
54
+        $moduleDirName.'_'.'posts_text',
55
+        $moduleDirName.'_'.'topics',
56
+        $moduleDirName.'_'.'online',
57
+        $moduleDirName.'_'.'digest',
58
+        $moduleDirName.'_'.'report',
59
+        $moduleDirName.'_'.'attachments',
60
+        $moduleDirName.'_'.'moderates',
61
+        $moduleDirName.'_'.'reads_forum',
62
+        $moduleDirName.'_'.'reads_topic',
63
+        $moduleDirName.'_'.'type',
64
+        $moduleDirName.'_'.'type_forum',
65
+        $moduleDirName.'_'.'stats',
66
+        $moduleDirName.'_'.'user_stats'
67 67
     ],
68 68
     // ------------------- Admin Menu -------------------
69 69
     'system_menu'         => 1,
@@ -604,7 +604,7 @@  discard block
 block discarded – undo
604 604
     'description' => '_MI_NEWBB_ANONYMOUS_PRE_DESC',
605 605
     'formtype'    => 'textbox',
606 606
     'valuetype'   => 'text',
607
-    'default'     => $GLOBALS['xoopsConfig']['anonymous'] . '-'
607
+    'default'     => $GLOBALS['xoopsConfig']['anonymous'].'-'
608 608
 ];
609 609
 $modversion['config'][] = [
610 610
     'name'        => 'allow_require_reply',
@@ -731,7 +731,7 @@  discard block
 block discarded – undo
731 731
     'item_name'      => 'topic_id',
732 732
     'allow_bookmark' => 1,
733 733
 ];
734
-$modversion['notification']['category'][]  = [
734
+$modversion['notification']['category'][] = [
735 735
     'name'           => 'forum',
736 736
     'title'          => _MI_NEWBB_FORUM_NOTIFY,
737 737
     'description'    => _MI_NEWBB_FORUM_NOTIFYDSC,
@@ -739,13 +739,13 @@  discard block
 block discarded – undo
739 739
     'item_name'      => 'forum',
740 740
     'allow_bookmark' => 1,
741 741
 ];
742
-$modversion['notification']['category'][]  = [
742
+$modversion['notification']['category'][] = [
743 743
     'name'           => 'global',
744 744
     'title'          => _MI_NEWBB_GLOBAL_NOTIFY,
745 745
     'description'    => _MI_NEWBB_GLOBAL_NOTIFYDSC,
746 746
     'subscribe_from' => 'index.php',
747 747
 ];
748
-$modversion['notification']['event'][]     = [
748
+$modversion['notification']['event'][] = [
749 749
     'name'          => 'new_post',
750 750
     'category'      => 'thread',
751 751
     'title'         => _MI_NEWBB_THREAD_NEWPOST_NOTIFY,
@@ -754,7 +754,7 @@  discard block
 block discarded – undo
754 754
     'mail_template' => 'thread_newpost_notify',
755 755
     'mail_subject'  => _MI_NEWBB_THREAD_NEWPOST_NOTIFYSBJ,
756 756
 ];
757
-$modversion['notification']['event'][]     = [
757
+$modversion['notification']['event'][] = [
758 758
     'name'          => 'new_thread',
759 759
     'category'      => 'forum',
760 760
     'title'         => _MI_NEWBB_FORUM_NEWTHREAD_NOTIFY,
@@ -763,7 +763,7 @@  discard block
 block discarded – undo
763 763
     'mail_template' => 'forum_newthread_notify',
764 764
     'mail_subject'  => _MI_NEWBB_FORUM_NEWTHREAD_NOTIFYSBJ,
765 765
 ];
766
-$modversion['notification']['event'][]     = [
766
+$modversion['notification']['event'][] = [
767 767
     'name'          => 'new_forum',
768 768
     'category'      => 'global',
769 769
     'title'         => _MI_NEWBB_GLOBAL_NEWFORUM_NOTIFY,
@@ -772,7 +772,7 @@  discard block
 block discarded – undo
772 772
     'mail_template' => 'global_newforum_notify',
773 773
     'mail_subject'  => _MI_NEWBB_GLOBAL_NEWFORUM_NOTIFYSBJ,
774 774
 ];
775
-$modversion['notification']['event'][]     = [
775
+$modversion['notification']['event'][] = [
776 776
     'name'          => 'new_post',
777 777
     'category'      => 'global',
778 778
     'title'         => _MI_NEWBB_GLOBAL_NEWPOST_NOTIFY,
@@ -781,7 +781,7 @@  discard block
 block discarded – undo
781 781
     'mail_template' => 'global_newpost_notify',
782 782
     'mail_subject'  => _MI_NEWBB_GLOBAL_NEWPOST_NOTIFYSBJ,
783 783
 ];
784
-$modversion['notification']['event'][]     = [
784
+$modversion['notification']['event'][] = [
785 785
     'name'          => 'new_post',
786 786
     'category'      => 'forum',
787 787
     'title'         => _MI_NEWBB_FORUM_NEWPOST_NOTIFY,
@@ -790,7 +790,7 @@  discard block
 block discarded – undo
790 790
     'mail_template' => 'forum_newpost_notify',
791 791
     'mail_subject'  => _MI_NEWBB_FORUM_NEWPOST_NOTIFYSBJ,
792 792
 ];
793
-$modversion['notification']['event'][]     = [
793
+$modversion['notification']['event'][] = [
794 794
     'name'          => 'new_fullpost',
795 795
     'category'      => 'global',
796 796
     'admin_only'    => 1,
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
800 800
     'mail_template' => 'global_newfullpost_notify',
801 801
     'mail_subject'  => _MI_NEWBB_GLOBAL_NEWFULLPOST_NOTIFYSBJ,
802 802
 ];
803
-$modversion['notification']['event'][]     = [
803
+$modversion['notification']['event'][] = [
804 804
     'name'          => 'digest',
805 805
     'category'      => 'global',
806 806
     'title'         => _MI_NEWBB_GLOBAL_DIGEST_NOTIFY,
@@ -809,7 +809,7 @@  discard block
 block discarded – undo
809 809
     'mail_template' => 'global_digest_notify',
810 810
     'mail_subject'  => _MI_NEWBB_GLOBAL_DIGEST_NOTIFYSBJ,
811 811
 ];
812
-$modversion['notification']['event'][]     = [
812
+$modversion['notification']['event'][] = [
813 813
     'name'          => 'new_fullpost',
814 814
     'category'      => 'forum',
815 815
     'admin_only'    => 1,
Please login to merge, or discard this patch.
newtopic.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -11,17 +11,17 @@  discard block
 block discarded – undo
11 11
 
12 12
 use Xmf\Request;
13 13
 
14
-require_once __DIR__ . '/header.php';
14
+require_once __DIR__.'/header.php';
15 15
 
16 16
 if (!$forum = Request::getString('forum', '', 'GET')) {
17
-    redirect_header(XOOPS_URL . '/index.php', 2, _MD_NEWBB_ERRORFORUM);
17
+    redirect_header(XOOPS_URL.'/index.php', 2, _MD_NEWBB_ERRORFORUM);
18 18
 }
19 19
 
20 20
 ///** @var Newbb\ForumHandler $forumHandler */
21 21
 //$forumHandler = Newbb\Helper::getInstance()->getHandler('Forum');
22 22
 $forumObject = $forumHandler->get($forum);
23 23
 if (!$forumHandler->getPermission($forumObject)) {
24
-    redirect_header(XOOPS_URL . '/index.php', 2, _NOPERM);
24
+    redirect_header(XOOPS_URL.'/index.php', 2, _NOPERM);
25 25
 }
26 26
 
27 27
 ///** @var Newbb\TopicHandler $topicHandler */
@@ -36,12 +36,12 @@  discard block
 block discarded – undo
36 36
     $query_array = [];
37 37
     foreach ($query_vars as $var) {
38 38
         if (Request::getString($var, '', 'GET')) {
39
-            $query_array[$var] = "{$var}=" . Request::getString($var, '', 'GET');
39
+            $query_array[$var] = "{$var}=".Request::getString($var, '', 'GET');
40 40
         }
41 41
     }
42 42
     $page_query = htmlspecialchars(implode('&', array_values($query_array)), ENT_QUOTES | ENT_HTML5);
43 43
     unset($query_array);
44
-    redirect_header(XOOPS_URL . "/modules/newbb/viewforum.php?{$page_query}", 2, _MD_NEWBB_NORIGHTTOPOST);
44
+    redirect_header(XOOPS_URL."/modules/newbb/viewforum.php?{$page_query}", 2, _MD_NEWBB_NORIGHTTOPOST);
45 45
 }
46 46
 
47 47
 if ($GLOBALS['xoopsModuleConfig']['wol_enabled']) {
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 $attachsig     = (is_object($GLOBALS['xoopsUser']) && $GLOBALS['xoopsUser']->getVar('attachsig')) ? 1 : 0;
71 71
 $post_id       = 0;
72 72
 $topic_id      = 0;
73
-require_once __DIR__   . '/include/form.post.php';
73
+require_once __DIR__.'/include/form.post.php';
74 74
 
75
-require_once __DIR__ . '/footer.php';
75
+require_once __DIR__.'/footer.php';
76 76
 require_once $GLOBALS['xoops']->path('footer.php');
Please login to merge, or discard this patch.
notification_update.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,5 +28,5 @@
 block discarded – undo
28 28
 // URL: http://www.myweb.ne.jp/, https://xoops.org/, http://jp.xoops.org/ //
29 29
 // Project: XOOPS Project                                                    //
30 30
 // ------------------------------------------------------------------------- //
31
-require_once dirname(dirname(__DIR__)) . '/mainfile.php';
31
+require_once dirname(dirname(__DIR__)).'/mainfile.php';
32 32
 require_once $GLOBALS['xoops']->path('include/notification_update.php');
Please login to merge, or discard this patch.
class/GroupPermForm.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
         foreach (array_keys($glist) as $i) {
55 55
             // get selected item id(s) for each group
56 56
             $selected = $grouppermHandler->getItemIds($this->_permName, $i, $this->_modid);
57
-            $ele      = new Newbb\GroupFormCheckBox($glist[$i], 'perms[' . $this->_permName . ']', $i, $selected);
57
+            $ele      = new Newbb\GroupFormCheckBox($glist[$i], 'perms['.$this->_permName.']', $i, $selected);
58 58
             $ele->setOptionTree($this->_itemTree);
59 59
             $this->addElement($ele);
60 60
             unset($ele);
@@ -63,19 +63,19 @@  discard block
 block discarded – undo
63 63
         $tray->addElement(new \XoopsFormButton('', 'submit', _SUBMIT, 'submit'));
64 64
         $tray->addElement(new \XoopsFormButton('', 'reset', _CANCEL, 'reset'));
65 65
         $this->addElement($tray);
66
-        $ret      = '<br><strong>' . $this->getTitle() . '</strong><br>' . $this->_permDesc . '<br>';
67
-        $ret      .= "<form name='" . $this->getName() . "' id='" . $this->getName() . "' action='" . $this->getAction() . "' method='" . $this->getMethod() . "'" . $this->getExtra() . ">\n<table width='100%' class='outer' cellspacing='1' valign='top'>\n";
66
+        $ret      = '<br><strong>'.$this->getTitle().'</strong><br>'.$this->_permDesc.'<br>';
67
+        $ret .= "<form name='".$this->getName()."' id='".$this->getName()."' action='".$this->getAction()."' method='".$this->getMethod()."'".$this->getExtra().">\n<table width='100%' class='outer' cellspacing='1' valign='top'>\n";
68 68
         $elements = $this->getElements();
69 69
         $hidden   = '';
70 70
         foreach (array_keys($elements) as $i) {
71 71
             if (!is_object($elements[$i])) {
72 72
                 $ret .= $elements[$i];
73 73
             } elseif (!$elements[$i]->isHidden()) {
74
-                $ret .= "<tr valign='top' align='left'><td class='head'>" . $elements[$i]->getCaption();
74
+                $ret .= "<tr valign='top' align='left'><td class='head'>".$elements[$i]->getCaption();
75 75
                 if ('' !== $elements[$i]->getDescription()) {
76
-                    $ret .= '<br><br><span style="font-weight: normal;">' . $elements[$i]->getDescription() . '</span>';
76
+                    $ret .= '<br><br><span style="font-weight: normal;">'.$elements[$i]->getDescription().'</span>';
77 77
                 }
78
-                $ret .= "</td>\n<td class='even' style='text-align:center;'>\n" . $elements[$i]->render() . "\n</td></tr>\n";
78
+                $ret .= "</td>\n<td class='even' style='text-align:center;'>\n".$elements[$i]->render()."\n</td></tr>\n";
79 79
             } else {
80 80
                 $hidden .= $elements[$i]->render();
81 81
             }
Please login to merge, or discard this patch.
class/Common/FilesManagement.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
                     throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
33 33
                 }
34 34
 
35
-                file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
35
+                file_put_contents($folder.'/index.html', '<script>history.go(-1);</script>');
36 36
             }
37 37
         } catch (\Exception $e) {
38 38
             echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
@@ -58,14 +58,14 @@  discard block
 block discarded – undo
58 58
         $dir = opendir($src);
59 59
         //        @mkdir($dst);
60 60
         if (!@mkdir($dst) && !is_dir($dst)) {
61
-            throw new \RuntimeException('The directory ' . $dst . ' could not be created.');
61
+            throw new \RuntimeException('The directory '.$dst.' could not be created.');
62 62
         }
63 63
             while (false !== ($file = readdir($dir))) {
64 64
                 if (('.' !== $file) && ('..' !== $file)) {
65
-                    if (is_dir($src . '/' . $file)) {
66
-                        self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
65
+                    if (is_dir($src.'/'.$file)) {
66
+                        self::recurseCopy($src.'/'.$file, $dst.'/'.$file);
67 67
                     } else {
68
-                        copy($src . '/' . $file, $dst . '/' . $file);
68
+                        copy($src.'/'.$file, $dst.'/'.$file);
69 69
                     }
70 70
                 }
71 71
             }
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
                 self::rrmdir($fObj->getPathname());
160 160
             }
161 161
         }
162
-        $iterator = null;   // clear iterator Obj to close file/directory
162
+        $iterator = null; // clear iterator Obj to close file/directory
163 163
         return rmdir($src); // remove the directory & return results
164 164
     }
165 165
 
@@ -192,14 +192,14 @@  discard block
 block discarded – undo
192 192
         $iterator = new \DirectoryIterator($src);
193 193
         foreach ($iterator as $fObj) {
194 194
             if ($fObj->isFile()) {
195
-                rename($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
195
+                rename($fObj->getPathname(), "{$dest}/".$fObj->getFilename());
196 196
             } elseif (!$fObj->isDot() && $fObj->isDir()) {
197 197
                 // Try recursively on directory
198
-                self::rmove($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
198
+                self::rmove($fObj->getPathname(), "{$dest}/".$fObj->getFilename());
199 199
                 //                rmdir($fObj->getPath()); // now delete the directory
200 200
             }
201 201
         }
202
-        $iterator = null;   // clear iterator Obj to close file/directory
202
+        $iterator = null; // clear iterator Obj to close file/directory
203 203
         return rmdir($src); // remove the directory & return results
204 204
     }
205 205
 
@@ -235,9 +235,9 @@  discard block
 block discarded – undo
235 235
         $iterator = new \DirectoryIterator($src);
236 236
         foreach ($iterator as $fObj) {
237 237
             if ($fObj->isFile()) {
238
-                copy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
238
+                copy($fObj->getPathname(), "{$dest}/".$fObj->getFilename());
239 239
             } elseif (!$fObj->isDot() && $fObj->isDir()) {
240
-                self::rcopy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
240
+                self::rcopy($fObj->getPathname(), "{$dest}/".$fObj->getFilename());
241 241
             }
242 242
         }
243 243
         return true;
Please login to merge, or discard this patch.
class/ReadForumHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
 
33 33
 use XoopsModules\Newbb;
34 34
 
35
-require_once __DIR__ . '/Read.php';
35
+require_once __DIR__.'/Read.php';
36 36
 
37 37
 /**
38 38
  * A handler for read/unread handling
Please login to merge, or discard this patch.
class/Helper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
             $this->initConfig();
67 67
         }
68 68
         $this->configs[$name] = $value;
69
-        $this->addLog("Setting config '{$name}' : " . $this->configs[$name]);
69
+        $this->addLog("Setting config '{$name}' : ".$this->configs[$name]);
70 70
 
71 71
         return $this->configs[$name];
72 72
     }
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
     public function getHandler($name)
90 90
     {
91 91
         $db    = \XoopsDatabaseFactory::getDatabaseConnection();
92
-        $class = '\\XoopsModules\\' . ucfirst(strtolower(basename(dirname(__DIR__)))) . '\\' . $name . 'Handler';
92
+        $class = '\\XoopsModules\\'.ucfirst(strtolower(basename(dirname(__DIR__)))).'\\'.$name.'Handler';
93 93
         $ret   = new $class($db);
94 94
 
95 95
         return $ret;
Please login to merge, or discard this patch.
class/User.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -81,13 +81,13 @@  discard block
 block discarded – undo
81 81
     $level              = [];
82 82
     $level['level']     = $showlevel;
83 83
     $level['exp']       = $ep;
84
-    $level['exp_width'] = $ep . '%';
84
+    $level['exp_width'] = $ep.'%';
85 85
     $level['hp']        = $hp;
86 86
     $level['hp_max']    = $maxhp;
87
-    $level['hp_width']  = $hpf . '%';
87
+    $level['hp_width']  = $hpf.'%';
88 88
     $level['mp']        = $mp;
89 89
     $level['mp_max']    = $maxmp;
90
-    $level['mp_width']  = $mpf . '%';
90
+    $level['mp_width']  = $mpf.'%';
91 91
 
92 92
     return $level;
93 93
 }
@@ -117,49 +117,49 @@  discard block
 block discarded – undo
117 117
 
118 118
         $user               = $this->user;
119 119
         $userbar['profile'] = [
120
-            'link' => XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid'),
120
+            'link' => XOOPS_URL.'/userinfo.php?uid='.$user->getVar('uid'),
121 121
             'name' => _PROFILE
122 122
         ];
123 123
 
124 124
         if (is_object($GLOBALS['xoopsUser'])) {
125 125
             $userbar['pm'] = [
126
-                'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . $user->getVar('uid') . "', 'pmlite', 450, 380);",
126
+                'link' => "javascript:void openWithSelfMain('".XOOPS_URL.'/pmlite.php?send2=1&amp;to_userid='.$user->getVar('uid')."', 'pmlite', 450, 380);",
127 127
                 'name' => _MD_NEWBB_PM
128 128
             ];
129 129
         }
130 130
         if ($user->getVar('user_viewemail') || $isAdmin) {
131 131
             $userbar['email'] = [
132
-                'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "', 'new');",
132
+                'link' => "javascript:void window.open('mailto:".$user->getVar('email')."', 'new');",
133 133
                 'name' => _MD_NEWBB_EMAIL
134 134
             ];
135 135
         }
136 136
         if ($url = $user->getVar('url')) {
137 137
             $userbar['url'] = [
138
-                'link' => "javascript:void window.open('" . $url . "', 'new');",
138
+                'link' => "javascript:void window.open('".$url."', 'new');",
139 139
                 'name' => _MD_NEWBB_WWW
140 140
             ];
141 141
         }
142 142
         if ($icq = $user->getVar('user_icq')) {
143 143
             $userbar['icq'] = [
144
-                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $icq . "', 'new');",
144
+                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=".$icq."', 'new');",
145 145
                 'name' => _MD_NEWBB_ICQ
146 146
             ];
147 147
         }
148 148
         if ($aim = $user->getVar('user_aim')) {
149 149
             $userbar['aim'] = [
150
-                'link' => "javascript:void window.open('aim:goim?screenname=" . $aim . '&amp;message=Hi+' . $aim . '+Are+you+there?' . "', 'new');",
150
+                'link' => "javascript:void window.open('aim:goim?screenname=".$aim.'&amp;message=Hi+'.$aim.'+Are+you+there?'."', 'new');",
151 151
                 'name' => _MD_NEWBB_AIM
152 152
             ];
153 153
         }
154 154
         if ($yim = $user->getVar('user_yim')) {
155 155
             $userbar['yim'] = [
156
-                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $yim . '&.src=pg' . "', 'new');",
156
+                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=".$yim.'&.src=pg'."', 'new');",
157 157
                 'name' => _MD_NEWBB_YIM
158 158
             ];
159 159
         }
160 160
         if ($msn = $user->getVar('user_msnm')) {
161 161
             $userbar['msnm'] = [
162
-                'link' => "javascript:void window.open('http://members.msn.com?mem=" . $msn . "', 'new');",
162
+                'link' => "javascript:void window.open('http://members.msn.com?mem=".$msn."', 'new');",
163 163
                 'name' => _MD_NEWBB_MSNM
164 164
             ];
165 165
         }
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
                 $rpg_path    = $iconHandler->getPath('rpg');
184 184
                 foreach (['img_left', 'img_backing', 'img_right', 'blue', 'green', 'orange'] as $img) {
185 185
                     // irmtfan fix: double "/" removed
186
-                    $rpg_images[$img] = XOOPS_URL . $rpg_path . '/' . $img . '.gif';
186
+                    $rpg_images[$img] = XOOPS_URL.$rpg_path.'/'.$img.'.gif';
187 187
                 }
188 188
             }
189 189
             // irmtfan hardcore removed align="left"
@@ -195,13 +195,13 @@  discard block
 block discarded – undo
195 195
                      . $rpg_images['img_right']
196 196
                      . "' alt='' /></td></tr></table>";
197 197
 
198
-            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '<br><span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>' . sprintf($table, $rpg_images['orange'], $level['hp_width']);
199
-            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span><br>' . sprintf($table, $rpg_images['green'], $level['mp_width']);
200
-            $info .= '<span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>' . sprintf($table, $rpg_images['blue'], $level['exp_width']);
198
+            $info = _MD_NEWBB_LEVEL.' '.$level['level'].'<br><span title="'._MD_NEWBB_HP_DESC.'">'._MD_NEWBB_HP.' '.$level['hp'].' / '.$level['hp_max'].'</span><br>'.sprintf($table, $rpg_images['orange'], $level['hp_width']);
199
+            $info .= '<span title="'._MD_NEWBB_MP_DESC.'">'._MD_NEWBB_MP.' '.$level['mp'].' / '.$level['mp_max'].'</span><br>'.sprintf($table, $rpg_images['green'], $level['mp_width']);
200
+            $info .= '<span title="'._MD_NEWBB_EXP_DESC.'">'._MD_NEWBB_EXP.' '.$level['exp'].'</span><br>'.sprintf($table, $rpg_images['blue'], $level['exp_width']);
201 201
         } else {
202
-            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '; <span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>';
203
-            $info .= '<span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>';
204
-            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span>';
202
+            $info = _MD_NEWBB_LEVEL.' '.$level['level'].'; <span title="'._MD_NEWBB_EXP_DESC.'">'._MD_NEWBB_EXP.' '.$level['exp'].'</span><br>';
203
+            $info .= '<span title="'._MD_NEWBB_HP_DESC.'">'._MD_NEWBB_HP.' '.$level['hp'].' / '.$level['hp_max'].'</span><br>';
204
+            $info .= '<span title="'._MD_NEWBB_MP_DESC.'">'._MD_NEWBB_MP.' '.$level['mp'].' / '.$level['mp_max'].'</span>';
205 205
         }
206 206
 
207 207
         return $info;
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
         $name             = empty($GLOBALS['xoopsModuleConfig']['show_realname']) ? $user->getVar('uname') : $user->getVar('name');
232 232
         $userinfo['name'] = $name ?: $user->getVar('uname');
233 233
 
234
-        $userinfo['link'] = '<a href=\'' . XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid') . '\'>' . $userinfo['name'] . '</a>';
234
+        $userinfo['link'] = '<a href=\''.XOOPS_URL.'/userinfo.php?uid='.$user->getVar('uid').'\'>'.$userinfo['name'].'</a>';
235 235
 
236 236
         $userinfo['avatar'] = $user->getVar('user_avatar');
237 237
         // START hacked by irmtfan - easier rank getting - consistency with previous version back rank.title and rank.image
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
         // END hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
255 255
         $userinfo['from'] = $user->getVar('user_from');
256 256
 
257
-        require_once  dirname(__DIR__) . '/include/functions.time.php';
257
+        require_once  dirname(__DIR__).'/include/functions.time.php';
258 258
         $userinfo['regdate']    = newbbFormatTimestamp($user->getVar('user_regdate'), 'reg');
259 259
         $userinfo['last_login'] = newbbFormatTimestamp($user->getVar('last_login')); // irmtfan add last_login
260 260
 
Please login to merge, or discard this patch.