mambax7 / newbb5

class/CategoryHandler.php

Spacing +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
         if (!$valid_ids = $this->getIdsByPermission($permission)) {
             return $categories;
         }
-        $criteria = new \Criteria('cat_id', '(' . implode(', ', $valid_ids) . ')', 'IN');
+        $criteria = new \Criteria('cat_id', '('.implode(', ', $valid_ids).')', 'IN');
         $criteria->setSort('cat_order');
         $categories = $this->getAll($criteria, $tags, $asObject);
 
@@ -115,7 +115,7 @@ 
             return true;
         }
 
-        $cat_id = is_object($category) ? $category->getVar('cat_id') : (int)$category;
+        $cat_id = is_object($category) ? $category->getVar('cat_id') : (int) $category;
         /** @var PermissionHandler $permHandler */
         $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
         return $permHandler->getPermission('category', $perm, $cat_id);

class/plugins/plugin.tag.php

Spacing +2 added lines, -2 removed lines

@@ -42,13 +42,13 @@
         // catid is not used in newbb, so just skip it
         foreach (array_keys($items[$cat_id]) as $item_id) {
             // In newbb, the item_id is "topic_id"
-            $items_id[] = (int)$item_id;
+            $items_id[] = (int) $item_id;
         }
     }
     /** @var TopicHandler $itemHandler */
     $itemHandler = Newbb\Helper::getInstance()->getHandler('Topic');
     /** @var \XoopsObject $itemsObject */
-    $itemsObject = $itemHandler->getObjects(new \Criteria('topic_id', '(' . implode(', ', $items_id) . ')', 'IN'), true);
+    $itemsObject = $itemHandler->getObjects(new \Criteria('topic_id', '('.implode(', ', $items_id).')', 'IN'), true);
 
     foreach (array_keys($items) as $cat_id) {
         foreach (array_keys($items[$cat_id]) as $item_id) {

class/TopicHandler.php

Spacing +27 added lines, -27 removed lines

@@ -88,9 +88,9 @@ 
     {
         $topic_id = $object->getVar('topic_id');
         if ($force) {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = -1 WHERE topic_id = {$topic_id}";
+            $sql = 'UPDATE '.$this->db->prefix('newbb_topics')." SET approved = -1 WHERE topic_id = {$topic_id}";
         } else {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = 1 WHERE topic_id = {$topic_id}";
+            $sql = 'UPDATE '.$this->db->prefix('newbb_topics')." SET approved = 1 WHERE topic_id = {$topic_id}";
         }
         if (!$result = $this->db->queryF($sql)) {
             //xoops_error($this->db->error());
@@ -130,7 +130,7 @@ 
     {
         $topic = null;
         if (!empty($action)) {
-            $sql = 'SELECT * FROM ' . $this->table . ' WHERE 1=1' . (($forum_id > 0) ? ' AND forum_id=' . (int)$forum_id : '') . ' AND topic_id ' . (($action > 0) ? '>' : '<') . (int)$topic_id . ' ORDER BY topic_id ' . (($action > 0) ? 'ASC' : 'DESC') . ' LIMIT 1';
+            $sql = 'SELECT * FROM '.$this->table.' WHERE 1=1'.(($forum_id > 0) ? ' AND forum_id='.(int) $forum_id : '').' AND topic_id '.(($action > 0) ? '>' : '<').(int) $topic_id.' ORDER BY topic_id '.(($action > 0) ? 'ASC' : 'DESC').' LIMIT 1';
             if ($result = $this->db->query($sql)) {
                 if ($row = $this->db->fetchArray($result)) {
                     $topic = $this->create(false);
@@ -152,8 +152,8 @@ 
     public function &getByPost($post_id)
     {
         $topic  = null;
-        $sql    = 'SELECT t.* FROM ' . $this->db->prefix('newbb_topics') . ' t, ' . $this->db->prefix('newbb_posts') . ' p
-                WHERE t.topic_id = p.topic_id AND p.post_id = ' . (int)$post_id;
+        $sql    = 'SELECT t.* FROM '.$this->db->prefix('newbb_topics').' t, '.$this->db->prefix('newbb_posts').' p
+                WHERE t.topic_id = p.topic_id AND p.post_id = ' . (int) $post_id;
         $result = $this->db->query($sql);
         if (!$result) {
             //xoops_error($this->db->error());
@@ -200,10 +200,10 @@ 
     public function &getTopPost($topic_id)
     {
         $post = null;
-        $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p,
-            ' . $this->db->prefix('newbb_posts_text') . ' t
+        $sql  = 'SELECT p.*, t.* FROM '.$this->db->prefix('newbb_posts').' p,
+            ' . $this->db->prefix('newbb_posts_text').' t
             WHERE
-            p.topic_id = ' . $topic_id . ' AND p.pid = 0
+            p.topic_id = ' . $topic_id.' AND p.pid = 0
             AND t.post_id = p.post_id';
 
         $result = $this->db->query($sql);
@@ -227,7 +227,7 @@ 
      */
     public function getTopPostId($topic_id)
     {
-        $sql    = 'SELECT MIN(post_id) AS post_id FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id = ' . $topic_id . ' AND pid = 0';
+        $sql    = 'SELECT MIN(post_id) AS post_id FROM '.$this->db->prefix('newbb_posts').' WHERE topic_id = '.$topic_id.' AND pid = 0';
         $result = $this->db->query($sql);
         if (!$result) {
             //xoops_error($this->db->error());
@@ -250,8 +250,8 @@ 
     public function &getAllPosts(&$topic, $order = 'ASC', $perpage = 10, &$start, $post_id = 0, $type = '')
     {
         $ret     = [];
-        $perpage = ((int)$perpage > 0) ? (int)$perpage : (empty($GLOBALS['xoopsModuleConfig']['posts_per_page']) ? 10 : $GLOBALS['xoopsModuleConfig']['posts_per_page']);
-        $start   = (int)$start;
+        $perpage = ((int) $perpage > 0) ? (int) $perpage : (empty($GLOBALS['xoopsModuleConfig']['posts_per_page']) ? 10 : $GLOBALS['xoopsModuleConfig']['posts_per_page']);
+        $start   = (int) $start;
         switch ($type) {
             case 'pending':
                 $approveCriteria = ' AND p.approved = 0';
@@ -272,17 +272,17 @@ 
                 $operator_for_position = '<';
             }
             //$approveCriteria = ' AND approved = 1'; // any others?
-            $sql    = 'SELECT COUNT(*) FROM ' . $this->db->prefix('newbb_posts') . ' AS p WHERE p.topic_id=' . (int)$topic->getVar('topic_id') . $approveCriteria . " AND p.post_id $operator_for_position $post_id";
+            $sql    = 'SELECT COUNT(*) FROM '.$this->db->prefix('newbb_posts').' AS p WHERE p.topic_id='.(int) $topic->getVar('topic_id').$approveCriteria." AND p.post_id $operator_for_position $post_id";
             $result = $this->db->query($sql);
             if (!$result) {
                 //xoops_error($this->db->error());
                 return $ret;
             }
             list($position) = $this->db->fetchRow($result);
-            $start = (int)($position / $perpage) * $perpage;
+            $start = (int) ($position / $perpage) * $perpage;
         }
 
-        $sql    = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p, ' . $this->db->prefix('newbb_posts_text') . ' t WHERE p.topic_id=' . $topic->getVar('topic_id') . ' AND p.post_id = t.post_id' . $approveCriteria . " ORDER BY p.post_id $order";
+        $sql    = 'SELECT p.*, t.* FROM '.$this->db->prefix('newbb_posts').' p, '.$this->db->prefix('newbb_posts_text').' t WHERE p.topic_id='.$topic->getVar('topic_id').' AND p.post_id = t.post_id'.$approveCriteria." ORDER BY p.post_id $order";
         $result = $this->db->query($sql, $perpage, $start);
         if (!$result) {
             //xoops_error($this->db->error());
@@ -327,18 +327,18 @@ 
         $postArray['post_time'] = newbbFormatTimestamp($postArray['post_time']);
 
         if (!empty($postArray['icon'])) {
-            $postArray['icon'] = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($postArray['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
+            $postArray['icon'] = '<img src="'.XOOPS_URL.'/images/subject/'.htmlspecialchars($postArray['icon'], ENT_QUOTES | ENT_HTML5).'" alt="" />';
         } else {
-            $postArray['icon'] = '<a name="' . $postArray['post_id'] . '"><img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" /></a>';
+            $postArray['icon'] = '<a name="'.$postArray['post_id'].'"><img src="'.XOOPS_URL.'/images/icons/no_posticon.gif" alt="" /></a>';
         }
 
-        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id=' . $topic->getVar('topic_id') . '&amp;forum=' . $postArray['forum_id'] . '&amp;post_id=' . $postArray['post_id'] . '">' . $postArray['subject'] . '</a>';
+        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id='.$topic->getVar('topic_id').'&amp;forum='.$postArray['forum_id'].'&amp;post_id='.$postArray['post_id'].'">'.$postArray['subject'].'</a>';
 
         $isActiveUser = false;
         if (isset($viewtopic_users[$postArray['uid']]['name'])) {
             $postArray['poster'] = $viewtopic_users[$postArray['uid']]['name'];
             if ($postArray['uid'] > 0) {
-                $postArray['poster'] = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $postArray['uid'] . '">' . $viewtopic_users[$postArray['uid']]['name'] . '</a>';
+                $postArray['poster'] = '<a href="'.XOOPS_URL.'/userinfo.php?uid='.$postArray['uid'].'">'.$viewtopic_users[$postArray['uid']]['name'].'</a>';
             }
         } else {
             $postArray['poster'] = empty($postArray['poster_name']) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $postArray['poster_name'];
@@ -354,7 +354,7 @@ 
      */
     public function &getAllPosters(&$topic, $isApproved = true)
     {
-        $sql = 'SELECT DISTINCT uid FROM ' . $this->db->prefix('newbb_posts') . '  WHERE topic_id=' . $topic->getVar('topic_id') . ' AND uid>0';
+        $sql = 'SELECT DISTINCT uid FROM '.$this->db->prefix('newbb_posts').'  WHERE topic_id='.$topic->getVar('topic_id').' AND uid>0';
         if ($isApproved) {
             $sql .= ' AND approved = 1';
         }
@@ -378,7 +378,7 @@ 
      */
     public function delete(\XoopsObject $topic, $force = true)
     {
-        $topic_id = is_object($topic) ? $topic->getVar('topic_id') : (int)$topic;
+        $topic_id = is_object($topic) ? $topic->getVar('topic_id') : (int) $topic;
         if (empty($topic_id)) {
             return false;
         }
@@ -408,12 +408,12 @@ 
     public function getPermission($forum, $topic_locked = 0, $type = 'view')
     {
         static $_cachedTopicPerms;
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
+        require_once  dirname(__DIR__).'/include/functions.user.php';
         if (newbbIsAdmin($forum)) {
             return true;
         }
 
-        $forum_id = is_object($forum) ? $forum->getVar('forum_id') : (int)$forum;
+        $forum_id = is_object($forum) ? $forum->getVar('forum_id') : (int) $forum;
         if ($forum_id < 1) {
             return false;
         }
@@ -457,14 +457,14 @@ 
         // irmtfan if 0 no cleanup look include/plugin.php
         if (!func_num_args()) {
             $newbbConfig = newbbLoadConfig();
-            $expire      = isset($newbbConfig['pending_expire']) ? (int)$newbbConfig['pending_expire'] : 7;
+            $expire      = isset($newbbConfig['pending_expire']) ? (int) $newbbConfig['pending_expire'] : 7;
             $expire      = $expire * 24 * 3600; // days to seconds
         }
         if (empty($expire)) {
             return false;
         }
         $crit_expire = new \CriteriaCompo(new \Criteria('approved', 0, '<='));
-        $crit_expire->add(new \Criteria('topic_time', time() - (int)$expire, '<'));
+        $crit_expire->add(new \Criteria('topic_time', time() - (int) $expire, '<'));
 
         return $this->deleteAll($crit_expire, true/*, true*/);
     }
@@ -479,7 +479,7 @@ 
     public function synchronization($object = null, $force = true)
     {
         if (!is_object($object)) {
-            $object = $this->get((int)$object);
+            $object = $this->get((int) $object);
         }
         if (!is_object($object) || !$object->getVar('topic_id')) {
             return false;
@@ -505,7 +505,7 @@ 
         }
         $b1 = $this->insert($object, $force);
         $criteria->add(new \Criteria('post_id', $top_post, '<>'), 'AND');
-        $criteria->add(new \Criteria('pid', '(' . implode(', ', $post_ids) . ')', 'NOT IN'), 'AND');
+        $criteria->add(new \Criteria('pid', '('.implode(', ', $post_ids).')', 'NOT IN'), 'AND');
         $b2       = $postHandler->updateAll('pid', $top_post, $criteria, $force);
         $criteria = new \CriteriaCompo();
         $criteria->add(new \Criteria('post_id', $top_post, '='), 'AND');
@@ -526,7 +526,7 @@ 
         $allDirs  = xoops_getActiveModules();
         foreach ($allDirs as $dirname) {
             // pollresults.php file is exist in all xoopspoll versions and umfrage versions
-            if (file_exists($GLOBALS['xoops']->path('modules/' . $dirname . '/pollresults.php'))) {
+            if (file_exists($GLOBALS['xoops']->path('modules/'.$dirname.'/pollresults.php'))) {
                 $pollDirs[$dirname] = $dirname;
             }
         }

class/PermissionForumHandler.php

Spacing +15 added lines, -15 removed lines

@@ -37,7 +37,7 @@ 
     {
         //        $this->PermissionHandler($db);
         parent::__construct($db);
-        $this->templateFilename = XOOPS_VAR_PATH . '/configs/newbb_permission_template.php';
+        $this->templateFilename = XOOPS_VAR_PATH.'/configs/newbb_permission_template.php';
     }
 
     /**
@@ -47,16 +47,16 @@ 
     public function getValidPerms($fullname = false)
     {
         static $validPerms = [];
-        if (isset($validPerms[(int)$fullname])) {
-            return $validPerms[(int)$fullname];
+        if (isset($validPerms[(int) $fullname])) {
+            return $validPerms[(int) $fullname];
         }
         $items = array_filter(array_map('trim', explode(',', FORUM_PERM_ITEMS)));
         if (!empty($fullname)) {
             foreach (array_keys($items) as $key) {
-                $items[$key] = 'forum_' . $items[$key];
+                $items[$key] = 'forum_'.$items[$key];
             }
         }
-        $validPerms[(int)$fullname] = $items;
+        $validPerms[(int) $fullname] = $items;
 
         return $items;
     }
@@ -74,7 +74,7 @@ 
             return $full_items;
         }
 
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
+        require_once  dirname(__DIR__).'/include/functions.user.php';
         $uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
         $ip  = \Xmf\IPAddress::fromRequest()->asReadable();
         if (!empty($GLOBALS['xoopsModuleConfig']['enable_usermoderate']) && !isset($suspension[$uid][$id])
@@ -133,18 +133,18 @@ 
         }
         // Create criteria for getting only the permissions regarding this module and this user's groups
         $criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
-        $criteria->add(new \Criteria('gperm_groupid', '(' . implode(',', $groups) . ')', 'IN'));
+        $criteria->add(new \Criteria('gperm_groupid', '('.implode(',', $groups).')', 'IN'));
         if ($id) {
             if (is_array($id)) {
-                $criteria->add(new \Criteria('gperm_itemid', '(' . implode(',', $id) . ')', 'IN'));
+                $criteria->add(new \Criteria('gperm_itemid', '('.implode(',', $id).')', 'IN'));
             } else {
-                $criteria->add(new \Criteria('gperm_itemid', (int)$id));
+                $criteria->add(new \Criteria('gperm_itemid', (int) $id));
             }
         }
         $gperm_names = implode(', ', $this->getValidItems($modid, $id));
 
         // Add criteria for gpermnames
-        $criteria->add(new \Criteria('gperm_name', '(' . $gperm_names . ')', 'IN'));
+        $criteria->add(new \Criteria('gperm_name', '('.$gperm_names.')', 'IN'));
         // Get all permission objects in this module and for this user's groups
         $userpermissions = $this->getObjects($criteria, true);
 
@@ -182,12 +182,12 @@ 
                 continue;
             }
             if ($isAdmin
-                || (isset($permission_set[$forumId]['forum_' . $item])
+                || (isset($permission_set[$forumId]['forum_'.$item])
                     && (!$topic_locked
                         || 'view' === $item))) {
-                $perm[] = constant('_MD_NEWBB_CAN_' . strtoupper($item));
+                $perm[] = constant('_MD_NEWBB_CAN_'.strtoupper($item));
             } else {
-                $perm[] = constant('_MD_NEWBB_CANNOT_' . strtoupper($item));
+                $perm[] = constant('_MD_NEWBB_CANNOT_'.strtoupper($item));
             }
         }
 
@@ -200,14 +200,14 @@ 
      */
     public function deleteByForum($forum_id)
     {
-        $forum_id = (int)$forum_id;
+        $forum_id = (int) $forum_id;
         if (empty($forum_id)) {
             return false;
         }
         $grouppermHandler = xoops_getHandler('groupperm');
         $criteria     = new \CriteriaCompo(new \Criteria('gperm_modid', $GLOBALS['xoopsModule']->getVar('mid')));
         $items        = $this->getValidPerms(true);
-        $criteria->add(new \Criteria('gperm_name', "('" . implode("', '", $items) . "')", 'IN'));
+        $criteria->add(new \Criteria('gperm_name', "('".implode("', '", $items)."')", 'IN'));
         $criteria->add(new \Criteria('gperm_itemid', $forum_id));
 
         return $grouppermHandler->deleteAll($criteria);

class/ReportHandler.php

Spacing +7 added lines, -7 removed lines

@@ -40,7 +40,7 @@ 
         if (!is_array($posts)) {
             $posts = [$posts];
         }
-        $post_criteria = new \Criteria('post_id', '(' . implode(', ', $posts) . ')', 'IN');
+        $post_criteria = new \Criteria('post_id', '('.implode(', ', $posts).')', 'IN');
         $ret           = $this->getAll($post_criteria);
 
         return $ret;
@@ -79,26 +79,26 @@ 
         if (empty($start)) {
             $start = 0;
         }
-        $result_criteria = ' AND r.report_result = ' . $report_result;
+        $result_criteria = ' AND r.report_result = '.$report_result;
 
         if ($forums) {
             $forumCriteria = '';
         } elseif (!is_array($forums)) {
             $forums        = [$forums];
-            $forumCriteria = ' AND p.forum_id IN (' . implode(',', $forums) . ')';
+            $forumCriteria = ' AND p.forum_id IN ('.implode(',', $forums).')';
         }
-        $tables_criteria = ' FROM ' . $this->db->prefix('newbb_report') . ' r, ' . $this->db->prefix('newbb_posts') . ' p WHERE r.post_id= p.post_id';
+        $tables_criteria = ' FROM '.$this->db->prefix('newbb_report').' r, '.$this->db->prefix('newbb_posts').' p WHERE r.post_id= p.post_id';
 
         if ($report_id) {
-            $result = $this->db->query('SELECT COUNT(*) as report_count' . $tables_criteria . $forumCriteria . $result_criteria . " AND report_id $operator_for_position $report_id" . $order_criteria);
+            $result = $this->db->query('SELECT COUNT(*) as report_count'.$tables_criteria.$forumCriteria.$result_criteria." AND report_id $operator_for_position $report_id".$order_criteria);
             if ($result) {
                 $row = $this->db->fetchArray($result);
             }
             $position = $row['report_count'];
-            $start    = (int)($position / $perpage) * $perpage;
+            $start    = (int) ($position / $perpage) * $perpage;
         }
 
-        $sql    = 'SELECT r.*, p.subject, p.topic_id, p.forum_id' . $tables_criteria . $forumCriteria . $result_criteria . $order_criteria;
+        $sql    = 'SELECT r.*, p.subject, p.topic_id, p.forum_id'.$tables_criteria.$forumCriteria.$result_criteria.$order_criteria;
         $result = $this->db->query($sql, $perpage, $start);
         $ret    = [];
         //$reportHandler =  Newbb\Helper::getInstance()->getHandler('Report');

class/Xmlrss.php

Spacing +3 added lines, -3 removed lines

@@ -85,7 +85,7 @@ 
     {
         if (count($this->items) < $this->max_items) {
             if (!empty($label)) {
-                $label = '[' . $this->cleanup($label) . ']';
+                $label = '['.$this->cleanup($label).']';
             }
             if (!empty($description)) {
                 $description = $this->cleanup($description, $this->max_item_description);
@@ -94,7 +94,7 @@ 
                 //$description = $label;
             }
 
-            $title         = $this->cleanup($title) . ' ' . $label;
+            $title         = $this->cleanup($title).' '.$label;
             $pubdate       = $this->cleanup($pubdate);
             $this->items[] = [
                 'title'       => $title,
@@ -119,7 +119,7 @@ 
             $text = \XoopsLocal::convert_encoding($text, 'utf-8');
         }
         if (!empty($trim)) {
-            $text = xoops_substr($text, 0, (int)$trim);
+            $text = xoops_substr($text, 0, (int) $trim);
         }
         $text = htmlspecialchars($text, ENT_QUOTES);
 

class/UserstatsHandler.php

Spacing +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
     public function get($id = null, $fields = null) //get($id)
     {
         $object = null;
-        if (!$id = (int)$id) {
+        if (!$id = (int) $id) {
             return $object;
         }
         $object = $this->create(false);
@@ -82,7 +82,7 @@ 
         if (empty($id)) {
             return null;
         }
-        $sql = 'SELECT * FROM ' . $this->table . ' WHERE ' . $this->keyName . ' = ' . (int)$id;
+        $sql = 'SELECT * FROM '.$this->table.' WHERE '.$this->keyName.' = '.(int) $id;
         if (!$result = $this->db->query($sql)) {
             return null;
         }

class/ModerateHandler.php

Spacing +9 added lines, -9 removed lines

@@ -36,7 +36,7 @@ 
      */
     public function clearGarbage($expire = 0)
     {
-        $expire = time() - (int)$expire;
+        $expire = time() - (int) $expire;
         $sql    = sprintf('DELETE FROM `%s` WHERE mod_end < %u', $this->db->prefix('newbb_moderates'), $expire);
         $this->db->queryF($sql);
     }
@@ -58,12 +58,12 @@ 
             return true;
         }
 
-        $uid = ($uid < 0) ? (is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0) : (int)$uid;
+        $uid = ($uid < 0) ? (is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0) : (int) $uid;
 
-        $criteria      = new \CriteriaCompo(new \Criteria('uid', (int)$uid));
+        $criteria      = new \CriteriaCompo(new \Criteria('uid', (int) $uid));
         $forumCriteria = new \CriteriaCompo(new \Criteria('forum_id', 0), 'OR');
         if (!empty($forum)) {
-            $forumCriteria->add(new \Criteria('forum_id', (int)$forum), 'OR');
+            $forumCriteria->add(new \Criteria('forum_id', (int) $forum), 'OR');
         }
         $criteria->add($forumCriteria);
         $criteria->add(new \Criteria('mod_end', time(), '>'));
@@ -90,7 +90,7 @@ 
             $checkIp = new IPAddress($modIp);
             if (false !== $checkIp->asReadable()) {
                 $defaultMask = (6 === $checkIp->ipVersion()) ? 128 : 32;
-                $netMask     = isset($parts[1]) ? (int)$parts[1] : $defaultMask;
+                $netMask     = isset($parts[1]) ? (int) $parts[1] : $defaultMask;
                 if ($checkIp->sameSubnet($ip, $netMask, $netMask)) {
                     return false; // IP is banned
                 }
@@ -112,16 +112,16 @@ 
     {
         $ips = [];
         if ($isUid) {
-            $criteria = 'uid =' . (int)$item;
+            $criteria = 'uid ='.(int) $item;
         } else {
             $ip_segs = explode('.', $item);
             $segs    = min(count($ip_segs), 4);
             for ($i = 1; $i <= $segs; ++$i) {
                 $ips[] = $this->db->quoteString(implode('.', array_slice($ip_segs, 0, $i)));
             }
-            $criteria = 'ip IN(' . implode(',', $ips) . ')';
+            $criteria = 'ip IN('.implode(',', $ips).')';
         }
-        $sql = 'SELECT MAX(mod_end) AS expire FROM ' . $this->db->prefix('newbb_moderates') . ' WHERE ' . $criteria;
+        $sql = 'SELECT MAX(mod_end) AS expire FROM '.$this->db->prefix('newbb_moderates').' WHERE '.$criteria;
         if (!$result = $this->db->query($sql)) {
             return -1;
         }
@@ -140,7 +140,7 @@ 
      */
     public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
     {
-        $sql = 'DELETE FROM ' . $this->table . ' WHERE (forum_id >0 AND forum_id NOT IN ( SELECT DISTINCT forum_id FROM ' . $this->db->prefix('newbb_forums') . ') )';
+        $sql = 'DELETE FROM '.$this->table.' WHERE (forum_id >0 AND forum_id NOT IN ( SELECT DISTINCT forum_id FROM '.$this->db->prefix('newbb_forums').') )';
         if (!$result = $this->db->queryF($sql)) {
             //xoops_error($this->db->error());
             return false;

class/PermissionHandler.php

Spacing +4 added lines, -4 removed lines

@@ -52,7 +52,7 @@ 
     {
         if (!isset($this->_handler[$name])) {
 //            require_once __DIR__ . "/permission.{$name}.php";
-            $className             = '\\XoopsModules\\Newbb\\Permission' . ucfirst($name) . 'Handler';
+            $className             = '\\XoopsModules\\Newbb\\Permission'.ucfirst($name).'Handler';
             $this->_handler[$name] = new $className($this->db);
         }
 
@@ -252,7 +252,7 @@ 
             }
         } else {
             $grouppermHandler = xoops_getHandler('groupperm');
-            $criteria     = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
+            $criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
             if (!empty($perm_name) && 'forum_all' !== $perm_name && 'category_all' !== $perm_name) {
                 $criteria->add(new \Criteria('gperm_name', $perm_name));
             }
@@ -260,7 +260,7 @@ 
 
             foreach ($permissions as $gperm) {
                 $item_id                                         = $gperm->getVar('gperm_itemid');
-                $group_id                                        = (int)$gperm->getVar('gperm_groupid');
+                $group_id                                        = (int) $gperm->getVar('gperm_groupid');
                 $perms[$gperm->getVar('gperm_name')][$item_id][] = $group_id;
             }
         }
@@ -331,7 +331,7 @@ 
         $ret      = false;
         $criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $gperm_modid));
         $criteria->add(new \Criteria('gperm_name', $gperm_name));
-        $gperm_itemid = (int)$gperm_itemid;
+        $gperm_itemid = (int) $gperm_itemid;
         if ($gperm_itemid > 0) {
             $criteria->add(new \Criteria('gperm_itemid', $gperm_itemid));
         }