mambax7 /
newbb5
These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
| 1 | <?php |
||
| 35 | |||
| 36 | if (Request::getString('submit', '', 'POST')) { |
||
| 37 | foreach (['forum', 'newforum', 'newtopic'] as $getint) { |
||
| 38 | ${$getint} = Request::getInt($getint, 0, 'POST');// (int)(@$_POST[$getint]); |
||
|
|
|||
| 39 | } |
||
| 40 | foreach (['topic_id'] as $getint) { |
||
| 41 | ${$getint} = Request::getInt($getint, 0, 'POST');// (int)(@$_POST[$getint]); |
||
| 42 | } |
||
| 43 | if (!is_array($topic_id)) { |
||
| 44 | $topic_id = [$topic_id]; |
||
| 45 | } |
||
| 46 | } else { |
||
| 47 | foreach (['forum', 'topic_id'] as $getint) { |
||
| 48 | ${$getint} = Request::getInt($getint, 0, 'GET');// (int)(@$_GET[$getint]); |
||
| 49 | } |
||
| 50 | } |
||
| 51 | |||
| 52 | View Code Duplication | if (empty($topic_id)) { |
|
| 53 | $redirect = empty($forum_id) ? 'index.php' : 'viewforum.php?forum={$forum}'; |
||
| 54 | $redirect = XOOPS_URL . '/modules/newbb/' . $redirect; |
||
| 55 | redirect_header($redirect, 2, _MD_NEWBB_ERRORTOPIC); |
||
| 111 | include_once $GLOBALS['xoops']->path('header.php'); |
||
| 112 | |||
| 113 | if (Request::getString('submit', '', 'POST')) { |
||
| 114 | $mode = Request::getString('mode', '', 'POST');// $_POST['mode']; |
||
| 115 | |||
| 116 | if ('delete' === $mode) { |
||
| 117 | foreach ($topic_id as $tid) { |
||
| 120 | // irmtfan - sync topic after delete |
||
| 121 | $topicHandler->synchronization($topicObject); |
||
| 122 | $forumHandler->synchronization($forum); |
||
| 123 | //$topicObject->loadFilters("delete"); |
||
| 124 | //sync($topic_id, "topic"); |
||
| 125 | //xoops_notification_deletebyitem ($xoopsModule->getVar('mid'), 'thread', $topic_id); |
||
| 126 | } |
||
| 127 | // irmtfan full URL |
||
| 128 | echo $action[$mode]['msg'] . "<p><a href='" . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/viewforum.php?forum=$forum'>" . _MD_NEWBB_RETURNTOTHEFORUM . "</a></p><p><a href='index.php'>" . _MD_NEWBB_RETURNFORUMINDEX . '</a></p>'; |
||
| 129 | } elseif ('restore' === $mode) { |
||
| 130 | //$topicHandler = xoops_getModuleHandler('topic', 'newbb'); |
||
| 131 | $forums = []; |
||
| 132 | $topicsObject = $topicHandler->getAll(new Criteria('topic_id', '(' . implode(',', $topic_id) . ')', 'IN')); |
||
| 133 | foreach (array_keys($topicsObject) as $id) { |
||
| 184 | $criteria = new CriteriaCompo($criteria_topic); |
||
| 185 | $criteria->add(new Criteria('pid', 0)); |
||
| 186 | // irmtfan OR change to this for less query?: |
||
| 187 | // $postHandler->updateAll("pid", $newtopicObject->getVar("topic_last_post_id"), $criteria, true); |
||
| 188 | $postHandler->updateAll('pid', $topicHandler->getTopPostId($newtopic), $criteria, true); |
||
| 189 | $postHandler->updateAll('topic_id', $newtopic, $criteria_topic, true); |
||
| 190 | // irmtfan update vote data instead of deleting them |
||
| 192 | |||
| 193 | $topic_views = $topicObject->getVar('topic_views') + $newtopicObject->getVar('topic_views'); |
||
| 194 | // irmtfan better method to update topic_views in new topic |
||
| 195 | //$criteria_newtopic = new Criteria('topic_id', $newtopic); |
||
| 196 | //$topicHandler->updateAll('topic_views', $topic_views, $criteria_newtopic, true); |
||
| 197 | $newtopicObject->setVar('topic_views', $topic_views); |
||
| 198 | // START irmtfan poll_module and rewrite the method |
||
| 199 | // irmtfan only move poll in old topic to new topic if new topic has not a poll |
||
| 206 | $topicObject->setVar('poll_id', 0);// set to not delete the poll |
||
| 207 | } |
||
| 208 | //update and sync newtopic after merge |
||
| 209 | //$topicHandler->insert($newtopicObject, true); |
||
| 210 | $topicHandler->synchronization($newtopicObject); // very important: only use object |
||
| 211 | //sync newforum after merge |
||
| 212 | $newforum = $newtopicObject->getVar('forum_id'); |
||
| 213 | $forumHandler->synchronization($newforum); |
||
| 214 | //hardcode remove force to delete old topic from database |
||
| 215 | //$topicHandler->delete($topicObject,true); // cannot use this |
||
| 216 | $topicHandler->deleteAll($criteria_topic, true); // $force = true |
||
| 217 | //delete poll if old topic had a poll |
||
| 218 | $topicObject->deletePoll($poll_id); |
||
| 329 | $categories = $categoryHandler->getByPermission('access'); |
||
| 330 | $forums = $forumHandler->getForumsByCategory(array_keys($categories), 'post', false); |
||
| 331 | |||
| 332 | View Code Duplication | if (count($categories) > 0 && count($forums) > 0) { |
|
| 333 | foreach (array_keys($forums) as $key) { |
||
| 334 | /** @var \NewbbCategory[] $categories */ |
||
| 335 | $box .= "<option value='-1'>[" . $categories[$key]->getVar('cat_title') . ']</option>'; |
||
| 369 |
mambax7
Loading history...
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.