mambax7 / newbb5

newtopic.php

<?php
/**
 * NewBB 5.0x,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
 * @since          4.00
 * @package        module::newbb
 */

use Xmf\Request;

include_once __DIR__ . '/header.php';

if (!$forum = Request::getString('forum', '', 'GET')) {
    redirect_header(XOOPS_URL . '/index.php', 2, _MD_NEWBB_ERRORFORUM);
}

///** @var \NewbbForumHandler $forumHandler */

50% of this comment could be valid code. Did you maybe forget this after debugging?

//$forumHandler = xoops_getModuleHandler('forum');
$forumObject    = $forumHandler->get($forum);
if (!$forumHandler->getPermission($forumObject)) {
    redirect_header(XOOPS_URL . '/index.php', 2, _NOPERM);
}

///** @var \NewbbTopicHandler $topicHandler */

54% of this comment could be valid code. Did you maybe forget this after debugging?

//$topicHandler = xoops_getModuleHandler('topic', 'newbb');
$topicObject    = $topicHandler->create();
$topicObject->setVar('forum_id', $forum);
if (!$topicHandler->getPermission($forumObject, 0, 'post')) {

This code seems to be duplicated across your project.

    /*
     * Build the page query
     */
    $query_vars  = ['forum', 'order', 'mode', 'viewmode'];

$query_vars does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $query_array = [];

$query_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    foreach ($query_vars as $var) {

$query_vars does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (Request::getString($var, '', 'GET')) {
            $query_array[$var] = "{$var}=" . Request::getString($var, '', 'GET');

$query_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
    }
    $page_query = htmlspecialchars(implode('&', array_values($query_array)));

$page_query does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    unset($query_array);

$query_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    redirect_header(XOOPS_URL . "/modules/newbb/viewforum.php?{$page_query}", 2, _MD_NEWBB_NORIGHTTOPOST);

$page_query does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

}

if ($GLOBALS['xoopsModuleConfig']['wol_enabled']) {
//    /** @var \NewbbOnlineHandler $onlineHandler */

42% of this comment could be valid code. Did you maybe forget this after debugging?

//    $onlineHandler = xoops_getModuleHandler('online', 'newbb');
    $onlineHandler->init($forumObject);
}

$xoopsOption['template_main']                                        = 'newbb_edit_post.tpl';
$GLOBALS['xoopsConfig']['module_cache'][$xoopsModule->getVar('mid')] = 0; // Disable cache
include_once $GLOBALS['xoops']->path('header.php');

if (1 == $GLOBALS['xoopsModuleConfig']['disc_show'] || 3 == $GLOBALS['xoopsModuleConfig']['disc_show']) {

This code seems to be duplicated across your project.

    $xoopsTpl->assign('disclaimer', $GLOBALS['xoopsModuleConfig']['disclaimer']);
}

$subject       = '';
$message       = '';
$dohtml        = 1;
$dosmiley      = 1;
$doxcode       = 1;
$dobr          = 1;
$icon          = '';
$post_karma    = 0;

$post_karma does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$require_reply = 0;

$require_reply does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$attachsig     = (is_object($GLOBALS['xoopsUser']) && $GLOBALS['xoopsUser']->getVar('attachsig')) ? 1 : 0;
$post_id       = 0;

$post_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$topic_id      = 0;

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

include __DIR__ . '/include/form.post.php';

include_once __DIR__ . '/footer.php';
include $GLOBALS['xoops']->path('footer.php');