mambax7 / newbb5

class/ReadForum.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 //  URL: https://xoops.org                                                    //
 //  Project: Article Project                                                 //
 //  ------------------------------------------------------------------------ //
-require_once __DIR__ . '/read.php';
+require_once __DIR__.'/read.php';
 
 /**
  * A handler for read/unread handling

class/ReadtopicHandler.php

Spacing +3 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
 
 use XoopsModules\Newbb;
 
-require_once __DIR__ . '/read.php';
+require_once __DIR__.'/read.php';
 
 /**
  * A handler for read/unread handling
@@ -176,7 +176,7 @@ 
             $sticky_id = $itemHandler->getIds($criteria_sticky);
             $items     = $items_id + $sticky_id;
             $criteria  = new \CriteriaCompo(new \Criteria('uid', $uid));
-            $criteria->add(new \Criteria('read_item', '(' . implode(', ', $items) . ')', 'IN'));
+            $criteria->add(new \Criteria('read_item', '('.implode(', ', $items).')', 'IN'));
             $this->deleteAll($criteria, true);
 
             return true;
@@ -184,7 +184,7 @@ 
 
         $itemsObject  = $itemHandler->getAll($criteria_topic, ['topic_last_post_id']);
         $stickyObject = $itemHandler->getAll($criteria_sticky, ['topic_last_post_id']);
-        $itemsObject  += $stickyObject;
+        $itemsObject += $stickyObject;
         $items        = [];
         foreach (array_keys($itemsObject) as $key) {
             $items[$key] = $itemsObject[$key]->getVar('topic_last_post_id');

class/Readtopic.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 //  URL: https://xoops.org                                                    //
 //  Project: Article Project                                                 //
 //  ------------------------------------------------------------------------ //
-require_once __DIR__ . '/read.php';
+require_once __DIR__.'/read.php';
 
 /**
  * A handler for read/unread handling

class/UserHandler.php

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
         if (empty($this->users) || !$this->enableOnline) {
             return;
         }
-        require_once __DIR__ . '/../include/functions.render.php';
+        require_once __DIR__.'/../include/functions.render.php';
         $image_online  = newbbDisplayImage('online', _MD_NEWBB_ONLINE);
         $image_offline = newbbDisplayImage('offline', _MD_NEWBB_OFFLINE);
 
@@ -83,7 +83,7 @@ 
             return;
         }
 
-        $sql    = 'SELECT user_digests, uid FROM ' . $GLOBALS['xoopsDB']->prefix('newbb_user_stats') . ' WHERE uid IN( ' . implode(', ', array_keys($this->users)) . ')';
+        $sql    = 'SELECT user_digests, uid FROM '.$GLOBALS['xoopsDB']->prefix('newbb_user_stats').' WHERE uid IN( '.implode(', ', array_keys($this->users)).')';
         $result = $GLOBALS['xoopsDB']->query($sql);
         while (false !== ($myrow = $GLOBALS['xoopsDB']->fetchArray($result))) {
             $this->userlist[$myrow['uid']]['digests'] = (int)$myrow['user_digests'];

class/IconHandler.php

Spacing +13 added lines, -13 removed lines

@@ -95,23 +95,23 @@ 
     public function getPath($type, $dirname = 'newbb', $default = '', $endDir = 'images')
     {
         static $paths;
-        if (isset($paths[$endDir . '/' . $type])) {
-            return $paths[$endDir . '/' . $type];
+        if (isset($paths[$endDir.'/'.$type])) {
+            return $paths[$endDir.'/'.$type];
         }
 
         $theme_path = $this->template->currentTheme->path;
         $rel_dir    = "modules/{$dirname}/{$endDir}";
         // START irmtfan add default for all pathes
         if (empty($default)) {
-            $path = is_dir($theme_path . "/{$rel_dir}/{$type}/") ? $theme_path . "/{$rel_dir}/{$type}"
-                : (is_dir(XOOPS_THEME_PATH . "/default/{$rel_dir}/{$type}/") ? XOOPS_THEME_PATH . "/default/{$rel_dir}/{$type}"
+            $path = is_dir($theme_path."/{$rel_dir}/{$type}/") ? $theme_path."/{$rel_dir}/{$type}"
+                : (is_dir(XOOPS_THEME_PATH."/default/{$rel_dir}/{$type}/") ? XOOPS_THEME_PATH . "/default/{$rel_dir}/{$type}"
                 : $GLOBALS['xoops']->path("modules/{$dirname}/templates/{$endDir}/{$type}"));
         } else {
-            $path = is_dir($theme_path . "/{$rel_dir}/{$type}/") ? $theme_path . "/{$rel_dir}/{$type}" : (
-                is_dir($theme_path . "/{$rel_dir}/{$default}/") ? $theme_path . "/{$rel_dir}/{$default}" : (
-                is_dir(XOOPS_THEME_PATH . "/default/{$rel_dir}/{$type}/") ? XOOPS_THEME_PATH
+            $path = is_dir($theme_path."/{$rel_dir}/{$type}/") ? $theme_path."/{$rel_dir}/{$type}" : (
+                is_dir($theme_path."/{$rel_dir}/{$default}/") ? $theme_path."/{$rel_dir}/{$default}" : (
+                is_dir(XOOPS_THEME_PATH."/default/{$rel_dir}/{$type}/") ? XOOPS_THEME_PATH
                  . "/default/{$rel_dir}/{$type}" : (
-                     is_dir(XOOPS_THEME_PATH . "/default/{$rel_dir}/{$default}/") ? XOOPS_THEME_PATH . "/default/{$rel_dir}/{$default}"
+                     is_dir(XOOPS_THEME_PATH."/default/{$rel_dir}/{$default}/") ? XOOPS_THEME_PATH . "/default/{$rel_dir}/{$default}"
                     : (is_dir($GLOBALS['xoops']->path("modules/{$dirname}/templates/{$endDir}/{$type}/")) ? $GLOBALS['xoops']->path("modules/{$dirname}/templates/{$endDir}/{$type}")
                     : $GLOBALS['xoops']->path("modules/{$dirname}/templates/{$endDir}/{$default}")) // XOOPS_ROOT_PATH
             ) // XOOPS_THEME_PATH {$default}
@@ -119,9 +119,9 @@ 
             ); // $theme_path {$default}
         }
         // END irmtfan add default for all pathes
-        $paths[$endDir . '/' . $type] = str_replace(XOOPS_ROOT_PATH, '', str_replace('\\', '/', $path));
+        $paths[$endDir.'/'.$type] = str_replace(XOOPS_ROOT_PATH, '', str_replace('\\', '/', $path));
 
-        return $paths[$endDir . '/' . $type];
+        return $paths[$endDir.'/'.$type];
     }
 
     // END irmtfan - improve to get other "end dirnames" like "css" and "js" - change images with $endDir
@@ -136,8 +136,8 @@ 
     ) {
         $this->forumImage = include $GLOBALS['xoops']->path("modules/{$dirname}/include/images.php");
 
-        $this->forumImage['icon']     = XOOPS_URL . $this->getPath('icon', $dirname) . '/';
-        $this->forumImage['language'] = XOOPS_URL . $this->getPath("language/{$language}", $dirname, 'language/english') . '/';
+        $this->forumImage['icon']     = XOOPS_URL.$this->getPath('icon', $dirname).'/';
+        $this->forumImage['language'] = XOOPS_URL.$this->getPath("language/{$language}", $dirname, 'language/english').'/';
     }
 
     /**
@@ -161,7 +161,7 @@ 
      */
     public function getImageSource($image)
     {
-        return $this->forumImage[$this->forumImage[$image]] . $this->prefix . $image . $this->postfix;
+        return $this->forumImage[$this->forumImage[$image]].$this->prefix.$image.$this->postfix;
     }
 
     /**

class/PermissionForumHandler.php

Spacing +10 added lines, -10 removed lines

@@ -37,7 +37,7 @@ 
     {
         //        $this->PermissionHandler($db);
         parent::__construct($db);
-        $this->templateFilename = XOOPS_VAR_PATH . '/configs/newbb_permission_template.php';
+        $this->templateFilename = XOOPS_VAR_PATH.'/configs/newbb_permission_template.php';
     }
 
     /**
@@ -53,7 +53,7 @@ 
         $items = array_filter(array_map('trim', explode(',', FORUM_PERM_ITEMS)));
         if (!empty($fullname)) {
             foreach (array_keys($items) as $key) {
-                $items[$key] = 'forum_' . $items[$key];
+                $items[$key] = 'forum_'.$items[$key];
             }
         }
         $validPerms[(int)$fullname] = $items;
@@ -74,7 +74,7 @@ 
             return $full_items;
         }
 
-        require_once __DIR__ . '/../include/functions.user.php';
+        require_once __DIR__.'/../include/functions.user.php';
         $uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
         $ip  = \Xmf\IPAddress::fromRequest()->asReadable();
         if (!empty($GLOBALS['xoopsModuleConfig']['enable_usermoderate']) && !isset($suspension[$uid][$id])
@@ -133,10 +133,10 @@ 
         }
         // Create criteria for getting only the permissions regarding this module and this user's groups
         $criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
-        $criteria->add(new \Criteria('gperm_groupid', '(' . implode(',', $groups) . ')', 'IN'));
+        $criteria->add(new \Criteria('gperm_groupid', '('.implode(',', $groups).')', 'IN'));
         if ($id) {
             if (is_array($id)) {
-                $criteria->add(new \Criteria('gperm_itemid', '(' . implode(',', $id) . ')', 'IN'));
+                $criteria->add(new \Criteria('gperm_itemid', '('.implode(',', $id).')', 'IN'));
             } else {
                 $criteria->add(new \Criteria('gperm_itemid', (int)$id));
             }
@@ -144,7 +144,7 @@ 
         $gperm_names = implode(', ', $this->getValidItems($modid, $id));
 
         // Add criteria for gpermnames
-        $criteria->add(new \Criteria('gperm_name', '(' . $gperm_names . ')', 'IN'));
+        $criteria->add(new \Criteria('gperm_name', '('.$gperm_names.')', 'IN'));
         // Get all permission objects in this module and for this user's groups
         $userpermissions = $this->getObjects($criteria, true);
 
@@ -182,12 +182,12 @@ 
                 continue;
             }
             if ($isAdmin
-                || (isset($permission_set[$forumId]['forum_' . $item])
+                || (isset($permission_set[$forumId]['forum_'.$item])
                     && (!$topic_locked
                         || 'view' === $item))) {
-                $perm[] = constant('_MD_NEWBB_CAN_' . strtoupper($item));
+                $perm[] = constant('_MD_NEWBB_CAN_'.strtoupper($item));
             } else {
-                $perm[] = constant('_MD_NEWBB_CANNOT_' . strtoupper($item));
+                $perm[] = constant('_MD_NEWBB_CANNOT_'.strtoupper($item));
             }
         }
 
@@ -207,7 +207,7 @@ 
         $gpermHandler = xoops_getHandler('groupperm');
         $criteria     = new \CriteriaCompo(new \Criteria('gperm_modid', $GLOBALS['xoopsModule']->getVar('mid')));
         $items        = $this->getValidPerms(true);
-        $criteria->add(new \Criteria('gperm_name', "('" . implode("', '", $items) . "')", 'IN'));
+        $criteria->add(new \Criteria('gperm_name', "('".implode("', '", $items)."')", 'IN'));
         $criteria->add(new \Criteria('gperm_itemid', $forum_id));
 
         return $gpermHandler->deleteAll($criteria);

class/Helper.php

Spacing +3 added lines, -3 removed lines

@@ -34,7 +34,7 @@ 
      */
     protected function __construct($debug = false)
     {
-        $this->debug   = $debug;
+        $this->debug = $debug;
         parent::__construct(basename(dirname(__DIR__)));
     }
 
@@ -65,7 +65,7 @@ 
             $this->initConfig();
         }
         $this->configs[$name] = $value;
-        $this->addLog("Setting config '{$name}' : " . $this->configs[$name]);
+        $this->addLog("Setting config '{$name}' : ".$this->configs[$name]);
 
         return $this->configs[$name];
     }
@@ -89,7 +89,7 @@ 
     {
         $ret   = false;
         $db    = \XoopsDatabaseFactory::getDatabaseConnection();
-        $class = '\\XoopsModules\\' . ucfirst(strtolower(basename(dirname(__DIR__)))) . '\\' . $name . 'Handler';
+        $class = '\\XoopsModules\\'.ucfirst(strtolower(basename(dirname(__DIR__)))).'\\'.$name.'Handler';
         $ret   = new $class($db);
         return $ret;
     }

class/TopicHandler.php

Spacing +18 added lines, -18 removed lines

@@ -88,9 +88,9 @@ 
     {
         $topic_id = $object->getVar('topic_id');
         if ($force) {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = -1 WHERE topic_id = {$topic_id}";
+            $sql = 'UPDATE '.$this->db->prefix('newbb_topics')." SET approved = -1 WHERE topic_id = {$topic_id}";
         } else {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = 1 WHERE topic_id = {$topic_id}";
+            $sql = 'UPDATE '.$this->db->prefix('newbb_topics')." SET approved = 1 WHERE topic_id = {$topic_id}";
         }
         if (!$result = $this->db->queryF($sql)) {
             //xoops_error($this->db->error());
@@ -130,7 +130,7 @@ 
     {
         $topic = null;
         if (!empty($action)) {
-            $sql = 'SELECT * FROM ' . $this->table . ' WHERE 1=1' . (($forum_id > 0) ? ' AND forum_id=' . (int)$forum_id : '') . ' AND topic_id ' . (($action > 0) ? '>' : '<') . (int)$topic_id . ' ORDER BY topic_id ' . (($action > 0) ? 'ASC' : 'DESC') . ' LIMIT 1';
+            $sql = 'SELECT * FROM '.$this->table.' WHERE 1=1'.(($forum_id > 0) ? ' AND forum_id='.(int)$forum_id : '').' AND topic_id '.(($action > 0) ? '>' : '<').(int)$topic_id.' ORDER BY topic_id '.(($action > 0) ? 'ASC' : 'DESC').' LIMIT 1';
             if ($result = $this->db->query($sql)) {
                 if ($row = $this->db->fetchArray($result)) {
                     $topic = $this->create(false);
@@ -152,7 +152,7 @@ 
     public function &getByPost($post_id)
     {
         $topic  = null;
-        $sql    = 'SELECT t.* FROM ' . $this->db->prefix('newbb_topics') . ' t, ' . $this->db->prefix('newbb_posts') . ' p
+        $sql    = 'SELECT t.* FROM '.$this->db->prefix('newbb_topics').' t, '.$this->db->prefix('newbb_posts').' p
                 WHERE t.topic_id = p.topic_id AND p.post_id = ' . (int)$post_id;
         $result = $this->db->query($sql);
         if (!$result) {
@@ -200,10 +200,10 @@ 
     public function &getTopPost($topic_id)
     {
         $post = null;
-        $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p,
-            ' . $this->db->prefix('newbb_posts_text') . ' t
+        $sql  = 'SELECT p.*, t.* FROM '.$this->db->prefix('newbb_posts').' p,
+            ' . $this->db->prefix('newbb_posts_text').' t
             WHERE
-            p.topic_id = ' . $topic_id . ' AND p.pid = 0
+            p.topic_id = ' . $topic_id.' AND p.pid = 0
             AND t.post_id = p.post_id';
 
         $result = $this->db->query($sql);
@@ -227,7 +227,7 @@ 
      */
     public function getTopPostId($topic_id)
     {
-        $sql    = 'SELECT MIN(post_id) AS post_id FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id = ' . $topic_id . ' AND pid = 0';
+        $sql    = 'SELECT MIN(post_id) AS post_id FROM '.$this->db->prefix('newbb_posts').' WHERE topic_id = '.$topic_id.' AND pid = 0';
         $result = $this->db->query($sql);
         if (!$result) {
             //xoops_error($this->db->error());
@@ -272,7 +272,7 @@ 
                 $operator_for_position = '<';
             }
             //$approveCriteria = ' AND approved = 1'; // any others?
-            $sql    = 'SELECT COUNT(*) FROM ' . $this->db->prefix('newbb_posts') . ' AS p WHERE p.topic_id=' . (int)$topic->getVar('topic_id') . $approveCriteria . " AND p.post_id $operator_for_position $post_id";
+            $sql    = 'SELECT COUNT(*) FROM '.$this->db->prefix('newbb_posts').' AS p WHERE p.topic_id='.(int)$topic->getVar('topic_id').$approveCriteria." AND p.post_id $operator_for_position $post_id";
             $result = $this->db->query($sql);
             if (!$result) {
                 //xoops_error($this->db->error());
@@ -282,7 +282,7 @@ 
             $start = (int)($position / $perpage) * $perpage;
         }
 
-        $sql    = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p, ' . $this->db->prefix('newbb_posts_text') . ' t WHERE p.topic_id=' . $topic->getVar('topic_id') . ' AND p.post_id = t.post_id' . $approveCriteria . " ORDER BY p.post_id $order";
+        $sql    = 'SELECT p.*, t.* FROM '.$this->db->prefix('newbb_posts').' p, '.$this->db->prefix('newbb_posts_text').' t WHERE p.topic_id='.$topic->getVar('topic_id').' AND p.post_id = t.post_id'.$approveCriteria." ORDER BY p.post_id $order";
         $result = $this->db->query($sql, $perpage, $start);
         if (!$result) {
             //xoops_error($this->db->error());
@@ -327,18 +327,18 @@ 
         $postArray['post_time'] = newbbFormatTimestamp($postArray['post_time']);
 
         if (!empty($postArray['icon'])) {
-            $postArray['icon'] = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($postArray['icon']) . '" alt="" />';
+            $postArray['icon'] = '<img src="'.XOOPS_URL.'/images/subject/'.htmlspecialchars($postArray['icon']).'" alt="" />';
         } else {
-            $postArray['icon'] = '<a name="' . $postArray['post_id'] . '"><img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" /></a>';
+            $postArray['icon'] = '<a name="'.$postArray['post_id'].'"><img src="'.XOOPS_URL.'/images/icons/no_posticon.gif" alt="" /></a>';
         }
 
-        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id=' . $topic->getVar('topic_id') . '&amp;forum=' . $postArray['forum_id'] . '&amp;post_id=' . $postArray['post_id'] . '">' . $postArray['subject'] . '</a>';
+        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id='.$topic->getVar('topic_id').'&amp;forum='.$postArray['forum_id'].'&amp;post_id='.$postArray['post_id'].'">'.$postArray['subject'].'</a>';
 
         $isActiveUser = false;
         if (isset($viewtopic_users[$postArray['uid']]['name'])) {
             $postArray['poster'] = $viewtopic_users[$postArray['uid']]['name'];
             if ($postArray['uid'] > 0) {
-                $postArray['poster'] = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $postArray['uid'] . '">' . $viewtopic_users[$postArray['uid']]['name'] . '</a>';
+                $postArray['poster'] = '<a href="'.XOOPS_URL.'/userinfo.php?uid='.$postArray['uid'].'">'.$viewtopic_users[$postArray['uid']]['name'].'</a>';
             }
         } else {
             $postArray['poster'] = empty($postArray['poster_name']) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $postArray['poster_name'];
@@ -354,7 +354,7 @@ 
      */
     public function &getAllPosters(&$topic, $isApproved = true)
     {
-        $sql = 'SELECT DISTINCT uid FROM ' . $this->db->prefix('newbb_posts') . '  WHERE topic_id=' . $topic->getVar('topic_id') . ' AND uid>0';
+        $sql = 'SELECT DISTINCT uid FROM '.$this->db->prefix('newbb_posts').'  WHERE topic_id='.$topic->getVar('topic_id').' AND uid>0';
         if ($isApproved) {
             $sql .= ' AND approved = 1';
         }
@@ -408,7 +408,7 @@ 
     public function getPermission($forum, $topic_locked = 0, $type = 'view')
     {
         static $_cachedTopicPerms;
-        require_once __DIR__ . '/../include/functions.user.php';
+        require_once __DIR__.'/../include/functions.user.php';
         if (newbbIsAdmin($forum)) {
             return true;
         }
@@ -505,7 +505,7 @@ 
         }
         $b1 = $this->insert($object, $force);
         $criteria->add(new \Criteria('post_id', $top_post, '<>'), 'AND');
-        $criteria->add(new \Criteria('pid', '(' . implode(', ', $post_ids) . ')', 'NOT IN'), 'AND');
+        $criteria->add(new \Criteria('pid', '('.implode(', ', $post_ids).')', 'NOT IN'), 'AND');
         $b2       = $postHandler->updateAll('pid', $top_post, $criteria, $force);
         $criteria = new \CriteriaCompo();
         $criteria->add(new \Criteria('post_id', $top_post, '='), 'AND');
@@ -526,7 +526,7 @@ 
         $allDirs  = xoops_getActiveModules();
         foreach ($allDirs as $dirname) {
             // pollresults.php file is exist in all xoopspoll versions and umfrage versions
-            if (file_exists($GLOBALS['xoops']->path('modules/' . $dirname . '/pollresults.php'))) {
+            if (file_exists($GLOBALS['xoops']->path('modules/'.$dirname.'/pollresults.php'))) {
                 $pollDirs[$dirname] = $dirname;
             }
         }

class/User.php

Spacing +20 added lines, -20 removed lines

@@ -81,13 +81,13 @@ 
     $level              = [];
     $level['level']     = $showlevel;
     $level['exp']       = $ep;
-    $level['exp_width'] = $ep . '%';
+    $level['exp_width'] = $ep.'%';
     $level['hp']        = $hp;
     $level['hp_max']    = $maxhp;
-    $level['hp_width']  = $hpf . '%';
+    $level['hp_width']  = $hpf.'%';
     $level['mp']        = $mp;
     $level['mp_max']    = $maxmp;
-    $level['mp_width']  = $mpf . '%';
+    $level['mp_width']  = $mpf.'%';
 
     return $level;
 }
@@ -117,49 +117,49 @@ 
 
         $user               = $this->user;
         $userbar['profile'] = [
-            'link' => XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid'),
+            'link' => XOOPS_URL.'/userinfo.php?uid='.$user->getVar('uid'),
             'name' => _PROFILE
         ];
 
         if (is_object($GLOBALS['xoopsUser'])) {
             $userbar['pm'] = [
-                'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&to_userid=' . $user->getVar('uid') . "', 'pmlite', 450, 380);",
+                'link' => "javascript:void openWithSelfMain('".XOOPS_URL.'/pmlite.php?send2=1&to_userid='.$user->getVar('uid')."', 'pmlite', 450, 380);",
                 'name' => _MD_NEWBB_PM
             ];
         }
         if ($user->getVar('user_viewemail') || $isAdmin) {
             $userbar['email'] = [
-                'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "', 'new');",
+                'link' => "javascript:void window.open('mailto:".$user->getVar('email')."', 'new');",
                 'name' => _MD_NEWBB_EMAIL
             ];
         }
         if ($url = $user->getVar('url')) {
             $userbar['url'] = [
-                'link' => "javascript:void window.open('" . $url . "', 'new');",
+                'link' => "javascript:void window.open('".$url."', 'new');",
                 'name' => _MD_NEWBB_WWW
             ];
         }
         if ($icq = $user->getVar('user_icq')) {
             $userbar['icq'] = [
-                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $icq . "', 'new');",
+                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=".$icq."', 'new');",
                 'name' => _MD_NEWBB_ICQ
             ];
         }
         if ($aim = $user->getVar('user_aim')) {
             $userbar['aim'] = [
-                'link' => "javascript:void window.open('aim:goim?screenname=" . $aim . '&message=Hi+' . $aim . '+Are+you+there?' . "', 'new');",
+                'link' => "javascript:void window.open('aim:goim?screenname=".$aim.'&message=Hi+'.$aim.'+Are+you+there?'."', 'new');",
                 'name' => _MD_NEWBB_AIM
             ];
         }
         if ($yim = $user->getVar('user_yim')) {
             $userbar['yim'] = [
-                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $yim . '&.src=pg' . "', 'new');",
+                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=".$yim.'&.src=pg'."', 'new');",
                 'name' => _MD_NEWBB_YIM
             ];
         }
         if ($msn = $user->getVar('user_msnm')) {
             $userbar['msnm'] = [
-                'link' => "javascript:void window.open('http://members.msn.com?mem=" . $msn . "', 'new');",
+                'link' => "javascript:void window.open('http://members.msn.com?mem=".$msn."', 'new');",
                 'name' => _MD_NEWBB_MSNM
             ];
         }
@@ -183,7 +183,7 @@ 
                 $rpg_path    = $iconHandler->getPath('rpg');
                 foreach (['img_left', 'img_backing', 'img_right', 'blue', 'green', 'orange'] as $img) {
                     // irmtfan fix: double "/" removed
-                    $rpg_images[$img] = XOOPS_URL . $rpg_path . '/' . $img . '.gif';
+                    $rpg_images[$img] = XOOPS_URL.$rpg_path.'/'.$img.'.gif';
                 }
             }
             // irmtfan hardcore removed align="left"
@@ -195,13 +195,13 @@ 
                      . $rpg_images['img_right']
                      . "' alt='' /></td></tr></table>";
 
-            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '<br><span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>' . sprintf($table, $rpg_images['orange'], $level['hp_width']);
-            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span><br>' . sprintf($table, $rpg_images['green'], $level['mp_width']);
-            $info .= '<span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>' . sprintf($table, $rpg_images['blue'], $level['exp_width']);
+            $info = _MD_NEWBB_LEVEL.' '.$level['level'].'<br><span title="'._MD_NEWBB_HP_DESC.'">'._MD_NEWBB_HP.' '.$level['hp'].' / '.$level['hp_max'].'</span><br>'.sprintf($table, $rpg_images['orange'], $level['hp_width']);
+            $info .= '<span title="'._MD_NEWBB_MP_DESC.'">'._MD_NEWBB_MP.' '.$level['mp'].' / '.$level['mp_max'].'</span><br>'.sprintf($table, $rpg_images['green'], $level['mp_width']);
+            $info .= '<span title="'._MD_NEWBB_EXP_DESC.'">'._MD_NEWBB_EXP.' '.$level['exp'].'</span><br>'.sprintf($table, $rpg_images['blue'], $level['exp_width']);
         } else {
-            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '; <span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>';
-            $info .= '<span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>';
-            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span>';
+            $info = _MD_NEWBB_LEVEL.' '.$level['level'].'; <span title="'._MD_NEWBB_EXP_DESC.'">'._MD_NEWBB_EXP.' '.$level['exp'].'</span><br>';
+            $info .= '<span title="'._MD_NEWBB_HP_DESC.'">'._MD_NEWBB_HP.' '.$level['hp'].' / '.$level['hp_max'].'</span><br>';
+            $info .= '<span title="'._MD_NEWBB_MP_DESC.'">'._MD_NEWBB_MP.' '.$level['mp'].' / '.$level['mp_max'].'</span>';
         }
 
         return $info;
@@ -231,7 +231,7 @@ 
         $name             = empty($GLOBALS['xoopsModuleConfig']['show_realname']) ? $user->getVar('uname') : $user->getVar('name');
         $userinfo['name'] = $name ?: $user->getVar('uname');
 
-        $userinfo['link'] = '<a href=\'' . XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid') . '\'>' . $userinfo['name'] . '</a>';
+        $userinfo['link'] = '<a href=\''.XOOPS_URL.'/userinfo.php?uid='.$user->getVar('uid').'\'>'.$userinfo['name'].'</a>';
 
         $userinfo['avatar'] = $user->getVar('user_avatar');
         // START hacked by irmtfan - easier rank getting - consistency with previous version back rank.title and rank.image
@@ -254,7 +254,7 @@ 
         // END hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
         $userinfo['from'] = $user->getVar('user_from');
 
-        require_once __DIR__ . '/../include/functions.time.php';
+        require_once __DIR__.'/../include/functions.time.php';
         $userinfo['regdate']    = newbbFormatTimestamp($user->getVar('user_regdate'), 'reg');
         $userinfo['last_login'] = newbbFormatTimestamp($user->getVar('last_login')); // irmtfan add last_login