IpCheck

Complexity

Total Complexity

10

Size/Duplication

Total Lines	67
Duplicated Lines	11.94 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isValidIpAddress()	0	11	3
C	addressType()	8	37	7

<?php

//adopted from poweradmin (https://github.com/poweradmin)

/**
 * Class IpCheck
 */
class IpCheck

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public $ipin;
    public $ipout;
    public $ipver;

    // Return IP type.  4 for IPv4, 6 for IPv6, 0 for bad IP.

    /**
     * @param $ipValue
     */
    public function addressType($ipValue)
    {
        $this->ipin  = $ipValue;
        $this->ipver = 0;

        // IPv4 addresses are easy-peasy
        if (filter_var($this->ipin, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
            $this->ipver = 4;
            $this->ipout = $this->ipin;
        }

        // IPv6 is at least a little more complex.
        if (filter_var($this->ipin, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {

            // Look for embedded IPv4 in an embedded IPv6 address, where FFFF is appended.
            if (strpos($this->ipin, '::FFFF:') === 0) {
                $ipv4addr = substr($this->ipin, 7);
                if (filter_var($ipv4addr, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {

This code seems to be duplicated across your project.

                    $this->ipver = 4;
                    $this->ipout = $ipv4addr;
                }

                // Look for an IPv4 address embedded as ::x.x.x.x
            } elseif (strpos($this->ipin, '::') === 0) {
                $ipv4addr = substr($this->ipin, 2);
                if (filter_var($ipv4addr, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {

This code seems to be duplicated across your project.

                    $this->ipver = 4;
                    $this->ipout = $ipv4addr;
                }

                // Otherwise, assume this an IPv6 address.
            } else {
                $this->ipver = 6;
                $this->ipout = $this->ipin;
            }
        }
    }

    /** Check whether the given address is an IP address
     *
     * @param string $ip Given IP address
     *
     * @return string A if IPv4, AAAA if IPv6 or 0 if invalid

Should the return type not be string|integer?

     */
    public function isValidIpAddress($ip)
    {
        $value = 0;
        if (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
            $value = 'A';
        } elseif (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
            $value = 'AAAA';
        }

        return $value;
    }
}