mambax7 / newbb5

reply.php

<?php
//
//  ------------------------------------------------------------------------ //
//                XOOPS - PHP Content Management System                      //
//                  Copyright (c) 2000-2016 XOOPS.org                        //
//                       <https://xoops.org/>                             //
//  ------------------------------------------------------------------------ //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //
//  Author: phppp (D.J., infomax@gmail.com)                                  //
//  URL: https://xoops.org                                                    //
//  Project: Article Project                                                 //
//  ------------------------------------------------------------------------ //

use Xmf\Request;

include_once __DIR__ . '/header.php';

$forum    = Request::getInt('forum', 0, 'GET');
$topic_id = Request::getInt('topic_id', 0, 'GET');
$post_id  = Request::getInt('post_id', 0, 'GET');
$order    = Request::getInt('order', 0, 'GET');
$start    = Request::getInt('start', 0, 'GET');

if (!$topic_id && !$post_id) {

This code seems to be duplicated across your project.

    $redirect = empty($forum) ? 'index.php' : "viewforum.php?forum={$forum}";
    redirect_header($redirect, 2, _MD_NEWBB_ERRORTOPIC);
}

/** @var NewbbForumHandler $forumHandler */
$forumHandler = xoops_getModuleHandler('forum', 'newbb');
/** @var NewbbTopicHandler $topicHandler */
$topicHandler = xoops_getModuleHandler('topic', 'newbb');
/** @var NewbbPostHandler $postHandler */
$postHandler = xoops_getModuleHandler('post', 'newbb');

if (!$pid = $post_id) {
    $pid = $topicHandler->getTopPostId($topic_id);
}
$postParentObject = $postHandler->get($pid);
$topic_id        = $postParentObject->getVar('topic_id');
$forum           = $postParentObject->getVar('forum_id');
$postObject        = $postHandler->create();
$postObject->setVar('pid', $pid);
$postObject->setVar('topic_id', $topic_id);
$postObject->setVar('forum_id', $forum);

$forumObject = $forumHandler->get($forum);
if (!$forumHandler->getPermission($forumObject)) {
    redirect_header(XOOPS_URL . '/index.php', 2, _MD_NEWBB_NORIGHTTOACCESS);
}

$topicObject    = $topicHandler->get($topic_id);
$topic_status = $topicObject->getVar('topic_status');
if (!$topicHandler->getPermission($forumObject, $topic_status, 'reply')) {

This code seems to be duplicated across your project.

    /*
     * Build the page query
     */
    $query_vars  = ['topic_id', 'post_id', 'status', 'order', 'mode', 'viewmode'];
    $query_array = [];
    foreach ($query_vars as $var) {
        if (Request::getString($var, '', 'GET')) {
            $query_array[$var] = "{$var}=" . Request::getString($var, '', 'GET');
        }
    }
    $page_query = htmlspecialchars(implode('&', array_values($query_array)));
    unset($query_array);

    redirect_header("viewtopic.php?{$page_query}", 2, _MD_NEWBB_NORIGHTTOREPLY);
}

if ($GLOBALS['xoopsModuleConfig']['wol_enabled']) {
    /** @var NewbbOnlineHandler $onlineHandler */
    $onlineHandler = xoops_getModuleHandler('online', 'newbb');
    $onlineHandler->init($forumObject);
}

$xoopsOption['template_main']                                        = 'newbb_edit_post.tpl';
$GLOBALS['xoopsConfig']['module_cache'][$xoopsModule->getVar('mid')] = 0;
// irmtfan remove and move to footer.php
//$xoopsOption['xoops_module_header']= $xoops_module_header;
// irmtfan include header.php after defining $xoopsOption['template_main']
include_once $GLOBALS['xoops']->path('header.php');
//$xoopsTpl->assign('xoops_module_header', $xoops_module_header);

80% of this comment could be valid code. Did you maybe forget this after debugging?

/*

64% of this comment could be valid code. Did you maybe forget this after debugging?

$xoopsTpl->assign('lang_forum_index', sprintf(_MD_NEWBB_FORUMINDEX, htmlspecialchars($GLOBALS['xoopsConfig']['sitename'], ENT_QUOTES)));

$categoryHandler = xoops_getModuleHandler("category");
$categoryObject = $categoryHandler->get($forumObject->getVar("cat_id"), array("cat_title"));
$xoopsTpl->assign('category', array("id" => $forumObject->getVar("cat_id"), "title" => $categoryObject->getVar('cat_title')));

$form_title = _MD_NEWBB_REPLY.": <a href=\"viewtopic.php?topic_id={$topic_id}\">".$topicObject->getVar("topic_title");
$xoopsTpl->assign("form_title", $form_title);
*/

if ((2 == $GLOBALS['xoopsModuleConfig']['disc_show']) || (3 == $GLOBALS['xoopsModuleConfig']['disc_show'])) {

This code seems to be duplicated across your project.

    $xoopsTpl->assign('disclaimer', $GLOBALS['xoopsModuleConfig']['disclaimer']);
}

$xoopsTpl->assign('parentforum', $forumHandler->getParents($forumObject));

$xoopsTpl->assign([
                      'forum_id'   => $forumObject->getVar('forum_id'),
                      'forum_name' => $forumObject->getVar('forum_name')
                  ]);

if ($postParentObject->getVar('uid')) {
    $r_name = newbbGetUnameFromId($postParentObject->getVar('uid'), $GLOBALS['xoopsModuleConfig']['show_realname']);
} else {
    $poster_name = $postParentObject->getVar('poster_name');
    $r_name      = empty($poster_name) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $poster_name;
}

$r_subject = $postParentObject->getVar('subject', 'E');

$subject = $r_subject;
if (!preg_match('/^(Re|' . _MD_NEWBB_RE . '):/i', $r_subject)) {
    $subject = _MD_NEWBB_RE . ': ' . $r_subject;
}

$q_message = $postParentObject->getVar('post_text', 'e');
if ((!$GLOBALS['xoopsModuleConfig']['enable_karma'] || !$postParentObject->getVar('post_karma'))
    && (!$GLOBALS['xoopsModuleConfig']['allow_require_reply'] || !$postParentObject->getVar('require_reply'))) {
    if (1 === Request::getInt('quotedac', 0, 'GET')) {
        $message = "[quote]\n";
        $message .= sprintf(_MD_NEWBB_USERWROTE, $r_name);
        $message .= "\n" . $q_message . '[/quote]';
        $hidden  = '';
    } else {
        $hidden  = "[quote]\n";
        $hidden  .= sprintf(_MD_NEWBB_USERWROTE, $r_name);
        $hidden  .= "\n" . $q_message . '[/quote]';
        $message = '';
    }
} else {
    $hidden  = '';
    $message = '';
}

$isreply       = 1;
$istopic       = 0;
$dohtml        = 1;
$dosmiley      = 1;
$doxcode       = 1;
$dobr          = 1;
$icon          = '';
$attachsig     = (is_object($GLOBALS['xoopsUser']) && $GLOBALS['xoopsUser']->getVar('attachsig')) ? 1 : 0;
$post_karma    = 0;
$require_reply = 0;

include __DIR__ . '/include/form.post.php';

/** @var \NewbbKarmaHandler $karmaHandler */
$karmaHandler = xoops_getModuleHandler('karma', 'newbb');
$user_karma   = $karmaHandler->getUserKarma();

$posts_context = [];
//$posts_contextObject = $postHandler->getByLimit($topic_id, 5); //mb

60% of this comment could be valid code. Did you maybe forget this after debugging?

$posts_contextObject = $postHandler->getByLimit(5, 0, null, null, true, $topic_id, 1);
/** @var \NewbbPost $post_contextObject */
foreach ($posts_contextObject as $post_contextObject) {

This code seems to be duplicated across your project.

    // Sorry, in order to save queries, we have to hide the non-open post_text even if you have replied or have adequate karma, even an admin.
    if ($GLOBALS['xoopsModuleConfig']['enable_karma'] && $post_contextObject->getVar('post_karma') > 0) {
        $p_message = sprintf(_MD_NEWBB_KARMA_REQUIREMENT, '***', $post_contextObject->getVar('post_karma')) . '</div>';
    } elseif ($GLOBALS['xoopsModuleConfig']['allow_require_reply'] && $post_contextObject->getVar('require_reply')) {
        $p_message = _MD_NEWBB_REPLY_REQUIREMENT;
    } else {
        $p_message = $post_contextObject->getVar('post_text');
    }

    if ($post_contextObject->getVar('uid')) {
        $p_name = newbbGetUnameFromId($post_contextObject->getVar('uid'), $GLOBALS['xoopsModuleConfig']['show_realname']);
    } else {
        $poster_name = $post_contextObject->getVar('poster_name');
        $p_name      = empty($poster_name) ? htmlspecialchars($GLOBALS['xoopsConfig']['anonymous']) : $poster_name;
    }
    $p_date    = formatTimestamp($post_contextObject->getVar('post_time'));
    $p_subject = $post_contextObject->getVar('subject');

    $posts_context[] = [
        'subject' => $p_subject,
        'meta'    => _MD_NEWBB_BY . ' ' . $p_name . ' ' . _MD_NEWBB_ON . ' ' . $p_date,
        'content' => $p_message
    ];
}
$xoopsTpl->assign_by_ref('posts_context', $posts_context);
// irmtfan move to footer.php
include_once __DIR__ . '/footer.php';
include $GLOBALS['xoops']->path('footer.php');