mambax7 / newbb5

edit.php

<?php
/**
 * NewBB 5.0x,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
 * @since          4.00
 * @package        module::newbb
 */

use Xmf\Request;

include_once __DIR__ . '/header.php';

foreach (['forum', 'topic_id', 'post_id', 'order'] as $getint) {

This code seems to be duplicated across your project.

    ${$getint} = Request::getInt($getint, 0, 'GET');
}

if (!$topic_id && !$post_id) {

This code seems to be duplicated across your project.

    $redirect = empty($forum) ? 'index.php' : "viewforum.php?forum={$forum}";
    redirect_header($redirect, 2, _MD_NEWBB_ERRORTOPIC);
}

/** @var \NewbbForumHandler $forumHandler */
$forumHandler = xoops_getModuleHandler('forum', 'newbb');
/** @var \NewbbTopicHandler $topicHandler */
$topicHandler = xoops_getModuleHandler('topic', 'newbb');
/** @var \NewbbPostHandler $postHandler */
$postHandler = xoops_getModuleHandler('post', 'newbb');

/** @var \NewbbPost $postObject */
$postObject  = $postHandler->get($post_id);
$topicObject = $topicHandler->get($postObject->getVar('topic_id'));
$forumObject = $forumHandler->get($postObject->getVar('forum_id'));
if (!$forumHandler->getPermission($forumObject)) {
    redirect_header('index.php', 2, _MD_NEWBB_NORIGHTTOACCESS);
}

if ($GLOBALS['xoopsModuleConfig']['wol_enabled']) {
    /** @var \NewbbOnlineHandler $onlineHandler */
    $onlineHandler = xoops_getModuleHandler('online', 'newbb');
    $onlineHandler->init($forumObject);
}
$isAdmin = newbbIsAdmin($forumObject);
$uid     = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;

$topic_id     = $postObject->getVar('topic_id');
$topic_status = $topicObject->getVar('topic_status');
$error_msg    = null;

if (!$topicHandler->getPermission($forumObject, $topic_status, 'edit') || (!$isAdmin && !$postObject->checkIdentity())) {
    $error_msg = _MD_NEWBB_NORIGHTTOEDIT;
} elseif (!$isAdmin && !$postObject->checkTimelimit('edit_timelimit')) {
    $error_msg = _MD_NEWBB_TIMEISUP;
}

if (!empty($error_msg)) {
    /*
     * Build the page query
     */
    $query_vars  = ['topic_id', 'post_id', 'forum', 'status', 'order', 'mode', 'viewmode'];
    $query_array = [];
    foreach ($query_vars as $var) {
        if (Request::getString($var, '', 'GET')) {
            $query_array[$var] = "{$var}=" . Request::getString($var, '', 'GET');
        }
    }
    $page_query = htmlspecialchars(implode('&', array_values($query_array)));
    unset($query_array);
    redirect_header("viewtopic.php?{$page_query}", 2, $error_msg);
}

if ($GLOBALS['xoopsModuleConfig']['wol_enabled']) {
    $onlineHandler = xoops_getModuleHandler('online', 'newbb');
    $onlineHandler->init($forumObject);
}

$xoopsOption['template_main']                                        = 'newbb_edit_post.tpl';
$GLOBALS['xoopsConfig']['module_cache'][$xoopsModule->getVar('mid')] = 0;
// irmtfan include header.php after defining $xoopsOption['template_main']
include_once $GLOBALS['xoops']->path('header.php');

/*

65% of this comment could be valid code. Did you maybe forget this after debugging?

$xoopsTpl->assign('lang_forum_index', sprintf(_MD_NEWBB_FORUMINDEX, htmlspecialchars($GLOBALS['xoopsConfig']['sitename'], ENT_QUOTES)));

$categoryHandler = xoops_getModuleHandler("category");
$categoryObject = $categoryHandler->get($forumObject->getVar('cat_id'), array("cat_title"));
$xoopsTpl->assign('category', array("id" => $forumObject->getVar('cat_id'), "title" => $categoryObject->getVar('cat_title')));

$form_title = _EDIT.": <a href=\"viewtopic.php?post_id={$post_id}\">".$postObject->getVar('subject');
$xoopsTpl->assign("form_title", $form_title);

$xoopsTpl->assign("parentforum", $forumHandler->getParents($forumObject));

$xoopsTpl->assign(array(
    'forum_id'             => $forumObject->getVar('forum_id'),
    'forum_name'         => $forumObject->getVar('forum_name'),
    ));
*/

$dohtml        = $postObject->getVar('dohtml');
$dosmiley      = $postObject->getVar('dosmiley');
$doxcode       = $postObject->getVar('doxcode');
$dobr          = $postObject->getVar('dobr');
$icon          = $postObject->getVar('icon');
$attachsig     = $postObject->getVar('attachsig');
$istopic       = $postObject->isTopic() ? 1 : 0;
$isedit        = 1;
$subject       = $postObject->getVar('subject', 'E');
$message       = $postObject->getVar('post_text', 'E');
$poster_name   = $postObject->getVar('poster_name', 'E');
$attachments   = $postObject->getAttachment();
$post_karma    = $postObject->getVar('post_karma');
$require_reply = $postObject->getVar('require_reply');

$xoopsTpl->assign('error_message', _MD_NEWBB_EDITEDBY . ' ' . $GLOBALS['xoopsUser']->uname());
include __DIR__ . '/include/form.post.php';

/** @var \NewbbKarmaHandler $karmaHandler */
$karmaHandler = xoops_getModuleHandler('karma', 'newbb');
$user_karma   = $karmaHandler->getUserKarma();

$posts_context     = [];
$posts_contextObject = $istopic ? [] : [$postHandler->get($postObject->getVar('pid'))];
foreach ($posts_contextObject as $post_contextObject) {

This code seems to be duplicated across your project.

    if ($GLOBALS['xoopsModuleConfig']['enable_karma'] && $post_contextObject->getVar('post_karma') > 0) {
        $p_message = sprintf(_MD_NEWBB_KARMA_REQUIREMENT, '***', $post_contextObject->getVar('post_karma')) . '</div>';
    } elseif ($GLOBALS['xoopsModuleConfig']['allow_require_reply'] && $post_contextObject->getVar('require_reply')) {
        $p_message = _MD_NEWBB_REPLY_REQUIREMENT;
    } else {
        $p_message = $post_contextObject->getVar('post_text');
    }

    if ($post_contextObject->getVar('uid')) {
        $p_name = newbbGetUnameFromId($post_contextObject->getVar('uid'), $GLOBALS['xoopsModuleConfig']['show_realname']);
    } else {
        $poster_name = $post_contextObject->getVar('poster_name');
        $p_name      = empty($poster_name) ? htmlspecialchars($GLOBALS['xoopsConfig']['anonymous']) : $poster_name;
    }
    $p_date    = formatTimestamp($post_contextObject->getVar('post_time'));
    $p_subject = $post_contextObject->getVar('subject');

    $posts_context[] = [
        'subject' => $p_subject,
        'meta'    => _MD_NEWBB_BY . ' ' . $p_name . ' ' . _MD_NEWBB_ON . ' ' . $p_date,
        'content' => $p_message
    ];
}
$xoopsTpl->assign_by_ref('posts_context', $posts_context);
// irmtfan move to footer.php
include_once __DIR__ . '/footer.php';
include $GLOBALS['xoops']->path('footer.php');