mambax7 / newbb5

footer.php

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright       The XUUPS Project http://sourceforge.net/projects/xuups/
 * @license         GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @package         NEWBB
 * @since           4.3
 * @author          irmtfan <irmtfan@yahoo.com>
 * @author          The Persian Xoops Support Site<www.xoops.ir>
 */

// defined('XOOPS_ROOT_PATH') || exit('Restricted access.');

70% of this comment could be valid code. Did you maybe forget this after debugging?

global $xoTheme;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

include_once $GLOBALS['xoops']->path('modules/newbb/include/functions.render.php');
$iconHandler = newbbGetIconHandler();
//  get css rel path from setted language
$css_rel_path = $iconHandler->getPath('language/' . $GLOBALS['xoopsConfig']['language'], 'newbb', 'language/english', 'css');

$css_rel_path does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

// add local stylesheet
/** @var xos_opal_Theme $xoTheme */
$xoTheme->addStylesheet($css_rel_path . '/style.css');

$css_rel_path does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

//  get js rel path from setted language
$js_rel_path = $iconHandler->getPath('language/' . $GLOBALS['xoopsConfig']['language'], 'newbb', 'language/english', 'js');

$js_rel_path does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

// add all local js files inside js directory
xoops_load('XoopsLists');
$allfiles = \XoopsLists::getFileListAsArray($GLOBALS['xoops']->path($js_rel_path));

$js_rel_path does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

foreach ($allfiles as $jsfile) {
    if ('js' === strtolower(pathinfo($jsfile, PATHINFO_EXTENSION))) {
        $xoTheme->addScript($js_rel_path . '/' . $jsfile);

$js_rel_path does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }
}
global $forumCookie;  // for $forumCookie["prefix"] revert last change - use global instead of include_once

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

// add toggle script
//$toggle_script = "var toggle_cookie=\"" . $forumCookie['prefix'] . 'G' . '\';';
$toggle_script = 'var toggle_cookie="' . $forumCookie['prefix'] . 'G";';

$toggle_script does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$xoTheme->addScript(null, ['type' => 'text/javascript'], $toggle_script);

$toggle_script does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).