User.php ➔ newbb_calculateLevel() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/mambax..." - mambax7/newbb5 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 62af87...249590 )

by Michael

created 2018-01-13 06:18 UTC

User.php ➔ newbb_calculateLevel() F

↳ Parent: Project

Complexity

Conditions	11
Paths	1024

Size

Total Lines	72
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	54
nc	1024
nop	2
dl	0
loc	72
rs	3.5064
c	0
b	0
f	0

How to fix Long Method Complexity

<?php namespace XoopsModules\Newbb;


/**
 * NewBB 5.0x,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <[email protected]>
 * @since          4.00
 * @package        module::newbb
 */

// defined('XOOPS_ROOT_PATH') || exit('Restricted access.');


defined('NEWBB_FUNCTIONS_INI') || include $GLOBALS['xoops']->path('modules/newbb/include/functions.ini.php');

/**
 * @param $RPG
 * @param $RPGDIFF
 * @return array|number
 */
function newbb_calculateLevel($RPG, $RPGDIFF)

{

    //$RPG = $user->getVar('posts');

    //$RPGDIFF = $user->getVar('user_regdate');


    $today = time();
    $diff  = $today - $RPGDIFF;

    $exp   = round($diff / 86400, 0);
    if ($exp <= 0) {
        $exp = 1;
    }
    $ppd       = round($RPG / $exp, 0);

    $level     = pow(log10($RPG), 3);

    $ep        = floor(100 * ($level - floor($level)));

    $showlevel = floor($level + 1);
    $hpmulti   = round($ppd / 6, 1);
    if ($hpmulti > 1.5) {
        $hpmulti = 1.5;
    }
    if ($hpmulti < 1) {
        $hpmulti = 1;
    }
    $maxhp = $level * 25 * $hpmulti;
    $hp    = $ppd / 5;

    if ($hp >= 1) {
        $hp = $maxhp;
    } else {
        $hp = floor($hp * $maxhp);
    }
    $hp    = floor($hp);
    $maxhp = floor($maxhp);
    $zhp   = $maxhp;
    if ($maxhp <= 0) {
        $zhp = 1;
    }
    $hpf   = floor(100 * ($hp / $zhp)) - 1;
    $maxmp = ($exp * $level) / 5;
    $mp    = $RPG / 3;

    if ($mp >= $maxmp) {
        $mp = $maxmp;
    }
    $maxmp = floor($maxmp);
    $mp    = floor($mp);
    $zmp   = $maxmp;
    if ($maxmp <= 0) {
        $zmp = 1;
    }
    $mpf = floor(100 * ($mp / $zmp)) - 1;
    if ($hpf >= 98) {
        $hpf -= 2;
    }
    if ($ep >= 98) {
        $ep -= 2;
    }
    if ($mpf >= 98) {
        $mpf -= 2;
    }

    $level              = [];
    $level['level']     = $showlevel;
    $level['exp']       = $ep;
    $level['exp_width'] = $ep . '%';
    $level['hp']        = $hp;
    $level['hp_max']    = $maxhp;
    $level['hp_width']  = $hpf . '%';
    $level['mp']        = $mp;
    $level['mp_max']    = $maxmp;
    $level['mp_width']  = $mpf . '%';

    return $level;
}

/**
 * Class User
 */
class User
{
    public $user;

    public function __construct()
    {
    }

    /**
     * @return array
     */
    public function getUserbar()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $isAdmin;
function myFunction($a, $b) {
    // Do something
}

        $userbar = [];
        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            return $userbar;
        }

        $user               = $this->user;
        $userbar['profile'] = [
            'link' => XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid'),
            'name' => _PROFILE
        ];

        if (is_object($GLOBALS['xoopsUser'])) {
            $userbar['pm'] = [
                'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . $user->getVar('uid') . "', 'pmlite', 450, 380);",
                'name' => _MD_NEWBB_PM
            ];
        }
        if ($user->getVar('user_viewemail') || $isAdmin) {
            $userbar['email'] = [
                'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "', 'new');",
                'name' => _MD_NEWBB_EMAIL
            ];
        }
        if ($url = $user->getVar('url')) {
            $userbar['url'] = [
                'link' => "javascript:void window.open('" . $url . "', 'new');",
                'name' => _MD_NEWBB_WWW
            ];
        }
        if ($icq = $user->getVar('user_icq')) {
            $userbar['icq'] = [
                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $icq . "', 'new');",
                'name' => _MD_NEWBB_ICQ
            ];
        }
        if ($aim = $user->getVar('user_aim')) {
            $userbar['aim'] = [
                'link' => "javascript:void window.open('aim:goim?screenname=" . $aim . '&amp;message=Hi+' . $aim . '+Are+you+there?' . "', 'new');",
                'name' => _MD_NEWBB_AIM
            ];
        }
        if ($yim = $user->getVar('user_yim')) {
            $userbar['yim'] = [
                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $yim . '&.src=pg' . "', 'new');",
                'name' => _MD_NEWBB_YIM
            ];
        }
        if ($msn = $user->getVar('user_msnm')) {
            $userbar['msnm'] = [
                'link' => "javascript:void window.open('http://members.msn.com?mem=" . $msn . "', 'new');",
                'name' => _MD_NEWBB_MSNM
            ];
        }

        return $userbar;
    }

    /**
     * @return string
     */
    public function getLevel()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $forumUrl;
function myFunction($a, $b) {
    // Do something
}

        $level = newbb_calculateLevel($this->user->getVar('posts'), $this->user->getVar('user_regdate'));
        $info  = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (2 == $GLOBALS['xoopsModuleConfig']['user_level']) {
            static $rpg_images;
            if (!isset($rpg_images)) {

                $iconHandler = newbbGetIconHandler();
                $rpg_path    = $iconHandler->getPath('rpg');

                foreach (['img_left', 'img_backing', 'img_right', 'blue', 'green', 'orange'] as $img) {
                    // irmtfan fix: double "/" removed
                    $rpg_images[$img] = XOOPS_URL . $rpg_path . '/' . $img . '.gif';

                }
            }
            // irmtfan hardcore removed align="left"
            $table = "<table class='userlevel'><tr><td class='end'><img src='"
                     . $rpg_images['img_left']

                     . "' alt='' /></td><td class='center' background='"
                     . $rpg_images['img_backing']

                     . "'><img src='%s' width='%d' alt='' class='icon_left' /></td><td><img src='"
                     . $rpg_images['img_right']

                     . "' alt='' /></td></tr></table>";

            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '<br><span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>' . sprintf($table, $rpg_images['orange'], $level['hp_width']);

            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span><br>' . sprintf($table, $rpg_images['green'], $level['mp_width']);

            $info .= '<span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>' . sprintf($table, $rpg_images['blue'], $level['exp_width']);

        } else {
            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '; <span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>';
            $info .= '<span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>';
            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span>';
        }

        return $info;
    }

    /**
     * @param \XoopsUser $user
     * @return mixed
     */
    public function getInfo(&$user)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $myts;
function myFunction($a, $b) {
    // Do something
}
        static $name_anonymous;

        if (!is_object($user) || !$user->isActive()) {
            if (!isset($name_anonymous)) {

                $name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);

            }

            return ['name' => $name_anonymous, 'link' => $name_anonymous];

        }

        $this->user = $user;

        $userinfo['uid'] = $user->getVar('uid');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        $name             = empty($GLOBALS['xoopsModuleConfig']['show_realname']) ? $user->getVar('uname') : $user->getVar('name');
        $userinfo['name'] = $name ?: $user->getVar('uname');

        $userinfo['link'] = '<a href=\'' . XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid') . '\'>' . $userinfo['name'] . '</a>';

        $userinfo['avatar'] = $user->getVar('user_avatar');
        // START hacked by irmtfan - easier rank getting - consistency with previous version back rank.title and rank.image
        $userrank         = $user->rank();
        $userinfo['rank'] = [];
        if (isset($userrank['image']) && $userrank['image']) {
            $userinfo['rank']['image'] = $userrank['image'];
            $userinfo['rank']['title'] = $userrank['title'];
        }
        // END hacked by irmtfan - easier rank getting  - a little correctness dot removed
        // START hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
        //checks for user's groups
        $userinfo['groups'] = [];
        /** @var \XoopsMemberHandler $memberHandler */
        $memberHandler = xoops_getHandler('member');
        $usergroups    = $memberHandler->getGroupsByUser($userinfo['uid'], true);
        foreach ($usergroups as $group) {
            $userinfo['groups'][] = $group->getVar('name');
        }
        // END hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
        $userinfo['from'] = $user->getVar('user_from');

        include_once __DIR__ . '/../include/functions.time.php';
        $userinfo['regdate']    = newbbFormatTimestamp($user->getVar('user_regdate'), 'reg');
        $userinfo['last_login'] = newbbFormatTimestamp($user->getVar('last_login')); // irmtfan add last_login

        $userinfo['posts'] = $user->getVar('posts');

        if (!empty($GLOBALS['xoopsModuleConfig']['user_level'])) {
            $userinfo['level'] = $this->getLevel();
        }

        if (!empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
            $userinfo['userbar'] = $this->getUserbar();
        }

        $userinfo['signature'] = $user->getVar('user_sig');

        return $userinfo;
    }
}


Push — master ( 62af87...249590 )

User.php ➔ newbb_calculateLevel() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php namespace XoopsModules\Newbb;
			0 ignored issues – show Coding Style Compatibility introduced 2018-01-13 06:21 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 22 and the first side effect is on line 15. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			/**
4			* NewBB 5.0x, the forum module for XOOPS project
5			*
6			* @copyright XOOPS Project (https://xoops.org)
7			* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
8			* @author Taiwen Jiang (phppp or D.J.) <[email protected]>
9			* @since 4.00
10			* @package module::newbb
11			*/
12
13			// defined('XOOPS_ROOT_PATH') \|\| exit('Restricted access.');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-07 04:30 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
14
15			defined('NEWBB_FUNCTIONS_INI') \|\| include $GLOBALS['xoops']->path('modules/newbb/include/functions.ini.php');
16
17			/**
18			* @param $RPG
19			* @param $RPGDIFF
20			* @return array\|number
21			*/
22			function newbb_calculateLevel($RPG, $RPGDIFF)
			0 ignored issues – show Coding Style introduced 2017-11-20 06:47 UTC by Report Bug Copy Issue Report `function newbb_calculateLevel()` does not seem to conform to the naming convention (`^(?:[a-z]\|__)[a-zA-Z0-9]$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style introduced 2017-11-20 06:47 UTC by Report Bug Copy Issue Report `$RPG` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
23			{
24
25			//$RPG = $user->getVar('posts');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-06-25 02:50 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26			//$RPGDIFF = $user->getVar('user_regdate');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-06-25 02:50 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
27
28			$today = time();
29			$diff = $today - $RPGDIFF;
			0 ignored issues – show Coding Style introduced 2017-11-20 06:47 UTC by Report Bug Copy Issue Report `$RPGDIFF` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
30			$exp = round($diff / 86400, 0);
31			if ($exp <= 0) {
32			$exp = 1;
33			}
34			$ppd = round($RPG / $exp, 0);

mambax7 / newbb5

Push — master ( 62af87...249590 )

User.php ➔ newbb_calculateLevel() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like