TopicHandler::findPollModule() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/mambax..." - mambax7/newbb5 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 62af87...249590 )

by Michael

created 2018-01-13 06:18 UTC

TopicHandler::findPollModule() D

↳ Parent: TopicHandler

Complexity

Conditions	10
Paths	24

Size

Total Lines	42
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	23
nc	24
nop	1
dl	0
loc	42
rs	4.8196
c	0
b	0
f	0

How to fix Complexity

<?php namespace XoopsModules\Newbb;


/**
 * NewBB 5.0x,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <[email protected]>
 * @since          4.00
 * @package        module::newbb
 */

use XoopsModules\Newbb;

// defined('XOOPS_ROOT_PATH') || exit('Restricted access.');


defined('NEWBB_FUNCTIONS_INI') || include $GLOBALS['xoops']->path('modules/newbb/include/functions.ini.php');

/**
 * Class TopicHandler
 */
class TopicHandler extends \XoopsPersistableObjectHandler
{
    /**
     * @param \XoopsDatabase $db
     */
    public function __construct(\XoopsDatabase $db)

    {
        parent::__construct($db, 'newbb_topics', Topic::class, 'topic_id', 'topic_title');
    }

    /**
     * @param  mixed      $id
     * @param  null|array $fields
     * @return mixed|null
     */
    public function get($id = null, $fields = null) //get($id, $var = null)

    {
        $var  = $fields;
        $ret  = null;
        $tags = $var;
        if (!empty($var) && is_string($var)) {
            $tags = [$var];
        }
        if (!$topicObject = parent::get($id, $tags)) {
            return $ret;
        }
        $ret = $topicObject;
        if (!empty($var) && is_string($var)) {
            $ret = @$topicObject->getVar($var);
        }

        return $ret;
    }

    /**
     * @param \XoopsObject $object
     * @param  bool        $force
     * @return mixed
     */
    public function insert(\XoopsObject $object, $force = true)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$object->getVar('topic_time')) {
            $object->setVar('topic_time', time());
        }
        if (!parent::insert($object, $force) || !$object->getVar('approved')) {
            return $object->getVar('topic_id');
        }

        $newbbConfig = newbbLoadConfig();
        if (!empty($newbbConfig['do_tag'])
            && @include_once $GLOBALS['xoops']->path('modules/tag/include/functions.php')) {
            if ($tagHandler = tag_getTagHandler()) {
                $tagHandler->updateByItem($object->getVar('topic_tags', 'n'), $object->getVar('topic_id'), 'newbb');
            }
        }

        return $object->getVar('topic_id');
    }

    /**
     * @param       $object
     * @param  bool $force
     * @return bool
     */
    public function approve($object, $force = false)

    {
        $topic_id = $object->getVar('topic_id');

        if ($force) {
            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = -1 WHERE topic_id = {$topic_id}";

        } else {
            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = 1 WHERE topic_id = {$topic_id}";

        }
        if (!$result = $this->db->queryF($sql)) {
            //xoops_error($this->db->error());

            return false;
        }
        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
        $postsObject = $postHandler->getAll(new \Criteria('topic_id', $topic_id));

        foreach (array_keys($postsObject) as $post_id) {

            $postHandler->approve($postsObject[$post_id]);

        }
        unset($postsObject);
        $statsHandler = Newbb\Helper::getInstance()->getHandler('Stats');
        $statsHandler->update($object->getVar('forum_id'), 'topic');

        return true;
    }

    /**
     * get previous/next topic
     *
     * @param integer $topic_id current topic ID
     * @param integer $action
     *                          <ul>
     *                          <li> -1: previous </li>
     *                          <li> 0: current </li>
     *                          <li> 1: next </li>
     *                          </ul>
     * @param integer $forum_id the scope for moving
     *                          <ul>
     *                          <li> >0 : inside the forum </li>
     *                          <li> <= 0: global </li>
     *                          </ul>
     * @access public
     * @return mixed|null|\XoopsObject
     */
    public function &getByMove($topic_id, $action, $forum_id = 0)

    {
        $topic = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (!empty($action)) {
            $sql = 'SELECT * FROM ' . $this->table . ' WHERE 1=1' . (($forum_id > 0) ? ' AND forum_id=' . (int)$forum_id : '') . ' AND topic_id ' . (($action > 0) ? '>' : '<') . (int)$topic_id . ' ORDER BY topic_id ' . (($action > 0) ? 'ASC' : 'DESC') . ' LIMIT 1';

            if ($result = $this->db->query($sql)) {
                if ($row = $this->db->fetchArray($result)) {
                    $topic = $this->create(false);
                    $topic->assignVars($row);

                    return $topic;
                }
            }
        }
        $topic = $this->get($topic_id);


        return $topic;
    }

    /**
     * @param $post_id
     * @return null|\XoopsObject
     */
    public function &getByPost($post_id)

    {
        $topic  = null;
        $sql    = 'SELECT t.* FROM ' . $this->db->prefix('newbb_topics') . ' t, ' . $this->db->prefix('newbb_posts') . ' p
                WHERE t.topic_id = p.topic_id AND p.post_id = ' . (int)$post_id;

        $result = $this->db->query($sql);
        if (!$result) {
            //xoops_error($this->db->error());

            return $topic;
        }
        $row   = $this->db->fetchArray($result);
        $topic = $this->create(false);
        $topic->assignVars($row);

        return $topic;
    }

    /**
     * @param  Topic  $topic
     * @param  string $type
     * @return mixed
     */
    public function getPostCount(&$topic, $type = '')
    {
        switch ($type) {
            case 'pending':
                $approved = 0;
                break;
            case 'deleted':
                $approved = -1;
                break;
            default:
                $approved = 1;
                break;
        }
        $criteria = new \CriteriaCompo(new \Criteria('topic_id', $topic->getVar('topic_id')));
        $criteria->add(new \Criteria('approved', $approved));
        /** @var Newbb\PostHandler $postHandler */
        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
        $count       = $postHandler->getCount($criteria);

        return $count;
    }

    /**
     * @param $topic_id
     * @return null|\Post

     */
    public function &getTopPost($topic_id)

    {
        $post = null;
        $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p,
            ' . $this->db->prefix('newbb_posts_text') . ' t
            WHERE
            p.topic_id = ' . $topic_id . ' AND p.pid = 0

            AND t.post_id = p.post_id';

        $result = $this->db->query($sql);
        if (!$result) {
            //xoops_error($this->db->error());

            return $post;
        }
        /** @var Newbb\PostHandler $postHandler */
        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
        $myrow       = $this->db->fetchArray($result);
        /** @var Newbb\Post $post */
        $post = $postHandler->create(false);
        $post->assignVars($myrow);

        return $post;
    }

    /**
     * @param $topic_id
     * @return bool
     */
    public function getTopPostId($topic_id)

    {
        $sql    = 'SELECT MIN(post_id) AS post_id FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id = ' . $topic_id . ' AND pid = 0';

        $result = $this->db->query($sql);
        if (!$result) {
            //xoops_error($this->db->error());

            return false;
        }
        list($post_id) = $this->db->fetchRow($result);


        return $post_id;

    }

    /**
     * @param         $topic
     * @param  string $order
     * @param  int    $perpage
     * @param         $start
     * @param  int    $post_id
     * @param  string $type
     * @return array
     */
    public function &getAllPosts(&$topic, $order = 'ASC', $perpage = 10, &$start, $post_id = 0, $type = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $ret     = [];
        $perpage = ((int)$perpage > 0) ? (int)$perpage : (empty($GLOBALS['xoopsModuleConfig']['posts_per_page']) ? 10 : $GLOBALS['xoopsModuleConfig']['posts_per_page']);
        $start   = (int)$start;
        switch ($type) {
            case 'pending':
                $approveCriteria = ' AND p.approved = 0';
                break;
            case 'deleted':
                $approveCriteria = ' AND p.approved = -1';
                break;
            default:
                $approveCriteria = ' AND p.approved = 1';
                break;
        }

        if ($post_id) {

            if ('DESC' === $order) {
                $operator_for_position = '>';

            } else {
                $order                 = 'ASC';
                $operator_for_position = '<';

            }
            //$approveCriteria = ' AND approved = 1'; // any others?

            $sql    = 'SELECT COUNT(*) FROM ' . $this->db->prefix('newbb_posts') . ' AS p WHERE p.topic_id=' . (int)$topic->getVar('topic_id') . $approveCriteria . " AND p.post_id $operator_for_position $post_id";

            $result = $this->db->query($sql);
            if (!$result) {
                //xoops_error($this->db->error());

                return $ret;
            }
            list($position) = $this->db->fetchRow($result);
            $start = (int)($position / $perpage) * $perpage;
        }

        $sql    = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p, ' . $this->db->prefix('newbb_posts_text') . ' t WHERE p.topic_id=' . $topic->getVar('topic_id') . ' AND p.post_id = t.post_id' . $approveCriteria . " ORDER BY p.post_id $order";
        $result = $this->db->query($sql, $perpage, $start);
        if (!$result) {
            //xoops_error($this->db->error());

            return $ret;
        }
        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
        while ($myrow = $this->db->fetchArray($result)) {

            $post = $postHandler->create(false);
            $post->assignVars($myrow);
            $ret[$myrow['post_id']] = $post;
            unset($post);
        }

        return $ret;
    }

    /**
     * @param        $postArray
     * @param  int   $pid
     * @return mixed
     */
    public function &getPostTree(&$postArray, $pid = 0)
    {
        //        include_once $GLOBALS['xoops']->path('modules/newbb/class/Tree.php');

        $NewBBTree = new Newbb\Tree('newbb_posts');

        $NewBBTree->setPrefix('&nbsp;&nbsp;');

        $NewBBTree->setPostArray($postArray);

        $NewBBTree->getPostTree($postsArray, $pid);


        return $postsArray;
    }

    /**
     * @param $topic
     * @param $postArray
     * @return mixed
     */
    public function showTreeItem(&$topic, &$postArray)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        global $viewtopic_users, $myts;
function myFunction($a, $b) {
    // Do something
}

        $postArray['post_time'] = newbbFormatTimestamp($postArray['post_time']);

        if (!empty($postArray['icon'])) {
            $postArray['icon'] = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($postArray['icon']) . '" alt="" />';
        } else {
            $postArray['icon'] = '<a name="' . $postArray['post_id'] . '"><img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" /></a>';
        }

        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id=' . $topic->getVar('topic_id') . '&amp;forum=' . $postArray['forum_id'] . '&amp;post_id=' . $postArray['post_id'] . '">' . $postArray['subject'] . '</a>';

        $isActiveUser = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($viewtopic_users[$postArray['uid']]['name'])) {

            $postArray['poster'] = $viewtopic_users[$postArray['uid']]['name'];

            if ($postArray['uid'] > 0) {
                $postArray['poster'] = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $postArray['uid'] . '">' . $viewtopic_users[$postArray['uid']]['name'] . '</a>';

            }
        } else {
            $postArray['poster'] = empty($postArray['poster_name']) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $postArray['poster_name'];
        }

        return $postArray;
    }

    /**
     * @param        $topic
     * @param  bool  $isApproved
     * @return array
     */
    public function &getAllPosters(&$topic, $isApproved = true)
    {
        $sql = 'SELECT DISTINCT uid FROM ' . $this->db->prefix('newbb_posts') . '  WHERE topic_id=' . $topic->getVar('topic_id') . ' AND uid>0';
        if ($isApproved) {
            $sql .= ' AND approved = 1';
        }
        $result = $this->db->query($sql);
        if (!$result) {
            //xoops_error($this->db->error());

            return [];
        }
        $ret = [];
        while ($myrow = $this->db->fetchArray($result)) {
            $ret[] = $myrow['uid'];
        }

        return $ret;
    }

    /**
     * @param \XoopsObject $topic
     * @param  bool        $force
     * @return bool
     */
    public function delete(\XoopsObject $topic, $force = true)

    {
        $topic_id = is_object($topic) ? $topic->getVar('topic_id') : (int)$topic;

        if (empty($topic_id)) {

            return false;
        }
        $postObject = $this->getTopPost($topic_id);

        /** @var Newbb\PostHandler $postHandler */
        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
        $postHandler->delete($postObject, false, $force);

        $newbbConfig = newbbLoadConfig();
        /** @var \TagTagHandler $tagHandler */
        if (!empty($newbbConfig['do_tag']) && $tagHandler = @xoops_getModuleHandler('tag', 'tag', true)) {
            $tagHandler->updateByItem([], $topic_id, 'newbb');

        }

        return true;
    }

    // get permission
    // parameter: $type: 'post', 'view',  'reply', 'edit', 'delete', 'addpoll', 'vote', 'attach'

    // $gperm_names = "'forum_can_post', 'forum_can_view', 'forum_can_reply', 'forum_can_edit', 'forum_can_delete', 'forum_can_addpoll', 'forum_can_vote', 'forum_can_attach', 'forum_can_noapprove'";

    /**
     * @param   Newbb\Forum $forum
     * @param  int     $topic_locked
     * @param  string  $type
     * @return bool
     */
    public function getPermission($forum, $topic_locked = 0, $type = 'view')

    {
        static $_cachedTopicPerms;
        include_once __DIR__ . '/../include/functions.user.php';
        if (newbbIsAdmin($forum)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return true;
        }

        $forum_id = is_object($forum) ? $forum->getVar('forum_id') : (int)$forum;

        if ($forum_id < 1) {

            return false;
        }

        if ($topic_locked && 'view' !== $type) {

            $permission = false;
        } else {
            /** var Newbb\PermissionHandler $permHandler */
            $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
            $permission  = $permHandler->getPermission('forum', $type, $forum_id);

        }

        return $permission;
    }

    /**
     * clean orphan items from database
     *
     * @param  string $table_link
     * @param  string $field_link
     * @param  string $field_object
     * @return bool   true on success
     */
    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()

    {
        $this->deleteAll(new \Criteria('topic_time', 0), true, true);
        parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id');
        parent::cleanOrphan($this->db->prefix('newbb_posts'), 'topic_id');

        return true;
    }

    /**
     * clean expired objects from database
     *
     * @param  int $expire time limit for expiration
     * @return bool true on success
     */
    public function cleanExpires($expire = 0)

    {
        // irmtfan if 0 no cleanup look include/plugin.php
        if (!func_num_args()) {
            $newbbConfig = newbbLoadConfig();
            $expire      = isset($newbbConfig['pending_expire']) ? (int)$newbbConfig['pending_expire'] : 7;
            $expire      = $expire * 24 * 3600; // days to seconds
        }
        if (empty($expire)) {
            return false;
        }
        $crit_expire = new \CriteriaCompo(new \Criteria('approved', 0, '<='));

        $crit_expire->add(new \Criteria('topic_time', time() - (int)$expire, '<'));


        return $this->deleteAll($crit_expire, true/*, true*/);

    }

    // START irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access

    /**
     * @param  null $object
     * @param  bool $force
     * @return bool
     */
    public function synchronization($object = null, $force = true)

    {
        if (!is_object($object)) {
            $object = $this->get((int)$object);
        }
        if (!is_object($object) || !$object->getVar('topic_id')) {
            return false;
        }

        /** @var Newbb\PostHandler $postHandler */
        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
        $criteria    = new \CriteriaCompo();
        $criteria->add(new \Criteria('topic_id', $object->getVar('topic_id')), 'AND');
        $criteria->add(new \Criteria('approved', 1), 'AND');
        $post_ids = $postHandler->getIds($criteria);

        if (empty($post_ids)) {

            return false;
        }
        $last_post     = max($post_ids);

        $top_post      = min($post_ids);

        $topic_replies = count($post_ids) - 1;

        if ($object->getVar('topic_last_post_id') != $last_post) {

            $object->setVar('topic_last_post_id', $last_post);

        }
        if ($object->getVar('topic_replies') != $topic_replies) {

            $object->setVar('topic_replies', $topic_replies);

        }
        $b1 = $this->insert($object, $force);

        $criteria->add(new \Criteria('post_id', $top_post, '<>'), 'AND');

        $criteria->add(new \Criteria('pid', '(' . implode(', ', $post_ids) . ')', 'NOT IN'), 'AND');

        $b2       = $postHandler->updateAll('pid', $top_post, $criteria, $force);

        $criteria = new \CriteriaCompo();
        $criteria->add(new \Criteria('post_id', $top_post, '='), 'AND');

        $b3 = $postHandler->updateAll('pid', 0, $criteria, $force);


        return ($b1 && $b2 && $b3);
    }
    // END irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
    // START irmtfan getActivePolls
    /**
     * get all active poll modules in the current xoops installtion.
     * @access public
     * @return array $pollDirs = array($dirname1=>$dirname1, $dirname2=>$dirname2, ...) dirnames of all active poll modules
     */
    public function getActivePolls()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $pollDirs = [];
        $allDirs  = xoops_getActiveModules();
        foreach ($allDirs as $dirname) {
            // pollresults.php file is exist in all xoopspoll versions and umfrage versions
            if (file_exists($GLOBALS['xoops']->path('modules/' . $dirname . '/pollresults.php'))) {
                $pollDirs[$dirname] = $dirname;
            }
        }

        return $pollDirs;
    }
    // END irmtfan getActivePolls

    // START irmtfan findPollModule
    /**
     * find poll module that is in used in the current newbb installtion.
     * @access public
     * @param  array $pollDirs dirnames of all active poll modules
     * @return bool|string $dir_def | true | false
     *                         $dir_def: dirname of poll module that is in used in the current newbb installtion.
     *                         true: no poll module is installed | newbb has no topic with poll | newbb has no topic
     *                         false: errors (see below xoops_errors)
     */
    public function findPollModule(array $pollDirs = [])
    {
        $dir_def = '';

        if (empty($pollDirs)) {
            $pollDirs = $this->getActivePolls();
        }
        if (empty($pollDirs)) {
            return true;
        }
        // if only one active poll module still we need to check!!!
        //if(count($pollDirs) === 1) return end($pollDirs);

        $topicPollObjs = $this->getAll(new \Criteria('topic_haspoll', 1), ['topic_id', 'poll_id']);
        if (empty($topicPollObjs)) {
            return true;
        } // no poll or no topic!!!
        foreach ($topicPollObjs as $tObj) {
            $poll_idInMod = 0;

            foreach ($pollDirs as $dirname) {
                $pollObj = $tObj->getPoll($tObj->getVar('poll_id'), $dirname);
                if (is_object($pollObj) && ($pollObj->getVar('poll_id') == $tObj->getVar('poll_id'))) {
                    ++$poll_idInMod;

                    $dir_def = $dirname;

                }
            }
            // Only one poll module should has this poll_id
            // if 0 there is an error
            if (0 == $poll_idInMod) {

                xoops_error("Error: Cannot find poll module for poll_id='{$tObj->getVar('poll_id')}'");

                return false;
            }
            // if 1 => $dir_def is correct
            if (1 == $poll_idInMod) {

                return $dir_def;

            }
            // if more than 1 continue
        }
        // if there is some topics but no module or more than one module have polls
        xoops_error("Error: Cannot find poll module that is in used in newbb!!! <br\><br\>You should select the correct poll module yourself in newbb > preferences > poll module setting.");

        return false;
    }
    // END irmtfan findPollModule
}


Push — master ( 62af87...249590 )

TopicHandler::findPollModule() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php namespace XoopsModules\Newbb;
			0 ignored issues – show Coding Style Compatibility introduced 2018-01-13 06:21 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 22 and the first side effect is on line 17. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			/**
4			* NewBB 5.0x, the forum module for XOOPS project
5			*
6			* @copyright XOOPS Project (https://xoops.org)
7			* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
8			* @author Taiwen Jiang (phppp or D.J.) <[email protected]>
9			* @since 4.00
10			* @package module::newbb
11			*/
12
13			use XoopsModules\Newbb;
14
15			// defined('XOOPS_ROOT_PATH') \|\| exit('Restricted access.');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-07 04:30 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
16
17			defined('NEWBB_FUNCTIONS_INI') \|\| include $GLOBALS['xoops']->path('modules/newbb/include/functions.ini.php');
18
19			/**
20			* Class TopicHandler
21			*/
22			class TopicHandler extends \XoopsPersistableObjectHandler
23			{
24			/**
25			* @param \XoopsDatabase $db
26			*/
27			public function __construct(\XoopsDatabase $db)
			0 ignored issues – show Comprehensibility introduced 2017-11-20 06:47 UTC by Report Bug Copy Issue Report Avoid variables with short names like $db. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
28			{
29			parent::__construct($db, 'newbb_topics', Topic::class, 'topic_id', 'topic_title');
30			}
31
32			/**
33			* @param mixed $id
34			* @param null\|array $fields
35			* @return mixed\|null
36			*/
37			public function get($id = null, $fields = null) //get($id, $var = null)

mambax7 / newbb5

Push — master ( 62af87...249590 )

TopicHandler::findPollModule() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like