XoopsModules\Newbb\PostHandler::myDelete()

Complexity

Conditions	23
Paths	453

Size

Total Lines	97
Code Lines	54

Duplication

Lines	20
Ratio	20.62 %

Importance

Changes

0

<?php namespace XoopsModules\Newbb;
    public function myDelete(Post $post, $force = false)

function myDelete() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    {
        global $xoopsModule;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        if (!is_object($post) || 0 == $post->getVar('post_id')) {
            return false;
        }

        /* Set active post as deleted */
        if ($post->getVar('approved') > 0 && empty($force)) {
            $sql = 'UPDATE ' . $this->db->prefix('newbb_posts') . ' SET approved = -1 WHERE post_id = ' . $post->getVar('post_id');
            if (!$result = $this->db->queryF($sql)) {

This if statement is empty and can be removed.

            }
            /* delete pending post directly */
        } else {
            $sql = sprintf('DELETE FROM %s WHERE post_id = %u', $this->db->prefix('newbb_posts'), $post->getVar('post_id'));
            if (!$result = $this->db->queryF($sql)) {

This code seems to be duplicated across your project.

                $post->setErrors('delete post error: ' . $sql);

                return false;
            }
            $post->deleteAttachment();

            $sql = sprintf('DELETE FROM %s WHERE post_id = %u', $this->db->prefix('newbb_posts_text'), $post->getVar('post_id'));
            if (!$result = $this->db->queryF($sql)) {

This code seems to be duplicated across your project.

                $post->setErrors('Could not remove post text: ' . $sql);

                return false;
            }
        }

        if ($post->isTopic()) {
            $topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
            /** @var Topic $topicObject */
            $topicObject = $topicHandler->get($post->getVar('topic_id'));
            if (is_object($topicObject) && $topicObject->getVar('approved') > 0 && empty($force)) {
                $topiccount_toupdate = 1;

$topiccount_toupdate does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$topiccount_toupdate is not used, you could remove the assignment.

                $topicObject->setVar('approved', -1);
                $topicHandler->insert($topicObject);
                xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'thread', $post->getVar('topic_id'));
            } else {
                if (is_object($topicObject)) {
                    if ($topicObject->getVar('approved') > 0) {
                        xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'thread', $post->getVar('topic_id'));
                    }

                    $poll_id = $topicObject->getVar('poll_id');

$poll_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    // START irmtfan poll_module
                    $topicObject->deletePoll($poll_id);

$poll_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    // END irmtfan poll_module
                }

                $sql = sprintf('DELETE FROM %s WHERE topic_id = %u', $this->db->prefix('newbb_topics'), $post->getVar('topic_id'));
                if (!$result = $this->db->queryF($sql)) {

This if statement is empty and can be removed.

                    //xoops_error($this->db->error());

73% of this comment could be valid code. Did you maybe forget this after debugging?

                }
                $sql = sprintf('DELETE FROM %s WHERE topic_id = %u', $this->db->prefix('newbb_votedata'), $post->getVar('topic_id'));
                if (!$result = $this->db->queryF($sql)) {

This if statement is empty and can be removed.

                    //xoops_error($this->db->error());

73% of this comment could be valid code. Did you maybe forget this after debugging?

                }
            }
        } else {
            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . ' t
                            LEFT JOIN ' . $this->db->prefix('newbb_posts') . ' p ON p.topic_id = t.topic_id
                            SET t.topic_last_post_id = p.post_id
                            WHERE t.topic_last_post_id = ' . $post->getVar('post_id') . '
                                    AND p.post_id = (SELECT MAX(post_id) FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id=t.topic_id)';
            if (!$result = $this->db->queryF($sql)) {

This if statement is empty and can be removed.

            }
        }

        $postcount_toupdate = $post->getVar('approved');

$postcount_toupdate does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if ($postcount_toupdate > 0) {

$postcount_toupdate does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            // Update user stats
            if ($post->getVar('uid') > 0) {

This code seems to be duplicated across your project.

                /** @var \XoopsMemberHandler $memberHandler */
                $memberHandler = xoops_getHandler('member');
                $poster        = $memberHandler->getUser($post->getVar('uid'));
                if (is_object($poster) && $post->getVar('uid') == $poster->getVar('uid')) {
                    $poster->setVar('posts', $poster->getVar('posts') - 1);
                    $res = $memberHandler->insertUser($poster, true);

$res is not used, you could remove the assignment.

                    unset($poster);
                }
            }
            // irmtfan - just update the pid for approved posts when the post is not topic (pid=0)
            if (!$post->isTopic()) {
                $sql = 'UPDATE ' . $this->db->prefix('newbb_posts') . ' SET pid = ' . $post->getVar('pid') . ' WHERE approved=1 AND pid=' . $post->getVar('post_id');
                if (!$result = $this->db->queryF($sql)) {

This if statement is empty and can be removed.

                    //xoops_error($this->db->error());

73% of this comment could be valid code. Did you maybe forget this after debugging?

                }
            }
        }

        return true;
    }