XoopsModules\Newbb\ForumHandler::getAllTopics()

Complexity

Conditions	68
Paths	> 20000

Size

Total Lines	304
Code Lines	199

Duplication

Lines	76
Ratio	25 %

Importance

Changes

0

<?php namespace XoopsModules\Newbb;
    public function getAllTopics(&$forum, $criteria = null)

getAllTopics uses the super-global variable $GLOBALS which is generally not recommended.

    {
        global $myts, $viewAllForums;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        $startdate = '';

        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.render.php');
        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.session.php');
        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.time.php');
        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.read.php');
        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.topic.php');

        $criteria_vars = ['startdate', 'start', 'sort', 'order', 'type', 'status', 'excerpt'];

$criteria_vars does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        foreach ($criteria_vars as $var) {

$criteria_vars does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            ${$var} = $criteria[$var];
        }

        $topic_lastread = newbbGetCookie('LT', true);

$topic_lastread does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$topic_lastread is not used, you could remove the assignment.

        $criteria_forum = '';

$criteria_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (is_object($forum)) {
            $criteria_forum = ' AND t.forum_id = ' . $forum->getVar('forum_id');

$criteria_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $hot_threshold  = $forum->getVar('hot_threshold');

$hot_threshold does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        } else {

This code seems to be duplicated across your project.

            $hot_threshold = 10;

$hot_threshold does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (is_array($forum) && count($forum) > 0) {
                $criteria_forum = ' AND t.forum_id IN (' . implode(',', array_keys($forum)) . ')';

$criteria_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } elseif (!empty($forum)) {
                $criteria_forum = ' AND t.forum_id =' . (int)$forum;

$criteria_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
        }

        $criteria_post    = $startdate ? ' p.post_time > ' . $startdate : ' 1 = 1 ';

$criteria_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $criteria_topic   = empty($type) ? '' : " AND t.type_id={$type}";

$criteria_topic does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The variable $type seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

        $criteria_extra   = '';

$criteria_extra does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $criteria_approve = ' AND t.approved = 1';

$criteria_approve does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $post_on          = ' p.post_id = t.topic_last_post_id';

$post_on does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$post_on is not used, you could remove the assignment.

        $leftjoin         = ' LEFT JOIN ' . $this->db->prefix('newbb_posts') . ' p ON p.post_id = t.topic_last_post_id';
        $sort_array       = [];

$sort_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        switch ($status) {

The variable $status does not exist. Did you forget to declare it?

            case 'digest':
                $criteria_extra = ' AND t.topic_digest = 1';

$criteria_extra does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                break;

            case 'unreplied':
                $criteria_extra = ' AND t.topic_replies < 1';

$criteria_extra does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                break;

            case 'unread':

This code seems to be duplicated across your project.

                if (empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {

This if statement is empty and can be removed.

                } elseif (2 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
                    // START irmtfan use read_uid to find the unread posts when the user is logged in
                    $read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;

$read_uid does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    if (!empty($read_uid)) {

$read_uid does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        $leftjoin      .= ' LEFT JOIN ' . $this->db->prefix('newbb_reads_topic') . ' r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';

$read_uid does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        $criteria_post .= ' AND (r.read_id IS NULL OR r.post_id < t.topic_last_post_id)';

$criteria_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    } else {

This else statement is empty and can be removed.

                    }
                    // END irmtfan use read_uid to find the unread posts when the user is logged in
                } elseif (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
                    // START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
                    if ($time_criterion = max($GLOBALS['last_visit'], $startdate)) {

$time_criterion does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        $criteria_post  = ' p.post_time > ' . $time_criterion; // for all users

$criteria_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        $topics         = [];
                        $topic_lastread = newbbGetCookie('LT', true);

$topic_lastread does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        if (count($topic_lastread) > 0) {

$topic_lastread does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                            foreach ($topic_lastread as $id => $time) {

$topic_lastread does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The expression $topic_lastread of type array|null is not guaranteed to be traversable. How about adding an additional type check?

                                if ($time > $time_criterion) {

$time_criterion does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                                    $topics[] = $id;
                                }
                            }
                        }
                        if (count($topics) > 0) {
                            $criteria_extra = ' AND t.topic_id NOT IN (' . implode(',', $topics) . ')';

$criteria_extra does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        }
                    }
                    // END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
                }
                break;
            case 'pending':
                $post_on          = ' p.topic_id = t.topic_id';

$post_on does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$post_on is not used, you could remove the assignment.

                $criteria_post    .= ' AND p.pid = 0';

$criteria_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $criteria_approve = ' AND t.approved = 0';

$criteria_approve does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                break;

            case 'deleted':
                $criteria_approve = ' AND t.approved = -1';

$criteria_approve does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                break;

            case 'all': // For viewall.php; do not display sticky topics at first
            case 'active': // same as "all"
                break;

            default:
                if ($startdate > 0) {
                    $criteria_post = ' (p.post_time > ' . $startdate . ' OR t.topic_sticky=1)';

$criteria_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                }
                $sort_array[] = 't.topic_sticky DESC';

$sort_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                break;
        }

        $select = 't.*, ' . ' p.post_time as last_post_time, p.poster_name as last_poster_name, p.icon, p.post_id, p.uid';
        $from   = $this->db->prefix('newbb_topics') . ' t ' . $leftjoin;
        $where  = $criteria_post . $criteria_topic . $criteria_forum . $criteria_extra . $criteria_approve;

$criteria_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if ($excerpt) {

The variable $excerpt does not exist. Did you forget to declare it?

            $select .= ', p.post_karma, p.require_reply, pt.post_text';
            $from   .= ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' pt ON pt.post_id = t.topic_last_post_id';
        }
        if ('u.uname' === $sort) {

The variable $sort seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

            $sort = 't.topic_poster';
        }

        $sort_array[] = trim($sort . ' ' . $order);

$sort_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

The variable $sort does not seem to be defined for all execution paths leading up to this point.

The variable $order does not exist. Did you forget to declare it?

        $sortby       = implode(', ', array_filter($sort_array));

$sort_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (empty($sortby)) {
            $sortby = 't.topic_last_post_id DESC';
        }

        $sql = 'SELECT ' . $select . ' FROM ' . $from . ' WHERE ' . $where . ' ORDER BY ' . $sortby;

        if (!$result = $this->db->query($sql, $GLOBALS['xoopsModuleConfig']['topics_per_page'], $start)) {

The variable $start does not exist. Did you forget to declare it?

            redirect_header('index.php', 2, _MD_NEWBB_ERROROCCURED);
        }

        $sticky  = 0;
        $topics  = [];
        $posters = [];
        $reads   = [];
        $types   = [];

$types is not used, you could remove the assignment.

        /** @var Newbb\TypeHandler $typeHandler */
        $typeHandler = Newbb\Helper::getInstance()->getHandler('Type');
        $typen       = $typeHandler->getByForum($forum->getVar('forum_id'));
        while ($myrow = $this->db->fetchArray($result)) {
            if ($myrow['topic_sticky']) {
                ++$sticky;
            }

            // ------------------------------------------------------
            // topic_icon: priority: sticky -> digest -> regular

            if ($myrow['topic_haspoll']) {
                if ($myrow['topic_sticky']) {
                    $topic_icon = newbbDisplayImage('topic_sticky', _MD_NEWBB_TOPICSTICKY) . '<br>' . newbbDisplayImage('poll', _MD_NEWBB_TOPICHASPOLL);

$topic_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                } else {
                    $topic_icon = newbbDisplayImage('poll', _MD_NEWBB_TOPICHASPOLL);

$topic_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                }
            } elseif ($myrow['topic_sticky']) {
                $topic_icon = newbbDisplayImage('topic_sticky', _MD_NEWBB_TOPICSTICKY);

$topic_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } elseif (!empty($myrow['icon'])) {
                $topic_icon = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($myrow['icon']) . '" alt="" />';

$topic_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } else {
                $topic_icon = '<img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" />';

$topic_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }

            // ------------------------------------------------------
            // rating_img
            $rating = number_format($myrow['rating'] / 2, 0);
            // irmtfan - add alt key for rating
            if ($rating < 1) {

This code seems to be duplicated across your project.

                $rating_img = newbbDisplayImage('blank');

$rating_img does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } else {
                $rating_img = newbbDisplayImage('rate' . $rating, constant('_MD_NEWBB_RATE' . $rating));

$rating_img does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
            // ------------------------------------------------------
            // topic_page_jump
            $topic_page_jump      = '';

$topic_page_jump does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $topic_page_jump_icon = '';

$topic_page_jump_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$topic_page_jump_icon is not used, you could remove the assignment.

            $totalpages           = ceil(($myrow['topic_replies'] + 1) / $GLOBALS['xoopsModuleConfig']['posts_per_page']);
            if ($totalpages > 1) {

This code seems to be duplicated across your project.

                $topic_page_jump .= '  ';

$topic_page_jump does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $append          = false;
                for ($i = 1; $i <= $totalpages; ++$i) {
                    if ($i > 3 && $i < $totalpages) {
                        if (!$append) {
                            $topic_page_jump .= '...';

$topic_page_jump does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                            $append          = true;
                        }
                    } else {
                        $topic_page_jump .= '[<a href="' . XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'] . '&amp;start=' . (($i - 1) * $GLOBALS['xoopsModuleConfig']['posts_per_page']) . '">' . $i . '</a>]';

$topic_page_jump does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        // irmtfan remove here and move
                        //$topic_page_jump_icon = "<a href='" . XOOPS_URL . "/modules/newbb/viewtopic.php?post_id=" . $myrow['post_id'] . "&amp;start=" . (($i - 1) * $GLOBALS['xoopsModuleConfig']['posts_per_page']) . "'>" . newbbDisplayImage('lastposticon',_MD_NEWBB_GOTOLASTPOST) . '</a>';

44% of this comment could be valid code. Did you maybe forget this after debugging?

                    }
                }
            }
            // irmtfan - move here for both topics with and without pages
            $topic_page_jump_icon = "<a href='" . XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $myrow['post_id'] . "'>" . newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST) . '</a>';

$topic_page_jump_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            // ------------------------------------------------------
            // => topic array
            $forum_link = '';

$forum_link does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (!empty($viewAllForums[$myrow['forum_id']])) {
                $forum_link = '<a href="' . XOOPS_URL . '/modules/newbb/viewforum.php?forum=' . $myrow['forum_id'] . '">' . $viewAllForums[$myrow['forum_id']]['forum_name'] . '</a>';

$forum_link does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }

            $topic_title = $myts->htmlSpecialChars($myrow['topic_title']);

$topic_title does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            // irmtfan remove here and move to for loop
            //if ($myrow['type_id'] > 0) {

65% of this comment could be valid code. Did you maybe forget this after debugging?

            //$topic_title = '<span style="color:'.$typen[$myrow["type_id"]]["type_color"].'">['.$typen[$myrow["type_id"]]["type_name"].']</span> '.$topic_title.'';

75% of this comment could be valid code. Did you maybe forget this after debugging?

            //}
            if ($myrow['topic_digest']) {
                $topic_title = "<span class='digest'>" . $topic_title . '</span>';

$topic_title does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }

            if (0 == $excerpt) {
                $topic_excerpt = '';

$topic_excerpt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } elseif (($myrow['post_karma'] > 0 || $myrow['require_reply'] > 0) && !newbbIsAdmin($forum)) {
                $topic_excerpt = '';

$topic_excerpt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } else {

This code seems to be duplicated across your project.

                $topic_excerpt = xoops_substr(newbbHtml2text($myts->displayTarea($myrow['post_text'])), 0, $excerpt);

$topic_excerpt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $topic_excerpt = str_replace('[', '[', $myts->htmlSpecialChars($topic_excerpt));

$topic_excerpt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
            // START irmtfan move here
            $topics[$myrow['topic_id']] = [
                'topic_id'             => $myrow['topic_id'],
                'topic_icon'           => $topic_icon,

$topic_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                'type_id'              => $myrow['type_id'],
                //'type_text'                 => $topic_prefix,/*irmtfan remove here and move to for loop*/
                'topic_title'          => $topic_title,

$topic_title does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                //'topic_link'                => XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'],

48% of this comment could be valid code. Did you maybe forget this after debugging?

                'topic_link'           => 'viewtopic.php?topic_id=' . $myrow['topic_id'],
                'rating_img'           => $rating_img,

$rating_img does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                'topic_page_jump'      => $topic_page_jump,

$topic_page_jump does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                'topic_page_jump_icon' => $topic_page_jump_icon,

$topic_page_jump_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                'topic_replies'        => $myrow['topic_replies'],

                'topic_digest' => $myrow['topic_digest'],
                //mb

                'topic_poster_uid'       => $myrow['topic_poster'],
                'topic_poster_name'      => $myts->htmlSpecialChars($myrow['poster_name'] ?: $GLOBALS['xoopsConfig']['anonymous']),
                'topic_views'            => $myrow['topic_views'],
                'topic_time'             => newbbFormatTimestamp($myrow['topic_time']),
                'topic_last_posttime'    => newbbFormatTimestamp($myrow['last_post_time']),
                'topic_last_poster_uid'  => $myrow['uid'],
                'topic_last_poster_name' => $myts->htmlSpecialChars($myrow['last_poster_name'] ?: $GLOBALS['xoopsConfig']['anonymous']),
                'topic_forum_link'       => $forum_link,

$forum_link does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                'topic_excerpt'          => $topic_excerpt,

$topic_excerpt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                'stick'                  => empty($myrow['topic_sticky']),
                'stats'                  => [
                    $myrow['topic_status'],
                    $myrow['topic_digest'],
                    $myrow['topic_replies']
                ],
                /* irmtfan uncomment use ib the for loop*/
                //"topic_poster"              => $topic_poster,/*irmtfan remove here and move to for loop*/
                //"topic_last_poster"         => $topic_last_poster,/*irmtfan remove here and move to for loop*/
                //"topic_folder"              => newbbDisplayImage($topic_folder,$topic_folder_text),/*irmtfan remove here and move to for loop*/

36% of this comment could be valid code. Did you maybe forget this after debugging?

            ];
            // END irmtfan move here
            /* users */
            $posters[$myrow['topic_poster']] = 1;
            $posters[$myrow['uid']]          = 1;
            // reads
            if (!empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
                $reads[$myrow['topic_id']] = (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) ? $myrow['last_post_time'] : $myrow['topic_last_post_id'];
            }
        }// irmtfan while end
        // START irmtfan move to a for loop
        $posters_name = newbbGetUnameFromIds(array_keys($posters), $GLOBALS['xoopsModuleConfig']['show_realname'], true);

$posters_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        //$topic_poster = newbbGetUnameFromId($myrow['topic_poster'], $GLOBALS['xoopsModuleConfig']['show_realname'], true);

75% of this comment could be valid code. Did you maybe forget this after debugging?

        //$topic_last_poster = newbbGetUnameFromId($myrow['uid'], $GLOBALS['xoopsModuleConfig']['show_realname'], true);

75% of this comment could be valid code. Did you maybe forget this after debugging?

        $topic_isRead = newbbIsRead('topic', $reads);

$topic_isRead does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        foreach (array_keys($topics) as $id) {
            $topics[$id]['topic_read'] = empty($topic_isRead[$id]) ? 0 : 1; // add topic-read/topic-new smarty variable

$topic_isRead does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (!empty($topics[$id]['type_id']) && isset($typen[$topics[$id]['type_id']])) {
                $topics[$id]['topic_title'] = getTopicTitle($topics[$id]['topic_title'], $typen[$topics[$id]['type_id']]['type_name'], $typen[$topics[$id]['type_id']]['type_color']);
            }
            //$topic_prefix =  (!empty($typen[$myrow['type_id']])) ? getTopicTitle("", $typen[$myrow['type_id']]["type_name"], $typen[$myrow['type_id']]["type_color"]) : "";

82% of this comment could be valid code. Did you maybe forget this after debugging?

            $topics[$id]['topic_poster']      = !empty($posters_name[$topics[$id]['topic_poster_uid']]) ? $posters_name[$topics[$id]['topic_poster_uid']] : $topics[$id]['topic_poster_name'];

$posters_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $topics[$id]['topic_last_poster'] = !empty($posters_name[$topics[$id]['topic_last_poster_uid']]) ? $posters_name[$topics[$id]['topic_last_poster_uid']] : $topics[$id]['topic_last_poster_name'];

$posters_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            // ------------------------------------------------------
            // topic_folder: priority: newhot -> hot/new -> regular
            list($topic_status, $topic_digest, $topic_replies) = $topics[$id]['stats'];

$topic_status does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (1 == $topic_status) {

$topic_status does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $topic_folder      = 'topic_locked';

$topic_folder does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $topic_folder_text = _MD_NEWBB_TOPICLOCKED;

$topic_folder_text does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            } else {
                if ($topic_digest) {

$topic_digest does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $topic_folder      = 'topic_digest';

$topic_folder does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $topic_folder_text = _MD_NEWBB_TOPICDIGEST;

$topic_folder_text does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                } elseif ($topic_replies >= $hot_threshold) {

$topic_replies does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $topic_folder      = empty($topic_isRead[$id]) ? 'topic_hot_new' : 'topic_hot';

$topic_folder does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_MORETHAN : _MD_NEWBB_MORETHAN2;

$topic_folder_text does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                } else {

This code seems to be duplicated across your project.

                    $topic_folder      = empty($topic_isRead[$id]) ? 'topic_new' : 'topic';

$topic_folder does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_NEWPOSTS : _MD_NEWBB_NONEWPOSTS;

$topic_folder_text does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                }
            }
            $topics[$id]['topic_folder'] = newbbDisplayImage($topic_folder, $topic_folder_text);

$topic_folder does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            unset($topics[$id]['topic_poster_name'], $topics[$id]['topic_last_poster_name'], $topics[$id]['stats']);
        } // irmtfan end for loop
        // END irmtfan move to a for loop
        if (count($topics) > 0) {

This code seems to be duplicated across your project.

            $sql = ' SELECT DISTINCT topic_id FROM ' . $this->db->prefix('newbb_posts') . " WHERE attachment != ''" . ' AND topic_id IN (' . implode(',', array_keys($topics)) . ')';
            if ($result = $this->db->query($sql)) {
                while (list($topic_id) = $this->db->fetchRow($result)) {

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $topics[$topic_id]['attachment'] = ' ' . newbbDisplayImage('attachment', _MD_NEWBB_TOPICSHASATT);

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                }
            }
        }

        return [$topics, $sticky];
    }