XoopsModules\Newbb\ForumHandler::display()

Complexity

Conditions	20
Paths	4212

Size

Total Lines	119
Code Lines	78

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php namespace XoopsModules\Newbb;
    public function &display($forums, $length_title_index = 30, $count_subforum = 1)

$length_title_index does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

display uses the super-global variable $GLOBALS which is generally not recommended.

    {
        global $myts;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        $posts       = [];
        $postsObject = [];

$postsObject is not used, you could remove the assignment.

        foreach (array_keys($forums) as $id) {
            $posts[] = $forums[$id]['forum_last_post_id'];
        }
        if (!empty($posts)) {
            $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
            $tags_post   = ['uid', 'topic_id', 'post_time', 'poster_name', 'icon'];

$tags_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (!empty($length_title_index)) {

$length_title_index does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $tags_post[] = 'subject';

$tags_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
            $posts = $postHandler->getAll(new \Criteria('post_id', '(' . implode(', ', $posts) . ')', 'IN'), $tags_post, false);

$tags_post does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        // Get topic/post stats per forum
        $stats_forum = [];

$stats_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (!empty($count_subforum)) {

$count_subforum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $stats_forum = $this->getSubforumStats(array_keys($forums)); // irmtfan uncomment to count sub forum posts/topics

$stats_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        $users  = [];
        $reads  = [];
        $topics = [];

$topics is not used, you could remove the assignment.

        foreach (array_keys($forums) as $id) {
            $forum =& $forums[$id];

            if (!$forum['forum_last_post_id']) {
                continue;
            }
            if (!$post = @$posts[$forum['forum_last_post_id']]) {
                $forum['forum_last_post_id'] = 0;
                continue;
            }

            $users[] = $post['uid'];
            if ($moderators[$id] = $forum['forum_moderator']) {
                $users = array_merge($users, $moderators[$id]);

The variable $moderators does not seem to be defined for all execution paths leading up to this point.

            }

            // reads
            if (!empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
                $reads[$id] = (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) ? $post['post_time'] : $post['post_id'];
            }
        }

        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.user.php');
        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.time.php');
        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.render.php');
        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.read.php');
        $forum_isread = newbbIsRead('forum', $reads);

$forum_isread does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $users_linked = newbbGetUnameFromIds(array_unique($users), !empty($GLOBALS['xoopsModuleConfig']['show_realname']), true);

$users_linked does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

!empty($GLOBALS['xoopsModuleConfig']['show_realname']) is of type boolean, but the function expects a integer.

        $forums_array   = [];

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);

$name_anonymous does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        foreach (array_keys($forums) as $id) {
            $forum =& $forums[$id];

            $_forum_data                 = [];

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $_forum_data['forum_order']  = $forum['forum_order'];

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $_forum_data['forum_id']     = $id;

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $_forum_data['forum_cid']    = $forum['cat_id'];

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $_forum_data['forum_name']   = $forum['forum_name'];

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $forumDescLength             = $GLOBALS['xoopsModuleConfig']['forum_desc_length'];
            $_forum_data['forum_desc']   = mb_strimwidth($forum['forum_desc'], 0, $forumDescLength, '...');

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $_forum_data['forum_topics'] = $forum['forum_topics'] + @$stats_forum[$id]['topics'];

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $_forum_data['forum_posts']  = $forum['forum_posts'] + @$stats_forum[$id]['posts'];

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            //$_forum_data["forum_type"]= $forum['forum_type'];

82% of this comment could be valid code. Did you maybe forget this after debugging?

            $forum_moderators = [];

$forum_moderators does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if (!empty($moderators[$id])) {
                foreach (@$moderators[$id] as $moderator) {
                    $forum_moderators[] = @$users_linked[$moderator];

$forum_moderators does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                }
            }
            $_forum_data['forum_moderators'] = implode(', ', $forum_moderators);

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            // irmtfan change if/endif to if{} method
            if ($post_id = $forum['forum_last_post_id']) {

$post_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $post                               =& $posts[$post_id];

$post_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $_forum_data['forum_lastpost_id']   = $post_id;

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $_forum_data['forum_lastpost_time'] = newbbFormatTimestamp($post['post_time']);

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                if (!empty($users_linked[$post['uid']])) {

$users_linked does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $_forum_data['forum_lastpost_user'] = $users_linked[$post['uid']];

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                } elseif ($poster_name = $post['poster_name']) {

$poster_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $_forum_data['forum_lastpost_user'] = $poster_name;

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                } else {
                    $_forum_data['forum_lastpost_user'] = $name_anonymous;

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                }
                if (!empty($length_title_index)) {

$length_title_index does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $subject = $post['subject'];
                    if ($length_title_index < 255) {

$length_title_index does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                        $subject = xoops_substr($subject, 0, $length_title_index);

$length_title_index does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    }
                    $_forum_data['forum_lastpost_subject'] = $subject;

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                }
                // irmtfan - remove icon_path and use newbbDisplayImage
                $_forum_data['forum_lastpost_icon'] = newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST);

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                // START irmtfan change the method to add read smarty
                if (empty($forum_isread[$id])) {

$forum_isread does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $_forum_data['forum_folder'] = newbbDisplayImage('forum_new', _MD_NEWBB_NEWPOSTS);

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $_forum_data['forum_read']   = 0; // irmtfan add forum-read/forum-new smarty variable

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                } else {
                    $_forum_data['forum_folder'] = newbbDisplayImage('forum', _MD_NEWBB_NONEWPOSTS);

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                    $_forum_data['forum_read']   = 1; // irmtfan add forum-read/forum-new smarty variable

$_forum_data does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                }
                // END irmtfan change the method to add read smarty
            }
            $forums_array[$forum['parent_forum']][] = $_forum_data;

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        return $forums_array;

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }