Issues in menu.php - New Issues - Inspection of "namespaces" - mambax7/newbb5 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5fac45...a8bd3e )

by Michael

created 2017-11-22 07:11 UTC

admin/menu.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
//
// ------------------------------------------------------------------------ //
// XOOPS - PHP Content Management System                      //
// Copyright (c) 2000-2016 XOOPS.org                           //
// <https://xoops.org/>                             //
// ------------------------------------------------------------------------ //
// This program is free software; you can redistribute it and/or modify     //
// it under the terms of the GNU General Public License as published by     //
// the Free Software Foundation; either version 2 of the License, or        //
// (at your option) any later version.                                      //
// //
// You may not change or alter any portion of this comment or credits       //
// of supporting developers from this source code or any supporting         //
// source code which is considered copyrighted (c) material of the          //
// original comment or credit authors.                                      //
// //
// This program is distributed in the hope that it will be useful,          //
// but WITHOUT ANY WARRANTY; without even the implied warranty of           //
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
// GNU General Public License for more details.                             //
// //
// You should have received a copy of the GNU General Public License        //
// along with this program; if not, write to the Free Software              //
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
// ------------------------------------------------------------------------ //
// Author: Kazumi Ono (AKA onokazu)                                          //
// URL: http://www.myweb.ne.jp/, https://xoops.org/, http://jp.xoops.org/ //
// Project: XOOPS Project                                                    //
// ------------------------------------------------------------------------- //

use Xoopsmodules\newbb;

require_once __DIR__ . '/../class/Helper.php';
//require_once __DIR__ . '/../include/common.php';

$helper = newbb\Helper::getInstance();

$pathIcon32 = \Xmf\Module\Admin::menuIconPath('');
$pathModIcon32 = $helper->getModule()->getInfo('modicons32');

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_INDEX,
    'link'  => 'admin/index.php',
    'icon'  => $pathIcon32 . 'home.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_CATEGORY,
    'link'  => 'admin/admin_cat_manager.php',
    'icon'  => $pathIcon32 . 'category.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_FORUM,
    'link'  => 'admin/admin_forum_manager.php',
    'icon'  => $pathIcon32 . 'forums.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_PERMISSION,
    'link'  => 'admin/admin_permissions.php',
    'icon'  => $pathIcon32 . 'permissions.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_ORDER,
    'link'  => 'admin/admin_forum_reorder.php',
    'icon'  => $pathIcon32 . 'compfile.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_PRUNE,
    'link'  => 'admin/admin_forum_prune.php',
    'icon'  => $pathIcon32 . 'update.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_REPORT,
    'link'  => 'admin/admin_report.php',
    'icon'  => $pathIcon32 . 'content.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_DIGEST,
    'link'  => 'admin/admin_digest.php',
    'icon'  => $pathIcon32 . 'digest.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_VOTE,
    'link'  => 'admin/admin_votedata.php',
    'icon'  => $pathIcon32 . 'button_ok.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_TYPE,
    'link'  => 'admin/admin_type_manager.php',
    'icon'  => $pathIcon32 . 'type.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_GROUPMOD,
    'link'  => 'admin/admin_groupmod.php',
    'icon'  => $pathIcon32 . 'groupmod.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_SYNC,
    'link'  => 'admin/admin_synchronization.php',
    'icon'  => $pathIcon32 . 'synchronized.png'
];

$adminmenu[] = [
    'title' => _MI_NEWBB_ADMENU_ABOUT,
    'link'  => 'admin/about.php',
    'icon'  => $pathIcon32 . 'about.png'
];


1			<?php
2			//
3			// ------------------------------------------------------------------------ //
4			// XOOPS - PHP Content Management System //
5			// Copyright (c) 2000-2016 XOOPS.org //
6			// <https://xoops.org/> //
7			// ------------------------------------------------------------------------ //
8			// This program is free software; you can redistribute it and/or modify //
9			// it under the terms of the GNU General Public License as published by //
10			// the Free Software Foundation; either version 2 of the License, or //
11			// (at your option) any later version. //
12			// //
13			// You may not change or alter any portion of this comment or credits //
14			// of supporting developers from this source code or any supporting //
15			// source code which is considered copyrighted (c) material of the //
16			// original comment or credit authors. //
17			// //
18			// This program is distributed in the hope that it will be useful, //
19			// but WITHOUT ANY WARRANTY; without even the implied warranty of //
20			// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
21			// GNU General Public License for more details. //
22			// //
23			// You should have received a copy of the GNU General Public License //
24			// along with this program; if not, write to the Free Software //
25			// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
26			// ------------------------------------------------------------------------ //
27			// Author: Kazumi Ono (AKA onokazu) //
28			// URL: http://www.myweb.ne.jp/, https://xoops.org/, http://jp.xoops.org/ //
29			// Project: XOOPS Project //
30			// ------------------------------------------------------------------------- //
31
32			use Xoopsmodules\newbb;
33
34			require_once __DIR__ . '/../class/Helper.php';
35			//require_once __DIR__ . '/../include/common.php';
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-22 07:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
36			$helper = newbb\Helper::getInstance();
37
38			$pathIcon32 = \Xmf\Module\Admin::menuIconPath('');
39			$pathModIcon32 = $helper->getModule()->getInfo('modicons32');
40
41			$adminmenu[] = [
42			'title' => _MI_NEWBB_ADMENU_INDEX,
43			'link' => 'admin/index.php',
44			'icon' => $pathIcon32 . 'home.png'
45			];
46
47			$adminmenu[] = [
48			'title' => _MI_NEWBB_ADMENU_CATEGORY,
49			'link' => 'admin/admin_cat_manager.php',
50			'icon' => $pathIcon32 . 'category.png'
51			];
52
53			$adminmenu[] = [
54			'title' => _MI_NEWBB_ADMENU_FORUM,
55			'link' => 'admin/admin_forum_manager.php',
56			'icon' => $pathIcon32 . 'forums.png'
57			];
58
59			$adminmenu[] = [
60			'title' => _MI_NEWBB_ADMENU_PERMISSION,
61			'link' => 'admin/admin_permissions.php',
62			'icon' => $pathIcon32 . 'permissions.png'
63			];
64
65			$adminmenu[] = [
66			'title' => _MI_NEWBB_ADMENU_ORDER,
67			'link' => 'admin/admin_forum_reorder.php',
68			'icon' => $pathIcon32 . 'compfile.png'
69			];
70
71			$adminmenu[] = [
72			'title' => _MI_NEWBB_ADMENU_PRUNE,
73			'link' => 'admin/admin_forum_prune.php',
74			'icon' => $pathIcon32 . 'update.png'
75			];
76
77			$adminmenu[] = [
78			'title' => _MI_NEWBB_ADMENU_REPORT,
79			'link' => 'admin/admin_report.php',
80			'icon' => $pathIcon32 . 'content.png'
81			];
82
83			$adminmenu[] = [
84			'title' => _MI_NEWBB_ADMENU_DIGEST,
85			'link' => 'admin/admin_digest.php',
86			'icon' => $pathIcon32 . 'digest.png'
87			];
88
89			$adminmenu[] = [
90			'title' => _MI_NEWBB_ADMENU_VOTE,
91			'link' => 'admin/admin_votedata.php',
92			'icon' => $pathIcon32 . 'button_ok.png'
93			];
94
95			$adminmenu[] = [
96			'title' => _MI_NEWBB_ADMENU_TYPE,
97			'link' => 'admin/admin_type_manager.php',
98			'icon' => $pathIcon32 . 'type.png'
99			];
100
101			$adminmenu[] = [
102			'title' => _MI_NEWBB_ADMENU_GROUPMOD,
103			'link' => 'admin/admin_groupmod.php',
104			'icon' => $pathIcon32 . 'groupmod.png'
105			];
106
107			$adminmenu[] = [
108			'title' => _MI_NEWBB_ADMENU_SYNC,
109			'link' => 'admin/admin_synchronization.php',
110			'icon' => $pathIcon32 . 'synchronized.png'
111			];
112
113			$adminmenu[] = [
114			'title' => _MI_NEWBB_ADMENU_ABOUT,
115			'link' => 'admin/about.php',
116			'icon' => $pathIcon32 . 'about.png'
117			];
118

mambax7 / newbb5

Push — master ( 5fac45...a8bd3e )

admin/menu.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like