mambax7 / newbb5

class/ForumHandler.php

Indentation +1020 added lines, -1020 removed lines

@@ -26,613 +26,613 @@ 
  */
 class ForumHandler extends \XoopsPersistableObjectHandler
 {
-    /**
-     * @param null|\XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db = null)
-    {
-        parent::__construct($db, 'newbb_forums', Forum::class, 'forum_id', 'forum_name');
-    }
-
-    /**
-     * @param \XoopsObject $object
-     * @param  bool        $force
-     * @return bool
-     * @internal param \XoopsObject $forum
-     */
-
-    public function insert(\XoopsObject $object, $force = true) //insert($forum)
-    {
-        $forum = $object;
-        if (!parent::insert($forum, true)) {
-            return false;
-        }
-
-        if ($forum->isNew()) {
-            $this->applyPermissionTemplate($forum);
-        }
-
-        return $forum->getVar('forum_id');
-    }
-
-    /**
-     * @param \XoopsObject $forum
-     * @param  bool        $force
-     * @return bool
-     */
-    public function delete(\XoopsObject $forum, $force = false) //delete(&$forum)
-    {
-        global $xoopsModule;
-        // RMV-NOTIFY
-        xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'forum', $forum->getVar('forum_id'));
-        // Get list of all topics in forum, to delete them too
-        /** @var Newbb\TopicHandler $topicHandler */
-        $topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
-        $topicHandler->deleteAll(new \Criteria('forum_id', $forum->getVar('forum_id')), true, true);
-        $this->updateAll('parent_forum', $forum->getVar('parent_forum'), new \Criteria('parent_forum', $forum->getVar('forum_id')));
-        $this->deletePermission($forum);
-
-        return parent::delete($forum);
-    }
-
-    /**
-     * @param  string $perm
-     * @return mixed
-     */
-    public function getIdsByPermission($perm = 'access')
-    {
-        /** var Newbb\PermissionHandler $permHandler */
-        $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
-        return $permHandler->getForums($perm);
-    }
-
-    /**
-     * @param  int|array    $cat
-     * @param  string $permission
-     * @param  null   $tags
-     * @param  bool   $asObject
-     * @return array
-     */
-    public function &getByPermission($cat = 0, $permission = 'access', $tags = null, $asObject = true)
-    {
-        $_cachedForums = [];
-        if (!$valid_ids = $this->getIdsByPermission($permission)) {
-            return $_cachedForums;
-        }
-
-        $criteria = new \CriteriaCompo(new \Criteria('forum_id', '(' . implode(', ', $valid_ids) . ')', 'IN'));
-        if (is_numeric($cat) && $cat > 0) {
-            $criteria->add(new \Criteria('cat_id', (int)$cat));
-        } elseif (is_array($cat) && count($cat) > 0) {
-            $criteria->add(new \Criteria('cat_id', '(' . implode(', ', $cat) . ')', 'IN'));
-        }
-        $criteria->setSort('forum_order');
-        $criteria->setOrder('ASC');
-        $_cachedForums = $this->getAll($criteria, $tags, $asObject);
-
-        return $_cachedForums;
-    }
-
-    /**
-     * @param  int    $categoryid
-     * @param  string $permission
-     * @param  bool   $asObject
-     * @param  null   $tags
-     * @return array
-     */
-    public function &getForumsByCategory($categoryid = 0, $permission = '', $asObject = true, $tags = null)
-    {
-        $forums = $this->getByPermission($categoryid, $permission, $tags);
-        if ($asObject) {
-            return $forums;
-        }
-
-        $forums_array = [];
-        $array_cat    = [];
-        $array_forum  = [];
-        if (!is_array($forums)) {
-            return [];
-        }
-        foreach (array_keys($forums) as $forumid) {
-            $forum                                                  = $forums[$forumid];
-            $forums_array[$forum->getVar('parent_forum')][$forumid] = [
-                'cid'   => $forum->getVar('cat_id'),
-                'title' => $forum->getVar('forum_name')
-            ];
-        }
-        if (!isset($forums_array[0])) {
-            $ret = [];
-
-            return $ret;
-        }
-        foreach ($forums_array[0] as $key => $forum) {
-            if (isset($forums_array[$key])) {
-                $forum['sub'] = $forums_array[$key];
-            }
-            $array_forum[$forum['cid']][$key] = $forum;
-        }
-        ksort($array_forum);
-        unset($forums, $forums_array);
-
-        return $array_forum;
-    }
-
-    /**
-     * @param        $forum
-     * @param  null  $criteria
-     * @return array
-     */
-    public function getAllTopics(&$forum, $criteria = null)
-    {
-        global $myts, $viewAllForums;
-        $startdate = '';
-
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.render.php');
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.session.php');
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.time.php');
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.read.php');
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.topic.php');
-
-        $criteria_vars = ['startdate', 'start', 'sort', 'order', 'type', 'status', 'excerpt'];
-        foreach ($criteria_vars as $var) {
-            ${$var} = $criteria[$var];
-        }
-
-        $topic_lastread = newbbGetCookie('LT', true);
-        $criteria_forum = '';
-        if (is_object($forum)) {
-            $criteria_forum = ' AND t.forum_id = ' . $forum->getVar('forum_id');
-            $hot_threshold  = $forum->getVar('hot_threshold');
-        } else {
-            $hot_threshold = 10;
-            if (is_array($forum) && count($forum) > 0) {
-                $criteria_forum = ' AND t.forum_id IN (' . implode(',', array_keys($forum)) . ')';
-            } elseif (!empty($forum)) {
-                $criteria_forum = ' AND t.forum_id =' . (int)$forum;
-            }
-        }
-
-        $criteria_post    = $startdate ? ' p.post_time > ' . $startdate : ' 1 = 1 ';
-        $criteria_topic   = empty($type) ? '' : " AND t.type_id={$type}";
-        $criteria_extra   = '';
-        $criteria_approve = ' AND t.approved = 1';
-        $post_on          = ' p.post_id = t.topic_last_post_id';
-        $leftjoin         = ' LEFT JOIN ' . $this->db->prefix('newbb_posts') . ' p ON p.post_id = t.topic_last_post_id';
-        $sort_array       = [];
-        switch ($status) {
-            case 'digest':
-                $criteria_extra = ' AND t.topic_digest = 1';
-                break;
-
-            case 'unreplied':
-                $criteria_extra = ' AND t.topic_replies < 1';
-                break;
-
-            case 'unread':
-                if (empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
-                } elseif (2 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
-                    // START irmtfan use read_uid to find the unread posts when the user is logged in
-                    $read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
-                    if (!empty($read_uid)) {
-                        $leftjoin      .= ' LEFT JOIN ' . $this->db->prefix('newbb_reads_topic') . ' r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
-                        $criteria_post .= ' AND (r.read_id IS NULL OR r.post_id < t.topic_last_post_id)';
-                    } else {
-                    }
-                    // END irmtfan use read_uid to find the unread posts when the user is logged in
-                } elseif (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
-                    // START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
-                    if ($time_criterion = max($GLOBALS['last_visit'], $startdate)) {
-                        $criteria_post  = ' p.post_time > ' . $time_criterion; // for all users
-                        $topics         = [];
-                        $topic_lastread = newbbGetCookie('LT', true);
-                        if (count($topic_lastread) > 0) {
-                            foreach ($topic_lastread as $id => $time) {
-                                if ($time > $time_criterion) {
-                                    $topics[] = $id;
-                                }
-                            }
-                        }
-                        if (count($topics) > 0) {
-                            $criteria_extra = ' AND t.topic_id NOT IN (' . implode(',', $topics) . ')';
-                        }
-                    }
-                    // END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
-                }
-                break;
-            case 'pending':
-                $post_on          = ' p.topic_id = t.topic_id';
-                $criteria_post    .= ' AND p.pid = 0';
-                $criteria_approve = ' AND t.approved = 0';
-                break;
-
-            case 'deleted':
-                $criteria_approve = ' AND t.approved = -1';
-                break;
-
-            case 'all': // For viewall.php; do not display sticky topics at first
-            case 'active': // same as "all"
-                break;
-
-            default:
-                if ($startdate > 0) {
-                    $criteria_post = ' (p.post_time > ' . $startdate . ' OR t.topic_sticky=1)';
-                }
-                $sort_array[] = 't.topic_sticky DESC';
-                break;
-        }
-
-        $select = 't.*, ' . ' p.post_time as last_post_time, p.poster_name as last_poster_name, p.icon, p.post_id, p.uid';
-        $from   = $this->db->prefix('newbb_topics') . ' t ' . $leftjoin;
-        $where  = $criteria_post . $criteria_topic . $criteria_forum . $criteria_extra . $criteria_approve;
-
-        if ($excerpt) {
-            $select .= ', p.post_karma, p.require_reply, pt.post_text';
-            $from   .= ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' pt ON pt.post_id = t.topic_last_post_id';
-        }
-        if ('u.uname' === $sort) {
-            $sort = 't.topic_poster';
-        }
-
-        $sort_array[] = trim($sort . ' ' . $order);
-        $sortby       = implode(', ', array_filter($sort_array));
-        if (empty($sortby)) {
-            $sortby = 't.topic_last_post_id DESC';
-        }
-
-        $sql = 'SELECT ' . $select . ' FROM ' . $from . ' WHERE ' . $where . ' ORDER BY ' . $sortby;
-
-        if (!$result = $this->db->query($sql, $GLOBALS['xoopsModuleConfig']['topics_per_page'], $start)) {
-            redirect_header('index.php', 2, _MD_NEWBB_ERROROCCURED);
-        }
-
-        $sticky  = 0;
-        $topics  = [];
-        $posters = [];
-        $reads   = [];
-        $types   = [];
-
-        /** @var Newbb\TypeHandler $typeHandler */
-        $typeHandler = Newbb\Helper::getInstance()->getHandler('Type');
-        $typen       = $typeHandler->getByForum($forum->getVar('forum_id'));
-        while (false !== ($myrow = $this->db->fetchArray($result))) {
-            if ($myrow['topic_sticky']) {
-                ++$sticky;
-            }
-
-            // ------------------------------------------------------
-            // topic_icon: priority: sticky -> digest -> regular
-
-            if ($myrow['topic_haspoll']) {
-                if ($myrow['topic_sticky']) {
-                    $topic_icon = newbbDisplayImage('topic_sticky', _MD_NEWBB_TOPICSTICKY) . '<br>' . newbbDisplayImage('poll', _MD_NEWBB_TOPICHASPOLL);
-                } else {
-                    $topic_icon = newbbDisplayImage('poll', _MD_NEWBB_TOPICHASPOLL);
-                }
-            } elseif ($myrow['topic_sticky']) {
-                $topic_icon = newbbDisplayImage('topic_sticky', _MD_NEWBB_TOPICSTICKY);
-            } elseif (!empty($myrow['icon'])) {
-                $topic_icon = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($myrow['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
-            } else {
-                $topic_icon = '<img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" />';
-            }
-
-            // ------------------------------------------------------
-            // rating_img
-            $rating = number_format($myrow['rating'] / 2, 0);
-            // irmtfan - add alt key for rating
-            if ($rating < 1) {
-                $rating_img = newbbDisplayImage('blank');
-            } else {
-                $rating_img = newbbDisplayImage('rate' . $rating, constant('_MD_NEWBB_RATE' . $rating));
-            }
-            // ------------------------------------------------------
-            // topic_page_jump
-            $topic_page_jump      = '';
-            $topic_page_jump_icon = '';
-            $totalpages           = ceil(($myrow['topic_replies'] + 1) / $GLOBALS['xoopsModuleConfig']['posts_per_page']);
-            if ($totalpages > 1) {
-                $topic_page_jump .= '&nbsp;&nbsp;';
-                $append          = false;
-                for ($i = 1; $i <= $totalpages; ++$i) {
-                    if ($i > 3 && $i < $totalpages) {
-                        if (!$append) {
-                            $topic_page_jump .= '...';
-                            $append          = true;
-                        }
-                    } else {
-                        $topic_page_jump .= '[<a href="' . XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'] . '&amp;start=' . (($i - 1) * $GLOBALS['xoopsModuleConfig']['posts_per_page']) . '">' . $i . '</a>]';
-                        // irmtfan remove here and move
-                        //$topic_page_jump_icon = "<a href='" . XOOPS_URL . "/modules/newbb/viewtopic.php?post_id=" . $myrow['post_id'] . "&amp;start=" . (($i - 1) * $GLOBALS['xoopsModuleConfig']['posts_per_page']) . "'>" . newbbDisplayImage('lastposticon',_MD_NEWBB_GOTOLASTPOST) . '</a>';
-                    }
-                }
-            }
-            // irmtfan - move here for both topics with and without pages
-            $topic_page_jump_icon = "<a href='" . XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $myrow['post_id'] . "'>" . newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST) . '</a>';
-
-            // ------------------------------------------------------
-            // => topic array
-            $forum_link = '';
-            if (!empty($viewAllForums[$myrow['forum_id']])) {
-                $forum_link = '<a href="' . XOOPS_URL . '/modules/newbb/viewforum.php?forum=' . $myrow['forum_id'] . '">' . $viewAllForums[$myrow['forum_id']]['forum_name'] . '</a>';
-            }
-
-            $topic_title = $myts->htmlSpecialChars($myrow['topic_title']);
-            // irmtfan remove here and move to for loop
-            //if ($myrow['type_id'] > 0) {
-            //$topic_title = '<span style="color:'.$typen[$myrow["type_id"]]["type_color"].'">['.$typen[$myrow["type_id"]]["type_name"].']</span> '.$topic_title.'';
-            //}
-            if ($myrow['topic_digest']) {
-                $topic_title = "<span class='digest'>" . $topic_title . '</span>';
-            }
-
-            if (0 == $excerpt) {
-                $topic_excerpt = '';
-            } elseif (($myrow['post_karma'] > 0 || $myrow['require_reply'] > 0) && !newbbIsAdmin($forum)) {
-                $topic_excerpt = '';
-            } else {
-                $topic_excerpt = xoops_substr(newbbHtml2text($myts->displayTarea($myrow['post_text'])), 0, $excerpt);
-                $topic_excerpt = str_replace('[', '&#91;', $myts->htmlSpecialChars($topic_excerpt));
-            }
-            // START irmtfan move here
-            $topics[$myrow['topic_id']] = [
-                'topic_id'             => $myrow['topic_id'],
-                'topic_icon'           => $topic_icon,
-                'type_id'              => $myrow['type_id'],
-                //'type_text'                 => $topic_prefix,/*irmtfan remove here and move to for loop*/
-                'topic_title'          => $topic_title,
-                //'topic_link'                => XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'],
-                'topic_link'           => 'viewtopic.php?topic_id=' . $myrow['topic_id'],
-                'rating_img'           => $rating_img,
-                'topic_page_jump'      => $topic_page_jump,
-                'topic_page_jump_icon' => $topic_page_jump_icon,
-                'topic_replies'        => $myrow['topic_replies'],
-
-                'topic_digest' => $myrow['topic_digest'],
-                //mb
-
-                'topic_poster_uid'       => $myrow['topic_poster'],
-                'topic_poster_name'      => $myts->htmlSpecialChars($myrow['poster_name'] ?: $GLOBALS['xoopsConfig']['anonymous']),
-                'topic_views'            => $myrow['topic_views'],
-                'topic_time'             => newbbFormatTimestamp($myrow['topic_time']),
-                'topic_last_posttime'    => newbbFormatTimestamp($myrow['last_post_time']),
-                'topic_last_poster_uid'  => $myrow['uid'],
-                'topic_last_poster_name' => $myts->htmlSpecialChars($myrow['last_poster_name'] ?: $GLOBALS['xoopsConfig']['anonymous']),
-                'topic_forum_link'       => $forum_link,
-                'topic_excerpt'          => $topic_excerpt,
-                'stick'                  => empty($myrow['topic_sticky']),
-                'stats'                  => [
-                    $myrow['topic_status'],
-                    $myrow['topic_digest'],
-                    $myrow['topic_replies']
-                ],
-                /* irmtfan uncomment use ib the for loop*/
-                //"topic_poster"              => $topic_poster,/*irmtfan remove here and move to for loop*/
-                //"topic_last_poster"         => $topic_last_poster,/*irmtfan remove here and move to for loop*/
-                //"topic_folder"              => newbbDisplayImage($topic_folder,$topic_folder_text),/*irmtfan remove here and move to for loop*/
-            ];
-            // END irmtfan move here
-            /* users */
-            $posters[$myrow['topic_poster']] = 1;
-            $posters[$myrow['uid']]          = 1;
-            // reads
-            if (!empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
-                $reads[$myrow['topic_id']] = (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) ? $myrow['last_post_time'] : $myrow['topic_last_post_id'];
-            }
-        }// irmtfan while end
-        // START irmtfan move to a for loop
-        $posters_name = newbbGetUnameFromIds(array_keys($posters), $GLOBALS['xoopsModuleConfig']['show_realname'], true);
-        //$topic_poster = newbbGetUnameFromId($myrow['topic_poster'], $GLOBALS['xoopsModuleConfig']['show_realname'], true);
-        //$topic_last_poster = newbbGetUnameFromId($myrow['uid'], $GLOBALS['xoopsModuleConfig']['show_realname'], true);
-        $topic_isRead = newbbIsRead('topic', $reads);
-        foreach (array_keys($topics) as $id) {
-            $topics[$id]['topic_read'] = empty($topic_isRead[$id]) ? 0 : 1; // add topic-read/topic-new smarty variable
-            if (!empty($topics[$id]['type_id']) && isset($typen[$topics[$id]['type_id']])) {
-                $topics[$id]['topic_title'] = getTopicTitle($topics[$id]['topic_title'], $typen[$topics[$id]['type_id']]['type_name'], $typen[$topics[$id]['type_id']]['type_color']);
-            }
-            //$topic_prefix =  (!empty($typen[$myrow['type_id']])) ? getTopicTitle("", $typen[$myrow['type_id']]["type_name"], $typen[$myrow['type_id']]["type_color"]) : "";
-            $topics[$id]['topic_poster']      = !empty($posters_name[$topics[$id]['topic_poster_uid']]) ? $posters_name[$topics[$id]['topic_poster_uid']] : $topics[$id]['topic_poster_name'];
-            $topics[$id]['topic_last_poster'] = !empty($posters_name[$topics[$id]['topic_last_poster_uid']]) ? $posters_name[$topics[$id]['topic_last_poster_uid']] : $topics[$id]['topic_last_poster_name'];
-
-            // ------------------------------------------------------
-            // topic_folder: priority: newhot -> hot/new -> regular
-            list($topic_status, $topic_digest, $topic_replies) = $topics[$id]['stats'];
-            if (1 == $topic_status) {
-                $topic_folder      = 'topic_locked';
-                $topic_folder_text = _MD_NEWBB_TOPICLOCKED;
-            } else {
-                if ($topic_digest) {
-                    $topic_folder      = 'topic_digest';
-                    $topic_folder_text = _MD_NEWBB_TOPICDIGEST;
-                } elseif ($topic_replies >= $hot_threshold) {
-                    $topic_folder      = empty($topic_isRead[$id]) ? 'topic_hot_new' : 'topic_hot';
-                    $topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_MORETHAN : _MD_NEWBB_MORETHAN2;
-                } else {
-                    $topic_folder      = empty($topic_isRead[$id]) ? 'topic_new' : 'topic';
-                    $topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_NEWPOSTS : _MD_NEWBB_NONEWPOSTS;
-                }
-            }
-            $topics[$id]['topic_folder'] = newbbDisplayImage($topic_folder, $topic_folder_text);
-            unset($topics[$id]['topic_poster_name'], $topics[$id]['topic_last_poster_name'], $topics[$id]['stats']);
-        } // irmtfan end for loop
-        // END irmtfan move to a for loop
-        if (count($topics) > 0) {
-            $sql = ' SELECT DISTINCT topic_id FROM ' . $this->db->prefix('newbb_posts') . " WHERE attachment != ''" . ' AND topic_id IN (' . implode(',', array_keys($topics)) . ')';
-            if ($result = $this->db->query($sql)) {
-                while (false !== (list($topic_id) = $this->db->fetchRow($result))) {
-                    $topics[$topic_id]['attachment'] = '&nbsp;' . newbbDisplayImage('attachment', _MD_NEWBB_TOPICSHASATT);
-                }
-            }
-        }
-
-        return [$topics, $sticky];
-    }
-
-    /**
-     * @param $forum
-     * @param $startdate
-     * @param $type
-     * @return null|int
-     */
-    public function getTopicCount(&$forum, $startdate, $type)
-    {
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.session.php');
-
-        $criteria_extra   = '';
-        $criteria_approve = ' AND t.approved = 1'; // any others?
-        $leftjoin         = ' LEFT JOIN ' . $this->db->prefix('newbb_posts') . ' p ON p.post_id = t.topic_last_post_id';
-        $criteria_post    = ' p.post_time > ' . $startdate;
-        switch ($type) {
-            case 'digest':
-                $criteria_extra = ' AND topic_digest = 1';
-                break;
-            case 'unreplied':
-                $criteria_extra = ' AND topic_replies < 1';
-                break;
-            case 'unread':
-                if (empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
-                } elseif (2 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
-                    // START irmtfan use read_uid to find the unread posts when the user is logged in
-
-                    $read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
-                    if (!empty($read_uid)) {
-                        $leftjoin      .= ' LEFT JOIN ' . $this->db->prefix('newbb_reads_topic') . ' r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
-                        $criteria_post .= ' AND (r.read_id IS NULL OR r.post_id < t.topic_last_post_id)';
-                    } else {
-                    }
-                    // END irmtfan use read_uid to find the unread posts when the user is logged in
-                } elseif (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
-                    // START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
-                    if ($time_criterion = max($GLOBALS['last_visit'], $startdate)) {
-                        $criteria_post  = ' p.post_time > ' . $time_criterion; // for all users
-                        $topics         = [];
-                        $topic_lastread = newbbGetCookie('LT', true);
-                        if (count($topic_lastread) > 0) {
-                            foreach ($topic_lastread as $id => $time) {
-                                if ($time > $time_criterion) {
-                                    $topics[] = $id;
-                                }
-                            }
-                        }
-                        if (count($topics) > 0) {
-                            $criteria_extra = ' AND t.topic_id NOT IN (' . implode(',', $topics) . ')';
-                        }
-                    }
-                    // END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
-                }
-                break;
-            case 'pending':
-                $criteria_approve = ' AND t.approved = 0';
-                break;
-            case 'deleted':
-                $criteria_approve = ' AND t.approved = -1';
-                break;
-            case 'all':
-                break;
-            default:
-                $criteria_post = ' (p.post_time > ' . $startdate . ' OR t.topic_sticky=1)';
-                break;
-        }
-        $criteria_forum = '';
-        if (is_object($forum)) {
-            $criteria_forum = ' AND t.forum_id = ' . $forum->getVar('forum_id');
-        } else {
-            if (is_array($forum) && count($forum) > 0) {
-                $criteria_forum = ' AND t.forum_id IN (' . implode(',', array_keys($forum)) . ')';
-            } elseif (!empty($forum)) {
-                $criteria_forum = ' AND t.forum_id =' . (int)$forum;
-            }
-        }
-
-        $sql = 'SELECT COUNT(*) AS count FROM ' . $this->db->prefix('newbb_topics') . ' t ' . $leftjoin;
-        $sql .= ' WHERE ' . $criteria_post . $criteria_forum . $criteria_extra . $criteria_approve;
-        if (!$result = $this->db->query($sql)) {
-            //xoops_error($this->db->error().'<br>'.$sql);
-            return null;
-        }
-        $myrow = $this->db->fetchArray($result);
-        $count = $myrow['count'];
-
-        return $count;
-    }
-
-    // get permission
-
-    /**
-     * @param         $forum
-     * @param  string $type
-     * @param  bool   $checkCategory
-     * @return bool
-     */
-    public function getPermission($forum, $type = 'access', $checkCategory = true)
-    {
-        global $xoopsModule;
-        static $_cachedPerms;
-
-        if ('all' === $type) {
-            return true;
-        }
-
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
-        if (newbbIsAdmin($forum)) {
-            return true;
-        }
-        //if ($GLOBALS["xoopsUserIsAdmin"] && $xoopsModule->getVar("dirname") === "newbb") {
-        //return true;
-        //}
-
-        if (!is_object($forum)) {
-            $forum = $this->get($forum);
-        }
-
-        if (!empty($checkCategory)) {
-            /** @var Newbb\CategoryHandler $categoryHandler */
-            $categoryHandler = Newbb\Helper::getInstance()->getHandler('Category');
-            $categoryPerm    = $categoryHandler->getPermission($forum->getVar('cat_id'));
-            if (!$categoryPerm) {
-                return false;
-            }
-        }
-
-        $type = strtolower($type);
-        // START irmtfan commented and removed
-        //if ('moderate' === $type) {
-        //require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.user.php');
-        //$permission = newbbIsModerator($forum);
-        //} else {
-        $forum_id = $forum->getVar('forum_id');
-        /** var Newbb\PermissionHandler $permHandler */
-        $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
-        $permission  = $permHandler->getPermission('forum', $type, $forum_id);
-        //}
-        // END irmtfan commented and removed
-        return $permission;
-    }
-
-    /**
-     * @param $forum
-     * @return mixed
-     */
-    public function deletePermission(&$forum)
-    {
-        /** var Newbb\PermissionHandler $permHandler */
-        $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
-
-        return $permHandler->deleteByForum($forum->getVar('forum_id'));
-    }
-
-    /**
-     * @param $forum
-     * @return mixed
-     */
-    public function applyPermissionTemplate(&$forum)
-    {
-        /** var Newbb\PermissionHandler $permHandler */
-        $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
-
-        return $permHandler->applyTemplate($forum->getVar('forum_id'));
-    }
-
-    /*
+	/**
+	 * @param null|\XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db = null)
+	{
+		parent::__construct($db, 'newbb_forums', Forum::class, 'forum_id', 'forum_name');
+	}
+
+	/**
+	 * @param \XoopsObject $object
+	 * @param  bool        $force
+	 * @return bool
+	 * @internal param \XoopsObject $forum
+	 */
+
+	public function insert(\XoopsObject $object, $force = true) //insert($forum)
+	{
+		$forum = $object;
+		if (!parent::insert($forum, true)) {
+			return false;
+		}
+
+		if ($forum->isNew()) {
+			$this->applyPermissionTemplate($forum);
+		}
+
+		return $forum->getVar('forum_id');
+	}
+
+	/**
+	 * @param \XoopsObject $forum
+	 * @param  bool        $force
+	 * @return bool
+	 */
+	public function delete(\XoopsObject $forum, $force = false) //delete(&$forum)
+	{
+		global $xoopsModule;
+		// RMV-NOTIFY
+		xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'forum', $forum->getVar('forum_id'));
+		// Get list of all topics in forum, to delete them too
+		/** @var Newbb\TopicHandler $topicHandler */
+		$topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
+		$topicHandler->deleteAll(new \Criteria('forum_id', $forum->getVar('forum_id')), true, true);
+		$this->updateAll('parent_forum', $forum->getVar('parent_forum'), new \Criteria('parent_forum', $forum->getVar('forum_id')));
+		$this->deletePermission($forum);
+
+		return parent::delete($forum);
+	}
+
+	/**
+	 * @param  string $perm
+	 * @return mixed
+	 */
+	public function getIdsByPermission($perm = 'access')
+	{
+		/** var Newbb\PermissionHandler $permHandler */
+		$permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
+		return $permHandler->getForums($perm);
+	}
+
+	/**
+	 * @param  int|array    $cat
+	 * @param  string $permission
+	 * @param  null   $tags
+	 * @param  bool   $asObject
+	 * @return array
+	 */
+	public function &getByPermission($cat = 0, $permission = 'access', $tags = null, $asObject = true)
+	{
+		$_cachedForums = [];
+		if (!$valid_ids = $this->getIdsByPermission($permission)) {
+			return $_cachedForums;
+		}
+
+		$criteria = new \CriteriaCompo(new \Criteria('forum_id', '(' . implode(', ', $valid_ids) . ')', 'IN'));
+		if (is_numeric($cat) && $cat > 0) {
+			$criteria->add(new \Criteria('cat_id', (int)$cat));
+		} elseif (is_array($cat) && count($cat) > 0) {
+			$criteria->add(new \Criteria('cat_id', '(' . implode(', ', $cat) . ')', 'IN'));
+		}
+		$criteria->setSort('forum_order');
+		$criteria->setOrder('ASC');
+		$_cachedForums = $this->getAll($criteria, $tags, $asObject);
+
+		return $_cachedForums;
+	}
+
+	/**
+	 * @param  int    $categoryid
+	 * @param  string $permission
+	 * @param  bool   $asObject
+	 * @param  null   $tags
+	 * @return array
+	 */
+	public function &getForumsByCategory($categoryid = 0, $permission = '', $asObject = true, $tags = null)
+	{
+		$forums = $this->getByPermission($categoryid, $permission, $tags);
+		if ($asObject) {
+			return $forums;
+		}
+
+		$forums_array = [];
+		$array_cat    = [];
+		$array_forum  = [];
+		if (!is_array($forums)) {
+			return [];
+		}
+		foreach (array_keys($forums) as $forumid) {
+			$forum                                                  = $forums[$forumid];
+			$forums_array[$forum->getVar('parent_forum')][$forumid] = [
+				'cid'   => $forum->getVar('cat_id'),
+				'title' => $forum->getVar('forum_name')
+			];
+		}
+		if (!isset($forums_array[0])) {
+			$ret = [];
+
+			return $ret;
+		}
+		foreach ($forums_array[0] as $key => $forum) {
+			if (isset($forums_array[$key])) {
+				$forum['sub'] = $forums_array[$key];
+			}
+			$array_forum[$forum['cid']][$key] = $forum;
+		}
+		ksort($array_forum);
+		unset($forums, $forums_array);
+
+		return $array_forum;
+	}
+
+	/**
+	 * @param        $forum
+	 * @param  null  $criteria
+	 * @return array
+	 */
+	public function getAllTopics(&$forum, $criteria = null)
+	{
+		global $myts, $viewAllForums;
+		$startdate = '';
+
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.render.php');
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.session.php');
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.time.php');
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.read.php');
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.topic.php');
+
+		$criteria_vars = ['startdate', 'start', 'sort', 'order', 'type', 'status', 'excerpt'];
+		foreach ($criteria_vars as $var) {
+			${$var} = $criteria[$var];
+		}
+
+		$topic_lastread = newbbGetCookie('LT', true);
+		$criteria_forum = '';
+		if (is_object($forum)) {
+			$criteria_forum = ' AND t.forum_id = ' . $forum->getVar('forum_id');
+			$hot_threshold  = $forum->getVar('hot_threshold');
+		} else {
+			$hot_threshold = 10;
+			if (is_array($forum) && count($forum) > 0) {
+				$criteria_forum = ' AND t.forum_id IN (' . implode(',', array_keys($forum)) . ')';
+			} elseif (!empty($forum)) {
+				$criteria_forum = ' AND t.forum_id =' . (int)$forum;
+			}
+		}
+
+		$criteria_post    = $startdate ? ' p.post_time > ' . $startdate : ' 1 = 1 ';
+		$criteria_topic   = empty($type) ? '' : " AND t.type_id={$type}";
+		$criteria_extra   = '';
+		$criteria_approve = ' AND t.approved = 1';
+		$post_on          = ' p.post_id = t.topic_last_post_id';
+		$leftjoin         = ' LEFT JOIN ' . $this->db->prefix('newbb_posts') . ' p ON p.post_id = t.topic_last_post_id';
+		$sort_array       = [];
+		switch ($status) {
+			case 'digest':
+				$criteria_extra = ' AND t.topic_digest = 1';
+				break;
+
+			case 'unreplied':
+				$criteria_extra = ' AND t.topic_replies < 1';
+				break;
+
+			case 'unread':
+				if (empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
+				} elseif (2 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
+					// START irmtfan use read_uid to find the unread posts when the user is logged in
+					$read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
+					if (!empty($read_uid)) {
+						$leftjoin      .= ' LEFT JOIN ' . $this->db->prefix('newbb_reads_topic') . ' r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
+						$criteria_post .= ' AND (r.read_id IS NULL OR r.post_id < t.topic_last_post_id)';
+					} else {
+					}
+					// END irmtfan use read_uid to find the unread posts when the user is logged in
+				} elseif (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
+					// START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
+					if ($time_criterion = max($GLOBALS['last_visit'], $startdate)) {
+						$criteria_post  = ' p.post_time > ' . $time_criterion; // for all users
+						$topics         = [];
+						$topic_lastread = newbbGetCookie('LT', true);
+						if (count($topic_lastread) > 0) {
+							foreach ($topic_lastread as $id => $time) {
+								if ($time > $time_criterion) {
+									$topics[] = $id;
+								}
+							}
+						}
+						if (count($topics) > 0) {
+							$criteria_extra = ' AND t.topic_id NOT IN (' . implode(',', $topics) . ')';
+						}
+					}
+					// END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
+				}
+				break;
+			case 'pending':
+				$post_on          = ' p.topic_id = t.topic_id';
+				$criteria_post    .= ' AND p.pid = 0';
+				$criteria_approve = ' AND t.approved = 0';
+				break;
+
+			case 'deleted':
+				$criteria_approve = ' AND t.approved = -1';
+				break;
+
+			case 'all': // For viewall.php; do not display sticky topics at first
+			case 'active': // same as "all"
+				break;
+
+			default:
+				if ($startdate > 0) {
+					$criteria_post = ' (p.post_time > ' . $startdate . ' OR t.topic_sticky=1)';
+				}
+				$sort_array[] = 't.topic_sticky DESC';
+				break;
+		}
+
+		$select = 't.*, ' . ' p.post_time as last_post_time, p.poster_name as last_poster_name, p.icon, p.post_id, p.uid';
+		$from   = $this->db->prefix('newbb_topics') . ' t ' . $leftjoin;
+		$where  = $criteria_post . $criteria_topic . $criteria_forum . $criteria_extra . $criteria_approve;
+
+		if ($excerpt) {
+			$select .= ', p.post_karma, p.require_reply, pt.post_text';
+			$from   .= ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' pt ON pt.post_id = t.topic_last_post_id';
+		}
+		if ('u.uname' === $sort) {
+			$sort = 't.topic_poster';
+		}
+
+		$sort_array[] = trim($sort . ' ' . $order);
+		$sortby       = implode(', ', array_filter($sort_array));
+		if (empty($sortby)) {
+			$sortby = 't.topic_last_post_id DESC';
+		}
+
+		$sql = 'SELECT ' . $select . ' FROM ' . $from . ' WHERE ' . $where . ' ORDER BY ' . $sortby;
+
+		if (!$result = $this->db->query($sql, $GLOBALS['xoopsModuleConfig']['topics_per_page'], $start)) {
+			redirect_header('index.php', 2, _MD_NEWBB_ERROROCCURED);
+		}
+
+		$sticky  = 0;
+		$topics  = [];
+		$posters = [];
+		$reads   = [];
+		$types   = [];
+
+		/** @var Newbb\TypeHandler $typeHandler */
+		$typeHandler = Newbb\Helper::getInstance()->getHandler('Type');
+		$typen       = $typeHandler->getByForum($forum->getVar('forum_id'));
+		while (false !== ($myrow = $this->db->fetchArray($result))) {
+			if ($myrow['topic_sticky']) {
+				++$sticky;
+			}
+
+			// ------------------------------------------------------
+			// topic_icon: priority: sticky -> digest -> regular
+
+			if ($myrow['topic_haspoll']) {
+				if ($myrow['topic_sticky']) {
+					$topic_icon = newbbDisplayImage('topic_sticky', _MD_NEWBB_TOPICSTICKY) . '<br>' . newbbDisplayImage('poll', _MD_NEWBB_TOPICHASPOLL);
+				} else {
+					$topic_icon = newbbDisplayImage('poll', _MD_NEWBB_TOPICHASPOLL);
+				}
+			} elseif ($myrow['topic_sticky']) {
+				$topic_icon = newbbDisplayImage('topic_sticky', _MD_NEWBB_TOPICSTICKY);
+			} elseif (!empty($myrow['icon'])) {
+				$topic_icon = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($myrow['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
+			} else {
+				$topic_icon = '<img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" />';
+			}
+
+			// ------------------------------------------------------
+			// rating_img
+			$rating = number_format($myrow['rating'] / 2, 0);
+			// irmtfan - add alt key for rating
+			if ($rating < 1) {
+				$rating_img = newbbDisplayImage('blank');
+			} else {
+				$rating_img = newbbDisplayImage('rate' . $rating, constant('_MD_NEWBB_RATE' . $rating));
+			}
+			// ------------------------------------------------------
+			// topic_page_jump
+			$topic_page_jump      = '';
+			$topic_page_jump_icon = '';
+			$totalpages           = ceil(($myrow['topic_replies'] + 1) / $GLOBALS['xoopsModuleConfig']['posts_per_page']);
+			if ($totalpages > 1) {
+				$topic_page_jump .= '&nbsp;&nbsp;';
+				$append          = false;
+				for ($i = 1; $i <= $totalpages; ++$i) {
+					if ($i > 3 && $i < $totalpages) {
+						if (!$append) {
+							$topic_page_jump .= '...';
+							$append          = true;
+						}
+					} else {
+						$topic_page_jump .= '[<a href="' . XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'] . '&amp;start=' . (($i - 1) * $GLOBALS['xoopsModuleConfig']['posts_per_page']) . '">' . $i . '</a>]';
+						// irmtfan remove here and move
+						//$topic_page_jump_icon = "<a href='" . XOOPS_URL . "/modules/newbb/viewtopic.php?post_id=" . $myrow['post_id'] . "&amp;start=" . (($i - 1) * $GLOBALS['xoopsModuleConfig']['posts_per_page']) . "'>" . newbbDisplayImage('lastposticon',_MD_NEWBB_GOTOLASTPOST) . '</a>';
+					}
+				}
+			}
+			// irmtfan - move here for both topics with and without pages
+			$topic_page_jump_icon = "<a href='" . XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $myrow['post_id'] . "'>" . newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST) . '</a>';
+
+			// ------------------------------------------------------
+			// => topic array
+			$forum_link = '';
+			if (!empty($viewAllForums[$myrow['forum_id']])) {
+				$forum_link = '<a href="' . XOOPS_URL . '/modules/newbb/viewforum.php?forum=' . $myrow['forum_id'] . '">' . $viewAllForums[$myrow['forum_id']]['forum_name'] . '</a>';
+			}
+
+			$topic_title = $myts->htmlSpecialChars($myrow['topic_title']);
+			// irmtfan remove here and move to for loop
+			//if ($myrow['type_id'] > 0) {
+			//$topic_title = '<span style="color:'.$typen[$myrow["type_id"]]["type_color"].'">['.$typen[$myrow["type_id"]]["type_name"].']</span> '.$topic_title.'';
+			//}
+			if ($myrow['topic_digest']) {
+				$topic_title = "<span class='digest'>" . $topic_title . '</span>';
+			}
+
+			if (0 == $excerpt) {
+				$topic_excerpt = '';
+			} elseif (($myrow['post_karma'] > 0 || $myrow['require_reply'] > 0) && !newbbIsAdmin($forum)) {
+				$topic_excerpt = '';
+			} else {
+				$topic_excerpt = xoops_substr(newbbHtml2text($myts->displayTarea($myrow['post_text'])), 0, $excerpt);
+				$topic_excerpt = str_replace('[', '&#91;', $myts->htmlSpecialChars($topic_excerpt));
+			}
+			// START irmtfan move here
+			$topics[$myrow['topic_id']] = [
+				'topic_id'             => $myrow['topic_id'],
+				'topic_icon'           => $topic_icon,
+				'type_id'              => $myrow['type_id'],
+				//'type_text'                 => $topic_prefix,/*irmtfan remove here and move to for loop*/
+				'topic_title'          => $topic_title,
+				//'topic_link'                => XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'],
+				'topic_link'           => 'viewtopic.php?topic_id=' . $myrow['topic_id'],
+				'rating_img'           => $rating_img,
+				'topic_page_jump'      => $topic_page_jump,
+				'topic_page_jump_icon' => $topic_page_jump_icon,
+				'topic_replies'        => $myrow['topic_replies'],
+
+				'topic_digest' => $myrow['topic_digest'],
+				//mb
+
+				'topic_poster_uid'       => $myrow['topic_poster'],
+				'topic_poster_name'      => $myts->htmlSpecialChars($myrow['poster_name'] ?: $GLOBALS['xoopsConfig']['anonymous']),
+				'topic_views'            => $myrow['topic_views'],
+				'topic_time'             => newbbFormatTimestamp($myrow['topic_time']),
+				'topic_last_posttime'    => newbbFormatTimestamp($myrow['last_post_time']),
+				'topic_last_poster_uid'  => $myrow['uid'],
+				'topic_last_poster_name' => $myts->htmlSpecialChars($myrow['last_poster_name'] ?: $GLOBALS['xoopsConfig']['anonymous']),
+				'topic_forum_link'       => $forum_link,
+				'topic_excerpt'          => $topic_excerpt,
+				'stick'                  => empty($myrow['topic_sticky']),
+				'stats'                  => [
+					$myrow['topic_status'],
+					$myrow['topic_digest'],
+					$myrow['topic_replies']
+				],
+				/* irmtfan uncomment use ib the for loop*/
+				//"topic_poster"              => $topic_poster,/*irmtfan remove here and move to for loop*/
+				//"topic_last_poster"         => $topic_last_poster,/*irmtfan remove here and move to for loop*/
+				//"topic_folder"              => newbbDisplayImage($topic_folder,$topic_folder_text),/*irmtfan remove here and move to for loop*/
+			];
+			// END irmtfan move here
+			/* users */
+			$posters[$myrow['topic_poster']] = 1;
+			$posters[$myrow['uid']]          = 1;
+			// reads
+			if (!empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
+				$reads[$myrow['topic_id']] = (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) ? $myrow['last_post_time'] : $myrow['topic_last_post_id'];
+			}
+		}// irmtfan while end
+		// START irmtfan move to a for loop
+		$posters_name = newbbGetUnameFromIds(array_keys($posters), $GLOBALS['xoopsModuleConfig']['show_realname'], true);
+		//$topic_poster = newbbGetUnameFromId($myrow['topic_poster'], $GLOBALS['xoopsModuleConfig']['show_realname'], true);
+		//$topic_last_poster = newbbGetUnameFromId($myrow['uid'], $GLOBALS['xoopsModuleConfig']['show_realname'], true);
+		$topic_isRead = newbbIsRead('topic', $reads);
+		foreach (array_keys($topics) as $id) {
+			$topics[$id]['topic_read'] = empty($topic_isRead[$id]) ? 0 : 1; // add topic-read/topic-new smarty variable
+			if (!empty($topics[$id]['type_id']) && isset($typen[$topics[$id]['type_id']])) {
+				$topics[$id]['topic_title'] = getTopicTitle($topics[$id]['topic_title'], $typen[$topics[$id]['type_id']]['type_name'], $typen[$topics[$id]['type_id']]['type_color']);
+			}
+			//$topic_prefix =  (!empty($typen[$myrow['type_id']])) ? getTopicTitle("", $typen[$myrow['type_id']]["type_name"], $typen[$myrow['type_id']]["type_color"]) : "";
+			$topics[$id]['topic_poster']      = !empty($posters_name[$topics[$id]['topic_poster_uid']]) ? $posters_name[$topics[$id]['topic_poster_uid']] : $topics[$id]['topic_poster_name'];
+			$topics[$id]['topic_last_poster'] = !empty($posters_name[$topics[$id]['topic_last_poster_uid']]) ? $posters_name[$topics[$id]['topic_last_poster_uid']] : $topics[$id]['topic_last_poster_name'];
+
+			// ------------------------------------------------------
+			// topic_folder: priority: newhot -> hot/new -> regular
+			list($topic_status, $topic_digest, $topic_replies) = $topics[$id]['stats'];
+			if (1 == $topic_status) {
+				$topic_folder      = 'topic_locked';
+				$topic_folder_text = _MD_NEWBB_TOPICLOCKED;
+			} else {
+				if ($topic_digest) {
+					$topic_folder      = 'topic_digest';
+					$topic_folder_text = _MD_NEWBB_TOPICDIGEST;
+				} elseif ($topic_replies >= $hot_threshold) {
+					$topic_folder      = empty($topic_isRead[$id]) ? 'topic_hot_new' : 'topic_hot';
+					$topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_MORETHAN : _MD_NEWBB_MORETHAN2;
+				} else {
+					$topic_folder      = empty($topic_isRead[$id]) ? 'topic_new' : 'topic';
+					$topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_NEWPOSTS : _MD_NEWBB_NONEWPOSTS;
+				}
+			}
+			$topics[$id]['topic_folder'] = newbbDisplayImage($topic_folder, $topic_folder_text);
+			unset($topics[$id]['topic_poster_name'], $topics[$id]['topic_last_poster_name'], $topics[$id]['stats']);
+		} // irmtfan end for loop
+		// END irmtfan move to a for loop
+		if (count($topics) > 0) {
+			$sql = ' SELECT DISTINCT topic_id FROM ' . $this->db->prefix('newbb_posts') . " WHERE attachment != ''" . ' AND topic_id IN (' . implode(',', array_keys($topics)) . ')';
+			if ($result = $this->db->query($sql)) {
+				while (false !== (list($topic_id) = $this->db->fetchRow($result))) {
+					$topics[$topic_id]['attachment'] = '&nbsp;' . newbbDisplayImage('attachment', _MD_NEWBB_TOPICSHASATT);
+				}
+			}
+		}
+
+		return [$topics, $sticky];
+	}
+
+	/**
+	 * @param $forum
+	 * @param $startdate
+	 * @param $type
+	 * @return null|int
+	 */
+	public function getTopicCount(&$forum, $startdate, $type)
+	{
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.session.php');
+
+		$criteria_extra   = '';
+		$criteria_approve = ' AND t.approved = 1'; // any others?
+		$leftjoin         = ' LEFT JOIN ' . $this->db->prefix('newbb_posts') . ' p ON p.post_id = t.topic_last_post_id';
+		$criteria_post    = ' p.post_time > ' . $startdate;
+		switch ($type) {
+			case 'digest':
+				$criteria_extra = ' AND topic_digest = 1';
+				break;
+			case 'unreplied':
+				$criteria_extra = ' AND topic_replies < 1';
+				break;
+			case 'unread':
+				if (empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
+				} elseif (2 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
+					// START irmtfan use read_uid to find the unread posts when the user is logged in
+
+					$read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
+					if (!empty($read_uid)) {
+						$leftjoin      .= ' LEFT JOIN ' . $this->db->prefix('newbb_reads_topic') . ' r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
+						$criteria_post .= ' AND (r.read_id IS NULL OR r.post_id < t.topic_last_post_id)';
+					} else {
+					}
+					// END irmtfan use read_uid to find the unread posts when the user is logged in
+				} elseif (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) {
+					// START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
+					if ($time_criterion = max($GLOBALS['last_visit'], $startdate)) {
+						$criteria_post  = ' p.post_time > ' . $time_criterion; // for all users
+						$topics         = [];
+						$topic_lastread = newbbGetCookie('LT', true);
+						if (count($topic_lastread) > 0) {
+							foreach ($topic_lastread as $id => $time) {
+								if ($time > $time_criterion) {
+									$topics[] = $id;
+								}
+							}
+						}
+						if (count($topics) > 0) {
+							$criteria_extra = ' AND t.topic_id NOT IN (' . implode(',', $topics) . ')';
+						}
+					}
+					// END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
+				}
+				break;
+			case 'pending':
+				$criteria_approve = ' AND t.approved = 0';
+				break;
+			case 'deleted':
+				$criteria_approve = ' AND t.approved = -1';
+				break;
+			case 'all':
+				break;
+			default:
+				$criteria_post = ' (p.post_time > ' . $startdate . ' OR t.topic_sticky=1)';
+				break;
+		}
+		$criteria_forum = '';
+		if (is_object($forum)) {
+			$criteria_forum = ' AND t.forum_id = ' . $forum->getVar('forum_id');
+		} else {
+			if (is_array($forum) && count($forum) > 0) {
+				$criteria_forum = ' AND t.forum_id IN (' . implode(',', array_keys($forum)) . ')';
+			} elseif (!empty($forum)) {
+				$criteria_forum = ' AND t.forum_id =' . (int)$forum;
+			}
+		}
+
+		$sql = 'SELECT COUNT(*) AS count FROM ' . $this->db->prefix('newbb_topics') . ' t ' . $leftjoin;
+		$sql .= ' WHERE ' . $criteria_post . $criteria_forum . $criteria_extra . $criteria_approve;
+		if (!$result = $this->db->query($sql)) {
+			//xoops_error($this->db->error().'<br>'.$sql);
+			return null;
+		}
+		$myrow = $this->db->fetchArray($result);
+		$count = $myrow['count'];
+
+		return $count;
+	}
+
+	// get permission
+
+	/**
+	 * @param         $forum
+	 * @param  string $type
+	 * @param  bool   $checkCategory
+	 * @return bool
+	 */
+	public function getPermission($forum, $type = 'access', $checkCategory = true)
+	{
+		global $xoopsModule;
+		static $_cachedPerms;
+
+		if ('all' === $type) {
+			return true;
+		}
+
+		require_once  dirname(__DIR__) . '/include/functions.user.php';
+		if (newbbIsAdmin($forum)) {
+			return true;
+		}
+		//if ($GLOBALS["xoopsUserIsAdmin"] && $xoopsModule->getVar("dirname") === "newbb") {
+		//return true;
+		//}
+
+		if (!is_object($forum)) {
+			$forum = $this->get($forum);
+		}
+
+		if (!empty($checkCategory)) {
+			/** @var Newbb\CategoryHandler $categoryHandler */
+			$categoryHandler = Newbb\Helper::getInstance()->getHandler('Category');
+			$categoryPerm    = $categoryHandler->getPermission($forum->getVar('cat_id'));
+			if (!$categoryPerm) {
+				return false;
+			}
+		}
+
+		$type = strtolower($type);
+		// START irmtfan commented and removed
+		//if ('moderate' === $type) {
+		//require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.user.php');
+		//$permission = newbbIsModerator($forum);
+		//} else {
+		$forum_id = $forum->getVar('forum_id');
+		/** var Newbb\PermissionHandler $permHandler */
+		$permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
+		$permission  = $permHandler->getPermission('forum', $type, $forum_id);
+		//}
+		// END irmtfan commented and removed
+		return $permission;
+	}
+
+	/**
+	 * @param $forum
+	 * @return mixed
+	 */
+	public function deletePermission(&$forum)
+	{
+		/** var Newbb\PermissionHandler $permHandler */
+		$permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
+
+		return $permHandler->deleteByForum($forum->getVar('forum_id'));
+	}
+
+	/**
+	 * @param $forum
+	 * @return mixed
+	 */
+	public function applyPermissionTemplate(&$forum)
+	{
+		/** var Newbb\PermissionHandler $permHandler */
+		$permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
+
+		return $permHandler->applyTemplate($forum->getVar('forum_id'));
+	}
+
+	/*
     function isForum($forum)
     {
         $count = false;
@@ -647,422 +647,422 @@ 
     }
     */
 
-    /**
-     * clean orphan forums from database
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @param  array  $forum_ids forum IDs
-     * @return bool   true on success
-     */
-    // START irmtfan rewrite forum cleanOrphan function. add parent_forum and cat_id orphan check
-    //    public function cleanOrphan(array $forum_ids = array())
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '', $forum_ids = [])
-    {
-        // check parent_forum orphan forums
-        if (empty($forum_ids)) {
-            $forum_ids = $this->getIds();
-        }
-        if (empty($forum_ids)) {
-            return false;
-        }
-        /*
+	/**
+	 * clean orphan forums from database
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @param  array  $forum_ids forum IDs
+	 * @return bool   true on success
+	 */
+	// START irmtfan rewrite forum cleanOrphan function. add parent_forum and cat_id orphan check
+	//    public function cleanOrphan(array $forum_ids = array())
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '', $forum_ids = [])
+	{
+		// check parent_forum orphan forums
+		if (empty($forum_ids)) {
+			$forum_ids = $this->getIds();
+		}
+		if (empty($forum_ids)) {
+			return false;
+		}
+		/*
             $sql =    "    UPDATE ".$GLOBALS['xoopsDB']->prefix("newbb_forums").
                     "    SET parent_forum = 0".
                     "    WHERE (parent_forum NOT IN ( ".$forum_ids."))".
                     "        OR parent_forum = forum_id";
         */
-        $criteria = new \CriteriaCompo();
-        $criteria->add(new \Criteria('parent_forum', '(' . implode(', ', $forum_ids) . ')', 'NOT IN'), 'AND');
-        $criteria->add(new \Criteria('parent_forum', '`forum_id`', '='), 'OR');
-        $b1 = $this->updateAll('parent_forum', 0, $criteria, true);
-        // check cat_id orphan forums
-        $categoryHandler = Newbb\Helper::getInstance()->getHandler('Category');
-        $cat_ids         = $categoryHandler->getIds();
-        if (empty($cat_ids)) {
-            return false;
-        }
-        $criteria = new \CriteriaCompo();
-        $criteria->add(new \Criteria('cat_id', '(' . implode(', ', $cat_ids) . ')', 'NOT IN'), 'AND');
-        $b2 = $this->updateAll('cat_id', $cat_ids[0], $criteria, true);
-
-        return ($b1 && $b2);
-    }
-    // END irmtfan rewrite forum cleanOrphan function. add parent_forum and cat_id orphan check
-
-    /**
-     * forum data synchronization
-     *
-     * @param  mixed $object null for all forums; integer for forum_id; object for forum object
-     * @return bool
-     * @internal param int $mode 1 for stats only; 2 for forum index data only; 0 for both
-     *
-     */
-    public function synchronization($object = null)
-    {
-        if (empty($object)) {
-            $forums = $this->getIds();
-            $this->cleanOrphan('', '', '', $forums); // irmtfan - move cleanOrphan to synchronization function
-            foreach ($forums as $id) {
-                $this->synchronization($id);
-            }
-
-            return true;
-        }
-
-        if (!is_object($object)) {
-            $object = $this->get((int)$object);
-        }
-
-        if (!$object->getVar('forum_id')) {
-            return false;
-        }
-        $sql = 'SELECT MAX(post_id) AS last_post, COUNT(*) AS total FROM ' . $this->db->prefix('newbb_posts') . ' AS p LEFT JOIN  ' . $this->db->prefix('newbb_topics') . ' AS t ON p.topic_id=t.topic_id WHERE p.approved=1 AND t.approved=1 AND p.forum_id = ' . $object->getVar('forum_id');
-
-        if ($result = $this->db->query($sql)) {
-            $last_post = 0;
-            $posts     = 0;
-            if ($row = $this->db->fetchArray($result)) {
-                $last_post = (int)$row['last_post'];
-                $posts     = (int)$row['total'];
-            }
-            if ($object->getVar('forum_last_post_id') !== $last_post) {
-                $object->setVar('forum_last_post_id', $last_post);
-            }
-            if ($object->getVar('forum_posts') !== $posts) {
-                $object->setVar('forum_posts', $posts);
-            }
-        }
-
-        $sql = 'SELECT COUNT(*) AS total FROM ' . $this->db->prefix('newbb_topics') . ' WHERE approved=1 AND forum_id = ' . $object->getVar('forum_id');
-        if ($result = $this->db->query($sql)) {
-            if ($row = $this->db->fetchArray($result)) {
-                if ($object->getVar('forum_topics') !== $row['total']) {
-                    $object->setVar('forum_topics', $row['total']);
-                }
-            }
-        }
-        $object->setDirty();
-
-        return $this->insert($object, true);
-    }
-
-    /**
-     * @param  null $passedSubForums
-     * @return array
-     */
-    public function getSubforumStats($passedSubForums = null)
-    {
-        $stats = [];
-
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.forum.php');
-
-        $subForumTree = newbbGetSubForum();
-        if (empty($passedSubForums)) {
-            $sub_forums = $subForumTree;
-        } else {
-            foreach ($passedSubForums as $id) {
-                $sub_forums[$id] = isset($subForumTree[$id]) ? $subForumTree[$id] : null;
-            }
-        }
-
-        $forums_id = [];
-        foreach (array_keys($sub_forums) as $id) {
-            if (empty($sub_forums[$id])) {
-                continue;
-            }
-            $forums_id = array_merge($forums_id, $sub_forums[$id]);
-        }
-        if (!$forums_id) {
-            return $stats;
-        }
-        $sql = '    SELECT forum_posts AS posts, forum_topics AS topics, forum_id AS id' . '    FROM ' . $this->table . '    WHERE forum_id IN (' . implode(', ', $forums_id) . ')';
-        if (!$result = $this->db->query($sql)) {
-            return $stats;
-        }
-
-        $forum_stats = [];
-        while (false !== ($row = $this->db->fetchArray($result))) {
-            $forum_stats[$row['id']] = ['topics' => $row['topics'], 'posts' => $row['posts']];
-        }
-
-        foreach (array_keys($sub_forums) as $id) {
-            if (empty($sub_forums[$id])) {
-                continue;
-            }
-            $stats[$id] = ['topics' => 0, 'posts' => 0];
-            foreach ($sub_forums[$id] as $fid) {
-                $stats[$id]['topics'] += $forum_stats[$fid]['topics'];
-                $stats[$id]['posts']  += $forum_stats[$fid]['posts'];
-            }
-        }
-
-        return $stats;
-    }
-
-    /**
-     * @param        $forums
-     * @param  int   $length_title_index
-     * @param  int   $count_subforum
-     * @return array
-     */
-    public function &display($forums, $length_title_index = 30, $count_subforum = 1)
-    {
-        global $myts;
-
-        $posts       = [];
-        $postsObject = [];
-        foreach (array_keys($forums) as $id) {
-            $posts[] = $forums[$id]['forum_last_post_id'];
-        }
-        if (!empty($posts)) {
-            $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-            $tags_post   = ['uid', 'topic_id', 'post_time', 'poster_name', 'icon'];
-            if (!empty($length_title_index)) {
-                $tags_post[] = 'subject';
-            }
-            $posts = $postHandler->getAll(new \Criteria('post_id', '(' . implode(', ', $posts) . ')', 'IN'), $tags_post, false);
-        }
-
-        // Get topic/post stats per forum
-        $stats_forum = [];
-
-        if (!empty($count_subforum)) {
-            $stats_forum = $this->getSubforumStats(array_keys($forums)); // irmtfan uncomment to count sub forum posts/topics
-        }
-
-        $users  = [];
-        $reads  = [];
-        $topics = [];
-
-        foreach (array_keys($forums) as $id) {
-            $forum =& $forums[$id];
-
-            if (!$forum['forum_last_post_id']) {
-                continue;
-            }
-            if (!$post = @$posts[$forum['forum_last_post_id']]) {
-                $forum['forum_last_post_id'] = 0;
-                continue;
-            }
-
-            $users[] = $post['uid'];
-            if ($moderators[$id] = $forum['forum_moderator']) {
-                $users = array_merge($users, $moderators[$id]);
-            }
-
-            // reads
-            if (!empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
-                $reads[$id] = (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) ? $post['post_time'] : $post['post_id'];
-            }
-        }
-
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.user.php');
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.time.php');
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.render.php');
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.read.php');
-        $forum_isread = newbbIsRead('forum', $reads);
-        $users_linked = newbbGetUnameFromIds(array_unique($users), !empty($GLOBALS['xoopsModuleConfig']['show_realname']), true);
-
-        $forums_array   = [];
-        $name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
-
-        foreach (array_keys($forums) as $id) {
-            $forum =& $forums[$id];
-
-            $_forum_data                 = [];
-            $_forum_data['forum_order']  = $forum['forum_order'];
-            $_forum_data['forum_id']     = $id;
-            $_forum_data['forum_cid']    = $forum['cat_id'];
-            $_forum_data['forum_name']   = $forum['forum_name'];
-            $forumDescLength             = $GLOBALS['xoopsModuleConfig']['forum_desc_length'];
-            $_forum_data['forum_desc']   = mb_strimwidth($forum['forum_desc'], 0, $forumDescLength, '...');
-            $_forum_data['forum_topics'] = $forum['forum_topics'] + @$stats_forum[$id]['topics'];
-            $_forum_data['forum_posts']  = $forum['forum_posts'] + @$stats_forum[$id]['posts'];
-            //$_forum_data["forum_type"]= $forum['forum_type'];
-
-            $forum_moderators = [];
-            if (!empty($moderators[$id])) {
-                foreach (@$moderators[$id] as $moderator) {
-                    $forum_moderators[] = @$users_linked[$moderator];
-                }
-            }
-            $_forum_data['forum_moderators'] = implode(', ', $forum_moderators);
-
-            // irmtfan change if/endif to if{} method
-            if ($post_id = $forum['forum_last_post_id']) {
-                $post                               =& $posts[$post_id];
-                $_forum_data['forum_lastpost_id']   = $post_id;
-                $_forum_data['forum_lastpost_time'] = newbbFormatTimestamp($post['post_time']);
-                if (!empty($users_linked[$post['uid']])) {
-                    $_forum_data['forum_lastpost_user'] = $users_linked[$post['uid']];
-                } elseif ($poster_name = $post['poster_name']) {
-                    $_forum_data['forum_lastpost_user'] = $poster_name;
-                } else {
-                    $_forum_data['forum_lastpost_user'] = $name_anonymous;
-                }
-                if (!empty($length_title_index)) {
-                    $subject = $post['subject'];
-                    if ($length_title_index < 255) {
-                        $subject = xoops_substr($subject, 0, $length_title_index);
-                    }
-                    $_forum_data['forum_lastpost_subject'] = $subject;
-                }
-                // irmtfan - remove icon_path and use newbbDisplayImage
-                $_forum_data['forum_lastpost_icon'] = newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST);
-                // START irmtfan change the method to add read smarty
-                if (empty($forum_isread[$id])) {
-                    $_forum_data['forum_folder'] = newbbDisplayImage('forum_new', _MD_NEWBB_NEWPOSTS);
-                    $_forum_data['forum_read']   = 0; // irmtfan add forum-read/forum-new smarty variable
-                } else {
-                    $_forum_data['forum_folder'] = newbbDisplayImage('forum', _MD_NEWBB_NONEWPOSTS);
-                    $_forum_data['forum_read']   = 1; // irmtfan add forum-read/forum-new smarty variable
-                }
-                // END irmtfan change the method to add read smarty
-            }
-            $forums_array[$forum['parent_forum']][] = $_forum_data;
-        }
-
-        return $forums_array;
-    }
-
-    /**
-     * get a hierarchical tree of forums
-     *
-     * {@link newbbTree}
-     *
-     * @param  int    $cat_id     category ID
-     * @param  int    $pid        Top forum ID
-     * @param  string $permission permission type
-     * @param  string $prefix     prefix for display
-     * @param  string|array|null $tags       variables to fetch
-     * @return array  associative array of category IDs and sanitized titles
-     */
-    public function &getTree($cat_id = 0, $pid = 0, $permission = 'access', $prefix = '--', $tags = null)
-    {
-        $pid         = (int)$pid;
-        $perm_string = $permission;
-        if (!is_array($tags) || 0 === count($tags)) {
-            $tags = ['forum_id', 'parent_forum', 'forum_name', 'forum_order', 'cat_id'];
-        }
-        $forumsObject = $this->getByPermission($cat_id, $perm_string, $tags);
-
-        require_once __DIR__ . '/Tree.php';
-        $forums_structured = [];
-        foreach (array_keys($forumsObject) as $key) {
-            $forums_structured[$forumsObject[$key]->getVar('cat_id')][$key] = $forumsObject[$key];
-        }
-
-        foreach (array_keys($forums_structured) as $cid) {
-            $tree              = new ObjectTree($forums_structured[$cid]);
-            $forum_array[$cid] = $tree->makeTree($prefix, $pid, $tags);
-            unset($tree);
-        }
-
-        return $forum_array;
-    }
-
-    /**
-     * get a hierarchical array tree of forums
-     *
-     * {@link newbbTree}
-     *
-     * @param  int     $cat_id     category ID
-     * @param  int     $pid        Top forum ID
-     * @param  string  $permission permission type
-     * @param  string|array|null  $tags       variables to fetch
-     * @param  integer $depth      level of subcategories
-     * @return array   associative array of category IDs and sanitized titles
-     */
-    public function &getArrayTree($cat_id = 0, $pid = 0, $permission = 'access', $tags = null, $depth = 0)
-    {
-        $pid         = (int)$pid;
-        $perm_string = $permission;
-        if (!is_array($tags) || 0 === count($tags)) {
-            $tags = ['forum_id', 'parent_forum', 'forum_name', 'forum_order', 'cat_id'];
-        }
-        $forumsObject = $this->getByPermission($cat_id, $perm_string, $tags);
-
-        require_once __DIR__ . '/Tree.php';
-        $forums_structured = [];
-        foreach (array_keys($forumsObject) as $key) {
-            $forumObject                                             =& $forumsObject[$key];
-            $forums_structured[$forumObject->getVar('cat_id')][$key] = $forumsObject[$key];
-        }
-        foreach (array_keys($forums_structured) as $cid) {
-            $tree              = new ObjectTree($forums_structured[$cid]);
-            $forum_array[$cid] = $tree->makeArrayTree($pid, $tags, $depth);
-            unset($tree);
-        }
-
-        return $forum_array;
-    }
-
-    /**
-     * @param $object
-     * @return array|null
-     */
-    public function &getParents($object)
-    {
-        $ret = null;
-        if (!$object->getVar('forum_id')) {
-            return $ret;
-        }
-
-        require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.forum.php');
-        if (!$parents = newbbGetParentForum($object->getVar('forum_id'))) {
-            return $ret;
-        }
-        $parents_list = $this->getList(new \Criteria('forum_id', '(' . implode(', ', $parents) . ')', 'IN'));
-        foreach ($parents as $key => $id) {
-            $ret[] = ['forum_id' => $id, 'forum_name' => $parents_list[$id]];
-        }
-        unset($parents, $parents_list);
-
-        return $ret;
-    }
-
-    // START irmtfan - get forum Ids by values. parse positive values to forum IDs and negative values to category IDs. value=0 => all valid forums
-
-    /**
-     * function for get forum Ids by positive and negative values
-     *
-     * @param  int|text|array $values : positive values = forums | negative values = cats | $values=0 = all valid forums, $permission , true/false $parse_cats
-     * @param  string   $permission
-     * @param  bool     $parse_cats
-     * @return array|mixed $validForums
-     */
-    public function getIdsByValues($values = 0, $permission = 'access', $parse_cats = true)
-    {
-        // Get all valid forums with this permission
-        $validForums = $this->getIdsByPermission($permission);
-        // if no value or value=0 return all valid forums
-        if (empty($values)) {
-            return $validForums;
-        }
-        $values = is_numeric($values) ? [$values] : $values;
-        //parse negative values to category IDs
-        $forums = [];
-        $cats   = [];
-        foreach ($values as $val) {
-            if (0 == $val) {
-                // value=0 => all valid forums
-                return $validForums;
-            } elseif ($val > 0) {
-                $forums[] = $val;
-            } else {
-                $cats[] = abs($val);
-            }
-        }
-        // if dont want to parse categories OR no cats return all forums
-        if (empty($parse_cats) || empty($cats)) {
-            return array_intersect($validForums, $forums);
-        }
-        // Get all forums by category IDs
-        $forumObjs = $this->getForumsByCategory($cats, $permission, true);
-        $forums    = array_merge($forums, array_keys($forumObjs));
-
-        return array_intersect($validForums, $forums);
-    }
-    // END irmtfan - get forum Ids by values. parse positive values to forum IDs and negative values to category IDs. value=0 => all valid forums
+		$criteria = new \CriteriaCompo();
+		$criteria->add(new \Criteria('parent_forum', '(' . implode(', ', $forum_ids) . ')', 'NOT IN'), 'AND');
+		$criteria->add(new \Criteria('parent_forum', '`forum_id`', '='), 'OR');
+		$b1 = $this->updateAll('parent_forum', 0, $criteria, true);
+		// check cat_id orphan forums
+		$categoryHandler = Newbb\Helper::getInstance()->getHandler('Category');
+		$cat_ids         = $categoryHandler->getIds();
+		if (empty($cat_ids)) {
+			return false;
+		}
+		$criteria = new \CriteriaCompo();
+		$criteria->add(new \Criteria('cat_id', '(' . implode(', ', $cat_ids) . ')', 'NOT IN'), 'AND');
+		$b2 = $this->updateAll('cat_id', $cat_ids[0], $criteria, true);
+
+		return ($b1 && $b2);
+	}
+	// END irmtfan rewrite forum cleanOrphan function. add parent_forum and cat_id orphan check
+
+	/**
+	 * forum data synchronization
+	 *
+	 * @param  mixed $object null for all forums; integer for forum_id; object for forum object
+	 * @return bool
+	 * @internal param int $mode 1 for stats only; 2 for forum index data only; 0 for both
+	 *
+	 */
+	public function synchronization($object = null)
+	{
+		if (empty($object)) {
+			$forums = $this->getIds();
+			$this->cleanOrphan('', '', '', $forums); // irmtfan - move cleanOrphan to synchronization function
+			foreach ($forums as $id) {
+				$this->synchronization($id);
+			}
+
+			return true;
+		}
+
+		if (!is_object($object)) {
+			$object = $this->get((int)$object);
+		}
+
+		if (!$object->getVar('forum_id')) {
+			return false;
+		}
+		$sql = 'SELECT MAX(post_id) AS last_post, COUNT(*) AS total FROM ' . $this->db->prefix('newbb_posts') . ' AS p LEFT JOIN  ' . $this->db->prefix('newbb_topics') . ' AS t ON p.topic_id=t.topic_id WHERE p.approved=1 AND t.approved=1 AND p.forum_id = ' . $object->getVar('forum_id');
+
+		if ($result = $this->db->query($sql)) {
+			$last_post = 0;
+			$posts     = 0;
+			if ($row = $this->db->fetchArray($result)) {
+				$last_post = (int)$row['last_post'];
+				$posts     = (int)$row['total'];
+			}
+			if ($object->getVar('forum_last_post_id') !== $last_post) {
+				$object->setVar('forum_last_post_id', $last_post);
+			}
+			if ($object->getVar('forum_posts') !== $posts) {
+				$object->setVar('forum_posts', $posts);
+			}
+		}
+
+		$sql = 'SELECT COUNT(*) AS total FROM ' . $this->db->prefix('newbb_topics') . ' WHERE approved=1 AND forum_id = ' . $object->getVar('forum_id');
+		if ($result = $this->db->query($sql)) {
+			if ($row = $this->db->fetchArray($result)) {
+				if ($object->getVar('forum_topics') !== $row['total']) {
+					$object->setVar('forum_topics', $row['total']);
+				}
+			}
+		}
+		$object->setDirty();
+
+		return $this->insert($object, true);
+	}
+
+	/**
+	 * @param  null $passedSubForums
+	 * @return array
+	 */
+	public function getSubforumStats($passedSubForums = null)
+	{
+		$stats = [];
+
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.forum.php');
+
+		$subForumTree = newbbGetSubForum();
+		if (empty($passedSubForums)) {
+			$sub_forums = $subForumTree;
+		} else {
+			foreach ($passedSubForums as $id) {
+				$sub_forums[$id] = isset($subForumTree[$id]) ? $subForumTree[$id] : null;
+			}
+		}
+
+		$forums_id = [];
+		foreach (array_keys($sub_forums) as $id) {
+			if (empty($sub_forums[$id])) {
+				continue;
+			}
+			$forums_id = array_merge($forums_id, $sub_forums[$id]);
+		}
+		if (!$forums_id) {
+			return $stats;
+		}
+		$sql = '    SELECT forum_posts AS posts, forum_topics AS topics, forum_id AS id' . '    FROM ' . $this->table . '    WHERE forum_id IN (' . implode(', ', $forums_id) . ')';
+		if (!$result = $this->db->query($sql)) {
+			return $stats;
+		}
+
+		$forum_stats = [];
+		while (false !== ($row = $this->db->fetchArray($result))) {
+			$forum_stats[$row['id']] = ['topics' => $row['topics'], 'posts' => $row['posts']];
+		}
+
+		foreach (array_keys($sub_forums) as $id) {
+			if (empty($sub_forums[$id])) {
+				continue;
+			}
+			$stats[$id] = ['topics' => 0, 'posts' => 0];
+			foreach ($sub_forums[$id] as $fid) {
+				$stats[$id]['topics'] += $forum_stats[$fid]['topics'];
+				$stats[$id]['posts']  += $forum_stats[$fid]['posts'];
+			}
+		}
+
+		return $stats;
+	}
+
+	/**
+	 * @param        $forums
+	 * @param  int   $length_title_index
+	 * @param  int   $count_subforum
+	 * @return array
+	 */
+	public function &display($forums, $length_title_index = 30, $count_subforum = 1)
+	{
+		global $myts;
+
+		$posts       = [];
+		$postsObject = [];
+		foreach (array_keys($forums) as $id) {
+			$posts[] = $forums[$id]['forum_last_post_id'];
+		}
+		if (!empty($posts)) {
+			$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+			$tags_post   = ['uid', 'topic_id', 'post_time', 'poster_name', 'icon'];
+			if (!empty($length_title_index)) {
+				$tags_post[] = 'subject';
+			}
+			$posts = $postHandler->getAll(new \Criteria('post_id', '(' . implode(', ', $posts) . ')', 'IN'), $tags_post, false);
+		}
+
+		// Get topic/post stats per forum
+		$stats_forum = [];
+
+		if (!empty($count_subforum)) {
+			$stats_forum = $this->getSubforumStats(array_keys($forums)); // irmtfan uncomment to count sub forum posts/topics
+		}
+
+		$users  = [];
+		$reads  = [];
+		$topics = [];
+
+		foreach (array_keys($forums) as $id) {
+			$forum =& $forums[$id];
+
+			if (!$forum['forum_last_post_id']) {
+				continue;
+			}
+			if (!$post = @$posts[$forum['forum_last_post_id']]) {
+				$forum['forum_last_post_id'] = 0;
+				continue;
+			}
+
+			$users[] = $post['uid'];
+			if ($moderators[$id] = $forum['forum_moderator']) {
+				$users = array_merge($users, $moderators[$id]);
+			}
+
+			// reads
+			if (!empty($GLOBALS['xoopsModuleConfig']['read_mode'])) {
+				$reads[$id] = (1 == $GLOBALS['xoopsModuleConfig']['read_mode']) ? $post['post_time'] : $post['post_id'];
+			}
+		}
+
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.user.php');
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.time.php');
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.render.php');
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.read.php');
+		$forum_isread = newbbIsRead('forum', $reads);
+		$users_linked = newbbGetUnameFromIds(array_unique($users), !empty($GLOBALS['xoopsModuleConfig']['show_realname']), true);
+
+		$forums_array   = [];
+		$name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
+
+		foreach (array_keys($forums) as $id) {
+			$forum =& $forums[$id];
+
+			$_forum_data                 = [];
+			$_forum_data['forum_order']  = $forum['forum_order'];
+			$_forum_data['forum_id']     = $id;
+			$_forum_data['forum_cid']    = $forum['cat_id'];
+			$_forum_data['forum_name']   = $forum['forum_name'];
+			$forumDescLength             = $GLOBALS['xoopsModuleConfig']['forum_desc_length'];
+			$_forum_data['forum_desc']   = mb_strimwidth($forum['forum_desc'], 0, $forumDescLength, '...');
+			$_forum_data['forum_topics'] = $forum['forum_topics'] + @$stats_forum[$id]['topics'];
+			$_forum_data['forum_posts']  = $forum['forum_posts'] + @$stats_forum[$id]['posts'];
+			//$_forum_data["forum_type"]= $forum['forum_type'];
+
+			$forum_moderators = [];
+			if (!empty($moderators[$id])) {
+				foreach (@$moderators[$id] as $moderator) {
+					$forum_moderators[] = @$users_linked[$moderator];
+				}
+			}
+			$_forum_data['forum_moderators'] = implode(', ', $forum_moderators);
+
+			// irmtfan change if/endif to if{} method
+			if ($post_id = $forum['forum_last_post_id']) {
+				$post                               =& $posts[$post_id];
+				$_forum_data['forum_lastpost_id']   = $post_id;
+				$_forum_data['forum_lastpost_time'] = newbbFormatTimestamp($post['post_time']);
+				if (!empty($users_linked[$post['uid']])) {
+					$_forum_data['forum_lastpost_user'] = $users_linked[$post['uid']];
+				} elseif ($poster_name = $post['poster_name']) {
+					$_forum_data['forum_lastpost_user'] = $poster_name;
+				} else {
+					$_forum_data['forum_lastpost_user'] = $name_anonymous;
+				}
+				if (!empty($length_title_index)) {
+					$subject = $post['subject'];
+					if ($length_title_index < 255) {
+						$subject = xoops_substr($subject, 0, $length_title_index);
+					}
+					$_forum_data['forum_lastpost_subject'] = $subject;
+				}
+				// irmtfan - remove icon_path and use newbbDisplayImage
+				$_forum_data['forum_lastpost_icon'] = newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST);
+				// START irmtfan change the method to add read smarty
+				if (empty($forum_isread[$id])) {
+					$_forum_data['forum_folder'] = newbbDisplayImage('forum_new', _MD_NEWBB_NEWPOSTS);
+					$_forum_data['forum_read']   = 0; // irmtfan add forum-read/forum-new smarty variable
+				} else {
+					$_forum_data['forum_folder'] = newbbDisplayImage('forum', _MD_NEWBB_NONEWPOSTS);
+					$_forum_data['forum_read']   = 1; // irmtfan add forum-read/forum-new smarty variable
+				}
+				// END irmtfan change the method to add read smarty
+			}
+			$forums_array[$forum['parent_forum']][] = $_forum_data;
+		}
+
+		return $forums_array;
+	}
+
+	/**
+	 * get a hierarchical tree of forums
+	 *
+	 * {@link newbbTree}
+	 *
+	 * @param  int    $cat_id     category ID
+	 * @param  int    $pid        Top forum ID
+	 * @param  string $permission permission type
+	 * @param  string $prefix     prefix for display
+	 * @param  string|array|null $tags       variables to fetch
+	 * @return array  associative array of category IDs and sanitized titles
+	 */
+	public function &getTree($cat_id = 0, $pid = 0, $permission = 'access', $prefix = '--', $tags = null)
+	{
+		$pid         = (int)$pid;
+		$perm_string = $permission;
+		if (!is_array($tags) || 0 === count($tags)) {
+			$tags = ['forum_id', 'parent_forum', 'forum_name', 'forum_order', 'cat_id'];
+		}
+		$forumsObject = $this->getByPermission($cat_id, $perm_string, $tags);
+
+		require_once __DIR__ . '/Tree.php';
+		$forums_structured = [];
+		foreach (array_keys($forumsObject) as $key) {
+			$forums_structured[$forumsObject[$key]->getVar('cat_id')][$key] = $forumsObject[$key];
+		}
+
+		foreach (array_keys($forums_structured) as $cid) {
+			$tree              = new ObjectTree($forums_structured[$cid]);
+			$forum_array[$cid] = $tree->makeTree($prefix, $pid, $tags);
+			unset($tree);
+		}
+
+		return $forum_array;
+	}
+
+	/**
+	 * get a hierarchical array tree of forums
+	 *
+	 * {@link newbbTree}
+	 *
+	 * @param  int     $cat_id     category ID
+	 * @param  int     $pid        Top forum ID
+	 * @param  string  $permission permission type
+	 * @param  string|array|null  $tags       variables to fetch
+	 * @param  integer $depth      level of subcategories
+	 * @return array   associative array of category IDs and sanitized titles
+	 */
+	public function &getArrayTree($cat_id = 0, $pid = 0, $permission = 'access', $tags = null, $depth = 0)
+	{
+		$pid         = (int)$pid;
+		$perm_string = $permission;
+		if (!is_array($tags) || 0 === count($tags)) {
+			$tags = ['forum_id', 'parent_forum', 'forum_name', 'forum_order', 'cat_id'];
+		}
+		$forumsObject = $this->getByPermission($cat_id, $perm_string, $tags);
+
+		require_once __DIR__ . '/Tree.php';
+		$forums_structured = [];
+		foreach (array_keys($forumsObject) as $key) {
+			$forumObject                                             =& $forumsObject[$key];
+			$forums_structured[$forumObject->getVar('cat_id')][$key] = $forumsObject[$key];
+		}
+		foreach (array_keys($forums_structured) as $cid) {
+			$tree              = new ObjectTree($forums_structured[$cid]);
+			$forum_array[$cid] = $tree->makeArrayTree($pid, $tags, $depth);
+			unset($tree);
+		}
+
+		return $forum_array;
+	}
+
+	/**
+	 * @param $object
+	 * @return array|null
+	 */
+	public function &getParents($object)
+	{
+		$ret = null;
+		if (!$object->getVar('forum_id')) {
+			return $ret;
+		}
+
+		require_once $GLOBALS['xoops']->path('modules/newbb/include/functions.forum.php');
+		if (!$parents = newbbGetParentForum($object->getVar('forum_id'))) {
+			return $ret;
+		}
+		$parents_list = $this->getList(new \Criteria('forum_id', '(' . implode(', ', $parents) . ')', 'IN'));
+		foreach ($parents as $key => $id) {
+			$ret[] = ['forum_id' => $id, 'forum_name' => $parents_list[$id]];
+		}
+		unset($parents, $parents_list);
+
+		return $ret;
+	}
+
+	// START irmtfan - get forum Ids by values. parse positive values to forum IDs and negative values to category IDs. value=0 => all valid forums
+
+	/**
+	 * function for get forum Ids by positive and negative values
+	 *
+	 * @param  int|text|array $values : positive values = forums | negative values = cats | $values=0 = all valid forums, $permission , true/false $parse_cats
+	 * @param  string   $permission
+	 * @param  bool     $parse_cats
+	 * @return array|mixed $validForums
+	 */
+	public function getIdsByValues($values = 0, $permission = 'access', $parse_cats = true)
+	{
+		// Get all valid forums with this permission
+		$validForums = $this->getIdsByPermission($permission);
+		// if no value or value=0 return all valid forums
+		if (empty($values)) {
+			return $validForums;
+		}
+		$values = is_numeric($values) ? [$values] : $values;
+		//parse negative values to category IDs
+		$forums = [];
+		$cats   = [];
+		foreach ($values as $val) {
+			if (0 == $val) {
+				// value=0 => all valid forums
+				return $validForums;
+			} elseif ($val > 0) {
+				$forums[] = $val;
+			} else {
+				$cats[] = abs($val);
+			}
+		}
+		// if dont want to parse categories OR no cats return all forums
+		if (empty($parse_cats) || empty($cats)) {
+			return array_intersect($validForums, $forums);
+		}
+		// Get all forums by category IDs
+		$forumObjs = $this->getForumsByCategory($cats, $permission, true);
+		$forums    = array_merge($forums, array_keys($forumObjs));
+
+		return array_intersect($validForums, $forums);
+	}
+	// END irmtfan - get forum Ids by values. parse positive values to forum IDs and negative values to category IDs. value=0 => all valid forums
 }

class/ReadForumHandler.php

Indentation +101 added lines, -101 removed lines

@@ -48,105 +48,105 @@
  */
 class ReadForumHandler extends Newbb\ReadHandler
 {
-    /**
-     * @param \XoopsDatabase|null $db
-     */
-    public function __construct(\XoopsDatabase $db = null)
-    {
-        parent::__construct($db, 'forum');
-    }
-
-    /**
-     * clean orphan items from database
-     *
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @return bool   true on success
-     */
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
-    {
-        parent::cleanOrphan($this->db->prefix('newbb_posts'), 'post_id');
-
-        return parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id', 'read_item');
-    }
-
-    /**
-     * @param  int  $status
-     * @param  null $uid
-     * @return bool
-     */
-    public function setReadItems($status = 0, $uid = null)
-    {
-        if (empty($this->mode)) {
-            return true;
-        }
-
-        if (1 == $this->mode) {
-            return $this->setReadItemsCookie($status);
-        } else {
-            return $this->setReadItemsDb($status, $uid);
-        }
-    }
-
-    /**
-     * @param $status
-     * @param $items
-     * @return bool
-     */
-    public function setReadItemsCookie($status, $items)
-    {
-        $cookie_name = 'LF';
-        $items       = [];
-        if (!empty($status)) {
-            /** @var Newbb\ForumHandler $itemHandler */
-            $itemHandler = Newbb\Helper::getInstance()->getHandler('Forum');
-            $items_id    = $itemHandler->getIds();
-            foreach ($items_id as $key) {
-                $items[$key] = time();
-            }
-        }
-        newbbSetCookie($cookie_name, $items);
-
-        return true;
-    }
-
-    /**
-     * @param $status
-     * @param $uid
-     * @return bool
-     */
-    public function setReadItemsDb($status, $uid)
-    {
-        if (empty($uid)) {
-            if (is_object($GLOBALS['xoopsUser'])) {
-                $uid = $GLOBALS['xoopsUser']->getVar('uid');
-            } else {
-                return false;
-            }
-        }
-        if (empty($status)) {
-            $this->deleteAll(new \Criteria('uid', $uid));
-
-            return true;
-        }
-
-        /** @var Newbb\ForumHandler $itemHandler */
-        $itemHandler = Newbb\Helper::getInstance()->getHandler('Forum');
-        $itemsObject = $itemHandler->getAll(null, ['forum_last_post_id']);
-        foreach (array_keys($itemsObject) as $key) {
-            $this->setReadDb($key, $itemsObject[$key]->getVar('forum_last_post_id'), $uid);
-        }
-        unset($itemsObject);
-
-        return true;
-    }
-
-    /**
-     *
-     */
-    public function synchronization()
-    {
-        //        return;
-    }
+	/**
+	 * @param \XoopsDatabase|null $db
+	 */
+	public function __construct(\XoopsDatabase $db = null)
+	{
+		parent::__construct($db, 'forum');
+	}
+
+	/**
+	 * clean orphan items from database
+	 *
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @return bool   true on success
+	 */
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
+	{
+		parent::cleanOrphan($this->db->prefix('newbb_posts'), 'post_id');
+
+		return parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id', 'read_item');
+	}
+
+	/**
+	 * @param  int  $status
+	 * @param  null $uid
+	 * @return bool
+	 */
+	public function setReadItems($status = 0, $uid = null)
+	{
+		if (empty($this->mode)) {
+			return true;
+		}
+
+		if (1 == $this->mode) {
+			return $this->setReadItemsCookie($status);
+		} else {
+			return $this->setReadItemsDb($status, $uid);
+		}
+	}
+
+	/**
+	 * @param $status
+	 * @param $items
+	 * @return bool
+	 */
+	public function setReadItemsCookie($status, $items)
+	{
+		$cookie_name = 'LF';
+		$items       = [];
+		if (!empty($status)) {
+			/** @var Newbb\ForumHandler $itemHandler */
+			$itemHandler = Newbb\Helper::getInstance()->getHandler('Forum');
+			$items_id    = $itemHandler->getIds();
+			foreach ($items_id as $key) {
+				$items[$key] = time();
+			}
+		}
+		newbbSetCookie($cookie_name, $items);
+
+		return true;
+	}
+
+	/**
+	 * @param $status
+	 * @param $uid
+	 * @return bool
+	 */
+	public function setReadItemsDb($status, $uid)
+	{
+		if (empty($uid)) {
+			if (is_object($GLOBALS['xoopsUser'])) {
+				$uid = $GLOBALS['xoopsUser']->getVar('uid');
+			} else {
+				return false;
+			}
+		}
+		if (empty($status)) {
+			$this->deleteAll(new \Criteria('uid', $uid));
+
+			return true;
+		}
+
+		/** @var Newbb\ForumHandler $itemHandler */
+		$itemHandler = Newbb\Helper::getInstance()->getHandler('Forum');
+		$itemsObject = $itemHandler->getAll(null, ['forum_last_post_id']);
+		foreach (array_keys($itemsObject) as $key) {
+			$this->setReadDb($key, $itemsObject[$key]->getVar('forum_last_post_id'), $uid);
+		}
+		unset($itemsObject);
+
+		return true;
+	}
+
+	/**
+	 *
+	 */
+	public function synchronization()
+	{
+		//        return;
+	}
 }

class/TextHandler.php

Indentation +19 added lines, -19 removed lines

@@ -19,24 +19,24 @@
  */
 class TextHandler extends \XoopsPersistableObjectHandler
 {
-    /**
-     * @param \XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db = null)
-    {
-        parent::__construct($db, 'newbb_posts_text', Text::class, 'post_id', '');
-    }
+	/**
+	 * @param \XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db = null)
+	{
+		parent::__construct($db, 'newbb_posts_text', Text::class, 'post_id', '');
+	}
 
-    /**
-     * clean orphan items from database
-     *
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @return bool   true on success
-     */
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
-    {
-        return parent::cleanOrphan($this->db->prefix('newbb_posts'), 'post_id');
-    }
+	/**
+	 * clean orphan items from database
+	 *
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @return bool   true on success
+	 */
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
+	{
+		return parent::cleanOrphan($this->db->prefix('newbb_posts'), 'post_id');
+	}
 }

class/TopicRenderer.php

Indentation +1123 added lines, -1123 removed lines

@@ -25,1133 +25,1133 @@
  */
 class TopicRenderer
 {
-    public $vars = [];
-
-    /**
-     * reference to moduleConfig
-     */
-    public $config;
-
-    /**
-     * Current user has no access to current page
-     */
-    private $noperm = false;
-
-    /**
-     * For multiple forums
-     */
-    public $is_multiple = false;
-
-    /**
-     * force to parse vars (run against static vars) irmtfan
-     */
-    public $force = false;
-
-    /**
-     * Vistitor's level: 0 - anonymous; 1 - user; 2 - moderator or admin
-     */
-    public $userlevel = 0;
-
-    public $query = [];
-
-    /**
-     * reference to an object handler
-     */
-    private $handler;
-
-    /**
-     * Requested page
-     */
-    private $page = 'list.topic.php';
-
-    /**
-     * query variables
-     */
-    private $args = ['forum', 'uid', 'lastposter', 'type', 'status', 'mode', 'sort', 'order', 'start', 'since'];
-
-    /**
-     * Constructor
-     */
-    //    public function TopicRenderer()
-    public function __construct()
-    {
-        $this->handler = Newbb\Helper::getInstance()->getHandler('Topic');
-    }
-
-    /**
-     * Access the only instance of this class
-     * @return TopicRenderer
-     */
-    public static function getInstance()
-    {
-        static $instance;
-        if (null === $instance) {
-            $instance = new static();
-        }
-
-        return $instance;
-    }
-
-    public function init()
-    {
-        $this->noperm = false;
-        $this->query  = [];
-    }
-
-    /**
-     * @param $var
-     * @param $val
-     * @return array|int|string
-     */
-    public function setVar($var, $val)
-    {
-        switch ($var) {
-            case 'forum':
-                if (is_numeric($val)) {
-                    $val = (int)$val;
-                // START irmtfan - if the forum is array
-                } elseif (is_array($val)) {
-                    $val = implode('|', $val);
-                    //} elseif (!empty($val)) {
-                    //    $val = implode("|", array_map("intval", explode(", ", $val)));
-                }
-                // END irmtfan - if the forum is array
-                break;
-
-            case 'type':
-            case 'mode':
-            case 'order':
-            case 'start':
-            case 'since':
-                $val = (int)$val;
-                break;
-
-            case 'uid': // irmtfan add multi topic poster
-            case 'lastposter': // irmtfan add multi lastposter
-                break;
-
-            case 'status':
-                // START irmtfan to accept multiple status
-                $val = is_array($val) ? $val : [$val];
-                $val = implode(',', $val);
-                //$val = (in_array($val, array_keys($this->getStatus( $this->userlevel ))) ) ? $val : "all"; //irmtfan no need to check if status is empty or not
-                //if ($val === "all" && !$this->is_multiple) $val = ""; irmtfan commented because it is done in sort
-                // END irmtfan to accept multiple status
-                break;
-
-            default:
-                break;
-        }
-
-        return $val;
-    }
-
-    /**
-     * @param array $vars
-     */
-    public function setVars(array $vars = [])
-    {
-        $this->init();
-
-        foreach ($vars as $var => $val) {
-            if (!in_array($var, $this->args)) {
-                continue;
-            }
-            $this->vars[$var] = $this->setVar($var, $val);
-        }
-        $this->parseVars();
-    }
-
-    /**
-     * @param null $status
-     */
-    public function myParseStatus($status = null)
-    {
-        switch ($status) {
-            case 'digest':
-                $this->query['where'][] = 't.topic_digest = 1';
-                break;
-
-            case 'undigest':
-                $this->query['where'][] = 't.topic_digest = 0';
-                break;
-
-            case 'sticky':
-                $this->query['where'][] = 't.topic_sticky = 1';
-                break;
-
-            case 'unsticky':
-                $this->query['where'][] = 't.topic_sticky = 0';
-                break;
-
-            case 'lock':
-                $this->query['where'][] = 't.topic_status = 1';
-                break;
-
-            case 'unlock':
-                $this->query['where'][] = 't.topic_status = 0';
-                break;
-
-            case 'poll':
-                $this->query['where'][] = 't.topic_haspoll = 1';
-                break;
-
-            case 'unpoll':
-                $this->query['where'][] = 't.topic_haspoll = 0';
-                break;
-
-            case 'voted':
-                $this->query['where'][] = 't.votes > 0';
-                break;
-
-            case 'unvoted':
-                $this->query['where'][] = 't.votes < 1';
-                break;
-
-            case 'replied':
-                $this->query['where'][] = 't.topic_replies > 0';
-                break;
-
-            case 'unreplied':
-                $this->query['where'][] = 't.topic_replies < 1';
-                break;
-
-            case 'viewed':
-                $this->query['where'][] = 't.topic_views > 0';
-                break;
-
-            case 'unviewed':
-                $this->query['where'][] = 't.topic_views < 1';
-                break;
-
-            case 'read':
-                // Skip
-                if (empty($this->config['read_mode'])) {
-                    // Use database
-                } elseif (2 == $this->config['read_mode']) {
-                    // START irmtfan use read_uid to find the unread posts when the user is logged in
-                    $read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
-                    if (!empty($read_uid)) {
-                        $this->query['join'][]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_reads_topic') . ' AS r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
-                        $this->query['where'][] = 'r.post_id = t.topic_last_post_id';
-                    } else {
-                    }
-                    // END irmtfan change criteria to get from uid p.uid = last post submit user id
-                    // User cookie
-                } elseif (1 == $this->config['read_mode']) {
-                    // START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
-                    $startdate = !empty($this->vars['since']) ? (time() - newbbGetSinceTime($this->vars['since'])) : 0;
-                    if ($lastvisit = max($GLOBALS['last_visit'], $startdate)) {
-                        $readmode1query = '';
-                        if ($lastvisit > $startdate) {
-                            $readmode1query = 'p.post_time < ' . $lastvisit;
-                        }
-                        $topics         = [];
-                        $topic_lastread = newbbGetCookie('LT', true);
-                        if (count($topic_lastread) > 0) {
-                            foreach ($topic_lastread as $id => $time) {
-                                if ($time > $lastvisit) {
-                                    $topics[] = $id;
-                                }
-                            }
-                        }
-                        if (count($topics) > 0) {
-                            $topicquery = ' t.topic_id IN (' . implode(',', $topics) . ')';
-                            // because it should be OR
-                            $readmode1query = !empty($readmode1query) ? '(' . $readmode1query . ' OR ' . $topicquery . ')' : $topicquery;
-                        }
-                        $this->query['where'][] = $readmode1query;
-                    }
-                    // END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
-                }
-                break;
-
-            case 'unread':
-                // Skip
-                if (empty($this->config['read_mode'])) {
-                    // Use database
-                } elseif (2 == $this->config['read_mode']) {
-                    // START irmtfan use read_uid to find the unread posts when the user is logged in
-                    $read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
-                    if (!empty($read_uid)) {
-                        $this->query['join'][]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_reads_topic') . ' AS r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
-                        $this->query['where'][] = '(r.read_id IS NULL OR r.post_id < t.topic_last_post_id)';
-                    } else {
-                    }
-                    // END irmtfan change criteria to get from uid p.uid = last post submit user id
-                    // User cookie
-                } elseif (1 == $this->config['read_mode']) {
-                    // START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
-                    $startdate = !empty($this->vars['since']) ? (time() - newbbGetSinceTime($this->vars['since'])) : 0;
-                    if ($lastvisit = max($GLOBALS['last_visit'], $startdate)) {
-                        if ($lastvisit > $startdate) {
-                            $this->query['where'][] = 'p.post_time > ' . $lastvisit;
-                        }
-                        $topics         = [];
-                        $topic_lastread = newbbGetCookie('LT', true);
-                        if (count($topic_lastread) > 0) {
-                            foreach ($topic_lastread as $id => $time) {
-                                if ($time > $lastvisit) {
-                                    $topics[] = $id;
-                                }
-                            }
-                        }
-                        if (count($topics) > 0) {
-                            $this->query['where'][] = ' t.topic_id NOT IN (' . implode(',', $topics) . ')';
-                        }
-                    }
-                    // END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
-                }
-                break;
-
-            case 'pending':
-                if ($this->userlevel < 2) {
-                    $this->noperm = true;
-                } else {
-                    $this->query['where'][] = 't.approved = 0';
-                }
-                break;
-
-            case 'deleted':
-                if ($this->userlevel < 2) {
-                    $this->noperm = true;
-                } else {
-                    $this->query['where'][] = 't.approved = -1';
-                }
-                break;
-
-            case 'all': // For viewall.php; do not display sticky topics at first
-            case 'active': // same as 'all'
-                $this->query['where'][] = 't.approved = 1';
-                break;
-
-            default: // irmtfan do nothing
-                break;
-        }
-    }
-
-    /**
-     * @param $var
-     * @param $val
-     */
-    public function parseVar($var, $val)
-    {
-        switch ($var) {
-            case 'forum':
-                /** @var Newbb\ForumHandler $forumHandler */
-                $forumHandler = Newbb\Helper::getInstance()->getHandler('Forum');
-                // START irmtfan - get forum Ids by values. parse positive values to forum IDs and negative values to category IDs. value=0 => all valid forums
-                // Get accessible forums
-                $accessForums = $forumHandler->getIdsByValues(array_map('intval', @explode('|', $val)));
-                // Filter specified forums if any
-                //if (!empty($val) && $_forums = @explode('|', $val)) {
-                //$accessForums = array_intersect($accessForums, array_map('intval', $_forums));
-                //}
-                $this->vars['forum'] = $this->setVar('forum', $accessForums);
-                // END irmtfan - get forum Ids by values. parse positive values to forum IDs and negative values to category IDs. value=0 => all valid forums
-
-                if (empty($accessForums)) {
-                    $this->noperm = true;
-                // irmtfan - it just return return the forum_id only when the forum_id is the first allowed forum - no need for this code implode is enough removed.
-                    //} elseif (count($accessForums) === 1) {
-                    //$this->query["where"][] = "t.forum_id = " . $accessForums[0];
-                } else {
-                    $this->query['where'][] = 't.forum_id IN ( ' . implode(', ', $accessForums) . ' )';
-                }
-                break;
-
-            case 'uid': // irmtfan add multi topic poster
-                if (-1 !== $val) {
-                    $val                    = implode(',', array_map('intval', explode(',', $val)));
-                    $this->query['where'][] = 't.topic_poster IN ( ' . $val . ' )';
-                }
-                break;
-            case 'lastposter': // irmtfan add multi lastposter
-                if (-1 !== $val) {
-                    $val                    = implode(',', array_map('intval', explode(',', $val)));
-                    $this->query['where'][] = 'p.uid IN ( ' . $val . ' )';
-                }
-                break;
-
-            case 'since':
-                if (!empty($val)) {
-                    // START irmtfan if unread && read_mode = 1 and last_visit > startdate do not add where query | to accept multiple status
-                    $startdate = time() - newbbGetSinceTime($val);
-                    if (in_array('unread', explode(',', $this->vars['status'], true)) && 1 == $this->config['read_mode']
-                        && $GLOBALS['last_visit'] > $startdate) {
-                        break;
-                    }
-                    // irmtfan digest_time | to accept multiple status
-                    if (in_array('digest', explode(',', $this->vars['status'], true))) {
-                        $this->query['where'][] = 't.digest_time > ' . $startdate;
-                    }
-                    // irmtfan - should be >= instead of =
-                    $this->query['where'][] = 'p.post_time >= ' . $startdate;
-                    // END irmtfan if unread && read_mode = 1 and last_visit > startdate do not add where query
-                }
-                break;
-
-            case 'type':
-                if (!empty($val)) {
-                    $this->query['where'][] = 't.type_id = ' . $val;
-                }
-                break;
-
-            case 'status':
-                // START irmtfan to accept multiple status
-                $val = explode(',', $val);
-                // irmtfan - add 'all' to always parse t.approved = 1
-                if (0 === count(array_intersect($val, ['all', 'active', 'pending', 'deleted']))) {
-                    $val[] = 'all';
-                }
-                foreach ($val as $key => $status) {
-                    $this->myParseStatus($status);
-                }
-                // END irmtfan to accept multiple status
-                break;
-
-            case 'sort':
-                if ($sort = $this->getSort($val, 'sort')) {
-                    $this->query['sort'][] = $sort . (empty($this->vars['order']) ? ' DESC' : ' ASC');
-                } else { // irmtfan if sort is not in the list
-                    $this->query['sort'][] = 't.topic_last_post_id' . (empty($this->vars['order']) ? ' DESC' : ' ASC');
-                }
-                break;
-
-            default:
-                break;
-        }
-    }
-
-    /**
-     * @return bool
-     */
-    public function parseVars()
-    {
-        static $parsed;
-        // irmtfan - force to parse vars (run against static vars)
-        if (null !== $parsed && !$this->force) {
-            return true;
-        }
-
-        if (!isset($this->vars['forum'])) {
-            $this->vars['forum'] = null;
-        }
-        //irmtfan parse status for rendering topic correctly - if empty($_GET(status)) it will show all topics include deleted and pendings. 'all' instead of all
-        if (!isset($this->vars['status'])) {
-            $this->vars['status'] = 'all';
-        }
-        // irmtfan if sort is not set or is empty get a default sort- if empty($_GET(sort)) | if sort=null eg: /list.topic.php?sort=
-        if (empty($this->vars['sort'])) {
-            $this->vars['sort'] = 'lastpost';
-        } // use lastpost instead of sticky
-
-        foreach ($this->vars as $var => $val) {
-            $this->parseVar($var, $val);
-            if (empty($val)) {
-                unset($this->vars[$var]);
-            }
-        }
-        $parsed = true;
-
-        return true;
-    }
-
-    /**
-     * @param  null $header
-     * @param  null $var
-     * @return array|null
-     */
-    public function getSort($header = null, $var = null)
-    {
-        $headers = [
-            'topic'           => [
-                'title' => _MD_NEWBB_TOPICS,
-                'sort'  => 't.topic_title'
-            ],
-            'forum'           => [
-                'title' => _MD_NEWBB_FORUM,
-                'sort'  => 't.forum_id'
-            ],
-            'poster'          => [
-                'title' => _MD_NEWBB_TOPICPOSTER, /*irmtfan _MD_NEWBB_POSTER to _MD_NEWBB_TOPICPOSTER*/
-                'sort'  => 't.topic_poster'
-            ],
-            'replies'         => [
-                'title' => _MD_NEWBB_REPLIES,
-                'sort'  => 't.topic_replies'
-            ],
-            'views'           => [
-                'title' => _MD_NEWBB_VIEWS,
-                'sort'  => 't.topic_views'
-            ],
-            'lastpost'        => [ // irmtfan show topic_page_jump_icon smarty
-                                   'title' => _MD_NEWBB_LASTPOST,
-                                   /*irmtfan _MD_NEWBB_DATE to _MD_NEWBB_LASTPOSTTIME again change to _MD_LASTPOST*/
-                                   'sort'  => 't.topic_last_post_id'
-            ],
-            // START irmtfan add more sorts
-            'lastposttime'    => [ // irmtfan same as lastpost
-                                   'title' => _MD_NEWBB_LASTPOSTTIME,
-                                   'sort'  => 't.topic_last_post_id'
-            ],
-            'lastposter'      => [ // irmtfan
-                                   'title' => _MD_NEWBB_POSTER,
-                                   'sort'  => 'p.uid',// poster uid
-            ],
-            'lastpostmsgicon' => [ // irmtfan
-                                   'title' => _MD_NEWBB_MESSAGEICON,
-                                   'sort'  => 'p.icon',// post message icon
-            ],
-            'ratings'         => [
-                'title' => _MD_NEWBB_RATINGS,
-                'sort'  => 't.rating', // irmtfan t.topic_rating to t.rating
-            ],
-            'votes'           => [
-                'title' => _MD_NEWBB_VOTES,
-                'sort'  => 't.votes'
-            ],
-            'publish'         => [
-                'title' => _MD_NEWBB_TOPICTIME,
-                'sort'  => 't.topic_id'
-            ],
-            'digest'          => [
-                'title' => _MD_NEWBB_DIGEST,
-                'sort'  => 't.digest_time'
-            ],
-            'sticky'          => [
-                'title' => _MD_NEWBB_STICKY,
-                'sort'  => 't.topic_sticky'
-            ],
-            'lock'            => [
-                'title' => _MD_NEWBB_LOCK,
-                'sort'  => 't.topic_status'
-            ],
-            'poll'            => [
-                'title' => _MD_NEWBB_POLL_POLL,
-                'sort'  => 't.poll_id'
-            ]
-        ];
-        $types   = $this->getTypes();
-        if (!empty($types)) {
-            $headers['type'] = [
-                'title' => _MD_NEWBB_TYPE,
-                'sort'  => 't.type_id'
-            ];
-        }
-        if (2 == $this->userlevel) {
-            $headers['approve'] = [
-                'title' => _MD_NEWBB_APPROVE,
-                'sort'  => 't.approved'
-            ];
-        }
-        // END irmtfan add more sorts
-        if (empty($header) && empty($var)) {
-            return $headers;
-        }
-        if (!empty($var) && !empty($header)) {
-            return @$headers[$header][$var];
-        }
-        if (empty($var)) {
-            return @$headers[$header];
-        }
-        $ret = null;
-        foreach (array_keys($headers) as $key) {
-            $ret[$key] = @$headers[$key][$var];
-        }
-
-        return $ret;
-    }
-
-    // START irmtfan add Display topic headers function
-
-    /**
-     * @param  null $header
-     * @return array
-     */
-    public function getHeader($header = null)
-    {
-        $headersSort = $this->getSort('', 'title');
-        // additional headers - important: those cannot be in sort anyway
-        $headers = array_merge($headersSort, [
-            'attachment' => _MD_NEWBB_TOPICSHASATT, // show attachment smarty
-            'read'       => _MD_NEWBB_MARK_UNREAD . '|' . _MD_NEWBB_MARK_READ, // read/unread show topic_folder smarty
-            'pagenav'    => _MD_NEWBB_PAGENAV_DISPLAY, // show topic_page_jump smarty - sort by topic_replies?
-        ]);
-
-        return $this->getFromKeys($headers, $header);
-    }
-
-    // END irmtfan add Display topic headers function
-
-    /**
-     * @param  null $type
-     * @param  null $status
-     * @return array
-     */
-    public function getStatus($type = null, $status = null)
-    {
-        $links       = [
-            //""            => "", /* irmtfan remove empty array */
-            'all'       => _ALL,
-            'digest'    => _MD_NEWBB_DIGEST,
-            'undigest'  => _MD_NEWBB_UNDIGEST, // irmtfan add
-            'sticky'    => _MD_NEWBB_STICKY, // irmtfan add
-            'unsticky'  => _MD_NEWBB_UNSTICKY, // irmtfan add
-            'lock'      => _MD_NEWBB_LOCK, // irmtfan add
-            'unlock'    => _MD_NEWBB_UNLOCK, // irmtfan add
-            'poll'      => _MD_NEWBB_TOPICHASPOLL, // irmtfan add
-            'unpoll'    => _MD_NEWBB_TOPICHASNOTPOLL, // irmtfan add
-            'voted'     => _MD_NEWBB_VOTED, // irmtfan add
-            'unvoted'   => _MD_NEWBB_UNVOTED, // irmtfan add
-            'viewed'    => _MD_NEWBB_VIEWED, // irmtfan add
-            'unviewed'  => _MD_NEWBB_UNVIEWED, // irmtfan add
-            'replied'   => _MD_NEWBB_REPLIED, // irmtfan add
-            'unreplied' => _MD_NEWBB_UNREPLIED,
-            'read'      => _MD_NEWBB_READ, // irmtfan add
-            'unread'    => _MD_NEWBB_UNREAD
-        ];
-        $links_admin = [
-            'active'  => _MD_NEWBB_TYPE_ADMIN,
-            'pending' => _MD_NEWBB_TYPE_PENDING,
-            'deleted' => _MD_NEWBB_TYPE_DELETED
-        ];
-
-        // all status, for admin
-        if ($type > 1) {
-            $links = array_merge($links, $links_admin);// irmtfan to accept multiple status
-        }
-
-        return $this->getFromKeys($links, $status); // irmtfan to accept multiple status
-    }
-
-    /**
-     * @param \Smarty $xoopsTpl
-     * @throws \RuntimeException
-     */
-    public function buildSelection(\Smarty $xoopsTpl)
-    {
-        $selection         = ['action' => $this->page];
-        $selection['vars'] = $this->vars;
-        require_once  dirname(__DIR__) . '/include/functions.forum.php';
-        $forum_selected     = empty($this->vars['forum']) ? null : explode('|', @$this->vars['forum']);
-        $selection['forum'] = '<select name="forum[]" multiple="multiple">';
-        $selection['forum'] .= '<option value="0">' . _MD_NEWBB_ALL . '</option>';
-        $selection['forum'] .= newbbForumSelectBox($forum_selected);
-        $selection['forum'] .= '</select>';
-
-        $sort_selected     = $this->vars['sort'];
-        $sorts             = $this->getSort('', 'title');
-        $selection['sort'] = "<select name='sort'>";
-        if (!is_array($sorts)) {
-            throw new \RuntimeException('$sorts must be an array.');
-        }
-        foreach ($sorts as $sort => $title) {
-            $selection['sort'] .= "<option value='" . $sort . "' " . (($sort == $sort_selected) ? " selected='selected'" : '') . '>' . $title . '</option>';
-        }
-        $selection['sort'] .= '</select>';
-
-        $selection['order'] = "<select name='order'>";
-        $selection['order'] .= "<option value='0' " . (empty($this->vars['order']) ? " selected='selected'" : '') . '>' . _DESCENDING . '</option>';
-        $selection['order'] .= "<option value='1' " . (!empty($this->vars['order']) ? " selected='selected'" : '') . '>' . _ASCENDING . '</option>';
-        $selection['order'] .= '</select>';
-
-        $since              = isset($this->vars['since']) ? $this->vars['since'] : $this->config['since_default'];
-        $selection['since'] = newbbSinceSelectBox($since);
-
-        $xoopsTpl->assign_by_ref('selection', $selection);
-    }
-
-    /**
-     * @param \Smarty $xoopsTpl
-     */
-    public function buildSearch(\Smarty $xoopsTpl)
-    {
-        $search             = [];
-        $search['forum']    = @$this->vars['forum'];
-        $search['since']    = @$this->vars['since'];
-        $search['searchin'] = 'both';
-
-        $xoopsTpl->assign_by_ref('search', $search);
-    }
-
-    /**
-     * @param \Smarty $xoopsTpl
-     * @throws \RuntimeException
-     */
-    public function buildHeaders(\Smarty $xoopsTpl)
-    {
-        $args = [];
-        foreach ($this->vars as $var => $val) {
-            if ('sort' === $var || 'order' === $var) {
-                continue;
-            }
-            $args[] = "{$var}={$val}";
-        }
-
-        $headers = $this->getSort('', 'title');
-        if (!is_array($headers)) {
-            throw new \RuntimeException('$headers must be an array.');
-        }
-        foreach ($headers as $header => $title) {
-            $_args = ["sort={$header}"];
-            if (@$this->vars['sort'] == $header) {
-                $_args[] = 'order=' . ((@$this->vars['order'] + 1) % 2);
-            }
-            $headers_data[$header]['title'] = $title;
-            $headers_data[$header]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
-        }
-        $xoopsTpl->assign_by_ref('headers', $headers_data);
-    }
-
-    /**
-     * @param \Smarty $xoopsTpl
-     */
-    public function buildFilters(\Smarty $xoopsTpl)
-    {
-        $args = [];
-        foreach ($this->vars as $var => $val) {
-            if ('status' === $var) {
-                continue;
-            }
-            $args[] = "{$var}={$val}";
-        }
-
-        $links = $this->getStatus($this->userlevel);
-
-        $status = [];
-        foreach ($links as $link => $title) {
-            $_args                  = ["status={$link}"];
-            $status[$link]['title'] = $title;
-            $status[$link]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
-        }
-        $xoopsTpl->assign_by_ref('filters', $status);
-    }
-
-    /**
-     * @param  null $type_id
-     * @return mixed
-     */
-    public function getTypes($type_id = null)
-    {
-        static $types;
-        if (!isset($types)) {
-            /** @var Newbb\TypeHandler $typeHandler */
-            $typeHandler = Newbb\Helper::getInstance()->getHandler('Type');
-
-            $types = $typeHandler->getByForum(explode('|', @$this->vars['forum']));
-        }
-
-        if (empty($type_id)) {
-            return $types;
-        }
-
-        return @$types[$type_id];
-    }
-
-    /**
-     * @param  \Smarty $xoopsTpl
-     * @return bool
-     */
-    public function buildTypes(\Smarty $xoopsTpl)
-    {
-        $status = '';
-        if (!$types = $this->getTypes()) {
-            return true;
-        }
-
-        $args = [];
-        foreach ($this->vars as $var => $val) {
-            if ('type' === $var) {
-                continue;
-            }
-            $args[] = "{$var}={$val}";
-        }
-
-        foreach ($types as $id => $type) {
-            $_args                = ["type={$id}"];
-            $status[$id]['title'] = $type['type_name'];
-            $status[$id]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
-        }
-        $xoopsTpl->assign_by_ref('types', $status);
-    }
-
-    /**
-     * @param  \Smarty $xoopsTpl
-     * @return bool
-     */
-    public function buildCurrent(\Smarty $xoopsTpl)
-    {
-        if (empty($this->vars['status']) && !$this->is_multiple) {
-            return true;
-        }
-
-        $args = [];
-        foreach ($this->vars as $var => $val) {
-            $args[] = "{$var}={$val}";
-        }
-
-        $status          = [];
-        $status['title'] = implode(',', $this->getStatus($this->userlevel, $this->vars['status'])); // irmtfan to accept multiple status
-        //$status['link'] = $this->page.(empty($this->vars['status']) ? '' : '?status='.$this->vars['status']);
-        $status['link'] = $this->page . (empty($args) ? '' : '?' . implode('&amp;', $args));
-
-        $xoopsTpl->assign_by_ref('current', $status);
-    }
-
-    /**
-     * @param \Smarty $xoopsTpl
-     */
-    public function buildPagenav(\Smarty $xoopsTpl)
-    {
-        $count_topic = $this->getCount();
-        if ($count_topic > $this->config['topics_per_page']) {
-            $args = [];
-            foreach ($this->vars as $var => $val) {
-                if ('start' === $var) {
-                    continue;
-                }
-                $args[] = "{$var}={$val}";
-            }
-            require_once $GLOBALS['xoops']->path('class/pagenav.php');
-            $nav = new \XoopsPageNav($count_topic, $this->config['topics_per_page'], @$this->vars['start'], 'start', implode('&amp;', $args));
-            if (isset($GLOBALS['xoopsModuleConfig']['do_rewrite'])) {
-                $nav->url = formatURL(Request::getString('SERVER_NAME', '', 'SERVER')) . ' /' . $nav->url;
-            }
-            if ('select' === $this->config['pagenav_display']) {
-                $navi = $nav->renderSelect();
-            } elseif ('image' === $this->config['pagenav_display']) {
-                $navi = $nav->renderImageNav(4);
-            } else {
-                $navi = $nav->renderNav(4);
-            }
-            $xoopsTpl->assign('pagenav', $navi);
-        } else {
-            $xoopsTpl->assign('pagenav', '');
-        }
-    }
-
-    /**
-     * @return int
-     */
-    public function getCount()
-    {
-        if ($this->noperm) {
-            return 0;
-        }
-
-        $selects = [];
-        $froms   = [];
-        $joins   = [];
-        $wheres  = [];
-
-        // topic fields
-        $selects[] = 'COUNT(*)';
-
-        $froms[]  = $this->handler->db->prefix('newbb_topics') . ' AS t ';
-        $joins[]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts') . ' AS p ON p.post_id = t.topic_last_post_id';
-        $wheres[] = '1 = 1';
-
-        $sql = '    SELECT ' . implode(', ', $selects) . '     FROM ' . implode(', ', $froms) . '        ' . implode(' ', $joins) . (!empty($this->query['join']) ? '        ' . implode(' ', $this->query['join']) : '') . // irmtfan bug fix: Undefined index: join when post_excerpt = 0
-               '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']);
-
-        if (!$result = $this->handler->db->query($sql)) {
-            return 0;
-        }
-        list($count) = $this->handler->db->fetchRow($result);
-
-        return $count;
-    }
-
-    /**
-     * @param  \Smarty $xoopsTpl
-     * @return array|void
-     */
-    public function renderTopics(\Smarty $xoopsTpl = null)
-    {
-        $myts = \MyTextSanitizer::getInstance(); // irmtfan Instanciate
-
-        $ret = [];
-        //$this->parseVars();
-
-        if ($this->noperm) {
-            if (is_object($xoopsTpl)) {
-                $xoopsTpl->assign_by_ref('topics', $ret);
-
-                return;
-            }
-
-            return $ret;
-        }
-
-        $selects = [];
-        $froms   = [];
-        $joins   = [];
-        $wheres  = [];
-
-        // topic fields
-        $selects[] = 't.*';
-        // post fields
-        $selects[] = 'p.post_time as last_post_time, p.poster_name as last_poster_name, p.icon, p.post_id, p.uid';
-
-        $froms[]  = $this->handler->db->prefix('newbb_topics') . ' AS t ';
-        $joins[]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts') . ' AS p ON p.post_id = t.topic_last_post_id';
-        $wheres[] = '1 = 1';
-
-        if (!empty($this->config['post_excerpt'])) {
-            $selects[]             = 'p.post_karma, p.require_reply, pt.post_text';
-            $this->query['join'][] = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts_text') . ' AS pt ON pt.post_id = t.topic_last_post_id';
-        }
-        //if (empty($this->query["sort"])) $this->query["sort"][] = 't.topic_last_post_id DESC'; // irmtfan commented no need
-
-        $sql = '    SELECT ' . implode(', ', $selects) . '     FROM ' . implode(', ', $froms) . '        ' . implode(' ', $joins) . (!empty($this->query['join']) ? '        ' . implode(' ', $this->query['join']) : '') . // irmtfan bug fix: Undefined index join when post_excerpt = 0
-               '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']) . '     ORDER BY ' . implode(', ', $this->query['sort']);
-
-        if (!$result = $this->handler->db->query($sql, $this->config['topics_per_page'], @$this->vars['start'])) {
-            if (is_object($xoopsTpl)) {
-                $xoopsTpl->assign_by_ref('topics', $ret);
-
-                return;
-            }
-
-            return $ret;
-        }
-
-        require_once  dirname(__DIR__) . '/include/functions.render.php';
-        require_once  dirname(__DIR__) . '/include/functions.session.php';
-        require_once  dirname(__DIR__) . '/include/functions.time.php';
-        require_once  dirname(__DIR__) . '/include/functions.read.php';
-        require_once  dirname(__DIR__) . '/include/functions.topic.php';
-
-        $sticky    = 0;
-        $topics    = [];
-        $posters   = [];
-        $reads     = [];
-        $types     = [];
-        $forums    = [];
-        $anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
-
-        while (false !== ($myrow = $this->handler->db->fetchArray($result))) {
-            if ($myrow['topic_sticky']) {
-                ++$sticky;
-            }
-
-            // ------------------------------------------------------
-            // START irmtfan remove topic_icon hardcode smarty
-            // topic_icon: just regular topic_icon
-            if (!empty($myrow['icon'])) {
-                $topic_icon = '<img align="middle" src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($myrow['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
-            } else {
-                $topic_icon = '<img align="middle" src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" />';
-            }
-            // END irmtfan remove topic_icon hardcode smarty
-
-            // ------------------------------------------------------
-            // rating_img
-            $rating = number_format($myrow['rating'] / 2, 0);
-            // irmtfan - add alt key for rating
-            if ($rating < 1) {
-                $rating_img = newbbDisplayImage('blank');
-            } else {
-                $rating_img = newbbDisplayImage('rate' . $rating, constant('_MD_NEWBB_RATE' . $rating));
-            }
-
-            // ------------------------------------------------------
-            // topic_page_jump
-            $topic_page_jump      = '';
-            $topic_page_jump_icon = '';
-            $totalpages           = ceil(($myrow['topic_replies'] + 1) / $this->config['posts_per_page']);
-            if ($totalpages > 1) {
-                $topic_page_jump .= '&nbsp;&nbsp;';
-                $append          = false;
-                for ($i = 1; $i <= $totalpages; ++$i) {
-                    if ($i > 3 && $i < $totalpages) {
-                        if (!$append) {
-                            $topic_page_jump .= '...';
-                            $append          = true;
-                        }
-                    } else {
-                        $topic_page_jump .= '[<a href="' . XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'] . '&amp;start=' . (($i - 1) * $this->config['posts_per_page']) . '">' . $i . '</a>]';
-                        // irmtfan remove here and move
-                        //$topic_page_jump_icon = "<a href='" . XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=" . $myrow['topic_id'] . "&amp;start=" . (($i - 1) * $this->config['posts_per_page']) . "" . "'>" . newbbDisplayImage('document',_MD_NEWBB_GOTOLASTPOST) . '</a>';
-                    }
-                }
-            }
-            // irmtfan - move here for both topics with and without pages - change topic_id to post_id
-            $topic_page_jump_icon = "<a href='" . XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $myrow['topic_last_post_id'] . '' . "'>" . newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST) . '</a>';
-
-            // ------------------------------------------------------
-            // => topic array
-
-            $topic_title = $myts->htmlSpecialChars($myrow['topic_title']);
-            // irmtfan use topic_title_excerpt for block topic title length
-            $topic_title_excerpt = $topic_title;
-            if (!empty($this->config['topic_title_excerpt'])) {
-                $topic_title_excerpt = xoops_substr($topic_title, 0, $this->config['topic_title_excerpt']);
-            }
-            // irmtfan hardcode class commented
-            //if ($myrow['topic_digest']) {
-            //   $topic_title = "<span class='digest'>" . $topic_title . "</span>";
-            //}
-
-            if (empty($this->config['post_excerpt'])) {
-                $topic_excerpt = '';
-            } elseif (($myrow['post_karma'] > 0 || $myrow['require_reply'] > 0) && !newbbIsAdmin($myrow['forum_id'])) {
-                $topic_excerpt = '';
-            } else {
-                $topic_excerpt = xoops_substr(newbbHtml2text($myts->displayTarea($myrow['post_text'])), 0, $this->config['post_excerpt']);
-                $topic_excerpt = str_replace('[', '&#91;', $myts->htmlSpecialChars($topic_excerpt));
-            }
-
-            $topics[$myrow['topic_id']] = [
-                'topic_id'               => $myrow['topic_id'],
-                'topic_icon'             => $topic_icon,
-                'type_id'                => $myrow['type_id'],
-                'topic_title_excerpt'    => $topic_title_excerpt,
-                //irmtfan use topic_title_excerpt
-                //'topic_link'    => XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'], // . '&amp;forum=' . $myrow['forum_id'], // irmtfan comment
-                'topic_link'             => 'viewtopic.php?topic_id=' . $myrow['topic_id'],
-                // irmtfan remove hardcode link
-                'rating_img'             => $rating_img,
-                'votes'                  => $myrow['votes'],
-                //irmtfan added
-                'topic_page_jump'        => $topic_page_jump,
-                'topic_page_jump_icon'   => $topic_page_jump_icon,
-                'topic_replies'          => $myrow['topic_replies'],
-                'topic_poster_uid'       => $myrow['topic_poster'],
-                'topic_poster_name'      => !empty($myrow['poster_name']) ? $myts->htmlSpecialChars($myrow['poster_name']) : $anonymous,
-                'topic_views'            => $myrow['topic_views'],
-                'topic_time'             => newbbFormatTimestamp($myrow['topic_time']),
-                'topic_last_post_id'     => $myrow['topic_last_post_id'],
-                //irmtfan added
-                'topic_last_posttime'    => newbbFormatTimestamp($myrow['last_post_time']),
-                'topic_last_poster_uid'  => $myrow['uid'],
-                'topic_last_poster_name' => !empty($myrow['last_poster_name']) ? $myts->htmlSpecialChars($myrow['last_poster_name']) : $anonymous,
-                'topic_forum'            => $myrow['forum_id'],
-                'topic_excerpt'          => $topic_excerpt,
-                'sticky'                 => $myrow['topic_sticky'] ? newbbDisplayImage('topic_sticky', _MD_NEWBB_TOPICSTICKY) : '',
-                // irmtfan bug fixed
-                'lock'                   => $myrow['topic_status'] ? newbbDisplayImage('topic_locked', _MD_NEWBB_TOPICLOCK) : '',
-                //irmtfan added
-                'digest'                 => $myrow['topic_digest'] ? newbbDisplayImage('topic_digest', _MD_NEWBB_TOPICDIGEST) : '',
-                //irmtfan added
-                'poll'                   => $myrow['topic_haspoll'] ? newbbDisplayImage('poll', _MD_NEWBB_TOPICHASPOLL) : '',
-                //irmtfan added
-                'approve'                => $myrow['approved'],
-                //irmtfan added
-            ];
-
-            /* users */
-            $posters[$myrow['topic_poster']] = 1;
-            $posters[$myrow['uid']]          = 1;
-            // reads
-            if (!empty($this->config['read_mode'])) {
-                $reads[$myrow['topic_id']] = (1 == $this->config['read_mode']) ? $myrow['last_post_time'] : $myrow['topic_last_post_id'];
-            }
-            // types
-            if (!empty($myrow['type_id'])) {
-                //$types[$myrow['type_id']] = 1;
-            }
-            // forums
-            $forums[$myrow['forum_id']] = 1;
-        }
-        $posters_name = newbbGetUnameFromIds(array_keys($posters), $this->config['show_realname'], true);
-        $topic_isRead = newbbIsRead('topic', $reads);
-        /*
+	public $vars = [];
+
+	/**
+	 * reference to moduleConfig
+	 */
+	public $config;
+
+	/**
+	 * Current user has no access to current page
+	 */
+	private $noperm = false;
+
+	/**
+	 * For multiple forums
+	 */
+	public $is_multiple = false;
+
+	/**
+	 * force to parse vars (run against static vars) irmtfan
+	 */
+	public $force = false;
+
+	/**
+	 * Vistitor's level: 0 - anonymous; 1 - user; 2 - moderator or admin
+	 */
+	public $userlevel = 0;
+
+	public $query = [];
+
+	/**
+	 * reference to an object handler
+	 */
+	private $handler;
+
+	/**
+	 * Requested page
+	 */
+	private $page = 'list.topic.php';
+
+	/**
+	 * query variables
+	 */
+	private $args = ['forum', 'uid', 'lastposter', 'type', 'status', 'mode', 'sort', 'order', 'start', 'since'];
+
+	/**
+	 * Constructor
+	 */
+	//    public function TopicRenderer()
+	public function __construct()
+	{
+		$this->handler = Newbb\Helper::getInstance()->getHandler('Topic');
+	}
+
+	/**
+	 * Access the only instance of this class
+	 * @return TopicRenderer
+	 */
+	public static function getInstance()
+	{
+		static $instance;
+		if (null === $instance) {
+			$instance = new static();
+		}
+
+		return $instance;
+	}
+
+	public function init()
+	{
+		$this->noperm = false;
+		$this->query  = [];
+	}
+
+	/**
+	 * @param $var
+	 * @param $val
+	 * @return array|int|string
+	 */
+	public function setVar($var, $val)
+	{
+		switch ($var) {
+			case 'forum':
+				if (is_numeric($val)) {
+					$val = (int)$val;
+				// START irmtfan - if the forum is array
+				} elseif (is_array($val)) {
+					$val = implode('|', $val);
+					//} elseif (!empty($val)) {
+					//    $val = implode("|", array_map("intval", explode(", ", $val)));
+				}
+				// END irmtfan - if the forum is array
+				break;
+
+			case 'type':
+			case 'mode':
+			case 'order':
+			case 'start':
+			case 'since':
+				$val = (int)$val;
+				break;
+
+			case 'uid': // irmtfan add multi topic poster
+			case 'lastposter': // irmtfan add multi lastposter
+				break;
+
+			case 'status':
+				// START irmtfan to accept multiple status
+				$val = is_array($val) ? $val : [$val];
+				$val = implode(',', $val);
+				//$val = (in_array($val, array_keys($this->getStatus( $this->userlevel ))) ) ? $val : "all"; //irmtfan no need to check if status is empty or not
+				//if ($val === "all" && !$this->is_multiple) $val = ""; irmtfan commented because it is done in sort
+				// END irmtfan to accept multiple status
+				break;
+
+			default:
+				break;
+		}
+
+		return $val;
+	}
+
+	/**
+	 * @param array $vars
+	 */
+	public function setVars(array $vars = [])
+	{
+		$this->init();
+
+		foreach ($vars as $var => $val) {
+			if (!in_array($var, $this->args)) {
+				continue;
+			}
+			$this->vars[$var] = $this->setVar($var, $val);
+		}
+		$this->parseVars();
+	}
+
+	/**
+	 * @param null $status
+	 */
+	public function myParseStatus($status = null)
+	{
+		switch ($status) {
+			case 'digest':
+				$this->query['where'][] = 't.topic_digest = 1';
+				break;
+
+			case 'undigest':
+				$this->query['where'][] = 't.topic_digest = 0';
+				break;
+
+			case 'sticky':
+				$this->query['where'][] = 't.topic_sticky = 1';
+				break;
+
+			case 'unsticky':
+				$this->query['where'][] = 't.topic_sticky = 0';
+				break;
+
+			case 'lock':
+				$this->query['where'][] = 't.topic_status = 1';
+				break;
+
+			case 'unlock':
+				$this->query['where'][] = 't.topic_status = 0';
+				break;
+
+			case 'poll':
+				$this->query['where'][] = 't.topic_haspoll = 1';
+				break;
+
+			case 'unpoll':
+				$this->query['where'][] = 't.topic_haspoll = 0';
+				break;
+
+			case 'voted':
+				$this->query['where'][] = 't.votes > 0';
+				break;
+
+			case 'unvoted':
+				$this->query['where'][] = 't.votes < 1';
+				break;
+
+			case 'replied':
+				$this->query['where'][] = 't.topic_replies > 0';
+				break;
+
+			case 'unreplied':
+				$this->query['where'][] = 't.topic_replies < 1';
+				break;
+
+			case 'viewed':
+				$this->query['where'][] = 't.topic_views > 0';
+				break;
+
+			case 'unviewed':
+				$this->query['where'][] = 't.topic_views < 1';
+				break;
+
+			case 'read':
+				// Skip
+				if (empty($this->config['read_mode'])) {
+					// Use database
+				} elseif (2 == $this->config['read_mode']) {
+					// START irmtfan use read_uid to find the unread posts when the user is logged in
+					$read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
+					if (!empty($read_uid)) {
+						$this->query['join'][]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_reads_topic') . ' AS r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
+						$this->query['where'][] = 'r.post_id = t.topic_last_post_id';
+					} else {
+					}
+					// END irmtfan change criteria to get from uid p.uid = last post submit user id
+					// User cookie
+				} elseif (1 == $this->config['read_mode']) {
+					// START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
+					$startdate = !empty($this->vars['since']) ? (time() - newbbGetSinceTime($this->vars['since'])) : 0;
+					if ($lastvisit = max($GLOBALS['last_visit'], $startdate)) {
+						$readmode1query = '';
+						if ($lastvisit > $startdate) {
+							$readmode1query = 'p.post_time < ' . $lastvisit;
+						}
+						$topics         = [];
+						$topic_lastread = newbbGetCookie('LT', true);
+						if (count($topic_lastread) > 0) {
+							foreach ($topic_lastread as $id => $time) {
+								if ($time > $lastvisit) {
+									$topics[] = $id;
+								}
+							}
+						}
+						if (count($topics) > 0) {
+							$topicquery = ' t.topic_id IN (' . implode(',', $topics) . ')';
+							// because it should be OR
+							$readmode1query = !empty($readmode1query) ? '(' . $readmode1query . ' OR ' . $topicquery . ')' : $topicquery;
+						}
+						$this->query['where'][] = $readmode1query;
+					}
+					// END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
+				}
+				break;
+
+			case 'unread':
+				// Skip
+				if (empty($this->config['read_mode'])) {
+					// Use database
+				} elseif (2 == $this->config['read_mode']) {
+					// START irmtfan use read_uid to find the unread posts when the user is logged in
+					$read_uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
+					if (!empty($read_uid)) {
+						$this->query['join'][]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_reads_topic') . ' AS r ON r.read_item = t.topic_id AND r.uid = ' . $read_uid . ' ';
+						$this->query['where'][] = '(r.read_id IS NULL OR r.post_id < t.topic_last_post_id)';
+					} else {
+					}
+					// END irmtfan change criteria to get from uid p.uid = last post submit user id
+					// User cookie
+				} elseif (1 == $this->config['read_mode']) {
+					// START irmtfan fix read_mode = 1 bugs - for all users (member and anon)
+					$startdate = !empty($this->vars['since']) ? (time() - newbbGetSinceTime($this->vars['since'])) : 0;
+					if ($lastvisit = max($GLOBALS['last_visit'], $startdate)) {
+						if ($lastvisit > $startdate) {
+							$this->query['where'][] = 'p.post_time > ' . $lastvisit;
+						}
+						$topics         = [];
+						$topic_lastread = newbbGetCookie('LT', true);
+						if (count($topic_lastread) > 0) {
+							foreach ($topic_lastread as $id => $time) {
+								if ($time > $lastvisit) {
+									$topics[] = $id;
+								}
+							}
+						}
+						if (count($topics) > 0) {
+							$this->query['where'][] = ' t.topic_id NOT IN (' . implode(',', $topics) . ')';
+						}
+					}
+					// END irmtfan fix read_mode = 1 bugs - for all users (member and anon)
+				}
+				break;
+
+			case 'pending':
+				if ($this->userlevel < 2) {
+					$this->noperm = true;
+				} else {
+					$this->query['where'][] = 't.approved = 0';
+				}
+				break;
+
+			case 'deleted':
+				if ($this->userlevel < 2) {
+					$this->noperm = true;
+				} else {
+					$this->query['where'][] = 't.approved = -1';
+				}
+				break;
+
+			case 'all': // For viewall.php; do not display sticky topics at first
+			case 'active': // same as 'all'
+				$this->query['where'][] = 't.approved = 1';
+				break;
+
+			default: // irmtfan do nothing
+				break;
+		}
+	}
+
+	/**
+	 * @param $var
+	 * @param $val
+	 */
+	public function parseVar($var, $val)
+	{
+		switch ($var) {
+			case 'forum':
+				/** @var Newbb\ForumHandler $forumHandler */
+				$forumHandler = Newbb\Helper::getInstance()->getHandler('Forum');
+				// START irmtfan - get forum Ids by values. parse positive values to forum IDs and negative values to category IDs. value=0 => all valid forums
+				// Get accessible forums
+				$accessForums = $forumHandler->getIdsByValues(array_map('intval', @explode('|', $val)));
+				// Filter specified forums if any
+				//if (!empty($val) && $_forums = @explode('|', $val)) {
+				//$accessForums = array_intersect($accessForums, array_map('intval', $_forums));
+				//}
+				$this->vars['forum'] = $this->setVar('forum', $accessForums);
+				// END irmtfan - get forum Ids by values. parse positive values to forum IDs and negative values to category IDs. value=0 => all valid forums
+
+				if (empty($accessForums)) {
+					$this->noperm = true;
+				// irmtfan - it just return return the forum_id only when the forum_id is the first allowed forum - no need for this code implode is enough removed.
+					//} elseif (count($accessForums) === 1) {
+					//$this->query["where"][] = "t.forum_id = " . $accessForums[0];
+				} else {
+					$this->query['where'][] = 't.forum_id IN ( ' . implode(', ', $accessForums) . ' )';
+				}
+				break;
+
+			case 'uid': // irmtfan add multi topic poster
+				if (-1 !== $val) {
+					$val                    = implode(',', array_map('intval', explode(',', $val)));
+					$this->query['where'][] = 't.topic_poster IN ( ' . $val . ' )';
+				}
+				break;
+			case 'lastposter': // irmtfan add multi lastposter
+				if (-1 !== $val) {
+					$val                    = implode(',', array_map('intval', explode(',', $val)));
+					$this->query['where'][] = 'p.uid IN ( ' . $val . ' )';
+				}
+				break;
+
+			case 'since':
+				if (!empty($val)) {
+					// START irmtfan if unread && read_mode = 1 and last_visit > startdate do not add where query | to accept multiple status
+					$startdate = time() - newbbGetSinceTime($val);
+					if (in_array('unread', explode(',', $this->vars['status'], true)) && 1 == $this->config['read_mode']
+						&& $GLOBALS['last_visit'] > $startdate) {
+						break;
+					}
+					// irmtfan digest_time | to accept multiple status
+					if (in_array('digest', explode(',', $this->vars['status'], true))) {
+						$this->query['where'][] = 't.digest_time > ' . $startdate;
+					}
+					// irmtfan - should be >= instead of =
+					$this->query['where'][] = 'p.post_time >= ' . $startdate;
+					// END irmtfan if unread && read_mode = 1 and last_visit > startdate do not add where query
+				}
+				break;
+
+			case 'type':
+				if (!empty($val)) {
+					$this->query['where'][] = 't.type_id = ' . $val;
+				}
+				break;
+
+			case 'status':
+				// START irmtfan to accept multiple status
+				$val = explode(',', $val);
+				// irmtfan - add 'all' to always parse t.approved = 1
+				if (0 === count(array_intersect($val, ['all', 'active', 'pending', 'deleted']))) {
+					$val[] = 'all';
+				}
+				foreach ($val as $key => $status) {
+					$this->myParseStatus($status);
+				}
+				// END irmtfan to accept multiple status
+				break;
+
+			case 'sort':
+				if ($sort = $this->getSort($val, 'sort')) {
+					$this->query['sort'][] = $sort . (empty($this->vars['order']) ? ' DESC' : ' ASC');
+				} else { // irmtfan if sort is not in the list
+					$this->query['sort'][] = 't.topic_last_post_id' . (empty($this->vars['order']) ? ' DESC' : ' ASC');
+				}
+				break;
+
+			default:
+				break;
+		}
+	}
+
+	/**
+	 * @return bool
+	 */
+	public function parseVars()
+	{
+		static $parsed;
+		// irmtfan - force to parse vars (run against static vars)
+		if (null !== $parsed && !$this->force) {
+			return true;
+		}
+
+		if (!isset($this->vars['forum'])) {
+			$this->vars['forum'] = null;
+		}
+		//irmtfan parse status for rendering topic correctly - if empty($_GET(status)) it will show all topics include deleted and pendings. 'all' instead of all
+		if (!isset($this->vars['status'])) {
+			$this->vars['status'] = 'all';
+		}
+		// irmtfan if sort is not set or is empty get a default sort- if empty($_GET(sort)) | if sort=null eg: /list.topic.php?sort=
+		if (empty($this->vars['sort'])) {
+			$this->vars['sort'] = 'lastpost';
+		} // use lastpost instead of sticky
+
+		foreach ($this->vars as $var => $val) {
+			$this->parseVar($var, $val);
+			if (empty($val)) {
+				unset($this->vars[$var]);
+			}
+		}
+		$parsed = true;
+
+		return true;
+	}
+
+	/**
+	 * @param  null $header
+	 * @param  null $var
+	 * @return array|null
+	 */
+	public function getSort($header = null, $var = null)
+	{
+		$headers = [
+			'topic'           => [
+				'title' => _MD_NEWBB_TOPICS,
+				'sort'  => 't.topic_title'
+			],
+			'forum'           => [
+				'title' => _MD_NEWBB_FORUM,
+				'sort'  => 't.forum_id'
+			],
+			'poster'          => [
+				'title' => _MD_NEWBB_TOPICPOSTER, /*irmtfan _MD_NEWBB_POSTER to _MD_NEWBB_TOPICPOSTER*/
+				'sort'  => 't.topic_poster'
+			],
+			'replies'         => [
+				'title' => _MD_NEWBB_REPLIES,
+				'sort'  => 't.topic_replies'
+			],
+			'views'           => [
+				'title' => _MD_NEWBB_VIEWS,
+				'sort'  => 't.topic_views'
+			],
+			'lastpost'        => [ // irmtfan show topic_page_jump_icon smarty
+								   'title' => _MD_NEWBB_LASTPOST,
+								   /*irmtfan _MD_NEWBB_DATE to _MD_NEWBB_LASTPOSTTIME again change to _MD_LASTPOST*/
+								   'sort'  => 't.topic_last_post_id'
+			],
+			// START irmtfan add more sorts
+			'lastposttime'    => [ // irmtfan same as lastpost
+								   'title' => _MD_NEWBB_LASTPOSTTIME,
+								   'sort'  => 't.topic_last_post_id'
+			],
+			'lastposter'      => [ // irmtfan
+								   'title' => _MD_NEWBB_POSTER,
+								   'sort'  => 'p.uid',// poster uid
+			],
+			'lastpostmsgicon' => [ // irmtfan
+								   'title' => _MD_NEWBB_MESSAGEICON,
+								   'sort'  => 'p.icon',// post message icon
+			],
+			'ratings'         => [
+				'title' => _MD_NEWBB_RATINGS,
+				'sort'  => 't.rating', // irmtfan t.topic_rating to t.rating
+			],
+			'votes'           => [
+				'title' => _MD_NEWBB_VOTES,
+				'sort'  => 't.votes'
+			],
+			'publish'         => [
+				'title' => _MD_NEWBB_TOPICTIME,
+				'sort'  => 't.topic_id'
+			],
+			'digest'          => [
+				'title' => _MD_NEWBB_DIGEST,
+				'sort'  => 't.digest_time'
+			],
+			'sticky'          => [
+				'title' => _MD_NEWBB_STICKY,
+				'sort'  => 't.topic_sticky'
+			],
+			'lock'            => [
+				'title' => _MD_NEWBB_LOCK,
+				'sort'  => 't.topic_status'
+			],
+			'poll'            => [
+				'title' => _MD_NEWBB_POLL_POLL,
+				'sort'  => 't.poll_id'
+			]
+		];
+		$types   = $this->getTypes();
+		if (!empty($types)) {
+			$headers['type'] = [
+				'title' => _MD_NEWBB_TYPE,
+				'sort'  => 't.type_id'
+			];
+		}
+		if (2 == $this->userlevel) {
+			$headers['approve'] = [
+				'title' => _MD_NEWBB_APPROVE,
+				'sort'  => 't.approved'
+			];
+		}
+		// END irmtfan add more sorts
+		if (empty($header) && empty($var)) {
+			return $headers;
+		}
+		if (!empty($var) && !empty($header)) {
+			return @$headers[$header][$var];
+		}
+		if (empty($var)) {
+			return @$headers[$header];
+		}
+		$ret = null;
+		foreach (array_keys($headers) as $key) {
+			$ret[$key] = @$headers[$key][$var];
+		}
+
+		return $ret;
+	}
+
+	// START irmtfan add Display topic headers function
+
+	/**
+	 * @param  null $header
+	 * @return array
+	 */
+	public function getHeader($header = null)
+	{
+		$headersSort = $this->getSort('', 'title');
+		// additional headers - important: those cannot be in sort anyway
+		$headers = array_merge($headersSort, [
+			'attachment' => _MD_NEWBB_TOPICSHASATT, // show attachment smarty
+			'read'       => _MD_NEWBB_MARK_UNREAD . '|' . _MD_NEWBB_MARK_READ, // read/unread show topic_folder smarty
+			'pagenav'    => _MD_NEWBB_PAGENAV_DISPLAY, // show topic_page_jump smarty - sort by topic_replies?
+		]);
+
+		return $this->getFromKeys($headers, $header);
+	}
+
+	// END irmtfan add Display topic headers function
+
+	/**
+	 * @param  null $type
+	 * @param  null $status
+	 * @return array
+	 */
+	public function getStatus($type = null, $status = null)
+	{
+		$links       = [
+			//""            => "", /* irmtfan remove empty array */
+			'all'       => _ALL,
+			'digest'    => _MD_NEWBB_DIGEST,
+			'undigest'  => _MD_NEWBB_UNDIGEST, // irmtfan add
+			'sticky'    => _MD_NEWBB_STICKY, // irmtfan add
+			'unsticky'  => _MD_NEWBB_UNSTICKY, // irmtfan add
+			'lock'      => _MD_NEWBB_LOCK, // irmtfan add
+			'unlock'    => _MD_NEWBB_UNLOCK, // irmtfan add
+			'poll'      => _MD_NEWBB_TOPICHASPOLL, // irmtfan add
+			'unpoll'    => _MD_NEWBB_TOPICHASNOTPOLL, // irmtfan add
+			'voted'     => _MD_NEWBB_VOTED, // irmtfan add
+			'unvoted'   => _MD_NEWBB_UNVOTED, // irmtfan add
+			'viewed'    => _MD_NEWBB_VIEWED, // irmtfan add
+			'unviewed'  => _MD_NEWBB_UNVIEWED, // irmtfan add
+			'replied'   => _MD_NEWBB_REPLIED, // irmtfan add
+			'unreplied' => _MD_NEWBB_UNREPLIED,
+			'read'      => _MD_NEWBB_READ, // irmtfan add
+			'unread'    => _MD_NEWBB_UNREAD
+		];
+		$links_admin = [
+			'active'  => _MD_NEWBB_TYPE_ADMIN,
+			'pending' => _MD_NEWBB_TYPE_PENDING,
+			'deleted' => _MD_NEWBB_TYPE_DELETED
+		];
+
+		// all status, for admin
+		if ($type > 1) {
+			$links = array_merge($links, $links_admin);// irmtfan to accept multiple status
+		}
+
+		return $this->getFromKeys($links, $status); // irmtfan to accept multiple status
+	}
+
+	/**
+	 * @param \Smarty $xoopsTpl
+	 * @throws \RuntimeException
+	 */
+	public function buildSelection(\Smarty $xoopsTpl)
+	{
+		$selection         = ['action' => $this->page];
+		$selection['vars'] = $this->vars;
+		require_once  dirname(__DIR__) . '/include/functions.forum.php';
+		$forum_selected     = empty($this->vars['forum']) ? null : explode('|', @$this->vars['forum']);
+		$selection['forum'] = '<select name="forum[]" multiple="multiple">';
+		$selection['forum'] .= '<option value="0">' . _MD_NEWBB_ALL . '</option>';
+		$selection['forum'] .= newbbForumSelectBox($forum_selected);
+		$selection['forum'] .= '</select>';
+
+		$sort_selected     = $this->vars['sort'];
+		$sorts             = $this->getSort('', 'title');
+		$selection['sort'] = "<select name='sort'>";
+		if (!is_array($sorts)) {
+			throw new \RuntimeException('$sorts must be an array.');
+		}
+		foreach ($sorts as $sort => $title) {
+			$selection['sort'] .= "<option value='" . $sort . "' " . (($sort == $sort_selected) ? " selected='selected'" : '') . '>' . $title . '</option>';
+		}
+		$selection['sort'] .= '</select>';
+
+		$selection['order'] = "<select name='order'>";
+		$selection['order'] .= "<option value='0' " . (empty($this->vars['order']) ? " selected='selected'" : '') . '>' . _DESCENDING . '</option>';
+		$selection['order'] .= "<option value='1' " . (!empty($this->vars['order']) ? " selected='selected'" : '') . '>' . _ASCENDING . '</option>';
+		$selection['order'] .= '</select>';
+
+		$since              = isset($this->vars['since']) ? $this->vars['since'] : $this->config['since_default'];
+		$selection['since'] = newbbSinceSelectBox($since);
+
+		$xoopsTpl->assign_by_ref('selection', $selection);
+	}
+
+	/**
+	 * @param \Smarty $xoopsTpl
+	 */
+	public function buildSearch(\Smarty $xoopsTpl)
+	{
+		$search             = [];
+		$search['forum']    = @$this->vars['forum'];
+		$search['since']    = @$this->vars['since'];
+		$search['searchin'] = 'both';
+
+		$xoopsTpl->assign_by_ref('search', $search);
+	}
+
+	/**
+	 * @param \Smarty $xoopsTpl
+	 * @throws \RuntimeException
+	 */
+	public function buildHeaders(\Smarty $xoopsTpl)
+	{
+		$args = [];
+		foreach ($this->vars as $var => $val) {
+			if ('sort' === $var || 'order' === $var) {
+				continue;
+			}
+			$args[] = "{$var}={$val}";
+		}
+
+		$headers = $this->getSort('', 'title');
+		if (!is_array($headers)) {
+			throw new \RuntimeException('$headers must be an array.');
+		}
+		foreach ($headers as $header => $title) {
+			$_args = ["sort={$header}"];
+			if (@$this->vars['sort'] == $header) {
+				$_args[] = 'order=' . ((@$this->vars['order'] + 1) % 2);
+			}
+			$headers_data[$header]['title'] = $title;
+			$headers_data[$header]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
+		}
+		$xoopsTpl->assign_by_ref('headers', $headers_data);
+	}
+
+	/**
+	 * @param \Smarty $xoopsTpl
+	 */
+	public function buildFilters(\Smarty $xoopsTpl)
+	{
+		$args = [];
+		foreach ($this->vars as $var => $val) {
+			if ('status' === $var) {
+				continue;
+			}
+			$args[] = "{$var}={$val}";
+		}
+
+		$links = $this->getStatus($this->userlevel);
+
+		$status = [];
+		foreach ($links as $link => $title) {
+			$_args                  = ["status={$link}"];
+			$status[$link]['title'] = $title;
+			$status[$link]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
+		}
+		$xoopsTpl->assign_by_ref('filters', $status);
+	}
+
+	/**
+	 * @param  null $type_id
+	 * @return mixed
+	 */
+	public function getTypes($type_id = null)
+	{
+		static $types;
+		if (!isset($types)) {
+			/** @var Newbb\TypeHandler $typeHandler */
+			$typeHandler = Newbb\Helper::getInstance()->getHandler('Type');
+
+			$types = $typeHandler->getByForum(explode('|', @$this->vars['forum']));
+		}
+
+		if (empty($type_id)) {
+			return $types;
+		}
+
+		return @$types[$type_id];
+	}
+
+	/**
+	 * @param  \Smarty $xoopsTpl
+	 * @return bool
+	 */
+	public function buildTypes(\Smarty $xoopsTpl)
+	{
+		$status = '';
+		if (!$types = $this->getTypes()) {
+			return true;
+		}
+
+		$args = [];
+		foreach ($this->vars as $var => $val) {
+			if ('type' === $var) {
+				continue;
+			}
+			$args[] = "{$var}={$val}";
+		}
+
+		foreach ($types as $id => $type) {
+			$_args                = ["type={$id}"];
+			$status[$id]['title'] = $type['type_name'];
+			$status[$id]['link']  = $this->page . '?' . implode('&amp;', array_merge($args, $_args));
+		}
+		$xoopsTpl->assign_by_ref('types', $status);
+	}
+
+	/**
+	 * @param  \Smarty $xoopsTpl
+	 * @return bool
+	 */
+	public function buildCurrent(\Smarty $xoopsTpl)
+	{
+		if (empty($this->vars['status']) && !$this->is_multiple) {
+			return true;
+		}
+
+		$args = [];
+		foreach ($this->vars as $var => $val) {
+			$args[] = "{$var}={$val}";
+		}
+
+		$status          = [];
+		$status['title'] = implode(',', $this->getStatus($this->userlevel, $this->vars['status'])); // irmtfan to accept multiple status
+		//$status['link'] = $this->page.(empty($this->vars['status']) ? '' : '?status='.$this->vars['status']);
+		$status['link'] = $this->page . (empty($args) ? '' : '?' . implode('&amp;', $args));
+
+		$xoopsTpl->assign_by_ref('current', $status);
+	}
+
+	/**
+	 * @param \Smarty $xoopsTpl
+	 */
+	public function buildPagenav(\Smarty $xoopsTpl)
+	{
+		$count_topic = $this->getCount();
+		if ($count_topic > $this->config['topics_per_page']) {
+			$args = [];
+			foreach ($this->vars as $var => $val) {
+				if ('start' === $var) {
+					continue;
+				}
+				$args[] = "{$var}={$val}";
+			}
+			require_once $GLOBALS['xoops']->path('class/pagenav.php');
+			$nav = new \XoopsPageNav($count_topic, $this->config['topics_per_page'], @$this->vars['start'], 'start', implode('&amp;', $args));
+			if (isset($GLOBALS['xoopsModuleConfig']['do_rewrite'])) {
+				$nav->url = formatURL(Request::getString('SERVER_NAME', '', 'SERVER')) . ' /' . $nav->url;
+			}
+			if ('select' === $this->config['pagenav_display']) {
+				$navi = $nav->renderSelect();
+			} elseif ('image' === $this->config['pagenav_display']) {
+				$navi = $nav->renderImageNav(4);
+			} else {
+				$navi = $nav->renderNav(4);
+			}
+			$xoopsTpl->assign('pagenav', $navi);
+		} else {
+			$xoopsTpl->assign('pagenav', '');
+		}
+	}
+
+	/**
+	 * @return int
+	 */
+	public function getCount()
+	{
+		if ($this->noperm) {
+			return 0;
+		}
+
+		$selects = [];
+		$froms   = [];
+		$joins   = [];
+		$wheres  = [];
+
+		// topic fields
+		$selects[] = 'COUNT(*)';
+
+		$froms[]  = $this->handler->db->prefix('newbb_topics') . ' AS t ';
+		$joins[]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts') . ' AS p ON p.post_id = t.topic_last_post_id';
+		$wheres[] = '1 = 1';
+
+		$sql = '    SELECT ' . implode(', ', $selects) . '     FROM ' . implode(', ', $froms) . '        ' . implode(' ', $joins) . (!empty($this->query['join']) ? '        ' . implode(' ', $this->query['join']) : '') . // irmtfan bug fix: Undefined index: join when post_excerpt = 0
+			   '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']);
+
+		if (!$result = $this->handler->db->query($sql)) {
+			return 0;
+		}
+		list($count) = $this->handler->db->fetchRow($result);
+
+		return $count;
+	}
+
+	/**
+	 * @param  \Smarty $xoopsTpl
+	 * @return array|void
+	 */
+	public function renderTopics(\Smarty $xoopsTpl = null)
+	{
+		$myts = \MyTextSanitizer::getInstance(); // irmtfan Instanciate
+
+		$ret = [];
+		//$this->parseVars();
+
+		if ($this->noperm) {
+			if (is_object($xoopsTpl)) {
+				$xoopsTpl->assign_by_ref('topics', $ret);
+
+				return;
+			}
+
+			return $ret;
+		}
+
+		$selects = [];
+		$froms   = [];
+		$joins   = [];
+		$wheres  = [];
+
+		// topic fields
+		$selects[] = 't.*';
+		// post fields
+		$selects[] = 'p.post_time as last_post_time, p.poster_name as last_poster_name, p.icon, p.post_id, p.uid';
+
+		$froms[]  = $this->handler->db->prefix('newbb_topics') . ' AS t ';
+		$joins[]  = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts') . ' AS p ON p.post_id = t.topic_last_post_id';
+		$wheres[] = '1 = 1';
+
+		if (!empty($this->config['post_excerpt'])) {
+			$selects[]             = 'p.post_karma, p.require_reply, pt.post_text';
+			$this->query['join'][] = 'LEFT JOIN ' . $this->handler->db->prefix('newbb_posts_text') . ' AS pt ON pt.post_id = t.topic_last_post_id';
+		}
+		//if (empty($this->query["sort"])) $this->query["sort"][] = 't.topic_last_post_id DESC'; // irmtfan commented no need
+
+		$sql = '    SELECT ' . implode(', ', $selects) . '     FROM ' . implode(', ', $froms) . '        ' . implode(' ', $joins) . (!empty($this->query['join']) ? '        ' . implode(' ', $this->query['join']) : '') . // irmtfan bug fix: Undefined index join when post_excerpt = 0
+			   '     WHERE ' . implode(' AND ', $wheres) . '        AND ' . @implode(' AND ', @$this->query['where']) . '     ORDER BY ' . implode(', ', $this->query['sort']);
+
+		if (!$result = $this->handler->db->query($sql, $this->config['topics_per_page'], @$this->vars['start'])) {
+			if (is_object($xoopsTpl)) {
+				$xoopsTpl->assign_by_ref('topics', $ret);
+
+				return;
+			}
+
+			return $ret;
+		}
+
+		require_once  dirname(__DIR__) . '/include/functions.render.php';
+		require_once  dirname(__DIR__) . '/include/functions.session.php';
+		require_once  dirname(__DIR__) . '/include/functions.time.php';
+		require_once  dirname(__DIR__) . '/include/functions.read.php';
+		require_once  dirname(__DIR__) . '/include/functions.topic.php';
+
+		$sticky    = 0;
+		$topics    = [];
+		$posters   = [];
+		$reads     = [];
+		$types     = [];
+		$forums    = [];
+		$anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
+
+		while (false !== ($myrow = $this->handler->db->fetchArray($result))) {
+			if ($myrow['topic_sticky']) {
+				++$sticky;
+			}
+
+			// ------------------------------------------------------
+			// START irmtfan remove topic_icon hardcode smarty
+			// topic_icon: just regular topic_icon
+			if (!empty($myrow['icon'])) {
+				$topic_icon = '<img align="middle" src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($myrow['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
+			} else {
+				$topic_icon = '<img align="middle" src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" />';
+			}
+			// END irmtfan remove topic_icon hardcode smarty
+
+			// ------------------------------------------------------
+			// rating_img
+			$rating = number_format($myrow['rating'] / 2, 0);
+			// irmtfan - add alt key for rating
+			if ($rating < 1) {
+				$rating_img = newbbDisplayImage('blank');
+			} else {
+				$rating_img = newbbDisplayImage('rate' . $rating, constant('_MD_NEWBB_RATE' . $rating));
+			}
+
+			// ------------------------------------------------------
+			// topic_page_jump
+			$topic_page_jump      = '';
+			$topic_page_jump_icon = '';
+			$totalpages           = ceil(($myrow['topic_replies'] + 1) / $this->config['posts_per_page']);
+			if ($totalpages > 1) {
+				$topic_page_jump .= '&nbsp;&nbsp;';
+				$append          = false;
+				for ($i = 1; $i <= $totalpages; ++$i) {
+					if ($i > 3 && $i < $totalpages) {
+						if (!$append) {
+							$topic_page_jump .= '...';
+							$append          = true;
+						}
+					} else {
+						$topic_page_jump .= '[<a href="' . XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'] . '&amp;start=' . (($i - 1) * $this->config['posts_per_page']) . '">' . $i . '</a>]';
+						// irmtfan remove here and move
+						//$topic_page_jump_icon = "<a href='" . XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=" . $myrow['topic_id'] . "&amp;start=" . (($i - 1) * $this->config['posts_per_page']) . "" . "'>" . newbbDisplayImage('document',_MD_NEWBB_GOTOLASTPOST) . '</a>';
+					}
+				}
+			}
+			// irmtfan - move here for both topics with and without pages - change topic_id to post_id
+			$topic_page_jump_icon = "<a href='" . XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $myrow['topic_last_post_id'] . '' . "'>" . newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST) . '</a>';
+
+			// ------------------------------------------------------
+			// => topic array
+
+			$topic_title = $myts->htmlSpecialChars($myrow['topic_title']);
+			// irmtfan use topic_title_excerpt for block topic title length
+			$topic_title_excerpt = $topic_title;
+			if (!empty($this->config['topic_title_excerpt'])) {
+				$topic_title_excerpt = xoops_substr($topic_title, 0, $this->config['topic_title_excerpt']);
+			}
+			// irmtfan hardcode class commented
+			//if ($myrow['topic_digest']) {
+			//   $topic_title = "<span class='digest'>" . $topic_title . "</span>";
+			//}
+
+			if (empty($this->config['post_excerpt'])) {
+				$topic_excerpt = '';
+			} elseif (($myrow['post_karma'] > 0 || $myrow['require_reply'] > 0) && !newbbIsAdmin($myrow['forum_id'])) {
+				$topic_excerpt = '';
+			} else {
+				$topic_excerpt = xoops_substr(newbbHtml2text($myts->displayTarea($myrow['post_text'])), 0, $this->config['post_excerpt']);
+				$topic_excerpt = str_replace('[', '&#91;', $myts->htmlSpecialChars($topic_excerpt));
+			}
+
+			$topics[$myrow['topic_id']] = [
+				'topic_id'               => $myrow['topic_id'],
+				'topic_icon'             => $topic_icon,
+				'type_id'                => $myrow['type_id'],
+				'topic_title_excerpt'    => $topic_title_excerpt,
+				//irmtfan use topic_title_excerpt
+				//'topic_link'    => XOOPS_URL . '/modules/newbb/viewtopic.php?topic_id=' . $myrow['topic_id'], // . '&amp;forum=' . $myrow['forum_id'], // irmtfan comment
+				'topic_link'             => 'viewtopic.php?topic_id=' . $myrow['topic_id'],
+				// irmtfan remove hardcode link
+				'rating_img'             => $rating_img,
+				'votes'                  => $myrow['votes'],
+				//irmtfan added
+				'topic_page_jump'        => $topic_page_jump,
+				'topic_page_jump_icon'   => $topic_page_jump_icon,
+				'topic_replies'          => $myrow['topic_replies'],
+				'topic_poster_uid'       => $myrow['topic_poster'],
+				'topic_poster_name'      => !empty($myrow['poster_name']) ? $myts->htmlSpecialChars($myrow['poster_name']) : $anonymous,
+				'topic_views'            => $myrow['topic_views'],
+				'topic_time'             => newbbFormatTimestamp($myrow['topic_time']),
+				'topic_last_post_id'     => $myrow['topic_last_post_id'],
+				//irmtfan added
+				'topic_last_posttime'    => newbbFormatTimestamp($myrow['last_post_time']),
+				'topic_last_poster_uid'  => $myrow['uid'],
+				'topic_last_poster_name' => !empty($myrow['last_poster_name']) ? $myts->htmlSpecialChars($myrow['last_poster_name']) : $anonymous,
+				'topic_forum'            => $myrow['forum_id'],
+				'topic_excerpt'          => $topic_excerpt,
+				'sticky'                 => $myrow['topic_sticky'] ? newbbDisplayImage('topic_sticky', _MD_NEWBB_TOPICSTICKY) : '',
+				// irmtfan bug fixed
+				'lock'                   => $myrow['topic_status'] ? newbbDisplayImage('topic_locked', _MD_NEWBB_TOPICLOCK) : '',
+				//irmtfan added
+				'digest'                 => $myrow['topic_digest'] ? newbbDisplayImage('topic_digest', _MD_NEWBB_TOPICDIGEST) : '',
+				//irmtfan added
+				'poll'                   => $myrow['topic_haspoll'] ? newbbDisplayImage('poll', _MD_NEWBB_TOPICHASPOLL) : '',
+				//irmtfan added
+				'approve'                => $myrow['approved'],
+				//irmtfan added
+			];
+
+			/* users */
+			$posters[$myrow['topic_poster']] = 1;
+			$posters[$myrow['uid']]          = 1;
+			// reads
+			if (!empty($this->config['read_mode'])) {
+				$reads[$myrow['topic_id']] = (1 == $this->config['read_mode']) ? $myrow['last_post_time'] : $myrow['topic_last_post_id'];
+			}
+			// types
+			if (!empty($myrow['type_id'])) {
+				//$types[$myrow['type_id']] = 1;
+			}
+			// forums
+			$forums[$myrow['forum_id']] = 1;
+		}
+		$posters_name = newbbGetUnameFromIds(array_keys($posters), $this->config['show_realname'], true);
+		$topic_isRead = newbbIsRead('topic', $reads);
+		/*
         $type_list = array();
         if (count($types) > 0) {
             $typeHandler =  Newbb\Helper::getInstance()->getHandler('Type');
             $type_list = $typeHandler->getAll(new \Criteria("type_id", "(".implode(", ", array_keys($types)).")", "IN"), null, false);
         }
         */
-        $type_list = $this->getTypes();
-        /** @var Newbb\ForumHandler $forumHandler */
-        $forumHandler = Newbb\Helper::getInstance()->getHandler('Forum');
-
-        if (count($forums) > 0) {
-            $forum_list = $forumHandler->getAll(new \Criteria('forum_id', '(' . implode(', ', array_keys($forums)) . ')', 'IN'), ['forum_name', 'hot_threshold'], false);
-        } else {
-            $forum_list = $forumHandler->getAll();
-        }
-
-        foreach (array_keys($topics) as $id) {
-            $topics[$id]['topic_read']       = empty($topic_isRead[$id]) ? 0 : 1; // add topic-read/topic-new smarty variable
-            $topics[$id]['topic_forum_link'] = '<a href="' . XOOPS_URL . '/modules/newbb/viewforum.php?forum=' . $topics[$id]['topic_forum'] . '">' . $forum_list[$topics[$id]['topic_forum']]['forum_name'] . '</a>';
-
-            //irmtfan use topic_title_excerpt -- add else
-            if (!empty($topics[$id]['type_id']) && isset($type_list[$topics[$id]['type_id']])) {
-                $topics[$id]['topic_title'] = getTopicTitle($topics[$id]['topic_title_excerpt'], $type_list[$topics[$id]['type_id']]['type_name'], $type_list[$topics[$id]['type_id']]['type_color']);
-            } else {
-                $topics[$id]['topic_title'] = $topics[$id]['topic_title_excerpt'];
-            }
-            $topics[$id]['topic_poster']      = !empty($posters_name[$topics[$id]['topic_poster_uid']]) ? $posters_name[$topics[$id]['topic_poster_uid']] : $topics[$id]['topic_poster_name'];
-            $topics[$id]['topic_last_poster'] = !empty($posters_name[$topics[$id]['topic_last_poster_uid']]) ? $posters_name[$topics[$id]['topic_last_poster_uid']] : $topics[$id]['topic_last_poster_name'];
-            // ------------------------------------------------------
-            // START irmtfan remove hardcodes from topic_folder smarty
-            // topic_folder: priority: newhot -> hot/new -> regular
-            //list($topic_status, $topic_digest, $topic_replies) = $topics[$id]["stats"]; irmtfan
-            // START irmtfan - add topic_folder_text for alt
-            //if ($topics[$id]["lock"] === 1) {
-            //    $topic_folder = 'topic_locked';
-            //    $topic_folder_text = _MD_NEWBB_TOPICLOCKED;
-            //} else {
-            //if ($topic_digest) {
-            //    $topic_folder = 'topic_digest';
-            //    $topic_folder_text = _MD_NEWBB_TOPICDIGEST;
-            if ($topics[$id]['topic_replies'] >= $forum_list[$topics[$id]['topic_forum']]['hot_threshold']) {
-                $topic_folder      = empty($topic_isRead[$id]) ? 'topic_hot_new' : 'topic_hot';
-                $topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_MORETHAN : _MD_NEWBB_MORETHAN2;
-            } else {
-                $topic_folder      = empty($topic_isRead[$id]) ? 'topic_new' : 'topic';
-                $topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_NEWPOSTS : _MD_NEWBB_NONEWPOSTS;
-            }
-            //}
-            // END irmtfan remove hardcodes from topic_folder smarty
-            $topics[$id]['topic_folder'] = newbbDisplayImage($topic_folder, $topic_folder_text);
-            // END irmtfan - add topic_folder_text for alt
-
-            unset($topics[$id]['topic_poster_name'], $topics[$id]['topic_last_poster_name']);// irmtfan remove $topics[$id]["stats"] because it is not exist now
-        }
-
-        if (count($topics) > 0) {
-            $sql = ' SELECT DISTINCT topic_id FROM ' . $this->handler->db->prefix('newbb_posts') . " WHERE attachment != ''" . ' AND topic_id IN (' . implode(',', array_keys($topics)) . ')';
-            if ($result = $this->handler->db->query($sql)) {
-                while (false !== (list($topic_id) = $this->handler->db->fetchRow($result))) {
-                    $topics[$topic_id]['attachment'] = '&nbsp;' . newbbDisplayImage('attachment', _MD_NEWBB_TOPICSHASATT);
-                }
-            }
-        }
-
-        if (is_object($xoopsTpl)) {
-            $xoopsTpl->assign_by_ref('sticky', $sticky);
-            $xoopsTpl->assign_by_ref('topics', $topics);
-
-            return;
-        }
-
-        return [$topics, $sticky];
-    }
-
-    // START irmtfan to create an array from selected keys of an array
-
-    /**
-     * @param        $array
-     * @param  null  $keys
-     * @return array
-     */
-    public function getFromKeys($array, $keys = null)
-    {
-        if (empty($keys)) {
-            return $array;
-        } // all keys
-        $keyarr = is_string($keys) ? explode(',', $keys) : $keys;
-        $keyarr = array_intersect(array_keys($array), $keyarr); // keys should be in array
-        $ret    = [];
-        foreach ($keyarr as $key) {
-            $ret[$key] = $array[$key];
-        }
-
-        return $ret;
-    }
-    // END irmtfan to create an array from selected keys of an array
+		$type_list = $this->getTypes();
+		/** @var Newbb\ForumHandler $forumHandler */
+		$forumHandler = Newbb\Helper::getInstance()->getHandler('Forum');
+
+		if (count($forums) > 0) {
+			$forum_list = $forumHandler->getAll(new \Criteria('forum_id', '(' . implode(', ', array_keys($forums)) . ')', 'IN'), ['forum_name', 'hot_threshold'], false);
+		} else {
+			$forum_list = $forumHandler->getAll();
+		}
+
+		foreach (array_keys($topics) as $id) {
+			$topics[$id]['topic_read']       = empty($topic_isRead[$id]) ? 0 : 1; // add topic-read/topic-new smarty variable
+			$topics[$id]['topic_forum_link'] = '<a href="' . XOOPS_URL . '/modules/newbb/viewforum.php?forum=' . $topics[$id]['topic_forum'] . '">' . $forum_list[$topics[$id]['topic_forum']]['forum_name'] . '</a>';
+
+			//irmtfan use topic_title_excerpt -- add else
+			if (!empty($topics[$id]['type_id']) && isset($type_list[$topics[$id]['type_id']])) {
+				$topics[$id]['topic_title'] = getTopicTitle($topics[$id]['topic_title_excerpt'], $type_list[$topics[$id]['type_id']]['type_name'], $type_list[$topics[$id]['type_id']]['type_color']);
+			} else {
+				$topics[$id]['topic_title'] = $topics[$id]['topic_title_excerpt'];
+			}
+			$topics[$id]['topic_poster']      = !empty($posters_name[$topics[$id]['topic_poster_uid']]) ? $posters_name[$topics[$id]['topic_poster_uid']] : $topics[$id]['topic_poster_name'];
+			$topics[$id]['topic_last_poster'] = !empty($posters_name[$topics[$id]['topic_last_poster_uid']]) ? $posters_name[$topics[$id]['topic_last_poster_uid']] : $topics[$id]['topic_last_poster_name'];
+			// ------------------------------------------------------
+			// START irmtfan remove hardcodes from topic_folder smarty
+			// topic_folder: priority: newhot -> hot/new -> regular
+			//list($topic_status, $topic_digest, $topic_replies) = $topics[$id]["stats"]; irmtfan
+			// START irmtfan - add topic_folder_text for alt
+			//if ($topics[$id]["lock"] === 1) {
+			//    $topic_folder = 'topic_locked';
+			//    $topic_folder_text = _MD_NEWBB_TOPICLOCKED;
+			//} else {
+			//if ($topic_digest) {
+			//    $topic_folder = 'topic_digest';
+			//    $topic_folder_text = _MD_NEWBB_TOPICDIGEST;
+			if ($topics[$id]['topic_replies'] >= $forum_list[$topics[$id]['topic_forum']]['hot_threshold']) {
+				$topic_folder      = empty($topic_isRead[$id]) ? 'topic_hot_new' : 'topic_hot';
+				$topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_MORETHAN : _MD_NEWBB_MORETHAN2;
+			} else {
+				$topic_folder      = empty($topic_isRead[$id]) ? 'topic_new' : 'topic';
+				$topic_folder_text = empty($topic_isRead[$id]) ? _MD_NEWBB_NEWPOSTS : _MD_NEWBB_NONEWPOSTS;
+			}
+			//}
+			// END irmtfan remove hardcodes from topic_folder smarty
+			$topics[$id]['topic_folder'] = newbbDisplayImage($topic_folder, $topic_folder_text);
+			// END irmtfan - add topic_folder_text for alt
+
+			unset($topics[$id]['topic_poster_name'], $topics[$id]['topic_last_poster_name']);// irmtfan remove $topics[$id]["stats"] because it is not exist now
+		}
+
+		if (count($topics) > 0) {
+			$sql = ' SELECT DISTINCT topic_id FROM ' . $this->handler->db->prefix('newbb_posts') . " WHERE attachment != ''" . ' AND topic_id IN (' . implode(',', array_keys($topics)) . ')';
+			if ($result = $this->handler->db->query($sql)) {
+				while (false !== (list($topic_id) = $this->handler->db->fetchRow($result))) {
+					$topics[$topic_id]['attachment'] = '&nbsp;' . newbbDisplayImage('attachment', _MD_NEWBB_TOPICSHASATT);
+				}
+			}
+		}
+
+		if (is_object($xoopsTpl)) {
+			$xoopsTpl->assign_by_ref('sticky', $sticky);
+			$xoopsTpl->assign_by_ref('topics', $topics);
+
+			return;
+		}
+
+		return [$topics, $sticky];
+	}
+
+	// START irmtfan to create an array from selected keys of an array
+
+	/**
+	 * @param        $array
+	 * @param  null  $keys
+	 * @return array
+	 */
+	public function getFromKeys($array, $keys = null)
+	{
+		if (empty($keys)) {
+			return $array;
+		} // all keys
+		$keyarr = is_string($keys) ? explode(',', $keys) : $keys;
+		$keyarr = array_intersect(array_keys($array), $keyarr); // keys should be in array
+		$ret    = [];
+		foreach ($keyarr as $key) {
+			$ret[$key] = $array[$key];
+		}
+
+		return $ret;
+	}
+	// END irmtfan to create an array from selected keys of an array
 }

class/TypeHandler.php

Indentation +166 added lines, -166 removed lines

@@ -21,175 +21,175 @@
  */
 class TypeHandler extends \XoopsPersistableObjectHandler
 {
-    /**
-     * @param null|\XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db = null)
-    {
-        parent::__construct($db, 'newbb_type', Type::class, 'type_id', 'type_name');
-    }
-
-    /**
-     * Get types linked to a forum
-     *
-     * @param  mixed $forums single forum ID or an array of forum IDs
-     * @return array associative array of types (name, color, order)
-     */
-    public function getByForum($forums = null)
-    {
-        $ret = [];
-
-        $forums = (is_array($forums) ? array_filter(array_map('intval', array_map('trim', $forums))) : (empty($forums) ? 0 : [(int)$forums]));
-
-        $sql = '    SELECT o.type_id, o.type_name, o.type_color, l.type_order'
-               . '     FROM '
-               . $this->db->prefix('newbb_type_forum')
-               . ' AS l '
-               . "         LEFT JOIN {$this->table} AS o ON o.{$this->keyName} = l.{$this->keyName} "
-               . '     WHERE '
-               . '        l.forum_id '
-               . (empty($forums) ? 'IS NOT NULL' : 'IN (' . implode(', ', $forums) . ')')
-               . '         ORDER BY l.type_order ASC';
-        if (false === ($result = $this->db->query($sql))) {
-            //xoops_error($this->db->error());
-            return $ret;
-        }
-
-        while (false !== ($myrow = $this->db->fetchArray($result))) {
-            $ret[$myrow[$this->keyName]] = [
-                'type_id'    => $myrow[$this->keyName],
-                'type_order' => $myrow['type_order'],
-                'type_name'  => htmlspecialchars($myrow['type_name'], ENT_QUOTES | ENT_HTML5),
-                'type_color' => htmlspecialchars($myrow['type_color'], ENT_QUOTES | ENT_HTML5)
-            ];
-        }
-
-        return $ret;
-    }
-
-    /**
-     * Update types linked to a forum
-     *
-     * @param  integer $forum_id
-     * @param  array   $types
-     * @return boolean
-     */
-    public function updateByForum($forum_id, $types)
-    {
-        $forum_id = (int)$forum_id;
-        if (empty($forum_id)) {
-            return false;
-        }
-
-        $types_existing = $this->getByForum($forum_id);
-        $types_valid    = [];
-        $types_add      = [];
-        $types_update   = [];
-        foreach (array_keys($types_existing) as $key) {
-            if (empty($types[$key])) {
-                continue;
-            }
-            $types_valid[] = $key;
-            if ($types[$key] !== $types_existing[$key]['type_order']) {
-                $types_update[] = $key;
-            }
-        }
-        foreach (array_keys($types) as $key) {
-            if (!empty($types[$key]) && !isset($types_existing[$key])) {
-                $types_add[] = $key;
-            }
-        }
-        $types_valid  = array_filter($types_valid);
-        $types_add    = array_filter($types_add);
-        $types_update = array_filter($types_update);
-
-        if (!empty($types_valid)) {
-            $sql = 'DELETE FROM ' . $this->db->prefix('newbb_type_forum') . ' WHERE ' . ' forum_id = ' . $forum_id . ' AND ' . // irmtfan bug fix: delete other forums types when update the type for a specific forum
-                   "     {$this->keyName} NOT IN (" . implode(', ', $types_valid) . ')';
-            if (false === ($result = $this->db->queryF($sql))) {
-            }
-        }
-
-        if (!empty($types_update)) {
-            $type_query = [];
-            foreach ($types_update as $key) {
-                $order = $types[$key];
-                if ($types_existing[$key]['type_order'] == $order) {
-                    continue;
-                }
-                $sql = 'UPDATE ' . $this->db->prefix('newbb_type_forum') . " SET type_order = {$order}" . " WHERE  {$this->keyName} = {$key} AND forum_id = {$forum_id}";
-                if (false === ($result = $this->db->queryF($sql))) {
-                }
-            }
-        }
-
-        if (!empty($types_add)) {
-            $type_query = [];
-            foreach ($types_add as $key) {
-                $order = $types[$key];
-                //if (!in_array($key, $types_add)) continue;
-                $type_query[] = "({$key}, {$forum_id}, {$order})";
-            }
-            $sql = 'INSERT INTO ' . $this->db->prefix('newbb_type_forum') . ' (type_id, forum_id, type_order) ' . ' VALUES ' . implode(', ', $type_query);
-            if (false === ($result = $this->db->queryF($sql))) {
-                //xoops_error($this->db->error());
-            }
-        }
-
-        return true;
-    }
-
-    /**
-     * delete an object as well as links relying on it
-     *
-     * @param Type|\XoopsObject $object {@link Type}
-     * @param  bool        $force  flag to force the query execution despite security settings
-     * @return bool
-     */
-    public function delete(\XoopsObject $object, $force = true)
-    {
-        if (!is_object($object) || !$object->getVar($this->keyName)) {
-            return false;
-        }
-        $queryFunc = empty($force) ? 'query' : 'queryF';
-
-        /*
+	/**
+	 * @param null|\XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db = null)
+	{
+		parent::__construct($db, 'newbb_type', Type::class, 'type_id', 'type_name');
+	}
+
+	/**
+	 * Get types linked to a forum
+	 *
+	 * @param  mixed $forums single forum ID or an array of forum IDs
+	 * @return array associative array of types (name, color, order)
+	 */
+	public function getByForum($forums = null)
+	{
+		$ret = [];
+
+		$forums = (is_array($forums) ? array_filter(array_map('intval', array_map('trim', $forums))) : (empty($forums) ? 0 : [(int)$forums]));
+
+		$sql = '    SELECT o.type_id, o.type_name, o.type_color, l.type_order'
+			   . '     FROM '
+			   . $this->db->prefix('newbb_type_forum')
+			   . ' AS l '
+			   . "         LEFT JOIN {$this->table} AS o ON o.{$this->keyName} = l.{$this->keyName} "
+			   . '     WHERE '
+			   . '        l.forum_id '
+			   . (empty($forums) ? 'IS NOT NULL' : 'IN (' . implode(', ', $forums) . ')')
+			   . '         ORDER BY l.type_order ASC';
+		if (false === ($result = $this->db->query($sql))) {
+			//xoops_error($this->db->error());
+			return $ret;
+		}
+
+		while (false !== ($myrow = $this->db->fetchArray($result))) {
+			$ret[$myrow[$this->keyName]] = [
+				'type_id'    => $myrow[$this->keyName],
+				'type_order' => $myrow['type_order'],
+				'type_name'  => htmlspecialchars($myrow['type_name'], ENT_QUOTES | ENT_HTML5),
+				'type_color' => htmlspecialchars($myrow['type_color'], ENT_QUOTES | ENT_HTML5)
+			];
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * Update types linked to a forum
+	 *
+	 * @param  integer $forum_id
+	 * @param  array   $types
+	 * @return boolean
+	 */
+	public function updateByForum($forum_id, $types)
+	{
+		$forum_id = (int)$forum_id;
+		if (empty($forum_id)) {
+			return false;
+		}
+
+		$types_existing = $this->getByForum($forum_id);
+		$types_valid    = [];
+		$types_add      = [];
+		$types_update   = [];
+		foreach (array_keys($types_existing) as $key) {
+			if (empty($types[$key])) {
+				continue;
+			}
+			$types_valid[] = $key;
+			if ($types[$key] !== $types_existing[$key]['type_order']) {
+				$types_update[] = $key;
+			}
+		}
+		foreach (array_keys($types) as $key) {
+			if (!empty($types[$key]) && !isset($types_existing[$key])) {
+				$types_add[] = $key;
+			}
+		}
+		$types_valid  = array_filter($types_valid);
+		$types_add    = array_filter($types_add);
+		$types_update = array_filter($types_update);
+
+		if (!empty($types_valid)) {
+			$sql = 'DELETE FROM ' . $this->db->prefix('newbb_type_forum') . ' WHERE ' . ' forum_id = ' . $forum_id . ' AND ' . // irmtfan bug fix: delete other forums types when update the type for a specific forum
+				   "     {$this->keyName} NOT IN (" . implode(', ', $types_valid) . ')';
+			if (false === ($result = $this->db->queryF($sql))) {
+			}
+		}
+
+		if (!empty($types_update)) {
+			$type_query = [];
+			foreach ($types_update as $key) {
+				$order = $types[$key];
+				if ($types_existing[$key]['type_order'] == $order) {
+					continue;
+				}
+				$sql = 'UPDATE ' . $this->db->prefix('newbb_type_forum') . " SET type_order = {$order}" . " WHERE  {$this->keyName} = {$key} AND forum_id = {$forum_id}";
+				if (false === ($result = $this->db->queryF($sql))) {
+				}
+			}
+		}
+
+		if (!empty($types_add)) {
+			$type_query = [];
+			foreach ($types_add as $key) {
+				$order = $types[$key];
+				//if (!in_array($key, $types_add)) continue;
+				$type_query[] = "({$key}, {$forum_id}, {$order})";
+			}
+			$sql = 'INSERT INTO ' . $this->db->prefix('newbb_type_forum') . ' (type_id, forum_id, type_order) ' . ' VALUES ' . implode(', ', $type_query);
+			if (false === ($result = $this->db->queryF($sql))) {
+				//xoops_error($this->db->error());
+			}
+		}
+
+		return true;
+	}
+
+	/**
+	 * delete an object as well as links relying on it
+	 *
+	 * @param Type|\XoopsObject $object {@link Type}
+	 * @param  bool        $force  flag to force the query execution despite security settings
+	 * @return bool
+	 */
+	public function delete(\XoopsObject $object, $force = true)
+	{
+		if (!is_object($object) || !$object->getVar($this->keyName)) {
+			return false;
+		}
+		$queryFunc = empty($force) ? 'query' : 'queryF';
+
+		/*
          * Remove forum-type links
          */
-        $sql = 'DELETE' . ' FROM ' . $this->db->prefix('newbb_type_forum') . ' WHERE  ' . $this->keyName . ' = ' . $object->getVar($this->keyName);
-        if (false === ($result = $this->db->{$queryFunc}($sql))) {
-            // xoops_error($this->db->error());
-        }
+		$sql = 'DELETE' . ' FROM ' . $this->db->prefix('newbb_type_forum') . ' WHERE  ' . $this->keyName . ' = ' . $object->getVar($this->keyName);
+		if (false === ($result = $this->db->{$queryFunc}($sql))) {
+			// xoops_error($this->db->error());
+		}
 
-        /*
+		/*
          * Reset topic type linked to this type
          */
-        $sql = 'UPATE' . ' ' . $this->db->prefix('newbb_topics') . ' SET ' . $this->keyName . '=0' . ' WHERE  ' . $this->keyName . ' = ' . $object->getVar($this->keyName);
-        if (false === ($result = $this->db->{$queryFunc}($sql))) {
-            //xoops_error($this->db->error());
-        }
-
-        return parent::delete($object, $force);
-    }
-
-    /**
-     * clean orphan links from database
-     *
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @return bool   true on success
-     */
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
-    {
-        /* clear forum-type links */
-        $sql = 'DELETE FROM ' . $this->db->prefix('newbb_type_forum') . " WHERE ({$this->keyName} NOT IN ( SELECT DISTINCT {$this->keyName} FROM {$this->table}) )";
-        $this->db->queryF($sql);
-
-        /* reconcile topic-type link */
-        $sql = 'UPATE ' . $this->db->prefix('newbb_topics') . " SET {$this->keyName} = 0" . " WHERE ({$this->keyName} NOT IN ( SELECT DISTINCT {$this->keyName} FROM {$this->table}) )";
-        $this->db->queryF($sql);
-
-        return true;
-    }
+		$sql = 'UPATE' . ' ' . $this->db->prefix('newbb_topics') . ' SET ' . $this->keyName . '=0' . ' WHERE  ' . $this->keyName . ' = ' . $object->getVar($this->keyName);
+		if (false === ($result = $this->db->{$queryFunc}($sql))) {
+			//xoops_error($this->db->error());
+		}
+
+		return parent::delete($object, $force);
+	}
+
+	/**
+	 * clean orphan links from database
+	 *
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @return bool   true on success
+	 */
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
+	{
+		/* clear forum-type links */
+		$sql = 'DELETE FROM ' . $this->db->prefix('newbb_type_forum') . " WHERE ({$this->keyName} NOT IN ( SELECT DISTINCT {$this->keyName} FROM {$this->table}) )";
+		$this->db->queryF($sql);
+
+		/* reconcile topic-type link */
+		$sql = 'UPATE ' . $this->db->prefix('newbb_topics') . " SET {$this->keyName} = 0" . " WHERE ({$this->keyName} NOT IN ( SELECT DISTINCT {$this->keyName} FROM {$this->table}) )";
+		$this->db->queryF($sql);
+
+		return true;
+	}
 }

class/PermissionForumHandler.php

Indentation +212 added lines, -212 removed lines

@@ -18,7 +18,7 @@ 
 //define("NEWBB_HANDLER_PERMISSION_FORUM", 1);
 
 if (defined('FORUM_PERM_ITEMS') && class_exists('ForumPermissionHandler')) {
-    exit('access denied');
+	exit('access denied');
 }
 // irmtfan add pdf and print permissions.
 define('FORUM_PERM_ITEMS', 'access,view,post,reply,edit,delete,addpoll,vote,attach,noapprove,type,html,signature,pdf,print');
@@ -28,246 +28,246 @@ 
  */
 class PermissionForumHandler extends PermissionHandler
 {
-    protected $templateFilename;
+	protected $templateFilename;
 
-    /**
-     * @param \XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db = null)
-    {
-        //        $this->PermissionHandler($db);
-        parent::__construct($db);
-        $this->templateFilename = XOOPS_VAR_PATH . '/configs/newbb_permission_template.php';
-    }
+	/**
+	 * @param \XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db = null)
+	{
+		//        $this->PermissionHandler($db);
+		parent::__construct($db);
+		$this->templateFilename = XOOPS_VAR_PATH . '/configs/newbb_permission_template.php';
+	}
 
-    /**
-     * @param  bool $fullname
-     * @return array
-     */
-    public function getValidPerms($fullname = false)
-    {
-        static $validPerms = [];
-        if (isset($validPerms[(int)$fullname])) {
-            return $validPerms[(int)$fullname];
-        }
-        $items = array_filter(array_map('trim', explode(',', FORUM_PERM_ITEMS)));
-        if (!empty($fullname)) {
-            foreach (array_keys($items) as $key) {
-                $items[$key] = 'forum_' . $items[$key];
-            }
-        }
-        $validPerms[(int)$fullname] = $items;
+	/**
+	 * @param  bool $fullname
+	 * @return array
+	 */
+	public function getValidPerms($fullname = false)
+	{
+		static $validPerms = [];
+		if (isset($validPerms[(int)$fullname])) {
+			return $validPerms[(int)$fullname];
+		}
+		$items = array_filter(array_map('trim', explode(',', FORUM_PERM_ITEMS)));
+		if (!empty($fullname)) {
+			foreach (array_keys($items) as $key) {
+				$items[$key] = 'forum_' . $items[$key];
+			}
+		}
+		$validPerms[(int)$fullname] = $items;
 
-        return $items;
-    }
+		return $items;
+	}
 
-    /**
-     * @param        $mid
-     * @param  int   $id
-     * @return array
-     */
-    public function getValidItems($mid, $id = 0)
-    {
-        static $suspension = [];
-        $full_items = [];
-        if (empty($mid)) {
-            return $full_items;
-        }
+	/**
+	 * @param        $mid
+	 * @param  int   $id
+	 * @return array
+	 */
+	public function getValidItems($mid, $id = 0)
+	{
+		static $suspension = [];
+		$full_items = [];
+		if (empty($mid)) {
+			return $full_items;
+		}
 
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
-        $uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
-        $ip  = \Xmf\IPAddress::fromRequest()->asReadable();
-        if (!empty($GLOBALS['xoopsModuleConfig']['enable_usermoderate']) && !isset($suspension[$uid][$id])
-            && !newbbIsAdmin($id)) {
-            /** @var Newbb\ModerateHandler $moderateHandler */
-            $moderateHandler = Newbb\Helper::getInstance()->getHandler('Moderate');
-            if (!$moderateHandler->verifyUser($uid, '', $id)) {
-                $suspension[$uid][$ip][$id] = 1;
-            } else {
-                $suspension[$uid][$ip][$id] = 0;
-            }
-        }
+		require_once  dirname(__DIR__) . '/include/functions.user.php';
+		$uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
+		$ip  = \Xmf\IPAddress::fromRequest()->asReadable();
+		if (!empty($GLOBALS['xoopsModuleConfig']['enable_usermoderate']) && !isset($suspension[$uid][$id])
+			&& !newbbIsAdmin($id)) {
+			/** @var Newbb\ModerateHandler $moderateHandler */
+			$moderateHandler = Newbb\Helper::getInstance()->getHandler('Moderate');
+			if (!$moderateHandler->verifyUser($uid, '', $id)) {
+				$suspension[$uid][$ip][$id] = 1;
+			} else {
+				$suspension[$uid][$ip][$id] = 0;
+			}
+		}
 
-        $items = $this->getValidPerms();
-        foreach ($items as $item) {
-            /* skip access for suspended users */
-            //if ( !empty($suspension[$uid][$ip][$id]) && in_array($item, array("post", "reply", "edit", "delete", "addpoll", "vote", "attach", "noapprove", "type")) ) continue;
-            if (!empty($suspension[$uid][$ip][$id])) {
-                continue;
-            }
-            $full_items[] = "'forum_{$item}'";
-        }
+		$items = $this->getValidPerms();
+		foreach ($items as $item) {
+			/* skip access for suspended users */
+			//if ( !empty($suspension[$uid][$ip][$id]) && in_array($item, array("post", "reply", "edit", "delete", "addpoll", "vote", "attach", "noapprove", "type")) ) continue;
+			if (!empty($suspension[$uid][$ip][$id])) {
+				continue;
+			}
+			$full_items[] = "'forum_{$item}'";
+		}
 
-        return $full_items;
-    }
+		return $full_items;
+	}
 
-    /*
+	/*
     * Returns permissions for a certain type
     *
     * @param int $id id of the item (forum, topic or possibly post) to get permissions for
     *
     * @return array
     */
-    /**
-     * @param  int|array $id
-     * @return bool|array
-     */
-    public function getPermissions($id = 0)
-    {
-        $permissions = [];
-        if (is_object($GLOBALS['xoopsModule']) && 'newbb' === $GLOBALS['xoopsModule']->getVar('dirname')) {
-            $modid = $GLOBALS['xoopsModule']->getVar('mid');
-        } else {
-            /** @var \XoopsModuleHandler $moduleHandler */
-            $moduleHandler = xoops_getHandler('module');
-            $xoopsNewBB    = $moduleHandler->getByDirname('newbb');
-            $modid         = $xoopsNewBB->getVar('mid');
-            unset($xoopsNewBB);
-        }
+	/**
+	 * @param  int|array $id
+	 * @return bool|array
+	 */
+	public function getPermissions($id = 0)
+	{
+		$permissions = [];
+		if (is_object($GLOBALS['xoopsModule']) && 'newbb' === $GLOBALS['xoopsModule']->getVar('dirname')) {
+			$modid = $GLOBALS['xoopsModule']->getVar('mid');
+		} else {
+			/** @var \XoopsModuleHandler $moduleHandler */
+			$moduleHandler = xoops_getHandler('module');
+			$xoopsNewBB    = $moduleHandler->getByDirname('newbb');
+			$modid         = $xoopsNewBB->getVar('mid');
+			unset($xoopsNewBB);
+		}
 
-        // Get user's groups
-        $groups = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : [XOOPS_GROUP_ANONYMOUS];
-        // Create string of groupid's separated by commas, inserted in a set of brackets
-        if (count($groups) < 1) {
-            return false;
-        }
-        // Create criteria for getting only the permissions regarding this module and this user's groups
-        $criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
-        $criteria->add(new \Criteria('gperm_groupid', '(' . implode(',', $groups) . ')', 'IN'));
-        if ($id) {
-            if (is_array($id)) {
-                $criteria->add(new \Criteria('gperm_itemid', '(' . implode(',', $id) . ')', 'IN'));
-            } else {
-                $criteria->add(new \Criteria('gperm_itemid', (int)$id));
-            }
-        }
-        $gperm_names = implode(', ', $this->getValidItems($modid, $id));
+		// Get user's groups
+		$groups = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : [XOOPS_GROUP_ANONYMOUS];
+		// Create string of groupid's separated by commas, inserted in a set of brackets
+		if (count($groups) < 1) {
+			return false;
+		}
+		// Create criteria for getting only the permissions regarding this module and this user's groups
+		$criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
+		$criteria->add(new \Criteria('gperm_groupid', '(' . implode(',', $groups) . ')', 'IN'));
+		if ($id) {
+			if (is_array($id)) {
+				$criteria->add(new \Criteria('gperm_itemid', '(' . implode(',', $id) . ')', 'IN'));
+			} else {
+				$criteria->add(new \Criteria('gperm_itemid', (int)$id));
+			}
+		}
+		$gperm_names = implode(', ', $this->getValidItems($modid, $id));
 
-        // Add criteria for gpermnames
-        $criteria->add(new \Criteria('gperm_name', '(' . $gperm_names . ')', 'IN'));
-        // Get all permission objects in this module and for this user's groups
-        $userpermissions = $this->getObjects($criteria, true);
+		// Add criteria for gpermnames
+		$criteria->add(new \Criteria('gperm_name', '(' . $gperm_names . ')', 'IN'));
+		// Get all permission objects in this module and for this user's groups
+		$userpermissions = $this->getObjects($criteria, true);
 
-        // Set the granted permissions to 1
-        foreach ($userpermissions as $gperm_id => $gperm) {
-            $permissions[$gperm->getVar('gperm_itemid')][$gperm->getVar('gperm_name')] = 1;
-        }
-        $userpermissions = null;
-        unset($userpermissions);
+		// Set the granted permissions to 1
+		foreach ($userpermissions as $gperm_id => $gperm) {
+			$permissions[$gperm->getVar('gperm_itemid')][$gperm->getVar('gperm_name')] = 1;
+		}
+		$userpermissions = null;
+		unset($userpermissions);
 
-        // Return the permission array
-        return $permissions;
-    }
+		// Return the permission array
+		return $permissions;
+	}
 
-    /**
-     * @param  Forum|int $forum
-     * @param  bool      $topic_locked
-     * @param  bool      $isAdmin
-     * @return array
-     */
-    public function getPermissionTable($forum = 0, $topic_locked = false, $isAdmin = false)
-    {
-        $perm = [];
+	/**
+	 * @param  Forum|int $forum
+	 * @param  bool      $topic_locked
+	 * @param  bool      $isAdmin
+	 * @return array
+	 */
+	public function getPermissionTable($forum = 0, $topic_locked = false, $isAdmin = false)
+	{
+		$perm = [];
 
-        $forumId = $forum;
-        if (is_object($forum)) {
-            $forumId = $forum->getVar('forum_id');
-        }
+		$forumId = $forum;
+		if (is_object($forum)) {
+			$forumId = $forum->getVar('forum_id');
+		}
 
-        $permission_set = $this->getPermissions($forumId);
+		$permission_set = $this->getPermissions($forumId);
 
-        $permItems = $this->getValidPerms();
-        foreach ($permItems as $item) {
-            if ('access' === $item) {
-                continue;
-            }
-            if ($isAdmin
-                || (isset($permission_set[$forumId]['forum_' . $item])
-                    && (!$topic_locked
-                        || 'view' === $item))) {
-                $perm[] = constant('_MD_NEWBB_CAN_' . strtoupper($item));
-            } else {
-                $perm[] = constant('_MD_NEWBB_CANNOT_' . strtoupper($item));
-            }
-        }
+		$permItems = $this->getValidPerms();
+		foreach ($permItems as $item) {
+			if ('access' === $item) {
+				continue;
+			}
+			if ($isAdmin
+				|| (isset($permission_set[$forumId]['forum_' . $item])
+					&& (!$topic_locked
+						|| 'view' === $item))) {
+				$perm[] = constant('_MD_NEWBB_CAN_' . strtoupper($item));
+			} else {
+				$perm[] = constant('_MD_NEWBB_CANNOT_' . strtoupper($item));
+			}
+		}
 
-        return $perm;
-    }
+		return $perm;
+	}
 
-    /**
-     * @param $forum_id
-     * @return bool
-     */
-    public function deleteByForum($forum_id)
-    {
-        $forum_id = (int)$forum_id;
-        if (empty($forum_id)) {
-            return false;
-        }
-        $grouppermHandler = xoops_getHandler('groupperm');
-        $criteria     = new \CriteriaCompo(new \Criteria('gperm_modid', $GLOBALS['xoopsModule']->getVar('mid')));
-        $items        = $this->getValidPerms(true);
-        $criteria->add(new \Criteria('gperm_name', "('" . implode("', '", $items) . "')", 'IN'));
-        $criteria->add(new \Criteria('gperm_itemid', $forum_id));
+	/**
+	 * @param $forum_id
+	 * @return bool
+	 */
+	public function deleteByForum($forum_id)
+	{
+		$forum_id = (int)$forum_id;
+		if (empty($forum_id)) {
+			return false;
+		}
+		$grouppermHandler = xoops_getHandler('groupperm');
+		$criteria     = new \CriteriaCompo(new \Criteria('gperm_modid', $GLOBALS['xoopsModule']->getVar('mid')));
+		$items        = $this->getValidPerms(true);
+		$criteria->add(new \Criteria('gperm_name', "('" . implode("', '", $items) . "')", 'IN'));
+		$criteria->add(new \Criteria('gperm_itemid', $forum_id));
 
-        return $grouppermHandler->deleteAll($criteria);
-    }
+		return $grouppermHandler->deleteAll($criteria);
+	}
 
-    /**
-     * @param       $forum
-     * @param  int  $mid
-     * @return bool
-     */
-    public function applyTemplate($forum, $mid = 0)
-    {
-        if (!$perm_template = $this->getTemplate()) {
-            return false;
-        }
+	/**
+	 * @param       $forum
+	 * @param  int  $mid
+	 * @return bool
+	 */
+	public function applyTemplate($forum, $mid = 0)
+	{
+		if (!$perm_template = $this->getTemplate()) {
+			return false;
+		}
 
-        if (empty($mid)) {
-            if (is_object($GLOBALS['xoopsModule']) && 'newbb' === $GLOBALS['xoopsModule']->getVar('dirname')) {
-                $mid = $GLOBALS['xoopsModule']->getVar('mid');
-            } else {
-                /** @var \XoopsModuleHandler $moduleHandler */
-                $moduleHandler = xoops_getHandler('module');
-                $newbb         = $moduleHandler->getByDirname('newbb');
-                $mid           = $newbb->getVar('mid');
-                unset($newbb);
-            }
-        }
+		if (empty($mid)) {
+			if (is_object($GLOBALS['xoopsModule']) && 'newbb' === $GLOBALS['xoopsModule']->getVar('dirname')) {
+				$mid = $GLOBALS['xoopsModule']->getVar('mid');
+			} else {
+				/** @var \XoopsModuleHandler $moduleHandler */
+				$moduleHandler = xoops_getHandler('module');
+				$newbb         = $moduleHandler->getByDirname('newbb');
+				$mid           = $newbb->getVar('mid');
+				unset($newbb);
+			}
+		}
 
-        /** @var \XoopsMemberHandler $memberHandler */
-        $memberHandler = xoops_getHandler('member');
-        $glist         = $memberHandler->getGroupList();
-        $perms         = $this->getValidPerms(true);
-        foreach (array_keys($glist) as $group) {
-            foreach ($perms as $perm) {
-                if (!empty($perm_template[$group][$perm])) {
-                    $this->validateRight($perm, $forum, $group, $mid);
-                } else {
-                    $this->deleteRight($perm, $forum, $group, $mid);
-                }
-            }
-        }
+		/** @var \XoopsMemberHandler $memberHandler */
+		$memberHandler = xoops_getHandler('member');
+		$glist         = $memberHandler->getGroupList();
+		$perms         = $this->getValidPerms(true);
+		foreach (array_keys($glist) as $group) {
+			foreach ($perms as $perm) {
+				if (!empty($perm_template[$group][$perm])) {
+					$this->validateRight($perm, $forum, $group, $mid);
+				} else {
+					$this->deleteRight($perm, $forum, $group, $mid);
+				}
+			}
+		}
 
-        return true;
-    }
+		return true;
+	}
 
-    /**
-     * @return array|false
-     */
-    public function getTemplate()
-    {
-        $perms = \Xmf\Yaml::readWrapped($this->templateFilename);
-        return $perms;
-    }
+	/**
+	 * @return array|false
+	 */
+	public function getTemplate()
+	{
+		$perms = \Xmf\Yaml::readWrapped($this->templateFilename);
+		return $perms;
+	}
 
-    /**
-     * @param array $perms
-     * @return bool
-     */
-    public function setTemplate($perms)
-    {
-        return \Xmf\Yaml::saveWrapped($perms, $this->templateFilename);
-    }
+	/**
+	 * @param array $perms
+	 * @return bool
+	 */
+	public function setTemplate($perms)
+	{
+		return \Xmf\Yaml::saveWrapped($perms, $this->templateFilename);
+	}
 }

class/TopicHandler.php

Indentation +560 added lines, -560 removed lines

@@ -22,570 +22,570 @@
  */
 class TopicHandler extends \XoopsPersistableObjectHandler
 {
-    /**
-     * @param \XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db = null)
-    {
-        parent::__construct($db, 'newbb_topics', Topic::class, 'topic_id', 'topic_title');
-    }
-
-    /**
-     * @param  mixed      $id
-     * @param  null|array $fields
-     * @return mixed|null
-     */
-    public function get($id = null, $fields = null) //get($id, $var = null)
-    {
-        $var  = $fields;
-        $ret  = null;
-        $tags = $var;
-        if (!empty($var) && is_string($var)) {
-            $tags = [$var];
-        }
-        if (!$topicObject = parent::get($id, $tags)) {
-            return $ret;
-        }
-        $ret = $topicObject;
-        if (!empty($var) && is_string($var)) {
-            $ret = @$topicObject->getVar($var);
-        }
-
-        return $ret;
-    }
-
-    /**
-     * @param \XoopsObject $object
-     * @param  bool        $force
-     * @return mixed
-     */
-    public function insert(\XoopsObject $object, $force = true)
-    {
-        if (!$object->getVar('topic_time')) {
-            $object->setVar('topic_time', time());
-        }
-        if (!parent::insert($object, $force) || !$object->getVar('approved')) {
-            return $object->getVar('topic_id');
-        }
-
-        $newbbConfig = newbbLoadConfig();
-        if (!empty($newbbConfig['do_tag'])
-            && @require_once $GLOBALS['xoops']->path('modules/tag/include/functions.php')) {
-            if ($tagHandler = tag_getTagHandler()) {
-                $tagHandler->updateByItem($object->getVar('topic_tags', 'n'), $object->getVar('topic_id'), 'newbb');
-            }
-        }
-
-        return $object->getVar('topic_id');
-    }
-
-    /**
-     * @param       $object
-     * @param  bool $force
-     * @return bool
-     */
-    public function approve($object, $force = false)
-    {
-        $topic_id = $object->getVar('topic_id');
-        if ($force) {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = -1 WHERE topic_id = {$topic_id}";
-        } else {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = 1 WHERE topic_id = {$topic_id}";
-        }
-        if (!$result = $this->db->queryF($sql)) {
-            //xoops_error($this->db->error());
-            return false;
-        }
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $postsObject = $postHandler->getAll(new \Criteria('topic_id', $topic_id));
-        foreach (array_keys($postsObject) as $post_id) {
-            $postHandler->approve($postsObject[$post_id]);
-        }
-        unset($postsObject);
-        $statsHandler = Newbb\Helper::getInstance()->getHandler('Stats');
-        $statsHandler->update($object->getVar('forum_id'), 'topic');
-
-        return true;
-    }
-
-    /**
-     * get previous/next topic
-     *
-     * @param integer $topic_id current topic ID
-     * @param integer $action
-     *                          <ul>
-     *                          <li> -1: previous </li>
-     *                          <li> 0: current </li>
-     *                          <li> 1: next </li>
-     *                          </ul>
-     * @param integer $forum_id the scope for moving
-     *                          <ul>
-     *                          <li> >0 : inside the forum </li>
-     *                          <li> <= 0: global </li>
-     *                          </ul>
-     * @access public
-     * @return mixed|null|\XoopsObject
-     */
-    public function &getByMove($topic_id, $action, $forum_id = 0)
-    {
-        $topic = null;
-        if (!empty($action)) {
-            $sql = 'SELECT * FROM ' . $this->table . ' WHERE 1=1' . (($forum_id > 0) ? ' AND forum_id=' . (int)$forum_id : '') . ' AND topic_id ' . (($action > 0) ? '>' : '<') . (int)$topic_id . ' ORDER BY topic_id ' . (($action > 0) ? 'ASC' : 'DESC') . ' LIMIT 1';
-            if ($result = $this->db->query($sql)) {
-                if ($row = $this->db->fetchArray($result)) {
-                    $topic = $this->create(false);
-                    $topic->assignVars($row);
-
-                    return $topic;
-                }
-            }
-        }
-        $topic = $this->get($topic_id);
-
-        return $topic;
-    }
-
-    /**
-     * @param $post_id
-     * @return null|\XoopsObject
-     */
-    public function &getByPost($post_id)
-    {
-        $topic  = null;
-        $sql    = 'SELECT t.* FROM ' . $this->db->prefix('newbb_topics') . ' t, ' . $this->db->prefix('newbb_posts') . ' p
+	/**
+	 * @param \XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db = null)
+	{
+		parent::__construct($db, 'newbb_topics', Topic::class, 'topic_id', 'topic_title');
+	}
+
+	/**
+	 * @param  mixed      $id
+	 * @param  null|array $fields
+	 * @return mixed|null
+	 */
+	public function get($id = null, $fields = null) //get($id, $var = null)
+	{
+		$var  = $fields;
+		$ret  = null;
+		$tags = $var;
+		if (!empty($var) && is_string($var)) {
+			$tags = [$var];
+		}
+		if (!$topicObject = parent::get($id, $tags)) {
+			return $ret;
+		}
+		$ret = $topicObject;
+		if (!empty($var) && is_string($var)) {
+			$ret = @$topicObject->getVar($var);
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * @param \XoopsObject $object
+	 * @param  bool        $force
+	 * @return mixed
+	 */
+	public function insert(\XoopsObject $object, $force = true)
+	{
+		if (!$object->getVar('topic_time')) {
+			$object->setVar('topic_time', time());
+		}
+		if (!parent::insert($object, $force) || !$object->getVar('approved')) {
+			return $object->getVar('topic_id');
+		}
+
+		$newbbConfig = newbbLoadConfig();
+		if (!empty($newbbConfig['do_tag'])
+			&& @require_once $GLOBALS['xoops']->path('modules/tag/include/functions.php')) {
+			if ($tagHandler = tag_getTagHandler()) {
+				$tagHandler->updateByItem($object->getVar('topic_tags', 'n'), $object->getVar('topic_id'), 'newbb');
+			}
+		}
+
+		return $object->getVar('topic_id');
+	}
+
+	/**
+	 * @param       $object
+	 * @param  bool $force
+	 * @return bool
+	 */
+	public function approve($object, $force = false)
+	{
+		$topic_id = $object->getVar('topic_id');
+		if ($force) {
+			$sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = -1 WHERE topic_id = {$topic_id}";
+		} else {
+			$sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = 1 WHERE topic_id = {$topic_id}";
+		}
+		if (!$result = $this->db->queryF($sql)) {
+			//xoops_error($this->db->error());
+			return false;
+		}
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$postsObject = $postHandler->getAll(new \Criteria('topic_id', $topic_id));
+		foreach (array_keys($postsObject) as $post_id) {
+			$postHandler->approve($postsObject[$post_id]);
+		}
+		unset($postsObject);
+		$statsHandler = Newbb\Helper::getInstance()->getHandler('Stats');
+		$statsHandler->update($object->getVar('forum_id'), 'topic');
+
+		return true;
+	}
+
+	/**
+	 * get previous/next topic
+	 *
+	 * @param integer $topic_id current topic ID
+	 * @param integer $action
+	 *                          <ul>
+	 *                          <li> -1: previous </li>
+	 *                          <li> 0: current </li>
+	 *                          <li> 1: next </li>
+	 *                          </ul>
+	 * @param integer $forum_id the scope for moving
+	 *                          <ul>
+	 *                          <li> >0 : inside the forum </li>
+	 *                          <li> <= 0: global </li>
+	 *                          </ul>
+	 * @access public
+	 * @return mixed|null|\XoopsObject
+	 */
+	public function &getByMove($topic_id, $action, $forum_id = 0)
+	{
+		$topic = null;
+		if (!empty($action)) {
+			$sql = 'SELECT * FROM ' . $this->table . ' WHERE 1=1' . (($forum_id > 0) ? ' AND forum_id=' . (int)$forum_id : '') . ' AND topic_id ' . (($action > 0) ? '>' : '<') . (int)$topic_id . ' ORDER BY topic_id ' . (($action > 0) ? 'ASC' : 'DESC') . ' LIMIT 1';
+			if ($result = $this->db->query($sql)) {
+				if ($row = $this->db->fetchArray($result)) {
+					$topic = $this->create(false);
+					$topic->assignVars($row);
+
+					return $topic;
+				}
+			}
+		}
+		$topic = $this->get($topic_id);
+
+		return $topic;
+	}
+
+	/**
+	 * @param $post_id
+	 * @return null|\XoopsObject
+	 */
+	public function &getByPost($post_id)
+	{
+		$topic  = null;
+		$sql    = 'SELECT t.* FROM ' . $this->db->prefix('newbb_topics') . ' t, ' . $this->db->prefix('newbb_posts') . ' p
                 WHERE t.topic_id = p.topic_id AND p.post_id = ' . (int)$post_id;
-        $result = $this->db->query($sql);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return $topic;
-        }
-        $row   = $this->db->fetchArray($result);
-        $topic = $this->create(false);
-        $topic->assignVars($row);
-
-        return $topic;
-    }
-
-    /**
-     * @param  Topic  $topic
-     * @param  string $type
-     * @return mixed
-     */
-    public function getPostCount(&$topic, $type = '')
-    {
-        switch ($type) {
-            case 'pending':
-                $approved = 0;
-                break;
-            case 'deleted':
-                $approved = -1;
-                break;
-            default:
-                $approved = 1;
-                break;
-        }
-        $criteria = new \CriteriaCompo(new \Criteria('topic_id', $topic->getVar('topic_id')));
-        $criteria->add(new \Criteria('approved', $approved));
-        /** @var Newbb\PostHandler $postHandler */
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $count       = $postHandler->getCount($criteria);
-
-        return $count;
-    }
-
-    /**
-     * @param $topic_id
-     * @return null|Newbb\Post
-     */
-    public function &getTopPost($topic_id)
-    {
-        $post = null;
-        $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p,
+		$result = $this->db->query($sql);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return $topic;
+		}
+		$row   = $this->db->fetchArray($result);
+		$topic = $this->create(false);
+		$topic->assignVars($row);
+
+		return $topic;
+	}
+
+	/**
+	 * @param  Topic  $topic
+	 * @param  string $type
+	 * @return mixed
+	 */
+	public function getPostCount(&$topic, $type = '')
+	{
+		switch ($type) {
+			case 'pending':
+				$approved = 0;
+				break;
+			case 'deleted':
+				$approved = -1;
+				break;
+			default:
+				$approved = 1;
+				break;
+		}
+		$criteria = new \CriteriaCompo(new \Criteria('topic_id', $topic->getVar('topic_id')));
+		$criteria->add(new \Criteria('approved', $approved));
+		/** @var Newbb\PostHandler $postHandler */
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$count       = $postHandler->getCount($criteria);
+
+		return $count;
+	}
+
+	/**
+	 * @param $topic_id
+	 * @return null|Newbb\Post
+	 */
+	public function &getTopPost($topic_id)
+	{
+		$post = null;
+		$sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p,
             ' . $this->db->prefix('newbb_posts_text') . ' t
             WHERE
             p.topic_id = ' . $topic_id . ' AND p.pid = 0
             AND t.post_id = p.post_id';
 
-        $result = $this->db->query($sql);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return $post;
-        }
-        /** @var Newbb\PostHandler $postHandler */
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $myrow       = $this->db->fetchArray($result);
-        /** @var Newbb\Post $post */
-        $post = $postHandler->create(false);
-        $post->assignVars($myrow);
-
-        return $post;
-    }
-
-    /**
-     * @param $topic_id
-     * @return bool
-     */
-    public function getTopPostId($topic_id)
-    {
-        $sql    = 'SELECT MIN(post_id) AS post_id FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id = ' . $topic_id . ' AND pid = 0';
-        $result = $this->db->query($sql);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return false;
-        }
-        list($post_id) = $this->db->fetchRow($result);
-
-        return $post_id;
-    }
-
-    /**
-     * @param         $topic
-     * @param  string $order
-     * @param  int    $perpage
-     * @param         $start
-     * @param  int    $post_id
-     * @param  string $type
-     * @return array
-     */
-    public function &getAllPosts(&$topic, $order = 'ASC', $perpage = 10, &$start, $post_id = 0, $type = '')
-    {
-        $ret     = [];
-        $perpage = ((int)$perpage > 0) ? (int)$perpage : (empty($GLOBALS['xoopsModuleConfig']['posts_per_page']) ? 10 : $GLOBALS['xoopsModuleConfig']['posts_per_page']);
-        $start   = (int)$start;
-        switch ($type) {
-            case 'pending':
-                $approveCriteria = ' AND p.approved = 0';
-                break;
-            case 'deleted':
-                $approveCriteria = ' AND p.approved = -1';
-                break;
-            default:
-                $approveCriteria = ' AND p.approved = 1';
-                break;
-        }
-
-        if ($post_id) {
-            if ('DESC' === $order) {
-                $operator_for_position = '>';
-            } else {
-                $order                 = 'ASC';
-                $operator_for_position = '<';
-            }
-            //$approveCriteria = ' AND approved = 1'; // any others?
-            $sql    = 'SELECT COUNT(*) FROM ' . $this->db->prefix('newbb_posts') . ' AS p WHERE p.topic_id=' . (int)$topic->getVar('topic_id') . $approveCriteria . " AND p.post_id $operator_for_position $post_id";
-            $result = $this->db->query($sql);
-            if (!$result) {
-                //xoops_error($this->db->error());
-                return $ret;
-            }
-            list($position) = $this->db->fetchRow($result);
-            $start = (int)($position / $perpage) * $perpage;
-        }
-
-        $sql    = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p, ' . $this->db->prefix('newbb_posts_text') . ' t WHERE p.topic_id=' . $topic->getVar('topic_id') . ' AND p.post_id = t.post_id' . $approveCriteria . " ORDER BY p.post_id $order";
-        $result = $this->db->query($sql, $perpage, $start);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return $ret;
-        }
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        while (false !== ($myrow = $this->db->fetchArray($result))) {
-            $post = $postHandler->create(false);
-            $post->assignVars($myrow);
-            $ret[$myrow['post_id']] = $post;
-            unset($post);
-        }
-
-        return $ret;
-    }
-
-    /**
-     * @param        $postArray
-     * @param  int   $pid
-     * @return mixed
-     */
-    public function &getPostTree(&$postArray, $pid = 0)
-    {
-        //        require_once $GLOBALS['xoops']->path('modules/newbb/class/Tree.php');
-        $NewBBTree = new Newbb\Tree('newbb_posts');
-        $NewBBTree->setPrefix('&nbsp;&nbsp;');
-        $NewBBTree->setPostArray($postArray);
-        $NewBBTree->getPostTree($postsArray, $pid);
-
-        return $postsArray;
-    }
-
-    /**
-     * @param $topic
-     * @param $postArray
-     * @return mixed
-     */
-    public function showTreeItem(&$topic, &$postArray)
-    {
-        global $viewtopic_users, $myts;
-
-        $postArray['post_time'] = newbbFormatTimestamp($postArray['post_time']);
-
-        if (!empty($postArray['icon'])) {
-            $postArray['icon'] = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($postArray['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
-        } else {
-            $postArray['icon'] = '<a name="' . $postArray['post_id'] . '"><img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" /></a>';
-        }
-
-        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id=' . $topic->getVar('topic_id') . '&amp;forum=' . $postArray['forum_id'] . '&amp;post_id=' . $postArray['post_id'] . '">' . $postArray['subject'] . '</a>';
-
-        $isActiveUser = false;
-        if (isset($viewtopic_users[$postArray['uid']]['name'])) {
-            $postArray['poster'] = $viewtopic_users[$postArray['uid']]['name'];
-            if ($postArray['uid'] > 0) {
-                $postArray['poster'] = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $postArray['uid'] . '">' . $viewtopic_users[$postArray['uid']]['name'] . '</a>';
-            }
-        } else {
-            $postArray['poster'] = empty($postArray['poster_name']) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $postArray['poster_name'];
-        }
-
-        return $postArray;
-    }
-
-    /**
-     * @param        $topic
-     * @param  bool  $isApproved
-     * @return array
-     */
-    public function &getAllPosters(&$topic, $isApproved = true)
-    {
-        $sql = 'SELECT DISTINCT uid FROM ' . $this->db->prefix('newbb_posts') . '  WHERE topic_id=' . $topic->getVar('topic_id') . ' AND uid>0';
-        if ($isApproved) {
-            $sql .= ' AND approved = 1';
-        }
-        $result = $this->db->query($sql);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return [];
-        }
-        $ret = [];
-        while (false !== ($myrow = $this->db->fetchArray($result))) {
-            $ret[] = $myrow['uid'];
-        }
-
-        return $ret;
-    }
-
-    /**
-     * @param Topic|\XoopsObject $topic
-     * @param  bool        $force
-     * @return bool
-     */
-    public function delete(\XoopsObject $topic, $force = true)
-    {
-        $topic_id = is_object($topic) ? $topic->getVar('topic_id') : (int)$topic;
-        if (empty($topic_id)) {
-            return false;
-        }
-        $postObject = $this->getTopPost($topic_id);
-        /** @var Newbb\PostHandler $postHandler */
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $postHandler->delete($postObject, false, $force);
-
-        $newbbConfig = newbbLoadConfig();
-        /** @var \XoopsModules\Tag\TagHandler $tagHandler */
-        if (!empty($newbbConfig['do_tag']) && $tagHandler = Tag\Helper::getInstance()->getHandler('Tag')) { //@xoops_getModuleHandler('tag', 'tag', true)) {
-            $tagHandler->updateByItem([], $topic_id, 'newbb');
-        }
-
-        return true;
-    }
-
-    // get permission
-    // parameter: $type: 'post', 'view',  'reply', 'edit', 'delete', 'addpoll', 'vote', 'attach'
-    // $gperm_names = "'forum_can_post', 'forum_can_view', 'forum_can_reply', 'forum_can_edit', 'forum_can_delete', 'forum_can_addpoll', 'forum_can_vote', 'forum_can_attach', 'forum_can_noapprove'";
-    /**
-     * @param   Newbb\Forum $forum
-     * @param  int     $topic_locked
-     * @param  string  $type
-     * @return bool
-     */
-    public function getPermission($forum, $topic_locked = 0, $type = 'view')
-    {
-        static $_cachedTopicPerms;
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
-        if (newbbIsAdmin($forum)) {
-            return true;
-        }
-
-        $forum_id = is_object($forum) ? $forum->getVar('forum_id') : (int)$forum;
-        if ($forum_id < 1) {
-            return false;
-        }
-
-        if ($topic_locked && 'view' !== $type) {
-            $permission = false;
-        } else {
-            /** var Newbb\PermissionHandler $permHandler */
-            $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
-            $permission  = $permHandler->getPermission('forum', $type, $forum_id);
-        }
-
-        return $permission;
-    }
-
-    /**
-     * clean orphan items from database
-     *
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @return bool   true on success
-     */
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
-    {
-        $this->deleteAll(new \Criteria('topic_time', 0), true, true);
-        parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id');
-        parent::cleanOrphan($this->db->prefix('newbb_posts'), 'topic_id');
-
-        return true;
-    }
-
-    /**
-     * clean expired objects from database
-     *
-     * @param  int $expire time limit for expiration
-     * @return bool true on success
-     */
-    public function cleanExpires($expire = 0)
-    {
-        // irmtfan if 0 no cleanup look include/plugin.php
-        if (!func_num_args()) {
-            $newbbConfig = newbbLoadConfig();
-            $expire      = isset($newbbConfig['pending_expire']) ? (int)$newbbConfig['pending_expire'] : 7;
-            $expire      = $expire * 24 * 3600; // days to seconds
-        }
-        if (empty($expire)) {
-            return false;
-        }
-        $crit_expire = new \CriteriaCompo(new \Criteria('approved', 0, '<='));
-        $crit_expire->add(new \Criteria('topic_time', time() - (int)$expire, '<'));
-
-        return $this->deleteAll($crit_expire, true/*, true*/);
-    }
-
-    // START irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
-
-    /**
-     * @param  null $object
-     * @param  bool $force
-     * @return bool
-     */
-    public function synchronization($object = null, $force = true)
-    {
-        if (!is_object($object)) {
-            $object = $this->get((int)$object);
-        }
-        if (!is_object($object) || !$object->getVar('topic_id')) {
-            return false;
-        }
-
-        /** @var Newbb\PostHandler $postHandler */
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $criteria    = new \CriteriaCompo();
-        $criteria->add(new \Criteria('topic_id', $object->getVar('topic_id')), 'AND');
-        $criteria->add(new \Criteria('approved', 1), 'AND');
-        $post_ids = $postHandler->getIds($criteria);
-        if (empty($post_ids)) {
-            return false;
-        }
-        $last_post     = max($post_ids);
-        $top_post      = min($post_ids);
-        $topic_replies = count($post_ids) - 1;
-        if ($object->getVar('topic_last_post_id') != $last_post) {
-            $object->setVar('topic_last_post_id', $last_post);
-        }
-        if ($object->getVar('topic_replies') != $topic_replies) {
-            $object->setVar('topic_replies', $topic_replies);
-        }
-        $b1 = $this->insert($object, $force);
-        $criteria->add(new \Criteria('post_id', $top_post, '<>'), 'AND');
-        $criteria->add(new \Criteria('pid', '(' . implode(', ', $post_ids) . ')', 'NOT IN'), 'AND');
-        $b2       = $postHandler->updateAll('pid', $top_post, $criteria, $force);
-        $criteria = new \CriteriaCompo();
-        $criteria->add(new \Criteria('post_id', $top_post, '='), 'AND');
-        $b3 = $postHandler->updateAll('pid', 0, $criteria, $force);
-
-        return ($b1 && $b2 && $b3);
-    }
-    // END irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
-    // START irmtfan getActivePolls
-    /**
-     * get all active poll modules in the current xoops installtion.
-     * @access public
-     * @return array $pollDirs = array($dirname1=>$dirname1, $dirname2=>$dirname2, ...) dirnames of all active poll modules
-     */
-    public function getActivePolls()
-    {
-        $pollDirs = [];
-        $allDirs  = xoops_getActiveModules();
-        foreach ($allDirs as $dirname) {
-            // pollresults.php file is exist in all xoopspoll versions and umfrage versions
-            if (file_exists($GLOBALS['xoops']->path('modules/' . $dirname . '/pollresults.php'))) {
-                $pollDirs[$dirname] = $dirname;
-            }
-        }
-
-        return $pollDirs;
-    }
-    // END irmtfan getActivePolls
-
-    // START irmtfan findPollModule
-    /**
-     * find poll module that is in used in the current newbb installtion.
-     * @access public
-     * @param  array $pollDirs dirnames of all active poll modules
-     * @return bool|string $dir_def | true | false
-     *                         $dir_def: dirname of poll module that is in used in the current newbb installtion.
-     *                         true: no poll module is installed | newbb has no topic with poll | newbb has no topic
-     *                         false: errors (see below xoops_errors)
-     */
-    public function findPollModule(array $pollDirs = [])
-    {
-        $dir_def = '';
-        if (empty($pollDirs)) {
-            $pollDirs = $this->getActivePolls();
-        }
-        if (empty($pollDirs)) {
-            return true;
-        }
-        // if only one active poll module still we need to check!!!
-        //if(count($pollDirs) === 1) return end($pollDirs);
-        $topicPollObjs = $this->getAll(new \Criteria('topic_haspoll', 1), ['topic_id', 'poll_id']);
-        if (empty($topicPollObjs)) {
-            return true;
-        } // no poll or no topic!!!
-        foreach ($topicPollObjs as $tObj) {
-            $poll_idInMod = 0;
-            foreach ($pollDirs as $dirname) {
-                $pollObj = $tObj->getPoll($tObj->getVar('poll_id'), $dirname);
-                if (is_object($pollObj) && ($pollObj->getVar('poll_id') == $tObj->getVar('poll_id'))) {
-                    ++$poll_idInMod;
-                    $dir_def = $dirname;
-                }
-            }
-            // Only one poll module should has this poll_id
-            // if 0 there is an error
-            if (0 == $poll_idInMod) {
-                xoops_error("Error: Cannot find poll module for poll_id='{$tObj->getVar('poll_id')}'");
-
-                return false;
-            }
-            // if 1 => $dir_def is correct
-            if (1 == $poll_idInMod) {
-                return $dir_def;
-            }
-            // if more than 1 continue
-        }
-        // if there is some topics but no module or more than one module have polls
-        xoops_error("Error: Cannot find poll module that is in used in newbb!!! <br\><br\>You should select the correct poll module yourself in newbb > preferences > poll module setting.");
-
-        return false;
-    }
-    // END irmtfan findPollModule
+		$result = $this->db->query($sql);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return $post;
+		}
+		/** @var Newbb\PostHandler $postHandler */
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$myrow       = $this->db->fetchArray($result);
+		/** @var Newbb\Post $post */
+		$post = $postHandler->create(false);
+		$post->assignVars($myrow);
+
+		return $post;
+	}
+
+	/**
+	 * @param $topic_id
+	 * @return bool
+	 */
+	public function getTopPostId($topic_id)
+	{
+		$sql    = 'SELECT MIN(post_id) AS post_id FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id = ' . $topic_id . ' AND pid = 0';
+		$result = $this->db->query($sql);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return false;
+		}
+		list($post_id) = $this->db->fetchRow($result);
+
+		return $post_id;
+	}
+
+	/**
+	 * @param         $topic
+	 * @param  string $order
+	 * @param  int    $perpage
+	 * @param         $start
+	 * @param  int    $post_id
+	 * @param  string $type
+	 * @return array
+	 */
+	public function &getAllPosts(&$topic, $order = 'ASC', $perpage = 10, &$start, $post_id = 0, $type = '')
+	{
+		$ret     = [];
+		$perpage = ((int)$perpage > 0) ? (int)$perpage : (empty($GLOBALS['xoopsModuleConfig']['posts_per_page']) ? 10 : $GLOBALS['xoopsModuleConfig']['posts_per_page']);
+		$start   = (int)$start;
+		switch ($type) {
+			case 'pending':
+				$approveCriteria = ' AND p.approved = 0';
+				break;
+			case 'deleted':
+				$approveCriteria = ' AND p.approved = -1';
+				break;
+			default:
+				$approveCriteria = ' AND p.approved = 1';
+				break;
+		}
+
+		if ($post_id) {
+			if ('DESC' === $order) {
+				$operator_for_position = '>';
+			} else {
+				$order                 = 'ASC';
+				$operator_for_position = '<';
+			}
+			//$approveCriteria = ' AND approved = 1'; // any others?
+			$sql    = 'SELECT COUNT(*) FROM ' . $this->db->prefix('newbb_posts') . ' AS p WHERE p.topic_id=' . (int)$topic->getVar('topic_id') . $approveCriteria . " AND p.post_id $operator_for_position $post_id";
+			$result = $this->db->query($sql);
+			if (!$result) {
+				//xoops_error($this->db->error());
+				return $ret;
+			}
+			list($position) = $this->db->fetchRow($result);
+			$start = (int)($position / $perpage) * $perpage;
+		}
+
+		$sql    = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p, ' . $this->db->prefix('newbb_posts_text') . ' t WHERE p.topic_id=' . $topic->getVar('topic_id') . ' AND p.post_id = t.post_id' . $approveCriteria . " ORDER BY p.post_id $order";
+		$result = $this->db->query($sql, $perpage, $start);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return $ret;
+		}
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		while (false !== ($myrow = $this->db->fetchArray($result))) {
+			$post = $postHandler->create(false);
+			$post->assignVars($myrow);
+			$ret[$myrow['post_id']] = $post;
+			unset($post);
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * @param        $postArray
+	 * @param  int   $pid
+	 * @return mixed
+	 */
+	public function &getPostTree(&$postArray, $pid = 0)
+	{
+		//        require_once $GLOBALS['xoops']->path('modules/newbb/class/Tree.php');
+		$NewBBTree = new Newbb\Tree('newbb_posts');
+		$NewBBTree->setPrefix('&nbsp;&nbsp;');
+		$NewBBTree->setPostArray($postArray);
+		$NewBBTree->getPostTree($postsArray, $pid);
+
+		return $postsArray;
+	}
+
+	/**
+	 * @param $topic
+	 * @param $postArray
+	 * @return mixed
+	 */
+	public function showTreeItem(&$topic, &$postArray)
+	{
+		global $viewtopic_users, $myts;
+
+		$postArray['post_time'] = newbbFormatTimestamp($postArray['post_time']);
+
+		if (!empty($postArray['icon'])) {
+			$postArray['icon'] = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($postArray['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
+		} else {
+			$postArray['icon'] = '<a name="' . $postArray['post_id'] . '"><img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" /></a>';
+		}
+
+		$postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id=' . $topic->getVar('topic_id') . '&amp;forum=' . $postArray['forum_id'] . '&amp;post_id=' . $postArray['post_id'] . '">' . $postArray['subject'] . '</a>';
+
+		$isActiveUser = false;
+		if (isset($viewtopic_users[$postArray['uid']]['name'])) {
+			$postArray['poster'] = $viewtopic_users[$postArray['uid']]['name'];
+			if ($postArray['uid'] > 0) {
+				$postArray['poster'] = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $postArray['uid'] . '">' . $viewtopic_users[$postArray['uid']]['name'] . '</a>';
+			}
+		} else {
+			$postArray['poster'] = empty($postArray['poster_name']) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $postArray['poster_name'];
+		}
+
+		return $postArray;
+	}
+
+	/**
+	 * @param        $topic
+	 * @param  bool  $isApproved
+	 * @return array
+	 */
+	public function &getAllPosters(&$topic, $isApproved = true)
+	{
+		$sql = 'SELECT DISTINCT uid FROM ' . $this->db->prefix('newbb_posts') . '  WHERE topic_id=' . $topic->getVar('topic_id') . ' AND uid>0';
+		if ($isApproved) {
+			$sql .= ' AND approved = 1';
+		}
+		$result = $this->db->query($sql);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return [];
+		}
+		$ret = [];
+		while (false !== ($myrow = $this->db->fetchArray($result))) {
+			$ret[] = $myrow['uid'];
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * @param Topic|\XoopsObject $topic
+	 * @param  bool        $force
+	 * @return bool
+	 */
+	public function delete(\XoopsObject $topic, $force = true)
+	{
+		$topic_id = is_object($topic) ? $topic->getVar('topic_id') : (int)$topic;
+		if (empty($topic_id)) {
+			return false;
+		}
+		$postObject = $this->getTopPost($topic_id);
+		/** @var Newbb\PostHandler $postHandler */
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$postHandler->delete($postObject, false, $force);
+
+		$newbbConfig = newbbLoadConfig();
+		/** @var \XoopsModules\Tag\TagHandler $tagHandler */
+		if (!empty($newbbConfig['do_tag']) && $tagHandler = Tag\Helper::getInstance()->getHandler('Tag')) { //@xoops_getModuleHandler('tag', 'tag', true)) {
+			$tagHandler->updateByItem([], $topic_id, 'newbb');
+		}
+
+		return true;
+	}
+
+	// get permission
+	// parameter: $type: 'post', 'view',  'reply', 'edit', 'delete', 'addpoll', 'vote', 'attach'
+	// $gperm_names = "'forum_can_post', 'forum_can_view', 'forum_can_reply', 'forum_can_edit', 'forum_can_delete', 'forum_can_addpoll', 'forum_can_vote', 'forum_can_attach', 'forum_can_noapprove'";
+	/**
+	 * @param   Newbb\Forum $forum
+	 * @param  int     $topic_locked
+	 * @param  string  $type
+	 * @return bool
+	 */
+	public function getPermission($forum, $topic_locked = 0, $type = 'view')
+	{
+		static $_cachedTopicPerms;
+		require_once  dirname(__DIR__) . '/include/functions.user.php';
+		if (newbbIsAdmin($forum)) {
+			return true;
+		}
+
+		$forum_id = is_object($forum) ? $forum->getVar('forum_id') : (int)$forum;
+		if ($forum_id < 1) {
+			return false;
+		}
+
+		if ($topic_locked && 'view' !== $type) {
+			$permission = false;
+		} else {
+			/** var Newbb\PermissionHandler $permHandler */
+			$permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
+			$permission  = $permHandler->getPermission('forum', $type, $forum_id);
+		}
+
+		return $permission;
+	}
+
+	/**
+	 * clean orphan items from database
+	 *
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @return bool   true on success
+	 */
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
+	{
+		$this->deleteAll(new \Criteria('topic_time', 0), true, true);
+		parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id');
+		parent::cleanOrphan($this->db->prefix('newbb_posts'), 'topic_id');
+
+		return true;
+	}
+
+	/**
+	 * clean expired objects from database
+	 *
+	 * @param  int $expire time limit for expiration
+	 * @return bool true on success
+	 */
+	public function cleanExpires($expire = 0)
+	{
+		// irmtfan if 0 no cleanup look include/plugin.php
+		if (!func_num_args()) {
+			$newbbConfig = newbbLoadConfig();
+			$expire      = isset($newbbConfig['pending_expire']) ? (int)$newbbConfig['pending_expire'] : 7;
+			$expire      = $expire * 24 * 3600; // days to seconds
+		}
+		if (empty($expire)) {
+			return false;
+		}
+		$crit_expire = new \CriteriaCompo(new \Criteria('approved', 0, '<='));
+		$crit_expire->add(new \Criteria('topic_time', time() - (int)$expire, '<'));
+
+		return $this->deleteAll($crit_expire, true/*, true*/);
+	}
+
+	// START irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
+
+	/**
+	 * @param  null $object
+	 * @param  bool $force
+	 * @return bool
+	 */
+	public function synchronization($object = null, $force = true)
+	{
+		if (!is_object($object)) {
+			$object = $this->get((int)$object);
+		}
+		if (!is_object($object) || !$object->getVar('topic_id')) {
+			return false;
+		}
+
+		/** @var Newbb\PostHandler $postHandler */
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$criteria    = new \CriteriaCompo();
+		$criteria->add(new \Criteria('topic_id', $object->getVar('topic_id')), 'AND');
+		$criteria->add(new \Criteria('approved', 1), 'AND');
+		$post_ids = $postHandler->getIds($criteria);
+		if (empty($post_ids)) {
+			return false;
+		}
+		$last_post     = max($post_ids);
+		$top_post      = min($post_ids);
+		$topic_replies = count($post_ids) - 1;
+		if ($object->getVar('topic_last_post_id') != $last_post) {
+			$object->setVar('topic_last_post_id', $last_post);
+		}
+		if ($object->getVar('topic_replies') != $topic_replies) {
+			$object->setVar('topic_replies', $topic_replies);
+		}
+		$b1 = $this->insert($object, $force);
+		$criteria->add(new \Criteria('post_id', $top_post, '<>'), 'AND');
+		$criteria->add(new \Criteria('pid', '(' . implode(', ', $post_ids) . ')', 'NOT IN'), 'AND');
+		$b2       = $postHandler->updateAll('pid', $top_post, $criteria, $force);
+		$criteria = new \CriteriaCompo();
+		$criteria->add(new \Criteria('post_id', $top_post, '='), 'AND');
+		$b3 = $postHandler->updateAll('pid', 0, $criteria, $force);
+
+		return ($b1 && $b2 && $b3);
+	}
+	// END irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
+	// START irmtfan getActivePolls
+	/**
+	 * get all active poll modules in the current xoops installtion.
+	 * @access public
+	 * @return array $pollDirs = array($dirname1=>$dirname1, $dirname2=>$dirname2, ...) dirnames of all active poll modules
+	 */
+	public function getActivePolls()
+	{
+		$pollDirs = [];
+		$allDirs  = xoops_getActiveModules();
+		foreach ($allDirs as $dirname) {
+			// pollresults.php file is exist in all xoopspoll versions and umfrage versions
+			if (file_exists($GLOBALS['xoops']->path('modules/' . $dirname . '/pollresults.php'))) {
+				$pollDirs[$dirname] = $dirname;
+			}
+		}
+
+		return $pollDirs;
+	}
+	// END irmtfan getActivePolls
+
+	// START irmtfan findPollModule
+	/**
+	 * find poll module that is in used in the current newbb installtion.
+	 * @access public
+	 * @param  array $pollDirs dirnames of all active poll modules
+	 * @return bool|string $dir_def | true | false
+	 *                         $dir_def: dirname of poll module that is in used in the current newbb installtion.
+	 *                         true: no poll module is installed | newbb has no topic with poll | newbb has no topic
+	 *                         false: errors (see below xoops_errors)
+	 */
+	public function findPollModule(array $pollDirs = [])
+	{
+		$dir_def = '';
+		if (empty($pollDirs)) {
+			$pollDirs = $this->getActivePolls();
+		}
+		if (empty($pollDirs)) {
+			return true;
+		}
+		// if only one active poll module still we need to check!!!
+		//if(count($pollDirs) === 1) return end($pollDirs);
+		$topicPollObjs = $this->getAll(new \Criteria('topic_haspoll', 1), ['topic_id', 'poll_id']);
+		if (empty($topicPollObjs)) {
+			return true;
+		} // no poll or no topic!!!
+		foreach ($topicPollObjs as $tObj) {
+			$poll_idInMod = 0;
+			foreach ($pollDirs as $dirname) {
+				$pollObj = $tObj->getPoll($tObj->getVar('poll_id'), $dirname);
+				if (is_object($pollObj) && ($pollObj->getVar('poll_id') == $tObj->getVar('poll_id'))) {
+					++$poll_idInMod;
+					$dir_def = $dirname;
+				}
+			}
+			// Only one poll module should has this poll_id
+			// if 0 there is an error
+			if (0 == $poll_idInMod) {
+				xoops_error("Error: Cannot find poll module for poll_id='{$tObj->getVar('poll_id')}'");
+
+				return false;
+			}
+			// if 1 => $dir_def is correct
+			if (1 == $poll_idInMod) {
+				return $dir_def;
+			}
+			// if more than 1 continue
+		}
+		// if there is some topics but no module or more than one module have polls
+		xoops_error("Error: Cannot find poll module that is in used in newbb!!! <br\><br\>You should select the correct poll module yourself in newbb > preferences > poll module setting.");
+
+		return false;
+	}
+	// END irmtfan findPollModule
 }

class/User.php

Indentation +243 added lines, -243 removed lines

@@ -22,74 +22,74 @@ 
 function newbb_calculateLevel($RPG, $RPGDIFF)
 {
 
-    //$RPG = $user->getVar('posts');
-    //$RPGDIFF = $user->getVar('user_regdate');
-
-    $today = time();
-    $diff  = $today - $RPGDIFF;
-    $exp   = round($diff / 86400, 0);
-    if ($exp <= 0) {
-        $exp = 1;
-    }
-    $ppd       = round($RPG / $exp, 0);
-    $level     = log10($RPG) ** 3;
-    $ep        = floor(100 * ($level - floor($level)));
-    $showlevel = floor($level + 1);
-    $hpmulti   = round($ppd / 6, 1);
-    if ($hpmulti > 1.5) {
-        $hpmulti = 1.5;
-    }
-    if ($hpmulti < 1) {
-        $hpmulti = 1;
-    }
-    $maxhp = $level * 25 * $hpmulti;
-    $hp    = $ppd / 5;
-    if ($hp >= 1) {
-        $hp = $maxhp;
-    } else {
-        $hp = floor($hp * $maxhp);
-    }
-    $hp    = floor($hp);
-    $maxhp = floor($maxhp);
-    $zhp   = $maxhp;
-    if ($maxhp <= 0) {
-        $zhp = 1;
-    }
-    $hpf   = floor(100 * ($hp / $zhp)) - 1;
-    $maxmp = ($exp * $level) / 5;
-    $mp    = $RPG / 3;
-    if ($mp >= $maxmp) {
-        $mp = $maxmp;
-    }
-    $maxmp = floor($maxmp);
-    $mp    = floor($mp);
-    $zmp   = $maxmp;
-    if ($maxmp <= 0) {
-        $zmp = 1;
-    }
-    $mpf = floor(100 * ($mp / $zmp)) - 1;
-    if ($hpf >= 98) {
-        $hpf -= 2;
-    }
-    if ($ep >= 98) {
-        $ep -= 2;
-    }
-    if ($mpf >= 98) {
-        $mpf -= 2;
-    }
-
-    $level              = [];
-    $level['level']     = $showlevel;
-    $level['exp']       = $ep;
-    $level['exp_width'] = $ep . '%';
-    $level['hp']        = $hp;
-    $level['hp_max']    = $maxhp;
-    $level['hp_width']  = $hpf . '%';
-    $level['mp']        = $mp;
-    $level['mp_max']    = $maxmp;
-    $level['mp_width']  = $mpf . '%';
-
-    return $level;
+	//$RPG = $user->getVar('posts');
+	//$RPGDIFF = $user->getVar('user_regdate');
+
+	$today = time();
+	$diff  = $today - $RPGDIFF;
+	$exp   = round($diff / 86400, 0);
+	if ($exp <= 0) {
+		$exp = 1;
+	}
+	$ppd       = round($RPG / $exp, 0);
+	$level     = log10($RPG) ** 3;
+	$ep        = floor(100 * ($level - floor($level)));
+	$showlevel = floor($level + 1);
+	$hpmulti   = round($ppd / 6, 1);
+	if ($hpmulti > 1.5) {
+		$hpmulti = 1.5;
+	}
+	if ($hpmulti < 1) {
+		$hpmulti = 1;
+	}
+	$maxhp = $level * 25 * $hpmulti;
+	$hp    = $ppd / 5;
+	if ($hp >= 1) {
+		$hp = $maxhp;
+	} else {
+		$hp = floor($hp * $maxhp);
+	}
+	$hp    = floor($hp);
+	$maxhp = floor($maxhp);
+	$zhp   = $maxhp;
+	if ($maxhp <= 0) {
+		$zhp = 1;
+	}
+	$hpf   = floor(100 * ($hp / $zhp)) - 1;
+	$maxmp = ($exp * $level) / 5;
+	$mp    = $RPG / 3;
+	if ($mp >= $maxmp) {
+		$mp = $maxmp;
+	}
+	$maxmp = floor($maxmp);
+	$mp    = floor($mp);
+	$zmp   = $maxmp;
+	if ($maxmp <= 0) {
+		$zmp = 1;
+	}
+	$mpf = floor(100 * ($mp / $zmp)) - 1;
+	if ($hpf >= 98) {
+		$hpf -= 2;
+	}
+	if ($ep >= 98) {
+		$ep -= 2;
+	}
+	if ($mpf >= 98) {
+		$mpf -= 2;
+	}
+
+	$level              = [];
+	$level['level']     = $showlevel;
+	$level['exp']       = $ep;
+	$level['exp_width'] = $ep . '%';
+	$level['hp']        = $hp;
+	$level['hp_max']    = $maxhp;
+	$level['hp_width']  = $hpf . '%';
+	$level['mp']        = $mp;
+	$level['mp_max']    = $maxmp;
+	$level['mp_width']  = $mpf . '%';
+
+	return $level;
 }
 
 /**
@@ -97,179 +97,179 @@ 
  */
 class User
 {
-    public $user;
-
-    public function __construct()
-    {
-    }
-
-    /**
-     * @return array
-     */
-    public function getUserbar()
-    {
-        global $isAdmin;
-
-        $userbar = [];
-        if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
-            return $userbar;
-        }
-
-        $user               = $this->user;
-        $userbar['profile'] = [
-            'link' => XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid'),
-            'name' => _PROFILE
-        ];
-
-        if (is_object($GLOBALS['xoopsUser'])) {
-            $userbar['pm'] = [
-                'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . $user->getVar('uid') . "', 'pmlite', 450, 380);",
-                'name' => _MD_NEWBB_PM
-            ];
-        }
-        if ($user->getVar('user_viewemail') || $isAdmin) {
-            $userbar['email'] = [
-                'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "', 'new');",
-                'name' => _MD_NEWBB_EMAIL
-            ];
-        }
-        if ($url = $user->getVar('url')) {
-            $userbar['url'] = [
-                'link' => "javascript:void window.open('" . $url . "', 'new');",
-                'name' => _MD_NEWBB_WWW
-            ];
-        }
-        if ($icq = $user->getVar('user_icq')) {
-            $userbar['icq'] = [
-                'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $icq . "', 'new');",
-                'name' => _MD_NEWBB_ICQ
-            ];
-        }
-        if ($aim = $user->getVar('user_aim')) {
-            $userbar['aim'] = [
-                'link' => "javascript:void window.open('aim:goim?screenname=" . $aim . '&amp;message=Hi+' . $aim . '+Are+you+there?' . "', 'new');",
-                'name' => _MD_NEWBB_AIM
-            ];
-        }
-        if ($yim = $user->getVar('user_yim')) {
-            $userbar['yim'] = [
-                'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $yim . '&.src=pg' . "', 'new');",
-                'name' => _MD_NEWBB_YIM
-            ];
-        }
-        if ($msn = $user->getVar('user_msnm')) {
-            $userbar['msnm'] = [
-                'link' => "javascript:void window.open('http://members.msn.com?mem=" . $msn . "', 'new');",
-                'name' => _MD_NEWBB_MSNM
-            ];
-        }
-
-        return $userbar;
-    }
-
-    /**
-     * @return string
-     */
-    public function getLevel()
-    {
-        global $forumUrl;
-
-        $level = newbb_calculateLevel($this->user->getVar('posts'), $this->user->getVar('user_regdate'));
-        $info  = '';
-        if (2 == $GLOBALS['xoopsModuleConfig']['user_level']) {
-            static $rpg_images;
-            if (null === $rpg_images) {
-                $iconHandler = newbbGetIconHandler();
-                $rpg_path    = $iconHandler->getPath('rpg');
-                foreach (['img_left', 'img_backing', 'img_right', 'blue', 'green', 'orange'] as $img) {
-                    // irmtfan fix: double "/" removed
-                    $rpg_images[$img] = XOOPS_URL . $rpg_path . '/' . $img . '.gif';
-                }
-            }
-            // irmtfan hardcore removed align="left"
-            $table = "<table class='userlevel'><tr><td class='end'><img src='"
-                     . $rpg_images['img_left']
-                     . "' alt='' /></td><td class='center' background='"
-                     . $rpg_images['img_backing']
-                     . "'><img src='%s' width='%d' alt='' class='icon_left' /></td><td><img src='"
-                     . $rpg_images['img_right']
-                     . "' alt='' /></td></tr></table>";
-
-            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '<br><span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>' . sprintf($table, $rpg_images['orange'], $level['hp_width']);
-            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span><br>' . sprintf($table, $rpg_images['green'], $level['mp_width']);
-            $info .= '<span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>' . sprintf($table, $rpg_images['blue'], $level['exp_width']);
-        } else {
-            $info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '; <span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>';
-            $info .= '<span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>';
-            $info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span>';
-        }
-
-        return $info;
-    }
-
-    /**
-     * @param \XoopsUser $user
-     * @return mixed
-     */
-    public function getInfo(&$user)
-    {
-        global $myts;
-        static $name_anonymous;
-
-        if (!is_object($user) || !$user->isActive()) {
-            if (null === $name_anonymous) {
-                $name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
-            }
-
-            return ['name' => $name_anonymous, 'link' => $name_anonymous];
-        }
-
-        $this->user = $user;
-
-        $userinfo['uid'] = $user->getVar('uid');
-
-        $name             = empty($GLOBALS['xoopsModuleConfig']['show_realname']) ? $user->getVar('uname') : $user->getVar('name');
-        $userinfo['name'] = $name ?: $user->getVar('uname');
-
-        $userinfo['link'] = '<a href=\'' . XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid') . '\'>' . $userinfo['name'] . '</a>';
-
-        $userinfo['avatar'] = $user->getVar('user_avatar');
-        // START hacked by irmtfan - easier rank getting - consistency with previous version back rank.title and rank.image
-        $userrank         = $user->rank();
-        $userinfo['rank'] = [];
-        if (isset($userrank['image']) && $userrank['image']) {
-            $userinfo['rank']['image'] = $userrank['image'];
-            $userinfo['rank']['title'] = $userrank['title'];
-        }
-        // END hacked by irmtfan - easier rank getting  - a little correctness dot removed
-        // START hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
-        //checks for user's groups
-        $userinfo['groups'] = [];
-        /** @var \XoopsMemberHandler $memberHandler */
-        $memberHandler = xoops_getHandler('member');
-        $usergroups    = $memberHandler->getGroupsByUser($userinfo['uid'], true);
-        foreach ($usergroups as $group) {
-            $userinfo['groups'][] = $group->getVar('name');
-        }
-        // END hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
-        $userinfo['from'] = $user->getVar('user_from');
-
-        require_once  dirname(__DIR__) . '/include/functions.time.php';
-        $userinfo['regdate']    = newbbFormatTimestamp($user->getVar('user_regdate'), 'reg');
-        $userinfo['last_login'] = newbbFormatTimestamp($user->getVar('last_login')); // irmtfan add last_login
-
-        $userinfo['posts'] = $user->getVar('posts');
-
-        if (!empty($GLOBALS['xoopsModuleConfig']['user_level'])) {
-            $userinfo['level'] = $this->getLevel();
-        }
-
-        if (!empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
-            $userinfo['userbar'] = $this->getUserbar();
-        }
-
-        $userinfo['signature'] = $user->getVar('user_sig');
-
-        return $userinfo;
-    }
+	public $user;
+
+	public function __construct()
+	{
+	}
+
+	/**
+	 * @return array
+	 */
+	public function getUserbar()
+	{
+		global $isAdmin;
+
+		$userbar = [];
+		if (empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
+			return $userbar;
+		}
+
+		$user               = $this->user;
+		$userbar['profile'] = [
+			'link' => XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid'),
+			'name' => _PROFILE
+		];
+
+		if (is_object($GLOBALS['xoopsUser'])) {
+			$userbar['pm'] = [
+				'link' => "javascript:void openWithSelfMain('" . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . $user->getVar('uid') . "', 'pmlite', 450, 380);",
+				'name' => _MD_NEWBB_PM
+			];
+		}
+		if ($user->getVar('user_viewemail') || $isAdmin) {
+			$userbar['email'] = [
+				'link' => "javascript:void window.open('mailto:" . $user->getVar('email') . "', 'new');",
+				'name' => _MD_NEWBB_EMAIL
+			];
+		}
+		if ($url = $user->getVar('url')) {
+			$userbar['url'] = [
+				'link' => "javascript:void window.open('" . $url . "', 'new');",
+				'name' => _MD_NEWBB_WWW
+			];
+		}
+		if ($icq = $user->getVar('user_icq')) {
+			$userbar['icq'] = [
+				'link' => "javascript:void window.open('http://wwp.icq.com/scripts/search.dll?to=" . $icq . "', 'new');",
+				'name' => _MD_NEWBB_ICQ
+			];
+		}
+		if ($aim = $user->getVar('user_aim')) {
+			$userbar['aim'] = [
+				'link' => "javascript:void window.open('aim:goim?screenname=" . $aim . '&amp;message=Hi+' . $aim . '+Are+you+there?' . "', 'new');",
+				'name' => _MD_NEWBB_AIM
+			];
+		}
+		if ($yim = $user->getVar('user_yim')) {
+			$userbar['yim'] = [
+				'link' => "javascript:void window.open('http://edit.yahoo.com/config/send_webmesg?.target=" . $yim . '&.src=pg' . "', 'new');",
+				'name' => _MD_NEWBB_YIM
+			];
+		}
+		if ($msn = $user->getVar('user_msnm')) {
+			$userbar['msnm'] = [
+				'link' => "javascript:void window.open('http://members.msn.com?mem=" . $msn . "', 'new');",
+				'name' => _MD_NEWBB_MSNM
+			];
+		}
+
+		return $userbar;
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getLevel()
+	{
+		global $forumUrl;
+
+		$level = newbb_calculateLevel($this->user->getVar('posts'), $this->user->getVar('user_regdate'));
+		$info  = '';
+		if (2 == $GLOBALS['xoopsModuleConfig']['user_level']) {
+			static $rpg_images;
+			if (null === $rpg_images) {
+				$iconHandler = newbbGetIconHandler();
+				$rpg_path    = $iconHandler->getPath('rpg');
+				foreach (['img_left', 'img_backing', 'img_right', 'blue', 'green', 'orange'] as $img) {
+					// irmtfan fix: double "/" removed
+					$rpg_images[$img] = XOOPS_URL . $rpg_path . '/' . $img . '.gif';
+				}
+			}
+			// irmtfan hardcore removed align="left"
+			$table = "<table class='userlevel'><tr><td class='end'><img src='"
+					 . $rpg_images['img_left']
+					 . "' alt='' /></td><td class='center' background='"
+					 . $rpg_images['img_backing']
+					 . "'><img src='%s' width='%d' alt='' class='icon_left' /></td><td><img src='"
+					 . $rpg_images['img_right']
+					 . "' alt='' /></td></tr></table>";
+
+			$info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '<br><span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>' . sprintf($table, $rpg_images['orange'], $level['hp_width']);
+			$info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span><br>' . sprintf($table, $rpg_images['green'], $level['mp_width']);
+			$info .= '<span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>' . sprintf($table, $rpg_images['blue'], $level['exp_width']);
+		} else {
+			$info = _MD_NEWBB_LEVEL . ' ' . $level['level'] . '; <span title="' . _MD_NEWBB_EXP_DESC . '">' . _MD_NEWBB_EXP . ' ' . $level['exp'] . '</span><br>';
+			$info .= '<span title="' . _MD_NEWBB_HP_DESC . '">' . _MD_NEWBB_HP . ' ' . $level['hp'] . ' / ' . $level['hp_max'] . '</span><br>';
+			$info .= '<span title="' . _MD_NEWBB_MP_DESC . '">' . _MD_NEWBB_MP . ' ' . $level['mp'] . ' / ' . $level['mp_max'] . '</span>';
+		}
+
+		return $info;
+	}
+
+	/**
+	 * @param \XoopsUser $user
+	 * @return mixed
+	 */
+	public function getInfo(&$user)
+	{
+		global $myts;
+		static $name_anonymous;
+
+		if (!is_object($user) || !$user->isActive()) {
+			if (null === $name_anonymous) {
+				$name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
+			}
+
+			return ['name' => $name_anonymous, 'link' => $name_anonymous];
+		}
+
+		$this->user = $user;
+
+		$userinfo['uid'] = $user->getVar('uid');
+
+		$name             = empty($GLOBALS['xoopsModuleConfig']['show_realname']) ? $user->getVar('uname') : $user->getVar('name');
+		$userinfo['name'] = $name ?: $user->getVar('uname');
+
+		$userinfo['link'] = '<a href=\'' . XOOPS_URL . '/userinfo.php?uid=' . $user->getVar('uid') . '\'>' . $userinfo['name'] . '</a>';
+
+		$userinfo['avatar'] = $user->getVar('user_avatar');
+		// START hacked by irmtfan - easier rank getting - consistency with previous version back rank.title and rank.image
+		$userrank         = $user->rank();
+		$userinfo['rank'] = [];
+		if (isset($userrank['image']) && $userrank['image']) {
+			$userinfo['rank']['image'] = $userrank['image'];
+			$userinfo['rank']['title'] = $userrank['title'];
+		}
+		// END hacked by irmtfan - easier rank getting  - a little correctness dot removed
+		// START hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
+		//checks for user's groups
+		$userinfo['groups'] = [];
+		/** @var \XoopsMemberHandler $memberHandler */
+		$memberHandler = xoops_getHandler('member');
+		$usergroups    = $memberHandler->getGroupsByUser($userinfo['uid'], true);
+		foreach ($usergroups as $group) {
+			$userinfo['groups'][] = $group->getVar('name');
+		}
+		// END hacked by irmtfan - easier groups getting - can we use $_SESSION['xoopsUserGroups']???
+		$userinfo['from'] = $user->getVar('user_from');
+
+		require_once  dirname(__DIR__) . '/include/functions.time.php';
+		$userinfo['regdate']    = newbbFormatTimestamp($user->getVar('user_regdate'), 'reg');
+		$userinfo['last_login'] = newbbFormatTimestamp($user->getVar('last_login')); // irmtfan add last_login
+
+		$userinfo['posts'] = $user->getVar('posts');
+
+		if (!empty($GLOBALS['xoopsModuleConfig']['user_level'])) {
+			$userinfo['level'] = $this->getLevel();
+		}
+
+		if (!empty($GLOBALS['xoopsModuleConfig']['userbar_enabled'])) {
+			$userinfo['userbar'] = $this->getUserbar();
+		}
+
+		$userinfo['signature'] = $user->getVar('user_sig');
+
+		return $userinfo;
+	}
 }

include/functions.config.php

Indentation +32 added lines, -32 removed lines

@@ -17,37 +17,37 @@
 define('NEWBB_FUNCTIONS_CONFIG_LOADED', true);
 
 if (!defined('NEWBB_FUNCTIONS_CONFIG')) {
-    define('NEWBB_FUNCTIONS_CONFIG', 1);
-
-    /**
-     * @return array
-     * @internal param string $category
-     * @internal param string $dirname
-     */
-    function newbbLoadConfig()
-    {
+	define('NEWBB_FUNCTIONS_CONFIG', 1);
+
+	/**
+	 * @return array
+	 * @internal param string $category
+	 * @internal param string $dirname
+	 */
+	function newbbLoadConfig()
+	{
 //        require_once dirname(__DIR__) . '/class/Helper.php';
-        //$helper = NewBB::getInstance();
-        /** @var \XoopsModules\Newbb\Helper $helper */
-        $helper = \XoopsModules\Newbb\Helper::getInstance();
-        static $configs = null;
-
-        if (null !== $configs) {
-            return $configs;
-        }
-
-        $configs = is_object($helper) ? $helper->getConfig() : [];
-        $plugins = require __DIR__   . '/plugin.php';
-        if (is_array($configs) && is_array($plugins)) {
-            $configs = array_merge($configs, $plugins);
-        }
-        if (!isset($GLOBALS['xoopsModuleConfig'])) {
-            $GLOBALS['xoopsModuleConfig'] = [];
-        }
-        if (is_array($configs)) {
-            $GLOBALS['xoopsModuleConfig'] = array_merge($GLOBALS['xoopsModuleConfig'], $configs);
-        }
-
-        return $configs;
-    }
+		//$helper = NewBB::getInstance();
+		/** @var \XoopsModules\Newbb\Helper $helper */
+		$helper = \XoopsModules\Newbb\Helper::getInstance();
+		static $configs = null;
+
+		if (null !== $configs) {
+			return $configs;
+		}
+
+		$configs = is_object($helper) ? $helper->getConfig() : [];
+		$plugins = require __DIR__   . '/plugin.php';
+		if (is_array($configs) && is_array($plugins)) {
+			$configs = array_merge($configs, $plugins);
+		}
+		if (!isset($GLOBALS['xoopsModuleConfig'])) {
+			$GLOBALS['xoopsModuleConfig'] = [];
+		}
+		if (is_array($configs)) {
+			$GLOBALS['xoopsModuleConfig'] = array_merge($GLOBALS['xoopsModuleConfig'], $configs);
+		}
+
+		return $configs;
+	}
 }

Spacing +2 added lines, -2 removed lines

@@ -13,7 +13,7 @@ 
 
 use XoopsModules\Newbb;
 
-defined('NEWBB_FUNCTIONS_INI') || require __DIR__ . '/functions.ini.php';
+defined('NEWBB_FUNCTIONS_INI') || require __DIR__.'/functions.ini.php';
 define('NEWBB_FUNCTIONS_CONFIG_LOADED', true);
 
 if (!defined('NEWBB_FUNCTIONS_CONFIG')) {
@@ -37,7 +37,7 @@ 
         }
 
         $configs = is_object($helper) ? $helper->getConfig() : [];
-        $plugins = require __DIR__   . '/plugin.php';
+        $plugins = require __DIR__.'/plugin.php';
         if (is_array($configs) && is_array($plugins)) {
             $configs = array_merge($configs, $plugins);
         }