mambax7 / newbb5

class/ReadForumHandler.php

Indentation +101 added lines, -101 removed lines

@@ -48,105 +48,105 @@
  */
 class ReadForumHandler extends Newbb\ReadHandler
 {
-    /**
-     * @param \XoopsDatabase|null $db
-     */
-    public function __construct(\XoopsDatabase $db)
-    {
-        parent::__construct($db, 'forum');
-    }
-
-    /**
-     * clean orphan items from database
-     *
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @return bool   true on success
-     */
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
-    {
-        parent::cleanOrphan($this->db->prefix('newbb_posts'), 'post_id');
-
-        return parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id', 'read_item');
-    }
-
-    /**
-     * @param  int  $status
-     * @param  null $uid
-     * @return bool
-     */
-    public function setReadItems($status = 0, $uid = null)
-    {
-        if (empty($this->mode)) {
-            return true;
-        }
-
-        if (1 == $this->mode) {
-            return $this->setReadItemsCookie($status);
-        } else {
-            return $this->setReadItemsDb($status, $uid);
-        }
-    }
-
-    /**
-     * @param $status
-     * @param $items
-     * @return bool
-     */
-    public function setReadItemsCookie($status, $items)
-    {
-        $cookie_name = 'LF';
-        $items       = [];
-        if (!empty($status)) {
-            /** @var Newbb\ForumHandler $itemHandler */
-            $itemHandler = Newbb\Helper::getInstance()->getHandler('Forum');
-            $items_id    = $itemHandler->getIds();
-            foreach ($items_id as $key) {
-                $items[$key] = time();
-            }
-        }
-        newbbSetCookie($cookie_name, $items);
-
-        return true;
-    }
-
-    /**
-     * @param $status
-     * @param $uid
-     * @return bool
-     */
-    public function setReadItemsDb($status, $uid)
-    {
-        if (empty($uid)) {
-            if (is_object($GLOBALS['xoopsUser'])) {
-                $uid = $GLOBALS['xoopsUser']->getVar('uid');
-            } else {
-                return false;
-            }
-        }
-        if (empty($status)) {
-            $this->deleteAll(new \Criteria('uid', $uid));
-
-            return true;
-        }
-
-        /** @var Newbb\ForumHandler $itemHandler */
-        $itemHandler = Newbb\Helper::getInstance()->getHandler('Forum');
-        $itemsObject = $itemHandler->getAll(null, ['forum_last_post_id']);
-        foreach (array_keys($itemsObject) as $key) {
-            $this->setReadDb($key, $itemsObject[$key]->getVar('forum_last_post_id'), $uid);
-        }
-        unset($itemsObject);
-
-        return true;
-    }
-
-    /**
-     *
-     */
-    public function synchronization()
-    {
-        //        return;
-    }
+	/**
+	 * @param \XoopsDatabase|null $db
+	 */
+	public function __construct(\XoopsDatabase $db)
+	{
+		parent::__construct($db, 'forum');
+	}
+
+	/**
+	 * clean orphan items from database
+	 *
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @return bool   true on success
+	 */
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
+	{
+		parent::cleanOrphan($this->db->prefix('newbb_posts'), 'post_id');
+
+		return parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id', 'read_item');
+	}
+
+	/**
+	 * @param  int  $status
+	 * @param  null $uid
+	 * @return bool
+	 */
+	public function setReadItems($status = 0, $uid = null)
+	{
+		if (empty($this->mode)) {
+			return true;
+		}
+
+		if (1 == $this->mode) {
+			return $this->setReadItemsCookie($status);
+		} else {
+			return $this->setReadItemsDb($status, $uid);
+		}
+	}
+
+	/**
+	 * @param $status
+	 * @param $items
+	 * @return bool
+	 */
+	public function setReadItemsCookie($status, $items)
+	{
+		$cookie_name = 'LF';
+		$items       = [];
+		if (!empty($status)) {
+			/** @var Newbb\ForumHandler $itemHandler */
+			$itemHandler = Newbb\Helper::getInstance()->getHandler('Forum');
+			$items_id    = $itemHandler->getIds();
+			foreach ($items_id as $key) {
+				$items[$key] = time();
+			}
+		}
+		newbbSetCookie($cookie_name, $items);
+
+		return true;
+	}
+
+	/**
+	 * @param $status
+	 * @param $uid
+	 * @return bool
+	 */
+	public function setReadItemsDb($status, $uid)
+	{
+		if (empty($uid)) {
+			if (is_object($GLOBALS['xoopsUser'])) {
+				$uid = $GLOBALS['xoopsUser']->getVar('uid');
+			} else {
+				return false;
+			}
+		}
+		if (empty($status)) {
+			$this->deleteAll(new \Criteria('uid', $uid));
+
+			return true;
+		}
+
+		/** @var Newbb\ForumHandler $itemHandler */
+		$itemHandler = Newbb\Helper::getInstance()->getHandler('Forum');
+		$itemsObject = $itemHandler->getAll(null, ['forum_last_post_id']);
+		foreach (array_keys($itemsObject) as $key) {
+			$this->setReadDb($key, $itemsObject[$key]->getVar('forum_last_post_id'), $uid);
+		}
+		unset($itemsObject);
+
+		return true;
+	}
+
+	/**
+	 *
+	 */
+	public function synchronization()
+	{
+		//        return;
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 
 use XoopsModules\Newbb;
 
-require_once __DIR__ . '/Read.php';
+require_once __DIR__.'/Read.php';
 
 /**
  * A handler for read/unread handling

class/RateHandler.php

Indentation +26 added lines, -26 removed lines

@@ -39,32 +39,32 @@
  */
 class RateHandler extends \XoopsPersistableObjectHandler
 {
-    /**
-     * @param \XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db)
-    {
-        parent::__construct($db, 'newbb_votedata', Rate::class, 'ratingid', '');
-    }
+	/**
+	 * @param \XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db)
+	{
+		parent::__construct($db, 'newbb_votedata', Rate::class, 'ratingid', '');
+	}
 
-    /**
-     *
-     */
-    public function synchronization()
-    {
-        //        return;
-    }
+	/**
+	 *
+	 */
+	public function synchronization()
+	{
+		//        return;
+	}
 
-    /**
-     * clean orphan items from database
-     *
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @return bool   true on success
-     */
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
-    {
-        return parent::cleanOrphan($this->db->prefix('newbb_topics'), 'topic_id');
-    }
+	/**
+	 * clean orphan items from database
+	 *
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @return bool   true on success
+	 */
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
+	{
+		return parent::cleanOrphan($this->db->prefix('newbb_topics'), 'topic_id');
+	}
 }

class/ReadForum.php

Indentation +7 added lines, -7 removed lines

@@ -45,11 +45,11 @@
  */
 class ReadForum extends Newbb\Read
 {
-    /**
-     *
-     */
-    public function __construct()
-    {
-        parent::__construct();
-    }
+	/**
+	 *
+	 */
+	public function __construct()
+	{
+		parent::__construct();
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
 use XoopsModules\Newbb;
 
 
-require_once __DIR__ . '/Read.php';
+require_once __DIR__.'/Read.php';
 
 /**
  * A handler for read/unread handling

class/Helper.php

Indentation +60 added lines, -60 removed lines

@@ -26,72 +26,72 @@
  */
 class Helper extends \Xmf\Module\Helper
 {
-    public $debug;
+	public $debug;
 
-    /**
-     *
-     * @param bool $debug
-     */
-    public function __construct($debug = false)
-    {
-        $this->debug   = $debug;
-        $moduleDirName = basename(dirname(__DIR__));
-        parent::__construct($moduleDirName);
-    }
+	/**
+	 *
+	 * @param bool $debug
+	 */
+	public function __construct($debug = false)
+	{
+		$this->debug   = $debug;
+		$moduleDirName = basename(dirname(__DIR__));
+		parent::__construct($moduleDirName);
+	}
 
-    /**
-     * @param bool $debug
-     *
-     * @return \XoopsModules\Newbb\Helper
-     */
-    public static function getInstance($debug = false)
-    {
-        static $instance;
-        if (null === $instance) {
-            $instance = new static($debug);
-        }
+	/**
+	 * @param bool $debug
+	 *
+	 * @return \XoopsModules\Newbb\Helper
+	 */
+	public static function getInstance($debug = false)
+	{
+		static $instance;
+		if (null === $instance) {
+			$instance = new static($debug);
+		}
 
-        return $instance;
-    }
+		return $instance;
+	}
 
-    /**
-     * @param null|string $name
-     * @param null|string $value
-     *
-     * @return mixed
-     */
-    public function setConfig($name = null, $value = null)
-    {
-        if (null === $this->configs) {
-            $this->initConfig();
-        }
-        $this->configs[$name] = $value;
-        $this->addLog("Setting config '{$name}' : " . $this->configs[$name]);
+	/**
+	 * @param null|string $name
+	 * @param null|string $value
+	 *
+	 * @return mixed
+	 */
+	public function setConfig($name = null, $value = null)
+	{
+		if (null === $this->configs) {
+			$this->initConfig();
+		}
+		$this->configs[$name] = $value;
+		$this->addLog("Setting config '{$name}' : " . $this->configs[$name]);
 
-        return $this->configs[$name];
-    }
+		return $this->configs[$name];
+	}
 
-    /**
-     * @return string
-     */
-    public function getDirname()
-    {
-        return $this->dirname;
-    }
+	/**
+	 * @return string
+	 */
+	public function getDirname()
+	{
+		return $this->dirname;
+	}
 
-    /**
-     * Get an Object Handler
-     *
-     * @param string $name name of handler to load
-     *
-     * @return bool|\XoopsObjectHandler|\XoopsPersistableObjectHandler
-     */
-    public function getHandler($name)
-    {
-        $db    = \XoopsDatabaseFactory::getDatabaseConnection();
-        $class = '\\XoopsModules\\' . ucfirst(strtolower(basename(dirname(__DIR__)))) . '\\' . $name . 'Handler';
-        $ret   = new $class($db);
+	/**
+	 * Get an Object Handler
+	 *
+	 * @param string $name name of handler to load
+	 *
+	 * @return bool|\XoopsObjectHandler|\XoopsPersistableObjectHandler
+	 */
+	public function getHandler($name)
+	{
+		$db    = \XoopsDatabaseFactory::getDatabaseConnection();
+		$class = '\\XoopsModules\\' . ucfirst(strtolower(basename(dirname(__DIR__)))) . '\\' . $name . 'Handler';
+		$ret   = new $class($db);
 
-        return $ret;
-    }
+		return $ret;
+	}
 }

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
             $this->initConfig();
         }
         $this->configs[$name] = $value;
-        $this->addLog("Setting config '{$name}' : " . $this->configs[$name]);
+        $this->addLog("Setting config '{$name}' : ".$this->configs[$name]);
 
         return $this->configs[$name];
     }
@@ -89,7 +89,7 @@ 
     public function getHandler($name)
     {
         $db    = \XoopsDatabaseFactory::getDatabaseConnection();
-        $class = '\\XoopsModules\\' . ucfirst(strtolower(basename(dirname(__DIR__)))) . '\\' . $name . 'Handler';
+        $class = '\\XoopsModules\\'.ucfirst(strtolower(basename(dirname(__DIR__)))).'\\'.$name.'Handler';
         $ret   = new $class($db);
 
         return $ret;

class/TopicHandler.php

Indentation +560 added lines, -560 removed lines

@@ -22,570 +22,570 @@
  */
 class TopicHandler extends \XoopsPersistableObjectHandler
 {
-    /**
-     * @param \XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db)
-    {
-        parent::__construct($db, 'newbb_topics', Topic::class, 'topic_id', 'topic_title');
-    }
-
-    /**
-     * @param  mixed      $id
-     * @param  null|array $fields
-     * @return mixed|null
-     */
-    public function get($id = null, $fields = null) //get($id, $var = null)
-    {
-        $var  = $fields;
-        $ret  = null;
-        $tags = $var;
-        if (!empty($var) && is_string($var)) {
-            $tags = [$var];
-        }
-        if (!$topicObject = parent::get($id, $tags)) {
-            return $ret;
-        }
-        $ret = $topicObject;
-        if (!empty($var) && is_string($var)) {
-            $ret = @$topicObject->getVar($var);
-        }
-
-        return $ret;
-    }
-
-    /**
-     * @param \XoopsObject $object
-     * @param  bool        $force
-     * @return mixed
-     */
-    public function insert(\XoopsObject $object, $force = true)
-    {
-        if (!$object->getVar('topic_time')) {
-            $object->setVar('topic_time', time());
-        }
-        if (!parent::insert($object, $force) || !$object->getVar('approved')) {
-            return $object->getVar('topic_id');
-        }
-
-        $newbbConfig = newbbLoadConfig();
-        if (!empty($newbbConfig['do_tag'])
-            && @require_once $GLOBALS['xoops']->path('modules/tag/include/functions.php')) {
-            if ($tagHandler = tag_getTagHandler()) {
-                $tagHandler->updateByItem($object->getVar('topic_tags', 'n'), $object->getVar('topic_id'), 'newbb');
-            }
-        }
-
-        return $object->getVar('topic_id');
-    }
-
-    /**
-     * @param       $object
-     * @param  bool $force
-     * @return bool
-     */
-    public function approve($object, $force = false)
-    {
-        $topic_id = $object->getVar('topic_id');
-        if ($force) {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = -1 WHERE topic_id = {$topic_id}";
-        } else {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = 1 WHERE topic_id = {$topic_id}";
-        }
-        if (!$result = $this->db->queryF($sql)) {
-            //xoops_error($this->db->error());
-            return false;
-        }
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $postsObject = $postHandler->getAll(new \Criteria('topic_id', $topic_id));
-        foreach (array_keys($postsObject) as $post_id) {
-            $postHandler->approve($postsObject[$post_id]);
-        }
-        unset($postsObject);
-        $statsHandler = Newbb\Helper::getInstance()->getHandler('Stats');
-        $statsHandler->update($object->getVar('forum_id'), 'topic');
-
-        return true;
-    }
-
-    /**
-     * get previous/next topic
-     *
-     * @param integer $topic_id current topic ID
-     * @param integer $action
-     *                          <ul>
-     *                          <li> -1: previous </li>
-     *                          <li> 0: current </li>
-     *                          <li> 1: next </li>
-     *                          </ul>
-     * @param integer $forum_id the scope for moving
-     *                          <ul>
-     *                          <li> >0 : inside the forum </li>
-     *                          <li> <= 0: global </li>
-     *                          </ul>
-     * @access public
-     * @return mixed|null|\XoopsObject
-     */
-    public function &getByMove($topic_id, $action, $forum_id = 0)
-    {
-        $topic = null;
-        if (!empty($action)) {
-            $sql = 'SELECT * FROM ' . $this->table . ' WHERE 1=1' . (($forum_id > 0) ? ' AND forum_id=' . (int)$forum_id : '') . ' AND topic_id ' . (($action > 0) ? '>' : '<') . (int)$topic_id . ' ORDER BY topic_id ' . (($action > 0) ? 'ASC' : 'DESC') . ' LIMIT 1';
-            if ($result = $this->db->query($sql)) {
-                if ($row = $this->db->fetchArray($result)) {
-                    $topic = $this->create(false);
-                    $topic->assignVars($row);
-
-                    return $topic;
-                }
-            }
-        }
-        $topic = $this->get($topic_id);
-
-        return $topic;
-    }
-
-    /**
-     * @param $post_id
-     * @return null|\XoopsObject
-     */
-    public function &getByPost($post_id)
-    {
-        $topic  = null;
-        $sql    = 'SELECT t.* FROM ' . $this->db->prefix('newbb_topics') . ' t, ' . $this->db->prefix('newbb_posts') . ' p
+	/**
+	 * @param \XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db)
+	{
+		parent::__construct($db, 'newbb_topics', Topic::class, 'topic_id', 'topic_title');
+	}
+
+	/**
+	 * @param  mixed      $id
+	 * @param  null|array $fields
+	 * @return mixed|null
+	 */
+	public function get($id = null, $fields = null) //get($id, $var = null)
+	{
+		$var  = $fields;
+		$ret  = null;
+		$tags = $var;
+		if (!empty($var) && is_string($var)) {
+			$tags = [$var];
+		}
+		if (!$topicObject = parent::get($id, $tags)) {
+			return $ret;
+		}
+		$ret = $topicObject;
+		if (!empty($var) && is_string($var)) {
+			$ret = @$topicObject->getVar($var);
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * @param \XoopsObject $object
+	 * @param  bool        $force
+	 * @return mixed
+	 */
+	public function insert(\XoopsObject $object, $force = true)
+	{
+		if (!$object->getVar('topic_time')) {
+			$object->setVar('topic_time', time());
+		}
+		if (!parent::insert($object, $force) || !$object->getVar('approved')) {
+			return $object->getVar('topic_id');
+		}
+
+		$newbbConfig = newbbLoadConfig();
+		if (!empty($newbbConfig['do_tag'])
+			&& @require_once $GLOBALS['xoops']->path('modules/tag/include/functions.php')) {
+			if ($tagHandler = tag_getTagHandler()) {
+				$tagHandler->updateByItem($object->getVar('topic_tags', 'n'), $object->getVar('topic_id'), 'newbb');
+			}
+		}
+
+		return $object->getVar('topic_id');
+	}
+
+	/**
+	 * @param       $object
+	 * @param  bool $force
+	 * @return bool
+	 */
+	public function approve($object, $force = false)
+	{
+		$topic_id = $object->getVar('topic_id');
+		if ($force) {
+			$sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = -1 WHERE topic_id = {$topic_id}";
+		} else {
+			$sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = 1 WHERE topic_id = {$topic_id}";
+		}
+		if (!$result = $this->db->queryF($sql)) {
+			//xoops_error($this->db->error());
+			return false;
+		}
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$postsObject = $postHandler->getAll(new \Criteria('topic_id', $topic_id));
+		foreach (array_keys($postsObject) as $post_id) {
+			$postHandler->approve($postsObject[$post_id]);
+		}
+		unset($postsObject);
+		$statsHandler = Newbb\Helper::getInstance()->getHandler('Stats');
+		$statsHandler->update($object->getVar('forum_id'), 'topic');
+
+		return true;
+	}
+
+	/**
+	 * get previous/next topic
+	 *
+	 * @param integer $topic_id current topic ID
+	 * @param integer $action
+	 *                          <ul>
+	 *                          <li> -1: previous </li>
+	 *                          <li> 0: current </li>
+	 *                          <li> 1: next </li>
+	 *                          </ul>
+	 * @param integer $forum_id the scope for moving
+	 *                          <ul>
+	 *                          <li> >0 : inside the forum </li>
+	 *                          <li> <= 0: global </li>
+	 *                          </ul>
+	 * @access public
+	 * @return mixed|null|\XoopsObject
+	 */
+	public function &getByMove($topic_id, $action, $forum_id = 0)
+	{
+		$topic = null;
+		if (!empty($action)) {
+			$sql = 'SELECT * FROM ' . $this->table . ' WHERE 1=1' . (($forum_id > 0) ? ' AND forum_id=' . (int)$forum_id : '') . ' AND topic_id ' . (($action > 0) ? '>' : '<') . (int)$topic_id . ' ORDER BY topic_id ' . (($action > 0) ? 'ASC' : 'DESC') . ' LIMIT 1';
+			if ($result = $this->db->query($sql)) {
+				if ($row = $this->db->fetchArray($result)) {
+					$topic = $this->create(false);
+					$topic->assignVars($row);
+
+					return $topic;
+				}
+			}
+		}
+		$topic = $this->get($topic_id);
+
+		return $topic;
+	}
+
+	/**
+	 * @param $post_id
+	 * @return null|\XoopsObject
+	 */
+	public function &getByPost($post_id)
+	{
+		$topic  = null;
+		$sql    = 'SELECT t.* FROM ' . $this->db->prefix('newbb_topics') . ' t, ' . $this->db->prefix('newbb_posts') . ' p
                 WHERE t.topic_id = p.topic_id AND p.post_id = ' . (int)$post_id;
-        $result = $this->db->query($sql);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return $topic;
-        }
-        $row   = $this->db->fetchArray($result);
-        $topic = $this->create(false);
-        $topic->assignVars($row);
-
-        return $topic;
-    }
-
-    /**
-     * @param  Topic  $topic
-     * @param  string $type
-     * @return mixed
-     */
-    public function getPostCount(&$topic, $type = '')
-    {
-        switch ($type) {
-            case 'pending':
-                $approved = 0;
-                break;
-            case 'deleted':
-                $approved = -1;
-                break;
-            default:
-                $approved = 1;
-                break;
-        }
-        $criteria = new \CriteriaCompo(new \Criteria('topic_id', $topic->getVar('topic_id')));
-        $criteria->add(new \Criteria('approved', $approved));
-        /** @var Newbb\PostHandler $postHandler */
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $count       = $postHandler->getCount($criteria);
-
-        return $count;
-    }
-
-    /**
-     * @param $topic_id
-     * @return null|Newbb\Post
-     */
-    public function &getTopPost($topic_id)
-    {
-        $post = null;
-        $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p,
+		$result = $this->db->query($sql);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return $topic;
+		}
+		$row   = $this->db->fetchArray($result);
+		$topic = $this->create(false);
+		$topic->assignVars($row);
+
+		return $topic;
+	}
+
+	/**
+	 * @param  Topic  $topic
+	 * @param  string $type
+	 * @return mixed
+	 */
+	public function getPostCount(&$topic, $type = '')
+	{
+		switch ($type) {
+			case 'pending':
+				$approved = 0;
+				break;
+			case 'deleted':
+				$approved = -1;
+				break;
+			default:
+				$approved = 1;
+				break;
+		}
+		$criteria = new \CriteriaCompo(new \Criteria('topic_id', $topic->getVar('topic_id')));
+		$criteria->add(new \Criteria('approved', $approved));
+		/** @var Newbb\PostHandler $postHandler */
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$count       = $postHandler->getCount($criteria);
+
+		return $count;
+	}
+
+	/**
+	 * @param $topic_id
+	 * @return null|Newbb\Post
+	 */
+	public function &getTopPost($topic_id)
+	{
+		$post = null;
+		$sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p,
             ' . $this->db->prefix('newbb_posts_text') . ' t
             WHERE
             p.topic_id = ' . $topic_id . ' AND p.pid = 0
             AND t.post_id = p.post_id';
 
-        $result = $this->db->query($sql);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return $post;
-        }
-        /** @var Newbb\PostHandler $postHandler */
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $myrow       = $this->db->fetchArray($result);
-        /** @var Newbb\Post $post */
-        $post = $postHandler->create(false);
-        $post->assignVars($myrow);
-
-        return $post;
-    }
-
-    /**
-     * @param $topic_id
-     * @return bool
-     */
-    public function getTopPostId($topic_id)
-    {
-        $sql    = 'SELECT MIN(post_id) AS post_id FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id = ' . $topic_id . ' AND pid = 0';
-        $result = $this->db->query($sql);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return false;
-        }
-        list($post_id) = $this->db->fetchRow($result);
-
-        return $post_id;
-    }
-
-    /**
-     * @param         $topic
-     * @param  string $order
-     * @param  int    $perpage
-     * @param         $start
-     * @param  int    $post_id
-     * @param  string $type
-     * @return array
-     */
-    public function &getAllPosts(&$topic, $order = 'ASC', $perpage = 10, &$start, $post_id = 0, $type = '')
-    {
-        $ret     = [];
-        $perpage = ((int)$perpage > 0) ? (int)$perpage : (empty($GLOBALS['xoopsModuleConfig']['posts_per_page']) ? 10 : $GLOBALS['xoopsModuleConfig']['posts_per_page']);
-        $start   = (int)$start;
-        switch ($type) {
-            case 'pending':
-                $approveCriteria = ' AND p.approved = 0';
-                break;
-            case 'deleted':
-                $approveCriteria = ' AND p.approved = -1';
-                break;
-            default:
-                $approveCriteria = ' AND p.approved = 1';
-                break;
-        }
-
-        if ($post_id) {
-            if ('DESC' === $order) {
-                $operator_for_position = '>';
-            } else {
-                $order                 = 'ASC';
-                $operator_for_position = '<';
-            }
-            //$approveCriteria = ' AND approved = 1'; // any others?
-            $sql    = 'SELECT COUNT(*) FROM ' . $this->db->prefix('newbb_posts') . ' AS p WHERE p.topic_id=' . (int)$topic->getVar('topic_id') . $approveCriteria . " AND p.post_id $operator_for_position $post_id";
-            $result = $this->db->query($sql);
-            if (!$result) {
-                //xoops_error($this->db->error());
-                return $ret;
-            }
-            list($position) = $this->db->fetchRow($result);
-            $start = (int)($position / $perpage) * $perpage;
-        }
-
-        $sql    = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p, ' . $this->db->prefix('newbb_posts_text') . ' t WHERE p.topic_id=' . $topic->getVar('topic_id') . ' AND p.post_id = t.post_id' . $approveCriteria . " ORDER BY p.post_id $order";
-        $result = $this->db->query($sql, $perpage, $start);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return $ret;
-        }
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        while (false !== ($myrow = $this->db->fetchArray($result))) {
-            $post = $postHandler->create(false);
-            $post->assignVars($myrow);
-            $ret[$myrow['post_id']] = $post;
-            unset($post);
-        }
-
-        return $ret;
-    }
-
-    /**
-     * @param        $postArray
-     * @param  int   $pid
-     * @return mixed
-     */
-    public function &getPostTree(&$postArray, $pid = 0)
-    {
-        //        require_once $GLOBALS['xoops']->path('modules/newbb/class/Tree.php');
-        $NewBBTree = new Newbb\Tree('newbb_posts');
-        $NewBBTree->setPrefix('&nbsp;&nbsp;');
-        $NewBBTree->setPostArray($postArray);
-        $NewBBTree->getPostTree($postsArray, $pid);
-
-        return $postsArray;
-    }
-
-    /**
-     * @param $topic
-     * @param $postArray
-     * @return mixed
-     */
-    public function showTreeItem(&$topic, &$postArray)
-    {
-        global $viewtopic_users, $myts;
-
-        $postArray['post_time'] = newbbFormatTimestamp($postArray['post_time']);
-
-        if (!empty($postArray['icon'])) {
-            $postArray['icon'] = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($postArray['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
-        } else {
-            $postArray['icon'] = '<a name="' . $postArray['post_id'] . '"><img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" /></a>';
-        }
-
-        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id=' . $topic->getVar('topic_id') . '&amp;forum=' . $postArray['forum_id'] . '&amp;post_id=' . $postArray['post_id'] . '">' . $postArray['subject'] . '</a>';
-
-        $isActiveUser = false;
-        if (isset($viewtopic_users[$postArray['uid']]['name'])) {
-            $postArray['poster'] = $viewtopic_users[$postArray['uid']]['name'];
-            if ($postArray['uid'] > 0) {
-                $postArray['poster'] = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $postArray['uid'] . '">' . $viewtopic_users[$postArray['uid']]['name'] . '</a>';
-            }
-        } else {
-            $postArray['poster'] = empty($postArray['poster_name']) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $postArray['poster_name'];
-        }
-
-        return $postArray;
-    }
-
-    /**
-     * @param        $topic
-     * @param  bool  $isApproved
-     * @return array
-     */
-    public function &getAllPosters(&$topic, $isApproved = true)
-    {
-        $sql = 'SELECT DISTINCT uid FROM ' . $this->db->prefix('newbb_posts') . '  WHERE topic_id=' . $topic->getVar('topic_id') . ' AND uid>0';
-        if ($isApproved) {
-            $sql .= ' AND approved = 1';
-        }
-        $result = $this->db->query($sql);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return [];
-        }
-        $ret = [];
-        while (false !== ($myrow = $this->db->fetchArray($result))) {
-            $ret[] = $myrow['uid'];
-        }
-
-        return $ret;
-    }
-
-    /**
-     * @param Topic|\XoopsObject $topic
-     * @param  bool        $force
-     * @return bool
-     */
-    public function delete(\XoopsObject $topic, $force = true)
-    {
-        $topic_id = is_object($topic) ? $topic->getVar('topic_id') : (int)$topic;
-        if (empty($topic_id)) {
-            return false;
-        }
-        $postObject = $this->getTopPost($topic_id);
-        /** @var Newbb\PostHandler $postHandler */
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $postHandler->delete($postObject, false, $force);
-
-        $newbbConfig = newbbLoadConfig();
-        /** @var \XoopsModules\Tag\TagHandler $tagHandler */
-        if (!empty($newbbConfig['do_tag']) && $tagHandler = Tag\Helper::getInstance()->getHandler('Tag')) { //@xoops_getModuleHandler('tag', 'tag', true)) {
-            $tagHandler->updateByItem([], $topic_id, 'newbb');
-        }
-
-        return true;
-    }
-
-    // get permission
-    // parameter: $type: 'post', 'view',  'reply', 'edit', 'delete', 'addpoll', 'vote', 'attach'
-    // $gperm_names = "'forum_can_post', 'forum_can_view', 'forum_can_reply', 'forum_can_edit', 'forum_can_delete', 'forum_can_addpoll', 'forum_can_vote', 'forum_can_attach', 'forum_can_noapprove'";
-    /**
-     * @param   Newbb\Forum $forum
-     * @param  int     $topic_locked
-     * @param  string  $type
-     * @return bool
-     */
-    public function getPermission($forum, $topic_locked = 0, $type = 'view')
-    {
-        static $_cachedTopicPerms;
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
-        if (newbbIsAdmin($forum)) {
-            return true;
-        }
-
-        $forum_id = is_object($forum) ? $forum->getVar('forum_id') : (int)$forum;
-        if ($forum_id < 1) {
-            return false;
-        }
-
-        if ($topic_locked && 'view' !== $type) {
-            $permission = false;
-        } else {
-            /** var Newbb\PermissionHandler $permHandler */
-            $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
-            $permission  = $permHandler->getPermission('forum', $type, $forum_id);
-        }
-
-        return $permission;
-    }
-
-    /**
-     * clean orphan items from database
-     *
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @return bool   true on success
-     */
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
-    {
-        $this->deleteAll(new \Criteria('topic_time', 0), true, true);
-        parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id');
-        parent::cleanOrphan($this->db->prefix('newbb_posts'), 'topic_id');
-
-        return true;
-    }
-
-    /**
-     * clean expired objects from database
-     *
-     * @param  int $expire time limit for expiration
-     * @return bool true on success
-     */
-    public function cleanExpires($expire = 0)
-    {
-        // irmtfan if 0 no cleanup look include/plugin.php
-        if (!func_num_args()) {
-            $newbbConfig = newbbLoadConfig();
-            $expire      = isset($newbbConfig['pending_expire']) ? (int)$newbbConfig['pending_expire'] : 7;
-            $expire      = $expire * 24 * 3600; // days to seconds
-        }
-        if (empty($expire)) {
-            return false;
-        }
-        $crit_expire = new \CriteriaCompo(new \Criteria('approved', 0, '<='));
-        $crit_expire->add(new \Criteria('topic_time', time() - (int)$expire, '<'));
-
-        return $this->deleteAll($crit_expire, true/*, true*/);
-    }
-
-    // START irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
-
-    /**
-     * @param  null $object
-     * @param  bool $force
-     * @return bool
-     */
-    public function synchronization($object = null, $force = true)
-    {
-        if (!is_object($object)) {
-            $object = $this->get((int)$object);
-        }
-        if (!is_object($object) || !$object->getVar('topic_id')) {
-            return false;
-        }
-
-        /** @var Newbb\PostHandler $postHandler */
-        $postHandler = Newbb\Helper::getInstance()->getHandler('Post');
-        $criteria    = new \CriteriaCompo();
-        $criteria->add(new \Criteria('topic_id', $object->getVar('topic_id')), 'AND');
-        $criteria->add(new \Criteria('approved', 1), 'AND');
-        $post_ids = $postHandler->getIds($criteria);
-        if (empty($post_ids)) {
-            return false;
-        }
-        $last_post     = max($post_ids);
-        $top_post      = min($post_ids);
-        $topic_replies = count($post_ids) - 1;
-        if ($object->getVar('topic_last_post_id') != $last_post) {
-            $object->setVar('topic_last_post_id', $last_post);
-        }
-        if ($object->getVar('topic_replies') != $topic_replies) {
-            $object->setVar('topic_replies', $topic_replies);
-        }
-        $b1 = $this->insert($object, $force);
-        $criteria->add(new \Criteria('post_id', $top_post, '<>'), 'AND');
-        $criteria->add(new \Criteria('pid', '(' . implode(', ', $post_ids) . ')', 'NOT IN'), 'AND');
-        $b2       = $postHandler->updateAll('pid', $top_post, $criteria, $force);
-        $criteria = new \CriteriaCompo();
-        $criteria->add(new \Criteria('post_id', $top_post, '='), 'AND');
-        $b3 = $postHandler->updateAll('pid', 0, $criteria, $force);
-
-        return ($b1 && $b2 && $b3);
-    }
-    // END irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
-    // START irmtfan getActivePolls
-    /**
-     * get all active poll modules in the current xoops installtion.
-     * @access public
-     * @return array $pollDirs = array($dirname1=>$dirname1, $dirname2=>$dirname2, ...) dirnames of all active poll modules
-     */
-    public function getActivePolls()
-    {
-        $pollDirs = [];
-        $allDirs  = xoops_getActiveModules();
-        foreach ($allDirs as $dirname) {
-            // pollresults.php file is exist in all xoopspoll versions and umfrage versions
-            if (file_exists($GLOBALS['xoops']->path('modules/' . $dirname . '/pollresults.php'))) {
-                $pollDirs[$dirname] = $dirname;
-            }
-        }
-
-        return $pollDirs;
-    }
-    // END irmtfan getActivePolls
-
-    // START irmtfan findPollModule
-    /**
-     * find poll module that is in used in the current newbb installtion.
-     * @access public
-     * @param  array $pollDirs dirnames of all active poll modules
-     * @return bool|string $dir_def | true | false
-     *                         $dir_def: dirname of poll module that is in used in the current newbb installtion.
-     *                         true: no poll module is installed | newbb has no topic with poll | newbb has no topic
-     *                         false: errors (see below xoops_errors)
-     */
-    public function findPollModule(array $pollDirs = [])
-    {
-        $dir_def = '';
-        if (empty($pollDirs)) {
-            $pollDirs = $this->getActivePolls();
-        }
-        if (empty($pollDirs)) {
-            return true;
-        }
-        // if only one active poll module still we need to check!!!
-        //if(count($pollDirs) === 1) return end($pollDirs);
-        $topicPollObjs = $this->getAll(new \Criteria('topic_haspoll', 1), ['topic_id', 'poll_id']);
-        if (empty($topicPollObjs)) {
-            return true;
-        } // no poll or no topic!!!
-        foreach ($topicPollObjs as $tObj) {
-            $poll_idInMod = 0;
-            foreach ($pollDirs as $dirname) {
-                $pollObj = $tObj->getPoll($tObj->getVar('poll_id'), $dirname);
-                if (is_object($pollObj) && ($pollObj->getVar('poll_id') == $tObj->getVar('poll_id'))) {
-                    ++$poll_idInMod;
-                    $dir_def = $dirname;
-                }
-            }
-            // Only one poll module should has this poll_id
-            // if 0 there is an error
-            if (0 == $poll_idInMod) {
-                xoops_error("Error: Cannot find poll module for poll_id='{$tObj->getVar('poll_id')}'");
-
-                return false;
-            }
-            // if 1 => $dir_def is correct
-            if (1 == $poll_idInMod) {
-                return $dir_def;
-            }
-            // if more than 1 continue
-        }
-        // if there is some topics but no module or more than one module have polls
-        xoops_error("Error: Cannot find poll module that is in used in newbb!!! <br\><br\>You should select the correct poll module yourself in newbb > preferences > poll module setting.");
-
-        return false;
-    }
-    // END irmtfan findPollModule
+		$result = $this->db->query($sql);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return $post;
+		}
+		/** @var Newbb\PostHandler $postHandler */
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$myrow       = $this->db->fetchArray($result);
+		/** @var Newbb\Post $post */
+		$post = $postHandler->create(false);
+		$post->assignVars($myrow);
+
+		return $post;
+	}
+
+	/**
+	 * @param $topic_id
+	 * @return bool
+	 */
+	public function getTopPostId($topic_id)
+	{
+		$sql    = 'SELECT MIN(post_id) AS post_id FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id = ' . $topic_id . ' AND pid = 0';
+		$result = $this->db->query($sql);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return false;
+		}
+		list($post_id) = $this->db->fetchRow($result);
+
+		return $post_id;
+	}
+
+	/**
+	 * @param         $topic
+	 * @param  string $order
+	 * @param  int    $perpage
+	 * @param         $start
+	 * @param  int    $post_id
+	 * @param  string $type
+	 * @return array
+	 */
+	public function &getAllPosts(&$topic, $order = 'ASC', $perpage = 10, &$start, $post_id = 0, $type = '')
+	{
+		$ret     = [];
+		$perpage = ((int)$perpage > 0) ? (int)$perpage : (empty($GLOBALS['xoopsModuleConfig']['posts_per_page']) ? 10 : $GLOBALS['xoopsModuleConfig']['posts_per_page']);
+		$start   = (int)$start;
+		switch ($type) {
+			case 'pending':
+				$approveCriteria = ' AND p.approved = 0';
+				break;
+			case 'deleted':
+				$approveCriteria = ' AND p.approved = -1';
+				break;
+			default:
+				$approveCriteria = ' AND p.approved = 1';
+				break;
+		}
+
+		if ($post_id) {
+			if ('DESC' === $order) {
+				$operator_for_position = '>';
+			} else {
+				$order                 = 'ASC';
+				$operator_for_position = '<';
+			}
+			//$approveCriteria = ' AND approved = 1'; // any others?
+			$sql    = 'SELECT COUNT(*) FROM ' . $this->db->prefix('newbb_posts') . ' AS p WHERE p.topic_id=' . (int)$topic->getVar('topic_id') . $approveCriteria . " AND p.post_id $operator_for_position $post_id";
+			$result = $this->db->query($sql);
+			if (!$result) {
+				//xoops_error($this->db->error());
+				return $ret;
+			}
+			list($position) = $this->db->fetchRow($result);
+			$start = (int)($position / $perpage) * $perpage;
+		}
+
+		$sql    = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p, ' . $this->db->prefix('newbb_posts_text') . ' t WHERE p.topic_id=' . $topic->getVar('topic_id') . ' AND p.post_id = t.post_id' . $approveCriteria . " ORDER BY p.post_id $order";
+		$result = $this->db->query($sql, $perpage, $start);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return $ret;
+		}
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		while (false !== ($myrow = $this->db->fetchArray($result))) {
+			$post = $postHandler->create(false);
+			$post->assignVars($myrow);
+			$ret[$myrow['post_id']] = $post;
+			unset($post);
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * @param        $postArray
+	 * @param  int   $pid
+	 * @return mixed
+	 */
+	public function &getPostTree(&$postArray, $pid = 0)
+	{
+		//        require_once $GLOBALS['xoops']->path('modules/newbb/class/Tree.php');
+		$NewBBTree = new Newbb\Tree('newbb_posts');
+		$NewBBTree->setPrefix('&nbsp;&nbsp;');
+		$NewBBTree->setPostArray($postArray);
+		$NewBBTree->getPostTree($postsArray, $pid);
+
+		return $postsArray;
+	}
+
+	/**
+	 * @param $topic
+	 * @param $postArray
+	 * @return mixed
+	 */
+	public function showTreeItem(&$topic, &$postArray)
+	{
+		global $viewtopic_users, $myts;
+
+		$postArray['post_time'] = newbbFormatTimestamp($postArray['post_time']);
+
+		if (!empty($postArray['icon'])) {
+			$postArray['icon'] = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($postArray['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
+		} else {
+			$postArray['icon'] = '<a name="' . $postArray['post_id'] . '"><img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" /></a>';
+		}
+
+		$postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id=' . $topic->getVar('topic_id') . '&amp;forum=' . $postArray['forum_id'] . '&amp;post_id=' . $postArray['post_id'] . '">' . $postArray['subject'] . '</a>';
+
+		$isActiveUser = false;
+		if (isset($viewtopic_users[$postArray['uid']]['name'])) {
+			$postArray['poster'] = $viewtopic_users[$postArray['uid']]['name'];
+			if ($postArray['uid'] > 0) {
+				$postArray['poster'] = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $postArray['uid'] . '">' . $viewtopic_users[$postArray['uid']]['name'] . '</a>';
+			}
+		} else {
+			$postArray['poster'] = empty($postArray['poster_name']) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $postArray['poster_name'];
+		}
+
+		return $postArray;
+	}
+
+	/**
+	 * @param        $topic
+	 * @param  bool  $isApproved
+	 * @return array
+	 */
+	public function &getAllPosters(&$topic, $isApproved = true)
+	{
+		$sql = 'SELECT DISTINCT uid FROM ' . $this->db->prefix('newbb_posts') . '  WHERE topic_id=' . $topic->getVar('topic_id') . ' AND uid>0';
+		if ($isApproved) {
+			$sql .= ' AND approved = 1';
+		}
+		$result = $this->db->query($sql);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return [];
+		}
+		$ret = [];
+		while (false !== ($myrow = $this->db->fetchArray($result))) {
+			$ret[] = $myrow['uid'];
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * @param Topic|\XoopsObject $topic
+	 * @param  bool        $force
+	 * @return bool
+	 */
+	public function delete(\XoopsObject $topic, $force = true)
+	{
+		$topic_id = is_object($topic) ? $topic->getVar('topic_id') : (int)$topic;
+		if (empty($topic_id)) {
+			return false;
+		}
+		$postObject = $this->getTopPost($topic_id);
+		/** @var Newbb\PostHandler $postHandler */
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$postHandler->delete($postObject, false, $force);
+
+		$newbbConfig = newbbLoadConfig();
+		/** @var \XoopsModules\Tag\TagHandler $tagHandler */
+		if (!empty($newbbConfig['do_tag']) && $tagHandler = Tag\Helper::getInstance()->getHandler('Tag')) { //@xoops_getModuleHandler('tag', 'tag', true)) {
+			$tagHandler->updateByItem([], $topic_id, 'newbb');
+		}
+
+		return true;
+	}
+
+	// get permission
+	// parameter: $type: 'post', 'view',  'reply', 'edit', 'delete', 'addpoll', 'vote', 'attach'
+	// $gperm_names = "'forum_can_post', 'forum_can_view', 'forum_can_reply', 'forum_can_edit', 'forum_can_delete', 'forum_can_addpoll', 'forum_can_vote', 'forum_can_attach', 'forum_can_noapprove'";
+	/**
+	 * @param   Newbb\Forum $forum
+	 * @param  int     $topic_locked
+	 * @param  string  $type
+	 * @return bool
+	 */
+	public function getPermission($forum, $topic_locked = 0, $type = 'view')
+	{
+		static $_cachedTopicPerms;
+		require_once  dirname(__DIR__) . '/include/functions.user.php';
+		if (newbbIsAdmin($forum)) {
+			return true;
+		}
+
+		$forum_id = is_object($forum) ? $forum->getVar('forum_id') : (int)$forum;
+		if ($forum_id < 1) {
+			return false;
+		}
+
+		if ($topic_locked && 'view' !== $type) {
+			$permission = false;
+		} else {
+			/** var Newbb\PermissionHandler $permHandler */
+			$permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
+			$permission  = $permHandler->getPermission('forum', $type, $forum_id);
+		}
+
+		return $permission;
+	}
+
+	/**
+	 * clean orphan items from database
+	 *
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @return bool   true on success
+	 */
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
+	{
+		$this->deleteAll(new \Criteria('topic_time', 0), true, true);
+		parent::cleanOrphan($this->db->prefix('newbb_forums'), 'forum_id');
+		parent::cleanOrphan($this->db->prefix('newbb_posts'), 'topic_id');
+
+		return true;
+	}
+
+	/**
+	 * clean expired objects from database
+	 *
+	 * @param  int $expire time limit for expiration
+	 * @return bool true on success
+	 */
+	public function cleanExpires($expire = 0)
+	{
+		// irmtfan if 0 no cleanup look include/plugin.php
+		if (!func_num_args()) {
+			$newbbConfig = newbbLoadConfig();
+			$expire      = isset($newbbConfig['pending_expire']) ? (int)$newbbConfig['pending_expire'] : 7;
+			$expire      = $expire * 24 * 3600; // days to seconds
+		}
+		if (empty($expire)) {
+			return false;
+		}
+		$crit_expire = new \CriteriaCompo(new \Criteria('approved', 0, '<='));
+		$crit_expire->add(new \Criteria('topic_time', time() - (int)$expire, '<'));
+
+		return $this->deleteAll($crit_expire, true/*, true*/);
+	}
+
+	// START irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
+
+	/**
+	 * @param  null $object
+	 * @param  bool $force
+	 * @return bool
+	 */
+	public function synchronization($object = null, $force = true)
+	{
+		if (!is_object($object)) {
+			$object = $this->get((int)$object);
+		}
+		if (!is_object($object) || !$object->getVar('topic_id')) {
+			return false;
+		}
+
+		/** @var Newbb\PostHandler $postHandler */
+		$postHandler = Newbb\Helper::getInstance()->getHandler('Post');
+		$criteria    = new \CriteriaCompo();
+		$criteria->add(new \Criteria('topic_id', $object->getVar('topic_id')), 'AND');
+		$criteria->add(new \Criteria('approved', 1), 'AND');
+		$post_ids = $postHandler->getIds($criteria);
+		if (empty($post_ids)) {
+			return false;
+		}
+		$last_post     = max($post_ids);
+		$top_post      = min($post_ids);
+		$topic_replies = count($post_ids) - 1;
+		if ($object->getVar('topic_last_post_id') != $last_post) {
+			$object->setVar('topic_last_post_id', $last_post);
+		}
+		if ($object->getVar('topic_replies') != $topic_replies) {
+			$object->setVar('topic_replies', $topic_replies);
+		}
+		$b1 = $this->insert($object, $force);
+		$criteria->add(new \Criteria('post_id', $top_post, '<>'), 'AND');
+		$criteria->add(new \Criteria('pid', '(' . implode(', ', $post_ids) . ')', 'NOT IN'), 'AND');
+		$b2       = $postHandler->updateAll('pid', $top_post, $criteria, $force);
+		$criteria = new \CriteriaCompo();
+		$criteria->add(new \Criteria('post_id', $top_post, '='), 'AND');
+		$b3 = $postHandler->updateAll('pid', 0, $criteria, $force);
+
+		return ($b1 && $b2 && $b3);
+	}
+	// END irmtfan - rewrite topic synchronization function. add pid sync and remove hard-code db access
+	// START irmtfan getActivePolls
+	/**
+	 * get all active poll modules in the current xoops installtion.
+	 * @access public
+	 * @return array $pollDirs = array($dirname1=>$dirname1, $dirname2=>$dirname2, ...) dirnames of all active poll modules
+	 */
+	public function getActivePolls()
+	{
+		$pollDirs = [];
+		$allDirs  = xoops_getActiveModules();
+		foreach ($allDirs as $dirname) {
+			// pollresults.php file is exist in all xoopspoll versions and umfrage versions
+			if (file_exists($GLOBALS['xoops']->path('modules/' . $dirname . '/pollresults.php'))) {
+				$pollDirs[$dirname] = $dirname;
+			}
+		}
+
+		return $pollDirs;
+	}
+	// END irmtfan getActivePolls
+
+	// START irmtfan findPollModule
+	/**
+	 * find poll module that is in used in the current newbb installtion.
+	 * @access public
+	 * @param  array $pollDirs dirnames of all active poll modules
+	 * @return bool|string $dir_def | true | false
+	 *                         $dir_def: dirname of poll module that is in used in the current newbb installtion.
+	 *                         true: no poll module is installed | newbb has no topic with poll | newbb has no topic
+	 *                         false: errors (see below xoops_errors)
+	 */
+	public function findPollModule(array $pollDirs = [])
+	{
+		$dir_def = '';
+		if (empty($pollDirs)) {
+			$pollDirs = $this->getActivePolls();
+		}
+		if (empty($pollDirs)) {
+			return true;
+		}
+		// if only one active poll module still we need to check!!!
+		//if(count($pollDirs) === 1) return end($pollDirs);
+		$topicPollObjs = $this->getAll(new \Criteria('topic_haspoll', 1), ['topic_id', 'poll_id']);
+		if (empty($topicPollObjs)) {
+			return true;
+		} // no poll or no topic!!!
+		foreach ($topicPollObjs as $tObj) {
+			$poll_idInMod = 0;
+			foreach ($pollDirs as $dirname) {
+				$pollObj = $tObj->getPoll($tObj->getVar('poll_id'), $dirname);
+				if (is_object($pollObj) && ($pollObj->getVar('poll_id') == $tObj->getVar('poll_id'))) {
+					++$poll_idInMod;
+					$dir_def = $dirname;
+				}
+			}
+			// Only one poll module should has this poll_id
+			// if 0 there is an error
+			if (0 == $poll_idInMod) {
+				xoops_error("Error: Cannot find poll module for poll_id='{$tObj->getVar('poll_id')}'");
+
+				return false;
+			}
+			// if 1 => $dir_def is correct
+			if (1 == $poll_idInMod) {
+				return $dir_def;
+			}
+			// if more than 1 continue
+		}
+		// if there is some topics but no module or more than one module have polls
+		xoops_error("Error: Cannot find poll module that is in used in newbb!!! <br\><br\>You should select the correct poll module yourself in newbb > preferences > poll module setting.");
+
+		return false;
+	}
+	// END irmtfan findPollModule
 }

Spacing +18 added lines, -18 removed lines

@@ -88,9 +88,9 @@ 
     {
         $topic_id = $object->getVar('topic_id');
         if ($force) {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = -1 WHERE topic_id = {$topic_id}";
+            $sql = 'UPDATE '.$this->db->prefix('newbb_topics')." SET approved = -1 WHERE topic_id = {$topic_id}";
         } else {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . " SET approved = 1 WHERE topic_id = {$topic_id}";
+            $sql = 'UPDATE '.$this->db->prefix('newbb_topics')." SET approved = 1 WHERE topic_id = {$topic_id}";
         }
         if (!$result = $this->db->queryF($sql)) {
             //xoops_error($this->db->error());
@@ -130,7 +130,7 @@ 
     {
         $topic = null;
         if (!empty($action)) {
-            $sql = 'SELECT * FROM ' . $this->table . ' WHERE 1=1' . (($forum_id > 0) ? ' AND forum_id=' . (int)$forum_id : '') . ' AND topic_id ' . (($action > 0) ? '>' : '<') . (int)$topic_id . ' ORDER BY topic_id ' . (($action > 0) ? 'ASC' : 'DESC') . ' LIMIT 1';
+            $sql = 'SELECT * FROM '.$this->table.' WHERE 1=1'.(($forum_id > 0) ? ' AND forum_id='.(int)$forum_id : '').' AND topic_id '.(($action > 0) ? '>' : '<').(int)$topic_id.' ORDER BY topic_id '.(($action > 0) ? 'ASC' : 'DESC').' LIMIT 1';
             if ($result = $this->db->query($sql)) {
                 if ($row = $this->db->fetchArray($result)) {
                     $topic = $this->create(false);
@@ -152,7 +152,7 @@ 
     public function &getByPost($post_id)
     {
         $topic  = null;
-        $sql    = 'SELECT t.* FROM ' . $this->db->prefix('newbb_topics') . ' t, ' . $this->db->prefix('newbb_posts') . ' p
+        $sql    = 'SELECT t.* FROM '.$this->db->prefix('newbb_topics').' t, '.$this->db->prefix('newbb_posts').' p
                 WHERE t.topic_id = p.topic_id AND p.post_id = ' . (int)$post_id;
         $result = $this->db->query($sql);
         if (!$result) {
@@ -200,10 +200,10 @@ 
     public function &getTopPost($topic_id)
     {
         $post = null;
-        $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p,
-            ' . $this->db->prefix('newbb_posts_text') . ' t
+        $sql  = 'SELECT p.*, t.* FROM '.$this->db->prefix('newbb_posts').' p,
+            ' . $this->db->prefix('newbb_posts_text').' t
             WHERE
-            p.topic_id = ' . $topic_id . ' AND p.pid = 0
+            p.topic_id = ' . $topic_id.' AND p.pid = 0
             AND t.post_id = p.post_id';
 
         $result = $this->db->query($sql);
@@ -227,7 +227,7 @@ 
      */
     public function getTopPostId($topic_id)
     {
-        $sql    = 'SELECT MIN(post_id) AS post_id FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id = ' . $topic_id . ' AND pid = 0';
+        $sql    = 'SELECT MIN(post_id) AS post_id FROM '.$this->db->prefix('newbb_posts').' WHERE topic_id = '.$topic_id.' AND pid = 0';
         $result = $this->db->query($sql);
         if (!$result) {
             //xoops_error($this->db->error());
@@ -272,7 +272,7 @@ 
                 $operator_for_position = '<';
             }
             //$approveCriteria = ' AND approved = 1'; // any others?
-            $sql    = 'SELECT COUNT(*) FROM ' . $this->db->prefix('newbb_posts') . ' AS p WHERE p.topic_id=' . (int)$topic->getVar('topic_id') . $approveCriteria . " AND p.post_id $operator_for_position $post_id";
+            $sql    = 'SELECT COUNT(*) FROM '.$this->db->prefix('newbb_posts').' AS p WHERE p.topic_id='.(int)$topic->getVar('topic_id').$approveCriteria." AND p.post_id $operator_for_position $post_id";
             $result = $this->db->query($sql);
             if (!$result) {
                 //xoops_error($this->db->error());
@@ -282,7 +282,7 @@ 
             $start = (int)($position / $perpage) * $perpage;
         }
 
-        $sql    = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p, ' . $this->db->prefix('newbb_posts_text') . ' t WHERE p.topic_id=' . $topic->getVar('topic_id') . ' AND p.post_id = t.post_id' . $approveCriteria . " ORDER BY p.post_id $order";
+        $sql    = 'SELECT p.*, t.* FROM '.$this->db->prefix('newbb_posts').' p, '.$this->db->prefix('newbb_posts_text').' t WHERE p.topic_id='.$topic->getVar('topic_id').' AND p.post_id = t.post_id'.$approveCriteria." ORDER BY p.post_id $order";
         $result = $this->db->query($sql, $perpage, $start);
         if (!$result) {
             //xoops_error($this->db->error());
@@ -327,18 +327,18 @@ 
         $postArray['post_time'] = newbbFormatTimestamp($postArray['post_time']);
 
         if (!empty($postArray['icon'])) {
-            $postArray['icon'] = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($postArray['icon'], ENT_QUOTES | ENT_HTML5) . '" alt="" />';
+            $postArray['icon'] = '<img src="'.XOOPS_URL.'/images/subject/'.htmlspecialchars($postArray['icon'], ENT_QUOTES | ENT_HTML5).'" alt="" />';
         } else {
-            $postArray['icon'] = '<a name="' . $postArray['post_id'] . '"><img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" /></a>';
+            $postArray['icon'] = '<a name="'.$postArray['post_id'].'"><img src="'.XOOPS_URL.'/images/icons/no_posticon.gif" alt="" /></a>';
         }
 
-        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id=' . $topic->getVar('topic_id') . '&amp;forum=' . $postArray['forum_id'] . '&amp;post_id=' . $postArray['post_id'] . '">' . $postArray['subject'] . '</a>';
+        $postArray['subject'] = '<a href="viewtopic.php?viewmode=thread&amp;topic_id='.$topic->getVar('topic_id').'&amp;forum='.$postArray['forum_id'].'&amp;post_id='.$postArray['post_id'].'">'.$postArray['subject'].'</a>';
 
         $isActiveUser = false;
         if (isset($viewtopic_users[$postArray['uid']]['name'])) {
             $postArray['poster'] = $viewtopic_users[$postArray['uid']]['name'];
             if ($postArray['uid'] > 0) {
-                $postArray['poster'] = '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $postArray['uid'] . '">' . $viewtopic_users[$postArray['uid']]['name'] . '</a>';
+                $postArray['poster'] = '<a href="'.XOOPS_URL.'/userinfo.php?uid='.$postArray['uid'].'">'.$viewtopic_users[$postArray['uid']]['name'].'</a>';
             }
         } else {
             $postArray['poster'] = empty($postArray['poster_name']) ? $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']) : $postArray['poster_name'];
@@ -354,7 +354,7 @@ 
      */
     public function &getAllPosters(&$topic, $isApproved = true)
     {
-        $sql = 'SELECT DISTINCT uid FROM ' . $this->db->prefix('newbb_posts') . '  WHERE topic_id=' . $topic->getVar('topic_id') . ' AND uid>0';
+        $sql = 'SELECT DISTINCT uid FROM '.$this->db->prefix('newbb_posts').'  WHERE topic_id='.$topic->getVar('topic_id').' AND uid>0';
         if ($isApproved) {
             $sql .= ' AND approved = 1';
         }
@@ -408,7 +408,7 @@ 
     public function getPermission($forum, $topic_locked = 0, $type = 'view')
     {
         static $_cachedTopicPerms;
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
+        require_once  dirname(__DIR__).'/include/functions.user.php';
         if (newbbIsAdmin($forum)) {
             return true;
         }
@@ -505,7 +505,7 @@ 
         }
         $b1 = $this->insert($object, $force);
         $criteria->add(new \Criteria('post_id', $top_post, '<>'), 'AND');
-        $criteria->add(new \Criteria('pid', '(' . implode(', ', $post_ids) . ')', 'NOT IN'), 'AND');
+        $criteria->add(new \Criteria('pid', '('.implode(', ', $post_ids).')', 'NOT IN'), 'AND');
         $b2       = $postHandler->updateAll('pid', $top_post, $criteria, $force);
         $criteria = new \CriteriaCompo();
         $criteria->add(new \Criteria('post_id', $top_post, '='), 'AND');
@@ -526,7 +526,7 @@ 
         $allDirs  = xoops_getActiveModules();
         foreach ($allDirs as $dirname) {
             // pollresults.php file is exist in all xoopspoll versions and umfrage versions
-            if (file_exists($GLOBALS['xoops']->path('modules/' . $dirname . '/pollresults.php'))) {
+            if (file_exists($GLOBALS['xoops']->path('modules/'.$dirname.'/pollresults.php'))) {
                 $pollDirs[$dirname] = $dirname;
             }
         }

class/Post.php

Indentation +668 added lines, -668 removed lines

@@ -43,672 +43,672 @@
  */
 class Post extends \XoopsObject
 {
-    //class Post extends \XoopsObject {
-    private $attachmentArray = [];
-
-    /**
-     *
-     */
-    public function __construct()
-    {
-        parent::__construct();
-
-        $this->initVar('post_id', XOBJ_DTYPE_INT);
-        $this->initVar('topic_id', XOBJ_DTYPE_INT, 0, true);
-        $this->initVar('forum_id', XOBJ_DTYPE_INT, 0, true);
-        $this->initVar('post_time', XOBJ_DTYPE_INT, 0, true);
-        //        $this->initVar('poster_ip', XOBJ_DTYPE_INT, 0);
-        $this->initVar('poster_ip', XOBJ_DTYPE_TXTBOX, '');
-        $this->initVar('poster_name', XOBJ_DTYPE_TXTBOX, '');
-        $this->initVar('subject', XOBJ_DTYPE_TXTBOX, '', true);
-        $this->initVar('pid', XOBJ_DTYPE_INT, 0);
-        $this->initVar('dohtml', XOBJ_DTYPE_INT, 0);
-        $this->initVar('dosmiley', XOBJ_DTYPE_INT, 1);
-        $this->initVar('doxcode', XOBJ_DTYPE_INT, 1);
-        $this->initVar('doimage', XOBJ_DTYPE_INT, 1);
-        $this->initVar('dobr', XOBJ_DTYPE_INT, 1);
-        $this->initVar('uid', XOBJ_DTYPE_INT, 1);
-        $this->initVar('icon', XOBJ_DTYPE_TXTBOX, '');
-        $this->initVar('attachsig', XOBJ_DTYPE_INT, 0);
-        $this->initVar('approved', XOBJ_DTYPE_INT, 1);
-        $this->initVar('post_karma', XOBJ_DTYPE_INT, 0);
-        $this->initVar('require_reply', XOBJ_DTYPE_INT, 0);
-        $this->initVar('attachment', XOBJ_DTYPE_TXTAREA, '');
-        $this->initVar('post_text', XOBJ_DTYPE_TXTAREA, '');
-        $this->initVar('post_edit', XOBJ_DTYPE_TXTAREA, '');
-    }
-
-    // ////////////////////////////////////////////////////////////////////////////////////
-    // attachment functions    TODO: there should be a file/attachment management class
-    /**
-     * @return array|mixed|null
-     */
-    public function getAttachment()
-    {
-        if (count($this->attachmentArray)) {
-            return $this->attachmentArray;
-        }
-        $attachment = $this->getVar('attachment');
-        if (empty($attachment)) {
-            $this->attachmentArray = [];
-        } else {
-            $this->attachmentArray = @unserialize(base64_decode($attachment));
-        }
-
-        return $this->attachmentArray;
-    }
-
-    /**
-     * @param $attachKey
-     * @return bool
-     */
-    public function incrementDownload($attachKey)
-    {
-        if (!$attachKey) {
-            return false;
-        }
-        $this->attachmentArray[(string)$attachKey]['numDownload']++;
-
-        return $this->attachmentArray[(string)$attachKey]['numDownload'];
-    }
-
-    /**
-     * @return bool
-     */
-    public function saveAttachment()
-    {
-        $attachmentSave = '';
-        if (is_array($this->attachmentArray) && count($this->attachmentArray) > 0) {
-            $attachmentSave = base64_encode(serialize($this->attachmentArray));
-        }
-        $this->setVar('attachment', $attachmentSave);
-        $sql = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('newbb_posts') . ' SET attachment=' . $GLOBALS['xoopsDB']->quoteString($attachmentSave) . ' WHERE post_id = ' . $this->getVar('post_id');
-        if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
-            //xoops_error($GLOBALS['xoopsDB']->error());
-            return false;
-        }
-
-        return true;
-    }
-
-    /**
-     * @param  array|null $attachArray
-     * @return bool
-     */
-    public function deleteAttachment($attachArray = null)
-    {
-        $attachOld = $this->getAttachment();
-        if (!is_array($attachOld) || count($attachOld) < 1) {
-            return true;
-        }
-        $this->attachmentArray = [];
-
-        if (null === $attachArray) {
-            $attachArray = array_keys($attachOld);
-        } // to delete all!
-        if (!is_array($attachArray)) {
-            $attachArray = [$attachArray];
-        }
-
-        foreach ($attachOld as $key => $attach) {
-            if (in_array($key, $attachArray)) {
-                @unlink($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/' . $attach['name_saved']));
-                @unlink($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/thumbs/' . $attach['name_saved'])); // delete thumbnails
-                continue;
-            }
-            $this->attachmentArray[$key] = $attach;
-        }
-        $attachmentSave = '';
-        if (is_array($this->attachmentArray) && count($this->attachmentArray) > 0) {
-            $attachmentSave = base64_encode(serialize($this->attachmentArray));
-        }
-        $this->setVar('attachment', $attachmentSave);
-
-        return true;
-    }
-
-    /**
-     * @param  string $name_saved
-     * @param  string $nameDisplay
-     * @param  string $mimetype
-     * @param  int    $numDownload
-     * @return bool
-     */
-    public function setAttachment($name_saved = '', $nameDisplay = '', $mimetype = '', $numDownload = 0)
-    {
-        static $counter = 0;
-        $this->attachmentArray = $this->getAttachment();
-        if ($name_saved) {
-            $key                         = (string)(time() + $counter++);
-            $this->attachmentArray[$key] = [
-                'name_saved'  => $name_saved,
-                'nameDisplay' => empty($nameDisplay) ? $nameDisplay : $name_saved,
-                'mimetype'    => $mimetype,
-                'numDownload' => empty($numDownload) ? (int)$numDownload : 0
-            ];
-        }
-        $attachmentSave = null;
-        if (is_array($this->attachmentArray)) {
-            $attachmentSave = base64_encode(serialize($this->attachmentArray));
-        }
-        $this->setVar('attachment', $attachmentSave);
-
-        return true;
-    }
-
-    /**
-     * TODO: refactor
-     * @param  bool $asSource
-     * @return string
-     */
-    public function displayAttachment($asSource = false)
-    {
-        global $xoopsModule;
-
-        $post_attachment = '';
-        $attachments     = $this->getAttachment();
-        if (is_array($attachments) && count($attachments) > 0) {
-            $iconHandler = newbbGetIconHandler();
-            $mime_path   = $iconHandler->getPath('mime');
-            require_once dirname(__DIR__) . '/include/functions.image.php';
-            $image_extensions = ['jpg', 'jpeg', 'gif', 'png', 'bmp']; // need improve !!!
-            $post_attachment  .= '<br><strong>' . _MD_NEWBB_ATTACHMENT . '</strong>:';
-            $post_attachment  .= '<br><hr size="1" noshade="noshade" /><br>';
-            foreach ($attachments as $key => $att) {
-                $file_extension = ltrim(strrchr($att['name_saved'], '.'), '.');
-                $filetype       = $file_extension;
-                if (file_exists($GLOBALS['xoops']->path($mime_path . '/' . $filetype . '.gif'))) {
-                    $icon_filetype = XOOPS_URL . '/' . $mime_path . '/' . $filetype . '.gif';
-                } else {
-                    $icon_filetype = XOOPS_URL . '/' . $mime_path . '/unknown.gif';
-                }
-                $file_size = @filesize($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/' . $att['name_saved']));
-                $file_size = number_format($file_size / 1024, 2) . ' KB';
-                if (in_array(strtolower($file_extension), $image_extensions)
-                    && $GLOBALS['xoopsModuleConfig']['media_allowed']) {
-                    $post_attachment .= '<br><img src="' . $icon_filetype . '" alt="' . $filetype . '" /><strong>&nbsp; ' . $att['nameDisplay'] . '</strong> <small>(' . $file_size . ')</small>';
-                    $post_attachment .= '<br>' . newbbAttachmentImage($att['name_saved']);
-                    $isDisplayed     = true;
-                } else {
-                    if (empty($GLOBALS['xoopsModuleConfig']['show_userattach'])) {
-                        $post_attachment .= '<a href="'
-                                            . XOOPS_URL
-                                            . '/modules/'
-                                            . $xoopsModule->getVar('dirname', 'n')
-                                            . '/dl_attachment.php?attachid='
-                                            . $key
-                                            . '&amp;post_id='
-                                            . $this->getVar('post_id')
-                                            . '"> <img src="'
-                                            . $icon_filetype
-                                            . '" alt="'
-                                            . $filetype
-                                            . '" /> '
-                                            . $att['nameDisplay']
-                                            . '</a> '
-                                            . _MD_NEWBB_FILESIZE
-                                            . ': '
-                                            . $file_size
-                                            . '; '
-                                            . _MD_NEWBB_HITS
-                                            . ': '
-                                            . $att['numDownload'];
-                    } elseif ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser']->uid() > 0
-                              && $GLOBALS['xoopsUser']->isactive()) {
-                        $post_attachment .= '<a href="'
-                                            . XOOPS_URL
-                                            . '/modules/'
-                                            . $xoopsModule->getVar('dirname', 'n')
-                                            . '/dl_attachment.php?attachid='
-                                            . $key
-                                            . '&amp;post_id='
-                                            . $this->getVar('post_id')
-                                            . '"> <img src="'
-                                            . $icon_filetype
-                                            . '" alt="'
-                                            . $filetype
-                                            . '" /> '
-                                            . $att['nameDisplay']
-                                            . '</a> '
-                                            . _MD_NEWBB_FILESIZE
-                                            . ': '
-                                            . $file_size
-                                            . '; '
-                                            . _MD_NEWBB_HITS
-                                            . ': '
-                                            . $att['numDownload'];
-                    } else {
-                        $post_attachment .= _MD_NEWBB_SEENOTGUEST;
-                    }
-                }
-                $post_attachment .= '<br>';
-            }
-        }
-
-        return $post_attachment;
-    }
-    // attachment functions
-    // ////////////////////////////////////////////////////////////////////////////////////
-
-    /**
-     * @param  string $poster_name
-     * @param  string $post_editmsg
-     * @return bool
-     */
-    public function setPostEdit($poster_name = '', $post_editmsg = '')
-    {
-        $edit_user = '';
-        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
-            || (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
-            || $this->getVar('approved') < 1) {
-            return true;
-        }
-        if (is_object($GLOBALS['xoopsUser']) && $GLOBALS['xoopsUser']->isActive()) {
-            if ($GLOBALS['xoopsModuleConfig']['show_realname'] && $GLOBALS['xoopsUser']->getVar('name')) {
-                $edit_user = $GLOBALS['xoopsUser']->getVar('name');
-            } else {
-                $edit_user = $GLOBALS['xoopsUser']->getVar('uname');
-            }
-        }
-        $post_edit              = [];
-        $post_edit['edit_user'] = $edit_user; // (?) The proper way is to store uid instead of name.
-        // However, to save queries when displaying, the current way is ok.
-        $post_edit['edit_time'] = time();
-        $post_edit['edit_msg']  = $post_editmsg;
-
-        $post_edits = $this->getVar('post_edit');
-        if (!empty($post_edits)) {
-            $post_edits = unserialize(base64_decode($post_edits));
-        }
-        if (!is_array($post_edits)) {
-            $post_edits = [];
-        }
-        $post_edits[] = $post_edit;
-        $post_edit    = base64_encode(serialize($post_edits));
-        unset($post_edits);
-        $this->setVar('post_edit', $post_edit);
-
-        return true;
-    }
-
-    /**
-     * @return bool|string
-     */
-    public function displayPostEdit()
-    {
-        global $myts;
-
-        if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {
-            return false;
-        }
-
-        $post_edit  = '';
-        $post_edits = $this->getVar('post_edit');
-        if (!empty($post_edits)) {
-            $post_edits = unserialize(base64_decode($post_edits));
-        }
-        if (!isset($post_edits) || !is_array($post_edits)) {
-            $post_edits = [];
-        }
-        if (is_array($post_edits) && count($post_edits) > 0) {
-            foreach ($post_edits as $postedit) {
-                $edit_time = (int)$postedit['edit_time'];
-                $edit_user = $postedit['edit_user'];
-                $edit_msg  = !empty($postedit['edit_msg']) ? $postedit['edit_msg'] : '';
-                // Start irmtfan add option to do only the latest edit when do_latestedit=0 (Alfred)
-                if (empty($GLOBALS['xoopsModuleConfig']['do_latestedit'])) {
-                    $post_edit = '';
-                }
-                // End irmtfan add option to do only the latest edit when do_latestedit=0 (Alfred)
-                // START hacked by irmtfan
-                // display/save all edit records.
-                $post_edit .= _MD_NEWBB_EDITEDBY . ' ' . $edit_user . ' ' . _MD_NEWBB_ON . ' ' . formatTimestamp($edit_time) . '<br>';
-                // if reason is not empty
-                if ('' !== $edit_msg) {
-                    $post_edit .= _MD_NEWBB_EDITEDMSG . ' ' . $edit_msg . '<br>';
-                }
-                // START hacked by irmtfan
-            }
-        }
-
-        return $post_edit;
-    }
-
-    /**
-     * @return array
-     */
-    public function &getPostBody()
-    {
-        global $viewtopic_users;
-        $newbbConfig = newbbLoadConfig();
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
-        require_once  dirname(__DIR__) . '/include/functions.render.php';
-
-        $uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
-        /** @var KarmaHandler $karmaHandler */
-        $karmaHandler = Newbb\Helper::getInstance()->getHandler('Karma');
-        $user_karma   = $karmaHandler->getUserKarma();
-
-        $post               = [];
-        $post['attachment'] = false;
-        $post_text          = newbbDisplayTarea($this->vars['post_text']['value'], $this->getVar('dohtml'), $this->getVar('dosmiley'), $this->getVar('doxcode'), $this->getVar('doimage'), $this->getVar('dobr'));
-        if (newbbIsAdmin($this->getVar('forum_id')) || $this->checkIdentity()) {
-            $post['text'] = $post_text . '<br>' . $this->displayAttachment();
-        } elseif ($newbbConfig['enable_karma'] && $this->getVar('post_karma') > $user_karma) {
-            $post['text'] = sprintf(_MD_NEWBB_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma'));
-        } elseif ($newbbConfig['allow_require_reply'] && $this->getVar('require_reply')
-                  && (!$uid || !isset($viewtopic_users[$uid]))) {
-            $post['text'] = _MD_NEWBB_REPLY_REQUIREMENT;
-        } else {
-            $post['text'] = $post_text . '<br>' . $this->displayAttachment();
-        }
-        /** @var \XoopsMemberHandler $memberHandler */
-        $memberHandler = xoops_getHandler('member');
-        $eachposter    = $memberHandler->getUser($this->getVar('uid'));
-        if (is_object($eachposter) && $eachposter->isActive()) {
-            if ($newbbConfig['show_realname'] && $eachposter->getVar('name')) {
-                $post['author'] = $eachposter->getVar('name');
-            } else {
-                $post['author'] = $eachposter->getVar('uname');
-            }
-            unset($eachposter);
-        } else {
-            $post['author'] = $this->getVar('poster_name') ?: $GLOBALS['xoopsConfig']['anonymous'];
-        }
-
-        $post['subject'] = newbbHtmlspecialchars($this->vars['subject']['value']);
-
-        $post['date'] = $this->getVar('post_time');
-
-        return $post;
-    }
-
-    /**
-     * @return bool
-     */
-    public function isTopic()
-    {
-        return !$this->getVar('pid');
-    }
-
-    /**
-     * @param  string $action_tag
-     * @return bool
-     */
-    public function checkTimelimit($action_tag = 'edit_timelimit')
-    {
-        $newbbConfig = newbbLoadConfig();
-        if (empty($newbbConfig['edit_timelimit'])) {
-            return true;
-        }
-
-        return ($this->getVar('post_time') > time() - $newbbConfig[$action_tag] * 60);
-    }
-
-    /**
-     * @param  int $uid
-     * @return bool
-     */
-    public function checkIdentity($uid = -1)
-    {
-        $uid = ($uid > -1) ? $uid : (is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0);
-        if ($this->getVar('uid') > 0) {
-            $user_ok = ($uid == $this->getVar('uid'));
-        } else {
-            static $user_ip;
-            if (!isset($user_ip)) {
-                $user_ip = \Xmf\IPAddress::fromRequest()->asReadable();
-            }
-            $user_ok = ($user_ip == $this->getVar('poster_ip'));
-        }
-
-        return $user_ok;
-    }
-
-    // TODO: cleaning up and merge with post hanldings in viewpost.php
-
-    /**
-     * @param $isAdmin
-     * @return array
-     */
-    public function showPost($isAdmin)
-    {
-        global $xoopsModule, $myts;
-        global $forumUrl, $forumImage, $forumObject, $online, $viewmode;
-        global $viewtopic_users, $viewtopic_posters, $topicObject, $user_karma;
-        global $order, $start, $total_posts, $topic_status;
-        static $post_NO = 0;
-        static $name_anonymous;
-        /** @var TopicHandler $topicHandler */
-        $topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
-        if (!isset($name_anonymous)) {
-            $name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
-        }
-
-        require_once  dirname(__DIR__) . '/include/functions.time.php';
-        require_once  dirname(__DIR__) . '/include/functions.render.php';
-
-        $post_id  = $this->getVar('post_id');
-        $topic_id = $this->getVar('topic_id');
-        $forum_id = $this->getVar('forum_id');
-
-        $query_vars              = ['status', 'order', 'start', 'mode', 'viewmode'];
-        $query_array             = [];
-        $query_array['topic_id'] = "topic_id={$topic_id}";
-        foreach ($query_vars as $var) {
-            if (Request::getString($var, '', 'GET')) {
-                $query_array[$var] = "{$var}=" . Request::getString($var, '', 'GET');
-            }
-        }
-        $page_query = htmlspecialchars(implode('&', array_values($query_array)), ENT_QUOTES | ENT_HTML5);
-
-        $uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
-
-        ++$post_NO;
-        if ('desc' === strtolower($order)) {
-            $post_no = $total_posts - ($start + $post_NO) + 1;
-        } else {
-            $post_no = $start + $post_NO;
-        }
-
-        if ($isAdmin || $this->checkIdentity()) {
-            $post_text       = $this->getVar('post_text');
-            $post_attachment = $this->displayAttachment();
-        } elseif ($GLOBALS['xoopsModuleConfig']['enable_karma'] && $this->getVar('post_karma') > $user_karma) {
-            $post_text       = "<div class='karma'>" . sprintf(_MD_NEWBB_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma')) . '</div>';
-            $post_attachment = '';
-        } elseif ($GLOBALS['xoopsModuleConfig']['allow_require_reply'] && $this->getVar('require_reply')
-                  && (!$uid || !in_array($uid, $viewtopic_posters))) {
-            $post_text       = "<div class='karma'>" . _MD_NEWBB_REPLY_REQUIREMENT . '</div>';
-            $post_attachment = '';
-        } else {
-            $post_text       = $this->getVar('post_text');
-            $post_attachment = $this->displayAttachment();
-        }
-
-        // Hightlight search words
-        $post_title = $this->getVar('subject');
-        if ($keywords = Request::getString('keywords', '', 'GET')) {
-            //$keywords   = $myts->htmlSpecialChars(trim(urldecode(Request::getString('keywords', '', 'GET'))));
-            $post_text  = Highlighter::apply($keywords, $post_text, '<mark>', '</mark>');
-            $post_title = Highlighter::apply($keywords, $post_title, '<mark>', '</mark>');
-        }
-
-        if (isset($viewtopic_users[$this->getVar('uid')])) {
-            $poster = $viewtopic_users[$this->getVar('uid')];
-        } else {
-            $name   = ($post_name = $this->getVar('poster_name')) ? $post_name : $name_anonymous;
-            $poster = [
-                'poster_uid' => 0,
-                'name'       => $name,
-                'link'       => $name
-            ];
-        }
-
-        if ($posticon = $this->getVar('icon')) {
-            $post_image = '<a name="' . $post_id . '"><img src="' . XOOPS_URL . '/images/subject/' . $posticon . '" alt="" /></a>';
-        } else {
-            $post_image = '<a name="' . $post_id . '"><img src="' . XOOPS_URL . '/images/icons/posticon.gif" alt="" /></a>';
-        }
-
-        $thread_buttons = [];
-        $mod_buttons    = [];
-
-        if ($isAdmin && ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser']->getVar('uid') !== $this->getVar('uid'))
-            && $this->getVar('uid') > 0) {
-            $mod_buttons['bann']['image']    = newbbDisplayImage('p_bann', _MD_NEWBB_SUSPEND_MANAGEMENT);
-            $mod_buttons['bann']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/moderate.php?forum=' . $forum_id . '&amp;uid=' . $this->getVar('uid');
-            $mod_buttons['bann']['name']     = _MD_NEWBB_SUSPEND_MANAGEMENT;
-            $thread_buttons['bann']['image'] = newbbDisplayImage('p_bann', _MD_NEWBB_SUSPEND_MANAGEMENT);
-            $thread_buttons['bann']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/moderate.php?forum=' . $forum_id . '&amp;uid=' . $this->getVar('uid');
-            $thread_buttons['bann']['name']  = _MD_NEWBB_SUSPEND_MANAGEMENT;
-        }
-
-        if ($GLOBALS['xoopsModuleConfig']['enable_permcheck']) {
-            //            /** @var TopicHandler $topicHandler */
-            //            $topicHandler =  Newbb\Helper::getInstance()->getHandler('Topic');
-            $topic_status = $topicObject->getVar('topic_status');
-            if ($topicHandler->getPermission($forum_id, $topic_status, 'edit')) {
-                $edit_ok = ($isAdmin || ($this->checkIdentity() && $this->checkTimelimit('edit_timelimit')));
-
-                if ($edit_ok) {
-                    $thread_buttons['edit']['image'] = newbbDisplayImage('p_edit', _EDIT);
-                    $thread_buttons['edit']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
-                    $thread_buttons['edit']['name']  = _EDIT;
-                    $mod_buttons['edit']['image']    = newbbDisplayImage('p_edit', _EDIT);
-                    $mod_buttons['edit']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
-                    $mod_buttons['edit']['name']     = _EDIT;
-                }
-            }
-
-            if ($topicHandler->getPermission($forum_id, $topic_status, 'delete')) {
-                $delete_ok = ($isAdmin || ($this->checkIdentity() && $this->checkTimelimit('delete_timelimit')));
-
-                if ($delete_ok) {
-                    $thread_buttons['delete']['image'] = newbbDisplayImage('p_delete', _DELETE);
-                    $thread_buttons['delete']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
-                    $thread_buttons['delete']['name']  = _DELETE;
-                    $mod_buttons['delete']['image']    = newbbDisplayImage('p_delete', _DELETE);
-                    $mod_buttons['delete']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
-                    $mod_buttons['delete']['name']     = _DELETE;
-                }
-            }
-            if ($topicHandler->getPermission($forum_id, $topic_status, 'reply')) {
-                $thread_buttons['reply']['image'] = newbbDisplayImage('p_reply', _MD_NEWBB_REPLY);
-                $thread_buttons['reply']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}";
-                $thread_buttons['reply']['name']  = _MD_NEWBB_REPLY;
-
-                $thread_buttons['quote']['image'] = newbbDisplayImage('p_quote', _MD_NEWBB_QUOTE);
-                $thread_buttons['quote']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}&amp;quotedac=1";
-                $thread_buttons['quote']['name']  = _MD_NEWBB_QUOTE;
-            }
-        } else {
-            $mod_buttons['edit']['image'] = newbbDisplayImage('p_edit', _EDIT);
-            $mod_buttons['edit']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
-            $mod_buttons['edit']['name']  = _EDIT;
-
-            $mod_buttons['delete']['image'] = newbbDisplayImage('p_delete', _DELETE);
-            $mod_buttons['delete']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
-            $mod_buttons['delete']['name']  = _DELETE;
-
-            $thread_buttons['reply']['image'] = newbbDisplayImage('p_reply', _MD_NEWBB_REPLY);
-            $thread_buttons['reply']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}";
-            $thread_buttons['reply']['name']  = _MD_NEWBB_REPLY;
-        }
-
-        if (!$isAdmin && $GLOBALS['xoopsModuleConfig']['reportmod_enabled']) {
-            $thread_buttons['report']['image'] = newbbDisplayImage('p_report', _MD_NEWBB_REPORT);
-            $thread_buttons['report']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/report.php?{$page_query}";
-            $thread_buttons['report']['name']  = _MD_NEWBB_REPORT;
-        }
-
-        $thread_action = [];
-        // irmtfan add pdf permission
-        if (file_exists(XOOPS_ROOT_PATH . '/class/libraries/vendor/tecnickcom/tcpdf/tcpdf.php')
-            && $topicHandler->getPermission($forum_id, $topic_status, 'pdf')) {
-            $thread_action['pdf']['image']  = newbbDisplayImage('pdf', _MD_NEWBB_PDF);
-            $thread_action['pdf']['link']   = XOOPS_URL . '/modules/newbb/makepdf.php?type=post&amp;pageid=0';
-            $thread_action['pdf']['name']   = _MD_NEWBB_PDF;
-            $thread_action['pdf']['target'] = '_blank';
-        }
-        // irmtfan add print permission
-        if ($topicHandler->getPermission($forum_id, $topic_status, 'print')) {
-            $thread_action['print']['image']  = newbbDisplayImage('printer', _MD_NEWBB_PRINT);
-            $thread_action['print']['link']   = XOOPS_URL . '/modules/newbb/print.php?form=2&amp;forum=' . $forum_id . '&amp;topic_id=' . $topic_id;
-            $thread_action['print']['name']   = _MD_NEWBB_PRINT;
-            $thread_action['print']['target'] = '_blank';
-        }
-
-        if ($GLOBALS['xoopsModuleConfig']['show_sociallinks']) {
-            $full_title  = $this->getVar('subject');
-            $clean_title = preg_replace('/[^A-Za-z0-9-]+/', '+', $this->getVar('subject'));
-            $full_link   = XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $post_id;
-
-            $thread_action['social_twitter']['image']  = newbbDisplayImage('twitter', _MD_NEWBB_SHARE_TWITTER);
-            $thread_action['social_twitter']['link']   = 'http://twitter.com/share?text=' . $clean_title . '&amp;url=' . $full_link;
-            $thread_action['social_twitter']['name']   = _MD_NEWBB_SHARE_TWITTER;
-            $thread_action['social_twitter']['target'] = '_blank';
-
-            $thread_action['social_facebook']['image']  = newbbDisplayImage('facebook', _MD_NEWBB_SHARE_FACEBOOK);
-            $thread_action['social_facebook']['link']   = 'http://www.facebook.com/sharer.php?u=' . $full_link;
-            $thread_action['social_facebook']['name']   = _MD_NEWBB_SHARE_FACEBOOK;
-            $thread_action['social_facebook']['target'] = '_blank';
-
-            $thread_action['social_gplus']['image']  = newbbDisplayImage('googleplus', _MD_NEWBB_SHARE_GOOGLEPLUS);
-            $thread_action['social_gplus']['link']   = 'https://plusone.google.com/_/+1/confirm?hl=en&url=' . $full_link;
-            $thread_action['social_gplus']['name']   = _MD_NEWBB_SHARE_GOOGLEPLUS;
-            $thread_action['social_gplus']['target'] = '_blank';
-
-            $thread_action['social_linkedin']['image']  = newbbDisplayImage('linkedin', _MD_NEWBB_SHARE_LINKEDIN);
-            $thread_action['social_linkedin']['link']   = 'http://www.linkedin.com/shareArticle?mini=true&amp;title=' . $full_title . '&amp;url=' . $full_link;
-            $thread_action['social_linkedin']['name']   = _MD_NEWBB_SHARE_LINKEDIN;
-            $thread_action['social_linkedin']['target'] = '_blank';
-
-            $thread_action['social_delicious']['image']  = newbbDisplayImage('delicious', _MD_NEWBB_SHARE_DELICIOUS);
-            $thread_action['social_delicious']['link']   = 'http://del.icio.us/post?title=' . $full_title . '&amp;url=' . $full_link;
-            $thread_action['social_delicious']['name']   = _MD_NEWBB_SHARE_DELICIOUS;
-            $thread_action['social_delicious']['target'] = '_blank';
-
-            $thread_action['social_digg']['image']  = newbbDisplayImage('digg', _MD_NEWBB_SHARE_DIGG);
-            $thread_action['social_digg']['link']   = 'http://digg.com/submit?phase=2&amp;title=' . $full_title . '&amp;url=' . $full_link;
-            $thread_action['social_digg']['name']   = _MD_NEWBB_SHARE_DIGG;
-            $thread_action['social_digg']['target'] = '_blank';
-
-            $thread_action['social_reddit']['image']  = newbbDisplayImage('reddit', _MD_NEWBB_SHARE_REDDIT);
-            $thread_action['social_reddit']['link']   = 'http://reddit.com/submit?title=' . $full_title . '&amp;url=' . $full_link;
-            $thread_action['social_reddit']['name']   = _MD_NEWBB_SHARE_REDDIT;
-            $thread_action['social_reddit']['target'] = '_blank';
-
-            $thread_action['social_wong']['image']  = newbbDisplayImage('wong', _MD_NEWBB_SHARE_MRWONG);
-            $thread_action['social_wong']['link']   = 'http://www.mister-wong.de/index.php?action=addurl&bm_url=' . $full_link;
-            $thread_action['social_wong']['name']   = _MD_NEWBB_SHARE_MRWONG;
-            $thread_action['social_wong']['target'] = '_blank';
-        }
-
-        $post = [
-            'post_id'         => $post_id,
-            'post_parent_id'  => $this->getVar('pid'),
-            'post_date'       => newbbFormatTimestamp($this->getVar('post_time')),
-            'post_image'      => $post_image,
-            'post_title'      => $post_title,
-            // irmtfan $post_title to add highlight keywords
-            'post_text'       => $post_text,
-            'post_attachment' => $post_attachment,
-            'post_edit'       => $this->displayPostEdit(),
-            'post_no'         => $post_no,
-            'post_signature'  => $this->getVar('attachsig') ? @$poster['signature'] : '',
-            //            'poster_ip'       => ($isAdmin && $GLOBALS['xoopsModuleConfig']['show_ip']) ? long2ip($this->getVar('poster_ip')) : '',
-            'poster_ip'       => ($isAdmin
-                                  && $GLOBALS['xoopsModuleConfig']['show_ip']) ? $this->getVar('poster_ip') : '',
-            'thread_action'   => $thread_action,
-            'thread_buttons'  => $thread_buttons,
-            'mod_buttons'     => $mod_buttons,
-            'poster'          => $poster,
-            'post_permalink'  => '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewtopic.php?post_id=' . $post_id . '"></a>'
-        ];
-
-        unset($thread_buttons, $mod_buttons, $eachposter);
-
-        return $post;
-    }
+	//class Post extends \XoopsObject {
+	private $attachmentArray = [];
+
+	/**
+	 *
+	 */
+	public function __construct()
+	{
+		parent::__construct();
+
+		$this->initVar('post_id', XOBJ_DTYPE_INT);
+		$this->initVar('topic_id', XOBJ_DTYPE_INT, 0, true);
+		$this->initVar('forum_id', XOBJ_DTYPE_INT, 0, true);
+		$this->initVar('post_time', XOBJ_DTYPE_INT, 0, true);
+		//        $this->initVar('poster_ip', XOBJ_DTYPE_INT, 0);
+		$this->initVar('poster_ip', XOBJ_DTYPE_TXTBOX, '');
+		$this->initVar('poster_name', XOBJ_DTYPE_TXTBOX, '');
+		$this->initVar('subject', XOBJ_DTYPE_TXTBOX, '', true);
+		$this->initVar('pid', XOBJ_DTYPE_INT, 0);
+		$this->initVar('dohtml', XOBJ_DTYPE_INT, 0);
+		$this->initVar('dosmiley', XOBJ_DTYPE_INT, 1);
+		$this->initVar('doxcode', XOBJ_DTYPE_INT, 1);
+		$this->initVar('doimage', XOBJ_DTYPE_INT, 1);
+		$this->initVar('dobr', XOBJ_DTYPE_INT, 1);
+		$this->initVar('uid', XOBJ_DTYPE_INT, 1);
+		$this->initVar('icon', XOBJ_DTYPE_TXTBOX, '');
+		$this->initVar('attachsig', XOBJ_DTYPE_INT, 0);
+		$this->initVar('approved', XOBJ_DTYPE_INT, 1);
+		$this->initVar('post_karma', XOBJ_DTYPE_INT, 0);
+		$this->initVar('require_reply', XOBJ_DTYPE_INT, 0);
+		$this->initVar('attachment', XOBJ_DTYPE_TXTAREA, '');
+		$this->initVar('post_text', XOBJ_DTYPE_TXTAREA, '');
+		$this->initVar('post_edit', XOBJ_DTYPE_TXTAREA, '');
+	}
+
+	// ////////////////////////////////////////////////////////////////////////////////////
+	// attachment functions    TODO: there should be a file/attachment management class
+	/**
+	 * @return array|mixed|null
+	 */
+	public function getAttachment()
+	{
+		if (count($this->attachmentArray)) {
+			return $this->attachmentArray;
+		}
+		$attachment = $this->getVar('attachment');
+		if (empty($attachment)) {
+			$this->attachmentArray = [];
+		} else {
+			$this->attachmentArray = @unserialize(base64_decode($attachment));
+		}
+
+		return $this->attachmentArray;
+	}
+
+	/**
+	 * @param $attachKey
+	 * @return bool
+	 */
+	public function incrementDownload($attachKey)
+	{
+		if (!$attachKey) {
+			return false;
+		}
+		$this->attachmentArray[(string)$attachKey]['numDownload']++;
+
+		return $this->attachmentArray[(string)$attachKey]['numDownload'];
+	}
+
+	/**
+	 * @return bool
+	 */
+	public function saveAttachment()
+	{
+		$attachmentSave = '';
+		if (is_array($this->attachmentArray) && count($this->attachmentArray) > 0) {
+			$attachmentSave = base64_encode(serialize($this->attachmentArray));
+		}
+		$this->setVar('attachment', $attachmentSave);
+		$sql = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('newbb_posts') . ' SET attachment=' . $GLOBALS['xoopsDB']->quoteString($attachmentSave) . ' WHERE post_id = ' . $this->getVar('post_id');
+		if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
+			//xoops_error($GLOBALS['xoopsDB']->error());
+			return false;
+		}
+
+		return true;
+	}
+
+	/**
+	 * @param  array|null $attachArray
+	 * @return bool
+	 */
+	public function deleteAttachment($attachArray = null)
+	{
+		$attachOld = $this->getAttachment();
+		if (!is_array($attachOld) || count($attachOld) < 1) {
+			return true;
+		}
+		$this->attachmentArray = [];
+
+		if (null === $attachArray) {
+			$attachArray = array_keys($attachOld);
+		} // to delete all!
+		if (!is_array($attachArray)) {
+			$attachArray = [$attachArray];
+		}
+
+		foreach ($attachOld as $key => $attach) {
+			if (in_array($key, $attachArray)) {
+				@unlink($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/' . $attach['name_saved']));
+				@unlink($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/thumbs/' . $attach['name_saved'])); // delete thumbnails
+				continue;
+			}
+			$this->attachmentArray[$key] = $attach;
+		}
+		$attachmentSave = '';
+		if (is_array($this->attachmentArray) && count($this->attachmentArray) > 0) {
+			$attachmentSave = base64_encode(serialize($this->attachmentArray));
+		}
+		$this->setVar('attachment', $attachmentSave);
+
+		return true;
+	}
+
+	/**
+	 * @param  string $name_saved
+	 * @param  string $nameDisplay
+	 * @param  string $mimetype
+	 * @param  int    $numDownload
+	 * @return bool
+	 */
+	public function setAttachment($name_saved = '', $nameDisplay = '', $mimetype = '', $numDownload = 0)
+	{
+		static $counter = 0;
+		$this->attachmentArray = $this->getAttachment();
+		if ($name_saved) {
+			$key                         = (string)(time() + $counter++);
+			$this->attachmentArray[$key] = [
+				'name_saved'  => $name_saved,
+				'nameDisplay' => empty($nameDisplay) ? $nameDisplay : $name_saved,
+				'mimetype'    => $mimetype,
+				'numDownload' => empty($numDownload) ? (int)$numDownload : 0
+			];
+		}
+		$attachmentSave = null;
+		if (is_array($this->attachmentArray)) {
+			$attachmentSave = base64_encode(serialize($this->attachmentArray));
+		}
+		$this->setVar('attachment', $attachmentSave);
+
+		return true;
+	}
+
+	/**
+	 * TODO: refactor
+	 * @param  bool $asSource
+	 * @return string
+	 */
+	public function displayAttachment($asSource = false)
+	{
+		global $xoopsModule;
+
+		$post_attachment = '';
+		$attachments     = $this->getAttachment();
+		if (is_array($attachments) && count($attachments) > 0) {
+			$iconHandler = newbbGetIconHandler();
+			$mime_path   = $iconHandler->getPath('mime');
+			require_once dirname(__DIR__) . '/include/functions.image.php';
+			$image_extensions = ['jpg', 'jpeg', 'gif', 'png', 'bmp']; // need improve !!!
+			$post_attachment  .= '<br><strong>' . _MD_NEWBB_ATTACHMENT . '</strong>:';
+			$post_attachment  .= '<br><hr size="1" noshade="noshade" /><br>';
+			foreach ($attachments as $key => $att) {
+				$file_extension = ltrim(strrchr($att['name_saved'], '.'), '.');
+				$filetype       = $file_extension;
+				if (file_exists($GLOBALS['xoops']->path($mime_path . '/' . $filetype . '.gif'))) {
+					$icon_filetype = XOOPS_URL . '/' . $mime_path . '/' . $filetype . '.gif';
+				} else {
+					$icon_filetype = XOOPS_URL . '/' . $mime_path . '/unknown.gif';
+				}
+				$file_size = @filesize($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/' . $att['name_saved']));
+				$file_size = number_format($file_size / 1024, 2) . ' KB';
+				if (in_array(strtolower($file_extension), $image_extensions)
+					&& $GLOBALS['xoopsModuleConfig']['media_allowed']) {
+					$post_attachment .= '<br><img src="' . $icon_filetype . '" alt="' . $filetype . '" /><strong>&nbsp; ' . $att['nameDisplay'] . '</strong> <small>(' . $file_size . ')</small>';
+					$post_attachment .= '<br>' . newbbAttachmentImage($att['name_saved']);
+					$isDisplayed     = true;
+				} else {
+					if (empty($GLOBALS['xoopsModuleConfig']['show_userattach'])) {
+						$post_attachment .= '<a href="'
+											. XOOPS_URL
+											. '/modules/'
+											. $xoopsModule->getVar('dirname', 'n')
+											. '/dl_attachment.php?attachid='
+											. $key
+											. '&amp;post_id='
+											. $this->getVar('post_id')
+											. '"> <img src="'
+											. $icon_filetype
+											. '" alt="'
+											. $filetype
+											. '" /> '
+											. $att['nameDisplay']
+											. '</a> '
+											. _MD_NEWBB_FILESIZE
+											. ': '
+											. $file_size
+											. '; '
+											. _MD_NEWBB_HITS
+											. ': '
+											. $att['numDownload'];
+					} elseif ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser']->uid() > 0
+							  && $GLOBALS['xoopsUser']->isactive()) {
+						$post_attachment .= '<a href="'
+											. XOOPS_URL
+											. '/modules/'
+											. $xoopsModule->getVar('dirname', 'n')
+											. '/dl_attachment.php?attachid='
+											. $key
+											. '&amp;post_id='
+											. $this->getVar('post_id')
+											. '"> <img src="'
+											. $icon_filetype
+											. '" alt="'
+											. $filetype
+											. '" /> '
+											. $att['nameDisplay']
+											. '</a> '
+											. _MD_NEWBB_FILESIZE
+											. ': '
+											. $file_size
+											. '; '
+											. _MD_NEWBB_HITS
+											. ': '
+											. $att['numDownload'];
+					} else {
+						$post_attachment .= _MD_NEWBB_SEENOTGUEST;
+					}
+				}
+				$post_attachment .= '<br>';
+			}
+		}
+
+		return $post_attachment;
+	}
+	// attachment functions
+	// ////////////////////////////////////////////////////////////////////////////////////
+
+	/**
+	 * @param  string $poster_name
+	 * @param  string $post_editmsg
+	 * @return bool
+	 */
+	public function setPostEdit($poster_name = '', $post_editmsg = '')
+	{
+		$edit_user = '';
+		if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])
+			|| (time() - $this->getVar('post_time')) < $GLOBALS['xoopsModuleConfig']['recordedit_timelimit'] * 60
+			|| $this->getVar('approved') < 1) {
+			return true;
+		}
+		if (is_object($GLOBALS['xoopsUser']) && $GLOBALS['xoopsUser']->isActive()) {
+			if ($GLOBALS['xoopsModuleConfig']['show_realname'] && $GLOBALS['xoopsUser']->getVar('name')) {
+				$edit_user = $GLOBALS['xoopsUser']->getVar('name');
+			} else {
+				$edit_user = $GLOBALS['xoopsUser']->getVar('uname');
+			}
+		}
+		$post_edit              = [];
+		$post_edit['edit_user'] = $edit_user; // (?) The proper way is to store uid instead of name.
+		// However, to save queries when displaying, the current way is ok.
+		$post_edit['edit_time'] = time();
+		$post_edit['edit_msg']  = $post_editmsg;
+
+		$post_edits = $this->getVar('post_edit');
+		if (!empty($post_edits)) {
+			$post_edits = unserialize(base64_decode($post_edits));
+		}
+		if (!is_array($post_edits)) {
+			$post_edits = [];
+		}
+		$post_edits[] = $post_edit;
+		$post_edit    = base64_encode(serialize($post_edits));
+		unset($post_edits);
+		$this->setVar('post_edit', $post_edit);
+
+		return true;
+	}
+
+	/**
+	 * @return bool|string
+	 */
+	public function displayPostEdit()
+	{
+		global $myts;
+
+		if (empty($GLOBALS['xoopsModuleConfig']['recordedit_timelimit'])) {
+			return false;
+		}
+
+		$post_edit  = '';
+		$post_edits = $this->getVar('post_edit');
+		if (!empty($post_edits)) {
+			$post_edits = unserialize(base64_decode($post_edits));
+		}
+		if (!isset($post_edits) || !is_array($post_edits)) {
+			$post_edits = [];
+		}
+		if (is_array($post_edits) && count($post_edits) > 0) {
+			foreach ($post_edits as $postedit) {
+				$edit_time = (int)$postedit['edit_time'];
+				$edit_user = $postedit['edit_user'];
+				$edit_msg  = !empty($postedit['edit_msg']) ? $postedit['edit_msg'] : '';
+				// Start irmtfan add option to do only the latest edit when do_latestedit=0 (Alfred)
+				if (empty($GLOBALS['xoopsModuleConfig']['do_latestedit'])) {
+					$post_edit = '';
+				}
+				// End irmtfan add option to do only the latest edit when do_latestedit=0 (Alfred)
+				// START hacked by irmtfan
+				// display/save all edit records.
+				$post_edit .= _MD_NEWBB_EDITEDBY . ' ' . $edit_user . ' ' . _MD_NEWBB_ON . ' ' . formatTimestamp($edit_time) . '<br>';
+				// if reason is not empty
+				if ('' !== $edit_msg) {
+					$post_edit .= _MD_NEWBB_EDITEDMSG . ' ' . $edit_msg . '<br>';
+				}
+				// START hacked by irmtfan
+			}
+		}
+
+		return $post_edit;
+	}
+
+	/**
+	 * @return array
+	 */
+	public function &getPostBody()
+	{
+		global $viewtopic_users;
+		$newbbConfig = newbbLoadConfig();
+		require_once  dirname(__DIR__) . '/include/functions.user.php';
+		require_once  dirname(__DIR__) . '/include/functions.render.php';
+
+		$uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
+		/** @var KarmaHandler $karmaHandler */
+		$karmaHandler = Newbb\Helper::getInstance()->getHandler('Karma');
+		$user_karma   = $karmaHandler->getUserKarma();
+
+		$post               = [];
+		$post['attachment'] = false;
+		$post_text          = newbbDisplayTarea($this->vars['post_text']['value'], $this->getVar('dohtml'), $this->getVar('dosmiley'), $this->getVar('doxcode'), $this->getVar('doimage'), $this->getVar('dobr'));
+		if (newbbIsAdmin($this->getVar('forum_id')) || $this->checkIdentity()) {
+			$post['text'] = $post_text . '<br>' . $this->displayAttachment();
+		} elseif ($newbbConfig['enable_karma'] && $this->getVar('post_karma') > $user_karma) {
+			$post['text'] = sprintf(_MD_NEWBB_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma'));
+		} elseif ($newbbConfig['allow_require_reply'] && $this->getVar('require_reply')
+				  && (!$uid || !isset($viewtopic_users[$uid]))) {
+			$post['text'] = _MD_NEWBB_REPLY_REQUIREMENT;
+		} else {
+			$post['text'] = $post_text . '<br>' . $this->displayAttachment();
+		}
+		/** @var \XoopsMemberHandler $memberHandler */
+		$memberHandler = xoops_getHandler('member');
+		$eachposter    = $memberHandler->getUser($this->getVar('uid'));
+		if (is_object($eachposter) && $eachposter->isActive()) {
+			if ($newbbConfig['show_realname'] && $eachposter->getVar('name')) {
+				$post['author'] = $eachposter->getVar('name');
+			} else {
+				$post['author'] = $eachposter->getVar('uname');
+			}
+			unset($eachposter);
+		} else {
+			$post['author'] = $this->getVar('poster_name') ?: $GLOBALS['xoopsConfig']['anonymous'];
+		}
+
+		$post['subject'] = newbbHtmlspecialchars($this->vars['subject']['value']);
+
+		$post['date'] = $this->getVar('post_time');
+
+		return $post;
+	}
+
+	/**
+	 * @return bool
+	 */
+	public function isTopic()
+	{
+		return !$this->getVar('pid');
+	}
+
+	/**
+	 * @param  string $action_tag
+	 * @return bool
+	 */
+	public function checkTimelimit($action_tag = 'edit_timelimit')
+	{
+		$newbbConfig = newbbLoadConfig();
+		if (empty($newbbConfig['edit_timelimit'])) {
+			return true;
+		}
+
+		return ($this->getVar('post_time') > time() - $newbbConfig[$action_tag] * 60);
+	}
+
+	/**
+	 * @param  int $uid
+	 * @return bool
+	 */
+	public function checkIdentity($uid = -1)
+	{
+		$uid = ($uid > -1) ? $uid : (is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0);
+		if ($this->getVar('uid') > 0) {
+			$user_ok = ($uid == $this->getVar('uid'));
+		} else {
+			static $user_ip;
+			if (!isset($user_ip)) {
+				$user_ip = \Xmf\IPAddress::fromRequest()->asReadable();
+			}
+			$user_ok = ($user_ip == $this->getVar('poster_ip'));
+		}
+
+		return $user_ok;
+	}
+
+	// TODO: cleaning up and merge with post hanldings in viewpost.php
+
+	/**
+	 * @param $isAdmin
+	 * @return array
+	 */
+	public function showPost($isAdmin)
+	{
+		global $xoopsModule, $myts;
+		global $forumUrl, $forumImage, $forumObject, $online, $viewmode;
+		global $viewtopic_users, $viewtopic_posters, $topicObject, $user_karma;
+		global $order, $start, $total_posts, $topic_status;
+		static $post_NO = 0;
+		static $name_anonymous;
+		/** @var TopicHandler $topicHandler */
+		$topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
+		if (!isset($name_anonymous)) {
+			$name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
+		}
+
+		require_once  dirname(__DIR__) . '/include/functions.time.php';
+		require_once  dirname(__DIR__) . '/include/functions.render.php';
+
+		$post_id  = $this->getVar('post_id');
+		$topic_id = $this->getVar('topic_id');
+		$forum_id = $this->getVar('forum_id');
+
+		$query_vars              = ['status', 'order', 'start', 'mode', 'viewmode'];
+		$query_array             = [];
+		$query_array['topic_id'] = "topic_id={$topic_id}";
+		foreach ($query_vars as $var) {
+			if (Request::getString($var, '', 'GET')) {
+				$query_array[$var] = "{$var}=" . Request::getString($var, '', 'GET');
+			}
+		}
+		$page_query = htmlspecialchars(implode('&', array_values($query_array)), ENT_QUOTES | ENT_HTML5);
+
+		$uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
+
+		++$post_NO;
+		if ('desc' === strtolower($order)) {
+			$post_no = $total_posts - ($start + $post_NO) + 1;
+		} else {
+			$post_no = $start + $post_NO;
+		}
+
+		if ($isAdmin || $this->checkIdentity()) {
+			$post_text       = $this->getVar('post_text');
+			$post_attachment = $this->displayAttachment();
+		} elseif ($GLOBALS['xoopsModuleConfig']['enable_karma'] && $this->getVar('post_karma') > $user_karma) {
+			$post_text       = "<div class='karma'>" . sprintf(_MD_NEWBB_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma')) . '</div>';
+			$post_attachment = '';
+		} elseif ($GLOBALS['xoopsModuleConfig']['allow_require_reply'] && $this->getVar('require_reply')
+				  && (!$uid || !in_array($uid, $viewtopic_posters))) {
+			$post_text       = "<div class='karma'>" . _MD_NEWBB_REPLY_REQUIREMENT . '</div>';
+			$post_attachment = '';
+		} else {
+			$post_text       = $this->getVar('post_text');
+			$post_attachment = $this->displayAttachment();
+		}
+
+		// Hightlight search words
+		$post_title = $this->getVar('subject');
+		if ($keywords = Request::getString('keywords', '', 'GET')) {
+			//$keywords   = $myts->htmlSpecialChars(trim(urldecode(Request::getString('keywords', '', 'GET'))));
+			$post_text  = Highlighter::apply($keywords, $post_text, '<mark>', '</mark>');
+			$post_title = Highlighter::apply($keywords, $post_title, '<mark>', '</mark>');
+		}
+
+		if (isset($viewtopic_users[$this->getVar('uid')])) {
+			$poster = $viewtopic_users[$this->getVar('uid')];
+		} else {
+			$name   = ($post_name = $this->getVar('poster_name')) ? $post_name : $name_anonymous;
+			$poster = [
+				'poster_uid' => 0,
+				'name'       => $name,
+				'link'       => $name
+			];
+		}
+
+		if ($posticon = $this->getVar('icon')) {
+			$post_image = '<a name="' . $post_id . '"><img src="' . XOOPS_URL . '/images/subject/' . $posticon . '" alt="" /></a>';
+		} else {
+			$post_image = '<a name="' . $post_id . '"><img src="' . XOOPS_URL . '/images/icons/posticon.gif" alt="" /></a>';
+		}
+
+		$thread_buttons = [];
+		$mod_buttons    = [];
+
+		if ($isAdmin && ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser']->getVar('uid') !== $this->getVar('uid'))
+			&& $this->getVar('uid') > 0) {
+			$mod_buttons['bann']['image']    = newbbDisplayImage('p_bann', _MD_NEWBB_SUSPEND_MANAGEMENT);
+			$mod_buttons['bann']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/moderate.php?forum=' . $forum_id . '&amp;uid=' . $this->getVar('uid');
+			$mod_buttons['bann']['name']     = _MD_NEWBB_SUSPEND_MANAGEMENT;
+			$thread_buttons['bann']['image'] = newbbDisplayImage('p_bann', _MD_NEWBB_SUSPEND_MANAGEMENT);
+			$thread_buttons['bann']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/moderate.php?forum=' . $forum_id . '&amp;uid=' . $this->getVar('uid');
+			$thread_buttons['bann']['name']  = _MD_NEWBB_SUSPEND_MANAGEMENT;
+		}
+
+		if ($GLOBALS['xoopsModuleConfig']['enable_permcheck']) {
+			//            /** @var TopicHandler $topicHandler */
+			//            $topicHandler =  Newbb\Helper::getInstance()->getHandler('Topic');
+			$topic_status = $topicObject->getVar('topic_status');
+			if ($topicHandler->getPermission($forum_id, $topic_status, 'edit')) {
+				$edit_ok = ($isAdmin || ($this->checkIdentity() && $this->checkTimelimit('edit_timelimit')));
+
+				if ($edit_ok) {
+					$thread_buttons['edit']['image'] = newbbDisplayImage('p_edit', _EDIT);
+					$thread_buttons['edit']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
+					$thread_buttons['edit']['name']  = _EDIT;
+					$mod_buttons['edit']['image']    = newbbDisplayImage('p_edit', _EDIT);
+					$mod_buttons['edit']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
+					$mod_buttons['edit']['name']     = _EDIT;
+				}
+			}
+
+			if ($topicHandler->getPermission($forum_id, $topic_status, 'delete')) {
+				$delete_ok = ($isAdmin || ($this->checkIdentity() && $this->checkTimelimit('delete_timelimit')));
+
+				if ($delete_ok) {
+					$thread_buttons['delete']['image'] = newbbDisplayImage('p_delete', _DELETE);
+					$thread_buttons['delete']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
+					$thread_buttons['delete']['name']  = _DELETE;
+					$mod_buttons['delete']['image']    = newbbDisplayImage('p_delete', _DELETE);
+					$mod_buttons['delete']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
+					$mod_buttons['delete']['name']     = _DELETE;
+				}
+			}
+			if ($topicHandler->getPermission($forum_id, $topic_status, 'reply')) {
+				$thread_buttons['reply']['image'] = newbbDisplayImage('p_reply', _MD_NEWBB_REPLY);
+				$thread_buttons['reply']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}";
+				$thread_buttons['reply']['name']  = _MD_NEWBB_REPLY;
+
+				$thread_buttons['quote']['image'] = newbbDisplayImage('p_quote', _MD_NEWBB_QUOTE);
+				$thread_buttons['quote']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}&amp;quotedac=1";
+				$thread_buttons['quote']['name']  = _MD_NEWBB_QUOTE;
+			}
+		} else {
+			$mod_buttons['edit']['image'] = newbbDisplayImage('p_edit', _EDIT);
+			$mod_buttons['edit']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
+			$mod_buttons['edit']['name']  = _EDIT;
+
+			$mod_buttons['delete']['image'] = newbbDisplayImage('p_delete', _DELETE);
+			$mod_buttons['delete']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
+			$mod_buttons['delete']['name']  = _DELETE;
+
+			$thread_buttons['reply']['image'] = newbbDisplayImage('p_reply', _MD_NEWBB_REPLY);
+			$thread_buttons['reply']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}";
+			$thread_buttons['reply']['name']  = _MD_NEWBB_REPLY;
+		}
+
+		if (!$isAdmin && $GLOBALS['xoopsModuleConfig']['reportmod_enabled']) {
+			$thread_buttons['report']['image'] = newbbDisplayImage('p_report', _MD_NEWBB_REPORT);
+			$thread_buttons['report']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/report.php?{$page_query}";
+			$thread_buttons['report']['name']  = _MD_NEWBB_REPORT;
+		}
+
+		$thread_action = [];
+		// irmtfan add pdf permission
+		if (file_exists(XOOPS_ROOT_PATH . '/class/libraries/vendor/tecnickcom/tcpdf/tcpdf.php')
+			&& $topicHandler->getPermission($forum_id, $topic_status, 'pdf')) {
+			$thread_action['pdf']['image']  = newbbDisplayImage('pdf', _MD_NEWBB_PDF);
+			$thread_action['pdf']['link']   = XOOPS_URL . '/modules/newbb/makepdf.php?type=post&amp;pageid=0';
+			$thread_action['pdf']['name']   = _MD_NEWBB_PDF;
+			$thread_action['pdf']['target'] = '_blank';
+		}
+		// irmtfan add print permission
+		if ($topicHandler->getPermission($forum_id, $topic_status, 'print')) {
+			$thread_action['print']['image']  = newbbDisplayImage('printer', _MD_NEWBB_PRINT);
+			$thread_action['print']['link']   = XOOPS_URL . '/modules/newbb/print.php?form=2&amp;forum=' . $forum_id . '&amp;topic_id=' . $topic_id;
+			$thread_action['print']['name']   = _MD_NEWBB_PRINT;
+			$thread_action['print']['target'] = '_blank';
+		}
+
+		if ($GLOBALS['xoopsModuleConfig']['show_sociallinks']) {
+			$full_title  = $this->getVar('subject');
+			$clean_title = preg_replace('/[^A-Za-z0-9-]+/', '+', $this->getVar('subject'));
+			$full_link   = XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $post_id;
+
+			$thread_action['social_twitter']['image']  = newbbDisplayImage('twitter', _MD_NEWBB_SHARE_TWITTER);
+			$thread_action['social_twitter']['link']   = 'http://twitter.com/share?text=' . $clean_title . '&amp;url=' . $full_link;
+			$thread_action['social_twitter']['name']   = _MD_NEWBB_SHARE_TWITTER;
+			$thread_action['social_twitter']['target'] = '_blank';
+
+			$thread_action['social_facebook']['image']  = newbbDisplayImage('facebook', _MD_NEWBB_SHARE_FACEBOOK);
+			$thread_action['social_facebook']['link']   = 'http://www.facebook.com/sharer.php?u=' . $full_link;
+			$thread_action['social_facebook']['name']   = _MD_NEWBB_SHARE_FACEBOOK;
+			$thread_action['social_facebook']['target'] = '_blank';
+
+			$thread_action['social_gplus']['image']  = newbbDisplayImage('googleplus', _MD_NEWBB_SHARE_GOOGLEPLUS);
+			$thread_action['social_gplus']['link']   = 'https://plusone.google.com/_/+1/confirm?hl=en&url=' . $full_link;
+			$thread_action['social_gplus']['name']   = _MD_NEWBB_SHARE_GOOGLEPLUS;
+			$thread_action['social_gplus']['target'] = '_blank';
+
+			$thread_action['social_linkedin']['image']  = newbbDisplayImage('linkedin', _MD_NEWBB_SHARE_LINKEDIN);
+			$thread_action['social_linkedin']['link']   = 'http://www.linkedin.com/shareArticle?mini=true&amp;title=' . $full_title . '&amp;url=' . $full_link;
+			$thread_action['social_linkedin']['name']   = _MD_NEWBB_SHARE_LINKEDIN;
+			$thread_action['social_linkedin']['target'] = '_blank';
+
+			$thread_action['social_delicious']['image']  = newbbDisplayImage('delicious', _MD_NEWBB_SHARE_DELICIOUS);
+			$thread_action['social_delicious']['link']   = 'http://del.icio.us/post?title=' . $full_title . '&amp;url=' . $full_link;
+			$thread_action['social_delicious']['name']   = _MD_NEWBB_SHARE_DELICIOUS;
+			$thread_action['social_delicious']['target'] = '_blank';
+
+			$thread_action['social_digg']['image']  = newbbDisplayImage('digg', _MD_NEWBB_SHARE_DIGG);
+			$thread_action['social_digg']['link']   = 'http://digg.com/submit?phase=2&amp;title=' . $full_title . '&amp;url=' . $full_link;
+			$thread_action['social_digg']['name']   = _MD_NEWBB_SHARE_DIGG;
+			$thread_action['social_digg']['target'] = '_blank';
+
+			$thread_action['social_reddit']['image']  = newbbDisplayImage('reddit', _MD_NEWBB_SHARE_REDDIT);
+			$thread_action['social_reddit']['link']   = 'http://reddit.com/submit?title=' . $full_title . '&amp;url=' . $full_link;
+			$thread_action['social_reddit']['name']   = _MD_NEWBB_SHARE_REDDIT;
+			$thread_action['social_reddit']['target'] = '_blank';
+
+			$thread_action['social_wong']['image']  = newbbDisplayImage('wong', _MD_NEWBB_SHARE_MRWONG);
+			$thread_action['social_wong']['link']   = 'http://www.mister-wong.de/index.php?action=addurl&bm_url=' . $full_link;
+			$thread_action['social_wong']['name']   = _MD_NEWBB_SHARE_MRWONG;
+			$thread_action['social_wong']['target'] = '_blank';
+		}
+
+		$post = [
+			'post_id'         => $post_id,
+			'post_parent_id'  => $this->getVar('pid'),
+			'post_date'       => newbbFormatTimestamp($this->getVar('post_time')),
+			'post_image'      => $post_image,
+			'post_title'      => $post_title,
+			// irmtfan $post_title to add highlight keywords
+			'post_text'       => $post_text,
+			'post_attachment' => $post_attachment,
+			'post_edit'       => $this->displayPostEdit(),
+			'post_no'         => $post_no,
+			'post_signature'  => $this->getVar('attachsig') ? @$poster['signature'] : '',
+			//            'poster_ip'       => ($isAdmin && $GLOBALS['xoopsModuleConfig']['show_ip']) ? long2ip($this->getVar('poster_ip')) : '',
+			'poster_ip'       => ($isAdmin
+								  && $GLOBALS['xoopsModuleConfig']['show_ip']) ? $this->getVar('poster_ip') : '',
+			'thread_action'   => $thread_action,
+			'thread_buttons'  => $thread_buttons,
+			'mod_buttons'     => $mod_buttons,
+			'poster'          => $poster,
+			'post_permalink'  => '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewtopic.php?post_id=' . $post_id . '"></a>'
+		];
+
+		unset($thread_buttons, $mod_buttons, $eachposter);
+
+		return $post;
+	}
 }

Spacing +51 added lines, -51 removed lines

@@ -122,7 +122,7 @@ 
             $attachmentSave = base64_encode(serialize($this->attachmentArray));
         }
         $this->setVar('attachment', $attachmentSave);
-        $sql = 'UPDATE ' . $GLOBALS['xoopsDB']->prefix('newbb_posts') . ' SET attachment=' . $GLOBALS['xoopsDB']->quoteString($attachmentSave) . ' WHERE post_id = ' . $this->getVar('post_id');
+        $sql = 'UPDATE '.$GLOBALS['xoopsDB']->prefix('newbb_posts').' SET attachment='.$GLOBALS['xoopsDB']->quoteString($attachmentSave).' WHERE post_id = '.$this->getVar('post_id');
         if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
             //xoops_error($GLOBALS['xoopsDB']->error());
             return false;
@@ -152,8 +152,8 @@ 
 
         foreach ($attachOld as $key => $attach) {
             if (in_array($key, $attachArray)) {
-                @unlink($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/' . $attach['name_saved']));
-                @unlink($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/thumbs/' . $attach['name_saved'])); // delete thumbnails
+                @unlink($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'].'/'.$attach['name_saved']));
+                @unlink($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'].'/thumbs/'.$attach['name_saved'])); // delete thumbnails
                 continue;
             }
             $this->attachmentArray[$key] = $attach;
@@ -210,25 +210,25 @@ 
         if (is_array($attachments) && count($attachments) > 0) {
             $iconHandler = newbbGetIconHandler();
             $mime_path   = $iconHandler->getPath('mime');
-            require_once dirname(__DIR__) . '/include/functions.image.php';
+            require_once dirname(__DIR__).'/include/functions.image.php';
             $image_extensions = ['jpg', 'jpeg', 'gif', 'png', 'bmp']; // need improve !!!
-            $post_attachment  .= '<br><strong>' . _MD_NEWBB_ATTACHMENT . '</strong>:';
+            $post_attachment  .= '<br><strong>'._MD_NEWBB_ATTACHMENT.'</strong>:';
             $post_attachment  .= '<br><hr size="1" noshade="noshade" /><br>';
             foreach ($attachments as $key => $att) {
                 $file_extension = ltrim(strrchr($att['name_saved'], '.'), '.');
                 $filetype       = $file_extension;
-                if (file_exists($GLOBALS['xoops']->path($mime_path . '/' . $filetype . '.gif'))) {
-                    $icon_filetype = XOOPS_URL . '/' . $mime_path . '/' . $filetype . '.gif';
+                if (file_exists($GLOBALS['xoops']->path($mime_path.'/'.$filetype.'.gif'))) {
+                    $icon_filetype = XOOPS_URL.'/'.$mime_path.'/'.$filetype.'.gif';
                 } else {
-                    $icon_filetype = XOOPS_URL . '/' . $mime_path . '/unknown.gif';
+                    $icon_filetype = XOOPS_URL.'/'.$mime_path.'/unknown.gif';
                 }
-                $file_size = @filesize($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'] . '/' . $att['name_saved']));
-                $file_size = number_format($file_size / 1024, 2) . ' KB';
+                $file_size = @filesize($GLOBALS['xoops']->path($GLOBALS['xoopsModuleConfig']['dir_attachments'].'/'.$att['name_saved']));
+                $file_size = number_format($file_size / 1024, 2).' KB';
                 if (in_array(strtolower($file_extension), $image_extensions)
                     && $GLOBALS['xoopsModuleConfig']['media_allowed']) {
-                    $post_attachment .= '<br><img src="' . $icon_filetype . '" alt="' . $filetype . '" /><strong>&nbsp; ' . $att['nameDisplay'] . '</strong> <small>(' . $file_size . ')</small>';
-                    $post_attachment .= '<br>' . newbbAttachmentImage($att['name_saved']);
-                    $isDisplayed     = true;
+                    $post_attachment .= '<br><img src="'.$icon_filetype.'" alt="'.$filetype.'" /><strong>&nbsp; '.$att['nameDisplay'].'</strong> <small>('.$file_size.')</small>';
+                    $post_attachment .= '<br>'.newbbAttachmentImage($att['name_saved']);
+                    $isDisplayed = true;
                 } else {
                     if (empty($GLOBALS['xoopsModuleConfig']['show_userattach'])) {
                         $post_attachment .= '<a href="'
@@ -362,10 +362,10 @@ 
                 // End irmtfan add option to do only the latest edit when do_latestedit=0 (Alfred)
                 // START hacked by irmtfan
                 // display/save all edit records.
-                $post_edit .= _MD_NEWBB_EDITEDBY . ' ' . $edit_user . ' ' . _MD_NEWBB_ON . ' ' . formatTimestamp($edit_time) . '<br>';
+                $post_edit .= _MD_NEWBB_EDITEDBY.' '.$edit_user.' '._MD_NEWBB_ON.' '.formatTimestamp($edit_time).'<br>';
                 // if reason is not empty
                 if ('' !== $edit_msg) {
-                    $post_edit .= _MD_NEWBB_EDITEDMSG . ' ' . $edit_msg . '<br>';
+                    $post_edit .= _MD_NEWBB_EDITEDMSG.' '.$edit_msg.'<br>';
                 }
                 // START hacked by irmtfan
             }
@@ -381,8 +381,8 @@ 
     {
         global $viewtopic_users;
         $newbbConfig = newbbLoadConfig();
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
-        require_once  dirname(__DIR__) . '/include/functions.render.php';
+        require_once  dirname(__DIR__).'/include/functions.user.php';
+        require_once  dirname(__DIR__).'/include/functions.render.php';
 
         $uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
         /** @var KarmaHandler $karmaHandler */
@@ -393,14 +393,14 @@ 
         $post['attachment'] = false;
         $post_text          = newbbDisplayTarea($this->vars['post_text']['value'], $this->getVar('dohtml'), $this->getVar('dosmiley'), $this->getVar('doxcode'), $this->getVar('doimage'), $this->getVar('dobr'));
         if (newbbIsAdmin($this->getVar('forum_id')) || $this->checkIdentity()) {
-            $post['text'] = $post_text . '<br>' . $this->displayAttachment();
+            $post['text'] = $post_text.'<br>'.$this->displayAttachment();
         } elseif ($newbbConfig['enable_karma'] && $this->getVar('post_karma') > $user_karma) {
             $post['text'] = sprintf(_MD_NEWBB_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma'));
         } elseif ($newbbConfig['allow_require_reply'] && $this->getVar('require_reply')
                   && (!$uid || !isset($viewtopic_users[$uid]))) {
             $post['text'] = _MD_NEWBB_REPLY_REQUIREMENT;
         } else {
-            $post['text'] = $post_text . '<br>' . $this->displayAttachment();
+            $post['text'] = $post_text.'<br>'.$this->displayAttachment();
         }
         /** @var \XoopsMemberHandler $memberHandler */
         $memberHandler = xoops_getHandler('member');
@@ -485,8 +485,8 @@ 
             $name_anonymous = $myts->htmlSpecialChars($GLOBALS['xoopsConfig']['anonymous']);
         }
 
-        require_once  dirname(__DIR__) . '/include/functions.time.php';
-        require_once  dirname(__DIR__) . '/include/functions.render.php';
+        require_once  dirname(__DIR__).'/include/functions.time.php';
+        require_once  dirname(__DIR__).'/include/functions.render.php';
 
         $post_id  = $this->getVar('post_id');
         $topic_id = $this->getVar('topic_id');
@@ -497,7 +497,7 @@ 
         $query_array['topic_id'] = "topic_id={$topic_id}";
         foreach ($query_vars as $var) {
             if (Request::getString($var, '', 'GET')) {
-                $query_array[$var] = "{$var}=" . Request::getString($var, '', 'GET');
+                $query_array[$var] = "{$var}=".Request::getString($var, '', 'GET');
             }
         }
         $page_query = htmlspecialchars(implode('&', array_values($query_array)), ENT_QUOTES | ENT_HTML5);
@@ -515,11 +515,11 @@ 
             $post_text       = $this->getVar('post_text');
             $post_attachment = $this->displayAttachment();
         } elseif ($GLOBALS['xoopsModuleConfig']['enable_karma'] && $this->getVar('post_karma') > $user_karma) {
-            $post_text       = "<div class='karma'>" . sprintf(_MD_NEWBB_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma')) . '</div>';
+            $post_text       = "<div class='karma'>".sprintf(_MD_NEWBB_KARMA_REQUIREMENT, $user_karma, $this->getVar('post_karma')).'</div>';
             $post_attachment = '';
         } elseif ($GLOBALS['xoopsModuleConfig']['allow_require_reply'] && $this->getVar('require_reply')
                   && (!$uid || !in_array($uid, $viewtopic_posters))) {
-            $post_text       = "<div class='karma'>" . _MD_NEWBB_REPLY_REQUIREMENT . '</div>';
+            $post_text       = "<div class='karma'>"._MD_NEWBB_REPLY_REQUIREMENT.'</div>';
             $post_attachment = '';
         } else {
             $post_text       = $this->getVar('post_text');
@@ -546,9 +546,9 @@ 
         }
 
         if ($posticon = $this->getVar('icon')) {
-            $post_image = '<a name="' . $post_id . '"><img src="' . XOOPS_URL . '/images/subject/' . $posticon . '" alt="" /></a>';
+            $post_image = '<a name="'.$post_id.'"><img src="'.XOOPS_URL.'/images/subject/'.$posticon.'" alt="" /></a>';
         } else {
-            $post_image = '<a name="' . $post_id . '"><img src="' . XOOPS_URL . '/images/icons/posticon.gif" alt="" /></a>';
+            $post_image = '<a name="'.$post_id.'"><img src="'.XOOPS_URL.'/images/icons/posticon.gif" alt="" /></a>';
         }
 
         $thread_buttons = [];
@@ -557,10 +557,10 @@ 
         if ($isAdmin && ($GLOBALS['xoopsUser'] && $GLOBALS['xoopsUser']->getVar('uid') !== $this->getVar('uid'))
             && $this->getVar('uid') > 0) {
             $mod_buttons['bann']['image']    = newbbDisplayImage('p_bann', _MD_NEWBB_SUSPEND_MANAGEMENT);
-            $mod_buttons['bann']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/moderate.php?forum=' . $forum_id . '&amp;uid=' . $this->getVar('uid');
+            $mod_buttons['bann']['link']     = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname').'/moderate.php?forum='.$forum_id.'&amp;uid='.$this->getVar('uid');
             $mod_buttons['bann']['name']     = _MD_NEWBB_SUSPEND_MANAGEMENT;
             $thread_buttons['bann']['image'] = newbbDisplayImage('p_bann', _MD_NEWBB_SUSPEND_MANAGEMENT);
-            $thread_buttons['bann']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/moderate.php?forum=' . $forum_id . '&amp;uid=' . $this->getVar('uid');
+            $thread_buttons['bann']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname').'/moderate.php?forum='.$forum_id.'&amp;uid='.$this->getVar('uid');
             $thread_buttons['bann']['name']  = _MD_NEWBB_SUSPEND_MANAGEMENT;
         }
 
@@ -573,10 +573,10 @@ 
 
                 if ($edit_ok) {
                     $thread_buttons['edit']['image'] = newbbDisplayImage('p_edit', _EDIT);
-                    $thread_buttons['edit']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
+                    $thread_buttons['edit']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/edit.php?{$page_query}";
                     $thread_buttons['edit']['name']  = _EDIT;
                     $mod_buttons['edit']['image']    = newbbDisplayImage('p_edit', _EDIT);
-                    $mod_buttons['edit']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
+                    $mod_buttons['edit']['link']     = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/edit.php?{$page_query}";
                     $mod_buttons['edit']['name']     = _EDIT;
                 }
             }
@@ -586,55 +586,55 @@ 
 
                 if ($delete_ok) {
                     $thread_buttons['delete']['image'] = newbbDisplayImage('p_delete', _DELETE);
-                    $thread_buttons['delete']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
+                    $thread_buttons['delete']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/delete.php?{$page_query}";
                     $thread_buttons['delete']['name']  = _DELETE;
                     $mod_buttons['delete']['image']    = newbbDisplayImage('p_delete', _DELETE);
-                    $mod_buttons['delete']['link']     = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
+                    $mod_buttons['delete']['link']     = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/delete.php?{$page_query}";
                     $mod_buttons['delete']['name']     = _DELETE;
                 }
             }
             if ($topicHandler->getPermission($forum_id, $topic_status, 'reply')) {
                 $thread_buttons['reply']['image'] = newbbDisplayImage('p_reply', _MD_NEWBB_REPLY);
-                $thread_buttons['reply']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}";
+                $thread_buttons['reply']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/reply.php?{$page_query}";
                 $thread_buttons['reply']['name']  = _MD_NEWBB_REPLY;
 
                 $thread_buttons['quote']['image'] = newbbDisplayImage('p_quote', _MD_NEWBB_QUOTE);
-                $thread_buttons['quote']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}&amp;quotedac=1";
+                $thread_buttons['quote']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/reply.php?{$page_query}&amp;quotedac=1";
                 $thread_buttons['quote']['name']  = _MD_NEWBB_QUOTE;
             }
         } else {
             $mod_buttons['edit']['image'] = newbbDisplayImage('p_edit', _EDIT);
-            $mod_buttons['edit']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/edit.php?{$page_query}";
+            $mod_buttons['edit']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/edit.php?{$page_query}";
             $mod_buttons['edit']['name']  = _EDIT;
 
             $mod_buttons['delete']['image'] = newbbDisplayImage('p_delete', _DELETE);
-            $mod_buttons['delete']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/delete.php?{$page_query}";
+            $mod_buttons['delete']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/delete.php?{$page_query}";
             $mod_buttons['delete']['name']  = _DELETE;
 
             $thread_buttons['reply']['image'] = newbbDisplayImage('p_reply', _MD_NEWBB_REPLY);
-            $thread_buttons['reply']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/reply.php?{$page_query}";
+            $thread_buttons['reply']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/reply.php?{$page_query}";
             $thread_buttons['reply']['name']  = _MD_NEWBB_REPLY;
         }
 
         if (!$isAdmin && $GLOBALS['xoopsModuleConfig']['reportmod_enabled']) {
             $thread_buttons['report']['image'] = newbbDisplayImage('p_report', _MD_NEWBB_REPORT);
-            $thread_buttons['report']['link']  = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/report.php?{$page_query}";
+            $thread_buttons['report']['link']  = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname')."/report.php?{$page_query}";
             $thread_buttons['report']['name']  = _MD_NEWBB_REPORT;
         }
 
         $thread_action = [];
         // irmtfan add pdf permission
-        if (file_exists(XOOPS_ROOT_PATH . '/class/libraries/vendor/tecnickcom/tcpdf/tcpdf.php')
+        if (file_exists(XOOPS_ROOT_PATH.'/class/libraries/vendor/tecnickcom/tcpdf/tcpdf.php')
             && $topicHandler->getPermission($forum_id, $topic_status, 'pdf')) {
             $thread_action['pdf']['image']  = newbbDisplayImage('pdf', _MD_NEWBB_PDF);
-            $thread_action['pdf']['link']   = XOOPS_URL . '/modules/newbb/makepdf.php?type=post&amp;pageid=0';
+            $thread_action['pdf']['link']   = XOOPS_URL.'/modules/newbb/makepdf.php?type=post&amp;pageid=0';
             $thread_action['pdf']['name']   = _MD_NEWBB_PDF;
             $thread_action['pdf']['target'] = '_blank';
         }
         // irmtfan add print permission
         if ($topicHandler->getPermission($forum_id, $topic_status, 'print')) {
             $thread_action['print']['image']  = newbbDisplayImage('printer', _MD_NEWBB_PRINT);
-            $thread_action['print']['link']   = XOOPS_URL . '/modules/newbb/print.php?form=2&amp;forum=' . $forum_id . '&amp;topic_id=' . $topic_id;
+            $thread_action['print']['link']   = XOOPS_URL.'/modules/newbb/print.php?form=2&amp;forum='.$forum_id.'&amp;topic_id='.$topic_id;
             $thread_action['print']['name']   = _MD_NEWBB_PRINT;
             $thread_action['print']['target'] = '_blank';
         }
@@ -642,45 +642,45 @@ 
         if ($GLOBALS['xoopsModuleConfig']['show_sociallinks']) {
             $full_title  = $this->getVar('subject');
             $clean_title = preg_replace('/[^A-Za-z0-9-]+/', '+', $this->getVar('subject'));
-            $full_link   = XOOPS_URL . '/modules/newbb/viewtopic.php?post_id=' . $post_id;
+            $full_link   = XOOPS_URL.'/modules/newbb/viewtopic.php?post_id='.$post_id;
 
             $thread_action['social_twitter']['image']  = newbbDisplayImage('twitter', _MD_NEWBB_SHARE_TWITTER);
-            $thread_action['social_twitter']['link']   = 'http://twitter.com/share?text=' . $clean_title . '&amp;url=' . $full_link;
+            $thread_action['social_twitter']['link']   = 'http://twitter.com/share?text='.$clean_title.'&amp;url='.$full_link;
             $thread_action['social_twitter']['name']   = _MD_NEWBB_SHARE_TWITTER;
             $thread_action['social_twitter']['target'] = '_blank';
 
             $thread_action['social_facebook']['image']  = newbbDisplayImage('facebook', _MD_NEWBB_SHARE_FACEBOOK);
-            $thread_action['social_facebook']['link']   = 'http://www.facebook.com/sharer.php?u=' . $full_link;
+            $thread_action['social_facebook']['link']   = 'http://www.facebook.com/sharer.php?u='.$full_link;
             $thread_action['social_facebook']['name']   = _MD_NEWBB_SHARE_FACEBOOK;
             $thread_action['social_facebook']['target'] = '_blank';
 
             $thread_action['social_gplus']['image']  = newbbDisplayImage('googleplus', _MD_NEWBB_SHARE_GOOGLEPLUS);
-            $thread_action['social_gplus']['link']   = 'https://plusone.google.com/_/+1/confirm?hl=en&url=' . $full_link;
+            $thread_action['social_gplus']['link']   = 'https://plusone.google.com/_/+1/confirm?hl=en&url='.$full_link;
             $thread_action['social_gplus']['name']   = _MD_NEWBB_SHARE_GOOGLEPLUS;
             $thread_action['social_gplus']['target'] = '_blank';
 
             $thread_action['social_linkedin']['image']  = newbbDisplayImage('linkedin', _MD_NEWBB_SHARE_LINKEDIN);
-            $thread_action['social_linkedin']['link']   = 'http://www.linkedin.com/shareArticle?mini=true&amp;title=' . $full_title . '&amp;url=' . $full_link;
+            $thread_action['social_linkedin']['link']   = 'http://www.linkedin.com/shareArticle?mini=true&amp;title='.$full_title.'&amp;url='.$full_link;
             $thread_action['social_linkedin']['name']   = _MD_NEWBB_SHARE_LINKEDIN;
             $thread_action['social_linkedin']['target'] = '_blank';
 
             $thread_action['social_delicious']['image']  = newbbDisplayImage('delicious', _MD_NEWBB_SHARE_DELICIOUS);
-            $thread_action['social_delicious']['link']   = 'http://del.icio.us/post?title=' . $full_title . '&amp;url=' . $full_link;
+            $thread_action['social_delicious']['link']   = 'http://del.icio.us/post?title='.$full_title.'&amp;url='.$full_link;
             $thread_action['social_delicious']['name']   = _MD_NEWBB_SHARE_DELICIOUS;
             $thread_action['social_delicious']['target'] = '_blank';
 
             $thread_action['social_digg']['image']  = newbbDisplayImage('digg', _MD_NEWBB_SHARE_DIGG);
-            $thread_action['social_digg']['link']   = 'http://digg.com/submit?phase=2&amp;title=' . $full_title . '&amp;url=' . $full_link;
+            $thread_action['social_digg']['link']   = 'http://digg.com/submit?phase=2&amp;title='.$full_title.'&amp;url='.$full_link;
             $thread_action['social_digg']['name']   = _MD_NEWBB_SHARE_DIGG;
             $thread_action['social_digg']['target'] = '_blank';
 
             $thread_action['social_reddit']['image']  = newbbDisplayImage('reddit', _MD_NEWBB_SHARE_REDDIT);
-            $thread_action['social_reddit']['link']   = 'http://reddit.com/submit?title=' . $full_title . '&amp;url=' . $full_link;
+            $thread_action['social_reddit']['link']   = 'http://reddit.com/submit?title='.$full_title.'&amp;url='.$full_link;
             $thread_action['social_reddit']['name']   = _MD_NEWBB_SHARE_REDDIT;
             $thread_action['social_reddit']['target'] = '_blank';
 
             $thread_action['social_wong']['image']  = newbbDisplayImage('wong', _MD_NEWBB_SHARE_MRWONG);
-            $thread_action['social_wong']['link']   = 'http://www.mister-wong.de/index.php?action=addurl&bm_url=' . $full_link;
+            $thread_action['social_wong']['link']   = 'http://www.mister-wong.de/index.php?action=addurl&bm_url='.$full_link;
             $thread_action['social_wong']['name']   = _MD_NEWBB_SHARE_MRWONG;
             $thread_action['social_wong']['target'] = '_blank';
         }
@@ -704,7 +704,7 @@ 
             'thread_buttons'  => $thread_buttons,
             'mod_buttons'     => $mod_buttons,
             'poster'          => $poster,
-            'post_permalink'  => '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewtopic.php?post_id=' . $post_id . '"></a>'
+            'post_permalink'  => '<a href="'.XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname').'/viewtopic.php?post_id='.$post_id.'"></a>'
         ];
 
         unset($thread_buttons, $mod_buttons, $eachposter);

class/PostHandler.php

Indentation +545 added lines, -545 removed lines

@@ -41,555 +41,555 @@
  */
 class PostHandler extends \XoopsPersistableObjectHandler
 {
-    /**
-     * @param \XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db)
-    {
-        parent::__construct($db, 'newbb_posts', Post::class, 'post_id', 'subject');
-    }
-
-    /**
-     * @param  mixed $id
-     * @param  null  $var
-     * @return null|\XoopsObject
-     */
-    public function get($id = null, $var = null) //get($id)
-    {
-        $id   = (int)$id;
-        $post = null;
-        $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' t ON p.post_id=t.post_id WHERE p.post_id=' . $id;
-        if ($array = $this->db->fetchArray($this->db->query($sql))) {
-            $post = $this->create(false);
-            $post->assignVars($array);
-        }
-
-        return $post;
-    }
-
-    /**
-     * @param  int             $limit
-     * @param  int             $start
-     * @param  \CriteriaElement $criteria
-     * @param  null            $fields
-     * @param  bool            $asObject
-     * @param  int             $topic_id
-     * @param  int             $approved
-     * @return array
-     */
-    //    public function getByLimit($topic_id, $limit, $approved = 1)
-    public function &getByLimit(
-        $limit = 0,
-        $start = 0,
-        \CriteriaElement $criteria = null,
-        $fields = null,
-        $asObject = true,
-        $topic_id = 0,
-        $approved = 1
-    ) {
-        $sql    = 'SELECT p.*, t.*, tp.topic_status FROM '
-                  . $this->db->prefix('newbb_posts')
-                  . ' p LEFT JOIN '
-                  . $this->db->prefix('newbb_posts_text')
-                  . ' t ON p.post_id=t.post_id LEFT JOIN '
-                  . $this->db->prefix('newbb_topics')
-                  . ' tp ON tp.topic_id=p.topic_id WHERE p.topic_id='
-                  . $topic_id
-                  . ' AND p.approved ='
-                  . $approved
-                  . ' ORDER BY p.post_time DESC';
-        $result = $this->db->query($sql, $limit, 0);
-        $ret    = [];
-        while (false !== ($myrow = $this->db->fetchArray($result))) {
-            $post = $this->create(false);
-            $post->assignVars($myrow);
-
-            $ret[$myrow['post_id']] = $post;
-            unset($post);
-        }
-
-        return $ret;
-    }
-
-    /**
-     * @param Post $post
-     * @return mixed
-     */
-    public function getPostForPDF(&$post)
-    {
-        return $post->getPostBody(true);
-    }
-
-    /**
-     * @param Post $post
-     * @return mixed
-     */
-    public function getPostForPrint(&$post)
-    {
-        return $post->getPostBody();
-    }
-
-    /**
-     * @param  int|Post|\XoopsObject $post
-     * @param  bool $force
-     * @return bool
-     */
-    public function approve(&$post, $force = false)
-    {
-        if (empty($post)) {
-            return false;
-        }
-        if (is_numeric($post)) {
-            $post = $this->get($post);
-        }
-
-        $wasApproved = $post->getVar('approved');
-        // irmtfan approve post if the approved = 0 (pending) or -1 (deleted)
-        if (empty($force) && $wasApproved > 0) {
-            return true;
-        }
-        $post->setVar('approved', 1);
-        $this->insert($post, true);
-
-        /** @var Newbb\TopicHandler $topicHandler */
-        $topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
-        $topicObject  = $topicHandler->get($post->getVar('topic_id'));
-        if ($topicObject->getVar('topic_last_post_id') < $post->getVar('post_id')) {
-            $topicObject->setVar('topic_last_post_id', $post->getVar('post_id'));
-        }
-        if ($post->isTopic()) {
-            $topicObject->setVar('approved', 1);
-        } else {
-            $topicObject->setVar('topic_replies', $topicObject->getVar('topic_replies') + 1);
-        }
-        $topicHandler->insert($topicObject, true);
-
-        /** @var Newbb\ForumHandler $forumHandler */
-        $forumHandler = Newbb\Helper::getInstance()->getHandler('Forum');
-        $forumObject  = $forumHandler->get($post->getVar('forum_id'));
-        if ($forumObject->getVar('forum_last_post_id') < $post->getVar('post_id')) {
-            $forumObject->setVar('forum_last_post_id', $post->getVar('post_id'));
-        }
-        $forumObject->setVar('forum_posts', $forumObject->getVar('forum_posts') + 1);
-        if ($post->isTopic()) {
-            $forumObject->setVar('forum_topics', $forumObject->getVar('forum_topics') + 1);
-        }
-        $forumHandler->insert($forumObject, true);
-
-        // Update user stats
-        if ($post->getVar('uid') > 0) {
-            /** @var \XoopsMemberHandler $memberHandler */
-            $memberHandler = xoops_getHandler('member');
-            $poster        = $memberHandler->getUser($post->getVar('uid'));
-            if (is_object($poster) && $post->getVar('uid') == $poster->getVar('uid')) {
-                $poster->setVar('posts', $poster->getVar('posts') + 1);
-                $res = $memberHandler->insertUser($poster, true);
-                unset($poster);
-            }
-        }
-
-        // Update forum stats
-        /** @var StatsHandler $statsHandler */
-        $statsHandler = Newbb\Helper::getInstance()->getHandler('Stats');
-        $statsHandler->update($post->getVar('forum_id'), 'post');
-        if ($post->isTopic()) {
-            $statsHandler->update($post->getVar('forum_id'), 'topic');
-        }
-
-        return true;
-    }
-
-    /**
-     * @param \XoopsObject $post
-     * @param  bool        $force
-     * @return bool
-     */
-    public function insert(\XoopsObject $post, $force = true) //insert(&$post, $force = true)
-    {
-        $topicObject = null;
-        // Set the post time
-        // The time should be "publish" time. To be adjusted later
-        if (!$post->getVar('post_time')) {
-            $post->setVar('post_time', time());
-        }
-
-        /** @var Newbb\TopicHandler $topicHandler */
-        $topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
-        // Verify the topic ID
-        if ($topic_id = $post->getVar('topic_id')) {
-            $topicObject = $topicHandler->get($topic_id);
-            // Invalid topic OR the topic is no approved and the post is not top post
-            if (!$topicObject//    || (!$post->isTopic() && $topicObject->getVar("approved") < 1)
-            ) {
-                return false;
-            }
-        }
-        if (empty($topic_id)) {
-            $post->setVar('topic_id', 0);
-            $post->setVar('pid', 0);
-            $post->setNew();
-            $topicObject = $topicHandler->create();
-        }
-        $textHandler    = Newbb\Helper::getInstance()->getHandler('Text');
-        $post_text_vars = ['post_text', 'post_edit', 'dohtml', 'doxcode', 'dosmiley', 'doimage', 'dobr'];
-        if ($post->isNew()) {
-            if (!$topic_id = $post->getVar('topic_id')) {
-                $topicObject->setVar('topic_title', $post->getVar('subject', 'n'));
-                $topicObject->setVar('topic_poster', $post->getVar('uid'));
-                $topicObject->setVar('forum_id', $post->getVar('forum_id'));
-                $topicObject->setVar('topic_time', $post->getVar('post_time'));
-                $topicObject->setVar('poster_name', $post->getVar('poster_name'));
-                $topicObject->setVar('approved', $post->getVar('approved'));
-
-                if (!$topic_id = $topicHandler->insert($topicObject, $force)) {
-                    $post->deleteAttachment();
-                    $post->setErrors('insert topic error');
-
-                    //xoops_error($topicObject->getErrors());
-                    return false;
-                }
-                $post->setVar('topic_id', $topic_id);
-
-                $pid = 0;
-                $post->setVar('pid', 0);
-            } elseif (!$post->getVar('pid')) {
-                $pid = $topicHandler->getTopPostId($topic_id);
-                $post->setVar('pid', $pid);
-            }
-
-            $textObject = $textHandler->create();
-            foreach ($post_text_vars as $key) {
-                $textObject->vars[$key] = $post->vars[$key];
-            }
-            $post->destroyVars($post_text_vars);
-
-            //            if (!$post_id = parent::insert($post, $force)) {
-            //                return false;
-            //            }
-
-            if (!$post_id = parent::insert($post, $force)) {
-                return false;
-            } else {
-                $post->unsetNew();
-            }
-
-            $textObject->setVar('post_id', $post_id);
-            if (!$textHandler->insert($textObject, $force)) {
-                $this->delete($post);
-                $post->setErrors('post text insert error');
-
-                //xoops_error($textObject->getErrors());
-                return false;
-            }
-            if ($post->getVar('approved') > 0) {
-                $this->approve($post, true);
-            }
-            $post->setVar('post_id', $post_id);
-        } else {
-            if ($post->isTopic()) {
-                if ($post->getVar('subject') !== $topicObject->getVar('topic_title')) {
-                    $topicObject->setVar('topic_title', $post->getVar('subject', 'n'));
-                }
-                if ($post->getVar('approved') !== $topicObject->getVar('approved')) {
-                    $topicObject->setVar('approved', $post->getVar('approved'));
-                }
-                $topicObject->setDirty();
-                if (!$result = $topicHandler->insert($topicObject, $force)) {
-                    $post->setErrors('update topic error');
-
-                    //xoops_error($topicObject->getErrors());
-                    return false;
-                }
-            }
-            $textObject = $textHandler->get($post->getVar('post_id'));
-            $textObject->setDirty();
-            foreach ($post_text_vars as $key) {
-                $textObject->vars[$key] = $post->vars[$key];
-            }
-            $post->destroyVars($post_text_vars);
-            if (!$post_id = parent::insert($post, $force)) {
-                //xoops_error($post->getErrors());
-                return false;
-            } else {
-                $post->unsetNew();
-            }
-            if (!$textHandler->insert($textObject, $force)) {
-                $post->setErrors('update post text error');
-
-                //xoops_error($textObject->getErrors());
-                return false;
-            }
-        }
-
-        return $post->getVar('post_id');
-    }
-
-    /**
-     * @param \XoopsObject|Post $post
-     * @param  bool        $isDeleteOne
-     * @param  bool        $force
-     * @return bool
-     */
-    public function delete(\XoopsObject $post, $isDeleteOne = true, $force = false)
-    {
-        if (!is_object($post) || 0 == $post->getVar('post_id')) {
-            return false;
-        }
-
-        if ($isDeleteOne) {
-            if ($post->isTopic()) {
-                $criteria = new \CriteriaCompo(new \Criteria('topic_id', $post->getVar('topic_id')));
-                $criteria->add(new \Criteria('approved', 1));
-                $criteria->add(new \Criteria('pid', 0, '>'));
-                if ($this->getPostCount($criteria) > 0) {
-                    return false;
-                }
-            }
-
-            return $this->myDelete($post, $force);
-        } else {
-            require_once $GLOBALS['xoops']->path('class/xoopstree.php');
-            $mytree = new \XoopsTree($this->db->prefix('newbb_posts'), 'post_id', 'pid');
-            $arr    = $mytree->getAllChild($post->getVar('post_id'));
-            // irmtfan - delete childs in a reverse order
-            for ($i = count($arr) - 1; $i >= 0; $i--) {
-                $childpost = $this->create(false);
-                $childpost->assignVars($arr[$i]);
-                $this->myDelete($childpost, $force);
-                unset($childpost);
-            }
-            $this->myDelete($post, $force);
-        }
-
-        return true;
-    }
-
-    /**
-     * @param  Post|\XoopsObject $post
-     * @param  bool $force
-     * @return bool
-     */
-    public function myDelete(Post $post, $force = false)
-    {
-        global $xoopsModule;
-
-        if (!is_object($post) || 0 == $post->getVar('post_id')) {
-            return false;
-        }
-
-        /* Set active post as deleted */
-        if ($post->getVar('approved') > 0 && empty($force)) {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_posts') . ' SET approved = -1 WHERE post_id = ' . $post->getVar('post_id');
-            if (!$result = $this->db->queryF($sql)) {
-            }
-            /* delete pending post directly */
-        } else {
-            $sql = sprintf('DELETE FROM `%s` WHERE post_id = %u', $this->db->prefix('newbb_posts'), $post->getVar('post_id'));
-            if (!$result = $this->db->queryF($sql)) {
-                $post->setErrors('delete post error: ' . $sql);
-
-                return false;
-            }
-            $post->deleteAttachment();
-
-            $sql = sprintf('DELETE FROM `%s` WHERE post_id = %u', $this->db->prefix('newbb_posts_text'), $post->getVar('post_id'));
-            if (!$result = $this->db->queryF($sql)) {
-                $post->setErrors('Could not remove post text: ' . $sql);
-
-                return false;
-            }
-        }
-
-        if ($post->isTopic()) {
-            $topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
-            /** @var Topic $topicObject */
-            $topicObject = $topicHandler->get($post->getVar('topic_id'));
-            if (is_object($topicObject) && $topicObject->getVar('approved') > 0 && empty($force)) {
-                $topiccount_toupdate = 1;
-                $topicObject->setVar('approved', -1);
-                $topicHandler->insert($topicObject);
-                xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'thread', $post->getVar('topic_id'));
-            } else {
-                if (is_object($topicObject)) {
-                    if ($topicObject->getVar('approved') > 0) {
-                        xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'thread', $post->getVar('topic_id'));
-                    }
-
-                    $poll_id = $topicObject->getVar('poll_id');
-                    // START irmtfan poll_module
-                    $topicObject->deletePoll($poll_id);
-                    // END irmtfan poll_module
-                }
-
-                $sql = sprintf('DELETE FROM `%s` WHERE topic_id = %u', $this->db->prefix('newbb_topics'), $post->getVar('topic_id'));
-                if (!$result = $this->db->queryF($sql)) {
-                    //xoops_error($this->db->error());
-                }
-                $sql = sprintf('DELETE FROM `%s` WHERE topic_id = %u', $this->db->prefix('newbb_votedata'), $post->getVar('topic_id'));
-                if (!$result = $this->db->queryF($sql)) {
-                    //xoops_error($this->db->error());
-                }
-            }
-        } else {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . ' t
+	/**
+	 * @param \XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db)
+	{
+		parent::__construct($db, 'newbb_posts', Post::class, 'post_id', 'subject');
+	}
+
+	/**
+	 * @param  mixed $id
+	 * @param  null  $var
+	 * @return null|\XoopsObject
+	 */
+	public function get($id = null, $var = null) //get($id)
+	{
+		$id   = (int)$id;
+		$post = null;
+		$sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' t ON p.post_id=t.post_id WHERE p.post_id=' . $id;
+		if ($array = $this->db->fetchArray($this->db->query($sql))) {
+			$post = $this->create(false);
+			$post->assignVars($array);
+		}
+
+		return $post;
+	}
+
+	/**
+	 * @param  int             $limit
+	 * @param  int             $start
+	 * @param  \CriteriaElement $criteria
+	 * @param  null            $fields
+	 * @param  bool            $asObject
+	 * @param  int             $topic_id
+	 * @param  int             $approved
+	 * @return array
+	 */
+	//    public function getByLimit($topic_id, $limit, $approved = 1)
+	public function &getByLimit(
+		$limit = 0,
+		$start = 0,
+		\CriteriaElement $criteria = null,
+		$fields = null,
+		$asObject = true,
+		$topic_id = 0,
+		$approved = 1
+	) {
+		$sql    = 'SELECT p.*, t.*, tp.topic_status FROM '
+				  . $this->db->prefix('newbb_posts')
+				  . ' p LEFT JOIN '
+				  . $this->db->prefix('newbb_posts_text')
+				  . ' t ON p.post_id=t.post_id LEFT JOIN '
+				  . $this->db->prefix('newbb_topics')
+				  . ' tp ON tp.topic_id=p.topic_id WHERE p.topic_id='
+				  . $topic_id
+				  . ' AND p.approved ='
+				  . $approved
+				  . ' ORDER BY p.post_time DESC';
+		$result = $this->db->query($sql, $limit, 0);
+		$ret    = [];
+		while (false !== ($myrow = $this->db->fetchArray($result))) {
+			$post = $this->create(false);
+			$post->assignVars($myrow);
+
+			$ret[$myrow['post_id']] = $post;
+			unset($post);
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * @param Post $post
+	 * @return mixed
+	 */
+	public function getPostForPDF(&$post)
+	{
+		return $post->getPostBody(true);
+	}
+
+	/**
+	 * @param Post $post
+	 * @return mixed
+	 */
+	public function getPostForPrint(&$post)
+	{
+		return $post->getPostBody();
+	}
+
+	/**
+	 * @param  int|Post|\XoopsObject $post
+	 * @param  bool $force
+	 * @return bool
+	 */
+	public function approve(&$post, $force = false)
+	{
+		if (empty($post)) {
+			return false;
+		}
+		if (is_numeric($post)) {
+			$post = $this->get($post);
+		}
+
+		$wasApproved = $post->getVar('approved');
+		// irmtfan approve post if the approved = 0 (pending) or -1 (deleted)
+		if (empty($force) && $wasApproved > 0) {
+			return true;
+		}
+		$post->setVar('approved', 1);
+		$this->insert($post, true);
+
+		/** @var Newbb\TopicHandler $topicHandler */
+		$topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
+		$topicObject  = $topicHandler->get($post->getVar('topic_id'));
+		if ($topicObject->getVar('topic_last_post_id') < $post->getVar('post_id')) {
+			$topicObject->setVar('topic_last_post_id', $post->getVar('post_id'));
+		}
+		if ($post->isTopic()) {
+			$topicObject->setVar('approved', 1);
+		} else {
+			$topicObject->setVar('topic_replies', $topicObject->getVar('topic_replies') + 1);
+		}
+		$topicHandler->insert($topicObject, true);
+
+		/** @var Newbb\ForumHandler $forumHandler */
+		$forumHandler = Newbb\Helper::getInstance()->getHandler('Forum');
+		$forumObject  = $forumHandler->get($post->getVar('forum_id'));
+		if ($forumObject->getVar('forum_last_post_id') < $post->getVar('post_id')) {
+			$forumObject->setVar('forum_last_post_id', $post->getVar('post_id'));
+		}
+		$forumObject->setVar('forum_posts', $forumObject->getVar('forum_posts') + 1);
+		if ($post->isTopic()) {
+			$forumObject->setVar('forum_topics', $forumObject->getVar('forum_topics') + 1);
+		}
+		$forumHandler->insert($forumObject, true);
+
+		// Update user stats
+		if ($post->getVar('uid') > 0) {
+			/** @var \XoopsMemberHandler $memberHandler */
+			$memberHandler = xoops_getHandler('member');
+			$poster        = $memberHandler->getUser($post->getVar('uid'));
+			if (is_object($poster) && $post->getVar('uid') == $poster->getVar('uid')) {
+				$poster->setVar('posts', $poster->getVar('posts') + 1);
+				$res = $memberHandler->insertUser($poster, true);
+				unset($poster);
+			}
+		}
+
+		// Update forum stats
+		/** @var StatsHandler $statsHandler */
+		$statsHandler = Newbb\Helper::getInstance()->getHandler('Stats');
+		$statsHandler->update($post->getVar('forum_id'), 'post');
+		if ($post->isTopic()) {
+			$statsHandler->update($post->getVar('forum_id'), 'topic');
+		}
+
+		return true;
+	}
+
+	/**
+	 * @param \XoopsObject $post
+	 * @param  bool        $force
+	 * @return bool
+	 */
+	public function insert(\XoopsObject $post, $force = true) //insert(&$post, $force = true)
+	{
+		$topicObject = null;
+		// Set the post time
+		// The time should be "publish" time. To be adjusted later
+		if (!$post->getVar('post_time')) {
+			$post->setVar('post_time', time());
+		}
+
+		/** @var Newbb\TopicHandler $topicHandler */
+		$topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
+		// Verify the topic ID
+		if ($topic_id = $post->getVar('topic_id')) {
+			$topicObject = $topicHandler->get($topic_id);
+			// Invalid topic OR the topic is no approved and the post is not top post
+			if (!$topicObject//    || (!$post->isTopic() && $topicObject->getVar("approved") < 1)
+			) {
+				return false;
+			}
+		}
+		if (empty($topic_id)) {
+			$post->setVar('topic_id', 0);
+			$post->setVar('pid', 0);
+			$post->setNew();
+			$topicObject = $topicHandler->create();
+		}
+		$textHandler    = Newbb\Helper::getInstance()->getHandler('Text');
+		$post_text_vars = ['post_text', 'post_edit', 'dohtml', 'doxcode', 'dosmiley', 'doimage', 'dobr'];
+		if ($post->isNew()) {
+			if (!$topic_id = $post->getVar('topic_id')) {
+				$topicObject->setVar('topic_title', $post->getVar('subject', 'n'));
+				$topicObject->setVar('topic_poster', $post->getVar('uid'));
+				$topicObject->setVar('forum_id', $post->getVar('forum_id'));
+				$topicObject->setVar('topic_time', $post->getVar('post_time'));
+				$topicObject->setVar('poster_name', $post->getVar('poster_name'));
+				$topicObject->setVar('approved', $post->getVar('approved'));
+
+				if (!$topic_id = $topicHandler->insert($topicObject, $force)) {
+					$post->deleteAttachment();
+					$post->setErrors('insert topic error');
+
+					//xoops_error($topicObject->getErrors());
+					return false;
+				}
+				$post->setVar('topic_id', $topic_id);
+
+				$pid = 0;
+				$post->setVar('pid', 0);
+			} elseif (!$post->getVar('pid')) {
+				$pid = $topicHandler->getTopPostId($topic_id);
+				$post->setVar('pid', $pid);
+			}
+
+			$textObject = $textHandler->create();
+			foreach ($post_text_vars as $key) {
+				$textObject->vars[$key] = $post->vars[$key];
+			}
+			$post->destroyVars($post_text_vars);
+
+			//            if (!$post_id = parent::insert($post, $force)) {
+			//                return false;
+			//            }
+
+			if (!$post_id = parent::insert($post, $force)) {
+				return false;
+			} else {
+				$post->unsetNew();
+			}
+
+			$textObject->setVar('post_id', $post_id);
+			if (!$textHandler->insert($textObject, $force)) {
+				$this->delete($post);
+				$post->setErrors('post text insert error');
+
+				//xoops_error($textObject->getErrors());
+				return false;
+			}
+			if ($post->getVar('approved') > 0) {
+				$this->approve($post, true);
+			}
+			$post->setVar('post_id', $post_id);
+		} else {
+			if ($post->isTopic()) {
+				if ($post->getVar('subject') !== $topicObject->getVar('topic_title')) {
+					$topicObject->setVar('topic_title', $post->getVar('subject', 'n'));
+				}
+				if ($post->getVar('approved') !== $topicObject->getVar('approved')) {
+					$topicObject->setVar('approved', $post->getVar('approved'));
+				}
+				$topicObject->setDirty();
+				if (!$result = $topicHandler->insert($topicObject, $force)) {
+					$post->setErrors('update topic error');
+
+					//xoops_error($topicObject->getErrors());
+					return false;
+				}
+			}
+			$textObject = $textHandler->get($post->getVar('post_id'));
+			$textObject->setDirty();
+			foreach ($post_text_vars as $key) {
+				$textObject->vars[$key] = $post->vars[$key];
+			}
+			$post->destroyVars($post_text_vars);
+			if (!$post_id = parent::insert($post, $force)) {
+				//xoops_error($post->getErrors());
+				return false;
+			} else {
+				$post->unsetNew();
+			}
+			if (!$textHandler->insert($textObject, $force)) {
+				$post->setErrors('update post text error');
+
+				//xoops_error($textObject->getErrors());
+				return false;
+			}
+		}
+
+		return $post->getVar('post_id');
+	}
+
+	/**
+	 * @param \XoopsObject|Post $post
+	 * @param  bool        $isDeleteOne
+	 * @param  bool        $force
+	 * @return bool
+	 */
+	public function delete(\XoopsObject $post, $isDeleteOne = true, $force = false)
+	{
+		if (!is_object($post) || 0 == $post->getVar('post_id')) {
+			return false;
+		}
+
+		if ($isDeleteOne) {
+			if ($post->isTopic()) {
+				$criteria = new \CriteriaCompo(new \Criteria('topic_id', $post->getVar('topic_id')));
+				$criteria->add(new \Criteria('approved', 1));
+				$criteria->add(new \Criteria('pid', 0, '>'));
+				if ($this->getPostCount($criteria) > 0) {
+					return false;
+				}
+			}
+
+			return $this->myDelete($post, $force);
+		} else {
+			require_once $GLOBALS['xoops']->path('class/xoopstree.php');
+			$mytree = new \XoopsTree($this->db->prefix('newbb_posts'), 'post_id', 'pid');
+			$arr    = $mytree->getAllChild($post->getVar('post_id'));
+			// irmtfan - delete childs in a reverse order
+			for ($i = count($arr) - 1; $i >= 0; $i--) {
+				$childpost = $this->create(false);
+				$childpost->assignVars($arr[$i]);
+				$this->myDelete($childpost, $force);
+				unset($childpost);
+			}
+			$this->myDelete($post, $force);
+		}
+
+		return true;
+	}
+
+	/**
+	 * @param  Post|\XoopsObject $post
+	 * @param  bool $force
+	 * @return bool
+	 */
+	public function myDelete(Post $post, $force = false)
+	{
+		global $xoopsModule;
+
+		if (!is_object($post) || 0 == $post->getVar('post_id')) {
+			return false;
+		}
+
+		/* Set active post as deleted */
+		if ($post->getVar('approved') > 0 && empty($force)) {
+			$sql = 'UPDATE ' . $this->db->prefix('newbb_posts') . ' SET approved = -1 WHERE post_id = ' . $post->getVar('post_id');
+			if (!$result = $this->db->queryF($sql)) {
+			}
+			/* delete pending post directly */
+		} else {
+			$sql = sprintf('DELETE FROM `%s` WHERE post_id = %u', $this->db->prefix('newbb_posts'), $post->getVar('post_id'));
+			if (!$result = $this->db->queryF($sql)) {
+				$post->setErrors('delete post error: ' . $sql);
+
+				return false;
+			}
+			$post->deleteAttachment();
+
+			$sql = sprintf('DELETE FROM `%s` WHERE post_id = %u', $this->db->prefix('newbb_posts_text'), $post->getVar('post_id'));
+			if (!$result = $this->db->queryF($sql)) {
+				$post->setErrors('Could not remove post text: ' . $sql);
+
+				return false;
+			}
+		}
+
+		if ($post->isTopic()) {
+			$topicHandler = Newbb\Helper::getInstance()->getHandler('Topic');
+			/** @var Topic $topicObject */
+			$topicObject = $topicHandler->get($post->getVar('topic_id'));
+			if (is_object($topicObject) && $topicObject->getVar('approved') > 0 && empty($force)) {
+				$topiccount_toupdate = 1;
+				$topicObject->setVar('approved', -1);
+				$topicHandler->insert($topicObject);
+				xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'thread', $post->getVar('topic_id'));
+			} else {
+				if (is_object($topicObject)) {
+					if ($topicObject->getVar('approved') > 0) {
+						xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'thread', $post->getVar('topic_id'));
+					}
+
+					$poll_id = $topicObject->getVar('poll_id');
+					// START irmtfan poll_module
+					$topicObject->deletePoll($poll_id);
+					// END irmtfan poll_module
+				}
+
+				$sql = sprintf('DELETE FROM `%s` WHERE topic_id = %u', $this->db->prefix('newbb_topics'), $post->getVar('topic_id'));
+				if (!$result = $this->db->queryF($sql)) {
+					//xoops_error($this->db->error());
+				}
+				$sql = sprintf('DELETE FROM `%s` WHERE topic_id = %u', $this->db->prefix('newbb_votedata'), $post->getVar('topic_id'));
+				if (!$result = $this->db->queryF($sql)) {
+					//xoops_error($this->db->error());
+				}
+			}
+		} else {
+			$sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . ' t
                             LEFT JOIN ' . $this->db->prefix('newbb_posts') . ' p ON p.topic_id = t.topic_id
                             SET t.topic_last_post_id = p.post_id
                             WHERE t.topic_last_post_id = ' . $post->getVar('post_id') . '
                                     AND p.post_id = (SELECT MAX(post_id) FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id=t.topic_id)';
-            if (!$result = $this->db->queryF($sql)) {
-            }
-        }
-
-        $postcount_toupdate = $post->getVar('approved');
-
-        if ($postcount_toupdate > 0) {
-
-            // Update user stats
-            if ($post->getVar('uid') > 0) {
-                /** @var \XoopsMemberHandler $memberHandler */
-                $memberHandler = xoops_getHandler('member');
-                $poster        = $memberHandler->getUser($post->getVar('uid'));
-                if (is_object($poster) && $post->getVar('uid') == $poster->getVar('uid')) {
-                    $poster->setVar('posts', $poster->getVar('posts') - 1);
-                    $res = $memberHandler->insertUser($poster, true);
-                    unset($poster);
-                }
-            }
-            // irmtfan - just update the pid for approved posts when the post is not topic (pid=0)
-            if (!$post->isTopic()) {
-                $sql = 'UPDATE ' . $this->db->prefix('newbb_posts') . ' SET pid = ' . $post->getVar('pid') . ' WHERE approved=1 AND pid=' . $post->getVar('post_id');
-                if (!$result = $this->db->queryF($sql)) {
-                    //xoops_error($this->db->error());
-                }
-            }
-        }
-
-        return true;
-    }
-
-    // START irmtfan enhance getPostCount when there is join (read_mode = 2)
-
-    /**
-     * @param  null $criteria
-     * @param  null $join
-     * @return int|null
-     */
-    public function getPostCount($criteria = null, $join = null)
-    {
-        // if not join get the count from XOOPS/class/model/stats as before
-        if (empty($join)) {
-            return parent::getCount($criteria);
-        }
-
-        $sql = 'SELECT COUNT(*) as count' . ' FROM ' . $this->db->prefix('newbb_posts') . ' AS p' . ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' AS t ON t.post_id = p.post_id';
-        // LEFT JOIN
-        $sql .= $join;
-        // WHERE
-        if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
-            $sql .= ' ' . $criteria->renderWhere();
-        }
-        if (!$result = $this->db->query($sql)) {
-            //xoops_error($this->db->error().'<br>'.$sql);
-            return null;
-        }
-        $myrow = $this->db->fetchArray($result);
-        $count = $myrow['count'];
-
-        return $count;
-    }
-    // END irmtfan enhance getPostCount when there is join (read_mode = 2)
-    /*
+			if (!$result = $this->db->queryF($sql)) {
+			}
+		}
+
+		$postcount_toupdate = $post->getVar('approved');
+
+		if ($postcount_toupdate > 0) {
+
+			// Update user stats
+			if ($post->getVar('uid') > 0) {
+				/** @var \XoopsMemberHandler $memberHandler */
+				$memberHandler = xoops_getHandler('member');
+				$poster        = $memberHandler->getUser($post->getVar('uid'));
+				if (is_object($poster) && $post->getVar('uid') == $poster->getVar('uid')) {
+					$poster->setVar('posts', $poster->getVar('posts') - 1);
+					$res = $memberHandler->insertUser($poster, true);
+					unset($poster);
+				}
+			}
+			// irmtfan - just update the pid for approved posts when the post is not topic (pid=0)
+			if (!$post->isTopic()) {
+				$sql = 'UPDATE ' . $this->db->prefix('newbb_posts') . ' SET pid = ' . $post->getVar('pid') . ' WHERE approved=1 AND pid=' . $post->getVar('post_id');
+				if (!$result = $this->db->queryF($sql)) {
+					//xoops_error($this->db->error());
+				}
+			}
+		}
+
+		return true;
+	}
+
+	// START irmtfan enhance getPostCount when there is join (read_mode = 2)
+
+	/**
+	 * @param  null $criteria
+	 * @param  null $join
+	 * @return int|null
+	 */
+	public function getPostCount($criteria = null, $join = null)
+	{
+		// if not join get the count from XOOPS/class/model/stats as before
+		if (empty($join)) {
+			return parent::getCount($criteria);
+		}
+
+		$sql = 'SELECT COUNT(*) as count' . ' FROM ' . $this->db->prefix('newbb_posts') . ' AS p' . ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' AS t ON t.post_id = p.post_id';
+		// LEFT JOIN
+		$sql .= $join;
+		// WHERE
+		if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
+			$sql .= ' ' . $criteria->renderWhere();
+		}
+		if (!$result = $this->db->query($sql)) {
+			//xoops_error($this->db->error().'<br>'.$sql);
+			return null;
+		}
+		$myrow = $this->db->fetchArray($result);
+		$count = $myrow['count'];
+
+		return $count;
+	}
+	// END irmtfan enhance getPostCount when there is join (read_mode = 2)
+	/*
      * TODO: combining viewtopic.php
      */
-    /**
-     * @param  null $criteria
-     * @param  int  $limit
-     * @param  int  $start
-     * @param  null $join
-     * @return array
-     */
-    public function getPostsByLimit($criteria = null, $limit = 1, $start = 0, $join = null)
-    {
-        $ret = [];
-        $sql = 'SELECT p.*, t.* ' . ' FROM ' . $this->db->prefix('newbb_posts') . ' AS p' . ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' AS t ON t.post_id = p.post_id';
-        if (!empty($join)) {
-            $sql .= $join;
-        }
-        if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
-            $sql .= ' ' . $criteria->renderWhere();
-            if ('' !== $criteria->getSort()) {
-                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
-            }
-        }
-        $result = $this->db->query($sql, (int)$limit, (int)$start);
-        if (!$result) {
-            //xoops_error($this->db->error());
-            return $ret;
-        }
-        while (false !== ($myrow = $this->db->fetchArray($result))) {
-            $post = $this->create(false);
-            $post->assignVars($myrow);
-            $ret[$myrow['post_id']] = $post;
-            unset($post);
-        }
-
-        return $ret;
-    }
-
-    /**
-     * @return bool
-     */
-    public function synchronization()
-    {
-        //$this->cleanOrphan();
-        return true;
-    }
-
-    /**
-     * clean orphan items from database
-     *
-     * @param  string $table_link
-     * @param  string $field_link
-     * @param  string $field_object
-     * @return bool   true on success
-     */
-    public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
-    {
-        $this->deleteAll(new \Criteria('post_time', 0), true, true);
-        parent::cleanOrphan($this->db->prefix('newbb_topics'), 'topic_id');
-        parent::cleanOrphan($this->db->prefix('newbb_posts_text'), 'post_id');
-
-        $sql = 'DELETE FROM ' . $this->db->prefix('newbb_posts_text') . ' WHERE (post_id NOT IN ( SELECT DISTINCT post_id FROM ' . $this->table . ') )';
-        if (!$result = $this->db->queryF($sql)) {
-            //xoops_error($this->db->error());
-            return false;
-        }
-
-        return true;
-    }
-
-    /**
-     * clean expired objects from database
-     *
-     * @param  int $expire time limit for expiration
-     * @return bool true on success
-     */
-    public function cleanExpires($expire = 0)
-    {
-        // irmtfan if 0 no cleanup look include/plugin.php
-        if (!func_num_args()) {
-            $newbbConfig = newbbLoadConfig();
-            $expire      = isset($newbbConfig['pending_expire']) ? (int)$newbbConfig['pending_expire'] : 7;
-            $expire      = $expire * 24 * 3600; // days to seconds
-        }
-        if (empty($expire)) {
-            return false;
-        }
-        $crit_expire = new \CriteriaCompo(new \Criteria('approved', 0, '<='));
-        //if (!empty($expire)) {
-        $crit_expire->add(new \Criteria('post_time', time() - (int)$expire, '<'));
-
-        //}
-        return $this->deleteAll($crit_expire, true/*, true*/);
-    }
+	/**
+	 * @param  null $criteria
+	 * @param  int  $limit
+	 * @param  int  $start
+	 * @param  null $join
+	 * @return array
+	 */
+	public function getPostsByLimit($criteria = null, $limit = 1, $start = 0, $join = null)
+	{
+		$ret = [];
+		$sql = 'SELECT p.*, t.* ' . ' FROM ' . $this->db->prefix('newbb_posts') . ' AS p' . ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' AS t ON t.post_id = p.post_id';
+		if (!empty($join)) {
+			$sql .= $join;
+		}
+		if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
+			$sql .= ' ' . $criteria->renderWhere();
+			if ('' !== $criteria->getSort()) {
+				$sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
+			}
+		}
+		$result = $this->db->query($sql, (int)$limit, (int)$start);
+		if (!$result) {
+			//xoops_error($this->db->error());
+			return $ret;
+		}
+		while (false !== ($myrow = $this->db->fetchArray($result))) {
+			$post = $this->create(false);
+			$post->assignVars($myrow);
+			$ret[$myrow['post_id']] = $post;
+			unset($post);
+		}
+
+		return $ret;
+	}
+
+	/**
+	 * @return bool
+	 */
+	public function synchronization()
+	{
+		//$this->cleanOrphan();
+		return true;
+	}
+
+	/**
+	 * clean orphan items from database
+	 *
+	 * @param  string $table_link
+	 * @param  string $field_link
+	 * @param  string $field_object
+	 * @return bool   true on success
+	 */
+	public function cleanOrphan($table_link = '', $field_link = '', $field_object = '') //cleanOrphan()
+	{
+		$this->deleteAll(new \Criteria('post_time', 0), true, true);
+		parent::cleanOrphan($this->db->prefix('newbb_topics'), 'topic_id');
+		parent::cleanOrphan($this->db->prefix('newbb_posts_text'), 'post_id');
+
+		$sql = 'DELETE FROM ' . $this->db->prefix('newbb_posts_text') . ' WHERE (post_id NOT IN ( SELECT DISTINCT post_id FROM ' . $this->table . ') )';
+		if (!$result = $this->db->queryF($sql)) {
+			//xoops_error($this->db->error());
+			return false;
+		}
+
+		return true;
+	}
+
+	/**
+	 * clean expired objects from database
+	 *
+	 * @param  int $expire time limit for expiration
+	 * @return bool true on success
+	 */
+	public function cleanExpires($expire = 0)
+	{
+		// irmtfan if 0 no cleanup look include/plugin.php
+		if (!func_num_args()) {
+			$newbbConfig = newbbLoadConfig();
+			$expire      = isset($newbbConfig['pending_expire']) ? (int)$newbbConfig['pending_expire'] : 7;
+			$expire      = $expire * 24 * 3600; // days to seconds
+		}
+		if (empty($expire)) {
+			return false;
+		}
+		$crit_expire = new \CriteriaCompo(new \Criteria('approved', 0, '<='));
+		//if (!empty($expire)) {
+		$crit_expire->add(new \Criteria('post_time', time() - (int)$expire, '<'));
+
+		//}
+		return $this->deleteAll($crit_expire, true/*, true*/);
+	}
 }

Spacing +16 added lines, -16 removed lines

@@ -58,7 +58,7 @@ 
     {
         $id   = (int)$id;
         $post = null;
-        $sql  = 'SELECT p.*, t.* FROM ' . $this->db->prefix('newbb_posts') . ' p LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' t ON p.post_id=t.post_id WHERE p.post_id=' . $id;
+        $sql  = 'SELECT p.*, t.* FROM '.$this->db->prefix('newbb_posts').' p LEFT JOIN '.$this->db->prefix('newbb_posts_text').' t ON p.post_id=t.post_id WHERE p.post_id='.$id;
         if ($array = $this->db->fetchArray($this->db->query($sql))) {
             $post = $this->create(false);
             $post->assignVars($array);
@@ -87,7 +87,7 @@ 
         $topic_id = 0,
         $approved = 1
     ) {
-        $sql    = 'SELECT p.*, t.*, tp.topic_status FROM '
+        $sql = 'SELECT p.*, t.*, tp.topic_status FROM '
                   . $this->db->prefix('newbb_posts')
                   . ' p LEFT JOIN '
                   . $this->db->prefix('newbb_posts_text')
@@ -379,14 +379,14 @@ 
 
         /* Set active post as deleted */
         if ($post->getVar('approved') > 0 && empty($force)) {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_posts') . ' SET approved = -1 WHERE post_id = ' . $post->getVar('post_id');
+            $sql = 'UPDATE '.$this->db->prefix('newbb_posts').' SET approved = -1 WHERE post_id = '.$post->getVar('post_id');
             if (!$result = $this->db->queryF($sql)) {
             }
             /* delete pending post directly */
         } else {
             $sql = sprintf('DELETE FROM `%s` WHERE post_id = %u', $this->db->prefix('newbb_posts'), $post->getVar('post_id'));
             if (!$result = $this->db->queryF($sql)) {
-                $post->setErrors('delete post error: ' . $sql);
+                $post->setErrors('delete post error: '.$sql);
 
                 return false;
             }
@@ -394,7 +394,7 @@ 
 
             $sql = sprintf('DELETE FROM `%s` WHERE post_id = %u', $this->db->prefix('newbb_posts_text'), $post->getVar('post_id'));
             if (!$result = $this->db->queryF($sql)) {
-                $post->setErrors('Could not remove post text: ' . $sql);
+                $post->setErrors('Could not remove post text: '.$sql);
 
                 return false;
             }
@@ -431,11 +431,11 @@ 
                 }
             }
         } else {
-            $sql = 'UPDATE ' . $this->db->prefix('newbb_topics') . ' t
-                            LEFT JOIN ' . $this->db->prefix('newbb_posts') . ' p ON p.topic_id = t.topic_id
+            $sql = 'UPDATE '.$this->db->prefix('newbb_topics').' t
+                            LEFT JOIN ' . $this->db->prefix('newbb_posts').' p ON p.topic_id = t.topic_id
                             SET t.topic_last_post_id = p.post_id
-                            WHERE t.topic_last_post_id = ' . $post->getVar('post_id') . '
-                                    AND p.post_id = (SELECT MAX(post_id) FROM ' . $this->db->prefix('newbb_posts') . ' WHERE topic_id=t.topic_id)';
+                            WHERE t.topic_last_post_id = ' . $post->getVar('post_id').'
+                                    AND p.post_id = (SELECT MAX(post_id) FROM ' . $this->db->prefix('newbb_posts').' WHERE topic_id=t.topic_id)';
             if (!$result = $this->db->queryF($sql)) {
             }
         }
@@ -457,7 +457,7 @@ 
             }
             // irmtfan - just update the pid for approved posts when the post is not topic (pid=0)
             if (!$post->isTopic()) {
-                $sql = 'UPDATE ' . $this->db->prefix('newbb_posts') . ' SET pid = ' . $post->getVar('pid') . ' WHERE approved=1 AND pid=' . $post->getVar('post_id');
+                $sql = 'UPDATE '.$this->db->prefix('newbb_posts').' SET pid = '.$post->getVar('pid').' WHERE approved=1 AND pid='.$post->getVar('post_id');
                 if (!$result = $this->db->queryF($sql)) {
                     //xoops_error($this->db->error());
                 }
@@ -481,12 +481,12 @@ 
             return parent::getCount($criteria);
         }
 
-        $sql = 'SELECT COUNT(*) as count' . ' FROM ' . $this->db->prefix('newbb_posts') . ' AS p' . ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' AS t ON t.post_id = p.post_id';
+        $sql = 'SELECT COUNT(*) as count'.' FROM '.$this->db->prefix('newbb_posts').' AS p'.' LEFT JOIN '.$this->db->prefix('newbb_posts_text').' AS t ON t.post_id = p.post_id';
         // LEFT JOIN
         $sql .= $join;
         // WHERE
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
         }
         if (!$result = $this->db->query($sql)) {
             //xoops_error($this->db->error().'<br>'.$sql);
@@ -511,14 +511,14 @@ 
     public function getPostsByLimit($criteria = null, $limit = 1, $start = 0, $join = null)
     {
         $ret = [];
-        $sql = 'SELECT p.*, t.* ' . ' FROM ' . $this->db->prefix('newbb_posts') . ' AS p' . ' LEFT JOIN ' . $this->db->prefix('newbb_posts_text') . ' AS t ON t.post_id = p.post_id';
+        $sql = 'SELECT p.*, t.* '.' FROM '.$this->db->prefix('newbb_posts').' AS p'.' LEFT JOIN '.$this->db->prefix('newbb_posts_text').' AS t ON t.post_id = p.post_id';
         if (!empty($join)) {
             $sql .= $join;
         }
         if (isset($criteria) && is_subclass_of($criteria, 'CriteriaElement')) {
-            $sql .= ' ' . $criteria->renderWhere();
+            $sql .= ' '.$criteria->renderWhere();
             if ('' !== $criteria->getSort()) {
-                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
+                $sql .= ' ORDER BY '.$criteria->getSort().' '.$criteria->getOrder();
             }
         }
         $result = $this->db->query($sql, (int)$limit, (int)$start);
@@ -559,7 +559,7 @@ 
         parent::cleanOrphan($this->db->prefix('newbb_topics'), 'topic_id');
         parent::cleanOrphan($this->db->prefix('newbb_posts_text'), 'post_id');
 
-        $sql = 'DELETE FROM ' . $this->db->prefix('newbb_posts_text') . ' WHERE (post_id NOT IN ( SELECT DISTINCT post_id FROM ' . $this->table . ') )';
+        $sql = 'DELETE FROM '.$this->db->prefix('newbb_posts_text').' WHERE (post_id NOT IN ( SELECT DISTINCT post_id FROM '.$this->table.') )';
         if (!$result = $this->db->queryF($sql)) {
             //xoops_error($this->db->error());
             return false;

class/PermissionForumHandler.php

Indentation +212 added lines, -212 removed lines

@@ -18,7 +18,7 @@ 
 //define("NEWBB_HANDLER_PERMISSION_FORUM", 1);
 
 if (defined('FORUM_PERM_ITEMS') && class_exists('ForumPermissionHandler')) {
-    exit('access denied');
+	exit('access denied');
 }
 // irmtfan add pdf and print permissions.
 define('FORUM_PERM_ITEMS', 'access,view,post,reply,edit,delete,addpoll,vote,attach,noapprove,type,html,signature,pdf,print');
@@ -28,246 +28,246 @@ 
  */
 class PermissionForumHandler extends PermissionHandler
 {
-    protected $templateFilename;
+	protected $templateFilename;
 
-    /**
-     * @param \XoopsDatabase $db
-     */
-    public function __construct(\XoopsDatabase $db)
-    {
-        //        $this->PermissionHandler($db);
-        parent::__construct($db);
-        $this->templateFilename = XOOPS_VAR_PATH . '/configs/newbb_permission_template.php';
-    }
+	/**
+	 * @param \XoopsDatabase $db
+	 */
+	public function __construct(\XoopsDatabase $db)
+	{
+		//        $this->PermissionHandler($db);
+		parent::__construct($db);
+		$this->templateFilename = XOOPS_VAR_PATH . '/configs/newbb_permission_template.php';
+	}
 
-    /**
-     * @param  bool $fullname
-     * @return array
-     */
-    public function getValidPerms($fullname = false)
-    {
-        static $validPerms = [];
-        if (isset($validPerms[(int)$fullname])) {
-            return $validPerms[(int)$fullname];
-        }
-        $items = array_filter(array_map('trim', explode(',', FORUM_PERM_ITEMS)));
-        if (!empty($fullname)) {
-            foreach (array_keys($items) as $key) {
-                $items[$key] = 'forum_' . $items[$key];
-            }
-        }
-        $validPerms[(int)$fullname] = $items;
+	/**
+	 * @param  bool $fullname
+	 * @return array
+	 */
+	public function getValidPerms($fullname = false)
+	{
+		static $validPerms = [];
+		if (isset($validPerms[(int)$fullname])) {
+			return $validPerms[(int)$fullname];
+		}
+		$items = array_filter(array_map('trim', explode(',', FORUM_PERM_ITEMS)));
+		if (!empty($fullname)) {
+			foreach (array_keys($items) as $key) {
+				$items[$key] = 'forum_' . $items[$key];
+			}
+		}
+		$validPerms[(int)$fullname] = $items;
 
-        return $items;
-    }
+		return $items;
+	}
 
-    /**
-     * @param        $mid
-     * @param  int   $id
-     * @return array
-     */
-    public function getValidItems($mid, $id = 0)
-    {
-        static $suspension = [];
-        $full_items = [];
-        if (empty($mid)) {
-            return $full_items;
-        }
+	/**
+	 * @param        $mid
+	 * @param  int   $id
+	 * @return array
+	 */
+	public function getValidItems($mid, $id = 0)
+	{
+		static $suspension = [];
+		$full_items = [];
+		if (empty($mid)) {
+			return $full_items;
+		}
 
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
-        $uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
-        $ip  = \Xmf\IPAddress::fromRequest()->asReadable();
-        if (!empty($GLOBALS['xoopsModuleConfig']['enable_usermoderate']) && !isset($suspension[$uid][$id])
-            && !newbbIsAdmin($id)) {
-            /** @var Newbb\ModerateHandler $moderateHandler */
-            $moderateHandler = Newbb\Helper::getInstance()->getHandler('Moderate');
-            if (!$moderateHandler->verifyUser($uid, '', $id)) {
-                $suspension[$uid][$ip][$id] = 1;
-            } else {
-                $suspension[$uid][$ip][$id] = 0;
-            }
-        }
+		require_once  dirname(__DIR__) . '/include/functions.user.php';
+		$uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
+		$ip  = \Xmf\IPAddress::fromRequest()->asReadable();
+		if (!empty($GLOBALS['xoopsModuleConfig']['enable_usermoderate']) && !isset($suspension[$uid][$id])
+			&& !newbbIsAdmin($id)) {
+			/** @var Newbb\ModerateHandler $moderateHandler */
+			$moderateHandler = Newbb\Helper::getInstance()->getHandler('Moderate');
+			if (!$moderateHandler->verifyUser($uid, '', $id)) {
+				$suspension[$uid][$ip][$id] = 1;
+			} else {
+				$suspension[$uid][$ip][$id] = 0;
+			}
+		}
 
-        $items = $this->getValidPerms();
-        foreach ($items as $item) {
-            /* skip access for suspended users */
-            //if ( !empty($suspension[$uid][$ip][$id]) && in_array($item, array("post", "reply", "edit", "delete", "addpoll", "vote", "attach", "noapprove", "type")) ) continue;
-            if (!empty($suspension[$uid][$ip][$id])) {
-                continue;
-            }
-            $full_items[] = "'forum_{$item}'";
-        }
+		$items = $this->getValidPerms();
+		foreach ($items as $item) {
+			/* skip access for suspended users */
+			//if ( !empty($suspension[$uid][$ip][$id]) && in_array($item, array("post", "reply", "edit", "delete", "addpoll", "vote", "attach", "noapprove", "type")) ) continue;
+			if (!empty($suspension[$uid][$ip][$id])) {
+				continue;
+			}
+			$full_items[] = "'forum_{$item}'";
+		}
 
-        return $full_items;
-    }
+		return $full_items;
+	}
 
-    /*
+	/*
     * Returns permissions for a certain type
     *
     * @param int $id id of the item (forum, topic or possibly post) to get permissions for
     *
     * @return array
     */
-    /**
-     * @param  int|array $id
-     * @return bool|array
-     */
-    public function getPermissions($id = 0)
-    {
-        $permissions = [];
-        if (is_object($GLOBALS['xoopsModule']) && 'newbb' === $GLOBALS['xoopsModule']->getVar('dirname')) {
-            $modid = $GLOBALS['xoopsModule']->getVar('mid');
-        } else {
-            /** @var \XoopsModuleHandler $moduleHandler */
-            $moduleHandler = xoops_getHandler('module');
-            $xoopsNewBB    = $moduleHandler->getByDirname('newbb');
-            $modid         = $xoopsNewBB->getVar('mid');
-            unset($xoopsNewBB);
-        }
+	/**
+	 * @param  int|array $id
+	 * @return bool|array
+	 */
+	public function getPermissions($id = 0)
+	{
+		$permissions = [];
+		if (is_object($GLOBALS['xoopsModule']) && 'newbb' === $GLOBALS['xoopsModule']->getVar('dirname')) {
+			$modid = $GLOBALS['xoopsModule']->getVar('mid');
+		} else {
+			/** @var \XoopsModuleHandler $moduleHandler */
+			$moduleHandler = xoops_getHandler('module');
+			$xoopsNewBB    = $moduleHandler->getByDirname('newbb');
+			$modid         = $xoopsNewBB->getVar('mid');
+			unset($xoopsNewBB);
+		}
 
-        // Get user's groups
-        $groups = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : [XOOPS_GROUP_ANONYMOUS];
-        // Create string of groupid's separated by commas, inserted in a set of brackets
-        if (count($groups) < 1) {
-            return false;
-        }
-        // Create criteria for getting only the permissions regarding this module and this user's groups
-        $criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
-        $criteria->add(new \Criteria('gperm_groupid', '(' . implode(',', $groups) . ')', 'IN'));
-        if ($id) {
-            if (is_array($id)) {
-                $criteria->add(new \Criteria('gperm_itemid', '(' . implode(',', $id) . ')', 'IN'));
-            } else {
-                $criteria->add(new \Criteria('gperm_itemid', (int)$id));
-            }
-        }
-        $gperm_names = implode(', ', $this->getValidItems($modid, $id));
+		// Get user's groups
+		$groups = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : [XOOPS_GROUP_ANONYMOUS];
+		// Create string of groupid's separated by commas, inserted in a set of brackets
+		if (count($groups) < 1) {
+			return false;
+		}
+		// Create criteria for getting only the permissions regarding this module and this user's groups
+		$criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
+		$criteria->add(new \Criteria('gperm_groupid', '(' . implode(',', $groups) . ')', 'IN'));
+		if ($id) {
+			if (is_array($id)) {
+				$criteria->add(new \Criteria('gperm_itemid', '(' . implode(',', $id) . ')', 'IN'));
+			} else {
+				$criteria->add(new \Criteria('gperm_itemid', (int)$id));
+			}
+		}
+		$gperm_names = implode(', ', $this->getValidItems($modid, $id));
 
-        // Add criteria for gpermnames
-        $criteria->add(new \Criteria('gperm_name', '(' . $gperm_names . ')', 'IN'));
-        // Get all permission objects in this module and for this user's groups
-        $userpermissions = $this->getObjects($criteria, true);
+		// Add criteria for gpermnames
+		$criteria->add(new \Criteria('gperm_name', '(' . $gperm_names . ')', 'IN'));
+		// Get all permission objects in this module and for this user's groups
+		$userpermissions = $this->getObjects($criteria, true);
 
-        // Set the granted permissions to 1
-        foreach ($userpermissions as $gperm_id => $gperm) {
-            $permissions[$gperm->getVar('gperm_itemid')][$gperm->getVar('gperm_name')] = 1;
-        }
-        $userpermissions = null;
-        unset($userpermissions);
+		// Set the granted permissions to 1
+		foreach ($userpermissions as $gperm_id => $gperm) {
+			$permissions[$gperm->getVar('gperm_itemid')][$gperm->getVar('gperm_name')] = 1;
+		}
+		$userpermissions = null;
+		unset($userpermissions);
 
-        // Return the permission array
-        return $permissions;
-    }
+		// Return the permission array
+		return $permissions;
+	}
 
-    /**
-     * @param  Forum|int $forum
-     * @param  bool      $topic_locked
-     * @param  bool      $isAdmin
-     * @return array
-     */
-    public function getPermissionTable($forum = 0, $topic_locked = false, $isAdmin = false)
-    {
-        $perm = [];
+	/**
+	 * @param  Forum|int $forum
+	 * @param  bool      $topic_locked
+	 * @param  bool      $isAdmin
+	 * @return array
+	 */
+	public function getPermissionTable($forum = 0, $topic_locked = false, $isAdmin = false)
+	{
+		$perm = [];
 
-        $forumId = $forum;
-        if (is_object($forum)) {
-            $forumId = $forum->getVar('forum_id');
-        }
+		$forumId = $forum;
+		if (is_object($forum)) {
+			$forumId = $forum->getVar('forum_id');
+		}
 
-        $permission_set = $this->getPermissions($forumId);
+		$permission_set = $this->getPermissions($forumId);
 
-        $permItems = $this->getValidPerms();
-        foreach ($permItems as $item) {
-            if ('access' === $item) {
-                continue;
-            }
-            if ($isAdmin
-                || (isset($permission_set[$forumId]['forum_' . $item])
-                    && (!$topic_locked
-                        || 'view' === $item))) {
-                $perm[] = constant('_MD_NEWBB_CAN_' . strtoupper($item));
-            } else {
-                $perm[] = constant('_MD_NEWBB_CANNOT_' . strtoupper($item));
-            }
-        }
+		$permItems = $this->getValidPerms();
+		foreach ($permItems as $item) {
+			if ('access' === $item) {
+				continue;
+			}
+			if ($isAdmin
+				|| (isset($permission_set[$forumId]['forum_' . $item])
+					&& (!$topic_locked
+						|| 'view' === $item))) {
+				$perm[] = constant('_MD_NEWBB_CAN_' . strtoupper($item));
+			} else {
+				$perm[] = constant('_MD_NEWBB_CANNOT_' . strtoupper($item));
+			}
+		}
 
-        return $perm;
-    }
+		return $perm;
+	}
 
-    /**
-     * @param $forum_id
-     * @return bool
-     */
-    public function deleteByForum($forum_id)
-    {
-        $forum_id = (int)$forum_id;
-        if (empty($forum_id)) {
-            return false;
-        }
-        $grouppermHandler = xoops_getHandler('groupperm');
-        $criteria     = new \CriteriaCompo(new \Criteria('gperm_modid', $GLOBALS['xoopsModule']->getVar('mid')));
-        $items        = $this->getValidPerms(true);
-        $criteria->add(new \Criteria('gperm_name', "('" . implode("', '", $items) . "')", 'IN'));
-        $criteria->add(new \Criteria('gperm_itemid', $forum_id));
+	/**
+	 * @param $forum_id
+	 * @return bool
+	 */
+	public function deleteByForum($forum_id)
+	{
+		$forum_id = (int)$forum_id;
+		if (empty($forum_id)) {
+			return false;
+		}
+		$grouppermHandler = xoops_getHandler('groupperm');
+		$criteria     = new \CriteriaCompo(new \Criteria('gperm_modid', $GLOBALS['xoopsModule']->getVar('mid')));
+		$items        = $this->getValidPerms(true);
+		$criteria->add(new \Criteria('gperm_name', "('" . implode("', '", $items) . "')", 'IN'));
+		$criteria->add(new \Criteria('gperm_itemid', $forum_id));
 
-        return $grouppermHandler->deleteAll($criteria);
-    }
+		return $grouppermHandler->deleteAll($criteria);
+	}
 
-    /**
-     * @param       $forum
-     * @param  int  $mid
-     * @return bool
-     */
-    public function applyTemplate($forum, $mid = 0)
-    {
-        if (!$perm_template = $this->getTemplate()) {
-            return false;
-        }
+	/**
+	 * @param       $forum
+	 * @param  int  $mid
+	 * @return bool
+	 */
+	public function applyTemplate($forum, $mid = 0)
+	{
+		if (!$perm_template = $this->getTemplate()) {
+			return false;
+		}
 
-        if (empty($mid)) {
-            if (is_object($GLOBALS['xoopsModule']) && 'newbb' === $GLOBALS['xoopsModule']->getVar('dirname')) {
-                $mid = $GLOBALS['xoopsModule']->getVar('mid');
-            } else {
-                /** @var \XoopsModuleHandler $moduleHandler */
-                $moduleHandler = xoops_getHandler('module');
-                $newbb         = $moduleHandler->getByDirname('newbb');
-                $mid           = $newbb->getVar('mid');
-                unset($newbb);
-            }
-        }
+		if (empty($mid)) {
+			if (is_object($GLOBALS['xoopsModule']) && 'newbb' === $GLOBALS['xoopsModule']->getVar('dirname')) {
+				$mid = $GLOBALS['xoopsModule']->getVar('mid');
+			} else {
+				/** @var \XoopsModuleHandler $moduleHandler */
+				$moduleHandler = xoops_getHandler('module');
+				$newbb         = $moduleHandler->getByDirname('newbb');
+				$mid           = $newbb->getVar('mid');
+				unset($newbb);
+			}
+		}
 
-        /** @var \XoopsMemberHandler $memberHandler */
-        $memberHandler = xoops_getHandler('member');
-        $glist         = $memberHandler->getGroupList();
-        $perms         = $this->getValidPerms(true);
-        foreach (array_keys($glist) as $group) {
-            foreach ($perms as $perm) {
-                if (!empty($perm_template[$group][$perm])) {
-                    $this->validateRight($perm, $forum, $group, $mid);
-                } else {
-                    $this->deleteRight($perm, $forum, $group, $mid);
-                }
-            }
-        }
+		/** @var \XoopsMemberHandler $memberHandler */
+		$memberHandler = xoops_getHandler('member');
+		$glist         = $memberHandler->getGroupList();
+		$perms         = $this->getValidPerms(true);
+		foreach (array_keys($glist) as $group) {
+			foreach ($perms as $perm) {
+				if (!empty($perm_template[$group][$perm])) {
+					$this->validateRight($perm, $forum, $group, $mid);
+				} else {
+					$this->deleteRight($perm, $forum, $group, $mid);
+				}
+			}
+		}
 
-        return true;
-    }
+		return true;
+	}
 
-    /**
-     * @return array|false
-     */
-    public function getTemplate()
-    {
-        $perms = \Xmf\Yaml::readWrapped($this->templateFilename);
-        return $perms;
-    }
+	/**
+	 * @return array|false
+	 */
+	public function getTemplate()
+	{
+		$perms = \Xmf\Yaml::readWrapped($this->templateFilename);
+		return $perms;
+	}
 
-    /**
-     * @param array $perms
-     * @return bool
-     */
-    public function setTemplate($perms)
-    {
-        return \Xmf\Yaml::saveWrapped($perms, $this->templateFilename);
-    }
+	/**
+	 * @param array $perms
+	 * @return bool
+	 */
+	public function setTemplate($perms)
+	{
+		return \Xmf\Yaml::saveWrapped($perms, $this->templateFilename);
+	}
 }

Spacing +10 added lines, -10 removed lines

@@ -37,7 +37,7 @@ 
     {
         //        $this->PermissionHandler($db);
         parent::__construct($db);
-        $this->templateFilename = XOOPS_VAR_PATH . '/configs/newbb_permission_template.php';
+        $this->templateFilename = XOOPS_VAR_PATH.'/configs/newbb_permission_template.php';
     }
 
     /**
@@ -53,7 +53,7 @@ 
         $items = array_filter(array_map('trim', explode(',', FORUM_PERM_ITEMS)));
         if (!empty($fullname)) {
             foreach (array_keys($items) as $key) {
-                $items[$key] = 'forum_' . $items[$key];
+                $items[$key] = 'forum_'.$items[$key];
             }
         }
         $validPerms[(int)$fullname] = $items;
@@ -74,7 +74,7 @@ 
             return $full_items;
         }
 
-        require_once  dirname(__DIR__) . '/include/functions.user.php';
+        require_once  dirname(__DIR__).'/include/functions.user.php';
         $uid = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
         $ip  = \Xmf\IPAddress::fromRequest()->asReadable();
         if (!empty($GLOBALS['xoopsModuleConfig']['enable_usermoderate']) && !isset($suspension[$uid][$id])
@@ -133,10 +133,10 @@ 
         }
         // Create criteria for getting only the permissions regarding this module and this user's groups
         $criteria = new \CriteriaCompo(new \Criteria('gperm_modid', $modid));
-        $criteria->add(new \Criteria('gperm_groupid', '(' . implode(',', $groups) . ')', 'IN'));
+        $criteria->add(new \Criteria('gperm_groupid', '('.implode(',', $groups).')', 'IN'));
         if ($id) {
             if (is_array($id)) {
-                $criteria->add(new \Criteria('gperm_itemid', '(' . implode(',', $id) . ')', 'IN'));
+                $criteria->add(new \Criteria('gperm_itemid', '('.implode(',', $id).')', 'IN'));
             } else {
                 $criteria->add(new \Criteria('gperm_itemid', (int)$id));
             }
@@ -144,7 +144,7 @@ 
         $gperm_names = implode(', ', $this->getValidItems($modid, $id));
 
         // Add criteria for gpermnames
-        $criteria->add(new \Criteria('gperm_name', '(' . $gperm_names . ')', 'IN'));
+        $criteria->add(new \Criteria('gperm_name', '('.$gperm_names.')', 'IN'));
         // Get all permission objects in this module and for this user's groups
         $userpermissions = $this->getObjects($criteria, true);
 
@@ -182,12 +182,12 @@ 
                 continue;
             }
             if ($isAdmin
-                || (isset($permission_set[$forumId]['forum_' . $item])
+                || (isset($permission_set[$forumId]['forum_'.$item])
                     && (!$topic_locked
                         || 'view' === $item))) {
-                $perm[] = constant('_MD_NEWBB_CAN_' . strtoupper($item));
+                $perm[] = constant('_MD_NEWBB_CAN_'.strtoupper($item));
             } else {
-                $perm[] = constant('_MD_NEWBB_CANNOT_' . strtoupper($item));
+                $perm[] = constant('_MD_NEWBB_CANNOT_'.strtoupper($item));
             }
         }
 
@@ -207,7 +207,7 @@ 
         $grouppermHandler = xoops_getHandler('groupperm');
         $criteria     = new \CriteriaCompo(new \Criteria('gperm_modid', $GLOBALS['xoopsModule']->getVar('mid')));
         $items        = $this->getValidPerms(true);
-        $criteria->add(new \Criteria('gperm_name', "('" . implode("', '", $items) . "')", 'IN'));
+        $criteria->add(new \Criteria('gperm_name', "('".implode("', '", $items)."')", 'IN'));
         $criteria->add(new \Criteria('gperm_itemid', $forum_id));
 
         return $grouppermHandler->deleteAll($criteria);

class/Xmlrss.php

Indentation +91 added lines, -91 removed lines

@@ -24,105 +24,105 @@
  */
 class Xmlrss
 {
-    public $xml_version;
-    public $rss_version;
-    public $xml_encoding;
+	public $xml_version;
+	public $rss_version;
+	public $xml_encoding;
 
-    public $channel_title;
-    public $channel_link;
-    public $channel_desc;
-    public $channel_lastbuild;
-    public $channel_webmaster;
-    public $channel_editor;
-    public $channel_category;
-    public $channel_generator;
-    public $channel_language;
+	public $channel_title;
+	public $channel_link;
+	public $channel_desc;
+	public $channel_lastbuild;
+	public $channel_webmaster;
+	public $channel_editor;
+	public $channel_category;
+	public $channel_generator;
+	public $channel_language;
 
-    public $image_title;
-    public $image_url;
-    public $image_link;
-    public $image_description;
-    public $image_height;
-    public $image_width;
+	public $image_title;
+	public $image_url;
+	public $image_link;
+	public $image_description;
+	public $image_height;
+	public $image_width;
 
-    public $max_items;
-    public $max_item_description;
-    public $items = [];
+	public $max_items;
+	public $max_item_description;
+	public $items = [];
 
-    /**
-     *
-     */
-    public function __construct()
-    {
-        $this->xml_version          = '1.0';
-        $this->xml_encoding         = empty($GLOBALS['xoopsModuleConfig']['rss_utf8']) ? _CHARSET : 'UTF-8';
-        $this->rss_version          = '2.0';
-        $this->image_height         = 31;
-        $this->image_width          = 88;
-        $this->max_items            = 10;
-        $this->max_item_description = 0;
-        $this->items                = [];
-    }
+	/**
+	 *
+	 */
+	public function __construct()
+	{
+		$this->xml_version          = '1.0';
+		$this->xml_encoding         = empty($GLOBALS['xoopsModuleConfig']['rss_utf8']) ? _CHARSET : 'UTF-8';
+		$this->rss_version          = '2.0';
+		$this->image_height         = 31;
+		$this->image_width          = 88;
+		$this->max_items            = 10;
+		$this->max_item_description = 0;
+		$this->items                = [];
+	}
 
-    /**
-     * @param $var
-     * @param $val
-     */
-    public function setVarRss($var, $val)
-    {
-        $this->$var = $this->cleanup($val);
-    }
+	/**
+	 * @param $var
+	 * @param $val
+	 */
+	public function setVarRss($var, $val)
+	{
+		$this->$var = $this->cleanup($val);
+	}
 
-    /**
-     * @param         $title
-     * @param         $link
-     * @param  string $description
-     * @param  string $label
-     * @param  int|string    $pubdate
-     * @return bool
-     */
-    public function addItem($title, $link, $description = '', $label = '', $pubdate = 0)
-    {
-        if (count($this->items) < $this->max_items) {
-            if (!empty($label)) {
-                $label = '[' . $this->cleanup($label) . ']';
-            }
-            if (!empty($description)) {
-                $description = $this->cleanup($description, $this->max_item_description);
-            //$description .= ' ' . $label;
-            } else {
-                //$description = $label;
-            }
+	/**
+	 * @param         $title
+	 * @param         $link
+	 * @param  string $description
+	 * @param  string $label
+	 * @param  int|string    $pubdate
+	 * @return bool
+	 */
+	public function addItem($title, $link, $description = '', $label = '', $pubdate = 0)
+	{
+		if (count($this->items) < $this->max_items) {
+			if (!empty($label)) {
+				$label = '[' . $this->cleanup($label) . ']';
+			}
+			if (!empty($description)) {
+				$description = $this->cleanup($description, $this->max_item_description);
+			//$description .= ' ' . $label;
+			} else {
+				//$description = $label;
+			}
 
-            $title         = $this->cleanup($title) . ' ' . $label;
-            $pubdate       = $this->cleanup($pubdate);
-            $this->items[] = [
-                'title'       => $title,
-                'link'        => $link,
-                'guid'        => $link,
-                'description' => $description,
-                'pubdate'     => $pubdate
-            ];
-        }
+			$title         = $this->cleanup($title) . ' ' . $label;
+			$pubdate       = $this->cleanup($pubdate);
+			$this->items[] = [
+				'title'       => $title,
+				'link'        => $link,
+				'guid'        => $link,
+				'description' => $description,
+				'pubdate'     => $pubdate
+			];
+		}
 
-        return true;
-    }
+		return true;
+	}
 
-    /**
-     * @param               $text
-     * @param  int          $trim
-     * @return mixed|string
-     */
-    public function cleanup($text, $trim = 0)
-    {
-        if ('utf-8' === strtolower($this->xml_encoding) && strncasecmp(_CHARSET, $this->xml_encoding, 5)) {
-            $text = \XoopsLocal::convert_encoding($text, 'utf-8');
-        }
-        if (!empty($trim)) {
-            $text = xoops_substr($text, 0, (int)$trim);
-        }
-        $text = htmlspecialchars($text, ENT_QUOTES);
+	/**
+	 * @param               $text
+	 * @param  int          $trim
+	 * @return mixed|string
+	 */
+	public function cleanup($text, $trim = 0)
+	{
+		if ('utf-8' === strtolower($this->xml_encoding) && strncasecmp(_CHARSET, $this->xml_encoding, 5)) {
+			$text = \XoopsLocal::convert_encoding($text, 'utf-8');
+		}
+		if (!empty($trim)) {
+			$text = xoops_substr($text, 0, (int)$trim);
+		}
+		$text = htmlspecialchars($text, ENT_QUOTES);
 
-        return $text;
-    }
+		return $text;
+	}
 }