mambax7 / newbb5

index.php

<?php
/**
 * NewBB 5.0x,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
 * @since          4.00
 * @package        module::newbb
 */

use Xmf\Request;

include_once __DIR__ . '/header.php';

/* deal with marks */
if (Request::getInt('mark_read', 0)) {
    if (1 === Request::getInt('mark_read', 0)) { // marked as read

This code seems to be duplicated across your project.

        $markvalue  = 1;
        $markresult = _MD_NEWBB_MARK_READ;
    } else { // marked as unread
        $markvalue  = 0;
        $markresult = _MD_NEWBB_MARK_UNREAD;
    }
    include_once __DIR__ . '/include/functions.read.php';
    newbbSetReadForum($markvalue);
    $url = XOOPS_URL . '/modules/newbb/index.php';
    redirect_header($url, 2, _MD_NEWBB_ALL_FORUM_MARKED . ' ' . $markresult);
}

$viewcat = Request::getInt('cat', 0, 'GET');//TODO mb check if this is GET or POST?
///** @var \NewbbCategoryHandler $categoryHandler */
//$categoryHandler = xoops_getModuleHandler('category', 'newbb');

$categories = [];
if (!$viewcat) {
    $categories        = $categoryHandler->getByPermission('access', null, false);
    $forum_index_title = '';

$forum_index_title does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $xoops_pagetitle   = $xoopsModule->getVar('name');

$xoops_pagetitle does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

} else {
    $categoryObject = $categoryHandler->get($viewcat);
    if ($categoryHandler->getPermission($categoryObject)) {
        $categories[$viewcat] = $categoryObject->getValues();
    }
    $forum_index_title = sprintf(_MD_NEWBB_FORUMINDEX, htmlspecialchars($GLOBALS['xoopsConfig']['sitename'], ENT_QUOTES));

$forum_index_title does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $xoops_pagetitle   = $categoryObject->getVar('cat_title') . ' [' . $xoopsModule->getVar('name') . ']';

$xoops_pagetitle does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

}

if (0 === count($categories)) {
    redirect_header(XOOPS_URL, 2, _MD_NEWBB_NORIGHTTOACCESS);
}

$xoopsOption['template_main']   = 'newbb_index.tpl';
$xoopsOption['xoops_pagetitle'] = $xoops_pagetitle;

$xoops_pagetitle does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

// irmtfan remove and move to footer.php
//$xoopsOption['xoops_module_header'] = $xoops_module_header;
// irmtfan include header.php after defining $xoopsOption['template_main']
include_once $GLOBALS['xoops']->path('header.php');
include_once __DIR__ . '/include/functions.render.php';
/* rss feed */
// irmtfan new method
if (!empty($GLOBALS['xoopsModuleConfig']['rss_enable'])) {

This code seems to be duplicated across your project.

    $xoopsTpl->assign('xoops_module_header', '
    <link rel="alternate" type="application/xml+rss" title="' . $xoopsModule->getVar('name') . '" href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/rss.php" />
    ' . @$xoopsTpl->get_template_vars('xoops_module_header'));
}
$xoopsTpl->assign('xoops_pagetitle', $xoops_pagetitle);

$xoops_pagetitle does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

// irmtfan remove and move to footer.php
//$xoopsTpl->assign('xoops_module_header', $xoops_module_header);
$xoopsTpl->assign('forum_index_title', $forum_index_title);

$forum_index_title does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

//if ($GLOBALS['xoopsModuleConfig']['wol_enabled']) {
if (!empty($GLOBALS['xoopsModuleConfig']['wol_enabled'])) {
//    /** @var \NewbbOnlineHandler $onlineHandler */
//    $onlineHandler = xoops_getModuleHandler('online', 'newbb');
    $onlineHandler->init();
    $xoopsTpl->assign('online', $onlineHandler->showOnline());
}
///** @var \NewbbForumHandler $forumHandler */
//$forumHandler = xoops_getModuleHandler('forum', 'newbb');
///** @var \NewbbPostHandler $postHandler */
//$postHandler = xoops_getModuleHandler('post', 'newbb');

/* Allowed forums */
$forums_allowed = $forumHandler->getIdsByPermission();

$forums_allowed does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

/* fetch top forums */
$forums_top = [];

$forums_top does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

if (!empty($forums_allowed)) {

$forums_allowed does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit_top = new CriteriaCompo(new Criteria('parent_forum', 0));

$crit_top does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit_top->add(new Criteria('cat_id', '(' . implode(', ', array_keys($categories)) . ')', 'IN'));

$crit_top does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit_top->add(new Criteria('forum_id', '(' . implode(', ', $forums_allowed) . ')', 'IN'));

$crit_top does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $forums_top = $forumHandler->getIds($crit_top);

$forums_top does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

}

/* fetch subforums if required to display */
if ('hidden' === $GLOBALS['xoopsModuleConfig']['subforum_display'] || 0 === count($forums_top)) {

$forums_top does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $forums_sub = [];

$forums_sub does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

} else {
    $crit_sub = new CriteriaCompo(new Criteria('parent_forum', '(' . implode(', ', $forums_top) . ')', 'IN'));

$crit_sub does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit_sub->add(new Criteria('forum_id', '(' . implode(', ', $forums_allowed) . ')', 'IN'));

$crit_sub does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $forums_sub = $forumHandler->getIds($crit_sub);

$forums_sub does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

}

/* Fetch forum data */
$forums_available = array_merge($forums_top, $forums_sub);

$forums_available does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$forums_array     = [];

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$newtopics        = 0;
$deletetopics     = 0;
$newposts         = 0;
$deleteposts      = 0;
if (0 !== count($forums_available)) {

$forums_available does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit_forum = new Criteria('forum_id', '(' . implode(', ', $forums_available) . ')', 'IN');

$crit_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit_forum->setSort('cat_id ASC, parent_forum ASC, forum_order');

$crit_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit_forum->setOrder('ASC');

$crit_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $forums       = $forumHandler->getAll($crit_forum, null, false);

$crit_forum does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $newtopics    = $forumHandler->getTopicCount($forums, 0, 'pending');
    $deletetopics = $forumHandler->getTopicCount($forums, 0, 'deleted');
    $forums_array = $forumHandler->display($forums, $GLOBALS['xoopsModuleConfig']['length_title_index'], $GLOBALS['xoopsModuleConfig']['count_subforum']);

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit         = new CriteriaCompo(new Criteria('forum_id', '(' . implode(', ', $forums_available) . ')', 'IN'));

$forums_available does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit->add(new Criteria('approved', '-1'));
    $deleteposts = $postHandler->getCount($crit);
    $crit        = new CriteriaCompo(new Criteria('forum_id', '(' . implode(', ', $forums_available) . ')', 'IN'));

$forums_available does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $crit->add(new Criteria('approved', '0'));
    $newposts = $postHandler->getCount($crit);
}

if ($newtopics > 0) {
    $xoopsTpl->assign('wait_new_topic', $newtopics);
}
if ($deletetopics > 0) {
    $xoopsTpl->assign('delete_topic', $deletetopics);
}
if ($newposts > 0) {
    $xoopsTpl->assign('wait_new_post', $newposts);
}
if ($deleteposts > 0) {
    $xoopsTpl->assign('delete_post', $deleteposts);
}

///** @var \NewbbReportHandler $reportHandler */
//$reportHandler = xoops_getModuleHandler('report', 'newbb');
$reported      = $reportHandler->getCount(new Criteria('report_result', 0));
$xoopsTpl->assign('reported_count', $reported);
if ($reported > 0) {
    $xoopsTpl->assign('report_post', sprintf(_MD_NEWBB_SEEWAITREPORT, $reported));
}

if (count($forums_array) > 0) {

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    foreach ($forums_array[0] as $parent => $forum) {

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (isset($forums_array[$forum['forum_id']])) {

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $forum['subforum'] = $forums_array[$forum['forum_id']];

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        $forumsByCat[$forum['forum_cid']][] = $forum;
    }
}

$category_array = [];

$category_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$toggles        = newbbGetCookie('G', true);
$iconHandler    = newbbGetIconHandler();
$category_icon  = [

$category_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    'expand'   => $iconHandler->getImageSource('minus'),
    'collapse' => $iconHandler->getImageSource('plus')
];

foreach (array_keys($categories) as $id) {
    $forums = [];
    $onecat = $categories[$id];

    $cat_element_id = 'cat_' . $onecat['cat_id'];

$cat_element_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $expand         = (count($toggles) > 0) ? (in_array($cat_element_id, $toggles) ? false : true) : true;

$cat_element_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    // START irmtfan to improve newbbDisplayImage
    if ($expand) {
        $cat_display      = 'block';        //irmtfan move semicolon

$cat_display does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $cat_icon_display = 'minus';

$cat_icon_display does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $cat_alt          = _MD_NEWBB_HIDE;

$cat_alt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    } else {
        $cat_display      = 'none';        //irmtfan move semicolon

$cat_display does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $cat_icon_display = 'plus';

$cat_icon_display does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $cat_alt          = _MD_NEWBB_SEE;

$cat_alt does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }
    $cat_displayImage = newbbDisplayImage($cat_icon_display, $cat_alt);

$cat_displayImage does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    if (isset($forumsByCat[$onecat['cat_id']])) {
        $forums = $forumsByCat[$onecat['cat_id']];
    }

    $cat_sponsor = [];

$cat_sponsor does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    @list($url, $title) = array_map('trim', preg_split('/ /', $onecat['cat_url'], 2));

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

    if ('' === $title) {
        $title = $url;
    }
    $title = $myts->htmlSpecialChars($title);
    if ('' !== $url) {
        $cat_sponsor = ['title' => $title, 'link' => formatURL($url)];

$cat_sponsor does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }
    //$cat_image = $onecat['cat_image'];
    $cat_image = '';

$cat_image does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $cat_image = $onecat['cat_image'];

$cat_image does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    if ('' !== $cat_image && 'blank.gif' !== $cat_image && $cat_image) {

$cat_image does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $cat_image = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/assets/images/category/' . $cat_image;

$cat_image does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }
    $category_array[] = [

$category_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        'cat_id'           => $onecat['cat_id'],
        'cat_title'        => $myts->displayTarea($onecat['cat_title'], 1),
        'cat_image'        => $cat_image,

$cat_image does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        'cat_sponsor'      => $cat_sponsor,

$cat_sponsor does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        'cat_description'  => $myts->displayTarea($onecat['cat_description'], 1),
        'cat_element_id'   => $cat_element_id,

$cat_element_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        'cat_display'      => $cat_display,

$cat_display does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        'cat_displayImage' => $cat_displayImage,

$cat_displayImage does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        'forums'           => $forums
    ];
}

unset($categories, $forums_array, $forumsByCat);

$forums_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$xoopsTpl->assign_by_ref('category_icon', $category_icon);

$category_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$xoopsTpl->assign_by_ref('categories', $category_array);

$category_array does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$xoopsTpl->assign('notifyicon', $category_icon);

$category_icon does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$xoopsTpl->assign([
                      'index_title' => sprintf(_MD_NEWBB_WELCOME, htmlspecialchars($GLOBALS['xoopsConfig']['sitename'], ENT_QUOTES)),
                      'index_desc'  => _MD_NEWBB_TOSTART
                  ]);

/* display user stats */
if (!empty($GLOBALS['xoopsModuleConfig']['statistik_enabled'])) {
    $userstats = [];
    if (is_object($GLOBALS['xoopsUser'])) {
//        /** @var \NewbbUserstatsHandler $userstatsHandler */
//        $userstatsHandler         = xoops_getModuleHandler('userstats');
        $userstats_row            = $userstatsHandler->getStats($GLOBALS['xoopsUser']->getVar('uid'));

$userstats_row does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $userstats['topics']      = sprintf(_MD_NEWBB_USER_TOPICS, (int)(@$userstats_row['user_topics']));

$userstats_row does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $userstats['posts']       = sprintf(_MD_NEWBB_USER_POSTS, (int)(@$userstats_row['user_posts']));

$userstats_row does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $userstats['digests']     = sprintf(_MD_NEWBB_USER_DIGESTS, (int)(@$userstats_row['user_digests']));

$userstats_row does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $userstats['currenttime'] = sprintf(_MD_NEWBB_TIMENOW, formatTimestamp(time(), 's')); // irmtfan should be removed because it is for anon users too
        $userstats['lastvisit']   = sprintf(_MD_NEWBB_USER_LASTVISIT, formatTimestamp($last_visit, 's')); // irmtfan should be removed because it is for anon users too

$last_visit does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $userstats['lastpost']    = empty($userstats_row['user_lastpost']) ? _MD_NEWBB_USER_NOLASTPOST : sprintf(_MD_NEWBB_USER_LASTPOST, formatTimestamp($userstats_row['user_lastpost'], 's'));

$userstats_row does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }
    $xoopsTpl->assign_by_ref('userstats', $userstats);
    // irmtfan add lastvisit smarty variable for all users
    $xoopsTpl->assign('lastvisit', sprintf(_MD_NEWBB_USER_LASTVISIT, formatTimestamp($last_visit, 'l')));

$last_visit does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $xoopsTpl->assign('currenttime', sprintf(_MD_NEWBB_TIMENOW, formatTimestamp(time(), 'm')));
}

/* display forum stats */
///** @var \NewbbStatsHandler $statsHandler */
//$statsHandler = xoops_getModuleHandler('stats', 'newbb');
$stats        = $statsHandler->getStats(array_merge([0], $forums_available));

$forums_available does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$xoopsTpl->assign_by_ref('stats', $stats);
$xoopsTpl->assign('subforum_display', $GLOBALS['xoopsModuleConfig']['subforum_display']);
$xoopsTpl->assign('mark_read', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/index.php?mark_read=1');
$xoopsTpl->assign('mark_unread', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/index.php?mark_read=2');

$xoopsTpl->assign('all_link', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/list.topic.php?status=all');
$xoopsTpl->assign('post_link', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/viewpost.php?status=all');
$xoopsTpl->assign('newpost_link', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/viewpost.php?status=new');
$xoopsTpl->assign('digest_link', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/list.topic.php?status=digest');
$xoopsTpl->assign('unreplied_link', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/list.topic.php?status=unreplied');
$xoopsTpl->assign('unread_link', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/list.topic.php?status=unread');
$xoopsTpl->assign('menumode', $menumode);
$xoopsTpl->assign('menumode_other', $menumode_other);

$menumode_other does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$isAdmin = $GLOBALS['xoopsUserIsAdmin'];
$xoopsTpl->assign('viewer_level', $isAdmin ? 2 : is_object($GLOBALS['xoopsUser']));
$mode = Request::getInt('mode', 0, 'GET');
$xoopsTpl->assign('mode', $mode);

$xoopsTpl->assign('viewcat', $viewcat);
$xoopsTpl->assign('version', $xoopsModule->getVar('version'));

/* To be removed */
if ($isAdmin) {
    $xoopsTpl->assign('forum_index_cpanel', ['link' => 'admin/index.php', 'name' => _MD_NEWBB_ADMINCP]);
}

if (1 == $GLOBALS['xoopsModuleConfig']['rss_enable']) {
    $xoopsTpl->assign('rss_enable', 1);
    $xoopsTpl->assign('rss_button', newbbDisplayImage('rss', 'RSS feed'));
}
$xoopsTpl->assign([
                      'img_forum_new' => newbbDisplayImage('forum_new', _MD_NEWBB_NEWPOSTS),
                      'img_forum'     => newbbDisplayImage('forum', _MD_NEWBB_NONEWPOSTS),
                      'img_subforum'  => newbbDisplayImage('subforum')
                  ]);

// irmtfan move to footer.php
include_once __DIR__ . '/footer.php';
include $GLOBALS['xoops']->path('footer.php');