mambax7 / newbb5

delete.php

<?php
/**
 * NewBB 5.0x,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
 * @since          4.00
 * @package        module::newbb
 */

use Xmf\Request;

include_once __DIR__ . '/header.php';

$ok = Request::getInt('ok', 0, 'POST');

foreach (['forum', 'topic_id', 'post_id', 'order', 'pid', 'act'] as $getint) {
    ${$getint} = Request::getInt($getint, 0, 'POST');
}

foreach (['forum', 'topic_id', 'post_id', 'order', 'pid', 'act'] as $getint) {

This code seems to be duplicated across your project.

    ${$getint} = !empty(${$getint}) ? ${$getint} : Request::getInt($getint, 0, 'GET');
}
//$viewmode = (isset($_GET['viewmode']) && $_GET['viewmode'] !== 'flat') ? 'thread' : 'flat';

69% of this comment could be valid code. Did you maybe forget this after debugging?

//$viewmode = ($viewmode) ? $viewmode: (isset($_POST['viewmode'])?$_POST['viewmode'] : 'flat');

$viewmode = (Request::getString('viewmode', '', 'GET')
             && 'flat' !== Request::getString('viewmode', '', 'GET')) ? 'thread' : 'flat';
$viewmode = $viewmode ?: (Request::getString('viewmode', '', 'POST') ?: 'flat');

///** @var \NewbbForumHandler $forumHandler */

52% of this comment could be valid code. Did you maybe forget this after debugging?

//$forumHandler = xoops_getModuleHandler('forum', 'newbb');
///** @var \NewbbTopicHandler $topicHandler */
//$topicHandler = xoops_getModuleHandler('topic', 'newbb');
///** @var \NewbbPostHandler $postHandler */
//$postHandler = xoops_getModuleHandler('post', 'newbb');

if (!empty($post_id)) {

$post_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $topic = $topicHandler->getByPost($post_id);

$post_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

} else {
    $topic = $topicHandler->get($topic_id);

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

}
$topic_id = $topic->getVar('topic_id');

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

if (!$topic_id) {

This code seems to be duplicated across your project.

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $redirect = empty($forum) ? 'index.php' : 'viewforum.php?forum=' . $forum;
    $redirect = XOOPS_URL . '/modules/newbb/' . $redirect;
    redirect_header($redirect, 2, _MD_NEWBB_ERRORTOPIC);
}

$forum     = $topic->getVar('forum_id');
$forumObject = $forumHandler->get($forum);
if (!$forumHandler->getPermission($forumObject)) {
    redirect_header(XOOPS_URL . '/index.php', 2, _MD_NEWBB_NORIGHTTOACCESS);
}

$isAdmin = newbbIsAdmin($forumObject);
$uid     = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;

/** @var NewbbPost $postObject */
$postObject     = $postHandler->get($post_id);

$post_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$topic_status = $topic->getVar('topic_status');

$topic_status does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

if (($postObject->checkIdentity() || $isAdmin)

This if statement is empty and can be removed.

    && $topicHandler->getPermission($topic->getVar('forum_id'), $topic_status, 'delete')) {

$topic_status does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

} else {
    redirect_header(XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=$topic_id&pid=$pid&forum=$forum", 2, _MD_NEWBB_DELNOTALLOWED);

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

}

if (!$isAdmin && !$postObject->checkTimelimit('delete_timelimit')) {
    redirect_header(XOOPS_URL . "/modules/newbb/viewtopic.php?forum=$forum&topic_id=$topic_id&post_id=$post_id&pid=$pid", 2, _MD_NEWBB_TIMEISUPDEL);

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

}

if ($GLOBALS['xoopsModuleConfig']['wol_enabled']) {
//    /** @var \NewbbOnlineHandler $onlineHandler */

42% of this comment could be valid code. Did you maybe forget this after debugging?

//    $onlineHandler = xoops_getModuleHandler('online', 'newbb');
    $onlineHandler->init($forumObject);
}

if ($ok) {
    $isDeleteOne = (1 === $ok);
    if ($postObject->isTopic() && 0 == $topic->getVar('topic_replies')) {
        $isDeleteOne = false;
    }
    if ($isDeleteOne && $postObject->isTopic() && $topic->getVar('topic_replies') > 0) {
        //$postHandler->emptyTopic($postObject);

86% of this comment could be valid code. Did you maybe forget this after debugging?

        redirect_header(XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=$topic_id&pid=$pid&forum=$forum", 2, _MD_NEWBB_POSTFIRSTWITHREPLYNODELETED);

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    } else {
        if (Request::getString('post_text', '', 'POST')) {
            //send a message
            /** @var \XoopsMemberHandler $memberHandler */
            $memberHandler = xoops_getHandler('member');
            $senduser      = $memberHandler->getUser($postObject->getVar('uid'));
            if ($senduser->getVar('notify_method') > 0) {
                $xoopsMailer = xoops_getMailer();
                $xoopsMailer->reset();
                if (1 == $senduser->getVar('notify_method')) {
                    $xoopsMailer->usePM();
                } else {
                    $xoopsMailer->useMail();
                }
                $xoopsMailer->setHTML(true);
                $xoopsMailer->setToUsers($senduser);
                $xoopsMailer->setFromName($GLOBALS['xoopsUser']->getVar('uname'));
                $xoopsMailer->setSubject(_MD_NEWBB_DELEDEDMSG_SUBJECT);
                $forenurl = '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewtopic.php?topic_id=' . $postObject->getVar('topic_id') . '">' . $postObject->getVar('subject') . '</a>';
                if (!empty($GLOBALS['xoopsModuleConfig']['do_rewrite'])) {
                    $forenurl = seo_urls($forenurl);
                }
                $body = sprintf(_MD_NEWBB_DELEDEDMSG_BODY, $senduser->getVar('uname'), $forenurl, Request::getString('post_text', '', 'POST'), $GLOBALS['xoopsUser']->getVar('uname'), $GLOBALS['xoopsConfig']['sitename'], XOOPS_URL . '/');
                $body = $myts->nl2Br($body);
                $xoopsMailer->setBody($body);
                $xoopsMailer->send();
            }
        }
        $postHandler->delete($postObject, $isDeleteOne);
        $forumHandler->synchronization($forum);
        $topicHandler->synchronization($topic_id);

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

//        /** @var \NewbbStatsHandler $statsHandler */

42% of this comment could be valid code. Did you maybe forget this after debugging?

//        $statsHandler = xoops_getModuleHandler('stats', 'newbb');
        $statsHandler->reset();
    }

    //$postObject->loadFilters('delete');

86% of this comment could be valid code. Did you maybe forget this after debugging?

    if ($isDeleteOne) {
        redirect_header(XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=$topic_id&order=$order&viewmode=$viewmode&pid=$pid&forum=$forum", 2, _MD_NEWBB_POSTDELETED);

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    } else {
        redirect_header(XOOPS_URL . "/modules/newbb/viewforum.php?forum=$forum", 2, _MD_NEWBB_POSTSDELETED);
    }
} else {
    include $GLOBALS['xoops']->path('header.php');
    //xoops_confirm(array('post_id' => $post_id, 'viewmode' => $viewmode, 'order' => $order, 'forum' => $forum, 'topic_id' => $topic_id, 'ok' => 1), 'delete.php', _MD_NEWBB_DEL_ONE);

61% of this comment could be valid code. Did you maybe forget this after debugging?

    echo '<div class="confirmMsg">' . _MD_NEWBB_DEL_ONE . '<br>
          <form method="post" action="' . XOOPS_URL . '/modules/newbb/delete.php">';
    echo _MD_NEWBB_DELEDEDMSG . '<br>';
    echo '<textarea name="post_text" cols="50" rows="5"></textarea><br>';
    echo '<input type="hidden" name="post_id" value="' . htmlspecialchars($post_id) . '" />';

$post_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    echo '<input type="hidden" name="order" value="' . htmlspecialchars($order) . '" />';
    echo '<input type="hidden" name="forum" value="' . htmlspecialchars($forum) . '" />';
    echo '<input type="hidden" name="topic_id" value="' . htmlspecialchars($topic_id) . '" />';

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    echo '<input type="hidden" name="ok" value="1" />';
    echo $GLOBALS['xoopsSecurity']->getTokenHTML();
    echo '<input type="submit" name="confirm_submit" value="' . _SUBMIT . '" title="' . _SUBMIT . '"/>
          <input type="button" name="confirm_back" value="' . _CANCEL . '" onclick="history.go(-1);" title="' . _CANCEL . '" />
          </form>
          </div>';
    if ($isAdmin) {
        xoops_confirm([
                          'post_id'  => $post_id,

$post_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                          'viewmode' => $viewmode,
                          'order'    => $order,
                          'forum'    => $forum,
                          'topic_id' => $topic_id,

$topic_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                          'ok'       => 99
                      ], 'delete.php', _MD_NEWBB_DEL_RELATED);
    }
    include $GLOBALS['xoops']->path('footer.php');
}