blocks/newbb_block.php ➔ b_newbb_show()

Complexity

Conditions	23
Paths	> 20000

Size

Total Lines	163
Code Lines	119

Duplication

Lines	37
Ratio	22.7 %

Importance

Changes

0

<?php
function b_newbb_show($options)
{
    global $accessForums;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    global $xoopsLogger;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    include_once __DIR__ . '/../include/functions.config.php';
    include_once __DIR__ . '/../include/functions.time.php';

    $myts          = \MyTextSanitizer::getInstance();

The type MyTextSanitizer was not found. Maybe you did not declare it correctly or list all dependencies?

    $block         = [];
    $i             = 0;

The assignment to $i is dead and can be removed.

    $order         = '';

The assignment to $order is dead and can be removed.

    $extraCriteria = '';
    if (!empty($options[2])) {
        //include_once __DIR__ . '/../include/functions.time.php';

50% of this comment could be valid code. Did you maybe forget this after debugging?

        $extraCriteria .= ' AND p.post_time>' . (time() - newbbGetSinceTime($options[2]));
    }
    switch ($options[0]) {
        case 'time':
        default:
            $order = 't.topic_last_post_id';
            break;
    }

    if (!isset($accessForums)) {
        /** var Newbb\PermissionHandler $permHandler */
        $permHandler = Newbb\Helper::getInstance()->getHandler('Permission');
        if (!$accessForums = $permHandler->getForums()) {
            return $block;
        }
    }
    if (!empty($options[6])) {
        $myallowedForums = array_filter(array_slice($options, 6), 'b_newbb_array_filter'); // get allowed forums
        $allowedForums   = array_intersect($myallowedForums, $accessForums);
    } else {
        $allowedForums = $accessForums;
    }
    if (empty($allowedForums)) {
        return $block;
    }

    $forumCriteria   = ' AND t.forum_id IN (' . implode(',', $allowedForums) . ')';
    $approveCriteria = ' AND t.approved = 1';

    $newbbConfig = newbbLoadConfig();
    if (!empty($newbbConfig['do_rewrite'])) {
        include_once $GLOBALS['xoops']->path('modules/newbb/seo_url.php');
    } else {
        if (!defined('SEO_MODULE_NAME')) {
            define('SEO_MODULE_NAME', 'modules/newbb');
        }
    }

    $query = 'SELECT'
             . '    t.topic_id, t.topic_replies, t.forum_id, t.topic_title, t.topic_views, t.type_id,'
             . '    f.forum_name,t.topic_status,'
             . '    p.post_id, p.post_time, p.icon, p.uid, p.poster_name'
             . '    FROM '
             . $GLOBALS['xoopsDB']->prefix('newbb_topics')
             . ' AS t '
             . '    LEFT JOIN '
             . $GLOBALS['xoopsDB']->prefix('newbb_posts')
             . ' AS p ON t.topic_last_post_id=p.post_id'
             . '    LEFT JOIN '
             . $GLOBALS['xoopsDB']->prefix('newbb_forums')
             . ' AS f ON f.forum_id=t.forum_id'
             . '    WHERE 1=1 '
             . $forumCriteria
             . $approveCriteria
             . $extraCriteria
             . ' ORDER BY '
             . $order
             . ' DESC';

    $result = $GLOBALS['xoopsDB']->query($query, $options[1], 0);

    if (!$result) {
        //xoops_error($GLOBALS['xoopsDB']->error());

84% of this comment could be valid code. Did you maybe forget this after debugging?

        return false;
    }
    $block['disp_mode'] = $options[3]; // 0 - full view; 1 - compact view; 2 - lite view;
    $rows               = [];
    $author             = [];
    $types              = [];

    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
        $rows[]              = $row;
        $author[$row['uid']] = 1;
        if ($row['type_id'] > 0) {
            $types[$row['type_id']] = 1;
        }
    }

    if (count($rows) < 1) {
        return $block;
    }

    include_once __DIR__ . '/../include/functions.user.php';
    $author_name = newbbGetUnameFromIds(array_keys($author), $newbbConfig['show_realname'], true);

    if (count($types) > 0) {
        /** @var Newbb\TypeHandler $typeHandler */
        $typeHandler = Newbb\Helper::getInstance()->getHandler('Type');
        $type_list   = $typeHandler->getList(new \Criteria('type_id', '(' . implode(', ', array_keys($types)) . ')', 'IN'));

The type Criteria was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    foreach ($rows as $arr) {
        // irmtfan add lastposticon - load main lang
        xoops_loadLanguage('main', 'newbb');

The function xoops_loadLanguage was not found. Maybe you did not declare it correctly or list all dependencies?

        $topic                  = [];
        $topic_page_jump        = newbbDisplayImage('lastposticon', _MD_NEWBB_GOTOLASTPOST);
        $topic['topic_subject'] = empty($type_list[$arr['type_id']]) ? '' : '[' . $type_list[$arr['type_id']] . ']';

        $topic['post_id']      = $arr['post_id'];
        $topic['topic_status'] = $arr['topic_status'];
        $topic['forum_id']     = $arr['forum_id'];
        $topic['forum_name']   = $myts->htmlSpecialChars($arr['forum_name']);
        $topic['id']           = $arr['topic_id'];

        $title = $myts->htmlSpecialChars($arr['topic_title']);
        if (!empty($options[5])) {
            $title = xoops_substr($title, 0, $options[5]);

The function xoops_substr was not found. Maybe you did not declare it correctly or list all dependencies?

        }
        $topic['title']   = $topic['topic_subject'] . ' ' . $title;
        $topic['replies'] = $arr['topic_replies'];
        $topic['views']   = $arr['topic_views'];
        $topic['time']    = newbbFormatTimestamp($arr['post_time']);
        if (!empty($author_name[$arr['uid']])) {
            $topic_poster = $author_name[$arr['uid']];
        } else {
            $topic_poster = $myts->htmlSpecialChars($arr['poster_name'] ?: $GLOBALS['xoopsConfig']['anonymous']);
        }
        $topic['topic_poster']    = $topic_poster;
        $topic['topic_page_jump'] = $topic_page_jump;
        // START irmtfan remove hardcoded html in URLs - add $seo_topic_url
        $seo_url       = XOOPS_URL . '/' . SEO_MODULE_NAME . '/viewtopic.php?post_id=' . $topic['post_id'];

The constant XOOPS_URL was not found. Maybe you did not declare it correctly or list all dependencies?

        $seo_topic_url = XOOPS_URL . '/' . SEO_MODULE_NAME . '/viewtopic.php?topic_id=' . $topic['id'];
        $seo_forum_url = XOOPS_URL . '/' . SEO_MODULE_NAME . '/viewforum.php?forum=' . $topic['forum_id'];
        if (!empty($newbbConfig['do_rewrite'])) {
            $topic['seo_url']       = seo_urls($seo_url);
            $topic['seo_topic_url'] = seo_urls($seo_topic_url);
            $topic['seo_forum_url'] = seo_urls($seo_forum_url);
        } else {
            $topic['seo_url']       = $seo_url;
            $topic['seo_topic_url'] = $seo_topic_url;
            $topic['seo_forum_url'] = $seo_forum_url;
        }
        // END irmtfan remove hardcoded html in URLs - add $seo_topic_url
        $block['topics'][] = $topic;
        unset($topic);
    }
    // START irmtfan remove hardcoded html in URLs
    $seo_top_allforums          = XOOPS_URL . '/' . SEO_MODULE_NAME;
    $block['seo_top_allforums'] = !empty($newbbConfig['do_rewrite']) ? seo_urls($seo_top_allforums) : $seo_top_allforums;
    $seo_top_allforums          = XOOPS_URL . '/' . SEO_MODULE_NAME . '/list.topic.php';
    $block['seo_top_alltopics'] = !empty($newbbConfig['do_rewrite']) ? seo_urls($seo_top_allforums) : $seo_top_allforums;
    $seo_top_allforums          = XOOPS_URL . '/' . SEO_MODULE_NAME . '/viewpost.php';
    $block['seo_top_allposts']  = !empty($newbbConfig['do_rewrite']) ? seo_urls($seo_top_allforums) : $seo_top_allforums;
    // END irmtfan remove hardcoded html in URLs
    $block['indexNav'] = (int)$options[4];

    return $block;
}