Code Duplication - mambax7/newbb5 - Measure and Improve Code Quality continuously with Scrutinizer

newbb5

Code Duplication Length = 3-11 lines in 2 locations

delete.php 1 location


    ${$getint} = Request::getInt($getint, 0, 'POST');
}

foreach (['forum', 'topic_id', 'post_id', 'order', 'pid', 'act'] as $getint) {
    ${$getint} = !empty(${$getint}) ? ${$getint} : Request::getInt($getint, 0, 'GET');
}
//$viewmode = (isset($_GET['viewmode']) && $_GET['viewmode'] !== 'flat') ? 'thread' : 'flat';
//$viewmode = ($viewmode) ? $viewmode: (isset($_POST['viewmode'])?$_POST['viewmode'] : 'flat');


include/form.post.php 1 location


}
$xoopsTpl->assign('form_title', $form_title);

foreach ([
             'start',
             'topic_id',
             'post_id',
             'pid',
             'isreply',
             'isedit',
             'contents_preview'
         ] as $getint) {
    ${$getint} = Request::getInt($getint, ((!empty(${$getint})) ? ${$getint} : 0), 'GET'); // isset($_GET[$getint]) ? (int)($_GET[$getint]) : ((!empty(${$getint})) ? ${$getint} : 0);
}
foreach ([
             'order',
             'viewmode',

		@@ 22-24 (lines=3) @@
19		${$getint} = Request::getInt($getint, 0, 'POST');
20		}
21
22		foreach (['forum', 'topic_id', 'post_id', 'order', 'pid', 'act'] as $getint) {
23		${$getint} = !empty(${$getint}) ? ${$getint} : Request::getInt($getint, 0, 'GET');
24		}
25		//$viewmode = (isset($_GET['viewmode']) && $_GET['viewmode'] !== 'flat') ? 'thread' : 'flat';
26		//$viewmode = ($viewmode) ? $viewmode: (isset($_POST['viewmode'])?$_POST['viewmode'] : 'flat');
27

		@@ 75-85 (lines=11) @@
72		}
73		$xoopsTpl->assign('form_title', $form_title);
74
75		foreach ([
76		'start',
77		'topic_id',
78		'post_id',
79		'pid',
80		'isreply',
81		'isedit',
82		'contents_preview'
83		] as $getint) {
84		${$getint} = Request::getInt($getint, ((!empty(${$getint})) ? ${$getint} : 0), 'GET'); // isset($_GET[$getint]) ? (int)($_GET[$getint]) : ((!empty(${$getint})) ? ${$getint} : 0);
85		}
86		foreach ([
87		'order',
88		'viewmode',

mambax7 / newbb5

Code Duplication Length = 3-11 lines in 2 locations

delete.php 1 location

include/form.post.php 1 location