View GitHub Repository newbb5

Schedule Inspection
Subscribe

Code Duplication    Length = 4-4 lines in 2 locations

viewtopic.php 2 locations

@@ 73-76 (lines=4) @@
70 
    }
71 
}
72 

                                

                                                            

                                    73
                                    
                                    
if (!$topic_id && !$post_id) {

                                

                                                            

                                    74
                                    
                                    
    $redirect = empty($forum_id) ? XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/index.php' : XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/viewforum.php?forum={$forum_id}";

                                

                                                            

                                    75
                                    
                                    
    redirect_header($redirect, 2, _MD_NEWBB_ERRORTOPIC);

                                

                                                            

                                    76
                                    
                                    
}

                                

                                                            

                                    77
                                    
                                    

                                

                                                            

                                    78
                                    
                                    
/** @var \NewbbTopicHandler $topicHandler */

                                

                                                            

                                    79
                                    
                                    
$topicHandler = xoops_getModuleHandler('topic', 'newbb');

                                

                                                                                

                                
                                
                                    @@ 90-93 (lines=4) @@
                                
                            


                                                            

                                    87
                                    
                                    
    $topicObject = $topicHandler->get($topic_id);

                                

                                                            

                                    88
                                    
                                    
}

                                

                                                            

                                    89
                                    
                                    

                                

                                                            

                                    90
                                    
                                    
if (!is_object($topicObject) || !$topic_id = $topicObject->getVar('topic_id')) {

                                

                                                            

                                    91
                                    
                                    
    $redirect = empty($forum_id) ? XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/index.php' : XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . "/viewforum.php?forum={$forum_id}";

                                

                                                            

                                    92
                                    
                                    
    redirect_header($redirect, 2, _MD_NEWBB_ERRORTOPIC);

                                

                                                            

                                    93
                                    
                                    
}

                                

                                                            

                                    94
                                    
                                    
$forum_id = $topicObject->getVar('forum_id');

                                

                                                            

                                    95
                                    
                                    
/** @var \NewbbForumHandler $forumHandler */

                                

                                                            

                                    96
                                    
                                    
$forumHandler = xoops_getModuleHandler('forum', 'newbb');