mambax7 / newbb

include/functions.time.php

<?php declare(strict_types=1);
/**
 * NewBB,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
 * @since          4.00
 */
defined('NEWBB_FUNCTIONS_INI') || require __DIR__ . '/functions.ini.php';
define('NEWBB_FUNCTIONS_TIME_LOADED', true);

if (!defined('NEWBB_FUNCTIONS_TIME')) {
    define('NEWBB_FUNCTIONS_TIME', 1);

    /**
     * Function to convert UNIX time to formatted time string
     * @param int $time
     * @param string  $format
     * @param string  $timeoffset
     * @return string
     */
    function newbbFormatTimestamp(int $time, string $format = 'c', string $timeoffset = ''): string
    {
        xoops_loadLanguage('locale');
        $newbbConfig = newbbLoadConfig();

        $format = \mb_strtolower($format);
        if ('reg' === $format || '' === $format) {
            $format = 'c';
        }
        if (('custom' === $format || 'c' === $format) && !empty($newbbConfig['formatTimestamp_custom'])) {
            $format = $newbbConfig['formatTimestamp_custom'];
        }

        return XoopsLocal::formatTimestamp($time, $format, $timeoffset);
    }

    /**
     * @param int $selected
     * @return string
     */
    function newbbSinceSelectBox(int $selected = 100): string
    {
        $newbbConfig = newbbLoadConfig();
        // irmtfan - new method to get user inputs
        preg_match_all('/-?\d+/', (string) $newbbConfig['since_options'], $match);
        $select_array = array_unique($match[0]);
        //$select_array = explode(',', $newbbConfig['since_options']);
        //$select_array = array_map('trim', $select_array);
        // irmtfan - if the array is empty do not show selection box
        if (!$select_array) {

The expression $select_array of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $since = $newbbConfig['since_default'];
            switch ($since) {
                case 0:
                    $forum_since = _MD_NEWBB_BEGINNING;
                    break;
                case 365:
                    $forum_since = _MD_NEWBB_THELASTYEAR;
                    break;
                default:
                    if ($since > 0) {
                        $forum_since = sprintf(_MD_NEWBB_FROMLASTDAYS, $since);
                    } else {
                        $forum_since = sprintf(_MD_NEWBB_FROMLASTHOURS, abs($since));
                    }
            }

            return $forum_since;
        }
        $forum_selection_since = '<select class="form-control" name="since" id="since">';
        // irmtfan no option when no selected value
        $forum_selection_since .= '<option value="">--------</option>';
        foreach ($select_array as $since) {
            $forum_selection_since .= '<option value="' . $since . '"' . (($selected == $since) ? ' selected="selected"' : '') . '>';
            // START irmtfan functional since 0 and 365
            switch ($since) {
                case 0:
                    $forum_selection_since .= _MD_NEWBB_BEGINNING;
                    break;
                case 365:
                    $forum_selection_since .= _MD_NEWBB_THELASTYEAR;
                    break;
                default:
                    if ($since > 0) {
                        $forum_selection_since .= sprintf(_MD_NEWBB_FROMLASTDAYS, $since);
                    } else {
                        $forum_selection_since .= sprintf(_MD_NEWBB_FROMLASTHOURS, abs((int)$since));
                    }
            }
            // END irmtfan functional since 0 and 365
            $forum_selection_since .= '</option>';
        }
        // irmtfan remove hardcodes
        //$forum_selection_since .= '<option value="365"'.(($selected === 365) ? ' selected="selected"' : '').'>'._MD_NEWBB_THELASTYEAR.'</option>';
        //$forum_selection_since .= '<option value="0"'.(($selected === 0) ? ' selected="selected"' : '').'>'._MD_NEWBB_BEGINNING.'</option>';
        $forum_selection_since .= '</select>';

        return $forum_selection_since;
    }

    /**
     * @param int $since
     *
     * @return int
     *
     * @psalm-return 0|positive-int
     */
    function newbbGetSinceTime(int $since = 100)
    {
        // irmtfan bad coding
        //if ($since==1000) return 0;
        if ($since > 0) {
            return (int)$since * 24 * 3600;
        }

        return (int)abs($since) * 3600;
    }
}