mambax7 / newbb

delete.php

<?php declare(strict_types=1);

/**
 * NewBB,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
 * @since          4.00
 */

use Xmf\Request;
use XoopsModules\Newbb\{
    Forum,
    OnlineHandler,
    Post,
    StatsHandler
};
/** @var XoopsModules\Newbb\StatsHandler $statsHandler */
/** @var XoopsModules\Newbb\OnlineHandler $onlineHandler */
/** @var XoopsModules\Newbb\Post $postObject */
/** @var XoopsModules\Newbb\ForumHandler $forumHandler */
/** @var XoopsModules\Newbb\TopicHandler $topicHandler */
/** @var XoopsModules\Newbb\PostHandler $postHandler */

require_once __DIR__ . '/header.php';

$ok = Request::getInt('ok', 0, 'POST');

foreach (['forum', 'topic_id', 'post_id', 'order', 'pid', 'act'] as $getint) {
    ${$getint} = Request::getInt($getint, 0, 'POST');
}

foreach (['forum', 'topic_id', 'post_id', 'order', 'pid', 'act'] as $getint) {
    ${$getint} = !empty(${$getint}) ? ${$getint} : Request::getInt($getint, 0, 'GET');
}
//$viewmode = (isset($_GET['viewmode']) && $_GET['viewmode'] !== 'flat') ? 'thread' : 'flat';
//$viewmode = ($viewmode) ? $viewmode: (isset($_POST['viewmode'])?$_POST['viewmode'] : 'flat');

$viewmode = (Request::getString('viewmode', '', 'GET') && 'flat' !== Request::getString('viewmode', '', 'GET')) ? 'thread' : 'flat';
$viewmode = $viewmode ?: (Request::getString('viewmode', '', 'POST') ?: 'flat');

///** @var XoopsModules\Newbb\ForumHandler $forumHandler */
//$forumHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Forum');
///** @var XoopsModules\Newbb\TopicHandler $topicHandler */
//$topicHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Topic');
/** @var XoopsModules\Newbb\PostHandler $postHandler */
//$postHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Post');

if (!empty($post_id)) {
    $topic = $topicHandler->getByPost($post_id);
} else {
    $topic = $topicHandler->get($topic_id);
}
$topic_id = $topic->getVar('topic_id');
if (!$topic_id) {
    $redirect = empty($forum) ? 'index.php' : 'viewforum.php?forum=' . $forum;
    $redirect = XOOPS_URL . '/modules/newbb/' . $redirect;
    redirect_header($redirect, 2, _MD_NEWBB_ERRORTOPIC);
}

$forum       = $topic->getVar('forum_id');
/** @var Forum $forumObject */
$forumObject = $forumHandler->get($forum);
if (!$forumHandler->getPermission($forumObject)) {
    redirect_header(XOOPS_URL . '/index.php', 2, _MD_NEWBB_NORIGHTTOACCESS);
}

$isAdmin = newbbIsAdmin($forumObject);
$uid     = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;

$postObject   = $postHandler->get($post_id);
$topic_status = $topic->getVar('topic_status');
if (($postObject->checkIdentity() || $isAdmin) && $topicHandler->getPermission($topic->getVar('forum_id'), $topic_status, 'delete')) {

The method checkIdentity() does not exist on XoopsObject. It seems like you code against a sub-type of XoopsObject such as Post or XoopsModules\Newbb\Post.

} else {
    redirect_header(XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=$topic_id&pid=$pid&forum=$forum", 2, _MD_NEWBB_DELNOTALLOWED);
}

if (!$isAdmin && !$postObject->checkTimelimit('delete_timelimit')) {

The method checkTimelimit() does not exist on XoopsObject. It seems like you code against a sub-type of XoopsObject such as Post or XoopsModules\Newbb\Post.

    redirect_header(XOOPS_URL . "/modules/newbb/viewtopic.php?forum=$forum&topic_id=$topic_id&post_id=$post_id&pid=$pid", 2, _MD_NEWBB_TIMEISUPDEL);
}

if ($GLOBALS['xoopsModuleConfig']['wol_enabled']) {
    //    $onlineHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Online');
    $onlineHandler->init($forumObject);
}

if ($ok) {
    $isDeleteOne = (1 === $ok);
    if ($postObject->isTopic() && 0 == $topic->getVar('topic_replies')) {

The method isTopic() does not exist on XoopsObject. It seems like you code against a sub-type of XoopsObject such as Post or XoopsModules\Newbb\Post.

        $isDeleteOne = false;
    }
    if ($isDeleteOne && $postObject->isTopic() && $topic->getVar('topic_replies') > 0) {
        //$postHandler->emptyTopic($postObject);
        redirect_header(XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=$topic_id&pid=$pid&forum=$forum", 2, _MD_NEWBB_POSTFIRSTWITHREPLYNODELETED);
    } else {
        if (Request::getString('post_text', '', 'POST')) {
            //send a message
            /** @var \XoopsMemberHandler $memberHandler */
            $memberHandler = xoops_getHandler('member');
            $senduser      = $memberHandler->getUser($postObject->getVar('uid'));
            if ($senduser->getVar('notify_method') > 0) {
                $xoopsMailer = xoops_getMailer();
                $xoopsMailer->reset();
                if (1 == $senduser->getVar('notify_method')) {
                    $xoopsMailer->usePM();
                } else {
                    $xoopsMailer->useMail();
                }
                $xoopsMailer->setHTML(true);
                $xoopsMailer->setToUsers($senduser);
                $xoopsMailer->setFromName($GLOBALS['xoopsUser']->getVar('uname'));
                $xoopsMailer->setSubject(_MD_NEWBB_DELEDEDMSG_SUBJECT);
                $forenurl = '<a href="' . XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/viewtopic.php?topic_id=' . $postObject->getVar('topic_id') . '">' . $postObject->getVar('subject') . '</a>';
                if (!empty($GLOBALS['xoopsModuleConfig']['do_rewrite'])) {
                    $forenurl = seo_urls($forenurl);
                }
                $body = sprintf(_MD_NEWBB_DELEDEDMSG_BODY, $senduser->getVar('uname'), $forenurl, Request::getString('post_text', '', 'POST'), $GLOBALS['xoopsUser']->getVar('uname'), $GLOBALS['xoopsConfig']['sitename'], XOOPS_URL . '/');

It seems like $senduser->getVar('uname') can also be of type array and array; however, parameter $values of sprintf() does only seem to accept double|integer|string, maybe add an additional type check?

                $body = $myts->nl2Br($body);
                $xoopsMailer->setBody($body);
                $xoopsMailer->send();
            }
        }
        $postHandler->myDelete($postObject, $isDeleteOne);

It seems like $postObject can also be of type null; however, parameter $post of XoopsModules\Newbb\PostHandler::myDelete() does only seem to accept XoopsModules\Newbb\Post, maybe add an additional type check?

        $forumHandler->synchronization($forum);
        $topicHandler->synchronization($topic_id);
        //        $statsHandler = \XoopsModules\Newbb\Helper::getInstance()->getHandler('Stats');
        $statsHandler->reset();
    }

    //$postObject->loadFilters('delete');
    if ($isDeleteOne) {
        redirect_header(XOOPS_URL . "/modules/newbb/viewtopic.php?topic_id=$topic_id&order=$order&viewmode=$viewmode&pid=$pid&forum=$forum", 2, _MD_NEWBB_POSTDELETED);
    } else {
        redirect_header(XOOPS_URL . "/modules/newbb/viewforum.php?forum=$forum", 2, _MD_NEWBB_POSTSDELETED);
    }
} else {
    require_once $GLOBALS['xoops']->path('header.php');
    //xoops_confirm(array('post_id' => $post_id, 'viewmode' => $viewmode, 'order' => $order, 'forum' => $forum, 'topic_id' => $topic_id, 'ok' => 1), 'delete.php', _MD_NEWBB_DEL_ONE);
    echo '<div class="confirmMsg">' . _MD_NEWBB_DEL_ONE . '<br>
          <form method="post" action="' . XOOPS_URL . '/modules/newbb/delete.php">';
    echo _MD_NEWBB_DELEDEDMSG . '<br>';
    echo '<textarea name="post_text" cols="50" rows="5"></textarea><br>';
    echo '<input type="hidden" name="post_id" value="' . htmlspecialchars((string)$post_id, ENT_QUOTES | ENT_HTML5) . '" >';
    echo '<input type="hidden" name="order" value="' . htmlspecialchars((string)$order, ENT_QUOTES | ENT_HTML5) . '" >';
    echo '<input type="hidden" name="forum" value="' . htmlspecialchars((string)$forum, ENT_QUOTES | ENT_HTML5) . '" >';
    echo '<input type="hidden" name="topic_id" value="' . htmlspecialchars((string)$topic_id, ENT_QUOTES | ENT_HTML5) . '" >';
    echo '<input type="hidden" name="ok" value="1" >';
    echo $GLOBALS['xoopsSecurity']->getTokenHTML();
    echo '<input type="submit" name="confirm_submit" value="' . _SUBMIT . '" title="' . _SUBMIT . '">
          <input type="button" name="confirm_back" value="' . _CANCEL . '" onclick="history.go(-1);" title="' . _CANCEL . '" >
          </form>
          </div>';
    if ($isAdmin) {
        xoops_confirm(
            [
                'post_id'  => $post_id,
                'viewmode' => $viewmode,
                'order'    => $order,
                'forum'    => $forum,
                'topic_id' => $topic_id,
                'ok'       => 99,
            ],
            'delete.php',
            _MD_NEWBB_DEL_RELATED
        );
    }
    require_once $GLOBALS['xoops']->path('footer.php');
}