mambax7 / newbb

class/UserstatsHandler.php

<?php declare(strict_types=1);

namespace XoopsModules\Newbb;

/**
 * NewBB,  the forum module for XOOPS project
 *
 * @copyright      XOOPS Project (https://xoops.org)
 * @license        GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Taiwen Jiang (phppp or D.J.) <phppp@users.sourceforge.net>
 * @since          4.00
 */
\defined('NEWBB_FUNCTIONS_INI') || require $GLOBALS['xoops']->path('modules/newbb/include/functions.ini.php');

/**
 * user stats
 */
class UserstatsHandler extends \XoopsPersistableObjectHandler
{
    /**
     * @param \XoopsDatabase|null $db
     */
    public function __construct(\XoopsDatabase $db = null)
    {
        parent::__construct($db, 'newbb_user_stats', Userstats::class, 'uid', '');
    }

    /**
     * @param \XoopsDatabase|null $db
     * @return UserstatsHandler
     */
    public static function getInstance(\XoopsDatabase $db = null): UserstatsHandler
    {
        static $instance;
        if (null === $instance) {
            $instance = new static($db);
        }

        return $instance;
    }

    /**
     * @param mixed $id
     * @param array|null  $fields
     * @return null|\XoopsObject
     */
    public function get($id = null, $fields = null): ?\XoopsObject //get($id)
    {
        $object = null;

The assignment to $object is dead and can be removed.

        if (!$id = (int)$id) {
            return null;
        }
        $object = $this->create(false);
        $object->setVar($this->keyName, $id);
        if (!$row = $this->getStats($id)) {
            return $object;
        }
        $object->assignVars($row);

It seems like $row can also be of type true; however, parameter $var_arr of XoopsObject::assignVars() does only seem to accept array, maybe add an additional type check?

        /*
        $sql = "SELECT * FROM " . $this->table . " WHERE ".$this->keyName." = " . $id;
        if (!$result = $this->db->query($sql)) {
            return $object;
        }
        while (false !== ($row = $this->db->fetchArray($result))) {
            $object->assignVars($row);
        }
        */

        return $object;
    }

    /**
     * @param int $id
     * @return mixed[]|bool
     */
    public function getStats(int $id)
    {
        if (empty($id)) {
            return null;
        }
        $sql = 'SELECT * FROM ' . $this->table . ' WHERE ' . $this->keyName . ' = ' . (int)$id;
        $result = $this->db->query($sql);
        if (!$this->db->isResultSet($result)) {
            return null;
        }

        $row = $this->db->fetchArray($result);

        return $row;
    }
    /*
        function insert(\XoopsObject $object, $force = true)
        {
            if (!$object->isDirty()) {
                $object->setErrors("not isDirty");

                return $object->getVar($this->keyName);
            }
            $this->loadHandler("write");
            if (!$changedVars = $this->_handler["write"]->cleanVars($object)) {
                $object->setErrors("cleanVars failed");

                return $object->getVar($this->keyName);
            }
            $queryFunc = empty($force) ? "query" : "queryF";

            $keys = [];
            foreach ($changedVars as $k => $v) {
                $keys[] = " {$k} = {$v}";
            }
            $sql = "REPLACE INTO " . $this->table . " SET ".implode(",",$keys);
            if (!$result = $this->db->{$queryFunc}($sql)) {
                $object->setErrors("update object error:" . $sql);

                return false;
            }
            unset($changedVars);

            return $object->getVar($this->keyName);
        }
    */
}