xoops_module_update_newbb_v400()

Complexity

Conditions	13
Paths	320

Size

Total Lines	115
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php declare(strict_types=1);
function xoops_module_update_newbb_v400(XoopsModule $module)
{
    $statsHandler = xoops_getModuleHandler('stats', 'newbb');

    $result = $GLOBALS['xoopsDB']->query('SELECT `forum_id`, `forum_topics`, `forum_posts` FROM ' . $GLOBALS['xoopsDB']->prefix('bb_forums'));
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
        $statsHandler->update($row['forum_id'], 'topic', $row['forum_topics']);

The method update() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

        $statsHandler->update($row['forum_id'], 'post', $row['forum_posts']);
    }
    $result = $GLOBALS['xoopsDB']->query('SELECT `forum_id`, SUM(topic_views) AS views FROM ' . $GLOBALS['xoopsDB']->prefix('bb_topics') . ' GROUP BY `forum_id`');
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
        $statsHandler->update($row['forum_id'], 'view', $row['views']);
    }
    $result = $GLOBALS['xoopsDB']->query('SELECT `forum_id`, COUNT(*) AS digests FROM ' . $GLOBALS['xoopsDB']->prefix('bb_topics') . ' WHERE topic_digest = 1 GROUP BY `forum_id`');
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
        $statsHandler->update($row['forum_id'], 'digest', $row['digests']);
    }
    $result = $GLOBALS['xoopsDB']->query('SELECT SUM(forum_topics) AS topics, SUM(forum_posts) AS posts FROM ' . $GLOBALS['xoopsDB']->prefix('bb_forums'));
    while (false !== ($row = $GLOBALS['xoopsDB']->fetchArray($result))) {
        $statsHandler->update(-1, 'topic', $row['topics']);
        $statsHandler->update(-1, 'post', $row['posts']);
    }

    /*
    $GLOBALS['xoopsDB']->queryF(
            "    INSERT INTO ".$GLOBALS['xoopsDB']->prefix("bb_stats").
            "        (`id`, `value`, `type`, `period`, `time_update`, `time_format`)".
            "    SELECT `forum_id`, `forum_topics`, '".NEWBB_STATS_TYPE_TOPIC."', '".NEWBB_STATS_PERIOD_TOTAL."', NOW() + 0, ''".
            "         FROM ".$GLOBALS['xoopsDB']->prefix("bb_forums")
            );
    $GLOBALS['xoopsDB']->queryF(
            "    INSERT INTO ".$GLOBALS['xoopsDB']->prefix("bb_stats").
            "        (`id`, `value`, `type`, `period`, `time_update`, `time_format`)".
            "    SELECT `forum_id`, `forum_posts`, '".NEWBB_STATS_TYPE_POST."', '".NEWBB_STATS_PERIOD_TOTAL."', NOW() + 0, ''".
            "         FROM ".$GLOBALS['xoopsDB']->prefix("bb_forums")
            );
    $GLOBALS['xoopsDB']->queryF(
            "    INSERT INTO ".$GLOBALS['xoopsDB']->prefix("bb_stats").
            "        (`id`, `value`, `type`, `period`, `time_update`, `time_format`)".
            "    SELECT `forum_id`, count(*), '".NEWBB_STATS_TYPE_DIGEST."', '".NEWBB_STATS_PERIOD_TOTAL."', NOW() + 0, ''".
            "         FROM ".$GLOBALS['xoopsDB']->prefix("bb_topics").
            "        WHERE topic_digest = 1".
            "        GROUP BY `forum_id`".
            );
    $GLOBALS['xoopsDB']->queryF(
            "    INSERT INTO ".$GLOBALS['xoopsDB']->prefix("bb_stats").
            "        (`id`, `value`, `type`, `period`, `time_update`, `time_format`)".
            "    SELECT `forum_id`, SUM(topic_views), '".NEWBB_STATS_TYPE_VIEW."', '".NEWBB_STATS_PERIOD_TOTAL."', NOW() + 0, ''".
            "         FROM ".$GLOBALS['xoopsDB']->prefix("bb_topics").
            "        WHERE topic_digest = 1".
            "        GROUP BY `forum_id`".
            );
    */

    $sql = '    UPDATE '
           . $GLOBALS['xoopsDB']->prefix('bb_posts_text')
           . ' AS t, '
           . $GLOBALS['xoopsDB']->prefix('bb_posts')
           . ' AS p'
           . '    SET t.dohtml = p.dohtml, '
           . '        t.dosmiley = p.dosmiley, '
           . '        t.doxcode = p.doxcode, '
           . '        t.doimage = p.doimage, '
           . '        t.dobr = p.dobr'
           . '    WHERE p.post_id =t.post_id ';
    if ($GLOBALS['xoopsDB']->queryF($sql)) {
        $sql = '    ALTER TABLE ' . $GLOBALS['xoopsDB']->prefix('bb_posts') . '        DROP `dohtml`,' . '        DROP `dosmiley`,' . '        DROP `doxcode`,' . '        DROP `doimage`,' . '        DROP `dobr`';
        $GLOBALS['xoopsDB']->queryF($sql);
    } else {
        xoops_error($GLOBALS['xoopsDB']->error() . '<br>' . $sql);
    }

    if (\class_exists(\XoopsModules\Tag\TagHandler::class) && xoops_isActiveModule('tag')) {
        $tagHandler  = \XoopsModules\Tag\Helper::getInstance()->getHandler('Tag');
        $table_topic = $GLOBALS['xoopsDB']->prefix('bb_topics');

        $sql = '    SELECT topic_id, topic_tags' . "    FROM {$table_topic}";
        if (false === ($result = $GLOBALS['xoopsDB']->query($sql))) {
            xoops_error($GLOBALS['xoopsDB']->error());
        }
        if ($result instanceof \mysqli_result) {
            while (false !== ($myrow = $GLOBALS['xoopsDB']->fetchArray($result))) {
                if (empty($myrow['topic_tags'])) {
                    continue;
                }
                $tagHandler->updateByItem($myrow['topic_tags'], $myrow['topic_id'], $module->getVar('mid'));

It seems like $module->getVar('mid') can also be of type array and array; however, parameter $modid of XoopsModules\Tag\TagHandler::updateByItem() does only seem to accept integer|string, maybe add an additional type check?

            }
        }
    }

    if (!$GLOBALS['xoopsDB']->query(
        '
            SELECT COUNT(*)
            FROM ' . $GLOBALS['xoopsDB']->prefix('bb_type_tmp') . ' AS a, ' . $GLOBALS['xoopsDB']->prefix('bb_type_forum_tmp') . ' AS b
            WHERE a.type_id = b.type_id AND a.type_id >0;
        '
    )) {
        //xoops_error($GLOBALS['xoopsDB']->error());
        $GLOBALS['xoopsDB']->queryF('DROP TABLE ' . $GLOBALS['xoopsDB']->prefix('bb_type_tmp'));
        $GLOBALS['xoopsDB']->queryF('DROP TABLE ' . $GLOBALS['xoopsDB']->prefix('bb_type_forum_tmp'));

        return true;
    }

    $GLOBALS['xoopsDB']->queryF(
        '    INSERT INTO ' . $GLOBALS['xoopsDB']->prefix('bb_type') . '        (`type_id`, `type_name`, `type_color`)' . '    SELECT `type_id`, `type_name`, `type_color`' . '         FROM ' . $GLOBALS['xoopsDB']->prefix('bb_type_tmp')
    );
    $GLOBALS['xoopsDB']->queryF(
        '    INSERT INTO ' . $GLOBALS['xoopsDB']->prefix('bb_type_forum') . '        (`type_id`, `forum_id`, `type_order`)' . '    SELECT `type_id`, `forum_id`, `type_order`' . '         FROM ' . $GLOBALS['xoopsDB']->prefix('bb_type_forum_tmp')
    );

    $GLOBALS['xoopsDB']->queryF('DROP TABLE ' . $GLOBALS['xoopsDB']->prefix('bb_type_tmp'));
    $GLOBALS['xoopsDB']->queryF('DROP TABLE ' . $GLOBALS['xoopsDB']->prefix('bb_type_forum_tmp'));

    return true;
}