mambax7 / marquee

plugins/xfsection.php

<?php declare(strict_types=1);
/**
 * ****************************************************************************
 * Marquee - MODULE FOR XOOPS
 * Copyright (c) Hervé Thouzard (https://www.herve-thouzard.com)
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright         Hervé Thouzard (https://www.herve-thouzard.com)
 * @license           GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author            Hervé Thouzard (https://www.herve-thouzard.com)
 *
 * Version :
 * ****************************************************************************
 *
 * @param $limit
 * @param $dateFormat
 * @param $itemsSize
 *
 * @return array
 */

// Script to list recent articles from the xfsection module (tested with xfsection 1.12)
function b_marquee_xfsection($limit, $dateFormat, $itemsSize)
{
    $block = [];
    global $xoopsDB;
    if (!function_exists('xfblock_checkAccess')) {
        require_once XOOPS_ROOT_PATH . '/modules/xfsection/include/xfblock_groupaccess.php';
    }
    $myts   = \MyTextSanitizer::getInstance();

The assignment to $myts is dead and can be removed.

    $sql    = 'SELECT articleid, title, published, expired, counter, groupid, uid FROM ' . $xoopsDB->prefix('xfs_article') . ' WHERE published < ' . time() . ' AND published > 0 AND (expired = 0 OR expired > ' . time() . ') AND noshowart = 0 AND offline = 0 ORDER BY published DESC';
    $result = $xoopsDB->query($sql, $limit, 0);
    if (!$xoopsDB->isResultSet($result)) {
        throw new \RuntimeException(
            \sprintf(_DB_QUERY_ERROR, $sql) . $xoopsDB->error(), E_USER_ERROR);
    }
    while (false !== ($myrow = $xoopsDB->fetchArray($result))) {
        if (xfblock_checkAccess($myrow['groupid'])) {
            $wfs   = [];

The assignment to $wfs is dead and can be removed.

            $title = htmlspecialchars($myrow['title'], ENT_QUOTES | ENT_HTML5);
            if (!XOOPS_USE_MULTIBYTES) {
                if ($itemsSize > 0) {
                    $title = htmlspecialchars(mb_substr($myrow['title'], 0, $itemsSize - 1), ENT_QUOTES | ENT_HTML5);
                } else {
                    $title = htmlspecialchars($myrow['title'], ENT_QUOTES | ENT_HTML5);
                }
            }
            $block[] = [
                'date'     => formatTimestamp($myrow['published'], $dateFormat),
                'category' => '',
                'author'   => \XoopsUser::getUnameFromId($myrow['uid']),
                'title'    => $title,
                'link'     => "<a href='" . XOOPS_URL . '/modules/xfsection/article.php?articleid=' . $myrow['articleid'] . "'>" . $title . '</a>',
            ];
        }
    }

    return $block;
}