xoopspartners.php ➔ xoopspartners_random() - Code Metrics - Inspection of "update for PayPal" - mambax7/marquee - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 66731e...5478d6 )

by Michael

created 2017-03-29 08:36 UTC

xoopspartners.php ➔ xoopspartners_random() C

↳ Parent: Project

Complexity

Conditions	7
Paths	16

Size

Total Lines	31
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	22
nc	16
nop	4
dl	0
loc	31
rs	6.7272
c	0
b	0
f	0

<?php
/**
 * ****************************************************************************
 * Marquee - MODULE FOR XOOPS
 * Copyright (c) Hervé Thouzard (http://www.herve-thouzard.com)
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright         Hervé Thouzard (http://www.herve-thouzard.com)
 * @license           http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package           marquee
 * @author            Hervé Thouzard (http://www.herve-thouzard.com)
 *
 * Version : $Id:
 * ****************************************************************************
 *
 * @param $limit
 * @param $dateFormat
 * @param $itemsSize
 *
 * @return array
 */

// Script to list recent partners from the xoopspartners module (tested with version 1.1)
function b_marquee_xoopspartners($limit, $dateFormat, $itemsSize)

{
    $block    = array();
    $myts     = MyTextSanitizer::getInstance();
    $arrayIds = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $arrayIds = xoopspartners_random($limit);
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    foreach ($arrayIds as $id) {
        $result = $xoopsDB->query('SELECT id, url, image, title FROM ' . $xoopsDB->prefix('partners') . " WHERE id=$id");
        list($id, $url, $image, $title) = $xoopsDB->fetchrow($result);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        $origtitle = $title;
        $title     = $myts->htmlSpecialChars($title);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($itemsSize > 0) {
            $title = $myts->htmlSpecialChars(substr($origtitle, 0, 19));
        } else {
            $title = $myts->htmlSpecialChars($origtitle);
        }

        $block[] = array(
            'date'     => '',
            'category' => '',
            'author'   => '',
            'title'    => $title,
            'link'     => "<a href='" . XOOPS_URL . '/modules/xoopspartners/vpartner.php?id=' . $id . "'>" . $title . '</a>'
        );
    }

    return $block;
}

/**
 * @param        $numberPartners
 * @param bool   $random
 * @param string $orden
 * @param string $desc
 *
 * @return array
 */
function xoopspartners_random($numberPartners, $random = true, $orden = '', $desc = '')
{
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    $PartnersId  = array();
    $ArrayReturn = array();
    $numrows     = 0;
    if ($random) {
        $result  = $xoopsDB->query('SELECT id FROM ' . $xoopsDB->prefix('partners') . ' WHERE status = 1');
        $numrows = $xoopsDB->getRowsNum($result);
    } else {
        $result = $xoopsDB->query('SELECT id FROM ' . $xoopsDB->prefix('partners') . ' Where status = 1 ORDER BY ' . $orden . ' ' . $desc, $numberPartners);
    }
    while ($ret = $xoopsDB->fetchArray($result)) {
        $PartnersId[] = $ret['id'];
    }
    if (($numrows <= $numberPartners) || (!$random)) {
        return $PartnersId;
        //        exit();
    }
    $numberTotal  = 0;
    $totalPartner = count($PartnersId) - 1;
    while ($numberPartners > $numberTotal) {
        $RandomPart = mt_rand(0, $totalPartner);
        if (!in_array($PartnersId[$RandomPart], $ArrayReturn)) {
            $ArrayReturn[] = $PartnersId[$RandomPart];
            ++$numberTotal;
        }
    }

    return $ArrayReturn;
}


Push — master ( 66731e...5478d6 )

xoopspartners.php ➔ xoopspartners_random() C

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* ****************************************************************************
4			* Marquee - MODULE FOR XOOPS
5			* Copyright (c) Hervé Thouzard (http://www.herve-thouzard.com)
6			*
7			* You may not change or alter any portion of this comment or credits
8			* of supporting developers from this source code or any supporting source code
9			* which is considered copyrighted (c) material of the original comment or credit authors.
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13			*
14			* @copyright Hervé Thouzard (http://www.herve-thouzard.com)
15			* @license http://www.fsf.org/copyleft/gpl.html GNU public license
16			* @package marquee
17			* @author Hervé Thouzard (http://www.herve-thouzard.com)
18			*
19			* Version : $Id:
20			* ****************************************************************************
21			*
22			* @param $limit
23			* @param $dateFormat
24			* @param $itemsSize
25			*
26			* @return array
27			*/
28
29			// Script to list recent partners from the xoopspartners module (tested with version 1.1)
30			function b_marquee_xoopspartners($limit, $dateFormat, $itemsSize)
			0 ignored issues – show Unused Code introduced 2016-03-29 11:23 UTC by Report Bug Copy Issue Report The parameter `$dateFormat` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
31			{
32			$block = array();
33			$myts = MyTextSanitizer::getInstance();
34			$arrayIds = array();
			0 ignored issues – show Unused Code introduced 2016-03-27 02:13 UTC by Report Bug Copy Issue Report `$arrayIds` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35			$arrayIds = xoopspartners_random($limit);
36			global $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-03-27 02:13 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
37
38			foreach ($arrayIds as $id) {
39			$result = $xoopsDB->query('SELECT id, url, image, title FROM ' . $xoopsDB->prefix('partners') . " WHERE id=$id");
40			list($id, $url, $image, $title) = $xoopsDB->fetchrow($result);
			0 ignored issues – show Unused Code introduced 2016-03-27 02:13 UTC by Report Bug Copy Issue Report The assignment to `$url` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history... Unused Code introduced 2016-03-27 02:13 UTC by Report Bug Copy Issue Report The assignment to `$image` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
41			$origtitle = $title;
42			$title = $myts->htmlSpecialChars($title);
			0 ignored issues – show Unused Code introduced 2016-03-27 02:13 UTC by Report Bug Copy Issue Report `$title` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
43			if ($itemsSize > 0) {
44			$title = $myts->htmlSpecialChars(substr($origtitle, 0, 19));
45			} else {
46			$title = $myts->htmlSpecialChars($origtitle);
47			}
48
49			$block[] = array(
50			'date' => '',
51			'category' => '',
52			'author' => '',
53			'title' => $title,
54			'link' => "<a href='" . XOOPS_URL . '/modules/xoopspartners/vpartner.php?id=' . $id . "'>" . $title . '</a>'
55			);
56			}
57
58			return $block;
59			}
60
61			/**
62			* @param $numberPartners
63			* @param bool $random
64			* @param string $orden
65			* @param string $desc
66			*
67			* @return array
68			*/
69			function xoopspartners_random($numberPartners, $random = true, $orden = '', $desc = '')
70			{
71			global $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-03-27 02:13 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
72			$PartnersId = array();
73			$ArrayReturn = array();
74			$numrows = 0;
75			if ($random) {
76			$result = $xoopsDB->query('SELECT id FROM ' . $xoopsDB->prefix('partners') . ' WHERE status = 1');
77			$numrows = $xoopsDB->getRowsNum($result);
78			} else {
79			$result = $xoopsDB->query('SELECT id FROM ' . $xoopsDB->prefix('partners') . ' Where status = 1 ORDER BY ' . $orden . ' ' . $desc, $numberPartners);
80			}
81			while ($ret = $xoopsDB->fetchArray($result)) {
82			$PartnersId[] = $ret['id'];
83			}
84			if (($numrows <= $numberPartners) \|\| (!$random)) {
85			return $PartnersId;
86			// exit();
87			}
88			$numberTotal = 0;
89			$totalPartner = count($PartnersId) - 1;
90			while ($numberPartners > $numberTotal) {
91			$RandomPart = mt_rand(0, $totalPartner);
92			if (!in_array($PartnersId[$RandomPart], $ArrayReturn)) {
93			$ArrayReturn[] = $PartnersId[$RandomPart];
94			++$numberTotal;
95			}
96			}
97
98			return $ArrayReturn;
99			}
100

mambax7 / marquee

Push — master ( 66731e...5478d6 )

xoopspartners.php ➔ xoopspartners_random() C

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like