catads.php ➔ b_marquee_catads() - Code Metrics - Inspection of "update for PayPal" - mambax7/marquee - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 66731e...5478d6 )

by Michael

created 2017-03-29 08:36 UTC

catads.php ➔ b_marquee_catads() B

↳ Parent: Project

Complexity

Conditions	7
Paths	4

Size

Total Lines	56
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	44
nc	4
nop	3
dl	0
loc	56
rs	7.7489
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * ****************************************************************************
 * marquee - MODULE FOR XOOPS
 * Copyright (c) Hervé Thouzard (http://www.herve-thouzard.com)
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright         Hervé Thouzard (http://www.herve-thouzard.com)
 * @license           http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package           marquee
 * @author            Hervé Thouzard (http://www.herve-thouzard.com)
 *
 * Version : $Id:
 * ****************************************************************************
 *
 * @param $limit
 * @param $dateFormat
 * @param $itemsSize
 *
 * @return array
 */

// Script to list recent ads from the catads module (tested with catads v 1.4)
function b_marquee_catads($limit, $dateFormat, $itemsSize)
{
    global $xoopsModule, $xoopsModuleConfig, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    include_once XOOPS_ROOT_PATH . '/modules/catads/class/cat.php';
    $block = array();
    if (empty($xoopsModule) || $xoopsModule->getVar('dirname') !== 'catads') {
        $moduleHandler = xoops_getHandler('module');
        $module         = $moduleHandler->getByDirname('catads');
        $configHandler = xoops_getHandler('config');
        $config         =& $configHandler->getConfigsByCat(0, $module->getVar('mid'));
    } else {
        $module =& $xoopsModule;
        $config =& $xoopsModuleConfig;
    }
    //echo '<br />ok';
    $ads_hnd  = xoops_getModuleHandler('ads', 'catads');
    $criteria = new CriteriaCompo(new Criteria('waiting', '0'));
    $criteria->add(new Criteria('published', time(), '<'));
    $criteria->add(new Criteria('expired', time(), '>'));
    $criteria->setSort('published');
    $criteria->setOrder('DESC');
    $criteria->setLimit($limit);
    $nbads = $ads_hnd->getCount($criteria);

    $itemArray     = array();
    $catBuffer = array();

    if ($nbads > 0) {
        $ads  = $ads_hnd->getObjects($criteria);
        $myts = MyTextSanitizer::getInstance();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        foreach ($ads as $oneads) {
            if ($itemsSize > 0) {
                $title = xoops_substr($oneads->getVar('ads_title'), 0, $itemsSize);
            } else {
                $title = $oneads->getVar('ads_title');
            }
            if (!isset($catBuffer[$oneads->getVar('cat_id')])) {
                $tmpcat                                = new AdsCategory($oneads->getVar('cat_id'));
                $catBuffer[$oneads->getVar('cat_id')] = $tmpcat->title();
                $catTitle                             = $tmpcat->title();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            } else {
                $catTitle = $catBuffer[$oneads->getVar('cat_id')];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }
            $block[] = array(
                'date'     => formatTimestamp($oneads->getVar('published'), $dateFormat),
                'category' => '',
                'author'   => XoopsUser::getUnameFromId($oneads->getVar('uid')),
                'title'    => $title,
                'link'     => "<a href='" . XOOPS_URL . '/modules/catads/adsitem.php?ads_id=' . $oneads->getVar('ads_id') . "'>" . $title . '</a>'
            );
            unset($itemArray);
        }
    }

    return $block;
}


Push — master ( 66731e...5478d6 )

catads.php ➔ b_marquee_catads() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* ****************************************************************************
4			* marquee - MODULE FOR XOOPS
5			* Copyright (c) Hervé Thouzard (http://www.herve-thouzard.com)
6			*
7			* You may not change or alter any portion of this comment or credits
8			* of supporting developers from this source code or any supporting source code
9			* which is considered copyrighted (c) material of the original comment or credit authors.
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13			*
14			* @copyright Hervé Thouzard (http://www.herve-thouzard.com)
15			* @license http://www.fsf.org/copyleft/gpl.html GNU public license
16			* @package marquee
17			* @author Hervé Thouzard (http://www.herve-thouzard.com)
18			*
19			* Version : $Id:
20			* ****************************************************************************
21			*
22			* @param $limit
23			* @param $dateFormat
24			* @param $itemsSize
25			*
26			* @return array
27			*/
28
29			// Script to list recent ads from the catads module (tested with catads v 1.4)
30			function b_marquee_catads($limit, $dateFormat, $itemsSize)
31			{
32			global $xoopsModule, $xoopsModuleConfig, $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-03-27 02:13 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
33			include_once XOOPS_ROOT_PATH . '/modules/catads/class/cat.php';
34			$block = array();
35			if (empty($xoopsModule) \|\| $xoopsModule->getVar('dirname') !== 'catads') {
36			$moduleHandler = xoops_getHandler('module');
37			$module = $moduleHandler->getByDirname('catads');
38			$configHandler = xoops_getHandler('config');
39			$config =& $configHandler->getConfigsByCat(0, $module->getVar('mid'));
40			} else {
41			$module =& $xoopsModule;
42			$config =& $xoopsModuleConfig;
43			}
44			//echo '<br />ok';
45			$ads_hnd = xoops_getModuleHandler('ads', 'catads');
46			$criteria = new CriteriaCompo(new Criteria('waiting', '0'));
47			$criteria->add(new Criteria('published', time(), '<'));
48			$criteria->add(new Criteria('expired', time(), '>'));
49			$criteria->setSort('published');
50			$criteria->setOrder('DESC');
51			$criteria->setLimit($limit);
52			$nbads = $ads_hnd->getCount($criteria);
53
54			$itemArray = array();
55			$catBuffer = array();
56
57			if ($nbads > 0) {
58			$ads = $ads_hnd->getObjects($criteria);
59			$myts = MyTextSanitizer::getInstance();
			0 ignored issues – show Unused Code introduced 2016-03-29 11:23 UTC by Report Bug Copy Issue Report `$myts` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
60			foreach ($ads as $oneads) {
61			if ($itemsSize > 0) {
62			$title = xoops_substr($oneads->getVar('ads_title'), 0, $itemsSize);
63			} else {
64			$title = $oneads->getVar('ads_title');
65			}
66			if (!isset($catBuffer[$oneads->getVar('cat_id')])) {
67			$tmpcat = new AdsCategory($oneads->getVar('cat_id'));
68			$catBuffer[$oneads->getVar('cat_id')] = $tmpcat->title();
69			$catTitle = $tmpcat->title();
			0 ignored issues – show Unused Code introduced 2016-03-29 11:23 UTC by Report Bug Copy Issue Report `$catTitle` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
70			} else {
71			$catTitle = $catBuffer[$oneads->getVar('cat_id')];
			0 ignored issues – show Unused Code introduced 2016-03-29 11:23 UTC by Report Bug Copy Issue Report `$catTitle` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
72			}
73			$block[] = array(
74			'date' => formatTimestamp($oneads->getVar('published'), $dateFormat),
75			'category' => '',
76			'author' => XoopsUser::getUnameFromId($oneads->getVar('uid')),
77			'title' => $title,
78			'link' => "<a href='" . XOOPS_URL . '/modules/catads/adsitem.php?ads_id=' . $oneads->getVar('ads_id') . "'>" . $title . '</a>'
79			);
80			unset($itemArray);
81			}
82			}
83
84			return $block;
85			}
86

mambax7 / marquee

Push — master ( 66731e...5478d6 )

catads.php ➔ b_marquee_catads() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like