b_marquee_show() - Code Metrics - Inspection of "updates" - mambax7/marquee - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( dcbd4a...4bb7b0 )

by Michael

created 2018-04-01 09:40 UTC

b_marquee_show() B

↳ Parent: Project

Complexity

Conditions	4
Paths	4

Size

Total Lines	30
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	22
c	0
b	0
f	0
nc	4
nop	1
dl	0
loc	30
rs	8.5806

<?php
/**
 * ****************************************************************************
 * marquee - MODULE FOR XOOPS
 * Copyright (c) Hervé Thouzard (http://www.herve-thouzard.com)
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright         Hervé Thouzard (http://www.herve-thouzard.com)
 * @license           http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package           marquee
 * @author            Hervé Thouzard (http://www.herve-thouzard.com)
 *
 * Version :
 * ****************************************************************************
 *
 * @param $options
 *
 * @return array
 */

use XoopsModules\Marquee;

/**
 * @param $options
 * @return array
 */
function b_marquee_show($options)
{
    global $xoopsTpl;
function myFunction($a, $b) {
    // Do something
}
    $marquee = null;

//    require_once XOOPS_ROOT_PATH . '/modules/marquee/class/Utility.php';
    $marqueeHandler = XoopsModules\Marquee\Helper::getInstance()->getHandler('Marqueex');
    $block          = [];
    $marqueeId      = (int)$options[0];
    if ($marqueeId > 0) {
        /** @var Marquee\Marqueex $marquee */
        $marquee = $marqueeHandler->get($marqueeId);
        if (is_object($marquee)) {
            $uniqid = md5(uniqid(mt_rand(), true));
            if ('DHTML' === Marquee\Utility::getModuleOption('methodtouse')) {

                $link = '<script type="text/javascript" src="' . XOOPS_URL . '/modules/marquee/assets/js/xbMarquee.js"></script>';

                $link .= "\n<script type=\"text/javascript\">\n";
                $link .= 'var marquee' . $uniqid . ";\n";
                $link .= "var html$uniqid = '';\n";
                $link .= "function init_$uniqid()\n";
                $link .= "{\n";
                $link .= "\tmarquee$uniqid.start();\n";
                $link .= "}\n";
                $link .= "</script>\n";
                $xoopsTpl->assign('xoops_module_header', $link);
            }
            $block['marqueecode'] = $marquee->constructMarquee($uniqid);
        }
    }

    return $block;
}

/**
 * @param $options
 *
 * @return string
 */
function b_marquee_edit($options)
{
    /** @var Marquee\MarqueexHandler $marqueeHandler */
    $marqueeHandler = Marquee\Helper::getInstance()->getHandler('Marqueex');
    $form           = "<table border='0'>";
    $form           .= '<tr><td>' . _MB_MARQUEE_SELECT . "</td><td><select name='options[0]'>" . $marqueeHandler->getHtmlMarqueesList($options[0]) . '</select></td></tr>';
    $form           .= '</table>';

    return $form;
}

/*
 * Block on the fly
 */
/**
 * @param $options
 */
function b_marquee_custom($options)
{
    $options = explode('|', $options);
    $block   = b_marquee_show($options);

    $tpl = new \XoopsTpl();
filter:
    dependency_paths: ["lib/*"]
    $tpl->assign('block', $block);
    $tpl->display('db:marquee_block.tpl');
}


1			<?php
2			/**
3			* ****************************************************************************
4			* marquee - MODULE FOR XOOPS
5			* Copyright (c) Hervé Thouzard (http://www.herve-thouzard.com)
6			*
7			* You may not change or alter any portion of this comment or credits
8			* of supporting developers from this source code or any supporting source code
9			* which is considered copyrighted (c) material of the original comment or credit authors.
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13			*
14			* @copyright Hervé Thouzard (http://www.herve-thouzard.com)
15			* @license http://www.fsf.org/copyleft/gpl.html GNU public license
16			* @package marquee
17			* @author Hervé Thouzard (http://www.herve-thouzard.com)
18			*
19			* Version :
20			* ****************************************************************************
21			*
22			* @param $options
23			*
24			* @return array
25			*/
26
27			use XoopsModules\Marquee;
28
29			/**
30			* @param $options
31			* @return array
32			*/
33			function b_marquee_show($options)
34			{
35			global $xoopsTpl;
			0 ignored issues – show Compatibility Best Practice introduced 2018-01-14 03:22 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
36			$marquee = null;
			0 ignored issues – show Unused Code introduced 2018-04-01 09:43 UTC by Report Bug Copy Issue Report The assignment to `$marquee` is dead and can be removed. Loading history...
37			// require_once XOOPS_ROOT_PATH . '/modules/marquee/class/Utility.php';
38			$marqueeHandler = XoopsModules\Marquee\Helper::getInstance()->getHandler('Marqueex');
39			$block = [];
40			$marqueeId = (int)$options[0];
41			if ($marqueeId > 0) {
42			/** @var Marquee\Marqueex $marquee */
43			$marquee = $marqueeHandler->get($marqueeId);
44			if (is_object($marquee)) {
45			$uniqid = md5(uniqid(mt_rand(), true));
46			if ('DHTML' === Marquee\Utility::getModuleOption('methodtouse')) {
			0 ignored issues – show introduced 2018-04-01 09:43 UTC by Report Bug Copy Issue Report The condition `'DHTML' === XoopsModules...leOption('methodtouse')` is always `false`. Loading history...
47			$link = '<script type="text/javascript" src="' . XOOPS_URL . '/modules/marquee/assets/js/xbMarquee.js"></script>';
			0 ignored issues – show Bug introduced 2018-04-01 09:43 UTC by Report Bug Copy Issue Report The constant `XOOPS_URL` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
48			$link .= "\n<script type=\"text/javascript\">\n";
49			$link .= 'var marquee' . $uniqid . ";\n";
50			$link .= "var html$uniqid = '';\n";
51			$link .= "function init_$uniqid()\n";
52			$link .= "{\n";
53			$link .= "\tmarquee$uniqid.start();\n";
54			$link .= "}\n";
55			$link .= "</script>\n";
56			$xoopsTpl->assign('xoops_module_header', $link);
57			}
58			$block['marqueecode'] = $marquee->constructMarquee($uniqid);
59			}
60			}
61
62			return $block;
63			}
64
65			/**
66			* @param $options
67			*
68			* @return string
69			*/
70			function b_marquee_edit($options)
71			{
72			/** @var Marquee\MarqueexHandler $marqueeHandler */
73			$marqueeHandler = Marquee\Helper::getInstance()->getHandler('Marqueex');
74			$form = "<table border='0'>";
75			$form .= '<tr><td>' . _MB_MARQUEE_SELECT . "</td><td><select name='options[0]'>" . $marqueeHandler->getHtmlMarqueesList($options[0]) . '</select></td></tr>';
76			$form .= '</table>';
77
78			return $form;
79			}
80
81			/*
82			* Block on the fly
83			*/
84			/**
85			* @param $options
86			*/
87			function b_marquee_custom($options)
88			{
89			$options = explode('\|', $options);
90			$block = b_marquee_show($options);
91
92			$tpl = new \XoopsTpl();
			0 ignored issues – show Bug introduced 2018-04-01 09:43 UTC by Report Bug Copy Issue Report The type `XoopsTpl` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
93			$tpl->assign('block', $block);
94			$tpl->display('db:marquee_block.tpl');
95			}
96

mambax7 / marquee

Push — master ( dcbd4a...4bb7b0 )

b_marquee_show() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like