Issues in Category.php (master) - Issues in master - mambax7/instruction - Measure and Improve Code Quality continuously with Scrutinizer

Issues (175)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/Category.php (17 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Xoopsmodules\instruction;

//if (!defined("XOOPS_ROOT_PATH")) {

//	die("XOOPS root path not defined");
//}

//include_once $GLOBALS['xoops']->path('include/common.php');


//include_once __DIR__ . '/Utility.php';

//include_once __DIR__ . '/CategoryHandler.php';
//include_once __DIR__ . '/Helper.php';

/**
 * Class Category
 * @package Xoopsmodules\instruction
 */
class Category extends \XoopsObject
{
    // constructor
    public function __construct()
    {
        //		$this->XoopsObject();

        $this->initVar('cid', XOBJ_DTYPE_INT, null, false, 5);
        $this->initVar('pid', XOBJ_DTYPE_INT, 0, false, 5);
        $this->initVar('title', XOBJ_DTYPE_TXTBOX, '', false);
        $this->initVar('imgurl', XOBJ_DTYPE_TXTBOX, '', false);
        $this->initVar('description', XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar('weight', XOBJ_DTYPE_INT, 0, false, 11);
        $this->initVar('datecreated', XOBJ_DTYPE_INT, 0, false, 10);
        $this->initVar('dateupdated', XOBJ_DTYPE_INT, 0, false, 10);
        $this->initVar('metakeywords', XOBJ_DTYPE_TXTBOX, '', false);
        $this->initVar('metadescription', XOBJ_DTYPE_TXTBOX, '', false);
    }

    /**
     * @return mixed
     */
    public function getNewInstertId()
    {
        $newEnreg = $GLOBALS['xoopsDB']->getInsertId();
        return $newEnreg;
    }

    // Получаем форму

    /**
     * @param bool|null|string $action
     * @return \XoopsThemeForm
     */
    public function getForm($action = false)
    {
        //global $xoopsDB, $xoopsModule, $xoopsModuleConfig;

        require_once __DIR__ . '/../include/common.php';
        // Если нет $action
        if (false === $action) {
            $action = xoops_getenv('REQUEST_URI');
        }
        // Подключаем формы
        include_once $GLOBALS['xoops']->path('class/xoopsformloader.php');

        // Название формы
        $title = $this->isNew() ? sprintf(_AM_INSTRUCTION_FORMADDCAT) : sprintf(_AM_INSTRUCTION_FORMEDITCAT);

        // Форма
        $form = new \XoopsThemeForm($title, 'formcat', $action, 'post', true);
        //$form->setExtra('enctype="multipart/form-data"');

        // Название категории
        $form->addElement(new \XoopsFormText(_AM_INSTRUCTION_TITLEC, 'title', 50, 255, $this->getVar('title')), true);
        // Редактор
        $form->addElement(new \XoopsFormTextArea(_AM_INSTRUCTION_DSCC, 'description', $this->getVar('description', 'e')), true);
        //image
        /*

        $downloadscat_img = $this->getVar('imgurl') ? $this->getVar('imgurl') : 'blank.gif';
        $uploadirectory='/uploads/tdmdownloads/images/cats';
        $imgtray = new \XoopsFormElementTray(_AM_TDMDOWNLOADS_FORMIMG,'<br>');
        $imgpath=sprintf(_AM_TDMDOWNLOADS_FORMPATH, $uploadirectory );
        $imageselect= new \XoopsFormSelect($imgpath, 'downloadscat_img',$downloadscat_img);
        $topics_array = XoopsLists :: getImgListAsArray( XOOPS_ROOT_PATH . $uploadirectory );
        foreach( $topics_array as $image ) {
            $imageselect->addOption("$image", $image);
        }
        $imageselect->setExtra( "onchange='showImgSelected(\"image3\", \"downloadscat_img\", \"" . $uploadirectory . "\", \"\", \"" . XOOPS_URL . "\")'" );
        $imgtray->addElement($imageselect,false);
        $imgtray -> addElement( new \XoopsFormLabel( '', "<br><img src='" . XOOPS_URL . "/" . $uploadirectory . "/" . $downloadscat_img . "' name='image3' id='image3' alt='' >" ) );
        $fileseltray= new \XoopsFormElementTray('','<br>');
        $fileseltray->addElement(new \XoopsFormFile(_AM_TDMDOWNLOADS_FORMUPLOAD , 'attachedfile', $xoopsModuleConfig['maxuploadsize']), false);
        $fileseltray->addElement(new \XoopsFormLabel('' ), false);
        $imgtray->addElement($fileseltray);
        $form->addElement($imgtray);
        */
        // Родительская категория
        //        $categoryHandler = xoops_getModuleHandler('category', 'instruction');

        $criteria = new \CriteriaCompo();
        // Если мы редактируем, то убрать текущую категорию из списка выбора родительской
        if (!$this->isNew()) {
            $criteria->add(new \Criteria('cid', $this->getVar('cid'), '<>'));
        }
        $criteria->setSort('weight ASC, title');
        $criteria->setOrder('ASC');

        $categoryHandler    = new CategoryHandler;
        $instructioncat_arr = $categoryHandler->getall($criteria);
        unset($criteria);
        // Подключаем трей
        include_once $GLOBALS['xoops']->path('class/tree.php');
        $mytree = new \XoopsObjectTree($instructioncat_arr, 'cid', 'pid');

        // $form->addElement(new \XoopsFormLabel(_AM_INSTRUCTION_PCATC, $mytree->makeSelBox('pid', 'title', '--', $this->getVar('pid'), true)));


        $helper = Helper::getInstance();
        $module = $helper->getModule();

        if (Utility::checkVerXoops($module, '2.5.9')) {

            $mytree_select = $mytree->makeSelectElement('pid', 'title', '--', $this->getVar('pid'), true, 0, '', _AM_INSTRUCTION_PCATC);
            $form->addElement($mytree_select);
        } else {
            $form->addElement(new \XoopsFormLabel(_AM_INSTRUCTION_PCATC, $mytree->makeSelBox('pid', 'title', '--', $this->getVar('pid'), true)));
        }

        // Вес
        $form->addElement(new \XoopsFormText(_AM_INSTRUCTION_WEIGHTC, 'weight', 5, 5, $this->getVar('weight')), true);
        // Мета-теги ключевых слов
        $form->addElement(new \XoopsFormText(_AM_INSTRUCTION_METAKEYWORDSC, 'metakeywords', 50, 255, $this->getVar('metakeywords')), false);
        // Мета-теги описания
        $form->addElement(new \XoopsFormText(_AM_INSTRUCTION_METADESCRIPTIONC, 'metadescription', 50, 255, $this->getVar('metadescription')), false);

        // ==========================================================
        // ==========================================================

        // Права
        $memberHandler = xoops_getHandler('member');
        $group_list    = $memberHandler->getGroupList();
        $gpermHandler  = xoops_getHandler('groupperm');
        $full_list     = array_keys($group_list);

        // Права на просмотр
        $groups_ids = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        // Если мы редактируем
        if (!$this->isNew()) {

            $groups_ids        = $gpermHandler->getGroupIds('instruction_view', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
            $groups_ids        = array_values($groups_ids);
            $groups_instr_view = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_VIEW, 'groups_instr_view', $groups_ids);
        } else {
            $groups_instr_view = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_VIEW, 'groups_instr_view', $full_list);
        }
        $groups_instr_view->addOptionArray($group_list);
        $form->addElement($groups_instr_view);

        // Права на отправку
        $groups_ids = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (!$this->isNew()) {

            $groups_ids          = $gpermHandler->getGroupIds('instruction_submit', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
            $groups_ids          = array_values($groups_ids);
            $groups_instr_submit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_SUBMIT, 'groups_instr_submit', $groups_ids);
        } else {
            $groups_instr_submit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_SUBMIT, 'groups_instr_submit', $full_list);
        }
        $groups_instr_submit->addOptionArray($group_list);
        $form->addElement($groups_instr_submit);

        // Права на редактирование
        $groups_ids = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (!$this->isNew()) {

            $groups_ids        = $gpermHandler->getGroupIds('instruction_edit', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
            $groups_ids        = array_values($groups_ids);
            $groups_instr_edit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_EDIT, 'groups_instr_edit', $groups_ids);
        } else {
            $groups_instr_edit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_EDIT, 'groups_instr_edit', $full_list);
        }
        $groups_instr_edit->addOptionArray($group_list);
        $form->addElement($groups_instr_edit);

        // ==========================================================
        // ==========================================================

        // Если мы редактируем категорию
        if (!$this->isNew()) {
            $form->addElement(new \XoopsFormHidden('cid', $this->getVar('cid')));
            //$form->addElement( new \XoopsFormHidden( 'catmodify', true));

        }
        //
        $form->addElement(new \XoopsFormHidden('op', 'savecat'));
        // Кнопка
        $button_tray = new \XoopsFormElementTray('', '');
        $submit_btn  = new \XoopsFormButton('', 'submit', _SUBMIT, 'submit');
        $button_tray->addElement($submit_btn);
        $cancel_btn = new \XoopsFormButton('', 'cancel', _CANCEL, 'cancel');
        $cancel_btn->setExtra('onclick="javascript:history.go(-1);"');
        $button_tray->addElement($cancel_btn);
        $form->addElement($button_tray);

        return $form;
    }
}


1		<?php namespace Xoopsmodules\instruction;
2
3		//if (!defined("XOOPS_ROOT_PATH")) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
4		// die("XOOPS root path not defined");
5		//}
6
7		//include_once $GLOBALS['xoops']->path('include/common.php');
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-09 08:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `84%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
8
9		//include_once __DIR__ . '/Utility.php';
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-09 08:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `47%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
10		//include_once __DIR__ . '/CategoryHandler.php';
11		//include_once __DIR__ . '/Helper.php';
12
13		/**
14		* Class Category
15		* @package Xoopsmodules\instruction
16		*/
17		class Category extends \XoopsObject
18		{
19		// constructor
20		public function __construct()
21		{
22		// $this->XoopsObject();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
23		$this->initVar('cid', XOBJ_DTYPE_INT, null, false, 5);
24		$this->initVar('pid', XOBJ_DTYPE_INT, 0, false, 5);
25		$this->initVar('title', XOBJ_DTYPE_TXTBOX, '', false);
26		$this->initVar('imgurl', XOBJ_DTYPE_TXTBOX, '', false);
27		$this->initVar('description', XOBJ_DTYPE_TXTAREA, null, false);
28		$this->initVar('weight', XOBJ_DTYPE_INT, 0, false, 11);
29		$this->initVar('datecreated', XOBJ_DTYPE_INT, 0, false, 10);
30		$this->initVar('dateupdated', XOBJ_DTYPE_INT, 0, false, 10);
31		$this->initVar('metakeywords', XOBJ_DTYPE_TXTBOX, '', false);
32		$this->initVar('metadescription', XOBJ_DTYPE_TXTBOX, '', false);
33		}
34
35		/**
36		* @return mixed
37		*/
38		public function getNewInstertId()
39		{
40		$newEnreg = $GLOBALS['xoopsDB']->getInsertId();
41		return $newEnreg;
42		}
43
44		// Получаем форму
45
46		/**
47		* @param bool\|null\|string $action
48		* @return \XoopsThemeForm
49		*/
50		public function getForm($action = false)
51		{
52		//global $xoopsDB, $xoopsModule, $xoopsModuleConfig;
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
53		require_once __DIR__ . '/../include/common.php';
54		// Если нет $action
55		if (false === $action) {
56		$action = xoops_getenv('REQUEST_URI');
57		}
58		// Подключаем формы
59		include_once $GLOBALS['xoops']->path('class/xoopsformloader.php');
60
61		// Название формы
62		$title = $this->isNew() ? sprintf(_AM_INSTRUCTION_FORMADDCAT) : sprintf(_AM_INSTRUCTION_FORMEDITCAT);
63
64		// Форма
65		$form = new \XoopsThemeForm($title, 'formcat', $action, 'post', true);
66		//$form->setExtra('enctype="multipart/form-data"');
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
67		// Название категории
68		$form->addElement(new \XoopsFormText(_AM_INSTRUCTION_TITLEC, 'title', 50, 255, $this->getVar('title')), true);
69		// Редактор
70		$form->addElement(new \XoopsFormTextArea(_AM_INSTRUCTION_DSCC, 'description', $this->getVar('description', 'e')), true);
71		//image
72		/*
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
73		$downloadscat_img = $this->getVar('imgurl') ? $this->getVar('imgurl') : 'blank.gif';
74		$uploadirectory='/uploads/tdmdownloads/images/cats';
75		$imgtray = new \XoopsFormElementTray(_AM_TDMDOWNLOADS_FORMIMG,'<br>');
76		$imgpath=sprintf(_AM_TDMDOWNLOADS_FORMPATH, $uploadirectory );
77		$imageselect= new \XoopsFormSelect($imgpath, 'downloadscat_img',$downloadscat_img);
78		$topics_array = XoopsLists :: getImgListAsArray( XOOPS_ROOT_PATH . $uploadirectory );
79		foreach( $topics_array as $image ) {
80		$imageselect->addOption("$image", $image);
81		}
82		$imageselect->setExtra( "onchange='showImgSelected(\"image3\", \"downloadscat_img\", \"" . $uploadirectory . "\", \"\", \"" . XOOPS_URL . "\")'" );
83		$imgtray->addElement($imageselect,false);
84		$imgtray -> addElement( new \XoopsFormLabel( '', "<br><img src='" . XOOPS_URL . "/" . $uploadirectory . "/" . $downloadscat_img . "' name='image3' id='image3' alt='' >" ) );
85		$fileseltray= new \XoopsFormElementTray('','<br>');
86		$fileseltray->addElement(new \XoopsFormFile(_AM_TDMDOWNLOADS_FORMUPLOAD , 'attachedfile', $xoopsModuleConfig['maxuploadsize']), false);
87		$fileseltray->addElement(new \XoopsFormLabel('' ), false);
88		$imgtray->addElement($fileseltray);
89		$form->addElement($imgtray);
90		*/
91		// Родительская категория
92		// $categoryHandler = xoops_getModuleHandler('category', 'instruction');
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
93		$criteria = new \CriteriaCompo();
94		// Если мы редактируем, то убрать текущую категорию из списка выбора родительской
95		if (!$this->isNew()) {
96		$criteria->add(new \Criteria('cid', $this->getVar('cid'), '<>'));
97		}
98		$criteria->setSort('weight ASC, title');
99		$criteria->setOrder('ASC');
100
101		$categoryHandler = new CategoryHandler;
102		$instructioncat_arr = $categoryHandler->getall($criteria);
103		unset($criteria);
104		// Подключаем трей
105		include_once $GLOBALS['xoops']->path('class/tree.php');
106		$mytree = new \XoopsObjectTree($instructioncat_arr, 'cid', 'pid');
107
108		// $form->addElement(new \XoopsFormLabel(_AM_INSTRUCTION_PCATC, $mytree->makeSelBox('pid', 'title', '--', $this->getVar('pid'), true)));
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-03 09:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this `69%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
109
110		$helper = Helper::getInstance();
111		$module = $helper->getModule();
112
113	View Code Duplication	if (Utility::checkVerXoops($module, '2.5.9')) {
		0 ignored issues – show Duplication introduced 2017-10-09 08:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
114		$mytree_select = $mytree->makeSelectElement('pid', 'title', '--', $this->getVar('pid'), true, 0, '', _AM_INSTRUCTION_PCATC);
115		$form->addElement($mytree_select);
116		} else {
117		$form->addElement(new \XoopsFormLabel(_AM_INSTRUCTION_PCATC, $mytree->makeSelBox('pid', 'title', '--', $this->getVar('pid'), true)));
118		}
119
120		// Вес
121		$form->addElement(new \XoopsFormText(_AM_INSTRUCTION_WEIGHTC, 'weight', 5, 5, $this->getVar('weight')), true);
122		// Мета-теги ключевых слов
123		$form->addElement(new \XoopsFormText(_AM_INSTRUCTION_METAKEYWORDSC, 'metakeywords', 50, 255, $this->getVar('metakeywords')), false);
124		// Мета-теги описания
125		$form->addElement(new \XoopsFormText(_AM_INSTRUCTION_METADESCRIPTIONC, 'metadescription', 50, 255, $this->getVar('metadescription')), false);
126
127		// ==========================================================
128		// ==========================================================
129
130		// Права
131		$memberHandler = xoops_getHandler('member');
132		$group_list = $memberHandler->getGroupList();
133		$gpermHandler = xoops_getHandler('groupperm');
134		$full_list = array_keys($group_list);
135
136		// Права на просмотр
137		$groups_ids = [];
		0 ignored issues – show Unused Code introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$groups_ids` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
138		// Если мы редактируем
139	View Code Duplication	if (!$this->isNew()) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
140		$groups_ids = $gpermHandler->getGroupIds('instruction_view', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
141		$groups_ids = array_values($groups_ids);
142		$groups_instr_view = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_VIEW, 'groups_instr_view', $groups_ids);
143		} else {
144		$groups_instr_view = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_VIEW, 'groups_instr_view', $full_list);
145		}
146		$groups_instr_view->addOptionArray($group_list);
147		$form->addElement($groups_instr_view);
148
149		// Права на отправку
150		$groups_ids = [];
		0 ignored issues – show Unused Code introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$groups_ids` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
151	View Code Duplication	if (!$this->isNew()) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		$groups_ids = $gpermHandler->getGroupIds('instruction_submit', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
153		$groups_ids = array_values($groups_ids);
154		$groups_instr_submit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_SUBMIT, 'groups_instr_submit', $groups_ids);
155		} else {
156		$groups_instr_submit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_SUBMIT, 'groups_instr_submit', $full_list);
157		}
158		$groups_instr_submit->addOptionArray($group_list);
159		$form->addElement($groups_instr_submit);
160
161		// Права на редактирование
162		$groups_ids = [];
		0 ignored issues – show Unused Code introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$groups_ids` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
163	View Code Duplication	if (!$this->isNew()) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
164		$groups_ids = $gpermHandler->getGroupIds('instruction_edit', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
165		$groups_ids = array_values($groups_ids);
166		$groups_instr_edit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_EDIT, 'groups_instr_edit', $groups_ids);
167		} else {
168		$groups_instr_edit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_EDIT, 'groups_instr_edit', $full_list);
169		}
170		$groups_instr_edit->addOptionArray($group_list);
171		$form->addElement($groups_instr_edit);
172
173		// ==========================================================
174		// ==========================================================
175
176		// Если мы редактируем категорию
177		if (!$this->isNew()) {
178		$form->addElement(new \XoopsFormHidden('cid', $this->getVar('cid')));
179		//$form->addElement( new \XoopsFormHidden( 'catmodify', true));
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `65%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
180		}
181		//
182		$form->addElement(new \XoopsFormHidden('op', 'savecat'));
183		// Кнопка
184		$button_tray = new \XoopsFormElementTray('', '');
185		$submit_btn = new \XoopsFormButton('', 'submit', _SUBMIT, 'submit');
186		$button_tray->addElement($submit_btn);
187		$cancel_btn = new \XoopsFormButton('', 'cancel', _CANCEL, 'cancel');
188		$cancel_btn->setExtra('onclick="javascript:history.go(-1);"');
189		$button_tray->addElement($cancel_btn);
190		$form->addElement($button_tray);
191
192		return $form;
193		}
194		}
195

mambax7 / instruction

Issues (175)

Security Analysis no request data

class/Category.php (17 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like