Issues in ajax.php (master) - Issues in master - mambax7/instruction - Measure and Improve Code Quality continuously with Scrutinizer

Issues (175)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

admin/ajax.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Xmf\Request;
use Xoopsmodules\instruction;

//
include __DIR__ . '/admin_header.php';
// Функции модуля
//include __DIR__ . '/../class/utility.php';
// Отключаем дебугер
$GLOBALS['xoopsLogger']->activated = false;

// Объявляем объекты

//$instructionHandler = xoops_getModuleHandler('instruction', 'instruction');
//$categoryHandler   = xoops_getModuleHandler('category', 'instruction');
//$pageHandler  = xoops_getModuleHandler('page', 'instruction');

$uid  = ($GLOBALS['xoopsUser'] instanceof \XoopsUser) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
if ($x instanceof DoesNotExist) {
    // Do something.
}
$time = time();

// Опция
$op = Request::getString('op', 'main', 'POST');

// Выбор
switch ($op) {
    // Сохранение страницы
    case 'savepage':
        // Выходной массив
        $ret = [];

        // Ошибки
        $err         = false;
        $message_err = '';

        //
        $title       = Request::getString('title', '', 'POST');
        $pid         = Request::getInt('pid', 0, 'POST');
        $weight      = Request::getInt('weight', 0, 'POST');
        $hometext    = Request::getString('hometext', '', 'POST');
        $footnote    = Request::getString('footnote', '', 'POST');
        $status      = Request::getInt('status', 0, 'POST');
        $type        = Request::getInt('type', 0, 'POST');
        $keywords    = Request::getString('keywords', '', 'POST');
        $description = Request::getString('description', '', 'POST');
        $dosmiley    = (Request::getInt('dosmiley', 0, 'POST') > 0) ? 1 : 0;
        $doxcode     = (Request::getInt('doxcode', 0, 'POST') > 0) ? 1 : 0;
        $dobr        = (Request::getInt('dobr', 0, 'POST') > 0) ? 1 : 0;
        $dohtml      = (Request::getInt('dohtml', 0, 'POST') > 0) ? 1 : 0;
        //$dohtml      = Request::getInt( 'dohtml', 0, 'POST' );

        //$dosmiley    = Request::getInt( 'dosmiley', 0, 'POST' );

        //$doxcode     = Request::getInt( 'doxcode', 0, 'POST' );

        //$dobr        = Request::getInt( 'dobr', 0, 'POST' );

        $pageid  = Request::getInt('pageid', 0, 'POST');
        $instrid = Request::getInt('instrid', 0, 'POST');

        // Проверка
        if (!$GLOBALS['xoopsSecurity']->check()) {

            $err         = true;
            $err_txt     = implode(', ', $GLOBALS['xoopsSecurity']->getErrors());
            $message_err .= $err_txt . '<br>' . _AM_INSTR_TRY_AGAIN . '<br>';
        }
        // =========================
        // Устанавливаем новый token
        $token_name    = 'XOOPS_TOKEN';
        $token_timeout = 0;
        // $token_name . '_REQUEST' - название элемента формы
        $ret['toket'] = $GLOBALS['xoopsSecurity']->createToken($token_timeout, $token_name);
        // =========================

        // Если мы редактируем
        if ($pageid) {

            $objInspage = $pageHandler->get($pageid);
        } elseif ($instrid) {
            $objInspage = $pageHandler->create();
            // Если мы создаём страницу необходимо указать к какой инструкции
            $objInspage->setVar('instrid', $instrid);
            // Указываем дату создания
            $objInspage->setVar('datecreated', $time);
            // Указываем пользователя
            $objInspage->setVar('uid', $uid);
        } else {
            // Устанавливаем сообщение
            $ret['message'] = _AM_INSTRUCTION_BADREQUEST;
            // Возвращаем ответ скрипту через JSON
            echo json_encode($ret);
            // Прерываем выполнение
            exit();
        }

        // Родительская страница
        $objInspage->setVar('pid', $pid);
        // Дата обновления
        $objInspage->setVar('dateupdated', $time);
        // Название
        $objInspage->setVar('title', $title);
        // Вес
        $objInspage->setVar('weight', $weight);
        // Текст
        $objInspage->setVar('hometext', $hometext);
        // Сноска
        $objInspage->setVar('footnote', $footnote);
        // Статус
        $objInspage->setVar('status', $status);
        // Тип
        $objInspage->setVar('type', $type);
        // Мета-теги ключевых слов
        $objInspage->setVar('keywords', $keywords);
        // Мета-теги описания
        $objInspage->setVar('description', $description);
        //
        $objInspage->setVar('dohtml', $dohtml);
        $objInspage->setVar('dosmiley', $dosmiley);
        $objInspage->setVar('doxcode', $doxcode);
        $objInspage->setVar('dobr', $dobr);

        // Проверка категорий
        if (!$pageid && !$instrid) {

            $err         = true;
            $message_err .= _AM_INSTRUCTION_ERR_INSTR . '<br>';
        }
        // Проверка веса
        if (0 == $weight) {
            $err         = true;
            $message_err .= _AM_INSTRUCTION_ERR_WEIGHT . '<br>';
        }
        // Проверка родительской страницы
        if ($pageid && ($pageid == $pid)) {

            $err         = true;
            $message_err .= _AM_INSTRUCTION_ERR_PPAGE . '<br>';
        }
        // Проверка названия
        if (!$title) {
            $err         = true;
            $message_err .= _AM_INSTR_ERR_TITLE . '<br>';
        }
        // Проверка основного текста
        if (!$hometext) {
            $err         = true;
            $message_err .= _AM_INSTR_ERR_HOMETEXT . '<br>';
        }

        // Если были ошибки
        if (true === $err) {
            //
            $message_err = '<div class="errorMsg" style="text-align: left;">' . $message_err . '</div>';
            // Устанавливаем сообщение
            $ret['message'] = $message_err;
            // Возвращаем ответ скрипту через JSON
            echo json_encode($ret);
            // Прерываем выполнение
            exit();
            // Если небыло ошибок
        } else {
            // Вставляем данные в БД
            if ($pageHandler->insert($objInspage)) {
                // Находим ID созданной записи
                $pageid_new = $pageid ?: $objInspage->getNewInstertId();
                //
                $ret['pageid'] = $pageid_new;
                // Получаем ID инструкции
                $instrid = $objInspage->getInstrid();
                // Обновляем в инструкции число страниц и дату
                $instructionHandler->updatePages($instrid);
                // Если мы редактируем
                if ($pageid) {
                    // Устанавливаем сообщение
                    $ret['message'] = '<div class="successMsg" style="text-align: left;">' . _AM_INSTRUCTION_PAGEMODIFY . '</div>';
                    // Возвращаем ответ скрипту через JSON
                    echo json_encode($ret);
                    // Прерываем выполнение
                    exit();

                    // Если мы добавляем
                } else {
                    // Инкримент комментов
                    $pageHandler->updateposts($uid, $status, 'add');

                    // Устанавливаем сообщение
                    $ret['message'] = '<div class="successMsg" style="text-align: left;">' . _AM_INSTRUCTION_PAGEADDED . '</div>';
                    // Возвращаем ответ скрипту через JSON
                    echo json_encode($ret);
                    // Прерываем выполнение
                    exit();
                }
                // Если не получилось вставить данные
            } else {

                //
                $message_err = '<div class="errorMsg" style="text-align: left;">' . $objInspage->getHtmlErrors() . '</div>';
                // Устанавливаем сообщение
                $ret['message'] = $message_err;
                // Возвращаем ответ скрипту через JSON
                echo json_encode($ret);
                // Прерываем выполнение
                exit();
            }
        }

        break;
}


Issues (175)

Security Analysis no request data

admin/ajax.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

1		<?php
2
3		use Xmf\Request;
4		use Xoopsmodules\instruction;
5
6		//
7		include __DIR__ . '/admin_header.php';
8		// Функции модуля
9		//include __DIR__ . '/../class/utility.php';
10		// Отключаем дебугер
11		$GLOBALS['xoopsLogger']->activated = false;
12
13		// Объявляем объекты
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-09 08:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `49%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
14		//$instructionHandler = xoops_getModuleHandler('instruction', 'instruction');
15		//$categoryHandler = xoops_getModuleHandler('category', 'instruction');
16		//$pageHandler = xoops_getModuleHandler('page', 'instruction');
17
18		$uid = ($GLOBALS['xoopsUser'] instanceof \XoopsUser) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;
		0 ignored issues – show Bug introduced 2017-10-10 07:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
19		$time = time();
20
21		// Опция
22		$op = Request::getString('op', 'main', 'POST');
23
24		// Выбор
25		switch ($op) {
26		// Сохранение страницы
27		case 'savepage':
28		// Выходной массив
29		$ret = [];
30
31		// Ошибки
32		$err = false;
33		$message_err = '';
34
35		//
36		$title = Request::getString('title', '', 'POST');
37		$pid = Request::getInt('pid', 0, 'POST');
38		$weight = Request::getInt('weight', 0, 'POST');
39		$hometext = Request::getString('hometext', '', 'POST');
40		$footnote = Request::getString('footnote', '', 'POST');
41		$status = Request::getInt('status', 0, 'POST');
42		$type = Request::getInt('type', 0, 'POST');
43		$keywords = Request::getString('keywords', '', 'POST');
44		$description = Request::getString('description', '', 'POST');
45		$dosmiley = (Request::getInt('dosmiley', 0, 'POST') > 0) ? 1 : 0;
46		$doxcode = (Request::getInt('doxcode', 0, 'POST') > 0) ? 1 : 0;
47		$dobr = (Request::getInt('dobr', 0, 'POST') > 0) ? 1 : 0;
48		$dohtml = (Request::getInt('dohtml', 0, 'POST') > 0) ? 1 : 0;
49		//$dohtml = Request::getInt( 'dohtml', 0, 'POST' );
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-10 07:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50		//$dosmiley = Request::getInt( 'dosmiley', 0, 'POST' );
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-10 07:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51		//$doxcode = Request::getInt( 'doxcode', 0, 'POST' );
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-10 07:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52		//$dobr = Request::getInt( 'dobr', 0, 'POST' );
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-10 07:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
53		$pageid = Request::getInt('pageid', 0, 'POST');
54		$instrid = Request::getInt('instrid', 0, 'POST');
55
56		// Проверка
57	View Code Duplication	if (!$GLOBALS['xoopsSecurity']->check()) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		$err = true;
59		$err_txt = implode(', ', $GLOBALS['xoopsSecurity']->getErrors());
60		$message_err .= $err_txt . '<br>' . _AM_INSTR_TRY_AGAIN . '<br>';
61		}
62		// =========================
63		// Устанавливаем новый token
64		$token_name = 'XOOPS_TOKEN';
65		$token_timeout = 0;
66		// $token_name . '_REQUEST' - название элемента формы
67		$ret['toket'] = $GLOBALS['xoopsSecurity']->createToken($token_timeout, $token_name);
68		// =========================
69
70		// Если мы редактируем
71	View Code Duplication	if ($pageid) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		$objInspage = $pageHandler->get($pageid);
73		} elseif ($instrid) {
74		$objInspage = $pageHandler->create();
75		// Если мы создаём страницу необходимо указать к какой инструкции
76		$objInspage->setVar('instrid', $instrid);
77		// Указываем дату создания
78		$objInspage->setVar('datecreated', $time);
79		// Указываем пользователя
80		$objInspage->setVar('uid', $uid);
81		} else {
82		// Устанавливаем сообщение
83		$ret['message'] = _AM_INSTRUCTION_BADREQUEST;
84		// Возвращаем ответ скрипту через JSON
85		echo json_encode($ret);
86		// Прерываем выполнение
87		exit();
88		}
89
90		// Родительская страница
91		$objInspage->setVar('pid', $pid);
92		// Дата обновления
93		$objInspage->setVar('dateupdated', $time);
94		// Название
95		$objInspage->setVar('title', $title);
96		// Вес
97		$objInspage->setVar('weight', $weight);
98		// Текст
99		$objInspage->setVar('hometext', $hometext);
100		// Сноска
101		$objInspage->setVar('footnote', $footnote);
102		// Статус
103		$objInspage->setVar('status', $status);
104		// Тип
105		$objInspage->setVar('type', $type);
106		// Мета-теги ключевых слов
107		$objInspage->setVar('keywords', $keywords);
108		// Мета-теги описания
109		$objInspage->setVar('description', $description);
110		//
111		$objInspage->setVar('dohtml', $dohtml);
112		$objInspage->setVar('dosmiley', $dosmiley);
113		$objInspage->setVar('doxcode', $doxcode);
114		$objInspage->setVar('dobr', $dobr);
115
116		// Проверка категорий
117	View Code Duplication	if (!$pageid && !$instrid) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
118		$err = true;
119		$message_err .= _AM_INSTRUCTION_ERR_INSTR . '<br>';
120		}
121		// Проверка веса
122		if (0 == $weight) {
123		$err = true;
124		$message_err .= _AM_INSTRUCTION_ERR_WEIGHT . '<br>';
125		}
126		// Проверка родительской страницы
127	View Code Duplication	if ($pageid && ($pageid == $pid)) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
128		$err = true;
129		$message_err .= _AM_INSTRUCTION_ERR_PPAGE . '<br>';
130		}
131		// Проверка названия
132		if (!$title) {
133		$err = true;
134		$message_err .= _AM_INSTR_ERR_TITLE . '<br>';
135		}
136		// Проверка основного текста
137		if (!$hometext) {
138		$err = true;
139		$message_err .= _AM_INSTR_ERR_HOMETEXT . '<br>';
140		}
141
142		// Если были ошибки
143		if (true === $err) {
144		//
145		$message_err = '<div class="errorMsg" style="text-align: left;">' . $message_err . '</div>';
146		// Устанавливаем сообщение
147		$ret['message'] = $message_err;
148		// Возвращаем ответ скрипту через JSON
149		echo json_encode($ret);
150		// Прерываем выполнение
151		exit();
152		// Если небыло ошибок
153		} else {
154		// Вставляем данные в БД
155		if ($pageHandler->insert($objInspage)) {
156		// Находим ID созданной записи
157		$pageid_new = $pageid ?: $objInspage->getNewInstertId();
158		//
159		$ret['pageid'] = $pageid_new;
160		// Получаем ID инструкции
161		$instrid = $objInspage->getInstrid();
162		// Обновляем в инструкции число страниц и дату
163		$instructionHandler->updatePages($instrid);
164		// Если мы редактируем
165		if ($pageid) {
166		// Устанавливаем сообщение
167		$ret['message'] = '<div class="successMsg" style="text-align: left;">' . _AM_INSTRUCTION_PAGEMODIFY . '</div>';
168		// Возвращаем ответ скрипту через JSON
169		echo json_encode($ret);
170		// Прерываем выполнение
171		exit();
172
173		// Если мы добавляем
174		} else {
175		// Инкримент комментов
176		$pageHandler->updateposts($uid, $status, 'add');
177
178		// Устанавливаем сообщение
179		$ret['message'] = '<div class="successMsg" style="text-align: left;">' . _AM_INSTRUCTION_PAGEADDED . '</div>';
180		// Возвращаем ответ скрипту через JSON
181		echo json_encode($ret);
182		// Прерываем выполнение
183		exit();
184		}
185		// Если не получилось вставить данные
186		} else {
187
188		//
189		$message_err = '<div class="errorMsg" style="text-align: left;">' . $objInspage->getHtmlErrors() . '</div>';
190		// Устанавливаем сообщение
191		$ret['message'] = $message_err;
192		// Возвращаем ответ скрипту через JSON
193		echo json_encode($ret);
194		// Прерываем выполнение
195		exit();
196		}
197		}
198
199		break;
200		}
201

mambax7 / instruction

Issues (175)

Security Analysis no request data

admin/ajax.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like