mambax7 / instruction

include/config.php

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
 $moduleDirName = basename(dirname(__DIR__));
 $capsDirName   = strtoupper($moduleDirName);
 
-if (!defined($capsDirName . '_DIRNAME')) {
+if ( ! defined($capsDirName . '_DIRNAME')) {
     //if (!defined(constant($capsDirName . '_DIRNAME'))) {
     define($capsDirName . '_DIRNAME', $GLOBALS['xoopsModule']->dirname());
     define($capsDirName . '_PATH', XOOPS_ROOT_PATH . '/modules/' . constant($capsDirName . '_DIRNAME'));
@@ -35,7 +35,7 @@ 
 }
 
 //Configurator
-return (object)[
+return (object) [
     'name'          => strtoupper($moduleDirName) . ' Module Configurator',
     'paths'         => [
         'dirname'    => $moduleDirName,

include/search.inc.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
 
     $sql = 'SELECT p.pageid, p.title, p.uid, p.datecreated, i.title FROM ' . $GLOBALS['xoopsDB']->prefix('instruction_page') . ' p, ' . $GLOBALS['xoopsDB']->prefix('instruction_instr') . ' i WHERE i.instrid = p.instrid AND i.status > 0 AND p.status > 0 AND p.type > 0';
     if (0 != $userid) {
-        $sql .= ' AND p.uid = ' . (int)$userid . ' ';
+        $sql .= ' AND p.uid = ' . (int) $userid . ' ';
         //return NULL;
     }
 

class/Tree.php

Doc Comments +9 added lines, -9 removed lines

@@ -23,9 +23,9 @@ 
     //    }
 
     /**
-     * @param        $key
-     * @param        $ret
-     * @param        $prefix_orig
+     * @param        integer $key
+     * @param        string $ret
+     * @param        string $prefix_orig
      * @param        $objInsinstr
      * @param string $class
      * @param string $prefix_curr
@@ -140,9 +140,9 @@ 
     // ==================================
 
     /**
-     * @param        $key
-     * @param        $ret
-     * @param        $prefix_orig
+     * @param        integer $key
+     * @param        string $ret
+     * @param        string $prefix_orig
      * @param array  $cidinstrids
      * @param string $class
      * @param string $prefix_curr
@@ -239,8 +239,8 @@ 
     // ======================================
 
     /**
-     * @param       $key
-     * @param       $ret
+     * @param       integer $key
+     * @param       string $ret
      * @param int   $currpageid
      * @param array $lastpageids
      * @param int   $level
@@ -350,7 +350,7 @@ 
     // Находим предыдущую и следующую страницы.
     // Находим последнии страницы на каждом уровне.
     /**
-     * @param       $key
+     * @param       integer $key
      * @param int   $currpageid
      * @param array $prevpages
      * @param array $nextpages

Spacing +14 added lines, -14 removed lines

@@ -32,7 +32,7 @@ 
      */
     public function _makePagesAdminOptions($key, &$ret, $prefix_orig, $objInsinstr, $class = 'odd', $prefix_curr = '')
     {
-        $pathIcon16    = \Xmf\Module\Admin::iconUrl('', 16);
+        $pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);
         if ($key > 0) {
 
             //
@@ -59,7 +59,7 @@ 
             // Действие - удаление
             $act_del = ($num_childs > 0) ? '<img src="../assets/images/icons/16/application_key.png" alt="' . _AM_INSTR_NODELPAGE . '" title="' . _AM_INSTR_NODELPAGE . '" />' : '<a href="instr.php?op=delpage&pageid='
                                                                                                                                                                       . $pageid
-                                                                                                                                                                      . '"><img src="'. $pathIcon16 . '/delete.png" alt="'
+                                                                                                                                                                      . '"><img src="' . $pathIcon16 . '/delete.png" alt="'
                                                                                                                                                                       . _AM_INSTRUCTION_DEL
                                                                                                                                                                       . '" title="'
                                                                                                                                                                       . _AM_INSTRUCTION_DEL
@@ -77,7 +77,7 @@ 
             // Просмотре без кэша
             $ret .= ' <a href="' . XOOPS_URL . '/modules/' . INST_DIRNAME . '/page.php?id=' . $pageid . '&amp;nocache=1"><img src="../assets/images/icons/16/database_black.png" alt="' . _AM_INSTR_DISPLAY_NOCACHE . '" title="' . _AM_INSTR_DISPLAY_NOCACHE . '" /></a> ';
             // Добавить подстраницу
-            $ret .= ' <a href="instr.php?op=editpage&instrid=' . $instrid . '&pid=' . $pageid . '"><img src="'. $pathIcon16 . '/add.png" alt="' . _AM_INSTRUCTION_ADDSUBPAGE . '" title="' . _AM_INSTRUCTION_ADDSUBPAGE . '" /></a> ';
+            $ret .= ' <a href="instr.php?op=editpage&instrid=' . $instrid . '&pid=' . $pageid . '"><img src="' . $pathIcon16 . '/add.png" alt="' . _AM_INSTRUCTION_ADDSUBPAGE . '" title="' . _AM_INSTRUCTION_ADDSUBPAGE . '" /></a> ';
 
             if ($pagestatus) {
                 $ret .= ' <img src="../assets/images/icons/16/lock.png" alt="' . _AM_INSTRUCTION_LOCK . '" title="' . _AM_INSTRUCTION_LOCK . '"> ';
@@ -85,7 +85,7 @@ 
                 $ret .= ' <img src="../assets/images/icons/16/lock_open.png" alt="' . _AM_INSTRUCTION_UNLOCK . '" title="' . _AM_INSTRUCTION_UNLOCK . '"> ';
             }
 
-            $ret .= ' <a href="instr.php?op=editpage&pageid=' . $pageid . '"><img src="'. $pathIcon16 . '/edit.png" alt="' . _AM_INSTRUCTION_EDIT . '" title="' . _AM_INSTRUCTION_EDIT . '"></a> ' . $act_del . '
+            $ret .= ' <a href="instr.php?op=editpage&pageid=' . $pageid . '"><img src="' . $pathIcon16 . '/edit.png" alt="' . _AM_INSTRUCTION_EDIT . '" title="' . _AM_INSTRUCTION_EDIT . '"></a> ' . $act_del . '
       </td>
     </tr>';
 
@@ -93,7 +93,7 @@ 
             $prefix_curr .= $prefix_orig;
         }
 
-        if (isset($this->tree[$key]['child']) && !empty($this->tree[$key]['child'])) {
+        if (isset($this->tree[$key]['child']) && ! empty($this->tree[$key]['child'])) {
             foreach ($this->tree[$key]['child'] as $childkey) {
                 $this->_makePagesAdminOptions($childkey, $ret, $prefix_orig, $objInsinstr, $class, $prefix_curr);
             }
@@ -123,7 +123,7 @@ 
         $this->_makePagesAdminOptions($key, $ret, $prefix, $objInsinstr);
 
         $ret .= '<tr class="foot">
-      <td><a href="instr.php?op=editpage&instrid=' . $objInsinstr->getVar('instrid') . '"><img src="'. $pathIcon16 . '/add.png" alt="' . _AM_INSTRUCTION_ADDPAGE . '" title="' . _AM_INSTRUCTION_ADDPAGE . '"></a></td>
+      <td><a href="instr.php?op=editpage&instrid=' . $objInsinstr->getVar('instrid') . '"><img src="' . $pathIcon16 . '/add.png" alt="' . _AM_INSTRUCTION_ADDPAGE . '" title="' . _AM_INSTRUCTION_ADDPAGE . '"></a></td>
       <td colspan="2">
         <input type="hidden" name="instrid" value="' . $objInsinstr->getVar('instrid') . '" />
         <input type="hidden" name="op" value="updpage" />
@@ -150,7 +150,7 @@ 
      */
     public function _makeCatsAdminOptions($key, &$ret, $prefix_orig, $cidinstrids = [], &$class = 'odd', $prefix_curr = '')
     {
-        $pathIcon16    = \Xmf\Module\Admin::iconUrl('', 16);
+        $pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);
         if ($key > 0) {
 
             //
@@ -173,15 +173,15 @@ 
             $num_instrs = isset($cidinstrids[$catid]) ? $cidinstrids[$catid] : 0;
 
             // Действие - удаление
-            $act_del = (($num_instrs > 0) || ($num_childs > 0)) ? '<img src="'. $pathIcon16 . '/delete.png" alt="' . _AM_INSTR_NODELCAT . '" title="' . _AM_INSTR_NODELCAT . '" />' : '<a href="cat.php?op=delcat&cid='
+            $act_del = (($num_instrs > 0) || ($num_childs > 0)) ? '<img src="' . $pathIcon16 . '/delete.png" alt="' . _AM_INSTR_NODELCAT . '" title="' . _AM_INSTR_NODELCAT . '" />' : '<a href="cat.php?op=delcat&cid='
                                                                                                                                                                                            . $catid
-                                                                                                                                                                                           . '"><img src="'. $pathIcon16 . '/delete.png" alt="'
+                                                                                                                                                                                           . '"><img src="' . $pathIcon16 . '/delete.png" alt="'
                                                                                                                                                                                            . _AM_INSTRUCTION_DEL
                                                                                                                                                                                            . '" title="'
                                                                                                                                                                                            . _AM_INSTRUCTION_DEL
                                                                                                                                                                                            . '" /></a>';
             // Действие - просмотр
-            $act_view = ($num_instrs > 0) ? '<a href="instr.php?cid=' . $catid . '"><img src="'. $pathIcon16 . '/view.png" alt="' . _AM_INSTR_VIEWINSTR . '" title="' . _AM_INSTR_VIEWINSTR . '" /></a>' : '<img src="../assets/images/icons/16/document_protect.png" alt="'
+            $act_view = ($num_instrs > 0) ? '<a href="instr.php?cid=' . $catid . '"><img src="' . $pathIcon16 . '/view.png" alt="' . _AM_INSTR_VIEWINSTR . '" title="' . _AM_INSTR_VIEWINSTR . '" /></a>' : '<img src="../assets/images/icons/16/document_protect.png" alt="'
                                                                                                                                                                                                              . _AM_INSTR_NOVIEWINSTR
                                                                                                                                                                                                              . '" title="'
                                                                                                                                                                                                              . _AM_INSTR_NOVIEWINSTR
@@ -193,7 +193,7 @@ 
       <td align="center" width="100">' . $num_instrs . '</td>
       <td align="center" width="150">
         ' . $act_view . '
-        <a href="cat.php?op=editcat&cid=' . $catid . '"><img src="'. $pathIcon16 . '/edit.png" alt="' . _AM_INSTRUCTION_EDIT . '" title="' . _AM_INSTRUCTION_EDIT . '"></a>
+        <a href="cat.php?op=editcat&cid=' . $catid . '"><img src="' . $pathIcon16 . '/edit.png" alt="' . _AM_INSTRUCTION_EDIT . '" title="' . _AM_INSTRUCTION_EDIT . '"></a>
         ' . $act_del . '
       </td>
     </tr>';
@@ -202,7 +202,7 @@ 
             $prefix_curr .= $prefix_orig;
         }
 
-        if (isset($this->tree[$key]['child']) && !empty($this->tree[$key]['child'])) {
+        if (isset($this->tree[$key]['child']) && ! empty($this->tree[$key]['child'])) {
             foreach ($this->tree[$key]['child'] as $childkey) {
                 $this->_makeCatsAdminOptions($childkey, $ret, $prefix_orig, $cidinstrids, $class, $prefix_curr);
             }
@@ -332,7 +332,7 @@ 
         }
 
         // Рекурсия
-        if (isset($this->tree[$key]['child']) && !empty($this->tree[$key]['child'])) {
+        if (isset($this->tree[$key]['child']) && ! empty($this->tree[$key]['child'])) {
             foreach ($this->tree[$key]['child'] as $childkey) {
                 $this->_makePagesUserTree($childkey, $ret, $currpageid, $lastpageids, $level);
             }
@@ -401,7 +401,7 @@ 
         }
 
         // Рекурсия
-        if (isset($this->tree[$key]['child']) && !empty($this->tree[$key]['child'])) {
+        if (isset($this->tree[$key]['child']) && ! empty($this->tree[$key]['child'])) {
             foreach ($this->tree[$key]['child'] as $childkey) {
                 $this->_makePagesUserCalc($childkey, $currpageid, $prevpages, $nextpages, $lastpageids, $level);
             }

class/Utility.php

Doc Comments +2 added lines, -2 removed lines

@@ -46,8 +46,8 @@
     // Редактор
 
     /**
-     * @param        $caption
-     * @param        $name
+     * @param        string $caption
+     * @param        string $name
      * @param string $value
      * @return bool|\XoopsFormEditor
      */

admin/menu.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 use Xoopsmodules\instruction;
 
-if (!isset($moduleDirName)) {
+if ( ! isset($moduleDirName)) {
     $moduleDirName = basename(dirname(__DIR__));
 }
 

preloads/autoloader.php

Spacing +1 added lines, -1 removed lines

@@ -3,7 +3,7 @@
 /**
  * @see http://www.php-fig.org/psr/psr-4/examples/
  */
-spl_autoload_register(function ($class) {
+spl_autoload_register(function($class) {
     // project-specific namespace prefix
     $prefix = 'Xoopsmodules\\instruction\\';
 

class/common/VersionChecks.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
                     break;
                 }
             } else {
-                if ((int)$v > 0) { // handles versions like x.x.x.0_RC2
+                if ((int) $v > 0) { // handles versions like x.x.x.0_RC2
                     $success = false;
                     break;
                 }

class/common/Breadcrumb.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
      */
     public function render()
     {
-        if (!isset($GLOBALS['xoTheme']) || !is_object($GLOBALS['xoTheme'])) {
+        if ( ! isset($GLOBALS['xoTheme']) || ! is_object($GLOBALS['xoTheme'])) {
             require_once $GLOBALS['xoops']->path('class/theme.php');
             $GLOBALS['xoTheme'] = new xos_opal_Theme();
         }

class/Category.php

Spacing +5 added lines, -5 removed lines

@@ -92,7 +92,7 @@ 
         //        $categoryHandler = xoops_getModuleHandler('category', 'instruction');
         $criteria = new \CriteriaCompo();
         // Если мы редактируем, то убрать текущую категорию из списка выбора родительской
-        if (!$this->isNew()) {
+        if ( ! $this->isNew()) {
             $criteria->add(new \Criteria('cid', $this->getVar('cid'), '<>'));
         }
         $criteria->setSort('weight ASC, title');
@@ -138,7 +138,7 @@ 
         // Права на просмотр
         $groups_ids = [];
         // Если мы редактируем
-        if (!$this->isNew()) {
+        if ( ! $this->isNew()) {
             $groups_ids        = $gpermHandler->getGroupIds('instruction_view', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
             $groups_ids        = array_values($groups_ids);
             $groups_instr_view = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_VIEW, 'groups_instr_view', $groups_ids);
@@ -150,7 +150,7 @@ 
 
         // Права на отправку
         $groups_ids = [];
-        if (!$this->isNew()) {
+        if ( ! $this->isNew()) {
             $groups_ids          = $gpermHandler->getGroupIds('instruction_submit', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
             $groups_ids          = array_values($groups_ids);
             $groups_instr_submit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_SUBMIT, 'groups_instr_submit', $groups_ids);
@@ -162,7 +162,7 @@ 
 
         // Права на редактирование
         $groups_ids = [];
-        if (!$this->isNew()) {
+        if ( ! $this->isNew()) {
             $groups_ids        = $gpermHandler->getGroupIds('instruction_edit', $this->getVar('cid'), $GLOBALS['xoopsModule']->getVar('mid'));
             $groups_ids        = array_values($groups_ids);
             $groups_instr_edit = new \XoopsFormCheckBox(_AM_INSTRUCTION_PERM_EDIT, 'groups_instr_edit', $groups_ids);
@@ -176,7 +176,7 @@ 
         // ==========================================================
 
         // Если мы редактируем категорию
-        if (!$this->isNew()) {
+        if ( ! $this->isNew()) {
             $form->addElement(new \XoopsFormHidden('cid', $this->getVar('cid')));
             //$form->addElement( new \XoopsFormHidden( 'catmodify', true));
         }