Issues in page.php - All Issues - Inspection of "fix access to Handler" - mambax7/instruction - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 251d30...e23147 )

by Michael

created 2017-10-17 14:52 UTC

page.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Xmf\Request;
use Xoopsmodules\instruction;

require_once __DIR__ . '/header.php';
// Подключаем трей
include_once __DIR__ . '/class/Tree.php';

$groups       = ($GLOBALS['xoopsUser'] instanceof \XoopsUser) ? $GLOBALS['xoopsUser']->getGroups() : XOOPS_GROUP_ANONYMOUS;
if ($x instanceof DoesNotExist) {
    // Do something.
}
$gpermHandler = xoops_getHandler('groupperm');

// Права на просмотр страницы
// ==========================

// Объявляем объекты

//$instructionHandler = xoops_getModuleHandler('instruction', 'instruction');
//$categoryHandler   = xoops_getModuleHandler('category', 'instruction');
//$pageHandler  = xoops_getModuleHandler('page', 'instruction');

// Получаем данные
// ID страницы
$pageid = Request::getInt('id', 0, 'GET');
// Без кэша
$nocache = Request::getInt('nocache', 0, 'GET');

// Существует ли такая страница
$criteria = new \CriteriaCompo();
$criteria->add(new \Criteria('pageid ', $pageid));
$criteria->add(new \Criteria('status ', '0', '>'));
if (0 == $pageHandler->getCount($criteria)) {
    redirect_header('index.php', 3, _MD_INSTRUCTION_PAGENOTEXIST);
    exit();
}
//
unset($criteria);

// Находим данные о странице
$objInspage = $pageHandler->get($pageid);
// Находим данные об инструкции
$objInsinstr = $instructionHandler->get($objInspage->getVar('instrid'));

// Если админ и ссылка на отключение кэша
if (($GLOBALS['xoopsUser'] instanceof \XoopsUser) && $GLOBALS['xoopsUser']->isAdmin() && $nocache) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
    // Отключаем кэш
    $GLOBALS['xoopsConfig']['module_cache'][$GLOBALS['xoopsModule']->getVar('mid')] = 0;
}

// Задание тайтла
$xoopsOption['xoops_pagetitle'] = $GLOBALS['xoopsModule']->name() . ' - ' . $objInsinstr->getVar('title') . ' - ' . $objInspage->getVar('title');
// Шаблон
$GLOBALS['xoopsOption']['template_main'] = $moduleDirName . '_page.tpl';
// Заголовок
include_once $GLOBALS['xoops']->path('header.php');
// Стили
$xoTheme->addStylesheet(XOOPS_URL . '/modules/' . $moduleDirName . '/assets/css/style.css');
// Скрипты
$xoTheme->addScript(XOOPS_URL . '/modules/' . $moduleDirName . '/assets/js/tree.js');

// Права на просмотр инструкции
$categories = Xoopsmodules\instruction\Utility::getItemIds();
if (!in_array($objInsinstr->getVar('cid'), $categories)) {

    redirect_header(XOOPS_URL . '/modules/' . $moduleDirName . '/', 3, _NOPERM);
    exit();
}

// Массив данных о странице
$pages = [];
// Название страницы
$pages['title'] = $objInspage->getVar('title');
// ID страницы
$pages['pageid'] = $objInspage->getVar('pageid');
// ID инструкции
$pages['instrid'] = $objInspage->getVar('instrid');
// Основной текст
$pages['hometext'] = $objInspage->getVar('hometext');
// Сноска - массив строк
$footnote = $objInspage->getVar('footnote');
// Если есть сноски
if ($footnote) {
    $pages['footnotes'] = explode('|', $objInspage->getVar('footnote'));
} else {
    $pages['footnotes'] = false;
}
// Мета-теги ключевых слов
$pages['keywords'] = $objInspage->getVar('keywords');
// Мета-теги описания
$pages['description'] = $objInspage->getVar('description');
//
// Если админ, рисуем админлинк
if (($GLOBALS['xoopsUser'] instanceof \XoopsUser) && $GLOBALS['xoopsUser']->isAdmin($GLOBALS['xoopsModule']->mid())) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
    $pages['adminlink'] = '&nbsp;<a href="'
                          . XOOPS_URL
                          . '/modules/'
                          . $moduleDirName
                          . '/admin/instr.php?op=editpage&pageid='
                          . $pages['pageid']
                          . '"><img style="width:16px;" src="'. $pathIcon16 . '/edit.png" alt='
                          . _EDIT
                          . ' title='
                          . _EDIT
                          . '></a>&nbsp;<a href="'
                          . XOOPS_URL
                          . '/modules/'
                          . $moduleDirName
                          . '/admin/instr.php?op=delpage&pageid='
                          . $pages['pageid']
                          . '"><img style="width:16px;" src="'. $pathIcon16 . '/delete.png" alt='
                          . _DELETE
                          . ' title='
                          . _DELETE
                          . '></a>&nbsp;';
} else {
    $pages['adminlink'] = '&nbsp;';
    // Если можно редактировать
    if ($gpermHandler->checkRight($moduleDirName . '_edit', $objInsinstr->getVar('cid'), $groups, $GLOBALS['xoopsModule']->getVar('mid'))) {
        $pages['adminlink'] .= '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/submit.php?op=editpage&pageid=' . $pages['pageid'] . '"><img style="width:16px;" src="'. $pathIcon16 . '/edit.png" alt=' . _EDIT . ' title=' . _EDIT . '></a>';
    }

    $pages['adminlink'] .= '&nbsp;';
    // Если нет админлика
    if ('[&nbsp;&nbsp;]' === $pages['adminlink']) {
        $pages['adminlink'] = '';
    }
}
// Выводим в шаблон
$GLOBALS['xoopsTpl']->assign('insPage', $pages);

// Находим данные об категории
$objInscat = $categoryHandler->get($objInsinstr->getVar('cid'));

// Навигация
$criteria = new \CriteriaCompo();
$criteria->setSort('weight ASC, title');
$criteria->setOrder('ASC');
$inscat_arr    = $categoryHandler->getall($criteria);
$mytree        = new \XoopsObjectTree($inscat_arr, 'cid', 'pid');
$nav_parent_id = $mytree->getAllParent($objInsinstr->getVar('cid'));
$titre_page    = $nav_parent_id;
$nav_parent_id = array_reverse($nav_parent_id);
$navigation    = '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/">' . $GLOBALS['xoopsModule']->name() . '</a>&nbsp;:&nbsp;';
foreach (array_keys($nav_parent_id) as $i) {

    $navigation .= '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/index.php?cid=' . $nav_parent_id[$i]->getVar('cid') . '">' . $nav_parent_id[$i]->getVar('title') . '</a>&nbsp;:&nbsp;';
}
$navigation .= '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/index.php?cid=' . $objInscat->getVar('cid') . '">' . $objInscat->getVar('title') . '</a>&nbsp;:&nbsp;';
$navigation .= '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/instr.php?id=' . $pages['instrid'] . '">' . $objInsinstr->getVar('title') . '</a>';
$xoopsTpl->assign('insNav', $navigation);

unset($criteria);

// Список страниц в данной справке
$criteria = new \CriteriaCompo();
$criteria->add(new \Criteria('instrid', $pages['instrid'], '='));
$criteria->add(new \Criteria('status ', '0', '>'));
$criteria->setSort('weight');
$criteria->setOrder('ASC');
$ins_page = $pageHandler->getall($criteria);
unset($criteria);
// Предыдущая и следующая страницы
$prevpages = [];
$nextpages = [];
// Инициализируем
$instree = new Xoopsmodules\instruction\Tree($ins_page, 'pageid', 'pid');
// Выводим список страниц в шаблон
$GLOBALS['xoopsTpl']->assign('insListPage', $instree->makePagesUser($pageid, $prevpages, $nextpages));
// Выводим в шаблон
$xoopsTpl->assign('insPrevpages', $prevpages);
$xoopsTpl->assign('insNextpages', $nextpages);
// Языковые константы

//$xoopsTpl->assign( 'lang_listpages', _MD_INSTRUCTION_LISTPAGES );
$xoopsTpl->assign('lang_menu', _MD_INSTRUCTION_MENU);

// Рейтинг
if (xoops_getModuleOption('userat', 'instruction')) {

    $xoopsTpl->assign('insUserat', true);
} else {
    $xoopsTpl->assign('insUserat', false);
}

// Мета теги
$xoTheme->addMeta('meta', 'keywords', $objInspage->getVar('keywords'));
$xoTheme->addMeta('meta', 'description', $objInspage->getVar('description'));

// Комментарии
include_once $GLOBALS['xoops']->path('include/comment_view.php');
// Подвал
include_once $GLOBALS['xoops']->path('footer.php');


1		<?php
2
3		use Xmf\Request;
4		use Xoopsmodules\instruction;
5
6		require_once __DIR__ . '/header.php';
7		// Подключаем трей
8		include_once __DIR__ . '/class/Tree.php';
9
10		$groups = ($GLOBALS['xoopsUser'] instanceof \XoopsUser) ? $GLOBALS['xoopsUser']->getGroups() : XOOPS_GROUP_ANONYMOUS;
		0 ignored issues – show Bug introduced 2017-10-10 07:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
11		$gpermHandler = xoops_getHandler('groupperm');
12
13		// Права на просмотр страницы
14		// ==========================
15
16		// Объявляем объекты
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-09 08:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `49%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
17		//$instructionHandler = xoops_getModuleHandler('instruction', 'instruction');
18		//$categoryHandler = xoops_getModuleHandler('category', 'instruction');
19		//$pageHandler = xoops_getModuleHandler('page', 'instruction');
20
21		// Получаем данные
22		// ID страницы
23		$pageid = Request::getInt('id', 0, 'GET');
24		// Без кэша
25		$nocache = Request::getInt('nocache', 0, 'GET');
26
27		// Существует ли такая страница
28		$criteria = new \CriteriaCompo();
29		$criteria->add(new \Criteria('pageid ', $pageid));
30		$criteria->add(new \Criteria('status ', '0', '>'));
31		if (0 == $pageHandler->getCount($criteria)) {
32		redirect_header('index.php', 3, _MD_INSTRUCTION_PAGENOTEXIST);
33		exit();
34		}
35		//
36		unset($criteria);
37
38		// Находим данные о странице
39		$objInspage = $pageHandler->get($pageid);
40		// Находим данные об инструкции
41		$objInsinstr = $instructionHandler->get($objInspage->getVar('instrid'));
42
43		// Если админ и ссылка на отключение кэша
44		if (($GLOBALS['xoopsUser'] instanceof \XoopsUser) && $GLOBALS['xoopsUser']->isAdmin() && $nocache) {
		0 ignored issues – show Bug introduced 2017-10-10 07:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
45		// Отключаем кэш
46		$GLOBALS['xoopsConfig']['module_cache'][$GLOBALS['xoopsModule']->getVar('mid')] = 0;
47		}
48
49		// Задание тайтла
50		$xoopsOption['xoops_pagetitle'] = $GLOBALS['xoopsModule']->name() . ' - ' . $objInsinstr->getVar('title') . ' - ' . $objInspage->getVar('title');
51		// Шаблон
52		$GLOBALS['xoopsOption']['template_main'] = $moduleDirName . '_page.tpl';
53		// Заголовок
54		include_once $GLOBALS['xoops']->path('header.php');
55		// Стили
56		$xoTheme->addStylesheet(XOOPS_URL . '/modules/' . $moduleDirName . '/assets/css/style.css');
57		// Скрипты
58		$xoTheme->addScript(XOOPS_URL . '/modules/' . $moduleDirName . '/assets/js/tree.js');
59
60		// Права на просмотр инструкции
61		$categories = Xoopsmodules\instruction\Utility::getItemIds();
62	View Code Duplication	if (!in_array($objInsinstr->getVar('cid'), $categories)) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		redirect_header(XOOPS_URL . '/modules/' . $moduleDirName . '/', 3, _NOPERM);
64		exit();
65		}
66
67		// Массив данных о странице
68		$pages = [];
69		// Название страницы
70		$pages['title'] = $objInspage->getVar('title');
71		// ID страницы
72		$pages['pageid'] = $objInspage->getVar('pageid');
73		// ID инструкции
74		$pages['instrid'] = $objInspage->getVar('instrid');
75		// Основной текст
76		$pages['hometext'] = $objInspage->getVar('hometext');
77		// Сноска - массив строк
78		$footnote = $objInspage->getVar('footnote');
79		// Если есть сноски
80		if ($footnote) {
81		$pages['footnotes'] = explode('\|', $objInspage->getVar('footnote'));
82		} else {
83		$pages['footnotes'] = false;
84		}
85		// Мета-теги ключевых слов
86		$pages['keywords'] = $objInspage->getVar('keywords');
87		// Мета-теги описания
88		$pages['description'] = $objInspage->getVar('description');
89		//
90		// Если админ, рисуем админлинк
91		if (($GLOBALS['xoopsUser'] instanceof \XoopsUser) && $GLOBALS['xoopsUser']->isAdmin($GLOBALS['xoopsModule']->mid())) {
		0 ignored issues – show Bug introduced 2017-10-10 07:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `XoopsUser` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
92		$pages['adminlink'] = ' <a href="'
93		. XOOPS_URL
94		. '/modules/'
95		. $moduleDirName
96		. '/admin/instr.php?op=editpage&pageid='
97		. $pages['pageid']
98		. '"><img style="width:16px;" src="'. $pathIcon16 . '/edit.png" alt='
99		. _EDIT
100		. ' title='
101		. _EDIT
102		. '></a> <a href="'
103		. XOOPS_URL
104		. '/modules/'
105		. $moduleDirName
106		. '/admin/instr.php?op=delpage&pageid='
107		. $pages['pageid']
108		. '"><img style="width:16px;" src="'. $pathIcon16 . '/delete.png" alt='
109		. _DELETE
110		. ' title='
111		. _DELETE
112		. '></a> ';
113		} else {
114		$pages['adminlink'] = ' ';
115		// Если можно редактировать
116		if ($gpermHandler->checkRight($moduleDirName . '_edit', $objInsinstr->getVar('cid'), $groups, $GLOBALS['xoopsModule']->getVar('mid'))) {
117		$pages['adminlink'] .= '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/submit.php?op=editpage&pageid=' . $pages['pageid'] . '"><img style="width:16px;" src="'. $pathIcon16 . '/edit.png" alt=' . _EDIT . ' title=' . _EDIT . '></a>';
118		}
119
120		$pages['adminlink'] .= ' ';
121		// Если нет админлика
122		if ('[  ]' === $pages['adminlink']) {
123		$pages['adminlink'] = '';
124		}
125		}
126		// Выводим в шаблон
127		$GLOBALS['xoopsTpl']->assign('insPage', $pages);
128
129		// Находим данные об категории
130		$objInscat = $categoryHandler->get($objInsinstr->getVar('cid'));
131
132		// Навигация
133		$criteria = new \CriteriaCompo();
134		$criteria->setSort('weight ASC, title');
135		$criteria->setOrder('ASC');
136		$inscat_arr = $categoryHandler->getall($criteria);
137		$mytree = new \XoopsObjectTree($inscat_arr, 'cid', 'pid');
138		$nav_parent_id = $mytree->getAllParent($objInsinstr->getVar('cid'));
139		$titre_page = $nav_parent_id;
140		$nav_parent_id = array_reverse($nav_parent_id);
141		$navigation = '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/">' . $GLOBALS['xoopsModule']->name() . '</a> : ';
142	View Code Duplication	foreach (array_keys($nav_parent_id) as $i) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
143		$navigation .= '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/index.php?cid=' . $nav_parent_id[$i]->getVar('cid') . '">' . $nav_parent_id[$i]->getVar('title') . '</a> : ';
144		}
145		$navigation .= '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/index.php?cid=' . $objInscat->getVar('cid') . '">' . $objInscat->getVar('title') . '</a> : ';
146		$navigation .= '<a href="' . XOOPS_URL . '/modules/' . $moduleDirName . '/instr.php?id=' . $pages['instrid'] . '">' . $objInsinstr->getVar('title') . '</a>';
147		$xoopsTpl->assign('insNav', $navigation);
148
149		unset($criteria);
150
151		// Список страниц в данной справке
152		$criteria = new \CriteriaCompo();
153		$criteria->add(new \Criteria('instrid', $pages['instrid'], '='));
154		$criteria->add(new \Criteria('status ', '0', '>'));
155		$criteria->setSort('weight');
156		$criteria->setOrder('ASC');
157		$ins_page = $pageHandler->getall($criteria);
158		unset($criteria);
159		// Предыдущая и следующая страницы
160		$prevpages = [];
161		$nextpages = [];
162		// Инициализируем
163		$instree = new Xoopsmodules\instruction\Tree($ins_page, 'pageid', 'pid');
164		// Выводим список страниц в шаблон
165		$GLOBALS['xoopsTpl']->assign('insListPage', $instree->makePagesUser($pageid, $prevpages, $nextpages));
166		// Выводим в шаблон
167		$xoopsTpl->assign('insPrevpages', $prevpages);
168		$xoopsTpl->assign('insNextpages', $nextpages);
169		// Языковые константы
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `42%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
170		//$xoopsTpl->assign( 'lang_listpages', _MD_INSTRUCTION_LISTPAGES );
171		$xoopsTpl->assign('lang_menu', _MD_INSTRUCTION_MENU);
172
173		// Рейтинг
174	View Code Duplication	if (xoops_getModuleOption('userat', 'instruction')) {
		0 ignored issues – show Duplication introduced 2017-07-05 03:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
175		$xoopsTpl->assign('insUserat', true);
176		} else {
177		$xoopsTpl->assign('insUserat', false);
178		}
179
180		// Мета теги
181		$xoTheme->addMeta('meta', 'keywords', $objInspage->getVar('keywords'));
182		$xoTheme->addMeta('meta', 'description', $objInspage->getVar('description'));
183
184		// Комментарии
185		include_once $GLOBALS['xoops']->path('include/comment_view.php');
186		// Подвал
187		include_once $GLOBALS['xoops']->path('footer.php');
188

mambax7 / instruction

Push — master ( 251d30...e23147 )

page.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like