mambax7 /
instruction
| Conditions | 9 |
| Paths | 256 |
| Total Lines | 120 |
| Code Lines | 73 |
| Lines | 6 |
| Ratio | 5 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 48 | public function getForm($action = false, $instrid = 0) |
||
| 49 | { |
||
| 50 | // Если нет $action |
||
| 51 | if (false === $action) { |
||
| 52 | $action = xoops_getenv('REQUEST_URI'); |
||
| 53 | } |
||
| 54 | |||
| 55 | // Подключаем формы |
||
| 56 | include_once $GLOBALS['xoops']->path('class/xoopsformloader.php'); |
||
| 57 | // Подключаем типы страниц |
||
| 58 | $pagetypes = include $GLOBALS['xoops']->path('modules/instruction/include/pagetypes.inc.php'); |
||
| 59 | |||
| 60 | // Название формы |
||
| 61 | $title = $this->isNew() ? sprintf(_AM_INSTRUCTION_FORMADDPAGE) : sprintf(_AM_INSTRUCTION_FORMEDITPAGE); |
||
| 62 | |||
| 63 | // Форма |
||
| 64 | $form = new XoopsThemeForm($title, 'instr_form_page', $action, 'post', true); |
||
| 65 | // Название |
||
| 66 | $form->addElement(new XoopsFormText(_AM_INSTRUCTION_TITLEC, 'title', 50, 255, $this->getVar('title')), true); |
||
| 67 | |||
| 68 | // Родительская страница |
||
| 69 | $inspageHandler = xoops_getModuleHandler('page', 'instruction'); |
||
| 70 | $criteria = new CriteriaCompo(); |
||
| 71 | // ID инструкции в которой данная страница |
||
| 72 | $instrid_page = $this->isNew() ? $instrid : $this->getVar('instrid'); |
||
| 73 | // Находим все страницы данной инструкции |
||
| 74 | $criteria->add(new Criteria('instrid', $instrid_page, '=')); |
||
| 75 | // Если мы редактируем, то убрать текущую страницу из списка выбора родительской |
||
| 76 | if (!$this->isNew()) { |
||
| 77 | $criteria->add(new Criteria('pageid', $this->getVar('pageid'), '<>')); |
||
| 78 | } |
||
| 79 | $criteria->setSort('weight'); |
||
| 80 | $criteria->setOrder('ASC'); |
||
| 81 | $inspage_arr = $inspageHandler->getall($criteria); |
||
| 82 | unset($criteria); |
||
| 83 | // Подключаем трей |
||
| 84 | include_once $GLOBALS['xoops']->path('class/tree.php'); |
||
| 85 | $mytree = new XoopsObjectTree($inspage_arr, 'pageid', 'pid'); |
||
| 86 | |||
| 87 | // $form->addElement(new XoopsFormLabel(_AM_INSTRUCTION_PPAGEC, $mytree->makeSelBox('pid', 'title', '--', $this->getVar('pid'), true))); |
||
| 88 | $moduleDirName = basename(__DIR__); |
||
| 89 | if (false !== ($moduleHelper = Xmf\Module\Helper::getHelper($moduleDirName))) { |
||
| 90 | } else { |
||
| 91 | $moduleHelper = Xmf\Module\Helper::getHelper('system'); |
||
| 92 | } |
||
| 93 | $module = $moduleHelper->getModule(); |
||
| 94 | |||
| 95 | View Code Duplication | if (InstructionUtility::checkVerXoops($module, '2.5.9')) { |
|
| 96 | $mytree_select = $mytree->makeSelectElement('pid', 'title', '--', $this->getVar('pid'), true, 0, '', _AM_INSTRUCTION_PPAGEC); |
||
| 97 | $form->addElement($mytree_select); |
||
| 98 | } else { |
||
| 99 | $form->addElement(new XoopsFormLabel(_AM_INSTRUCTION_PPAGEC, $mytree->makeSelBox('pid', 'title', '--', $this->getVar('pid'), true))); |
||
| 100 | } |
||
| 101 | |||
| 102 | // Вес |
||
| 103 | $form->addElement(new XoopsFormText(_AM_INSTRUCTION_WEIGHTC, 'weight', 5, 5, $this->getVar('weight')), true); |
||
| 104 | // Основной текст |
||
| 105 | $form->addElement(InstructionUtility::getWysiwygForm(_AM_INSTRUCTION_HOMETEXTC, 'hometext', $this->getVar('hometext', 'e')), true); |
||
| 106 | // Сноска |
||
| 107 | $form_footnote = new XoopsFormTextArea(_AM_INSTRUCTION_FOOTNOTEC, 'footnote', $this->getVar('footnote', 'e')); |
||
| 108 | $form_footnote->setDescription(_AM_INSTRUCTION_FOOTNOTE_DSC); |
||
| 109 | $form->addElement($form_footnote, false); |
||
| 110 | unset($form_footnote); |
||
| 111 | // Статус |
||
| 112 | $form->addElement(new XoopsFormRadioYN(_AM_INSTRUCTION_ACTIVEC, 'status', $this->getVar('status')), false); |
||
| 113 | // Тип страницы |
||
| 114 | $form_type = new XoopsFormSelect(_AM_INSTR_PAGETYPEC, 'type', $this->getVar('type')); |
||
| 115 | $form_type->setDescription(_AM_INSTR_PAGETYPEC_DESC); |
||
| 116 | $form_type->addOptionArray($pagetypes); |
||
| 117 | $form->addElement($form_type, false); |
||
| 118 | // Мета-теги ключевых слов |
||
| 119 | $form->addElement(new XoopsFormText(_AM_INSTRUCTION_METAKEYWORDSC, 'keywords', 50, 255, $this->getVar('keywords')), false); |
||
| 120 | // Мета-теги описания |
||
| 121 | $form->addElement(new XoopsFormText(_AM_INSTRUCTION_METADESCRIPTIONC, 'description', 50, 255, $this->getVar('description')), false); |
||
| 122 | |||
| 123 | // Настройки |
||
| 124 | $option_tray = new XoopsFormElementTray(_OPTIONS, '<br>'); |
||
| 125 | // HTML |
||
| 126 | $html_checkbox = new XoopsFormCheckBox('', 'dohtml', $this->getVar('dohtml')); |
||
| 127 | $html_checkbox->addOption(1, _AM_INSTR_DOHTML); |
||
| 128 | $option_tray->addElement($html_checkbox); |
||
| 129 | // Смайлы |
||
| 130 | $smiley_checkbox = new XoopsFormCheckBox('', 'dosmiley', $this->getVar('dosmiley')); |
||
| 131 | $smiley_checkbox->addOption(1, _AM_INSTR_DOSMILEY); |
||
| 132 | $option_tray->addElement($smiley_checkbox); |
||
| 133 | // ББ коды |
||
| 134 | $xcode_checkbox = new XoopsFormCheckBox('', 'doxcode', $this->getVar('doxcode')); |
||
| 135 | $xcode_checkbox->addOption(1, _AM_INSTR_DOXCODE); |
||
| 136 | $option_tray->addElement($xcode_checkbox); |
||
| 137 | // |
||
| 138 | $br_checkbox = new XoopsFormCheckBox('', 'dobr', $this->getVar('dobr')); |
||
| 139 | $br_checkbox->addOption(1, _AM_INSTR_DOAUTOWRAP); |
||
| 140 | $option_tray->addElement($br_checkbox); |
||
| 141 | // |
||
| 142 | $form->addElement($option_tray); |
||
| 143 | |||
| 144 | // Если мы редактируем страницу |
||
| 145 | if (!$this->isNew()) { |
||
| 146 | $form->addElement(new XoopsFormHidden('pageid', $this->getVar('pageid'))); |
||
| 147 | } else { |
||
| 148 | $form->addElement(new XoopsFormHidden('pageid', 0)); |
||
| 149 | } |
||
| 150 | // ID инструкции |
||
| 151 | if ($instrid) { |
||
| 152 | $form->addElement(new XoopsFormHidden('instrid', $instrid)); |
||
| 153 | } else { |
||
| 154 | $form->addElement(new XoopsFormHidden('instrid', 0)); |
||
| 155 | } |
||
| 156 | // |
||
| 157 | $form->addElement(new XoopsFormHidden('op', 'savepage')); |
||
| 158 | // Кнопка |
||
| 159 | $button_tray = new XoopsFormElementTray('', ''); |
||
| 160 | $button_tray->addElement(new XoopsFormButton('', 'submit', _SUBMIT, 'submit')); |
||
| 161 | $save_btn = new XoopsFormButton('', 'cancel', _AM_INSTR_SAVEFORM); |
||
| 162 | $save_btn->setExtra('onclick="instrSavePage();"'); |
||
| 163 | $button_tray->addElement($save_btn); |
||
| 164 | $form->addElement($button_tray); |
||
| 165 | |||
| 166 | return $form; |
||
| 167 | } |
||
| 168 | |||
| 230 |
Loading history...
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.