InstructionInstruction

Complexity

Total Complexity

14

Size/Duplication

Total Lines	115
Duplicated Lines	5.22 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	19	1
A	InstructionInstruction()	0	4	1
A	get_new_enreg()	0	5	1
D	getForm()	6	79	11

<?php

//if (!defined("XOOPS_ROOT_PATH")) {

70% of this comment could be valid code. Did you maybe forget this after debugging?

//	die("XOOPS root path not defined");
//}

include_once $GLOBALS['xoops']->path('include/common.php');

class InstructionInstruction extends XoopsObject
{
    // constructor
    public function __construct()
    {
        //		$this->XoopsObject();

72% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->initVar('instrid', XOBJ_DTYPE_INT, null, false, 11);
        $this->initVar('cid', XOBJ_DTYPE_INT, 0, false, 5);
        $this->initVar('uid', XOBJ_DTYPE_INT, 0, false, 11);
        $this->initVar('title', XOBJ_DTYPE_TXTBOX, '', false);
        $this->initVar('status', XOBJ_DTYPE_INT, 0, false, 1);
        $this->initVar('pages', XOBJ_DTYPE_INT, 0, false, 11);
        $this->initVar('description', XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar('datecreated', XOBJ_DTYPE_INT, 0, false, 10);
        $this->initVar('dateupdated', XOBJ_DTYPE_INT, 0, false, 10);
        $this->initVar('metakeywords', XOBJ_DTYPE_TXTBOX, '', false);
        $this->initVar('metadescription', XOBJ_DTYPE_TXTBOX, '', false);

        // Нет в таблице
        $this->initVar('dohtml', XOBJ_DTYPE_INT, 1, false);
        $this->initVar('dobr', XOBJ_DTYPE_INT, 0, false);
    }

    public function InstructionInstruction()
    {
        $this->__construct();
    }

    public function get_new_enreg()
    {
        $new_enreg = $GLOBALS['xoopsDB']->getInsertId();
        return $new_enreg;
    }

    // Получаем форму
    public function getForm($action = false)
    {
        global $xoopsDB, $xoopsModule, $xoopsModuleConfig;
        // Если нет $action
        if (false === $action) {
            $action = xoops_getenv('REQUEST_URI');
        }
        // Подключаем формы
        include_once $GLOBALS['xoops']->path('class/xoopsformloader.php');

        // Название формы
        $title = $this->isNew() ? sprintf(_AM_INSTRUCTION_FORMADDINSTR) : sprintf(_AM_INSTRUCTION_FORMEDITINSTR);

        // Форма
        $form = new XoopsThemeForm($title, 'forminstr', $action, 'post', true);
        //$form->setExtra('enctype="multipart/form-data"');

86% of this comment could be valid code. Did you maybe forget this after debugging?

        // Название инструкции
        $form->addElement(new XoopsFormText(_AM_INSTRUCTION_TITLEC, 'title', 50, 255, $this->getVar('title')), true);
        // Категория
        $instructioncatHandler = xoops_getModuleHandler('category', 'instruction');
        $criteria              = new CriteriaCompo();
        $criteria->setSort('weight ASC, title');
        $criteria->setOrder('ASC');
        $instructioncat_arr = $instructioncatHandler->getall($criteria);
        unset($criteria);
        // Подключаем трей
        include_once $GLOBALS['xoops']->path('class/tree.php');
        $mytree = new XoopsObjectTree($instructioncat_arr, 'cid', 'pid');

        // $form->addElement(new XoopsFormLabel(_AM_INSTRUCTION_CATC, $mytree->makeSelBox('cid', 'title', '--', $this->getVar('cid'), true)));

69% of this comment could be valid code. Did you maybe forget this after debugging?

        $moduleDirName = basename(__DIR__);
        if (false !== ($moduleHelper = Xmf\Module\Helper::getHelper($moduleDirName))) {

This if statement is empty and can be removed.

        } else {
            $moduleHelper = Xmf\Module\Helper::getHelper('system');
        }
        $module = $moduleHelper->getModule();

        if (InstructionUtility::checkVerXoops($module, '2.5.9')) {

This code seems to be duplicated across your project.

            $mytree_select = $mytree->makeSelectElement('cid', 'title', '--', $this->getVar('cid'), true, 0, '', _AM_INSTRUCTION_CATC);
            $form->addElement($mytree_select);
        } else {
            $form->addElement(new XoopsFormLabel(_AM_INSTRUCTION_CATC, $mytree->makeSelBox('cid', 'title', '--', $this->getVar('cid'), true)));
        }

        // Описание
        $form->addElement(InstructionUtility::getWysiwygForm(_AM_INSTRUCTION_DESCRIPTIONC, 'description', $this->getVar('description', 'e')), true);
        // Статус
        $form->addElement(new XoopsFormRadioYN(_AM_INSTRUCTION_ACTIVEC, 'status', $this->getVar('status')), false);

        // Теги
        if (is_dir('../../tag') || is_dir('../tag')) {
            $dir_tag_ok = true;
        } else {
            $dir_tag_ok = false;
        }
        // Если влючена поддержка тегов и есть модуль tag
        if (xoops_getModuleOption('usetag', 'instruction') && $dir_tag_ok) {
            $itemIdForTag = $this->isNew() ? 0 : $this->getVar('instrid');
            // Подключаем форму тегов
            include_once $GLOBALS['xoops']->path('modules/tag/include/formtag.php');
            // Добавляем элемент в форму
            $form->addElement(new XoopsFormTag('tag', 60, 255, $itemIdForTag, 0));
        }

        // Мета-теги ключевых слов
        $form->addElement(new XoopsFormText(_AM_INSTRUCTION_METAKEYWORDSC, 'metakeywords', 50, 255, $this->getVar('metakeywords')), false);
        // Мета-теги описания
        $form->addElement(new XoopsFormText(_AM_INSTRUCTION_METADESCRIPTIONC, 'metadescription', 50, 255, $this->getVar('metadescription')), false);

        // Если мы редактируем категорию
        if (!$this->isNew()) {
            $form->addElement(new XoopsFormHidden('instrid', $this->getVar('instrid')));
        }
        //
        $form->addElement(new XoopsFormHidden('op', 'saveinstr'));
        // Кнопка
        $form->addElement(new XoopsFormButton('', 'submit', _SUBMIT, 'submit'));
        return $form;
    }
}

class InstructionInstructionHandler extends XoopsPersistableObjectHandler
{
    public function __construct($db)
    {
        parent::__construct($db, 'instruction_instr', 'InstructionInstruction', 'instrid', 'title');
    }

    // Обновление даты обновления инструкций
    public function updateDateupdated($instrid = 0, $time = null)

This method seems to be duplicated in your project.

    {
        // Если не передали время
        $time = null === $time ? time() : (int)$time;
        //
        $sql = sprintf('UPDATE `%s` SET `dateupdated` = %u WHERE `instrid` = %u', $this->table, $time, (int)$instrid);
        //
        return $this->db->query($sql);
    }

    // Обновление числа страниц
    public function updatePages($instrid = 0)
    {
        $inspageHandler = xoops_getModuleHandler('page', 'instruction');
        // Находим число активных страниц
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('instrid', $instrid, '='));
        $criteria->add(new Criteria('status ', '0', '>'));
        // Число страниц
        $pages = $inspageHandler->getCount($criteria);
        unset($criteria);

        // Сохраняем это число
        $sql = sprintf('UPDATE `%s` SET `pages` = %u, `dateupdated` = %u WHERE `instrid` = %u', $this->table, $pages, time(), $instrid);
        //
        return $this->db->query($sql);
    }
}