mambax7 /
instruction
| Conditions | 8 |
| Paths | 128 |
| Total Lines | 118 |
| Code Lines | 70 |
| Lines | 6 |
| Ratio | 5.08 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php namespace Xoopsmodules\instruction; |
||
| 56 | public function getForm($action = false, $instrid = 0) |
||
| 57 | { |
||
| 58 | // Если нет $action |
||
| 59 | if (false === $action) { |
||
| 60 | $action = xoops_getenv('REQUEST_URI'); |
||
| 61 | } |
||
| 62 | |||
| 63 | // Подключаем формы |
||
| 64 | include_once $GLOBALS['xoops']->path('class/xoopsformloader.php'); |
||
| 65 | // Подключаем типы страниц |
||
| 66 | $pagetypes = include $GLOBALS['xoops']->path('modules/instruction/include/pagetypes.inc.php'); |
||
| 67 | |||
| 68 | // Название формы |
||
| 69 | $title = $this->isNew() ? sprintf(_AM_INSTRUCTION_FORMADDPAGE) : sprintf(_AM_INSTRUCTION_FORMEDITPAGE); |
||
| 70 | |||
| 71 | // Форма |
||
| 72 | $form = new \XoopsThemeForm($title, 'instr_form_page', $action, 'post', true); |
||
| 73 | // Название |
||
| 74 | $form->addElement(new \XoopsFormText(_AM_INSTRUCTION_TITLEC, 'title', 50, 255, $this->getVar('title')), true); |
||
| 75 | |||
| 76 | // Родительская страница |
||
| 77 | // $pageHandler = xoops_getModuleHandler('page', 'instruction'); |
||
| 78 | $pageHandler = new PageHandler; |
||
| 79 | |||
| 80 | $criteria = new \CriteriaCompo(); |
||
| 81 | // ID инструкции в которой данная страница |
||
| 82 | $instrid_page = $this->isNew() ? $instrid : $this->getVar('instrid'); |
||
| 83 | // Находим все страницы данной инструкции |
||
| 84 | $criteria->add(new \Criteria('instrid', $instrid_page, '=')); |
||
| 85 | // Если мы редактируем, то убрать текущую страницу из списка выбора родительской |
||
| 86 | if (!$this->isNew()) { |
||
| 87 | $criteria->add(new \Criteria('pageid', $this->getVar('pageid'), '<>')); |
||
| 88 | } |
||
| 89 | $criteria->setSort('weight'); |
||
| 90 | $criteria->setOrder('ASC'); |
||
| 91 | $inspage_arr = $pageHandler->getall($criteria); |
||
| 92 | unset($criteria); |
||
| 93 | // Подключаем трей |
||
| 94 | include_once $GLOBALS['xoops']->path('class/tree.php'); |
||
| 95 | $mytree = new \XoopsObjectTree($inspage_arr, 'pageid', 'pid'); |
||
| 96 | |||
| 97 | // $form->addElement(new XoopsFormLabel(_AM_INSTRUCTION_PPAGEC, $mytree->makeSelBox('pid', 'title', '--', $this->getVar('pid'), true))); |
||
| 98 | $helper = Helper::getInstance(); |
||
| 99 | $module = $helper->getModule(); |
||
| 100 | |||
| 101 | View Code Duplication | if (Utility::checkVerXoops($module, '2.5.9')) { |
|
| 102 | $mytree_select = $mytree->makeSelectElement('pid', 'title', '--', $this->getVar('pid'), true, 0, '', _AM_INSTRUCTION_PPAGEC); |
||
| 103 | $form->addElement($mytree_select); |
||
| 104 | } else { |
||
| 105 | $form->addElement(new \XoopsFormLabel(_AM_INSTRUCTION_PPAGEC, $mytree->makeSelBox('pid', 'title', '--', $this->getVar('pid'), true))); |
||
| 106 | } |
||
| 107 | |||
| 108 | // Вес |
||
| 109 | $form->addElement(new \XoopsFormText(_AM_INSTRUCTION_WEIGHTC, 'weight', 5, 5, $this->getVar('weight')), true); |
||
| 110 | // Основной текст |
||
| 111 | $form->addElement(Utility::getWysiwygForm(_AM_INSTRUCTION_HOMETEXTC, 'hometext', $this->getVar('hometext', 'e')), true); |
||
| 112 | // Сноска |
||
| 113 | $form_footnote = new \XoopsFormTextArea(_AM_INSTRUCTION_FOOTNOTEC, 'footnote', $this->getVar('footnote', 'e')); |
||
| 114 | $form_footnote->setDescription(_AM_INSTRUCTION_FOOTNOTE_DSC); |
||
| 115 | $form->addElement($form_footnote, false); |
||
| 116 | unset($form_footnote); |
||
| 117 | // Статус |
||
| 118 | $form->addElement(new \XoopsFormRadioYN(_AM_INSTRUCTION_ACTIVEC, 'status', $this->getVar('status')), false); |
||
| 119 | // Тип страницы |
||
| 120 | $form_type = new \XoopsFormSelect(_AM_INSTR_PAGETYPEC, 'type', $this->getVar('type')); |
||
| 121 | $form_type->setDescription(_AM_INSTR_PAGETYPEC_DESC); |
||
| 122 | $form_type->addOptionArray($pagetypes); |
||
| 123 | $form->addElement($form_type, false); |
||
| 124 | // Мета-теги ключевых слов |
||
| 125 | $form->addElement(new \XoopsFormText(_AM_INSTRUCTION_METAKEYWORDSC, 'keywords', 50, 255, $this->getVar('keywords')), false); |
||
| 126 | // Мета-теги описания |
||
| 127 | $form->addElement(new \XoopsFormText(_AM_INSTRUCTION_METADESCRIPTIONC, 'description', 50, 255, $this->getVar('description')), false); |
||
| 128 | |||
| 129 | // Настройки |
||
| 130 | $option_tray = new \XoopsFormElementTray(_OPTIONS, '<br>'); |
||
| 131 | // HTML |
||
| 132 | $html_checkbox = new \XoopsFormCheckBox('', 'dohtml', $this->getVar('dohtml')); |
||
| 133 | $html_checkbox->addOption(1, _AM_INSTR_DOHTML); |
||
| 134 | $option_tray->addElement($html_checkbox); |
||
| 135 | // Смайлы |
||
| 136 | $smiley_checkbox = new \XoopsFormCheckBox('', 'dosmiley', $this->getVar('dosmiley')); |
||
| 137 | $smiley_checkbox->addOption(1, _AM_INSTR_DOSMILEY); |
||
| 138 | $option_tray->addElement($smiley_checkbox); |
||
| 139 | // ББ коды |
||
| 140 | $xcode_checkbox = new \XoopsFormCheckBox('', 'doxcode', $this->getVar('doxcode')); |
||
| 141 | $xcode_checkbox->addOption(1, _AM_INSTR_DOXCODE); |
||
| 142 | $option_tray->addElement($xcode_checkbox); |
||
| 143 | // |
||
| 144 | $br_checkbox = new \XoopsFormCheckBox('', 'dobr', $this->getVar('dobr')); |
||
| 145 | $br_checkbox->addOption(1, _AM_INSTR_DOAUTOWRAP); |
||
| 146 | $option_tray->addElement($br_checkbox); |
||
| 147 | // |
||
| 148 | $form->addElement($option_tray); |
||
| 149 | |||
| 150 | // Если мы редактируем страницу |
||
| 151 | if (!$this->isNew()) { |
||
| 152 | $form->addElement(new \XoopsFormHidden('pageid', $this->getVar('pageid'))); |
||
| 153 | } else { |
||
| 154 | $form->addElement(new \XoopsFormHidden('pageid', 0)); |
||
| 155 | } |
||
| 156 | // ID инструкции |
||
| 157 | if ($instrid) { |
||
| 158 | $form->addElement(new \XoopsFormHidden('instrid', $instrid)); |
||
| 159 | } else { |
||
| 160 | $form->addElement(new \XoopsFormHidden('instrid', 0)); |
||
| 161 | } |
||
| 162 | // |
||
| 163 | $form->addElement(new \XoopsFormHidden('op', 'savepage')); |
||
| 164 | // Кнопка |
||
| 165 | $button_tray = new \XoopsFormElementTray('', ''); |
||
| 166 | $button_tray->addElement(new \XoopsFormButton('', 'submit', _SUBMIT, 'submit')); |
||
| 167 | $save_btn = new \XoopsFormButton('', 'cancel', _AM_INSTR_SAVEFORM); |
||
| 168 | $save_btn->setExtra('onclick="instrSavePage();"'); |
||
| 169 | $button_tray->addElement($save_btn); |
||
| 170 | $form->addElement($button_tray); |
||
| 171 | |||
| 172 | return $form; |
||
| 173 | } |
||
| 174 | |||
| 186 |
Loading history...
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.