Issues in ajaxgwiki.php (master) - Issues in master - mambax7/gwiki - Measure and Improve Code Quality continuously with Scrutinizer

Issues (207)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

ajaxgwiki.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Xmf\Request;

/**
 * ajaxwiki.php - serve wiki page via ajax
 *
 * @copyright  Copyright © 2013 geekwright, LLC. All rights reserved.
 * @license    gwiki/docs/license.txt  GNU General Public License (GPL)
 * @since      1.0
 * @author     Richard Griffith <[email protected]>
 * @package    gwiki
 */
include __DIR__ . '/../../mainfile.php';
$xoopsLogger->activated = false;
// provide error logging for our sanity in debugging ajax use (won't see xoops logger)
//restore_error_handler();
//error_reporting(-1);

/**
 * @param $string
 *
 * @return string
 */
function cleaner($string)
/**
 * @ignore
 */
function getUser() {

}

function getUser($id, $realm) {

}
{
    $string = stripcslashes($string);
    $string = html_entity_decode($string);
    $string = strip_tags($string); // DANGER -- kills wiki text
    $string = trim($string);
    $string = stripslashes($string);

    return $string;
}

// $_GET variables we use
unset($page, $bid, $id);
$page = Request::getString('page', null, 'GET');

// strip rid of any anchor references
//$x=strpos($page,'#');
//if($x!==false) $page=substr($page,0,$x);
//trigger_error($page);

if (Request::hasVar('bid', 'GET')) {
    $bid = Request::getInt('bid', 'get');
} // from a block
if (Request::hasVar('id', 'GET')) {
    $id = Request::getInt('id', 'get');
}    // from utility (i.e. history)

$dir = basename(__DIR__);
$moduleHelper = Xmf\Module\Helper::getHelper($dir);

$retaindays = (int) $moduleHelper->getConfig('retain_days', 0);

$alloworigin = $moduleHelper->getConfig('allow_origin', '');
if (!empty($alloworigin)) {
    header('Access-Control-Allow-Origin: ' . $alloworigin);
}

include_once XOOPS_ROOT_PATH . '/modules/' . $dir . '/class/GwikiPage.php';
$imgdir = XOOPS_URL . '/modules/' . $dir . '/assets/images';

$wikiPage = new GwikiPage;
$wikiPage->setRecentCount($moduleHelper->getConfig('number_recent', 10));

if (empty($page)) {
    $page = $wikiPage->wikiHomePage;
}
$page = $wikiPage->normalizeKeyword($page);

if (isset($id)) {
    $wikiPage->setWikiLinkURL("javascript:alert('%s');");
    $wikiPage->setTocFormat('toc' . $id . '-', '#%s');
}
if (isset($bid)) {
    $wikiPage->setWikiLinkURL("javascript:ajaxGwikiLoad('%s','{$bid}');");
    $wikiPage->setTocFormat('toc' . $bid . '-', '#%s');
}
if (isset($id)) {
    $thispage = $wikiPage->getPage($page, $id);
} else {
    $thispage = $wikiPage->getPage($page);
}
if ($thispage) {
    if (!defined('_MI_GWIKI_NAME')) {

        $langfile = XOOPS_ROOT_PATH . '/modules/' . $dir . '/language/' . $xoopsConfig['language'] . '/modinfo.php';
        if (!file_exists($langfile)) {
            $langfile = XOOPS_ROOT_PATH . '/modules/' . $dir . '/language/english/modinfo.php';
        }
        include_once $langfile;
    }

    $rendered = '<h1 class="wikititle">' . htmlspecialchars($wikiPage->title) . '</h1>';
    $rendered .= $wikiPage->renderPage();
    if (!empty($thispage['pageset']['first']['link'])) {
        $rendered .= '<div class="wikipagesetnav">';
        $rendered .= '<a href="' . $thispage['pageset']['first']['link'] . '"><img src="' . $imgdir . '/psfirst.png" alt="' . $thispage['pageset']['first']['desc'] . '" title="'
                     . $thispage['pageset']['first']['text'] . '" /></a>';
        $rendered .= '<a href="' . $thispage['pageset']['prev']['link'] . '"><img src="' . $imgdir . '/psprev.png" alt="' . $thispage['pageset']['prev']['desc'] . '" title="'
                     . $thispage['pageset']['prev']['text'] . '" /></a>';
        $rendered .= '<a href="' . $thispage['pageset']['home']['link'] . '"><img src="' . $imgdir . '/pshome.png" alt="' . $thispage['pageset']['home']['desc'] . '" title="'
                     . $thispage['pageset']['home']['text'] . '" /></a>';
        $rendered .= '<a href="' . $thispage['pageset']['next']['link'] . '"><img src="' . $imgdir . '/psnext.png" alt="' . $thispage['pageset']['next']['desc'] . '" title="'
                     . $thispage['pageset']['next']['text'] . '" /></a>';
        $rendered .= '<a href="' . $thispage['pageset']['last']['link'] . '"><img src="' . $imgdir . '/pslast.png" alt="' . $thispage['pageset']['last']['desc'] . '" title="'
                     . $thispage['pageset']['last']['text'] . '" /></a>';
        $rendered .= '</div>';
    }

    if (!isset($id)) {
        $wikiPage->registerHit($page);
    } // don't count hits from utilities
} else {
    //if ($mayEdit) redirect_header("edit.php?page=$page", 2, _MD_GWIKI_PAGENOTFOUND);
    $rendered = '<h1 class="wikititle">' . _MD_GWIKI_NOEDIT_NOTFOUND_TITLE . '</h1>';
    $rendered .= _MD_GWIKI_NOEDIT_NOTFOUND_BODY;
}
echo $rendered;
exit;


1		<?php
2
3		use Xmf\Request;
4
5		/**
6		* ajaxwiki.php - serve wiki page via ajax
7		*
8		* @copyright Copyright © 2013 geekwright, LLC. All rights reserved.
9		* @license gwiki/docs/license.txt GNU General Public License (GPL)
10		* @since 1.0
11		* @author Richard Griffith <[email protected]>
12		* @package gwiki
13		*/
14		include __DIR__ . '/../../mainfile.php';
15		$xoopsLogger->activated = false;
16		// provide error logging for our sanity in debugging ajax use (won't see xoops logger)
17		//restore_error_handler();
18		//error_reporting(-1);
19
20		/**
21		* @param $string
22		*
23		* @return string
24		*/
25	View Code Duplication	function cleaner($string)
		0 ignored issues – show Best Practice introduced 2017-02-01 04:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The function `cleaner()` has been defined more than once; this definition is ignored, only the first definition in `admin/prefixes.php` (L601-612) is considered. This check looks for functions that have already been defined in other files. Some Codebases, like WordPress, make a practice of defining functions multiple times. This may lead to problems with the detection of function parameters and types. If you really need to do this, you can mark the duplicate definition with the `@ignore` annotation. /** * @ignore */ function getUser() { } function getUser($id, $realm) { } See also the PhpDoc documentation for @ignore. Loading history... Duplication introduced 2016-01-18 06:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		{
27		$string = stripcslashes($string);
28		$string = html_entity_decode($string);
29		$string = strip_tags($string); // DANGER -- kills wiki text
30		$string = trim($string);
31		$string = stripslashes($string);
32
33		return $string;
34		}
35
36		// $_GET variables we use
37		unset($page, $bid, $id);
38		$page = Request::getString('page', null, 'GET');
39
40		// strip rid of any anchor references
41		//$x=strpos($page,'#');
42		//if($x!==false) $page=substr($page,0,$x);
43		//trigger_error($page);
44
45		if (Request::hasVar('bid', 'GET')) {
46		$bid = Request::getInt('bid', 'get');
47		} // from a block
48		if (Request::hasVar('id', 'GET')) {
49		$id = Request::getInt('id', 'get');
50		} // from utility (i.e. history)
51
52		$dir = basename(__DIR__);
53		$moduleHelper = Xmf\Module\Helper::getHelper($dir);
54
55		$retaindays = (int) $moduleHelper->getConfig('retain_days', 0);
56
57		$alloworigin = $moduleHelper->getConfig('allow_origin', '');
58		if (!empty($alloworigin)) {
59		header('Access-Control-Allow-Origin: ' . $alloworigin);
60		}
61
62		include_once XOOPS_ROOT_PATH . '/modules/' . $dir . '/class/GwikiPage.php';
63		$imgdir = XOOPS_URL . '/modules/' . $dir . '/assets/images';
64
65		$wikiPage = new GwikiPage;
66		$wikiPage->setRecentCount($moduleHelper->getConfig('number_recent', 10));
67
68		if (empty($page)) {
69		$page = $wikiPage->wikiHomePage;
70		}
71		$page = $wikiPage->normalizeKeyword($page);
72
73		if (isset($id)) {
74		$wikiPage->setWikiLinkURL("javascript:alert('%s');");
75		$wikiPage->setTocFormat('toc' . $id . '-', '#%s');
76		}
77		if (isset($bid)) {
78		$wikiPage->setWikiLinkURL("javascript:ajaxGwikiLoad('%s','{$bid}');");
79		$wikiPage->setTocFormat('toc' . $bid . '-', '#%s');
80		}
81		if (isset($id)) {
82		$thispage = $wikiPage->getPage($page, $id);
83		} else {
84		$thispage = $wikiPage->getPage($page);
85		}
86		if ($thispage) {
87	View Code Duplication	if (!defined('_MI_GWIKI_NAME')) {
		0 ignored issues – show Duplication introduced 2016-01-18 06:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88		$langfile = XOOPS_ROOT_PATH . '/modules/' . $dir . '/language/' . $xoopsConfig['language'] . '/modinfo.php';
89		if (!file_exists($langfile)) {
90		$langfile = XOOPS_ROOT_PATH . '/modules/' . $dir . '/language/english/modinfo.php';
91		}
92		include_once $langfile;
93		}
94
95		$rendered = '<h1 class="wikititle">' . htmlspecialchars($wikiPage->title) . '</h1>';
96		$rendered .= $wikiPage->renderPage();
97		if (!empty($thispage['pageset']['first']['link'])) {
98		$rendered .= '<div class="wikipagesetnav">';
99		$rendered .= '<a href="' . $thispage['pageset']['first']['link'] . '"><img src="' . $imgdir . '/psfirst.png" alt="' . $thispage['pageset']['first']['desc'] . '" title="'
100		. $thispage['pageset']['first']['text'] . '" /></a>';
101		$rendered .= '<a href="' . $thispage['pageset']['prev']['link'] . '"><img src="' . $imgdir . '/psprev.png" alt="' . $thispage['pageset']['prev']['desc'] . '" title="'
102		. $thispage['pageset']['prev']['text'] . '" /></a>';
103		$rendered .= '<a href="' . $thispage['pageset']['home']['link'] . '"><img src="' . $imgdir . '/pshome.png" alt="' . $thispage['pageset']['home']['desc'] . '" title="'
104		. $thispage['pageset']['home']['text'] . '" /></a>';
105		$rendered .= '<a href="' . $thispage['pageset']['next']['link'] . '"><img src="' . $imgdir . '/psnext.png" alt="' . $thispage['pageset']['next']['desc'] . '" title="'
106		. $thispage['pageset']['next']['text'] . '" /></a>';
107		$rendered .= '<a href="' . $thispage['pageset']['last']['link'] . '"><img src="' . $imgdir . '/pslast.png" alt="' . $thispage['pageset']['last']['desc'] . '" title="'
108		. $thispage['pageset']['last']['text'] . '" /></a>';
109		$rendered .= '</div>';
110		}
111
112		if (!isset($id)) {
113		$wikiPage->registerHit($page);
114		} // don't count hits from utilities
115		} else {
116		//if ($mayEdit) redirect_header("edit.php?page=$page", 2, _MD_GWIKI_PAGENOTFOUND);
117		$rendered = '<h1 class="wikititle">' . _MD_GWIKI_NOEDIT_NOTFOUND_TITLE . '</h1>';
118		$rendered .= _MD_GWIKI_NOEDIT_NOTFOUND_BODY;
119		}
120		echo $rendered;
121		exit;
122

mambax7 / gwiki

Issues (207)

Security Analysis not enabled

ajaxgwiki.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like