mambax7 / extgallery

class/Common/Migrate.php

<?php

namespace XoopsModules\Extgallery\Common;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

use XoopsModules\Extgallery;


/**
 * Class Migrate synchronize existing tables with target schema
 *
 * @category  Migrate
 * @author    Richard Griffith <richard@geekwright.com>
 * @copyright 2016 XOOPS Project (https://xoops.org)
 * @license   GNU GPL 2 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @link      https://xoops.org
 */
class Migrate extends \Xmf\Database\Migrate
{
    private $renameTables;

    /**
     * Migrate constructor.
     * @param \XoopsModules\Extgallery\Common\Configurator $configurator
     */
    public function __construct(\XoopsModules\Extgallery\Common\Configurator $configurator)
    {
        $this->renameTables = $configurator->renameTables;

        $moduleDirName = \basename(\dirname(__DIR__, 2));
        parent::__construct($moduleDirName);
    }

    /**
     * change table prefix if needed
     */
    private function changePrefix()
    {
        foreach ($this->renameTables as $oldName => $newName) {
            if ($this->tableHandler->useTable($oldName)) {
                $this->tableHandler->renameTable($oldName, $newName);
            }
        }
    }

    /**
     * Change integer IPv4 column to varchar IPv6 capable
     *
     * @param string $tableName  table to convert
     * @param string $columnName column with IP address
     */
    private function convertIPAddresses($tableName, $columnName)

The method convertIPAddresses() is not used, and could be removed.

    {
        if ($this->tableHandler->useTable($tableName)) {
            $attributes = $this->tableHandler->getColumnAttributes($tableName, $columnName);
            if (false !== mb_strpos($attributes, ' int(')) {

It seems like $attributes can also be of type boolean; however, parameter $haystack of mb_strpos() does only seem to accept string, maybe add an additional type check?

                if (false === mb_strpos($attributes, 'unsigned')) {
                    $this->tableHandler->alterColumn($tableName, $columnName, " bigint(16) NOT NULL  DEFAULT '0' ");
                    $this->tableHandler->update($tableName, [$columnName => "4294967296 + $columnName"], "WHERE $columnName < 0", false);
                }
                $this->tableHandler->alterColumn($tableName, $columnName, " varchar(45)  NOT NULL  DEFAULT '' ");
                $this->tableHandler->update($tableName, [$columnName => "INET_NTOA($columnName)"], '', false);
            }
        }
    }

    /**
     * Move columns to another table
     */
    private function moveDoColumns()

The method moveDoColumns() is not used, and could be removed.

    {
        //for an example, see newbb 5.0
    }

    /**
     * Perform any upfront actions before synchronizing the schema
     *
     * Some typical uses include
     *   table and column renames
     *   data conversions
     */
    protected function preSyncActions()
    {
        // change table prefix
        if ($this->renameTables && \is_array($this->renameTables)) {
            $this->changePrefix();
        }
        //        // columns dohtml, dosmiley, doxcode, doimage and dobr moved between tables as some point
        //        $this->moveDoColumns();
        //        // Convert IP address columns from int to readable varchar(45) for IPv6
        //        $this->convertIPAddresses('extgallery_posts', 'poster_ip');
        //        $this->convertIPAddresses('extgallery_report', 'reporter_ip');
    }
}