ExtgalleryUtility::copyFile() - Code Metrics - Inspection of "Updates (Yoda, Helper, Traits)" - mambax7/extgallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 72613d...069c91 )

by Michael

created 2017-09-24 19:17 UTC

ExtgalleryUtility::copyFile() A

↳ Parent: ExtgalleryUtility::getModuleOption()

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0

<?php


use Xmf\Request;

require_once __DIR__ . '/common/traitversionchecks.php';
require_once __DIR__ . '/common/traitserverstats.php';
require_once __DIR__ . '/common/traitfilesmgmt.php';

//require_once __DIR__ . '/../include/common.php';

/**
 * Class ExtgalleryUtility
 */
class ExtgalleryUtility extends XoopsObject
namespace YourVendor;

class YourClass { }
{
    use VersionChecks; //checkVerXoops, checkVerPhp Traits

    use ServerStats; // getServerStats Trait

    use FilesManagement; // Files Management Trait


    /**
     * @param $option
     * @return bool|mixed
     */
    public static function getModuleOption($option)
    {
        global $xoopsModuleConfig, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
        static $tbloptions = [];
        if (is_array($tbloptions) && array_key_exists($option, $tbloptions)) {
            return $tbloptions[$option];
        }

        $retval = false;
        if (isset($xoopsModuleConfig)
            && (is_object($xoopsModule) && 'extgallery' === $xoopsModule->getVar('dirname')
                && $xoopsModule->getVar('isactive'))) {
            if (isset($xoopsModuleConfig[$option])) {
                $retval = $xoopsModuleConfig[$option];
            }
        } else {
            /** @var XoopsModuleHandler $moduleHandler */
            $moduleHandler = xoops_getHandler('module');
            $module        = $moduleHandler->getByDirname('extgallery');

            /** @var XoopsModuleHandler $moduleHandler */
            $configHandler = xoops_getHandler('config');
            if ($module) {
                $configurator = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
                if (isset($configurator[$option])) {
                    $retval = $configurator[$option];
                }
            }
        }
        $tbloptions[$option] = $retval;

        return $retval;
    }

    /**
     * @param $caption
     * @param $name
     * @param $value
     * @param $rows
     * @param $cols
     * @param $width
     * @param $height
     * @param $supplemental
     *
     * @return bool|XoopsFormEditor
     */
    public static function getWysiwygForm($caption, $name, $value, $rows, $cols, $width, $height, $supplemental)
    {
        $editor_option            = strtolower(static::getModuleOption('form_options'));
        $editor                   = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $editor_configs           = [];
        $editor_configs['name']   = $name;
        $editor_configs['value']  = $value;
        $editor_configs['rows']   = $rows;
        $editor_configs['cols']   = $cols;
        $editor_configs['width']  = $width;
        $editor_configs['height'] = $height;
        $editor_configs['editor'] = $editor_option;

        $editor = new XoopsFormEditor($caption, $name, $editor_configs);

        return $editor;
    }
}


Push — master ( 72613d...069c91 )

ExtgalleryUtility::copyFile() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-09-24 19:19 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 13 and the first side effect is on line 5. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			use Xmf\Request;
4
5			require_once __DIR__ . '/common/traitversionchecks.php';
6			require_once __DIR__ . '/common/traitserverstats.php';
7			require_once __DIR__ . '/common/traitfilesmgmt.php';
8
9			//require_once __DIR__ . '/../include/common.php';
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-09-24 19:19 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
10			/**
11			* Class ExtgalleryUtility
12			*/
13			class ExtgalleryUtility extends XoopsObject
			0 ignored issues – show Coding Style Compatibility introduced 2016-09-08 09:12 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
14			{
15			use VersionChecks; //checkVerXoops, checkVerPhp Traits
16
17			use ServerStats; // getServerStats Trait
18
19			use FilesManagement; // Files Management Trait
20
21
22			/**
23			* @param $option
24			* @return bool\|mixed
25			*/
26			public static function getModuleOption($option)
27			{
28			global $xoopsModuleConfig, $xoopsModule;
			0 ignored issues – show Compatibility Best Practice introduced 2016-09-08 09:12 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
29			static $tbloptions = [];
30			if (is_array($tbloptions) && array_key_exists($option, $tbloptions)) {
31			return $tbloptions[$option];
32			}
33
34			$retval = false;
35			if (isset($xoopsModuleConfig)
36			&& (is_object($xoopsModule) && 'extgallery' === $xoopsModule->getVar('dirname')
37			&& $xoopsModule->getVar('isactive'))) {
38			if (isset($xoopsModuleConfig[$option])) {
39			$retval = $xoopsModuleConfig[$option];
40			}
41			} else {
42			/** @var XoopsModuleHandler $moduleHandler */
43			$moduleHandler = xoops_getHandler('module');
44			$module = $moduleHandler->getByDirname('extgallery');
45
46			/** @var XoopsModuleHandler $moduleHandler */
47			$configHandler = xoops_getHandler('config');
48			if ($module) {
49			$configurator = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
50			if (isset($configurator[$option])) {
51			$retval = $configurator[$option];
52			}
53			}
54			}
55			$tbloptions[$option] = $retval;
56
57			return $retval;
58			}
59
60			/**
61			* @param $caption
62			* @param $name
63			* @param $value
64			* @param $rows
65			* @param $cols
66			* @param $width
67			* @param $height
68			* @param $supplemental
69			*
70			* @return bool\|XoopsFormEditor
71			*/
72			public static function getWysiwygForm($caption, $name, $value, $rows, $cols, $width, $height, $supplemental)
73			{
74			$editor_option = strtolower(static::getModuleOption('form_options'));
75			$editor = false;
			0 ignored issues – show Unused Code introduced 2016-09-08 09:12 UTC by Report Bug Copy Issue Report `$editor` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
76			$editor_configs = [];
77			$editor_configs['name'] = $name;
78			$editor_configs['value'] = $value;
79			$editor_configs['rows'] = $rows;
80			$editor_configs['cols'] = $cols;
81			$editor_configs['width'] = $width;
82			$editor_configs['height'] = $height;
83			$editor_configs['editor'] = $editor_option;
84
85			$editor = new XoopsFormEditor($caption, $name, $editor_configs);
86
87			return $editor;
88			}
89			}
90

mambax7 / extgallery

Push — master ( 72613d...069c91 )

ExtgalleryUtility::copyFile() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like