mambax7 /
extgallery
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like System often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use System, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 58 | class System |
||
| 59 | { |
||
| 60 | /** |
||
| 61 | * returns the commandline arguments of a function |
||
| 62 | * |
||
| 63 | * @param string $argv the commandline |
||
| 64 | * @param string $short_options the allowed option short-tags |
||
| 65 | * @param string $long_options the allowed option long-tags |
||
| 66 | * @return array the given options and there values |
||
| 67 | */ |
||
| 68 | public static function _parseArgs($argv, $short_options, $long_options = null) |
||
| 101 | |||
| 102 | /** |
||
| 103 | * Output errors with PHP trigger_error(). You can silence the errors |
||
| 104 | * with prefixing a "@" sign to the function call: @System::mkdir(..); |
||
| 105 | * |
||
| 106 | * @param mixed $error a PEAR error or a string with the error message |
||
| 107 | * @return bool false |
||
| 108 | */ |
||
| 109 | protected static function raiseError($error) |
||
| 118 | |||
| 119 | /** |
||
| 120 | * Creates a nested array representing the structure of a directory |
||
| 121 | * |
||
| 122 | * System::_dirToStruct('dir1', 0) => |
||
| 123 | * Array |
||
| 124 | * ( |
||
| 125 | * [dirs] => Array |
||
| 126 | * ( |
||
| 127 | * [0] => dir1 |
||
| 128 | * ) |
||
| 129 | * |
||
| 130 | * [files] => Array |
||
| 131 | * ( |
||
| 132 | * [0] => dir1/file2 |
||
| 133 | * [1] => dir1/file3 |
||
| 134 | * ) |
||
| 135 | * ) |
||
| 136 | * @param string $sPath Name of the directory |
||
| 137 | * @param integer $maxinst max. deep of the lookup |
||
| 138 | * @param integer $aktinst starting deep of the lookup |
||
| 139 | * @param bool $silent if true, do not emit errors. |
||
| 140 | * @return array the structure of the dir |
||
| 141 | */ |
||
| 142 | protected static function _dirToStruct($sPath, $maxinst, $aktinst = 0, $silent = false) |
||
| 177 | |||
| 178 | /** |
||
| 179 | * Creates a nested array representing the structure of a directory and files |
||
| 180 | * |
||
| 181 | * @param array $files Array listing files and dirs |
||
| 182 | * @return array |
||
| 183 | * @static |
||
| 184 | * @see System::_dirToStruct() |
||
| 185 | */ |
||
| 186 | protected static function _multipleToStruct($files) |
||
| 203 | |||
| 204 | /** |
||
| 205 | * The rm command for removing files. |
||
| 206 | * Supports multiple files and dirs and also recursive deletes |
||
| 207 | * |
||
| 208 | * @param string $args the arguments for rm |
||
| 209 | * @return mixed PEAR_Error or true for success |
||
| 210 | * @static |
||
| 211 | * @access public |
||
| 212 | */ |
||
| 213 | public static function rm($args) |
||
| 250 | |||
| 251 | /** |
||
| 252 | * Make directories. |
||
| 253 | * |
||
| 254 | * The -p option will create parent directories |
||
| 255 | * @param string $args the name of the director(y|ies) to create |
||
| 256 | * @return bool True for success |
||
| 257 | */ |
||
| 258 | public static function mkDir($args) |
||
| 313 | |||
| 314 | /** |
||
| 315 | * Concatenate files |
||
| 316 | * |
||
| 317 | * Usage: |
||
| 318 | * 1) $var = System::cat('sample.txt test.txt'); |
||
| 319 | * 2) System::cat('sample.txt test.txt > final.txt'); |
||
| 320 | * 3) System::cat('sample.txt test.txt >> final.txt'); |
||
| 321 | * |
||
| 322 | * Note: as the class use fopen, urls should work also (test that) |
||
| 323 | * |
||
| 324 | * @param string $args the arguments |
||
| 325 | * @return boolean true on success |
||
| 326 | */ |
||
| 327 | public static function &cat($args) |
||
| 378 | |||
| 379 | /** |
||
| 380 | * Creates temporary files or directories. This function will remove |
||
| 381 | * the created files when the scripts finish its execution. |
||
| 382 | * |
||
| 383 | * Usage: |
||
| 384 | * 1) $tempfile = System::mktemp("prefix"); |
||
| 385 | * 2) $tempdir = System::mktemp("-d prefix"); |
||
| 386 | * 3) $tempfile = System::mktemp(); |
||
| 387 | * 4) $tempfile = System::mktemp("-t /var/tmp prefix"); |
||
| 388 | * |
||
| 389 | * prefix -> The string that will be prepended to the temp name |
||
| 390 | * (defaults to "tmp"). |
||
| 391 | * -d -> A temporary dir will be created instead of a file. |
||
| 392 | * -t -> The target dir where the temporary (file|dir) will be created. If |
||
| 393 | * this param is missing by default the env vars TMP on Windows or |
||
| 394 | * TMPDIR in Unix will be used. If these vars are also missing |
||
| 395 | * c:\windows\temp or /tmp will be used. |
||
| 396 | * |
||
| 397 | * @param string $args The arguments |
||
| 398 | * @return mixed the full path of the created (file|dir) or false |
||
| 399 | * @see System::tmpdir() |
||
| 400 | */ |
||
| 401 | public static function mktemp($args = null) |
||
| 446 | |||
| 447 | /** |
||
| 448 | * Remove temporary files created my mkTemp. This function is executed |
||
| 449 | * at script shutdown time |
||
| 450 | */ |
||
| 451 | public static function _removeTmpFiles() |
||
| 460 | |||
| 461 | /** |
||
| 462 | * Get the path of the temporal directory set in the system |
||
| 463 | * by looking in its environments variables. |
||
| 464 | * Note: php.ini-recommended removes the "E" from the variables_order setting, |
||
| 465 | * making unavaible the $_ENV array, that s why we do tests with _ENV |
||
| 466 | * |
||
| 467 | * @return string The temporary directory on the system |
||
| 468 | */ |
||
| 469 | public static function tmpdir() |
||
| 493 | |||
| 494 | /** |
||
| 495 | * The "which" command (show the full path of a command) |
||
| 496 | * |
||
| 497 | * @param string $program The command to search for |
||
| 498 | * @param mixed $fallback Value to return if $program is not found |
||
| 499 | * |
||
| 500 | * @return mixed A string with the full path or false if not found |
||
| 501 | * @author Stig Bakken <[email protected]> |
||
| 502 | */ |
||
| 503 | public static function which($program, $fallback = false) |
||
| 544 | |||
| 545 | /** |
||
| 546 | * The "find" command |
||
| 547 | * |
||
| 548 | * Usage: |
||
| 549 | * |
||
| 550 | * System::find($dir); |
||
| 551 | * System::find("$dir -type d"); |
||
| 552 | * System::find("$dir -type f"); |
||
| 553 | * System::find("$dir -name *.php"); |
||
| 554 | * System::find("$dir -name *.php -name *.htm*"); |
||
| 555 | * System::find("$dir -maxdepth 1"); |
||
| 556 | * |
||
| 557 | * Params implemented: |
||
| 558 | * $dir -> Start the search at this directory |
||
| 559 | * -type d -> return only directories |
||
| 560 | * -type f -> return only files |
||
| 561 | * -maxdepth <n> -> max depth of recursion |
||
| 562 | * -name <pattern> -> search pattern (bash style). Multiple -name param allowed |
||
| 563 | * |
||
| 564 | * @param mixed Either array or string with the command line |
||
| 565 | * @return array Array of found files |
||
| 566 | */ |
||
| 567 | public static function find($args) |
||
| 631 | } |
||
| 632 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.