ExtgalleryPersistableObjectHandler - Code Metrics - Inspection of "updates" - mambax7/extgallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 32b1ca...48ec27 )

by Michael

created 2016-09-08 09:08 UTC

ExtgalleryPersistableObjectHandler C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	353
Duplicated Lines	24.08 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes	7
Bugs	0	Features	1

Metric	Value
c	7
b	0
f	1
dl	85
loc	353
rs	6.0975
wmc	60
lcom	2
cbo	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	2
A	create()	0	9	2
B	deleteById()	0	23	5
B	updateFieldValue()	3	13	5
A	_toObject()	0	18	3
C	objectToArray()	10	59	13
A	objectToArrayWithoutExternalKey()	0	12	3
A	updateCounter()	0	11	2
D	getSum()	34	35	10
D	getMax()	35	35	10
A	getAvg()	3	16	4
A	getInsertId()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like ExtgalleryPersistableObjectHandler often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use ExtgalleryPersistableObjectHandler, and based on these observations, apply Extract Interface, too.

<?php
/**
 * ExtGallery Class Manager
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @author      Zoullou (http://www.zoullou.net)
 * @package     ExtGallery
 */

/**
 * Persistable Object Handler class.
 * This class is responsible for providing data access mechanisms to the data source
 * of derived class objects.
 *
 * @author    Jan Keller Pedersen <[email protected]> - IDG Danmark A/S <www.idg.dk>
 * @copyright copyright (c) 2000-2004 XOOPS.org
 * @package   Kernel
 */
class ExtgalleryPersistableObjectHandler extends XoopsPersistableObjectHandler //XoopsObjectHandler
namespace YourVendor;

class YourClass { }
{
    /**#@+
     * Information about the class, the handler is managing
     *
     * @var string
     */
    public $table;
    public $keyName;
    public $className;
    public $identifierName;
    /**#@-*/

    /**
     * Constructor - called from child classes
     *
     * @param XoopsDatabase $db        {@link XoopsDatabase}
     *                                 object
     * @param string        $tablename Name of database table
     * @param string        $classname Name of Class, this handler is managing
     * @param string        $keyname   Name of the property, holding the key
     *
     * @param bool          $idenfierName
     *
     */

    public function __construct(XoopsDatabase $db, $tablename, $classname, $keyname, $idenfierName = false)
    {
        parent::__construct($db);
        //        $db = XoopsDatabaseFactory::getDatabaseConnection();

        $this->table     = $db->prefix($tablename);
        $this->keyName   = $keyname;
        $this->className = $classname;
        if (false !== $idenfierName) {
            $this->identifierName = $idenfierName;
        }
    }

    /**
     * create a new user
     *
     * @param bool $isNew Flag the new objects as "new"?
     *
     * @return XoopsObject
     */

    public function create($isNew = true)
    {
        $obj = new $this->className();
        if (true === $isNew) {
            $obj->setNew();
        }

        return $obj;
    }

    /**
     * delete an object from the database
     *
     * @param mixed $id id of the object to delete
     * @param  bool $force
     * @return bool        FALSE if failed.
     */
    public function deleteById($id, $force = false)
    {
        if (is_array($this->keyName)) {
            $clause = array();
            for ($i = 0, $iMax = count($this->keyName); $i < $iMax; ++$i) {
                $clause[] = $this->keyName[$i] . ' = ' . $id[$i];
            }
            $whereclause = implode(' AND ', $clause);
        } else {
            $whereclause = $this->keyName . ' = ' . $id;
        }
        $sql = 'DELETE FROM ' . $this->table . ' WHERE ' . $whereclause;
        if (false !== $force) {
            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }
        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * @param      $fieldname
     * @param      $fieldvalue
     * @param null $criteria
     * @param bool $force
     *
     * @return bool
     */
    public function updateFieldValue($fieldname, $fieldvalue, $criteria = null, $force = true)
    {
        $sql = 'UPDATE ' . $this->table . ' SET ' . $fieldname . ' = ' . $fieldvalue;
        if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();

        }
        $result = false !== $force ? $this->db->queryF($sql) : $this->db->query($sql);
        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * @param $data
     *
     * @return array

     */
    public function _toObject($data)
    {
        if (is_array($data)) {
            $ret = array();
            foreach ($data as $v) {
                $object = new $this->className();
                $object->assignVars($v);
                $ret[] = $object;
            }

            return $ret;
        } else {
            $object = new $this->className();
            $object->assignVars($v);
function someFunction() {
    $x = 5;
    echo $x;
}

            return $object;
        }
    }

    /**
     * @param        $objects
     * @param array  $externalKeys
     * @param string $format
     *
     * @return array
     */
    public function objectToArray($objects, $externalKeys = array(), $format = 's')
    {
        static $cached;

        $ret = array();
        if (is_array($objects)) {
            $i = 0;
            foreach ($objects as $object) {
                $vars = $object->getVars();
                foreach ($vars as $k => $v) {
                    $ret[$i][$k] = $object->getVar($k, $format);
                }
                foreach ($externalKeys as $key) {
                    // Replace external key by corresponding object
                    $externalKey = $object->getExternalKey($key);
                    if ($ret[$i][$key] != 0) {
                        // Retriving data if isn't cached
                        if (!isset($cached[$externalKey['keyName']][$ret[$i][$key]])) {
                            if ($externalKey['core']) {

                                $handler = xoops_getHandler($externalKey['className']);
                            } else {
                                $handler = xoops_getModuleHandler($externalKey['className'], 'extgallery');
                            }
                            $cached[$externalKey['keyName']][$ret[$i][$key]] = $this->objectToArrayWithoutExternalKey($handler->{$externalKey['getMethodeName']}($ret[$i][$key]),
                                                                                                                      $format);
                        }
                        $ret[$i][$externalKey['keyName']] = $cached[$externalKey['keyName']][$ret[$i][$key]];
                    }
                    unset($ret[$i][$key]);
                }
                ++$i;
            }
        } else {
            $vars = $objects->getVars();
            foreach ($vars as $k => $v) {
                $ret[$k] = $objects->getVar($k, $format);
            }
            foreach ($externalKeys as $key) {
                // Replace external key by corresponding object
                $externalKey = $objects->getExternalKey($key);
                if ($ret[$key] != 0) {
                    // Retriving data if isn't cached
                    if (!isset($cached[$externalKey['keyName']][$ret[$key]])) {
                        if ($externalKey['core']) {

                            $handler = xoops_getHandler($externalKey['className']);
                        } else {
                            $handler = xoops_getModuleHandler($externalKey['className'], 'extgallery');
                        }
                        $cached[$externalKey['keyName']][$ret[$key]] = $this->objectToArrayWithoutExternalKey($handler->{$externalKey['getMethodeName']}($ret[$key]),
                                                                                                              $format);
                    }
                    $ret[$externalKey['keyName']] = $cached[$externalKey['keyName']][$ret[$key]];
                }
                unset($ret[$key]);
            }
        }

        return $ret;
    }

    /**
     * @param        $object
     * @param string $format
     *
     * @return array
     */
    public function objectToArrayWithoutExternalKey($object, $format = 's')
    {
        $ret = array();
        if (null !== $object) {
            $vars = $object->getVars();
            foreach ($vars as $k => $v) {
                $ret[$k] = $object->getVar($k, $format);
            }
        }

        return $ret;
    }

    /**
     * @param        $fieldname
     * @param        $criteria
     * @param string $op
     *
     * @return bool
     */
    public function updateCounter($fieldname, $criteria, $op = '+')
    {
        $sql = 'UPDATE ' . $this->table . ' SET ' . $fieldname . ' = ' . $fieldname . $op . '1';
        $sql .= ' ' . $criteria->renderWhere();
        $result = $this->db->queryF($sql);
        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * @param null|CriteriaElement $criteria
     * @param string               $sum
     *
     * @return array|int|string
     */
    public function getSum(CriteriaElement $criteria = null, $sum = '*')

    {
        $field   = '';
        $groupby = false;
        if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
            if ($criteria->groupby != '') {
                $groupby = true;
                $field   = $criteria->groupby
                           . ', '; //Not entirely secure unless you KNOW that no criteria's groupby clause is going to be mis-used
            }
        }
        $sql = 'SELECT ' . $field . "SUM($sum) FROM " . $this->table;
        if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->groupby != '') {
                $sql .= $criteria->getGroupby();
            }
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        if ($groupby === false) {
            list($sum) = $this->db->fetchRow($result);

            return $sum;
        } else {
            $ret = array();
            while (list($id, $sum) = $this->db->fetchRow($result)) {
                $ret[$id] = $sum;
            }

            return $ret;
        }
    }

    /**
     * @param null|CriteriaElement $criteria
     * @param string               $max
     *
     * @return array|int|string
     */
    public function getMax(CriteriaElement $criteria = null, $max = '*')

    {
        $field   = '';
        $groupby = false;
        if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
            if ($criteria->groupby != '') {
                $groupby = true;
                $field   = $criteria->groupby
                           . ', '; //Not entirely secure unless you KNOW that no criteria's groupby clause is going to be mis-used
            }
        }
        $sql = 'SELECT ' . $field . "MAX($max) FROM " . $this->table;
        if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->groupby != '') {
                $sql .= $criteria->getGroupby();
            }
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        if (false === $groupby) {
            list($max) = $this->db->fetchRow($result);

            return $max;
        } else {
            $ret = array();
            while (list($id, $max) = $this->db->fetchRow($result)) {
                $ret[$id] = $max;
            }

            return $ret;
        }
    }

    /**
     * @param null|CriteriaElement $criteria
     * @param string               $avg
     *
     * @return int
     */
    public function getAvg(CriteriaElement $criteria = null, $avg = '*')
    {
        $field = '';

        $sql = 'SELECT ' . $field . "AVG($avg) FROM " . $this->table;
        if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        list($sum) = $this->db->fetchRow($result);

        return $sum;
    }

    /**
     * @return mixed
     */
    public function getInsertId()
    {
        return $this->db->getInsertId();
    }
}


1		<?php
2		/**
3		* ExtGallery Class Manager
4		*
5		* You may not change or alter any portion of this comment or credits
6		* of supporting developers from this source code or any supporting source code
7		* which is considered copyrighted (c) material of the original comment or credit authors.
8		* This program is distributed in the hope that it will be useful,
9		* but WITHOUT ANY WARRANTY; without even the implied warranty of
10		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11		*
12		* @copyright {@link http://xoops.org/ XOOPS Project}
13		* @license GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
14		* @author Zoullou (http://www.zoullou.net)
15		* @package ExtGallery
16		*/
17
18		/**
19		* Persistable Object Handler class.
20		* This class is responsible for providing data access mechanisms to the data source
21		* of derived class objects.
22		*
23		* @author Jan Keller Pedersen <[email protected]> - IDG Danmark A/S <www.idg.dk>
24		* @copyright copyright (c) 2000-2004 XOOPS.org
25		* @package Kernel
26		*/
27		class ExtgalleryPersistableObjectHandler extends XoopsPersistableObjectHandler //XoopsObjectHandler
		0 ignored issues – show Coding Style Compatibility introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
28		{
29		/**#@+
30		* Information about the class, the handler is managing
31		*
32		* @var string
33		*/
34		public $table;
35		public $keyName;
36		public $className;
37		public $identifierName;
38		/*#@-/
39
40		/**
41		* Constructor - called from child classes
42		*
43		* @param XoopsDatabase $db {@link XoopsDatabase}
44		* object
45		* @param string $tablename Name of database table
46		* @param string $classname Name of Class, this handler is managing
47		* @param string $keyname Name of the property, holding the key
48		*
49		* @param bool $idenfierName
50		*
51		*/
52
53		public function __construct(XoopsDatabase $db, $tablename, $classname, $keyname, $idenfierName = false)
54		{
55		parent::__construct($db);
56		// $db = XoopsDatabaseFactory::getDatabaseConnection();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report `46%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
57		$this->table = $db->prefix($tablename);
58		$this->keyName = $keyname;
59		$this->className = $classname;
60		if (false !== $idenfierName) {
61		$this->identifierName = $idenfierName;
62		}
63		}
64
65		/**
66		* create a new user
67		*
68		* @param bool $isNew Flag the new objects as "new"?
69		*
70		* @return XoopsObject
71		*/
72
73		public function create($isNew = true)
74		{
75		$obj = new $this->className();
76		if (true === $isNew) {
77		$obj->setNew();
78		}
79
80		return $obj;
81		}
82
83		/**
84		* delete an object from the database
85		*
86		* @param mixed $id id of the object to delete
87		* @param bool $force
88		* @return bool FALSE if failed.
89		*/
90		public function deleteById($id, $force = false)
91		{
92		if (is_array($this->keyName)) {
93		$clause = array();
94		for ($i = 0, $iMax = count($this->keyName); $i < $iMax; ++$i) {
95		$clause[] = $this->keyName[$i] . ' = ' . $id[$i];
96		}
97		$whereclause = implode(' AND ', $clause);
98		} else {
99		$whereclause = $this->keyName . ' = ' . $id;
100		}
101		$sql = 'DELETE FROM ' . $this->table . ' WHERE ' . $whereclause;
102		if (false !== $force) {
103		$result = $this->db->queryF($sql);
104		} else {
105		$result = $this->db->query($sql);
106		}
107		if (!$result) {
108		return false;
109		}
110
111		return true;
112		}
113
114		/**
115		* @param $fieldname
116		* @param $fieldvalue
117		* @param null $criteria
118		* @param bool $force
119		*
120		* @return bool
121		*/
122		public function updateFieldValue($fieldname, $fieldvalue, $criteria = null, $force = true)
123		{
124		$sql = 'UPDATE ' . $this->table . ' SET ' . $fieldname . ' = ' . $fieldvalue;
125	View Code Duplication	if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
		0 ignored issues – show Duplication introduced 2016-08-11 11:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126		$sql .= ' ' . $criteria->renderWhere();
		0 ignored issues – show Bug introduced 2016-08-11 11:13 UTC by Report Bug Copy Issue Report The method `renderWhere` cannot be called on `$criteria` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
127		}
128		$result = false !== $force ? $this->db->queryF($sql) : $this->db->query($sql);
129		if (!$result) {
130		return false;
131		}
132
133		return true;
134		}
135
136		/**
137		* @param $data
138		*
139		* @return array
		0 ignored issues – show Documentation introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report Should the return type not be `array\|object`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
140		*/
141		public function _toObject($data)
142		{
143		if (is_array($data)) {
144		$ret = array();
145		foreach ($data as $v) {
146		$object = new $this->className();
147		$object->assignVars($v);
148		$ret[] = $object;
149		}
150
151		return $ret;
152		} else {
153		$object = new $this->className();
154		$object->assignVars($v);
		0 ignored issues – show Bug introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report The variable `$v` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
155
156		return $object;
157		}
158		}
159
160		/**
161		* @param $objects
162		* @param array $externalKeys
163		* @param string $format
164		*
165		* @return array
166		*/
167		public function objectToArray($objects, $externalKeys = array(), $format = 's')
168		{
169		static $cached;
170
171		$ret = array();
172		if (is_array($objects)) {
173		$i = 0;
174		foreach ($objects as $object) {
175		$vars = $object->getVars();
176		foreach ($vars as $k => $v) {
177		$ret[$i][$k] = $object->getVar($k, $format);
178		}
179		foreach ($externalKeys as $key) {
180		// Replace external key by corresponding object
181		$externalKey = $object->getExternalKey($key);
182		if ($ret[$i][$key] != 0) {
183		// Retriving data if isn't cached
184		if (!isset($cached[$externalKey['keyName']][$ret[$i][$key]])) {
185	View Code Duplication	if ($externalKey['core']) {
		0 ignored issues – show Duplication introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
186		$handler = xoops_getHandler($externalKey['className']);
187		} else {
188		$handler = xoops_getModuleHandler($externalKey['className'], 'extgallery');
189		}
190		$cached[$externalKey['keyName']][$ret[$i][$key]] = $this->objectToArrayWithoutExternalKey($handler->{$externalKey['getMethodeName']}($ret[$i][$key]),
191		$format);
192		}
193		$ret[$i][$externalKey['keyName']] = $cached[$externalKey['keyName']][$ret[$i][$key]];
194		}
195		unset($ret[$i][$key]);
196		}
197		++$i;
198		}
199		} else {
200		$vars = $objects->getVars();
201		foreach ($vars as $k => $v) {
202		$ret[$k] = $objects->getVar($k, $format);
203		}
204		foreach ($externalKeys as $key) {
205		// Replace external key by corresponding object
206		$externalKey = $objects->getExternalKey($key);
207		if ($ret[$key] != 0) {
208		// Retriving data if isn't cached
209		if (!isset($cached[$externalKey['keyName']][$ret[$key]])) {
210	View Code Duplication	if ($externalKey['core']) {
		0 ignored issues – show Duplication introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
211		$handler = xoops_getHandler($externalKey['className']);
212		} else {
213		$handler = xoops_getModuleHandler($externalKey['className'], 'extgallery');
214		}
215		$cached[$externalKey['keyName']][$ret[$key]] = $this->objectToArrayWithoutExternalKey($handler->{$externalKey['getMethodeName']}($ret[$key]),
216		$format);
217		}
218		$ret[$externalKey['keyName']] = $cached[$externalKey['keyName']][$ret[$key]];
219		}
220		unset($ret[$key]);
221		}
222		}
223
224		return $ret;
225		}
226
227		/**
228		* @param $object
229		* @param string $format
230		*
231		* @return array
232		*/
233		public function objectToArrayWithoutExternalKey($object, $format = 's')
234		{
235		$ret = array();
236		if (null !== $object) {
237		$vars = $object->getVars();
238		foreach ($vars as $k => $v) {
239		$ret[$k] = $object->getVar($k, $format);
240		}
241		}
242
243		return $ret;
244		}
245
246		/**
247		* @param $fieldname
248		* @param $criteria
249		* @param string $op
250		*
251		* @return bool
252		*/
253		public function updateCounter($fieldname, $criteria, $op = '+')
254		{
255		$sql = 'UPDATE ' . $this->table . ' SET ' . $fieldname . ' = ' . $fieldname . $op . '1';
256		$sql .= ' ' . $criteria->renderWhere();
257		$result = $this->db->queryF($sql);
258		if (!$result) {
259		return false;
260		}
261
262		return true;
263		}
264
265		/**
266		* @param null\|CriteriaElement $criteria
267		* @param string $sum
268		*
269		* @return array\|int\|string
270		*/
271	View Code Duplication	public function getSum(CriteriaElement $criteria = null, $sum = '*')
		0 ignored issues – show Duplication introduced 2016-08-11 11:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
272		{
273		$field = '';
274		$groupby = false;
275		if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
276		if ($criteria->groupby != '') {
277		$groupby = true;
278		$field = $criteria->groupby
279		. ', '; //Not entirely secure unless you KNOW that no criteria's groupby clause is going to be mis-used
280		}
281		}
282		$sql = 'SELECT ' . $field . "SUM($sum) FROM " . $this->table;
283		if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
284		$sql .= ' ' . $criteria->renderWhere();
285		if ($criteria->groupby != '') {
286		$sql .= $criteria->getGroupby();
287		}
288		}
289		$result = $this->db->query($sql);
290		if (!$result) {
291		return 0;
292		}
293		if ($groupby === false) {
294		list($sum) = $this->db->fetchRow($result);
295
296		return $sum;
297		} else {
298		$ret = array();
299		while (list($id, $sum) = $this->db->fetchRow($result)) {
300		$ret[$id] = $sum;
301		}
302
303		return $ret;
304		}
305		}
306
307		/**
308		* @param null\|CriteriaElement $criteria
309		* @param string $max
310		*
311		* @return array\|int\|string
312		*/
313	View Code Duplication	public function getMax(CriteriaElement $criteria = null, $max = '*')
		0 ignored issues – show Duplication introduced 2016-08-11 11:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
314		{
315		$field = '';
316		$groupby = false;
317		if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
318		if ($criteria->groupby != '') {
319		$groupby = true;
320		$field = $criteria->groupby
321		. ', '; //Not entirely secure unless you KNOW that no criteria's groupby clause is going to be mis-used
322		}
323		}
324		$sql = 'SELECT ' . $field . "MAX($max) FROM " . $this->table;
325		if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
326		$sql .= ' ' . $criteria->renderWhere();
327		if ($criteria->groupby != '') {
328		$sql .= $criteria->getGroupby();
329		}
330		}
331		$result = $this->db->query($sql);
332		if (!$result) {
333		return 0;
334		}
335		if (false === $groupby) {
336		list($max) = $this->db->fetchRow($result);
337
338		return $max;
339		} else {
340		$ret = array();
341		while (list($id, $max) = $this->db->fetchRow($result)) {
342		$ret[$id] = $max;
343		}
344
345		return $ret;
346		}
347		}
348
349		/**
350		* @param null\|CriteriaElement $criteria
351		* @param string $avg
352		*
353		* @return int
354		*/
355		public function getAvg(CriteriaElement $criteria = null, $avg = '*')
356		{
357		$field = '';
358
359		$sql = 'SELECT ' . $field . "AVG($avg) FROM " . $this->table;
360	View Code Duplication	if (null !== $criteria && is_subclass_of($criteria, 'criteriaelement')) {
		0 ignored issues – show Duplication introduced 2016-08-11 11:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
361		$sql .= ' ' . $criteria->renderWhere();
362		}
363		$result = $this->db->query($sql);
364		if (!$result) {
365		return 0;
366		}
367		list($sum) = $this->db->fetchRow($result);
368
369		return $sum;
370		}
371
372		/**
373		* @return mixed
374		*/
375		public function getInsertId()
376		{
377		return $this->db->getInsertId();
378		}
379		}
380

mambax7 / extgallery